Re: [Mesa-dev] [PATCH] nvc0: fix line width on GM20x+

2018-04-20 Thread Pending Chaos
When both cso->line_smooth and cso->multisample are both false, this fixes the line rendering issue. So it seems it always uses LINE_WIDTH_SMOOTH. The alternative with the ">= GM204_3D" looks fine. On Fri, Apr 20, 2018 at 11:21 PM, Ilia Mirkin wrote: > On Fri, Apr 20, 2018 at 6:16 PM, Rhys Perry

Re: [Mesa-dev] [PATCH 1/4] mesa: add support for nvidia conservative rasterization extensions

2018-03-21 Thread Pending Chaos
The indentation error shall be fixed. no_error="true" does mean there's a separate no-error variant of the function. I create such variants for consistency with other functions in viewport.c On Wed, Mar 21, 2018 at 11:40 PM, Ilia Mirkin wrote: > On Wed, Mar 21, 2018 at 7:11 PM, pendingchaos >

Re: [Mesa-dev] [PATCH 4/4] nvc0: add conservative rasterization support

2018-03-21 Thread Pending Chaos
I haven't tested on Maxwell as I don't have easy access to one but I think I can do so sometime tomorrow. I'll gate on GM200 with the second revision of the patch-set. prec_bias should always fit in the max value of an immed, 2**12-1, as the maximum subpixel precision bias is 8 on GM200 and later