Re: [Mesa-dev] [PATCH] glsl: Fix function return typechecking

2019-02-21 Thread Oscar Blumberg
Hi, On Thu, Feb 21, 2019 at 10:35 AM Tapani Pälli wrote: > Hi; > > On 2/11/19 6:46 PM, Oscar Blumberg wrote: > > apply_implicit_conversion only converts and check base types but we > > need actual type equality for function returns, otherwise you can > > return a ve

[Mesa-dev] [PATCH] radeonsi: Fix guardband computation for large render targets

2019-02-12 Thread Oscar Blumberg
Stop using 12.12 quantization for viewports that are not contained in the lower 4k corner of the render target as the hardware needs to keep both absolute and relative coordinates representable. --- .../drivers/radeonsi/si_state_viewport.c | 30 +-- 1 file changed, 28 insertio

[Mesa-dev] [PATCH] glsl: Fix function return typechecking

2019-02-11 Thread Oscar Blumberg
apply_implicit_conversion only converts and check base types but we need actual type equality for function returns, otherwise you can return a vec2 from a function declared as returning a float. --- src/compiler/glsl/ast_to_hir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[Mesa-dev] [PATCH] intel/fs: Fix memory corruption when compiling a CS

2019-01-26 Thread Oscar Blumberg
Missing check for shader stage in the fs_visitor would corrupt the cs_prog_data.push information and trigger crashes / corruption later when uploading the CS state. --- src/intel/compiler/brw_fs_nir.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/compiler/brw