Re: [Mesa-dev] Mesa (master): glsl: Fix 'format not a string literal and no format arguments' warning.

On Thu, 16 Sep 2010 15:31:42 +0200, Ian Romanick wrote: > If __func__ is not showing up as a string literal, something else is > wrong. This is supposed to be a #define generated by the compiler. Actually, C99's __func__ is neither a macro nor a string literal: 6.4.2.2#1: The identifier __

[Mesa-dev] [PATCH] mesa: Use the format info to identify packed depth/stencil formats.

: Nick Bowler --- src/mesa/main/formats.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index c5f3e0b..112d7a0 100644 --- a/src/mesa/main/formats.c +++ b/src/mesa/main/formats.c @@ -945,13 +945,9

Re: [Mesa-dev] [PATCH v2] mesa: Identify packed depth/stencil buffers using the Format field.

On 8/26/10, Brian Paul wrote: > I added a missing semicolon after the prototype in formats.h and I > changed the return values to GL_TRUE/FALSE to be consistant. > Committed. Thanks. Whoops. I fixed the missing semicolon, but then forgot to change the commit id I passed to git send-email. Sorr

Re: [Mesa-dev] [PATCH 2/3] mesa: Use the _BaseFormat field to determine attachment completeness.

On 8/26/10, Brian Paul wrote: > This looks good. I'm not sure if there's a piglit test that would > exercise this. I prepared piglit tests for this and the other issue. Should I send them to this list as well? It's not obvious to me where the maintainer(s) want piglit patches sent. > Did you

[Mesa-dev] [PATCH v2] mesa: Identify packed depth/stencil buffers using the Format field.

er used to be made. This patch changes the logic to use the Format field instead, which is more like the old code. Fixes fdo bug 27590. Signed-off-by: Nick Bowler --- v2: Rewrite the helper function as a generic format helper. Suggested by Brian Paul. src/mesa/main/formats.c

[Mesa-dev] [PATCH 0/3] FBO fixes for intel.

t I am not sure whom I should send them to. Nick Bowler (3): mesa: Identify packed depth/stencil buffers using the Format field. mesa: Use the _BaseFormat field to determine attachment completeness. intel: Merge identical cases in switch statement. src/mesa/drivers/dri/intel/i

[Mesa-dev] [PATCH 1/3] mesa: Identify packed depth/stencil buffers using the Format field.

er used to be made. This patch changes the logic to use the Format field instead, which is more like the old code. Fixes fdo bug 27590. Signed-off-by: Nick Bowler --- src/mesa/main/framebuffer.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 2/3] mesa: Use the _BaseFormat field to determine attachment completeness.

-versa for GL_STENCIL_INDEX renderbuffers and the depth attachment). Performing such an attachment must yield an incomplete framebuffer. Since the renderbuffer struct has the actual base format stored in it, use that value instead of recomputing it incorrectly. Signed-off-by: Nick Bowler --- src

[Mesa-dev] [PATCH 3/3] intel: Merge identical cases in switch statement.

Signed-off-by: Nick Bowler --- src/mesa/drivers/dri/intel/intel_fbo.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c index 4a83886..2fdb6e4 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH] mesa: Fix GetUniformLocation while compiling display lists.

immediately when compiling display lists. Fixes fdo bug 29622. Signed-off-by: Nick Bowler --- src/mesa/main/dlist.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 727414d..5042e14 100644 --- a/src/mesa/main/dlist.c

[Mesa-dev] [PATCH] dri2: Track event mask in client code.

other clients. This is a fixed up version of the patch by Jesse Barnes, which drops BufferSwapComplete events if they are not requested by clients. Fixes fdo bug 27962. Signed-off-by: Nick Bowler --- src/glx/dri2.c|6 ++ src/glx/glx_pbuffer.c | 11 +++ src/glx/glxcli