Use pipe_shader_state_from_tgsi() to set shader state for transformed
shader so that we get all correct data for respective shader state.
This fixes several regressed glretrace, piglit crashes found during merging
upsteam mesa
Fixes: bf12bc2dd7a2 (draw: add nir info gathering and building support
Since we are now using sparse matrix for format_conversion_table,
we have to make sure we have last entry in table which gives the
sense of required size of format_conversion_table
Fixes: 84db6ba7 ("svga: Drop unsupported formats from the format table")
Reviewed-by: Charmaine Lee
---
src/galliu
Verify preconditions for copy_region_fallback() before using it, else
try cpu_blit if it fails to meet preconditions
Fixes crash with viewperf after merged-master-2019-12-10
Fixes: b30589cbd3dd ("mesa/st: Reuse st_choose_matching_format from
st_choose_format()")
Reviewed-by: Charmaine Lee https
With msvc compiler, enum is signed int. It caused failures with
piglit test and glretrace gl4_arb_tessellation_shader_v1
Fixes 84a1a2578dab ('compiler: pack shader_info from 160 bytes to 96 bytes')
Fixes vmware bug 2480550
Reviewed-by: Brian Paul
Reviewed-by: Charmaine Lee
---
src/compiler/sh
Since we are using st_common_variant while creating variant for vertext
program, we can release tokens created in st_create_vp_variant which
are already stored in respective states.
This fix memory leak found with piglit tests
Fixes bc99b22a305b ('st/mesa: use a separate VS variant for the draw mo
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, September 11, 2019 11:23 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; aio.olive...@intel.com
Subject: [PATCH] st/nir: fix illegal
LGTM
Reviewed-by: Neha Bhende
Regards,
Neha
From: Charmaine Lee
Sent: Thursday, August 1, 2019 3:56 PM
To: mesa-dev@lists.freedesktop.org; Brian Paul; Neha Bhende; Roland
Scheidegger; Jose Fonseca; airl...@redhat.com
Cc: Charmaine Lee
Subject: [PATCH
We need to free memory allocation PrimitiveOffsets in draw_gs_destroy().
This fixes memory leak found while running piglit on windows.
Fixes: 7720ce32a ("draw: add support to tgsi paths for geometry streams. (v2)")
Tested with piglit
Reviewed-by: Brian Paul
Reviewed-by: Charmaine Lee
---
src/
For series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, May 1, 2019 2:55 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; Deepak Singh Rawat; Thomas Hellstrom;
mesa-sta...@lists.freedesktop.org
Subject
LGTM
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, May 1, 2019 1:28 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Jose Fonseca; Charmaine Lee
Subject: [PATCH] glsl: work around MinGW 7.x compiler bug
I'm not
LGTM.
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Wednesday, May 1, 2019 9:48 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [Mesa-dev] [PATCH] llvmpipe: init some vars to NULL to silence MinGW
Looks reasonable to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Wednesday, May 1, 2019 9:48 AM
To: mesa-dev@lists.freedesktop.org
Cc: mesa-sta...@lists.freedesktop.org; Neha Bhende; Deepak Singh Rawat
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Friday, March 22, 2019 12:51 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [Mesa-dev] [PATCH] st/mesa: fix texture deletion context
Thanks for the fix!
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 21, 2019 6:19 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH] st/mesa: fix texture deletion context mix-up issues
When we destroy
Looks great!
For series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 14, 2019 12:37 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Jose Fonseca; Roland Scheidegger; Mathias Fröhlich
Subject: [PATCH 8/8] gallium
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Friday, March 8, 2019 9:14 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [Mesa-dev] [PATCH] st/mesa: init hash keys with memset(), not
designated
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Thursday, March 7, 2019 6:45 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Deepak Singh Rawat
Subject: [Mesa-dev] [PATCH] svga: remove SVGA_RELOC_READ flag in
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, March 8, 2019 7:52 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH 5/5] st/mesa: minor refactoring of texture/sampler delete code
Rename
Looks good to me.
Just one nit pick,
In definition of validate_index_buffer, extra space is required in argument
list.
Reviewed-by: Neha Bhende
Regards,
Neha
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 7, 2019 3:23 PM
To: mesa-dev
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 7, 2019 8:20 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH] st/mesa: move, clean-up shader variant key decls/inits
Move the variant key declarations inside
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Tuesday, March 5, 2019 7:48 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Deepak Singh Rawat; Thomas Hellstrom
Subject: [PATCH 3/3] winsys/svga: use new pb_usage_flags
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Monday, March 4, 2019 9:20 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH 2/2] svga: silence array out of bounds warning
MinGW release build
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Saturday, March 2, 2019 10:28 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH] st/wgl: init a variable to silence MinGW warning
MinGW release build says 'value' m
This caused vmware driver build failure
Fixes: 6010d7b8e8 ("gallium: add PIPE_CAP_MAX_VARYINGS")
---
src/gallium/drivers/svga/svga_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/svga/svga_screen.c
b/src/gallium/drivers/svga/svga_screen.c
index 6c
Looks good.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Monday, February 25, 2019 7:13 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende
Subject: [PATCH] svga: fix dma.pending > 0 test
The dma.pending field is boolean, so testing
Thanks Brian and Ilia for the review.
Regards,
Neha
From: Ilia Mirkin
Sent: Tuesday, January 29, 2019 1:20:50 PM
To: Brian Paul
Cc: Neha Bhende; mesa-dev@lists.freedesktop.org
Subject: Re: [Review Request (master branch)] st/mesa: Fix
topogun-1.06-orc-84k
We need to initialize all fields in rs->prim explicitly while
creating new rastpos stage.
Fixes: bac8534267 ("st/mesa: allow glDrawElements to work with GL_SELECT
feedback")
v2: Initializing all fields in rs->prim as per Ilia.
Reviewed-by: Brian Paul
---
src/mesa/state_tracker/st_cb_rasterpos.
rt_count;
exec->vtx.prim[i].count = 0;
exec->vtx.prim[i].num_instances = 1;
exec->vtx.prim[i].base_instance = 0;
exec->vtx.prim[i].is_indirect = 0;
I do think that your change is all that's strictly needed though.
Sorry about the breakage!
On Tue, Jan 29, 2019 at 1:31
This patch fixes regression caused by
bac8534267- st/mesa: allow glDrawElements to work with GL_SELECT feedback
We also need to set instance count while creating new rastpos stage.
Reviewed-by: Brian Paul
---
src/mesa/state_tracker/st_cb_rasterpos.c | 1 +
1 file changed, 1 insertion(+)
diff --
Looks good
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Tuesday, January 22, 2019 11:31:13 AM
To: mesa-dev@lists.freedesktop.org
Cc: Jose Fonseca; Neha Bhende; Marek Olšák
Subject: [PATCH] svga: add new gallium formats to the format
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Tuesday, October 9, 2018 8:06:26 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: change svga_destroy_shader_variant() to return void
Looks good.
For series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, July 27, 2018 12:07:50 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] swrast: fix crash in AA line code when there'
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Charmaine Lee
Sent: Friday, July 6, 2018 4:09:02 PM
To: mesa-dev@lists.freedesktop.org
Cc: Brian Paul; Neha Bhende; Charmaine Lee
Subject: [PATCH] st/wgl: check for NULL piAttribList in
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, May 17, 2018 1:06:26 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende; Roland Scheidegger
Subject: [PATCH] tgsi: fix incorrect tgsi_shader_info::num_tokens computation
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, April 13, 2018 9:03:41 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 3/3] glsl: #undef THIS macro to fix MSVC build
THIS is a macro
Reviewed-by: Neha Bhende
From: Brian Paul
Sent: Thursday, March 29, 2018 9:02:45 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH] nir: s/uint/unsigned/ to fix MSVC/MinGW build
---
src/compiler/glsl/glsl_to_nir.cpp | 2
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 22, 2018 8:28:52 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH 2/2] svga: simplify uses_flat_interp expression in
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, March 22, 2018 8:29:16 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH 3/3] st/mesa: s/unsigned/enum pipe_shader_type/ for
Looks good.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, February 14, 2018 1:53:52 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: s/unsigned/enum pipe_shader_type/
---
src/gallium
For the series,
Reviewed-by: Neha Bhende
From: Brian Paul
Sent: Wednesday, January 31, 2018 7:37:23 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 4/4] svga: remove unneeded #includes in svga_pipe_draw.c
---
src/gallium
For series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, January 26, 2018 8:39:18 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 3/3] mesa: remove MESA_FUNCTION
Just use __func__ in the two
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, January 25, 2018 4:29:05 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] mesa: silence MinGW 'may be unused uninitialized' warning in
Looks good.
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, January 25, 2018 8:48:00 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; Roland Scheidegger
Subject: [PATCH 3/3] mesa: whitespace fixes
Looks good.
Reviewed-by: Neha Bhende
From: Brian Paul
Sent: Friday, January 12, 2018 2:22:07 PM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH] svga: add num-commands-per-draw HUD query
This query shows the ratio of total
Looks good.
Reviewed-by: Neha Bhende
From: Brian Paul
Sent: Thursday, December 28, 2017 8:19:24 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: check for null fs pointer in update_samplers()
This can happen when
Looks good.
Reviewed-by : Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, December 27, 2017 12:38:53 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] st/mesa: increase size of glsl_base_type bitfields
Change
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Saturday, December 23, 2017 9:13 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix TGSI_TEXTURE_SHADOW1D coordinate selection
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Sunday, December 24, 2017 2:40:28 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: use tgsi_util_get_shadow_ref_src_index() in a
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: mesa-dev on behalf of Brian Paul
Sent: Friday, November 10, 2017 6:40:26 PM
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided
Looks good.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Monday, July 17, 2017 11:28:43 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] mesa: fix GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION_EXT query
This
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Monday, July 10, 2017 2:50:25 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/
---
src/gallium
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, June 28, 2017 3:44:35 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: update a few surface format names
To sync with in
For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, June 16, 2017 3:39:12 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: add new num-failed-allocations HUD query
This counter
Looks good to me. For the series,
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, May 3, 2017 12:49:40 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] wglgears: fix up wglChoosePixelFormatARB
series looks good to me.
Reviewed-by : Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Thursday, April 27, 2017 10:19:07 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] wglinfo: query/print sRGB and float pixel
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, April 26, 2017 8:28:02 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] st/mesa: minor clean-ups in st_update_renderbuffer_surface
Series looks good me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Friday, August 26, 2016 8:27:18 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Jose Fonseca
Subject: [PATCH 14/14] svga: move some code in svga_propagate_surface
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Brian Paul
Sent: Wednesday, August 17, 2016 7:40:13 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix src/dst typo in
58 matches
Mail list logo
