Re: [Mesa-dev] Rename "master" branch to "main"?

2020-08-03 Thread Mike Lothian
On Mon, 3 Aug 2020 at 18:42, Erik Faye-Lund wrote: > > On Mon, 2020-08-03 at 10:30 -0500, Jason Ekstrand wrote: > > All, > > > > I'm sure by now you've all seen the articles, LKML mails, and other > > chatter around inclusive language in software. While mesa doesn't > > provide a whole lot of doc

[Mesa-dev] [PATCH] meson: Always include 'coroutines' in llvm optional modules

2019-09-07 Thread Mike Lothian
Without this I get build failures: error: undefined reference to 'LLVMAddCoroEarlyPass' error: undefined reference to 'LLVMAddCoroSplitPass' error: undefined reference to 'LLVMAddCoroElidePass' error: undefined reference to 'LLVMAddCoroCleanupPass' Cc:

Re: [Mesa-dev] [PATCH 0/7] panfrost: GLES3 textures (and primitive restart)

2019-06-27 Thread Mike Lothian
Hi Are there plans to add Panfrost to docs/features.txt? Cheers Mike On Thu, 27 Jun 2019 at 14:13, Alyssa Rosenzweig wrote: > > Just a bit of potpourrie of low-hanging fruit for GLES3 features, e.g. > floating-point textures and ES-class primitive restart. > > Alyssa Rosenzweig (7): > panfro

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-21 Thread Mike Lothian
Can someone with access revert from master until this is fixed? It's been broken for 3 days now On Tue, 21 May 2019 at 09:01, Juan A. Suarez Romero wrote: > > On Tue, 2019-05-21 at 09:36 +0200, Gert Wollny wrote: > > Hi Marek, > > > > it seems that this patch is causing a few issues [1], any idea

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-20 Thread Mike Lothian
I managed to trigger the bug remotely using that branch :( On Mon, 20 May 2019 at 09:03, Juan A. Suarez Romero wrote: > > On Sat, 2019-05-18 at 15:52 +0100, Mike Lothian wrote: > > This patch is causing strange behaviour for me (and someone else on > > IRC) on my Raven syst

Re: [Mesa-dev] [PATCH 2/2] radeonsi: update buffer descriptors in all contexts after buffer invalidation

2019-05-18 Thread Mike Lothian
This patch is causing strange behaviour for me (and someone else on IRC) on my Raven system May 18 15:31:43 quark kwin_x11[607]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 2825, resource id: 37748896, major code: 18 (ChangeProperty), minor code: 0 May 18 15:31:44 quark systems

Re: [Mesa-dev] [PATCH 0/5] RadeonSI: Displayable DCC for Ravens

2019-03-01 Thread Mike Lothian
Thanks, I notice your 5.2-wip is version 3.30.0, so I'll wait until it's updated before testing Cheers Mike On Fri, 1 Mar 2019 at 15:17, Alex Deucher wrote: > > On Fri, Mar 1, 2019 at 10:11 AM Mike Lothian wrote: > > > > Hi > > > > What do you mean by k

Re: [Mesa-dev] [PATCH 0/5] RadeonSI: Displayable DCC for Ravens

2019-03-01 Thread Mike Lothian
Hi What do you mean by kernel driver version? It doesn't seem to match up with a kernel version or a DC Version Cheers Mike On Thu, 28 Feb 2019 at 21:20, Marek Olšák wrote: > > Hi, > > This series enables DCC for scanout on Ravens. > > It requires kernel driver version >= 3.31.0 and my xf86-vi

Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement

2019-02-04 Thread Mike Lothian
I'm a bit confused by this patch It's in a section called xlib_lease, for leases to work I think the newer version is required, but I think the underlying code was changed to build without the newer headers Do leases work with the old code, or should this section be renamed? On Sun, 3 Feb 2019 a

Re: [Mesa-dev] [PATCH] radv: take LDS into account for compute shader occupancy stats

2019-02-01 Thread Mike Lothian
Hi I think you've left a few references to the old ac_nir_get_max_workgroup_size FAILED: src/amd/vulkan/9198681@@vulkan_radeon@sha/radv_nir_to_llvm.c.o x86_64-pc-linux-gnu-gcc -m32 -Isrc/amd/vulkan/9198681@@vulkan_radeon@sha -Isrc/amd/vulkan -I../mesa-/src/amd/vulkan -Isrc/../include -I../mes

Re: [Mesa-dev] [PATCH 2/3] winsys/amdgpu: add support for allocating GDS and OA resources

2018-11-26 Thread Mike Lothian
Same for OA Cheers Mike On Tue, 27 Nov 2018, 01:57 Marek Olšák, wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/radeon_winsys.h | 4 +- > src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 55 +- > 2 files changed, 36 insertions(+), 23 deletions(-) > > diff --g

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-26 Thread Mike Lothian
Hi What's GDS and IB stand for? Thanks Mike On Tue, 27 Nov 2018, 01:57 Marek Olšák, wrote: > From: Marek Olšák > > --- > .../drivers/radeonsi/si_compute_blit.c| 4 +- > src/gallium/drivers/radeonsi/si_cp_dma.c | 49 ++- > src/gallium/drivers/radeonsi/si_pipe.h

Re: [Mesa-dev] [PATCH] loader/dri3: Also wait for front buffer fence if we triggered it

2018-10-11 Thread Mike Lothian
I'm still seeing weird graphical corruptions in chrome and sometimes when playing video It's especially noticeable when in inbox.google.com I might be suffering from a different issue however On Thu, 11 Oct 2018 at 11:43 Mike Lothian wrote: > Do you think this why I've b

Re: [Mesa-dev] [PATCH] loader/dri3: Also wait for front buffer fence if we triggered it

2018-10-11 Thread Mike Lothian
Do you think this why I've been seeing lots of weird flashing in Chrome recently? I'll test this patch out tonight and give you my tested by if you like On Thu, 11 Oct 2018 at 09:27 Michel Dänzer wrote: > > Any feedback? Without negative feedback, I'll push this fix tomorrow. > > > On 2018-10-0

Re: [Mesa-dev] [PATCH] docs/features: add EXT_direct_state_access features

2018-09-18 Thread Mike Lothian
You might want to remove the " we DO NOT WANT implementations of these extensions for Mesa" if you're planning on implementing them On Tue, 18 Sep 2018 at 10:48 Timothy Arceri wrote: > Acked-by: Timothy Arceri > > On 18/9/18 1:31 pm, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > d

Re: [Mesa-dev] [PATCH 1/2] loader/dri3: Only wait for back buffer fences in dri3_get_buffer

2018-09-11 Thread Mike Lothian
Hi If this is prime related I can test it tonight for you Cheers Mike On Tue, 11 Sep 2018 at 14:06 Thomas Hellstrom wrote: > > On 09/11/2018 02:41 PM, Michel Dänzer wrote: > > Any feedback on this patch? Without negative feedback, I'll push it > > later this week. > Hi, Michel, > > This looks

Re: [Mesa-dev] [PATCH] radv: add Doom workaround

2018-08-15 Thread Mike Lothian
Do you need the game name here, isn't that set in driconf? On Wed, 15 Aug 2018 at 12:12 Timothy Arceri wrote: > Cc: > --- > src/amd/vulkan/radv_device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 33f24b9d302..

[Mesa-dev] libdrm: Fix amdgpu build failure

2018-08-07 Thread Mike Lothian
Hi I'm not sure if this is the right mailing list or not but the following patch gets things building with meson again Signed-of-by: Mike Lothian diff --git a/amdgpu/meson.build b/amdgpu/meson.build index f39d7bf6..d9d7de2d 100644 --- a/amdgpu/meson.build +++ b/amdgpu/meson.build @@

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
might have what you're after On Thu, 2 Aug 2018 at 18:00 Guang Bai wrote: > On Thu, 2 Aug 2018 17:55:21 +0100 > Mike Lothian wrote: > > > Which distro are you using? > > uBuntu-14.045 & uBuntu-16.04 > Thanks, > Guang > > > > > On Thu, 2 Aug 2018

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Which distro are you using? On Thu, 2 Aug 2018 at 17:35 Guang Bai wrote: > This is the reason for me to look for helps from our mesa-dev community. > Thanks, > Guang > > On Thu, 2 Aug 2018 17:10:16 +0100 > Mike Lothian wrote: > > > Yeah the lease stuff was added

Re: [Mesa-dev] Mesa master branch vulkan/build question

2018-08-02 Thread Mike Lothian
Hi It would be helpful if you posted the failure output, without it its difficult to diagnose I'm not seeing any issues with the master branch on the meson build Is this your first time building mesa, or has something suddenly stopped working? Cheers Mike On Thu, 2 Aug 2018 at 16:46 Guang Bai

Re: [Mesa-dev] [PATCH 0/7] ASTC texture compression for all Gallium drivers

2018-07-25 Thread Mike Lothian
Feel free to add my tested by: Tested-by: Mike Lothian Cheers Mike On Tue, 24 Jul 2018 at 00:52 Marek Olšák wrote: > Hi, > > This series enables ASTC texture compression for all Gallium drivers > that don't support it in hardware. The works the same as the ETC2 &g

[Mesa-dev] Broken Tags

2018-07-17 Thread Mike Lothian
Hi Is there any change the following tags could be deleted (and recreated if required) from the git repo: R300_DRIVER_0 before_upgrade_03_01_05 blended_fountain embedded-1-20030120 embedded-1-20030224 embedded-1-20030305 embedded-1-20030324 embedded-1-20030417 embedded-1-20030502 gliding_penguin

Re: [Mesa-dev] Radeonsi OpenGL 4.4 compat profile support

2018-06-28 Thread Mike Lothian
he other 2 games that have this option set) Tested-by: Mike Lothian Thanks again for this On Thu, 28 Jun 2018 at 07:47 Timothy Arceri wrote: > Sorry to keep spamming the list with this stuff, but Dave helped > out with ARB_vertex_attrib_64bit support and the spec bug I > submitted f

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-25 Thread Mike Lothian
Hi I can confirm I no longer need to pass MESA_GL_VERSION_OVERRIDE to Dying Light Tested-by: Mike Lothian Cheers Mike On Tue, 26 Jun 2018 at 04:41 Dieter Nützel wrote: > Am 25.06.2018 13:26, schrieb Timothy Arceri: > > Please note I've fixed up make check where is was broken

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-25 Thread Mike Lothian
I'll test these tonight, Dying Light in particular required an override - hopefully that won't be necessary any more On Mon, 25 Jun 2018 at 12:26 Timothy Arceri wrote: > Please note I've fixed up make check where is was broken when enabling > some of these extensions. You can see all of the late

Re: [Mesa-dev] Enable/fix a bunch of OpenGL 4.0-4.3 extensions for compat profile

2018-06-22 Thread Mike Lothian
I think you forgot to bump PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY to 430 On Fri, 22 Jun 2018 at 09:48 Timothy Arceri wrote: > I've send all of these patches out already. The only change is to the > first 2 patches which fixes things so we store a double as 2 unsigned ints > rather than 2 floa

Re: [Mesa-dev] [PATCH 1/2] mesa: remove drirc workarounds for Worms, Tropico 5 and Crookz

2018-06-22 Thread Mike Lothian
rsion: 1.1 Max GLES[23] profile version: 3.1 On Fri, 22 Jun 2018 at 14:28 Mike Lothian wrote: > Hi > > Does the whole of mesa support that or just radeonsi? > > Cheers > > Mike > > On Fri, 22 Jun 2018 at 14:10 Samuel Pitoiset > wrote: > >> Since mesa

Re: [Mesa-dev] [PATCH 1/2] mesa: remove drirc workarounds for Worms, Tropico 5 and Crookz

2018-06-22 Thread Mike Lothian
Hi Does the whole of mesa support that or just radeonsi? Cheers Mike On Fri, 22 Jun 2018 at 14:10 Samuel Pitoiset wrote: > Since mesa now exposes OpenGL 3.3 compat, we no longer need > those workarounds. > > Signed-off-by: Samuel Pitoiset > --- > src/util/drirc | 12 > 1 file c

[Mesa-dev] [PATCH] meson: allow x86 asm on x86_64 cross compiles

2018-06-07 Thread Mike Lothian
This patch allows building asm for x86 on x86_64 cross compiles Fixes: 2d62fc064652 ("meson: disable x86 asm in fewer cases.") Signed-off-by: Mike Lothian --- If you're happy with this change, please can you commit it as I don't have access --- meson.build | 2 +- 1 file

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-07 Thread Mike Lothian
Hi Is it possible to get all 3 gears lined up under the points of the "M" and have the 3rd gear go under the "e" if need be Cheers Mike On Thu, 7 Jun 2018 at 10:02 Erik Faye-Lund wrote: > Just as a fun toy, I decided to give an animated SVG "variation" of > this a go myself: > > https://codep

Re: [Mesa-dev] [PATCH 4/5] egl/wayland: Allow client->server format conversion for PRIME offload.

2018-05-23 Thread Mike Lothian
Hi Mario Can you explain how I can test this? I'll test it out on an Intel+AMD system Cheers Mike On Wed, 23 May 2018 at 05:51 Mario Kleiner wrote: > On Mon, May 21, 2018 at 4:42 PM, Eric Engestrom > wrote: > > On Saturday, 2018-05-19 05:32:41 +0200, Mario Kleiner wrote: > >> Support PRIME r

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

2018-05-19 Thread Mike Lothian
I had hoped this would land in 18.1.0 Any signs of a review and can we get this backported asap? On Wed, 16 May 2018, 15:49 Michel Dänzer, wrote: > On 2018-05-16 01:39 PM, Mike Lothian wrote: > > Can this be added to stable too? > > Right, I meant add that but forgot, thanks f

Re: [Mesa-dev] [PATCH] dri3: Stricter SBC wraparound handling

2018-05-16 Thread Mike Lothian
Can this be added to stable too? On Wed, 16 May 2018 at 10:33 Michel Dänzer wrote: > On 2018-05-16 11:14 AM, Axel Davy wrote: > > Hi, > > > > Shouldn't this be fixed on the xserver or the ddx side, rather than in > > Mesa ? > No, it's a Mesa bug, the X server is doing what it's asked. (This wasn

Re: [Mesa-dev] [PATCH] glx/dri: Take an extra reference on our own GLX drawables

2018-05-09 Thread Mike Lothian
With Michel's suggestion I've not seen a freeze in Plasmashell or Steam so far Tested-by: Mike Lothian On Wed, 9 May 2018 at 21:47 Mike Lothian wrote: > On Tue, 8 May 2018 at 20:47 Adam Jackson wrote: > >> dri*_bind_context, when switching current drawables, will drop t

Re: [Mesa-dev] [PATCH] glx/dri: Take an extra reference on our own GLX drawables

2018-05-09 Thread Mike Lothian
ution, but in the > meantime this is effectively not a memory leak for any real scenario, > and fixes a real bug. > > Signed-off-by: Adam Jackson > Cc: Michel Dänzer > Cc: Mike Lothian > Cc: Mario Kleiner > Cc: Tobias Klausmann > Bugzilla: https://bugs.freedesktop.o

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
Thank you for the clarification. On Sat, 5 May 2018 at 14:31 Daniel Stone wrote: > On 5 May 2018 at 10:15, Mike Lothian wrote: > > Out of interest can you try running the vulkan smoketest, I'm seeing > this: > > > > smoketest > > terminate called

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
Which is: VK_ERROR_OUT_OF_DATE_KHR = -101004, On Sat, 5 May 2018 at 10:15 Mike Lothian wrote: > Out of interest can you try running the vulkan smoketest, I'm seeing this: > > smoketest > terminate called after throwing an instance of 'std::runtime_error' >

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Mike Lothian
ay 5, 2018 at 4:08 AM, Mike Lothian wrote: > > I definately saw the steam bug with patch 1 but not with plasmashell, > > I started seeing it with patch 2 but it seemed to fix itself > > > > I had two hangs of kwin_x11 within the last 6 hours when alt-tabbing &g

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
d eid %d\n", draw->width, draw->height, draw->drawable, draw->eid); } dri3_flush_present_events(draw); mtx_unlock(&draw->mtx); -- 2.17.0 On 4 May 2018 at 17:54, Mario Kleiner wrote: > On Fri, May 4, 2018 at 6:45 PM, Mike Lothian wrote: >> H

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi Yes I've not seen any freezes with Plasmashell, so a big improvement Had issues with patch 2 Cheers Mike On 4 May 2018 at 17:36, Mario Kleiner wrote: > On Fri, May 4, 2018 at 6:31 PM, Mike Lothian wrote: >> Hi >> >> I'm still seeing the freeze in t

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi The first hunk doesn't apply, the other 3 gives this with GCC 8.1 ../mesa-/src/loader/loader_dri3_helper.c: In function ‘dri3_handle_present_event’: ../mesa-/src/loader/loader_dri3_helper.c:376:13: error: implicit declaration of function ‘printf’ [-Werror=implicit-function-declaration

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi I'm still seeing the freeze in the Steam client with this patch Just about to test the other one Mike On 4 May 2018 at 17:17, Mike Lothian wrote: > Hi Mario > > Again thanks for looking into this issue :D > > Tested-by: Mike Lothian > > I'll give the oth

Re: [Mesa-dev] [PATCH 1/2] loader_dri3: Wait for pending swaps to complete before drawable_fini.

2018-05-04 Thread Mike Lothian
Hi Mario Again thanks for looking into this issue :D Tested-by: Mike Lothian I'll give the other patch a whirl now Cheers Mike On 4 May 2018 at 14:45, Mario Kleiner wrote: > Before destroying the loader_dri3_drawable, make sure all pending > swaps for it have completed. This gui

Re: [Mesa-dev] [PATCH] meson: Fix with_intel_vk and with_amd_vk variables

2018-04-24 Thread Mike Lothian
Can you also add radeon to the amd one? That works on autotools On Wed, 25 Apr 2018 at 02:16 Jordan Justen wrote: > Fixes: 5608d0a2cee "meson: use array type options" > Cc: Dylan Baker > Signed-off-by: Jordan Justen > --- > meson.build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

[Mesa-dev] [PATCH] meson: Build st_tests_common with gtest

2018-04-19 Thread Mike Lothian
Fixes: 34cb4d0ebc1 ("meson: build tests for gallium mesa state tracker") Signed-off-by: Mike Lothian --- src/mesa/state_tracker/tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/tests/meson.build b/src/mesa/state_tra

Re: [Mesa-dev] [PATCH v3 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-04 Thread Mike Lothian
Are you able to push this for me on my behalf? On Wed, 4 Apr 2018 at 15:04 Kyriazis, George wrote: > Thank you! > > Reviewed-By: George Kyriazis > > On Apr 4, 2018, at 3:22 AM, Mike Lothian wrote: > > Include llvm/Transforms/Utils.h with the newest LLVM 7 > > v2: I

[Mesa-dev] [PATCH v3 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-04 Thread Mike Lothian
Include llvm/Transforms/Utils.h with the newest LLVM 7 v2: Include with " " rather than < > (Vinson Lee) v3: Use LLVM_VERSION_MAJOR rather than HAVE_LLVM (George Kyriazis) Signed-of-by: Mike Lothian Tested-by: Vinson Lee --- src/gallium/drivers/swr/rasterizer/jitter/jit_pc

[Mesa-dev] [PATCH v2 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Include llvm/Transforms/Utils.h with the newest LLVM 7 v2: Include with " " rather than < > Signed-of-by: Mike Lothian Tested-by: Vinson Lee --- src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/driver

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Thanks for pointing that out I've sent a 4th patch, I've never compiled swr before, would you mind testing to see if it fixes things for you, it's using the llvm include rather than the llvm-c include On Sun, 1 Apr 2018 at 06:15 Vinson Lee wrote: > On Sat, Mar 31, 2018 at 5:0

[Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

2018-04-01 Thread Mike Lothian
Include llvm/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian --- src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp b/src/gallium/drivers/swr/rasterizer/jitter

[Mesa-dev] [PATCH 3/3] gallivm: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian Reviewed-by: Samuel Pitoiset Tested-by: Dieter Nützel --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src

[Mesa-dev] [PATCH 2/3] radeonsi: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian Reviewed-by: Samuel Pitoiset Tested-by: Dieter Nützel --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 1/3] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Signed-of-by: Mike Lothian Reviewed-by: Samuel Pitoiset Tested-by: Dieter Nützel --- src/amd/vulkan/radv_nir_to_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan

[Mesa-dev] [PATCH 0/3] Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
Hi I've split this into three patches, one for each area affected I think I've got the right prefixes now I've also removed the fixes line and included the testing and reviewed by tags Hope that's OK and again if you're happy with this please can you commit as I don't have git rights Thanks M

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
On 1 April 2018 at 00:03, Vinson Lee wrote: > > A similar change is needed in > src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp. > > Vinson Hi I'm not convinced that it does Utils.h defines two functions LLVMAddLowerSwitchPass & LLVMAddPromoteMemoryToRegisterPass. Whilst jit_pch.hpp does

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-31 Thread Mike Lothian
On Sat, 31 Mar 2018 at 00:54 Dylan Baker wrote: > > Quoting Mike Lothian (2018-03-29 17:49:30) > > > > > > On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > > > > Quoting Mike Lothian (2018-03-29 16:56:28) > > > Include llv

Re: [Mesa-dev] [radv] compilation error with 'latest' LLVM (#4e45b963bcd)

2018-03-30 Thread Mike Lothian
I've submitted a patch for this, it was a change in the llvm-c includes On Fri, 30 Mar 2018 at 08:43 Dieter Nützel wrote: > make[4]: Verzeichnis „/opt/mesa/src/amd/vulkan“ wird betreten >CC radv_nir_to_llvm.lo > radv_nir_to_llvm.c: In function ‘ac_llvm_finalize_module’: > radv_nir_to_l

Re: [Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-29 Thread Mike Lothian
On Fri, 30 Mar 2018, 01:42 Dylan Baker, wrote: > Quoting Mike Lothian (2018-03-29 16:56:28) > > Include llvm-c/Transforms/Utils.h with the newest LLVM 7 > > > > Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h > > I have no comment on the patch itself. >

[Mesa-dev] [PATCH] ac/nir: Fix include for LLVMAddPromoteMemoryToRegisterPass

2018-03-29 Thread Mike Lothian
Include llvm-c/Transforms/Utils.h with the newest LLVM 7 Fixes: 2dd4f35c7fc llvm-c: Split Utils out of Scalar.h Signed-of-by: Mike Lothian --- I don't have git commit rights If you're happy with this patch please can you commit it Cheers Mike --- src/amd/vulkan/radv_nir

Re: [Mesa-dev] [PATCH 2/2] configure.ac: require libdrm_amdgpu 2.4.91

2018-03-13 Thread Mike Lothian
Did you mean to remove the blacklist you added in the previous patch? On Wed, 14 Mar 2018 at 01:03 Marek Olšák wrote: > From: Marek Olšák > > Since 2.4.90 might not work, just ask for the next version. > --- > configure.ac | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > dif

Re: [Mesa-dev] Few issues with Meson

2018-03-12 Thread Mike Lothian
ng is used - I'll look into that sometime Regards Mike On Fri, 9 Mar 2018 at 16:37 Dylan Baker wrote: > Quoting Mike Lothian (2018-03-06 05:07:34) > > Hi > > > > When compiling wine I also noticed that the d3d.pc files didn't have > moduledir > > set, so w

Re: [Mesa-dev] Few issues with Meson

2018-03-06 Thread Mike Lothian
Hi When compiling wine I also noticed that the d3d.pc files didn't have moduledir set, so wine couldn't find it configure: error: pkg-config couldn't find Gallium Nine module Regards Mike On Tue, 6 Mar 2018 at 02:17 Mike Lothian wrote: > Hi > > I've been trying

[Mesa-dev] Few issues with Meson

2018-03-05 Thread Mike Lothian
Hi I've been trying to get a Gentoo ebuild ready for meson I've had to fudge the llvm-config for cross compiling a 32bit mesa on a 64bit machine I notice that -Dvulkan-drivers= doesn't accept intel,radeon like autotools used to, it also seems as long as one value is correct the other is ignored

Re: [Mesa-dev] [PATCH] disk cache: Link with -latomic if necessary

2018-03-03 Thread Mike Lothian
Hi Sorry to be a pain again I've just tested this with clang and the 32bit build still fails without -latomic libtool: link: /bin/true glsl/.libs/libstandalone.a libtool: link: rm -fr glsl/.libs/libstandalone.lax glsl/.libs/libstandalone.lax libtool: link: ( cd "glsl/.libs" && rm -f "libstandalo

Re: [Mesa-dev] [PATCH] disk cache: Link with -latomic if necessary

2018-02-26 Thread Mike Lothian
On Fri, 23 Feb 2018 at 13:18 Thierry Reding wrote: > From: Thierry Reding > > The disk cache implementation uses 64-bit atomic operations. For some > architectures, such as 32-bit ARM, GCC will not be able to translate > these operations into lock-free instructions and will instead rely on > the

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-23 Thread Mike Lothian
The OCD side of me says it doesn't look right :P The lazy side of me says it's fine Either way it doesn't make much difference, it's only exposed with the extended output anyway On Fri, 23 Feb 2018 at 16:32 Brian Paul wrote: > On 02/23/2018 03:06 AM, Mike Lothian wrot

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-23 Thread Mike Lothian
This still looks wrong, there's now two 4.3 sections: 4.3: GL_MAX_ELEMENT_INDEX = 2147483647 GL_MAX_COMPUTE_UNIFORM_BLOCKS = 14 GL_MAX_COMPUTE_TEXTURE_IMAGE_UNITS = 32 GL_MAX_COMPUTE_IMAGE_UNIFORMS = 32 GL_MAX_COMPUTE_SHARED_MEMORY_SIZE = 65536 GL_MAX_COMPUTE_UNIFORM_COMP

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
It also seems to have an off by one error On Wed, 21 Feb 2018 at 16:41 Mike Lothian wrote: > This doesn't show as default and seems to be tucked away > under GL_ARB_transform_feedback3 > > GL_ARB_transform_feedback3: > GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 > GL

Re: [Mesa-dev] [PATCH 2/2] glxinfo/wglinfo: print list of 4.3 shading language versions

2018-02-21 Thread Mike Lothian
This doesn't show as default and seems to be tucked away under GL_ARB_transform_feedback3 GL_ARB_transform_feedback3: GL_MAX_TRANSFORM_FEEDBACK_BUFFERS = 4 GL_MAX_VERTEX_STREAMS = 4 GL_NUM_SHADING_LANGUAGE_VERSIONS = 16 450 440 430 420 410

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

2018-02-14 Thread Mike Lothian
pack_es31a I'm not aware of anything that uses OpenGL 3.1 Compat or the ARB_compatability extension, but if you know of anything I'll test it directly Should i965 show the extra extensions or a higher compat version as well as the bump to the GLSL version? My games continue to w

Re: [Mesa-dev] Initial release of AMD Open Source Driver for Vulkan

2017-12-22 Thread Mike Lothian
rds, > David > > > On Dec 22, 2017, at 9:48 PM, Mike Lothian wrote: > > Congratulations on getting this out the door > > It didn't compile for me without these changes: > > In pal: > > diff --git a/src/util/math.cpp b/src/util/math.cpp > index 46e9ede.

Re: [Mesa-dev] Initial release of AMD Open Source Driver for Vulkan

2017-12-22 Thread Mike Lothian
Congratulations on getting this out the door It didn't compile for me without these changes: In pal: diff --git a/src/util/math.cpp b/src/util/math.cpp index 46e9ede..3af4259 100644 --- a/src/util/math.cpp +++ b/src/util/math.cpp @@ -54,7 +54,7 @@ static uint32 Float32ToFloatN(float f, const NBi

Re: [Mesa-dev] Gallium ARB_get_program_binary support

2017-12-12 Thread Mike Lothian
Game works fine, not sure if it's using the extension or not On Mon, 11 Dec 2017 at 23:21 Mike Lothian wrote: > I'll check that when I'm next home > > On Mon, 11 Dec 2017 at 21:19 Timothy Arceri wrote: > >> On 12/12/17 08:13, Mike Lothian wrote: >> &g

Re: [Mesa-dev] Gallium ARB_get_program_binary support

2017-12-11 Thread Mike Lothian
I'll check that when I'm next home On Mon, 11 Dec 2017 at 21:19 Timothy Arceri wrote: > On 12/12/17 08:13, Mike Lothian wrote: > > Tested with Dead Island, Dirt Rally and Serious Sam BFG (which I believe > > uses this extension) > > > > Do you know any oth

Re: [Mesa-dev] Gallium ARB_get_program_binary support

2017-12-11 Thread Mike Lothian
Tested with Dead Island, Dirt Rally and Serious Sam BFG (which I believe uses this extension) Do you know any other games that use this? On Mon, 11 Dec 2017 at 02:17 Dieter Nützel wrote: > For the V2 series: > > Tested-by: Dieter Nützel > and > Acked-by: Dieter Nützel > if this is worth from

Re: [Mesa-dev] Gallium ARB_get_program_binary support

2017-12-09 Thread Mike Lothian
I can confirm these sort the crash on Dead Island and I can confirm I'm also seeing the segfault with Dirt Rally On Fri, 8 Dec 2017 at 09:58 Timothy Arceri wrote: > Core support in now in master so this is just a resend of the gallium > patches. > > Resolves crash in Dead Island: > > Bugzilla: h

Re: [Mesa-dev] V3 i965/Gallium ARB_get_program_binary support

2017-12-05 Thread Mike Lothian
I can confirm this fixes the Dead Island crash, which makes this the first time I've been able to play the game since purchasing it :D The patches doesn't apply cleanly to master so I used the following fixup https://github.com/FireBurn/mesa/tree/gallium-program-binary If you're happy with that f

Re: [Mesa-dev] [PATCH 3/3] RFC: vulkan/wsi: Rework the way prime support works

2017-11-16 Thread Mike Lothian
Will this allow us to select between iGPU and dGPU like we can with OpenGL? Or is it just going to force radv like before? On Thu, 16 Nov 2017 at 10:09 Grazvydas Ignotas wrote: > On Thu, Nov 16, 2017 at 12:33 AM, Dave Airlie wrote: > > On 15 November 2017 at 04:40, Jason Ekstrand > wrote: > >>

Re: [Mesa-dev] [PATCH 00/16] RadeonSI micro-optimizations

2017-10-13 Thread Mike Lothian
Hi Have you ran any benchmarks against these? Cheers Mike On Fri, 13 Oct 2017 at 13:04 Marek Olšák wrote: > Hi, > > This series: > - switches IB placement to GTT WC > - uses SPI_SHADER_USER_DATA_COMMON on GFX9 > - combines setting of 2 per-stage descriptor pointers into 1 SET_SH_REG > packet

Re: [Mesa-dev] Vulkan extensions

2017-09-17 Thread Mike Lothian
Maybe you could use the hardware feature list and have an extra option of unsupported, for the hardware that cannot do that feature and not include that in the percentages On Fri, 15 Sep 2017, 12:19 am Bas Nieuwenhuizen wrote: > On Fri, Sep 15, 2017 at 1:18 AM, Dave Airlie wrote: > > On 15 Sept

Re: [Mesa-dev] [PATCH mesa] mesa/st: remove unwanted backup file

2017-08-30 Thread Mike Lothian
LOL didn't even spot this sorry It might be a good idea to pop *.orig and *.rej into the gitignore file On Wed, 30 Aug 2017 at 14:17 Emil Velikov wrote: > On 30 August 2017 at 14:11, Eric Engestrom wrote: > > Fixes: 0ac78dc92582a59d4319 "util: move string_to_uint_map to glsl" > > Cc: Emil Veli

Re: [Mesa-dev] [PATCH] util: move string_to_uint_map to glsl

2017-08-29 Thread Mike Lothian
Feel free to add my tested by for this Thanks for the fix On Sat, 26 Aug 2017 at 17:35 Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Fri, Aug 25, 2017 at 7:10 PM, Jason Ekstrand > wrote: > >> Ack. Not a review though. >> >> >> >> On August 25, 2017 6:38:46 PM Emil Velikov >> wr

Re: [Mesa-dev] threaded opengl

2017-07-23 Thread Mike Lothian
I think you also need to provide info on how much of a speed up it provides because some games are slower with glthread On Mon, 24 Jul 2017 at 01:33 siyia wrote: > sorry executable is "mb_warband_linux" start.sh or mb_warband.sh are > local scripts to start the game so: > > > >

Re: [Mesa-dev] [PATCH] egl/wayland: Fix linking libEGL_common.la

2017-07-23 Thread Mike Lothian
cache.c:(.text+0xe40): undefined reference to `__atomic_fetch_add_8' On Mon, 24 Jul 2017 at 00:03 Mike Lothian wrote: > This is only an issue when using ld.gold, ld.bfd works fine which is > probably why no one else has seen it. It only started being a problem when > the dmabuff s

Re: [Mesa-dev] [PATCH] egl/wayland: Fix linking libEGL_common.la

2017-07-23 Thread Mike Lothian
piler On Fri, 21 Jul 2017 at 13:27 Emil Velikov wrote: > On 20 July 2017 at 21:25, Mike Lothian wrote: > > Because libmesautil.la includes string_to_uint_map.o, -lstdc++ is > > required for linking to succeed > > > It's a bit suspicious why not many others are seein

[Mesa-dev] [PATCH] egl/wayland: Fix linking libEGL_common.la

2017-07-20 Thread Mike Lothian
Because libmesautil.la includes string_to_uint_map.o, -lstdc++ is required for linking to succeed Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101851 Signed-off-by: Mike Lothian --- src/egl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl

Re: [Mesa-dev] [PATCH v3 8/8] egl/wayland: Use linux-dmabuf interface for buffers

2017-07-18 Thread Mike Lothian
Hi I'm currently getting a build failure with this patch in an out of tree build Making all in egl make[3]: Entering directory '/var/tmp/portage/media-libs/mesa-/work/mesa--abi_x86_32.x86/src/egl' /usr/bin/wayland-scanner code < /usr/share/wayland-protocols/unstable/linux-dmabuf/linux-dm

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

2017-07-04 Thread Mike Lothian
Hi I'm not seeing this issue on Gentoo. My llvm-config --version shows "5.0.0git-79da0992d18" I'm attaching the patch we use Regards Mike On Tue, 4 Jul 2017 at 10:10 Emil Velikov wrote: > On 3 July 2017 at 22:51, Andy Furniss wrote: > > Emil Velikov wrote: > >> > >> On 3 July 2017 at 16:31,

Re: [Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

2017-06-21 Thread Mike Lothian
On Thu, 22 Jun 2017 at 00:12 Matt Turner wrote: > On Wed, Jun 21, 2017 at 3:50 PM, Mike Lothian wrote: > > Do intel run mesa through any of their test boxes like they do with > kernel > > patches? > > Don't top quote. > > Yes, we have a CI system that w

Re: [Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

2017-06-21 Thread Mike Lothian
Do intel run mesa through any of their test boxes like they do with kernel patches? On Wed, 21 Jun 2017 at 19:23 Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 11:20 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > >> On Wed, Jun 21, 2017 at 11:16:39AM -0700, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH 00/17] radv: Support for subgroup_vote and shader_ballot

2017-06-12 Thread Mike Lothian
I found some patches on the git mailing list but looks like none of them have been merged http://git.661346.n2.nabble.com/PATCH-send-mail-Add-option-to-sleep-between-sending-each-email-td6769476.html On Mon, 12 Jun 2017 at 23:22 Connor Abbott wrote: > On Mon, Jun 12, 2017 at 2:30 AM, Nicolai Hä

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

2017-05-22 Thread Mike Lothian
I'm quite sure on Gentoo lib points to lib64 and we have a lib32 On Mon, 22 May 2017 at 22:46 Rob Herring wrote: > On Mon, May 22, 2017 at 9:16 AM, Emil Velikov > wrote: > > On 20 May 2017 at 01:16, Rob Herring wrote: > >> On Fri, May 19, 2017 at 12:57 PM, Emil Velikov < > emil.l.veli...@gmail

Re: [Mesa-dev] [Bug 101088] `gallium: remove pipe_index_buffer and set_index_buffer` causes glitches and crash in gallium nine

2017-05-22 Thread Mike Lothian
This fixes WoW for me Thanks On Mon, 22 May 2017 at 00:18 wrote: > *Comment # 4 on > bug 101088 from Axel > Davy * > > Should be fixed > byhttps://lists.freedesktop.org/archives/mesa

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

2017-05-18 Thread Mike Lothian
Can you make sure whatever you do it's well tested I shudder every time I see such requests as it nearly always seems to cause breakage for me On Thu, 18 May 2017 at 11:25 Emil Velikov wrote: > On 18 May 2017 at 05:10, Chih-Wei Huang wrote: > > 2017-05-18 12:01 GMT+08:00 Xu, Randy : > >> > >>>

Re: [Mesa-dev] [PATCH 00/18] anv: Rework the allocation data structures

2017-05-05 Thread Mike Lothian
I'm seeing the following failure with GCC 7.1: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/intel/vulkan/anv_allocator.c: In function ‘anv_state_stream_alloc’: /var/tmp/portage/media-libs/mesa-/work/mesa-/src/intel/vulkan/anv_allocator.c:930:28: error: ‘struct anv_state_stream_

Re: [Mesa-dev] [ANNOUNCE] mesa 17.1.0-rc3

2017-05-01 Thread Mike Lothian
Hi I think this email is sent from a script so just wanted to point out: not available -> now available If it's just a bog standard typo in a manually written email - just ignore me Mike On Mon, 1 May 2017 at 13:24 Emil Velikov wrote: > Hello all, > > The third release candidate for Mesa 17.

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

2017-04-29 Thread Mike Lothian
Hi I've just tested this with Nine. It causes a weird white strobing effect - I think there are other graphical glitches too but it's hard to tell I was testing the blizzard app http://eu.battle.net/en/app/ the same also happens when World of Warcraft is launched This doesn't happen if I use CSM

Re: [Mesa-dev] [PATCH] clover: Fix build against clang SVN >= r301442

2017-04-26 Thread Mike Lothian
Tested-and-reviewed-by: Mike Lothian On Thu, 27 Apr 2017 at 04:33 Michel Dänzer wrote: > From: Michel Dänzer > > Hardcode the OpenCL InputKind in compat::set_lang_defaults. > > Signed-off-by: Michel Dänzer > --- > src/gallium/state_trackers/clover/llvm/compat.hpp |

Re: [Mesa-dev] [PATCH 00/14] Better Travis-CI integration, take 2

2017-04-21 Thread Mike Lothian
Use a lower make j number and make sure you're not using LTO On Fri, 21 Apr 2017, 2:33 pm Emil Velikov, wrote: > On 21 April 2017 at 13:25, Gustaw Smolarczyk wrote: > > 2017-04-21 14:08 GMT+02:00 Emil Velikov : > >> Note: GCC 5/6 crashes with internal compiler error at seemingly random > >> sta

  1   2   3   >