Re: [Mesa-dev] [PATCH] glsl: uniform sampler should occupy 1 location

2014-08-27 Thread Micael
mapTable[location] ==INACTIVE_UNIFORM_EXPLICIT_LOCATION)" later. Should I open another bug report? On Wed, Aug 27, 2014 at 11:15 AM, Tapani Pälli wrote: > On 08/26/2014 10:37 PM, Ian Romanick wrote: > > On 08/23/2014 07:51 AM, Micael wrote: > >> On second thought, the glsl_t

Re: [Mesa-dev] [PATCH] glsl: uniform sampler should occupy 1 location

2014-08-23 Thread Micael
e it clear that it reflects the size for the API, not GPU memory (since it's only used to fill prog->UniformRemapTable). On Sat, Aug 23, 2014 at 2:07 PM, Micael wrote: > On Fri, Aug 22, 2014 at 9:23 PM, Ian Romanick wrote: > >> I'm not sure this is correct, and I think we

Re: [Mesa-dev] [PATCH] glsl: uniform sampler should occupy 1 location

2014-08-23 Thread Micael
le locations assigned to a uniform and the GPU > visible locations where the uniform is stored. My guess is that we're > using the same accounting for both in places where we should not. > > On 08/21/2014 04:25 PM, Micael Dias wrote: > > --- > > If samplers occupy

Re: [Mesa-dev] [PATCH] glsl: uniform sampler should occupy 1 location

2014-08-22 Thread Micael
e. > > On 22 August 2014 09:25, Micael Dias wrote: > > --- > > If samplers occupy zero locations we can run into a lot of issues. See > #82921. > > I briefly tested this with my own code (which was previously crashing and > > misbehaving) and also ran other

[Mesa-dev] [PATCH] glsl: uniform sampler should occupy 1 location

2014-08-21 Thread Micael Dias
--- If samplers occupy zero locations we can run into a lot of issues. See #82921. I briefly tested this with my own code (which was previously crashing and misbehaving) and also ran other apps and everything seems to work fine. I'm not used to contributing code in this fashion, so please forgive m

Re: [Mesa-dev] [PATCH] Implement HW accelerated GL_SELECT

2011-08-24 Thread Micael
Any more feedback regarding this? I now don't have much time to work on it again, but I may find some, so knowing what's left to do would be nice... On Thu, Aug 4, 2011 at 2:59 PM, Micael Dias wrote: > --- > src/mesa/SConscript |1 + > src/m

[Mesa-dev] [PATCH] Implement HW accelerated GL_SELECT

2011-08-04 Thread Micael Dias
GLuint min_index, +GLuint max_index); #endif diff --git a/src/mesa/state_tracker/st_draw_select_emul.c b/src/mesa/state_tracker/st_draw_select_emul.c new file mode 100644 index 000..d6bb244 --- /dev/null +++ b/src/mesa/state_tracker/st_draw_select_emul.c @@ -0,0 +1,490 @@ +/

[Mesa-dev] [PATCH] Implement HW accelerated GL_SELECT

2011-08-04 Thread Micael Dias
GLuint min_index, +GLuint max_index); #endif diff --git a/src/mesa/state_tracker/st_draw_select_emul.c b/src/mesa/state_tracker/st_draw_select_emul.c new file mode 100644 index 000..5e15298 --- /dev/null +++ b/src/mesa/state_tracker/st_draw_select_emul.c @@ -0,0 +1,468 @@ +/

[Mesa-dev] [PATCH] Implement HW accelerated GL_SELECT

2011-08-02 Thread Micael Dias
ul.c new file mode 100644 index 000..ea54f22 --- /dev/null +++ b/src/mesa/state_tracker/st_draw_select_emul.c @@ -0,0 +1,475 @@ +/** + * + * Copyright 2011 Micael Dias . + * All Rights Reserved. + * + * Permission is hereby gr

[Mesa-dev] [PATCH] Implement HW accelerated GL_SELECT

2011-08-02 Thread Micael Dias
--- src/mesa/main/mtypes.h |7 + src/mesa/state_tracker/st_cb_feedback.c | 21 +- src/mesa/state_tracker/st_draw.h | 17 + src/mesa/state_tracker/st_draw_select_emul.c | 463 ++ src/mesa/SConscript |

[Mesa-dev] Implementing an HW accelerated GL_SELECT

2011-07-29 Thread Micael
wever, before starting this work, I would like to know if there is a chance that this will be included into master, and which eventual problems I may hit that will prevent it from going into master. Thanks. [1] https://bugs.freedesktop.org/show_bug.cgi?id=34495 -- Micael

Re: [Mesa-dev] [PATCH] Gallium: fix buffer overflow

2011-07-01 Thread Micael
ces, and not actual vertices. > > So it looks good, but let me investigate a bit more. > > Jose > > - Original Message - > > This looks good to me -- Jose? > > > > Keith > > > > On Thu, 2011-06-30 at 03:33 +0100, Micael Dias wr

[Mesa-dev] [PATCH] Gallium: fix buffer overflow

2011-07-01 Thread Micael Dias
--- src/gallium/auxiliary/draw/draw_llvm.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/gallium/auxiliary/draw/draw_llvm.c index 56c26f5..19134f3 100644 --- a/src/gallium/auxiliary/draw/draw_llvm.c +++ b/src/gall

[Mesa-dev] How to submit a patch?

2011-06-29 Thread Micael
Hi I'm new here, and I'm looking for a way to submit a patch that I have created that fixes an "index out of bounds" issue. I already attached the patch to the bug report in question ( https://bugs.freedesktop.org/show_bug.cgi?id=34495). Is that enough? Than