RE: [BUG][AMD][VDPAU] RX6600 GPU locks up when decoding HEVC

2024-02-15 Thread Liu, Leo
[AMD Official Use Only - General] This is being looked. > -Original Message- > From: mesa-dev On Behalf Of > Chris Rankin > Sent: Thursday, February 15, 2024 10:38 AM > To: mesa-dev@lists.freedesktop.org > Subject: [BUG][AMD][VDPAU] RX6600 GPU locks up when decoding HEVC > > I have disco

Re: [Mesa-dev] frontends/va/postproc: Use the actual image height when blitting

2020-11-30 Thread Liu, Leo
+Thong. -Original Message- From: mesa-dev On Behalf Of Ilia Mirkin Sent: November 25, 2020 5:48 PM To: ML Mesa-dev ; Thai, Thong Subject: Re: [Mesa-dev] frontends/va/postproc: Use the actual image height when blitting Hi Thong, In this change: https://nam11.safelinks.protection.outl

Re: [Mesa-dev] VAAPI encoder and OpenGL

2020-04-27 Thread Leo Liu
+Thong. On 2020-04-27 8:29 a.m., Daniel Gomez wrote: Adding Boyuan Zhang to the thread. On Mon, 27 Apr 2020 at 14:00, Daniel Gomez wrote: Hi guys, We have found a limitation on the usage of the GPU and the encoder when you run it simultaneously in a gstreamer pipeline and we would like to re

Re: [Mesa-dev] - Interested in the project "Unit and performance tests for VA-API"

2020-04-08 Thread Leo Liu
On 2020-04-02 2:58 p.m., AMAN IIT wrote: Dear Sir/ma'am, Hope you are doing well. Aman is here from India. I'm currently pursuing my Bachelor's degree from IIT Dharwad in the field of *Computer Science*. After considering my interests, I am convinced that I want to become a Backend developer

Re: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parameters for encoder

2020-01-02 Thread Liu, Leo
The mesa process has switched to using merge requests. -Original Message- From: mesa-dev On Behalf Of Satyajit Sahu Sent: Tuesday, December 24, 2019 4:39 AM To: mesa-dev@lists.freedesktop.org Cc: Sharma, Deepak ; Sahu, Satyajit Subject: [Mesa-dev] [PATCH] radeon/vcn: Handle crop parame

Re: [Mesa-dev] [PATCH] radeonsi: Add support for midstream bitrate change in encoder

2019-12-04 Thread Leo Liu
On 2019-12-02 11:30 p.m., Satyajit Sahu wrote: Added support for bitrate change in between encoding. Signed-off-by: Satyajit Sahu diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index 84d3c1e2fa4..7d7a2fa4eb3 100644 --- a/src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH] radeonsi: Add support for midstream bitrate change in encoder

2019-12-03 Thread Liu, Leo
+Boyuan From: Marek Olšák Sent: December 3, 2019 7:21:23 PM To: Sahu, Satyajit ; Liu, Leo Cc: ML Mesa-dev ; Sharma, Deepak Subject: Re: [Mesa-dev] [PATCH] radeonsi: Add support for midstream bitrate change in encoder +Leo On Mon, Dec 2, 2019 at 11:31 PM

[Mesa-dev] [PATCH] ac: add missing Arcturus to the info of pc lines

2019-11-04 Thread Liu, Leo
Signed-off-by: Leo Liu Cc: Marek Olšák --- src/amd/common/ac_gpu_info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 9caa51cb8b9..0061d2deb01 100644 --- a/src/amd/common/ac_gpu_info.c +++ b/src/amd/common/ac_gpu_info.c

Re: [Mesa-dev] radeon/vcn: exclude raven2 from vcn 2.0 encode initialization

2019-09-10 Thread Liu, Leo
Reviewed-by: Leo Liu On 2019-09-10 10:06 a.m., Das, Indrajit-kumar wrote: > From: Indrajit Das > Date: Tue, 10 Sep 2019 14:52:14 +0530 > Subject: [PATCH] radeon/vcn: exclude raven2 from vcn 2.0 encode initialization > > Signed-off-by: Indrajit Das > --- > src/g

[Mesa-dev] [PATCH] radeon/vcn: add RENOIR VCN decode support

2019-09-04 Thread Liu, Leo
It has same VCN2.x block as Navi1x Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers/radeon/radeon_vcn_dec.c index 77bfe187674

Re: [Mesa-dev] [PATCH] radeon/vcn: adding engine type for new fw interface

2019-07-12 Thread Liu, Leo
Reviewed-by Leo Liu On 2019-07-11 5:56 p.m., boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.h | 2 ++ > src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 1 + > src/g

Re: [Mesa-dev] [PATCH] radeonsi: Expose support for 10 bit VP9 decode

2019-06-27 Thread Liu, Leo
On 2019-06-26 11:56 p.m., Vishwakarma, Pratik wrote: > Fix si_vid_is_format_supported to expose > support for 10-bit VP9 decode using P016 format You could have a better commit message here, like what it will cause by missing this patch. Regards, Leo > > Signed-off-by: Pratik Vishwakarma >

Re: [Mesa-dev] [PATCH] radeon/vcn: enable rate control for hevc encoding

2019-06-19 Thread Liu, Leo
Please tag the bugzilla link to the commit messages. With that, the set of patches are Acked-by: Leo Liu On 2019-06-17 3:07 p.m., boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > Set cu_qp_delta_enable_flag on when rate control is enabled, and it > off when no rate control

Re: [Mesa-dev] [PATCH] radeon/vcn: fix poc for hevc encode

2019-05-29 Thread Liu, Leo
These 2 patches are: Acked-by: Leo Liu On 5/29/19 2:41 PM, boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > MaxPicOrderCntLsb should be at least 16 according to the spec, > therefore add minimum value check. > > Also use poc value passed from st instead of calculation

Re: [Mesa-dev] [PATCH] radeon/vcn: fix max poc for hevc encode

2019-05-22 Thread Liu, Leo
On 5/17/19 7:54 PM, boyuan.zh...@amd.com wrote: > [CAUTION: External Email] > > From: Boyuan Zhang > > Fix max poc value with hardcoded value until new feature requires > to change this in the future. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673 > Cc: mesa-sta...@lists.freede

Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-14 Thread Liu, Leo
On 2019-05-14 5:29 a.m., Michel Dänzer wrote: > [CAUTION: External Email] > > On 2019-05-09 8:10 p.m., Liu, Leo wrote: >> Since the using output optimization is only for back buffer case >> >> Signed-off-by: Leo Liu >> --- >> src/gallium/auxiliary/vl/vl_

Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-13 Thread Liu, Leo
Ping... On 5/9/19 2:10 PM, Liu, Leo wrote: > Since the using output optimization is only for back buffer case > > Signed-off-by: Leo Liu > --- > src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/auxiliary/

[Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case

2019-05-09 Thread Liu, Leo
Since the using output optimization is only for back buffer case Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 1558d832555

Re: [Mesa-dev] [PATCH] winsys/amdgpu: add VCN JPEG to no user fence group

2019-05-08 Thread Liu, Leo
On 5/8/19 9:19 AM, Koenig, Christian wrote: > Am 08.05.19 um 15:14 schrieb Liu, Leo: >> On 5/8/19 9:02 AM, Christian König wrote: >>> [CAUTION: External Email] >>> >>> Am 08.05.19 um 14:56 schrieb Liu, Leo: >>>> There is no user fence for JP

Re: [Mesa-dev] [PATCH] winsys/amdgpu: add VCN JPEG to no user fence group

2019-05-08 Thread Liu, Leo
On 5/8/19 9:02 AM, Christian König wrote: > [CAUTION: External Email] > > Am 08.05.19 um 14:56 schrieb Liu, Leo: >> There is no user fence for JPEG, the bug triggering >> kernel WARN_ON(flags & AMDGPU_FENCE_FLAG_64BIT) > > Oh, we are probably going to need to

[Mesa-dev] [PATCH] winsys/amdgpu: add VCN JPEG to no user fence group

2019-05-08 Thread Liu, Leo
There is no user fence for JPEG, the bug triggering kernel WARN_ON(flags & AMDGPU_FENCE_FLAG_64BIT) Signed-off-by: Leo Liu Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/wi

Re: [Mesa-dev] [PATCH 2/3] radeon/vce:Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-11 Thread Liu, Leo
above 2 lines to the else case of frame_cropping_flag. With that fixed, the series are Reviewed-by: Leo Liu > + if (pic->pic_ctrl.enc_frame_cropping_flag) { > + enc->enc_pic.pc.enc_crop_left_offset = > pic->pic_ctrl.enc_frame_crop_left_offset

Re: [Mesa-dev] [PATCH] gallium: Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-09 Thread Liu, Leo
On 4/9/19 12:23 AM, Sahu, Satyajit wrote: > On 4/9/2019 12:34 AM, Liu, Leo wrote: >> On 4/8/19 1:17 AM, Sahu, Satyajit wrote: >>> From: suresh guttula >>> >>> This patch will add support for frame_cropping when the input size is not >>> matched with

Re: [Mesa-dev] [PATCH] gallium: Add support for frame_cropping_flag of VAEncSequenceParameterBufferH264

2019-04-08 Thread Liu, Leo
On 4/8/19 1:17 AM, Sahu, Satyajit wrote: > From: suresh guttula > > This patch will add support for frame_cropping when the input size is not > matched with aligned size. Currently vaapi driver ignores frame cropping > values provided by client. This change will update SPS nalu with proper > crop

[Mesa-dev] [PATCH] radeon/vcn/vp9: search the render target from the whole list

2019-03-28 Thread Liu, Leo
The number of render targets could be more than max of references, so we search the full list of the render pictures for the current render target index https://bugs.freedesktop.org/show_bug.cgi?id=109648 Signed-off-by: Leo Liu Cc: --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 2 +- 1

[Mesa-dev] [PATCH] radeon/vcn: add H.264 constrained baseline support

2019-03-26 Thread Liu, Leo
VCN supports this profile as well as UVD, so add it Signed-off-by: Leo Liu CC: --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers/radeon/radeon_vcn_dec.c index a4e6d9dc6b5

Re: [Mesa-dev] [PATCH] vl/dri3: remove the wait before getting back buffer

2019-03-21 Thread Liu, Leo
On 2019-03-20 1:56 p.m., Michel Dänzer wrote: > On 2019-03-20 4:42 p.m., Liu, Leo wrote: >> The wait here is unnecessary since we got a pool of back buffers, >> and the wait for swap buffer will happen before the present pixmap, >> at the same time the previous back buffe

Re: [Mesa-dev] [PATCH] vl/dri3: remove the wait before getting back buffer

2019-03-21 Thread Liu, Leo
n. Thanks, Leo > > Regards > //Ernst > > Den ons 20 mars 2019 kl 16:42 skrev Liu, Leo : >> The wait here is unnecessary since we got a pool of back buffers, >> and the wait for swap buffer will happen before the present pixmap, >> at the same time the previous

[Mesa-dev] [PATCH] vl/dri3: remove the wait before getting back buffer

2019-03-20 Thread Liu, Leo
The wait here is unnecessary since we got a pool of back buffers, and the wait for swap buffer will happen before the present pixmap, at the same time the previous back buffer will be put back to pool for reuse after the check for PresentIdleNotify event Signed-off-by: Leo Liu --- src/gallium

Re: [Mesa-dev] [PATCH 3/3] gallium/auxiliary/vl: Change weave compute shader implementation

2019-03-13 Thread Liu, Leo
/bugs.freedesktop.org/show_bug.cgi?id=109646 The series are: Acked-by: Leo Liu > Signed-off-by: James Zhu > Tested-by: Bruno Milreu > --- > src/gallium/auxiliary/vl/vl_compositor_cs.c | 79 > ++--- > 1 file changed, 62 insertions(+), 17 deletions(-) &g

Re: [Mesa-dev] [PATCH 1/3] gallium: add pipe_grid_info::last_block

2019-03-01 Thread Liu, Leo
Series are: Acked-by: Leo Liu On 2/27/19 5:19 PM, Marek Olšák wrote: > From: Marek Olšák > > The OpenMAX state tracker will use this. > > RadeonSI is adapted to use pipe_grid_info::last_block instead of its > internal state. > --- > src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH v3] gallium/auxiliary/vl: Fix transparent issue on compute shader with rgba

2019-02-20 Thread Liu, Leo
Reviewed-by: Leo Liu On 2019-02-15 4:19 p.m., Zhu, James wrote: > Fixes: 9364d66cb7f7 (Add video compositor compute shader render) > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109646 > Problem 1,4: they are caused by imcomplete blend comute shader > implementation. So

Re: [Mesa-dev] [PATCH] gallium/auxiliary/vl: Revert rgba back to frament shader

2019-02-15 Thread Liu, Leo
On 2/15/19 3:42 PM, Zhu, James wrote: > Bugzilla Bug 109646 - New video compositor compute shader render glitches mpv > Problem 1,4: they are caused by imcomplete blend compute shader > implementation. So Revert rgba back to frament shader. Please refer to other commit message to put Bugzilla lin

Re: [Mesa-dev] [PATCH v5 5/5] gallium/auxiliary/vl: Add video compositor compute shader render

2019-02-12 Thread Liu, Leo
On 2/12/19 10:35 AM, Zhu, James wrote: > Add compute shader initilization, assign and cleanup in vl_compositor API. > Set video compositor compute shader render as default when pipe support it. > > Signed-off-by: James Zhu > Reviewed-by: Christian König > --- > src/gallium/auxiliary/vl/vl_comp

[Mesa-dev] [PATCH 1/2] st/va: fix the incorrect max profiles report

2019-02-08 Thread Liu, Leo
Add "PIPE_VIDEO_PROFILE_MAX" to enum, so it will make sure here will be correct when adding more profiles in the future. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109107 Signed-off-by: Leo Liu Cc: 19.0 --- src/gallium/include/pipe/p_video_enums.h | 3 ++- s

[Mesa-dev] [PATCH 2/2] st/va/vp9: set max reference as default of VP9 reference number

2019-02-08 Thread Liu, Leo
If there is no information about number of render targets Signed-off-by: Leo Liu Cc: 19.0 --- src/gallium/state_trackers/va/picture_vp9.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_vp9.c b/src/gallium/state_trackers/va

Re: [Mesa-dev] [PATCH] st/va:Add support for indirect manner by returning VA_STATUS_ERROR_OPERATION_FAILED

2019-02-07 Thread Liu, Leo
. Clients should then fall back  * to using vaCreateImage + vaPutImage to accomplish the same task in an  * indirect manner. This is similar to your commit message, so please add it something like "based on VA spec..." to your commit message. With that fixed, the patch is: Reviewed-by: Le

Re: [Mesa-dev] [Bug 109107] gallium/st/va: change va max_profiles when using Radeon VCN Hardware

2019-02-05 Thread Liu, Leo
I'll take a look and update Bugzilla accordingly. Cheers, Leo On 2/1/19 3:59 PM, Mihai wrote: Hi, I am not sure if this is related with regards to what is causing hardware accelerated decoding on my Raven laptop not to work. Fedora repos: che-mesa, rpmfusion, fedora-rawhide-kernel-nodebug Mes

Re: [Mesa-dev] [PATCH 6/6] gallium\auxiliary\vl: Add video compute shader render

2019-02-04 Thread Liu, Leo
On 2/1/19 11:38 AM, Christian König wrote: > Am 01.02.19 um 17:28 schrieb Zhu, James: >> Add video compute shader render. export CS_COMPOSITOR_RENDER=true >> to enable video compute shader render. > > Ok that actually makes more sense, but I would either put everything > into one file or cleanly

Re: [Mesa-dev] [PATCH 3/6] gallium\auxiliary\vl: Add compute shader to support video compositor render

2019-02-04 Thread Liu, Leo
On 2/1/19 11:28 AM, Zhu, James wrote: > Add compute shader to support video compositor render. > > Signed-off-by: James Zhu > --- > src/gallium/auxiliary/Makefile.sources | 2 + > src/gallium/auxiliary/meson.build | 2 + > src/gallium/auxiliary/vl/vl_compositor_cs.c | 414

Re: [Mesa-dev] st/va: Return correct status from vlVaQuerySurfaceStatus

2019-01-04 Thread Liu, Leo
Please add some commit messages. With that, the patch is Reviewed-by: Leo Liu On 1/3/19 5:20 AM, Das, Indrajit-kumar wrote: > From: Indrajit Das > Date: Thu, 3 Jan 2019 14:36:33 +0530 > Subject: [PATCH] st/va: Return correct status from vlVaQuerySurfaceStatus > > Signed-off-b

Re: [Mesa-dev] [PATCH] pci_ids: add new VegaM pci id

2018-12-21 Thread Liu, Leo
Reviewed-by: Leo Liu On 12/21/18 11:36 AM, Alex Deucher wrote: > Ping? > > On Thu, Dec 20, 2018 at 10:13 AM Alex Deucher wrote: >> Signed-off-by: Alex Deucher >> Cc: mesa-sta...@lists.freedesktop.org >> --- >> include/pci_ids/radeonsi_pci_ids.h | 1 +

Re: [Mesa-dev] [PATCH] radeonsi: fix video APIs on Raven2

2018-11-14 Thread Liu, Leo
Reviewed-by: Leo Liu On 11/13/18 6:51 PM, Marek Olšák wrote: > From: Marek Olšák > > This was missed when I added the new enum. > > Cc: 18.3 > --- > src/gallium/drivers/radeonsi/si_get.c | 9 ++--- > src/gallium/drivers/radeonsi/si_uvd.c | 3 ++- > 2 files

[Mesa-dev] [PATCH] amd/common: check DRM version 3.27 for JPEG decode

2018-10-23 Thread Liu, Leo
JPEG was added after DRM version 3.26 Signed-off-by: Leo Liu Fixes: 4558758c51749(amd/common: add vcn jpeg ip info query) Cc: Boyuan Zhang Cc: Alex Smith --- src/amd/common/ac_gpu_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd

Re: [Mesa-dev] [PATCH 02/15] meson: update required amdgpu version to 2.4.95

2018-10-18 Thread Liu, Leo
On 2018-10-17 3:03 p.m., boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > VCN jpeg requires new hw ip Patch 1 & 2 are: Reviewed-by: Leo Liu > > Signed-off-by: Boyuan Zhang > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g

Re: [Mesa-dev] [PATCH] st/va: use provided sizes and coords for getimage

2018-10-05 Thread Liu, Leo
Reviewed-by: Leo Liu -Original Message- From: Zhang, Boyuan Sent: Friday, October 05, 2018 12:01 PM To: mesa-dev@lists.freedesktop.org Cc: Liu, Leo ; imir...@alum.mit.edu; ckoenig.leichtzumer...@gmail.com; Zhang, Boyuan Subject: [PATCH] st/va: use provided sizes and coords for

Re: [Mesa-dev] [PATCH] radeon/vce: use switch to convert profile idc

2018-09-27 Thread Leo Liu
On 2018-09-26 10:40 AM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang The previous array logic for converting pipe video profile to profile idc relies on the order of pipe_video_profile enum defines. Adding new profile to enum defines may break the logic. Therefore, it's better to use switch

[Mesa-dev] [PATCH] radeon/uvd: use bitstream coded number for symbols of Huffman tables

2018-09-19 Thread Leo Liu
Signed-off-by: Leo Liu Fixes: 130d1f456(radeon/uvd: reconstruct MJPEG bitstream) Cc: "18.2" --- src/gallium/drivers/radeon/radeon_uvd.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/driv

Re: [Mesa-dev] [PATCH 1/4] vl/dri: add 10 bits format supports

2018-09-10 Thread Leo Liu
On 09/10/2018 04:49 PM, Ilia Mirkin wrote: On Mon, Sep 10, 2018 at 4:27 PM, Leo Liu wrote: v2: Tell B10G10R10X2 and R10G10B10X2 formats for different HW. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_dri.c | 69

[Mesa-dev] [PATCH 1/4] vl/dri: add 10 bits format supports

2018-09-10 Thread Leo Liu
v2: Tell B10G10R10X2 and R10G10B10X2 formats for different HW. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_dri.c | 70 2 files changed, 65 insertions(+), 10 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 1/4] vl/dri: add 10 bits format supports

2018-09-10 Thread Leo Liu
Forget the Patch 1, will re-send shortly. It's ming case 24: +vl_dri2_format_for_depth(struct vl_screen *vscreen, int depth) +{ + switch (depth) { + case 24: + case 30: Leo On 09/10/2018 04:27 PM, Leo Liu wrote: v2: Tell B10G10R10X2 and R10G10B10X2 formats for different HW. S

[Mesa-dev] [PATCH 3/4] vl/dri: add color depth to vl winsys

2018-09-10 Thread Leo Liu
For VDPAU use later Signed-off-by: Leo Liu Reviewed-by: Michel Dänzer --- src/gallium/auxiliary/vl/vl_winsys.h | 1 + src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_winsys.h b/src/gallium/auxiliary/vl

[Mesa-dev] [PATCH 4/4] st/vdpau: Use output buffer as back buffer with 24-bit color only

2018-09-10 Thread Leo Liu
Using output buffer with 8 bits video RGB as back buffer certainly is not working for 30 bits color depth visual. Signed-off-by: Leo Liu Reviewed-by: Michel Dänzer --- src/gallium/state_trackers/vdpau/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 2/4] vl/dri3: add support for 10 bits format

2018-09-10 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 29 +++ 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 8e3c4a0e04d..30e732e38eb 100644 --- a/src

[Mesa-dev] [PATCH 1/4] vl/dri: add 10 bits format supports

2018-09-10 Thread Leo Liu
v2: Tell B10G10R10X2 and R10G10B10X2 formats for different HW. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_dri.c | 69 2 files changed, 64 insertions(+), 10 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
On 09/07/2018 11:09 AM, Michel Dänzer wrote: On 2018-09-07 4:13 p.m., Leo Liu wrote: On 09/07/2018 10:07 AM, Michel Dänzer wrote: On 2018-09-07 3:55 p.m., Leo Liu wrote: Signed-off-by: Leo Liu diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3

Re: [Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
On 09/07/2018 10:07 AM, Michel Dänzer wrote: On 2018-09-07 3:55 p.m., Leo Liu wrote: Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium

[Mesa-dev] [PATCH 4/4] vl/dri: add 10 bits format support for DRI2

2018-09-07 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri.c b/src/gallium/auxiliary/vl/vl_winsys_dri.c index bb1ff50488..f3ae788f72 100644 --- a/src/gallium/auxiliary

[Mesa-dev] [PATCH 1/4] vl/dri3: add 10 bits format support for front buffer

2018-09-07 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 0233f58441..7ac6924c78 100644 --- a/src/gallium/auxiliary

[Mesa-dev] [PATCH 3/4] st/vdpau: Use output buffer as DRI3 back buffer with 24 bits color only

2018-09-07 Thread Leo Liu
Using output buffer with 8 bits video RGB as back buffer certainly is not working for 30 bits color depth visual. Signed-off-by: Leo Liu --- src/gallium/state_trackers/vdpau/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/output.c

[Mesa-dev] [PATCH 2/4] vl/dri: add color depth to vl_winsys

2018-09-07 Thread Leo Liu
It will be used for dri2 and dri3 Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys.h | 1 + src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_winsys.h b/src/gallium/auxiliary/vl/vl_winsys.h index

[Mesa-dev] [PATCH] vl/dri3: add support for 10 bits format

2018-09-06 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 8e3c4a0e04d..0233f58441e 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH] vl/dri3: do full teardown on screen_destroy

2018-09-04 Thread Leo Liu
("vl/dri3: implement DRI3 BufferFromPixmap") Cc: Leo Liu Cc: Christian König Signed-off-by: Emil Velikov --- Gents, can you please double-check this. I haven't really looked at the implementation, although the return seems bogus here. Thanks --- src/gallium/auxiliary/vl/vl_winsys_dri3

Re: [Mesa-dev] [PATCH 08/13] radeon/uvd: remove get mjpeg slice header

2018-08-17 Thread Leo Liu
These 3 patches are: Reviewed-by: Leo Liu On 2018-08-16 04:56 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Move the previous get_mjpeg_slice_heaeder function and eoi from "radeon/vcn" to "st/va". Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeo

Re: [Mesa-dev] [PATCH 13/13] radeonsi: enable vcn jpeg decode for raven

2018-08-16 Thread Leo Liu
Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Enable vcn jpeg decode for raven. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_get.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 12/13] winsys/amdgpu: add vcn jpeg cs support

2018-08-16 Thread Leo Liu
0x6000); /* nop packet */ + radeon_emit(rcs, 0x); + } + break; case RING_VCN_DEC: while (rcs->current.cdw & 15) radeon_emit(rcs, 0x81ff); /* nop packet */ The patch is: Reviewed-by: Leo Liu BTW, if you got chance, please fix the NOP for V

Re: [Mesa-dev] [PATCH 11/13] amd/common: add vcn jpeg ip info query

2018-08-16 Thread Leo Liu
Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/amd/common/ac_gpu_info.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common

Re: [Mesa-dev] [PATCH 10/13] radeon/vcn: implement jpeg target buffer cmd

2018-08-16 Thread Leo Liu
Patch 9-10: Acked-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Implement jpeg target buffer cmd by programming registers directly, since there is no firmware for VCN Jpeg decode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH 08/13] radeon/uvd: remove get mjpeg slice header

2018-08-16 Thread Leo Liu
Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Move the previous get_mjpeg_slice_header function from radeon/vcn to st/va. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_uvd.c | 136 1 file

Re: [Mesa-dev] [PATCH 07/13] st/va: get mjpeg slice header

2018-08-16 Thread Leo Liu
On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Move the previous get_mjpeg_slice_header function from radeon/vcn to st/va. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 3 + src/gallium/state_trackers/va/picture_mjpeg.c | 132 ++

Re: [Mesa-dev] [PATCH 06/13] radeon/vcn: add jpeg decode implementation

2018-08-16 Thread Leo Liu
On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Add a new file to handle VCN Jpeg decode specific functions. Use Jpeg specific cmd sending function in end_frame call. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/galli

Re: [Mesa-dev] [PATCH 05/13] radeon/vcn: separate send cmd call from end frame

2018-08-16 Thread Leo Liu
Patch 1-5: Reviewed-by: Leo Liu On 08/16/2018 12:06 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Use function pointer for sending cmd in end_frame call. By doing this, we can assign different cmd sending logics for Jpeg decode later. Signed-off-by: Boyuan Zhang --- src/gallium

Re: [Mesa-dev] [PATCH 04/10] radeon/vcn: implement jpeg decode functions

2018-08-07 Thread Leo Liu
On 08/02/2018 03:44 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 286 ++- 1 file changed, 281 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_jpeg

Re: [Mesa-dev] [PATCH 03/10] radeon/vcn: add jpeg decoder creation

2018-08-07 Thread Leo Liu
On 08/02/2018 03:44 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 1 + src/gallium/drivers/radeon/meson.build | 1 + src/gallium/drivers/radeon/radeon_vcn_jpeg.c | 212 ++

Re: [Mesa-dev] [PATCH 4/4] winsys/amdgpu: fix VDPAU interop by having one amdgpu_winsys_bo per BO

2018-07-18 Thread Leo Liu
The series are Acked-by: Leo Liu On 07/16/2018 06:03 PM, Leo Liu wrote: On 2018-07-16 04:01 PM, Marek Olšák wrote: From: Marek Olšák Dependencies between rings are inserted correctly if a buffer is represented by only one unique amdgpu_winsys_bo instance. Use a hash table keyed by

Re: [Mesa-dev] [PATCH 4/4] winsys/amdgpu: fix VDPAU interop by having one amdgpu_winsys_bo per BO

2018-07-16 Thread Leo Liu
series are: Tested-by: Leo Liu v2: return offset and stride properly --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 36 --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 5 +++ src/gallium/winsys/amdgpu/drm/amdgpu_winsys.h | 5 +++ 3 files changed, 41 insertions

Re: [Mesa-dev] [PATCH] radeon/vce: add firmware support for ver 53 and up

2018-05-09 Thread Leo Liu
Reviewed-by: Leo Liu On 05/08/2018 02:35 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang All vce firmwares with major version greater than or equal to 53 are supported Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce.c | 4 ++-- 1 file changed, 2 insertions

Re: [Mesa-dev] [PATCH] st/vdpau: allow progressive video surface with interop

2018-05-07 Thread Leo Liu
On 05/07/2018 09:14 AM, Christian König wrote: Am 07.05.2018 um 15:03 schrieb Leo Liu: On 05/07/2018 05:10 AM, Christian König wrote: Am 02.05.2018 um 16:51 schrieb Leo Liu: mpv now interop with video surface instead of output surface previously, so it fails with "vlVdpVideoSurfaceD

Re: [Mesa-dev] [PATCH] st/vdpau: allow progressive video surface with interop

2018-05-07 Thread Leo Liu
On 05/07/2018 05:10 AM, Christian König wrote: Am 02.05.2018 um 16:51 schrieb Leo Liu: mpv now interop with video surface instead of output surface previously, so it fails with "vlVdpVideoSurfaceDMABuf", this's fine for Mesa GL, since the code path wi

[Mesa-dev] [PATCH] st/vdpau: allow progressive video surface with interop

2018-05-02 Thread Leo Liu
mpv now interop with video surface instead of output surface previously, so it fails with "vlVdpVideoSurfaceDMABuf", this's fine for Mesa GL, since the code path will fall back to "vlVdpVideoSurfaceGallium", but this's not the case for others Signed-off-by: Leo Liu

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/omx/enc: fix blit setup for YUV LoadImage

2018-04-30 Thread Leo Liu
On 04/30/2018 12:47 PM, Juan A. Suarez Romero wrote: On Fri, 2018-04-27 at 08:32 -0400, Leo Liu wrote: The blit here involves scaling since it's copying from I8 format to R8G8 format. Half of source will be filtered out with PIPE_TEX_FILTER_NEAREST instruction, it looks that GPU always

[Mesa-dev] [PATCH] st/omx/enc: fix blit setup for YUV LoadImage

2018-04-27 Thread Leo Liu
The blit here involves scaling since it's copying from I8 format to R8G8 format. Half of source will be filtered out with PIPE_TEX_FILTER_NEAREST instruction, it looks that GPU always uses the second half as source. Currently we use "1" as the start point of x for R, then causing 1 source pixel of

Re: [Mesa-dev] [PATCH] st/va: Fix typos

2018-04-26 Thread Leo Liu
Hi Drew, This patch along with your other patch are pushed. Thanks for the help. Leo On 04/25/2018 11:55 AM, Leo Liu wrote: Reviewed-by: Leo Liu On 2018-04-25 11:32 AM, Drew Davenport wrote: s/attibute/attribute/ s/suface/surface/ ---   src/gallium/state_trackers/va/surface.c | 48

Re: [Mesa-dev] [PATCH] st/va: Fix typos

2018-04-25 Thread Leo Liu
Reviewed-by: Leo Liu On 2018-04-25 11:32 AM, Drew Davenport wrote: s/attibute/attribute/ s/suface/surface/ --- src/gallium/state_trackers/va/surface.c | 48 - 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/src/gallium/state_trackers/va/surface.c b

Re: [Mesa-dev] [PATCH] st/va: Fix potential buffer overread

2018-04-24 Thread Leo Liu
On 2018-04-24 07:01 PM, Drew Davenport wrote: VASurfaceAttribExternalBuffers.pitches is indexed by plane. Current implementation only supports single plane layout. Reviewed-by: Leo Liu --- src/gallium/state_trackers/va/surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH] radeon/vcn: fix mpeg4 msg buffer settings

2018-04-24 Thread Leo Liu
Reviewed-by: Leo Liu And Cc Mesa-stable as well. On 2018-04-24 04:49 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Previous bit-fields assignments are incorrect and will result certain mpeg4 decode failed due to wrong flag values. This patch fixes these assignments. Signed-off-by

[Mesa-dev] [PATCH 18/22] st/va: add VP9 config to enable profile0

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/config.c | 2 +- src/gallium/state_trackers/va/va_private.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/config.c b/src/gallium/state_trackers/va/config.c index 7bc031a1a2

[Mesa-dev] [PATCH 21/22] radeonsi: use PIPE_FORMAT_P016 format for VP9 profile2

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeonsi/si_get.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 4483ca766d..c8aacfe182 100644 --- a/src/gallium/drivers/radeonsi/si_get.c

[Mesa-dev] [PATCH 12/22] radeonsi: cap VP9 support to progressive buffer

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeonsi/si_get.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 761ca6f4cd..4483ca766d 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++ b/src/gallium

[Mesa-dev] [PATCH 14/22] st/va: add handles for VP9 buffers

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/Makefile.sources | 1 + src/gallium/state_trackers/va/meson.build | 4 +-- src/gallium/state_trackers/va/picture.c| 11 src/gallium/state_trackers/va/picture_vp9.c| 38 ++ src/gallium

[Mesa-dev] [PATCH 22/22] st/va: add VP9 config to enable profile2

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/config.c | 2 +- src/gallium/state_trackers/va/va_private.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/config.c b/src/gallium/state_trackers/va/config.c index ca0183398a

[Mesa-dev] [PATCH 16/22] st/va: add slice parameter handling for VP9

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture_vp9.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_vp9.c b/src/gallium/state_trackers/va/picture_vp9.c index d333a0cbcd..38684ca21e 100644

[Mesa-dev] [PATCH 15/22] st/va: add picture parameter handling for VP9

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture_vp9.c | 52 - 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_vp9.c b/src/gallium/state_trackers/va/picture_vp9.c index 62350692c5..d333a0cbcd 100644

[Mesa-dev] [PATCH 19/22] vl: add VP9 profile2 support

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/util/u_video.h | 1 + src/gallium/include/pipe/p_video_enums.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_video.h b/src/gallium/auxiliary/util/u_video.h index d313497a63..967ebc5748

[Mesa-dev] [PATCH 20/22] radeon/vcn: add VP9 profile2 support

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers/radeon/radeon_vcn_dec.c index b4cfba1713..046b371384 100644 --- a/src/gallium/drivers

[Mesa-dev] [PATCH 13/22] st/va: add VP9 picture to context

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/context.c| 4 src/gallium/state_trackers/va/va_private.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium/state_trackers/va/context.c index 836aa77c36..14e904ee49 100644

[Mesa-dev] [PATCH 17/22] st/va: parse VP9 uncompressed frame header

2018-04-09 Thread Leo Liu
To get some of UVD required parameters. Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 2 +- src/gallium/state_trackers/va/picture_vp9.c | 237 src/gallium/state_trackers/va/va_private.h | 1 + 3 files changed, 239 insertions(+), 1

[Mesa-dev] [PATCH 08/22] radeon/vcn: fill probability table to prob buffers

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 38 + 1 file changed, 38 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers/radeon/radeon_vcn_dec.c index b29ba37b3c..bcfdd33d31 100644 --- a/src

[Mesa-dev] [PATCH 09/22] radeon/vcn: get VP9 msg buffer

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 176 +++- src/gallium/drivers/radeon/radeon_vcn_dec.h | 1 + 2 files changed, 176 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers

[Mesa-dev] [PATCH 10/22] radeon/vcn: add VP9 context buffer

2018-04-09 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_dec.c b/src/gallium/drivers/radeon/radeon_vcn_dec.c index 170cc3fa41..b4cfba1713 100644 --- a/src/gallium

  1   2   3   4   5   6   7   8   >