Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread John Stultz
On Thu, Aug 2, 2018 at 10:25 AM, Mauro Rossi wrote: > Hi, > > > Il giorno gio 2 ago 2018 alle ore 17:51 Emil Velikov > ha scritto: >> >> On 2 August 2018 at 07:47, Mauro Rossi wrote: >> > Hi, >> > >> > Il giorno gio 2 ago 2018 alle ore 02:

[Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-01 Thread John Stultz
Just as a heads up, with mesa3d master (plus my other build fixups I just sent out), I'm seeing a new build failure when building under AOSP/master: external/mesa3d/src/amd/vulkan/Android.mk: error: vulkan.radv (SHARED_LIBRARIES android-arm64) missing libLLVM (SHARED_LIBRARIES android-arm64) You c

[Mesa-dev] [PATCH 3/3 v3] CleanSpec.mk: Remove HOST_OUT_release

2018-08-01 Thread John Stultz
to set an environment variable manually. Thus it was rarely if ever tested. Change-Id: I7972c0a50fa3520dcfa962d6dd7e602bfe22368d Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Reviewed-by: Emil Velikov Signed-off-by: John Stultz -

[Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-08-01 Thread John Stultz
Clark Reviewed-by: Emil Velikov Signed-off-by: Sumit Semwal Signed-off-by: John Stultz --- v2: Conditionalize it for PLATFORM_VERSION Q and higher v3: Rework conditionalization to numbered releases prior to P (9.0) --- Android.common.mk | 7 +++ 1 file changed, 7 insertions(+) diff --

[Mesa-dev] [PATCH 1/3 v3] util: Android.mk: Convert implicit rules to static pattern rules

2018-08-01 Thread John Stultz
don't see build issues without that portion. Comments or feedback would be appreciated! Change-Id: Id6dfd0d018cbd665fa19d80c14abd5f75fa10b8a Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Reviewed-by: Emil Velikov Signed-off-by: Jo

[Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread John Stultz
Sumit Semwal Signed-off-by: John Stultz --- v2: Conditionalize it for PLATFORM_VERSION Q and higher v3: Rework conditionalization to numbered releases prior to P (9.0) --- Android.common.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Android.common.mk b/Android.common.mk index 39

Re: [Mesa-dev] [PATCH 2/3 v2] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread John Stultz
On Thu, Jul 26, 2018 at 12:09 PM, Rob Herring wrote: > Resending from correct email... > > On Thu, Jul 26, 2018 at 12:28 PM John Stultz wrote: >> >> From: Sumit Semwal >> >> This is a forward port of a patch from the AOSP/master tree: >> https://android.go

[Mesa-dev] [PATCH 1/3 v2] util: Android.mk: Convert implicit rules to static pattern rules

2018-07-26 Thread John Stultz
don't see build issues without that portion. Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Reviewed-by: Emil Velikov Signed-off-by: John Stultz --- src/util/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 3/3 v2] CleanSpec.mk: Remove HOST_OUT_release

2018-07-26 Thread John Stultz
to set an environment variable manually. Thus it was rarely if ever tested. Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Reviewed-by: Emil Velikov Signed-off-by: John Stultz --- v2: Add more justification to the comm

[Mesa-dev] [PATCH 2/3 v2] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread John Stultz
Sumit Semwal Signed-off-by: John Stultz --- v2: Conditionalize it for PLATFORM_VERSION Q and higher --- Android.common.mk | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Android.common.mk b/Android.common.mk index 397dc03..3585470 100644 --- a/Android.common.mk +++ b/Android.common.mk @@

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-26 Thread John Stultz
On Thu, Jul 26, 2018 at 6:46 AM, Emil Velikov wrote: > On 25 July 2018 at 20:52, John Stultz wrote: >> On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov >> wrote: >>> On 25 July 2018 at 00:21, John Stultz wrote: >>>> From: Yong Yao >>>> >>>

Re: [Mesa-dev] [RFC][PATCH 5/5] Android.mk: Fix checkbuild on Mac builders.

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 12:33 PM, Alistair Strachan wrote: > On Wed, Jul 25, 2018 at 5:48 AM Emil Velikov wrote: >> >> On 25 July 2018 at 00:21, John Stultz wrote: >> > From: Alistair Strachan >> > >> > This is a forward port of a

Re: [Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 1:06 PM, Dan Willemsen wrote: > On Wed, Jul 25, 2018 at 12:35 PM John Stultz wrote: >> >> On Wed, Jul 25, 2018 at 5:36 AM, Emil Velikov >> wrote: >> > On 25 July 2018 at 00:21, John Stultz wrote: >> >> From: Dan Willemsen >

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 6:50 AM, Rob Herring wrote: > On Tue, Jul 24, 2018 at 5:21 PM John Stultz wrote: >> >> From: Yong Yao >> >> This is a forward port of a patch from the AOSP/master branch: >> https://android.googleso

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov wrote: > On 25 July 2018 at 00:21, John Stultz wrote: >> From: Yong Yao >> >> This is a forward port of a patch from the AOSP/master branch: >> https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51

Re: [Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 5:36 AM, Emil Velikov wrote: > On 25 July 2018 at 00:21, John Stultz wrote: >> From: Dan Willemsen >> >> This is a forward port of a patch from the AOSP/master tree: >> https://android.googlesource.com/platform/external/mesa3d/+/bd633f11de0c6

Re: [Mesa-dev] [RFC][PATCH 2/5] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-25 Thread John Stultz
On Wed, Jul 25, 2018 at 5:34 AM, Emil Velikov wrote: > On 25 July 2018 at 00:21, John Stultz wrote: >> From: Sumit Semwal >> >> This is a forward port of a patch from the AOSP/master tree: >> https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af7

[Mesa-dev] [RFC][PATCH 5/5] Android.mk: Fix checkbuild on Mac builders.

2018-07-24 Thread John Stultz
dependency of AOSP and is not installed on the Mac builders, so we must not build any part of mesa3d on these platforms. Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Signed-off-by: Alistair Strachan Signed-off-by: John Stultz --- Android.mk

[Mesa-dev] [RFC][PATCH 1/5] util: Android.mk: Convert implicit rules to static pattern rules

2018-07-24 Thread John Stultz
don't see build issues without that portion. Comments or feedback would be appreciated! Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Signed-off-by: John Stultz --- src/util/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-24 Thread John Stultz
Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Signed-off-by: John Stultz --- CleanSpec.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CleanSpec.mk b/CleanSpec.mk index d08b0de..e5030ce 100644 --- a/CleanSpec.mk +++ b/CleanSpec.mk @@ -10,7 +10,7 @@ $(call add-clean

[Mesa-dev] [RFC][PATCH 2/5] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-24 Thread John Stultz
build due to redefinition of timespec_get(). Avoid redefinition by defining HAVE_TIMESPEC_GET flag. Test: build and boot tested db820c to UI. Cc: Rob Herring Cc: Alistair Strachan Cc: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Signed-off-by: Sumit Semwal Signed-off-by:

[Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-24 Thread John Stultz
: Marissa Wall Cc: Sumit Semwal Cc: Emil Velikov Cc: Rob Clark Signed-off-by: Harish Krupo Signed-off-by: Yong Yao Signed-off-by: John Stultz --- Android.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Android.mk b/Android.mk index 914854c..494b4b9 100644 --- a/Android.mk +++ b

[Mesa-dev] [RFC][PATCH 0/5] Trying to align mesa upstream w/ AOSP/master

2018-07-24 Thread John Stultz
In trying to keep the upstream mesa aligned with AOSP, I wanted to submit a few changes that seemed reasonable to upstream. The first two are build fixes that are required to get mesa master building with AOSP. The last three are less critical, but seemed like things we might as well try to sync b

[Mesa-dev] [RFC][PATCH] util: Android.mk: Convert implicit rules to static pattern rules

2018-07-17 Thread John Stultz
don't see build issues without that portion. Comments or feedback would be appreciated! Signed-off-by: John Stultz --- src/util/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/Android.mk b/src/util/Android.mk index 9b61442..e463b63 100644 --- a