Re: [Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-20 Thread John Brooks
On Sat, May 20, 2017 at 10:46:00PM +0200, Kai Wasserbäch wrote: > Hey, > John Brooks wrote on 15.05.2017 07:47: > > This fixes the long-standing problem with Dying Light where the game would > > produce a black screen when running under Mesa. This happened because the > &g

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-16 Thread John Brooks
On 05/15/2017 06:52 PM, John Brooks wrote: On 2017-05-15 06:04 PM, Ian Romanick wrote: On 05/12/2017 06:39 AM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-15 Thread John Brooks
On 2017-05-15 06:04 PM, Ian Romanick wrote: On 05/12/2017 06:39 AM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root of the problem is that their vertex shaders

[Mesa-dev] [PATCH v2 0/3] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-14 Thread John Brooks
patch series. I spent a good amount of time with you on that RE those binaries so I think your series LGTM [19:32:57] Frogging101: Reviewed-by: Edward O'Callaghan [19:33:12] If I get a chance to be on the list sometime this week I will Rb them -- John Brooks (F

[Mesa-dev] [PATCH v2 1/3] driconf: Add allow_glsl_builtin_variable_redeclaration option

2017-05-14 Thread John Brooks
l Pitoiset): - Rename allow_glsl_builtin_redeclaration -> allow_glsl_builtin_variable_redeclaration Signed-off-by: John Brooks Reviewed-by: Edward O'Callaghan --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_screen.c | 3 +++ src/mesa/

[Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-14 Thread John Brooks
, so we set the allow_glsl_builtin_variable_redeclaration option for that game as well. v2 (Samuel Pitoiset): - Rename allow_glsl_builtin_redeclaration -> allow_glsl_builtin_variable_redeclaration Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96449 Signed-off-by: John Brooks R

[Mesa-dev] [PATCH v2 2/3] glsl: Conditionally allow redeclaration of built-in variables

2017-05-14 Thread John Brooks
Conditional on allow_glsl_builtin_variable_redeclaration driconf option. v2 (Samuel Pitoiset): - Rename allow_glsl_builtin_redeclaration -> allow_glsl_builtin_variable_redeclaration - style: put spaces after 'if' Signed-off-by: John Brooks Reviewed-by: Edward O'C

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
On Sat, May 13, 2017 at 10:47:17AM +1000, Timothy Arceri wrote: > On 13/05/17 09:55, John Brooks wrote: > >On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: > >>On 13/05/17 00:11, John Brooks wrote: > >>>On Fri, May 12, 2017 at 03:56:26P

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: > On 13/05/17 00:11, John Brooks wrote: > >On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > >> > >> > >>On 05/12/2017 03:39 PM, John Brooks wrote: > >>>Since release

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > > > On 05/12/2017 03:39 PM, John Brooks wrote: > >Since release, Dying Light and Dead Island Definitive Edition have been > >broken > >on Mesa, producing at best only a black screen after loading. I fo

[Mesa-dev] [PATCH 2/3] glsl: Conditionally allow redeclaration of builtins

2017-05-12 Thread John Brooks
Conditional on allow_glsl_builtin_redeclaration driconf option. Signed-off-by: John Brooks --- src/compiler/glsl/ast_to_hir.cpp | 16 src/compiler/glsl/glsl_parser_extras.cpp | 2 ++ src/compiler/glsl/glsl_parser_extras.h | 1 + 3 files changed, 19 insertions

[Mesa-dev] [PATCH 1/3] driconf: Add allow_glsl_builtin_redeclaration option

2017-05-12 Thread John Brooks
This option will allow GLSL builtins to be redeclared verbatim (e.g. redeclaring "in int gl_VertexID" in a vertex shader). This is not strictly valid and would normally fail to compile, but some applications (such as newer Techland ports) do it and need more leniency. Signed-off-by: J

[Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
rs from the #radeon IRC channel for their suggestions and their help with analyzing the game binaries. -- John Brooks Frogging101 on IRC and elsewhere ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] drirc: Add allow_glsl_builtin_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
, so we set the allow_glsl_builtin_redeclaration option for that game as well. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96449 Signed-off-by: John Brooks --- src/mesa/drivers/dri/common/drirc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/