The glx/apple code is quite dated. I think mesa has had a few architectural
changes in the years since it was brought up (~15+ years ago). If someone is
really serious about hardware rendering for X11 apps running on macOS, I'd be
happy to chat with them and point them in the right directions
Hey folks,
I finally had a little bit of time to take a look at mesa and XQuartz for the
first time in ~4 years. I am incredibly impressed that there wasn't more
bitrot. I was expecting a painful few days since I've never looked at meson,
but I was able to get it functional relatively quickly
I think we can instead revert c7f3657450683827446072ad6b1e8fce04078162. I
believe the underlying issue should instead be addressed by
a087a09fa86f9617af98f6294dd2228555a4891c. If any issues remain, we should
address them properly rather than masking them with this.
A quick audit makes me susp
From: Apple SWE
sched_yield is used but the include reference on Darwin is missing. This patch
conditionally guards on Darwin/OSX to import sched.h first.
Reviewed-by: Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia
---
src/gallium/drivers/swr/swr_fence.cpp | 4
1
patch, it is possible to use SWR as an alternate renderer on OSX to
softpipe and
llvmpipe.
Reviewed-by: Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia
---
.../drivers/swr/rasterizer/core/threads.cpp| 56 +-
1 file changed, 55 insertions(+), 1
Signed-off-by: Jeremy Huddleston Sequoia
CC: Nicolai Hähnle
CC: Matt Turner
CC: Ian Romanick
CC: Brian Paul
---
src/mesa/main/shaderapi.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index
017-03-27 at 21:48 +0300, Andres Gomez wrote:
>> Signed-off-by: Andres Gomez
>> Cc: Emil Velikov
>> Cc: Jeremy Huddleston Sequoia
>> ---
>> docs/releasing.html | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/docs/releasing.html b/doc
LGTM
Reviewed-by: Jeremy Sequoia
> On Jan 16, 2017, at 07:45, Emil Velikov wrote:
>
> From: Emil Velikov
>
> Analogous to previous commit.
>
> Cc: "12.0 13.0"
> Cc: Jeremy Huddleston Sequoia
> Signed-off-by: Emil Velikov
> ---
> src/glx/app
> On Dec 6, 2016, at 06:04, Emil Velikov wrote:
>
> On 5 December 2016 at 22:50, Jeremy Huddleston Sequoia
> wrote:
>>
>>> On Dec 5, 2016, at 11:52 AM, Emil Velikov wrote:
>>>
>>> From: Emil Velikov
>>>
>>> No point in havin
eader uses the
> correct GLXPbufferSGIX and both types are a typedef of the same
> primitive XID.
>
> Cc: Jeremy Huddleston Sequoia
> Signed-off-by: Emil Velikov
Reviewed-by: Jeremy Sequoia
(not tested yet, though)
> ---
> Jeremy, humble poke to send any/all Macports patches to
> On Aug 12, 2016, at 05:11, Tapani Pälli wrote:
>
>
>
> On 08/12/2016 01:31 PM, Jeremy Huddleston Sequoia wrote:
>>
>>> On Aug 12, 2016, at 00:41, Tapani Pälli wrote:
>>>
>>>
>>> On 07/18/2016 07:07 PM, Jeremy Huddleston Sequoia
> On Aug 12, 2016, at 00:41, Tapani Pälli wrote:
>
>
> On 07/18/2016 07:07 PM, Jeremy Huddleston Sequoia wrote:
>> Will do. Thanks for pinging me. Early June was very busy and I didn't see
>> this come through. I'll get back to you within a couple day
> reviewed by Emil.
>
> // Tapani
>
>
> On 06/07/2016 01:33 PM, Tapani Pälli wrote:
>> Signed-off-by: Tapani Pälli
>> Cc: Jeremy Huddleston Sequoia
>> ---
>> src/glx/apple/apple_xgl_api_stereo.c | 4 ++--
>> src/glx/apple/apple_xgl_api_viewport.c
> On Jun 7, 2016, at 03:25, Emil Velikov wrote:
>
> On 31 May 2016 at 10:53, Tapani Pälli wrote:
>> From: Daniel Czarnowski
>>
>> GLX documentation states:
>>glXCreateNewContext can generate the following errors: (...)
>>GLXBadFBConfig if config is not a valid GLXFBConfig
>>
Signed-off-by: Jeremy Huddleston Sequoia
CC: Nicolai Hähnle
CC: Matt Turner
CC: Ian Romanick
---
src/mesa/main/shaderapi.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index 8c1fba8
Signed-off-by: Jeremy Huddleston Sequoia
CC: Nicolai Hähnle
CC: Matt Turner
---
src/mesa/main/shaderapi.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index a988f41..7a0d19a 100644
--- a/src/mesa
> On Jan 21, 2016, at 07:51, Nicolai Hähnle wrote:
>
> Wow... did you actually run into that crash?
No. I was just paying attention to compiler warnings ;)
>
> On 20.01.2016 20:14, Jeremy Huddleston Sequoia wrote:
>> Signed-off-by: Jeremy Huddleston Sequoia
>
This series includes 3 changes related to help reconcile the differences in
declaration between Apple's vs Mesa's GLhandleARB type. The first, I expect to
be mostly uncontroversial as they are mainly cleaning up and correcting some
prototypes. The second is just a casting which should be fine.
: incompatible pointer types passing 'void
(GLhandleARB)' (aka 'void (unsigned long)') to parameter of type 'void
(*)(GLuint)' (aka 'void (*)(unsigned
int)')
[-Wincompatible-pointer-types]
SET_UseProgram(table, save_UseProgramObjectARB);
"glDeleteObjectARB(%u)\n", obj);
~~ ^~~
%lu
Signed-off-by: Jeremy Huddleston Sequoia
---
src/mesa/main/shaderapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index 9512e3b..a988f41 100644
--- a/src/mesa/main/sha
Signed-off-by: Jeremy Huddleston Sequoia
---
src/mesa/main/shaderapi.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index a988f41..75fc17c 100644
--- a/src/mesa/main/shaderapi.c
+++ b/src/mesa/main
Sorry, I thought I responded to this a while ago.
Reviewed-by: Jeremy Huddleston Sequoia
Tested-by: Jeremy Huddleston Sequoia
--Jeremy
> On Jan 19, 2016, at 05:21, Andreas Boll wrote:
>
> Jeremy, did you have a chance to test this patch?
> This patch would be still useful for O
The general concept of this change seems fine to me.
Given the desire to keep glapi as similar as possible across platforms, would
it be better to just move this into glx/apple rather than leaving it in glapi?
> On Dec 9, 2015, at 09:07, Emil Velikov wrote:
>
> On 9 December 2015 at 14:11, And
r, then the best thing might be
> to remove it entirely.
>
> On Sat, Sep 26, 2015 at 5:56 PM, Jeremy Huddleston Sequoia
> wrote:
> Reviewing diffs of code that generates code is always ick. =(
>
> This *looks* right to me, but has it been given a beating for correctness?
>
Sorry, been slammed and trying to catch up. I forget if I replied to this or
not, but if you're still waiting on me:
Reviewed-by: Jeremy Huddleston Sequoia
> On Jul 9, 2015, at 10:55, Ian Romanick wrote:
>
> I can't really speak to the Android.mk or SConscript changes
Reviewing diffs of code that generates code is always ick. =(
This *looks* right to me, but has it been given a beating for correctness? If
not, let me know, and I'll give it a whirl when I have some cycles.
Reviewed-by: Jeremy Huddleston Sequoia
---
You're right that this used to
Wow, that's a blast from the past ;)
> On Sep 3, 2015, at 21:36, Matt Turner wrote:
>
> From: Jeremy Huddleston
>
> Cc: "10.6 11.0"
> Bugzilla: https://bugs.gentoo.org/240956
> ---
> After talking with Ian today, we determined that this disables an
> optimization.
>
> And FWIW, NVIDIA's fork
> On May 20, 2015, at 13:59, Emil Velikov wrote:
>
> Hi Jeremy,
>
> On 11 February 2015 at 20:36, Jeremy Huddleston Sequoia
> wrote:
>>
>> Signed-off-by: Jeremy Huddleston Sequoia
>> ---
>> include/GL/glext.h | 1 +
>> 1 file changed, 1 inser
Looks right to me. I think this was also mentioned in the bugzilla ticket
where this change was committed from.
Reviewed-by: Jeremy Huddleston Sequoia
> On May 15, 2015, at 19:05, Alan Coopersmith
> wrote:
>
> Fixes regression from commit 5b2d3480f57168d50ad24cf0b8c9
Signed-off-by: Jeremy Huddleston Sequoia
---
include/GL/glext.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/GL/glext.h b/include/GL/glext.h
index 256ad35..0328cf6 100644
--- a/include/GL/glext.h
+++ b/include/GL/glext.h
@@ -4470,6 +4470,7 @@ GLAPI void APIENTRY glVertexBlendARB
> On Feb 11, 2015, at 05:02, Emil Velikov wrote:
>
> On 11 February 2015 at 10:32, Jeremy Huddleston Sequoia
> wrote:
>> libOSMesa is a library, not a module
>>
> Fwiw I'm not 100% sure that's the case. But considering it's been like
> that* for a
libOSMesa is a library, not a module
Signed-off-by: Jeremy Huddleston Sequoia
---
src/mesa/drivers/osmesa/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/osmesa/Makefile.am
b/src/mesa/drivers/osmesa/Makefile.am
index 589b5ee..8d69915 100644
--- a/src/mesa
Is there any indication on when is this "temporary" hack going to be removed?
This kind of linking is not legal in many toolchains (eg on darwin), and I
imagine behavior is not well defined in places where this hack actually works.
--Jeremy
commit 7414552b1826ece48a622c14b48cad3a37b68025
Autho
Fixes regression from commit 64b1dc44495890cbc2c7c5509cb830264020998c
Signed-off-by: Jeremy Huddleston Sequoia
CC: Emil Velikov
CC: jon.tur...@dronecode.org.uk
CC: io...@macports.org
---
src/mesa/drivers/dri/swrast/swrast.c | 16
1 file changed, 16 insertions(+)
diff --git a
e we don't even want to return
the full size of system memory for __DRI2_RENDERER_VIDEO_MEMORY.
> On Jan 1, 2015, at 20:10, Jeremy Huddleston Sequoia
> wrote:
>
> Fixes regression from commit 64b1dc44495890cbc2c7c5509cb830264020998c
>
> Signed-off-by: Jeremy Huddleston
I'm trying to take a stab at adding core profile support to XQuartz. As a
first step, I'm trying to add GLX_ARB_create_context and
GLX_ARB_create_context_profile.
For now, I want to make sure that GLX_ARB_create_context and
GLX_ARB_create_context_profile are only advertised as being available
On May 24, 2014, at 19:55, Emil Velikov wrote:
> On 25/05/14 02:12, Jeremy Huddleston Sequoia wrote:
>> I'm getting this build failure:
>>
>> main/shader_query.cpp:49:7: error: no matching function for call to
>> '_mesa_lookup_shader_program_err'
&
I'm getting this build failure:
main/shader_query.cpp:49:7: error: no matching function for call to
'_mesa_lookup_shader_program_err'
_mesa_lookup_shader_program_err(ctx, program, "glBindAttribLocation");
^~~
../../src/mesa/main/shaderobj.h:81:1: note: cand
On May 20, 2014, at 05:57, Jon TURNEY wrote:
> On 20/05/2014 09:57, Jeremy Huddleston Sequoia wrote:
>> Reviewed-by: Jeremy Huddleston Sequoia with one minor change (see below):
>
> Thanks very much for taking the time to review these.
No, thank you for taking the time to do th
Reviewed-by: Jeremy Huddleston Sequoia
On May 13, 2014, at 05:15, Jon TURNEY wrote:
> - Don't require xcb-dri[23] etc. if we aren't building for a target with DRM,
> as
> we won't be using dri[23]
>
> - Enable a more fine-grained control of what DRI code is bui
Reviewed-by: Jeremy Huddleston Sequoia with one minor
change (see below):
On May 13, 2014, at 05:15, Jon TURNEY wrote:
...
> diff --git a/src/glx/Makefile.am b/src/glx/Makefile.am
> index eee7c2c..c18d1c5 100644
> --- a/src/glx/Makefile.am
> +++ b/src/glx/Makefile.am
>
On Feb 17, 2014, at 13:29, Emil Velikov wrote:
> On 17/02/14 06:49, Jeremy Huddleston Sequoia wrote:
>>
>> On Feb 16, 2014, at 17:15, Emil Velikov wrote:
>>
>>> On 16/02/14 02:00, Jeremy Huddleston Sequoia wrote:
>>>> Mesa master hasn't built fo
On Feb 16, 2014, at 17:15, Emil Velikov wrote:
> On 16/02/14 02:00, Jeremy Huddleston Sequoia wrote:
>> Mesa master hasn't built for OSX for over a year now, unfortunately, but I
>> agree excluding in Makefile.am is preferable to cpp-guards. Hopefully
>> "
Mesa master hasn't built for OSX for over a year now, unfortunately, but I
agree excluding in Makefile.am is preferable to cpp-guards. Hopefully
"someone" will have the time and patience to get it working again in the near
future.
--Jeremy
Sent from my iPad
> On Feb 13, 2014, at 8:29, Ian Ro
Yep, looks right to me.
Reviewed-by: Jeremy Huddleston Sequoia:
On Feb 10, 2014, at 07:57, Ian Romanick wrote:
> Perhaps Jeremy can review this patch...
>
> On 02/10/2014 01:58 AM, Siavash Eliasi wrote:
>> ---
>> src/glx/apple/apple_glx_context.c | 1 +
>>
Tested-by: Jeremy Huddleston Sequoia
I tried applying that change to current master
(a0698b000b693fc1345fadd6d418dfd8d7548e44), and it didn't work at first, but
after a make clean it did. It looks like the Makefile dependencies were
insufficient to propagate this change properly. O
Mesa master stopped building successfully on my tinderbox on 7/6. The relevant
changes from the previous successful build were 95ce454..c445b0f, and I
bisected it to the upgrade of gl2ext.h to version 18099 (see below).
../../../src/mapi/glapi/glapitemp.h:4635:1: error: no previous prototype fo
47 matches
Mail list logo
