Re: [Mesa-dev] [PATCH 2/2] radeonsi: clamp point size to the limit

2018-10-17 Thread Jakob Bornecrantz
Tested-by: Jakob Bornecrantz On Wed, Oct 17, 2018 at 5:29 PM Marek Olšák wrote: > > From: Marek Olšák > > This fixes dEQP-GLES2.functional.rasterization.limits.points. > Broken by: ea039f789d9b54e1bd1d644b6a29863ca3500314 > --- > src/gallium/drivers/radeonsi/si_get.c | 5

Re: [Mesa-dev] [PATCH 1/2] radeonsi: fix a VGT hang with primitive restart on Polaris10 and later

2018-10-17 Thread Jakob Bornecrantz
Tested-by: Jakob Bornecrantz On Wed, Oct 17, 2018 at 5:29 PM Marek Olšák wrote: > > From: Marek Olšák > > Cc: 18.1 18.2 > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/s

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Jakob Bornecrantz
On Wed, Sep 19, 2018 at 1:48 PM Ilia Mirkin wrote: > > On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz > wrote: > > This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full > > setup is dEQP running on virgl with vtest that is running RadeonSI. So > >

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-19 Thread Jakob Bornecrantz
This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full setup is dEQP running on virgl with vtest that is running RadeonSI. So QEMU is not in the picture. All instances of the Mesa driver is from the same tree and have the patch applied. Cheers, Jakob. On Wed, Sep 12, 2018 at 12:05 PM

Re: [Mesa-dev] [PATCH 07/14] st/mesa: set ctx->Const.SubPixelBits

2018-08-28 Thread Jakob Bornecrantz
On Thu, Aug 9, 2018 at 12:57 AM Marek Olšák wrote: > > From: Marek Olšák This patch causes regressions in dEQP[1] on virgl running on a radeonSI device. Not a lot of drivers set PIPE_CAP_VIEWPORT_SUBPIXEL_BITS but SubPixelBits is by default set to 4, but this overwrites it without checking if th

Re: [Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

2018-08-15 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz On Tue, Aug 14, 2018 at 2:02 PM, Erik Faye-Lund wrote: > Instead of doing conservative guesses, we should report the max levels > based on the max sizes we get from GL on the host. > > Signed-off-by: Erik Faye-Lund > --- > src/gallium/driver

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

2018-08-15 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz On Tue, Aug 14, 2018 at 2:02 PM, Erik Faye-Lund wrote: > These macro-names are also used for softpipe, so let's avoid confusion > by avoiding them. Besides, they are just used in one place in virgl, so > let's just inline them into the place th

Re: [Mesa-dev] [virglrenderer-devel] [PATCH] virgl/vtest: add support to vtest for new cap getting.

2018-06-28 Thread Jakob Bornecrantz
On 2018-06-27 23:26, Dave Airlie wrote: On 28 June 2018 at 03:25, Jakob Bornecrantz wrote: On 2018-06-08 07:22, Dave Airlie wrote: From: Dave Airlie The vtest protocol is pretty simple but also pretty dumb, and the v1 caps query was fixed size, with no nice way to expand it, however the

Re: [Mesa-dev] [virglrenderer-devel] [PATCH] virgl/vtest: add support to vtest for new cap getting.

2018-06-27 Thread Jakob Bornecrantz
On 2018-06-08 07:22, Dave Airlie wrote: From: Dave Airlie The vtest protocol is pretty simple but also pretty dumb, and the v1 caps query was fixed size, with no nice way to expand it, however the server also ignores any command it doesn't understand. So we can query v2 caps by sending a v2 fo

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-18 Thread Jakob Bornecrantz
On Mon, Jun 18, 2018 at 1:06 PM Elie Tournier wrote: > > On Mon, Jun 18, 2018 at 12:06:42PM +0100, Jakob Bornecrantz wrote: > > TGSI already has a invariant field on declarations, we are running > > into a bug with virgl because st_glsl_to_tgsi completely drops the > > inv

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-18 Thread Jakob Bornecrantz
TGSI already has a invariant field on declarations, we are running into a bug with virgl because st_glsl_to_tgsi completely drops the invariant flag on the floor when it comes to declarations (tho precise is added to the ops). But virgl can't express precise ops (only invariant and precise declarat

Re: [Mesa-dev] [PATCH v2] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

2018-05-18 Thread Jakob Bornecrantz
I have run this patch on my Intel host running various CTS in a virgl guest. Not sure if this constitutes as a Tested-by or a Acked-by, but at least it is a datapoint. Cheers, Jakob. On Fri, May 18, 2018 at 11:04 AM, Tomeu Vizoso wrote: > Virgl could save a lot of work converting buffers in the

Re: [Mesa-dev] [PATCH] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

2018-05-16 Thread Jakob Bornecrantz
Tested-by: Jakob Bornecrantz On Mon, May 14, 2018 at 3:14 PM, Tomeu Vizoso wrote: > Virgl could save a lot of work converting buffers in the host side > between formats if Mesa supported a bunch of other formats when reading > pixels. > > This commit adds cases to handle spec

Re: [Mesa-dev] [PATCH] st/mesa: Also use PIPE_FORMAT_R8G8B8A8_SRGB for framebuffer_sRGB.

2018-04-03 Thread Jakob Bornecrantz
Thanks for the review. Cheers, Jakob. On Tue, Apr 3, 2018 at 5:37 PM, Brian Paul wrote: > On 04/03/2018 10:06 AM, Jakob Bornecrantz wrote: >> >> When running virgl on a GLES host the only sRGB formats that support >> rendering is RGBA and RGBX. That pipe format is in the

[Mesa-dev] [PATCH] virgl: Update virgl_hw.h

2018-04-03 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- src/gallium/drivers/virgl/virgl_hw.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/drivers/virgl/virgl_hw.h index 93849c03dd..180dead80a 100644 --- a/src/gallium/drivers/virgl/virgl_hw.h +++ b/src

[Mesa-dev] [PATCH] st/mesa: Also use PIPE_FORMAT_R8G8B8A8_SRGB for framebuffer_sRGB.

2018-04-03 Thread Jakob Bornecrantz
When running virgl on a GLES host the only sRGB formats that support rendering is RGBA and RGBX. That pipe format is in the sRGB default lists that the state tracker uses when mapping mesa formats. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz --- src/mesa/state_tracker/st_extensions.c | 3

Re: [Mesa-dev] [PATCH] vbo: MaxVertexAttribStride is not always set

2018-03-30 Thread Jakob Bornecrantz
On 2018-03-30 16:49, Mathias Fröhlich wrote: On Friday, 30 March 2018 17:38:39 CEST Jakob Bornecrantz wrote: This assert is hit on hardware which does expose GL 4.4 or GLES 3.1. Uff - sorry! Reviewed-by: Mathias Fröhlich Thanks, tho that should be "which does NOT expose" but y

[Mesa-dev] [PATCH] vbo: MaxVertexAttribStride is not always set

2018-03-30 Thread Jakob Bornecrantz
This assert is hit on hardware which does expose GL 4.4 or GLES 3.1. Signed-off-by: Jakob Bornecrantz --- src/mesa/vbo/vbo_save_api.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index a367a569c8..71304ede49

Re: [Mesa-dev] [PATCH 1/2] meson: provide Makefile.sources variables to meson build

2017-10-16 Thread Jakob Bornecrantz
On Mon, Oct 16, 2017 at 6:58 PM, Scott D Phillips wrote: > Dylan Baker writes: > >> Quoting Scott D Phillips (2017-10-16 10:04:45) >> > Dylan Baker writes: >> > >> > > Quoting Jakob Bornecrantz (2017-10-14 13:03:14) >> > > > On S

Re: [Mesa-dev] [PATCH 06/10] gbm: remove incorrect DRIImage version check in gbm_dri_bo_import()

2017-10-16 Thread Jakob Bornecrantz
c87ed4 ("dri: Make query image WIDTH and HEIGHT be version 4") > Cc: Jakob Bornecrantz > Signed-off-by: Emil Velikov Reviewed-by: Jakob Bornecrantz Cheers, Jakob. > --- > src/gbm/backends/dri/gbm_dri.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

Re: [Mesa-dev] [PATCH 05/10] gbm: handle queryImage() failure through rest of gbm_dri_bo_import()

2017-10-16 Thread Jakob Bornecrantz
On Mon, Oct 16, 2017 at 5:04 PM, Emil Velikov wrote: > From: Emil Velikov > > Fixes: 6a7dea93fa7 ("dri: Rework planar image interface") > Cc: Jakob Bornecrantz > Signed-off-by: Emil Velikov Reviewed-by: Jakob Bornecrantz Cheers, Jakob. > --- > src/

[Mesa-dev] [PATCH] docs: Add EXT_memory_objects extensions to features.txt

2017-10-15 Thread Jakob Bornecrantz
These extensions are important for Vulkan interop and various other use cases. So it would be nice if we tracked them. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz --- docs/features.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/features.txt b/docs/features.txt index

Re: [Mesa-dev] [PATCH 1/2] meson: provide Makefile.sources variables to meson build

2017-10-14 Thread Jakob Bornecrantz
On Sat, Oct 14, 2017 at 1:36 AM, Dylan Baker wrote: > I'm not sure about this approach, we would need a way to add depends to meson, > but I'm also worried that calling make adds another dependency that could be > problematic for windows, and I really don't like the idea of having a > half-and-hal

Re: [Mesa-dev] initial meson port

2017-09-21 Thread Jakob Bornecrantz
On Thu, Sep 21, 2017 at 2:20 AM, Eric Anholt wrote: > Dylan Baker writes: >> Results >> autotools : sh -c 535.34s user 30.33s system 310% cpu 3:02.05 total >> meson : sh -c 136.58s user 11.98s system 372% cpu 39.895 total > > I just want to point at these numbers again. meson is so trans

Re: [Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

2016-06-22 Thread Jakob Bornecrantz
So I have encountered bug that should be fixed by this. In my case its a happy little accident that I can use GL_ARB_gpu_shader5 in a compatibility context (since I want the textureGatherOffset functions). So while one part of me is happy that the bug exist. Cheers, Jakob.

Re: [Mesa-dev] [PATCH] gallium/tests: add missing arg to util_make_vertex_passthrough_shader()

2014-11-17 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz On 17 Nov 2014 18:11, "Brian Paul" wrote: > Fix oversights from the "add a window_space option to the passthrough > vertex shader" patch. > --- > src/gallium/tests/trivial/quad-tex.c |2 +- > src/gallium/tests/trivial/tri.

Re: [Mesa-dev] [PATCH 3/3] rbug-gui: add a spin button to select the layer index to display

2014-08-25 Thread Jakob Bornecrantz
nged, 136 insertions(+), 38 deletions(-) I'm assuming most of those random changes in the xml are due to the editing app doing stupid stuff. If that is the case and since the code changes looks good to me, this patch is Reviewed-by: Jakob Bornecrantz Cheers, Jakob.

Re: [Mesa-dev] [PATCH 2/3] rbug-gui: print texture target and format in the info column

2014-08-24 Thread Jakob Bornecrantz
On Sun, Aug 24, 2014 at 2:16 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/texture.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Jakob Bornecrantz > > diff --git a/src/texture.c b/src/texture.c > index 659d0de..40

Re: [Mesa-dev] [PATCH 1/3] rbug-gui: fix build for latest Mesa

2014-08-24 Thread Jakob Bornecrantz
On Sun, Aug 24, 2014 at 2:16 PM, Marek Olšák wrote: > From: Marek Olšák > > set c99 because u_math.h fails to compile without it with gcc > --- > Makefile.in | 5 +++-- > configure.ac | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Jakob Bornecran

Re: [Mesa-dev] [PATCH] st/xa: Don't close the drm fd on failure v2

2014-07-03 Thread Jakob Bornecrantz
ate_trackers/xa/xa_tracker.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Jakob Bornecrantz Cheers, Jakob. > > diff --git a/src/gallium/state_trackers/xa/xa_tracker.c > b/src/gallium/state_trackers/xa/xa_tracker.c > index 6e4312e..268d56b 100644 &

Re: [Mesa-dev] [PATCH] scons: avoid building any piece of i915

2014-06-21 Thread Jakob Bornecrantz
15/sw/SConscript | 12 > 3 files changed, 35 deletions(-) > delete mode 100644 src/gallium/drivers/i915/SConscript > delete mode 100644 src/gallium/winsys/i915/sw/SConscript Reviewed-by: Jakob Bornecrantz > > diff --git a/src/gallium/SConscript b/src/gallium/SConscript >

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Jakob Bornecrantz
Thanks again, and fair enough. :) Cheers, Jakob. On Thu, Jun 19, 2014 at 1:22 PM, Marek Olšák wrote: > Yes, that's correct. However, it's better to duplicate the same code > twice than ten times. > > Marek > > On Thu, Jun 19, 2014 at 1:12 PM, Jakob Bornecrantz >

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Jakob Bornecrantz
On Thu, Jun 19, 2014 at 1:08 PM, Marek Olšák wrote: > Hi Jakob, > > libdricore was nuked quite some time ago. What classic drivers now use > is all drivers in mesa_dri_drivers.so and the _dri.so files are > hardlinks to that file. Ah, thanks for the info. Wouldn't that mean that mesa core code li

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-19 Thread Jakob Bornecrantz
On Tue, Jun 17, 2014 at 8:38 PM, Emil Velikov wrote: > Hi all, > > As a follow up to the static/shared pipe-drivers series here is the final > series (if anyone is interested I may take a look at egl + opencl) of > refactoring the gallium dri targets into a single library/provider. > > In a nutshe

Re: [Mesa-dev] [PATCH] rbug: add missing pipe->blit() entrypoint

2014-05-21 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz On Wed, May 21, 2014 at 1:44 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/rbug/rbug_context.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/

Re: [Mesa-dev] [PATCH 03/23] scons: remove dri-i915 build target

2014-05-20 Thread Jakob Bornecrantz
Acked-by: Jakob Bornecrantz On Sun, May 18, 2014 at 9:07 AM, Emil Velikov wrote: > Unmaintained and broken. > > Cc: Jakob Bornecrantz > Signed-off-by: Emil Velikov > --- > scons/gallium.py | 1 - > src/gallium/SConscript

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit "Cache render target surface"

2014-05-08 Thread Jakob Bornecrantz
1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jakob Bornecrantz > diff --git a/src/gallium/state_trackers/xa/xa_context.c > b/src/gallium/state_trackers/xa/xa_context.c > index 37de45b..df3043c 100644 > --- a/src/gallium/state_trackers/xa/xa_context.c > +++ b/src/g

Re: [Mesa-dev] [PATCH] st/xa: Fix performance regression introduced by commit "Cache render target surface"

2014-05-08 Thread Jakob Bornecrantz
1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Jakob Bornecrantz > diff --git a/src/gallium/state_trackers/xa/xa_context.c > b/src/gallium/state_trackers/xa/xa_context.c > index 37de45b..df3043c 100644 > --- a/src/gallium/state_trackers/xa/xa_context.c > +++ b/sr

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jakob Bornecrantz
On 10 Apr 2014 15:56, "Brian Paul" wrote: > > On 04/10/2014 01:43 AM, Jakob Bornecrantz wrote: >> >> On Thu, Apr 10, 2014 at 3:26 AM, Brian Paul wrote: >>> >>> We were using REALLOC() from u_memory.h but FREE() from imports.h. >>> This m

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler_view REALLOC/FREE macro mix-up

2014-04-10 Thread Jakob Bornecrantz
t; --- > src/mesa/state_tracker/st_cb_texture.c |2 +- > src/mesa/state_tracker/st_texture.c| 12 > src/mesa/state_tracker/st_texture.h|3 +++ > 3 files changed, 16 insertions(+), 1 deletion(-) Is this patch obsoleted by the FREE/MALLOC remove series? Otherwise thi

Re: [Mesa-dev] [PATCH 1/5] mesa: use malloc/free instead of MALLOC/FREE in attrib stack code

2014-04-10 Thread Jakob Bornecrantz
insertions(+), 10 deletions(-) > > Series is: > Reviewed-by: Kenneth Graunke Was looking trough the series but couldn't find the first patch, but now I have and also the series is: Reviewed-by: Jakob Bornecrantz ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] svga: move LIST_INITHEAD(dirty_buffers) earlier in svga_context_create()

2014-04-09 Thread Jakob Bornecrantz
; Found/fixed by Charmaine Lee. > > Cc: "10.0" > --- > src/gallium/drivers/svga/svga_context.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jakob Bornecrantz Cheers, Jakob ___ mesa-dev mailing list mesa

Re: [Mesa-dev] [PATCH] st/xa: Bind destination before setting new state

2014-04-07 Thread Jakob Bornecrantz
r inconsistent sampler state / > sampler view setup. > > Signed-off-by: Thomas Hellstrom > --- > src/gallium/state_trackers/xa/xa_renderer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Jakob Bornecrantz Cheers, Jakob. > > diff

Re: [Mesa-dev] [PATCH 1/2] winsys/svga: Update the vmwgfx_drm.h header to latest version from kernel

2014-04-07 Thread Jakob Bornecrantz
On Mon, Apr 7, 2014 at 11:50 AM, Thomas Hellstrom wrote: > Cc: "10.1" > Signed-off-by: Thomas Hellstrom > > --- > src/gallium/winsys/svga/drm/vmwgfx_drm.h | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) Both patches are: Reviewed-by: Jakob

Re: [Mesa-dev] [PATCH] gallium/rtasm: handle mmap failures appropriately

2014-01-27 Thread Jakob Bornecrantz
, leaving only the crucial mmap check >> >> Gents can someone take a look at this trivial patch. >> >> Cheers, >> Emil Reviewed-by: Jakob Bornecrantz >> --- >> src/gallium/auxiliary/rtasm/rtasm_execmem.c | 10 +++--- >> 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] st/mesa: pass correct pipe_texture_target to st_choose_format()

2013-11-18 Thread Jakob Bornecrantz
Good catch, both patches in the series are Reviewed-by: Jakob Bornecrantz Cheers, Jakob. On Mon, Nov 18, 2013 at 11:55 PM, Brian Paul wrote: > We were always passing PIPE_TEXTURE_2D, but not all formats are > supported for all types of textures. In particular, the driver may > not

Re: [Mesa-dev] [PATCH] svga: dynamically allocate svga_texture::rendered_to array

2013-11-16 Thread Jakob Bornecrantz
Reviewed-by: Jakob Bornecrantz On Sat, Nov 16, 2013 at 4:49 PM, Brian Paul wrote: > Needs to be larger than 6 to accomodate 3D textures and array textures. > Fixes a few piglit tests (fbo-3d, copyteximage 3D). > --- > src/gallium/drivers/svga/svga_resource_texture.c |9 + &g

Re: [Mesa-dev] Dropping the xorg state tracker

2013-11-06 Thread Jakob Bornecrantz
On Thu, Nov 7, 2013 at 3:30 AM, Stéphane Marchesin wrote: > On Wed, Nov 6, 2013 at 5:43 PM, Matt Turner wrote: >> With the removal of the r600 and radeonsi xorg targets, the only ones >> left are i915 and nouveau. Does anyone have a compelling reason to >> keep them (and the state tracker code it

Re: [Mesa-dev] [PATCH] gallium/dri-targets: hide all symbols except for __driDriverExtensions

2013-09-12 Thread Jakob Bornecrantz
ke to see VISIBILITY_CFLAGS be added to st/dri and > the dri targets, which directly list source files from libdrmcommon in > their SOURCES. Besides, it seems __driConfigOptions and > __dri2ConfigOptions are also marked PUBLIC. Do they need to be > exported? > I tested the v2 pat

Re: [Mesa-dev] [RFC] Consolidate the remaining source files to Makefile.sources

2013-09-12 Thread Jakob Bornecrantz
On Thu, Aug 15, 2013 at 7:04 PM, Emil Velikov wrote: > Hello list > > Feeling inspired by the automake work done in mesa, I felt like > finishing a few things that did not receive too much attention > * use Makefile.sources wherever possible > * cleanup the duplicated C{,PP,XX}FLAGS and factor o

Re: [Mesa-dev] [PATCH] egl: Do not export private symbols

2013-08-06 Thread Jakob Bornecrantz
On Wed, Aug 7, 2013 at 2:00 AM, Chad Versace wrote: > On 08/06/2013 03:02 PM, Jakob Bornecrantz wrote: > >> On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz > >wrote: >> >> On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace < >>> chad.vers...@linux.intel.co

Re: [Mesa-dev] [PATCH] egl: Do not export private symbols

2013-08-06 Thread Jakob Bornecrantz
On Wed, Aug 7, 2013 at 12:00 AM, Jakob Bornecrantz wrote: > On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace > wrote: > >> libEGL was incorrectly exporting *all* symbols, public and private. >> This patch adds -fvisibility=hidden to libEGL's linker flags to ensure >>

Re: [Mesa-dev] [PATCH] egl: Do not export private symbols

2013-08-06 Thread Jakob Bornecrantz
On Tue, Aug 6, 2013 at 9:21 PM, Chad Versace wrote: > libEGL was incorrectly exporting *all* symbols, public and private. > This patch adds -fvisibility=hidden to libEGL's linker flags to ensure > that only symbols annotated with __attribute__((visibility("default"))) > get exported. > > Sanity-ch

Re: [Mesa-dev] [PATCH vmwgfx] update for XA API changes

2013-07-24 Thread Jakob Bornecrantz
Sure, okay with me. I'll push this patch to the video-vmware repo. Cheers, Jakob. On Thu, Jul 25, 2013 at 1:20 AM, Rob Clark wrote: > On Wed, Jul 24, 2013 at 6:33 PM, Jakob Bornecrantz > wrote: > > On Thu, Jul 11, 2013 at 1:58 AM, Jakob Bornecrantz > > > wrote: >

Re: [Mesa-dev] [PATCH vmwgfx] update for XA API changes

2013-07-24 Thread Jakob Bornecrantz
On Thu, Jul 11, 2013 at 1:58 AM, Jakob Bornecrantz wrote: > Just tried this out, on your XA branch, and I'm getting rendering > issues in gnome-terminal. It looks like some text is offset by > one or two lines, and the rest looks a bit like pitch issues. > > http://i.imgur.c

Re: [Mesa-dev] [RFC] Mesa 9.2 and release process changes

2013-07-19 Thread Jakob Bornecrantz
On Fri, Jul 19, 2013 at 7:42 PM, Kenneth Graunke wrote: > On 07/10/2013 04:38 PM, Ian Romanick wrote: > [snip] > > Could we just change our "Mark the patch with 'NOTE: ...'" policy with >> "To have the patch automatically included in the stable tree, add the tag >> Cc: >> mesa-stable@lists.

Re: [Mesa-dev] [PATCH vmwgfx] update for XA API changes

2013-07-10 Thread Jakob Bornecrantz
Just tried this out, on your XA branch, and I'm getting rendering issues in gnome-terminal. It looks like some text is offset by one or two lines, and the rest looks a bit like pitch issues. http://i.imgur.com/mdivF0q.png I can't really see anything in the patch that would cause this, going to ta

Re: [Mesa-dev] [RFC] Mesa 9.2 and release process changes

2013-07-02 Thread Jakob Bornecrantz
On Tue, Jul 2, 2013 at 11:37 PM, Matt Turner wrote: > On Tue, Jul 2, 2013 at 1:02 PM, Ian Romanick wrote: > > 2. Instead of just posting md5sum for the release tarballs, I think we > > should start GPG signing them. I'm not sure what sort of process we > want to > > establish for this. Should

Re: [Mesa-dev] [PATCH mesa 0/8] XA patches for freedreno/a3xx DDX

2013-06-12 Thread Jakob Bornecrantz
The changes looks good at a first glance. There are some thoughts tho, maybe we should try and make libxatracker.so autodetect which driver to use so we don't have to create a libxatracker.so for each driver, at least for linux that should be do-able. Thoughts? Cheers, Jakob.

Re: [Mesa-dev] Proposal for an Updated Linux OpenGL ABI, again

2013-04-25 Thread Jakob Bornecrantz
On Thu, Apr 25, 2013 at 9:59 PM, Andy Ritger wrote: > On Thu, Apr 25, 2013 at 05:34:11AM -0700, Ian Romanick wrote: > > On 04/25/2013 11:12 AM, Andy Ritger wrote: > > > Hi all, > > > > > > Last fall, I put together a proposal for an updated Linux OpenGL ABI > > > specification: > > > > > > > http

Re: [Mesa-dev] [PATCH 2/2] gallium: add texture update hook to screen

2013-03-19 Thread Jakob Bornecrantz
On Tue, Mar 19, 2013 at 8:29 AM, Dave Airlie wrote: >> Errr, what about using flush_frontbuffer, it seems todo >> the exact same thing. > > Hmm I wonder if I could overload it actually I hadn't considered that, > its not exactly the same thing, > but its pretty close to what I'd want to do alright

Re: [Mesa-dev] [PATCH 2/2] gallium: add texture update hook to screen

2013-03-19 Thread Jakob Bornecrantz
On Tue, Mar 19, 2013 at 5:40 AM, Dave Airlie wrote: > From: Dave Airlie > > We have cases on virtual GPU hw that renders using a wrapped llvmpipe, > that we can't produce the normal DRI2 semantics having the kernel/hw > enforce synchronisation semantics. It is also suboptimal to flush > all surfa

Re: [Mesa-dev] [PATCH 08/18] build: Move src/mapi/mapi/* to src/mapi/

2013-03-14 Thread Jakob Bornecrantz
On Mon, Mar 11, 2013 at 4:24 AM, Matt Turner wrote: > s,mapi/mapi,mapi,g This is a bit of a silly request, but mesa really sucks with tab completion, getting to anything g* in src is a PITA, it would be really nice if at least could fix the m* overload, by just calling the folder api, or somethin

Re: [Mesa-dev] [PATCH v2 3/5] gallium: Implement DRIimageExtension.duplicateImage

2013-03-03 Thread Jakob Bornecrantz
On Sun, Mar 3, 2013 at 7:03 AM, John Kåre Alsaker wrote: > --- > src/gallium/include/state_tracker/st_api.h | 1 + > src/gallium/state_trackers/dri/common/dri_screen.c | 1 + > src/gallium/state_trackers/dri/common/dri_screen.h | 1 + > src/gallium/state_trackers/dri/drm/dri2.c

Re: [Mesa-dev] [PATCH v2 2/5] dri: Add another duplicateImage to DRIimageExtension which allows you to create a sRGB view of a DRI image

2013-03-03 Thread Jakob Bornecrantz
On Sun, Mar 3, 2013 at 7:03 AM, John Kåre Alsaker wrote: > duplicateImage will allow you to create a linear or sRGB view into a DRIimage > you have access to. > This is useful because compositors may want a specific view which doesn't > correspond to the one used by applications. > --- > includ

Re: [Mesa-dev] [RFC] New EGL extension: EGL_EXT_platform_display

2013-02-26 Thread Jakob Bornecrantz
[SNIP] >> Hi, >> >> is it possible to build a binary, that will use this extension if it is >> present in whatever libEGL is available at runtime, and if it is not, >> fall back gracefully to using the core eglGetDisplay()? >> >> Or is this specifically not supported, since I cannot see a way for

Re: [Mesa-dev] [PATCH] targets/xorg-i915: Rename driver to i915_drv.so.

2012-09-25 Thread Jakob Bornecrantz
Looks good. Cheers, Jakob. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] intel: Support new dri image interface v2

2012-08-31 Thread Jakob Bornecrantz
Follow up to the previous patch, kept seperate for easier viewing, will be merged with previous patch before commiting. v2: Should fix YUV pitch/stride == 0. Signed-off-by: Jakob Bornecrantz --- src/mesa/drivers/dri/intel/intel_regions.h | 26 ++ src/mesa/drivers/dri/intel/intel_screen.c

Re: [Mesa-dev] Upcoming Mesa releases

2012-08-30 Thread Jakob Bornecrantz
On Fri, Aug 24, 2012 at 2:30 PM, Jakob Bornecrantz wrote: > On Mon, Aug 20, 2012 at 6:35 PM, Ian Romanick wrote: >> Yeah, that is fine... I'm lagging a bit and need a few more days too. > > Me to, I have some DRI interface changes I like to get into the > release, I'm

[Mesa-dev] [PATCH 2/2] intel: Support new dri image interface

2012-08-30 Thread Jakob Bornecrantz
Follow up to the previous patch, kept seperate for easier viewing, will be merged with previous patch before commiting. Signed-off-by: Jakob Bornecrantz --- src/mesa/drivers/dri/intel/intel_regions.h | 26 ++ src/mesa/drivers/dri/intel/intel_screen.c | 125

[Mesa-dev] [PATCH 1/2] dri: Rework planar image interface v2

2012-08-30 Thread Jakob Bornecrantz
to get the dri- interface changes out as fast as possible for review. I have tested these changes on SVGA with the previus patch series I sent out (mines the last one), and everything seem to work just as before. Cheers, Jakob. v2: Fix typo in dri2_from_planar. Signed-off-by: Jakob Bornecrantz --

[Mesa-dev] [PATCH] dri: Rework planar image interface v2

2012-08-25 Thread Jakob Bornecrantz
to get the dri- interface changes out as fast as possible for review. I have tested these changes on SVGA with the previus patch series I sent out (mines the last one), and everything seem to work just as before. Cheers, Jakob. v2: Fix typo in dri2_from_planar. Signed-off-by: Jakob Bornecrantz --

[Mesa-dev] [PATCH] dri: Rework planar image interface

2012-08-25 Thread Jakob Bornecrantz
to get the dri- interface changes out as fast as possible for review. I have tested these changes on SVGA with the previus patch series I sent out (mines the last one), and everything seem to work just as before. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz --- include/GL/internal/dri_i

Re: [Mesa-dev] Upcoming Mesa releases

2012-08-24 Thread Jakob Bornecrantz
On Mon, Aug 20, 2012 at 6:35 PM, Ian Romanick wrote: > On 08/20/2012 07:26 AM, Marek Olšák wrote: >> >> On Fri, Aug 10, 2012 at 4:01 AM, Ian Romanick wrote: >>> >>> After the big announcement at SIGGRAPH, I want to discuss plans for >>> upcoming >>> Mesa releases. This is basically inline with w

[Mesa-dev] [PATCH 6/6] egl_dri2: Avoid using createSubImage when not neccassery

2012-08-21 Thread Jakob Bornecrantz
Makes it possible to run Wayland on Gallium drivers. This patch will not be pushed as a interface rewrite will fix it more properly. It is here to facilitate testing of the other patches. Signed-off-by: Jakob Bornecrantz --- src/egl/drivers/dri2/egl_dri2.c | 22 -- src/gbm

[Mesa-dev] [PATCH 5/6] st/dri: Support width and height getters

2012-08-21 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- src/gallium/state_trackers/dri/drm/dri2.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/drm/dri2.c b/src/gallium/state_trackers/dri/drm/dri2.c index 5c7acfe..d7f4dd6 100644 --- a/src/gallium

[Mesa-dev] [PATCH 4/6] st/dri: Claim to support validate_usage

2012-08-21 Thread Jakob Bornecrantz
Support version 3 as well as 2, since that is only the new format query, which Jesse added support for to st/dri when he added it to dri_inteface.h. Signed-off-by: Jakob Bornecrantz --- src/gallium/state_trackers/dri/drm/dri2.c | 17 - 1 file changed, 16 insertions(+), 1

[Mesa-dev] [PATCH 3/6] dri: Make query image WIDTH and HEIGHT be version 4

2012-08-21 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- include/GL/internal/dri_interface.h |2 +- src/gbm/backends/dri/gbm_dri.c |4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index e766226..09f63ff

[Mesa-dev] [PATCH 2/6] dri: Remove image write function

2012-08-21 Thread Jakob Bornecrantz
Since its not used by anything anymore and no release has gone out where it was being used. Tested-by: Scott Moreau Signed-off-by: Jakob Bornecrantz --- include/GL/internal/dri_interface.h| 10 +- src/gbm/backends/dri/gbm_dri.c |2 -- src/mesa/drivers/dri

[Mesa-dev] [PATCH 1/6] gbm: Use libkms to replace DRI cursor images

2012-08-21 Thread Jakob Bornecrantz
add a kms_bo_write function, but that is probably wise in anyways. The only downside is that it adds a dependancy on libkms, this could however be replaced with the dumb_bo drm ioctl interface. Tested-by: Scott Moreau Signed-off-by: Jakob Bornecrantz --- configure.ac |2

[Mesa-dev] [PATCH 0/6] Gallium Wayland support

2012-08-21 Thread Jakob Bornecrantz
ly. I reworked the interface versioning so that the WIDTH and HEIGHT tokens are now version 4. I added support for DRI Image version 2-4, while support for the validate usage is hacked, it allows my to advertise 3 and 4 without gdm crashing. Cheers, Jakob. Jakob Bornecrantz (6): gbm: Use libk

[Mesa-dev] [PATCH 6/6] egl_dri2: Avoid using createSubImage when not neccassery

2012-08-15 Thread Jakob Bornecrantz
Makes it possible to run Wayland on Gallium drivers. Signed-off-by: Jakob Bornecrantz --- src/egl/drivers/dri2/egl_dri2.c | 22 -- src/gbm/backends/dri/gbm_dri.c | 10 ++ 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/src/egl/drivers/dri2

[Mesa-dev] [PATCH 5/6] dri: Remove image write function

2012-08-15 Thread Jakob Bornecrantz
Since its not used by anything anymore and no release has gone out where it was being used. Signed-off-by: Jakob Bornecrantz --- include/GL/internal/dri_interface.h| 10 +- src/gbm/backends/dri/gbm_dri.c |2 -- src/mesa/drivers/dri/intel/intel_regions.h |1

[Mesa-dev] [PATCH 4/6] gbm: Use libkms to replace DRI cursor images

2012-08-15 Thread Jakob Bornecrantz
a kms_bo_write function, but that is probably wise in anyways. The only downside is that it adds a dependancy on libkms, this could how ever be replaced with the dumb_bo drm ioctl interface. Signed-off-by: Jakob Bornecrantz --- configure.ac |2 ++ src/egl/drivers/dri2

[Mesa-dev] [PATCH 3/6] gbm: Add shared usage on images created

2012-08-15 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- src/gbm/backends/dri/gbm_dri.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index f09f6ef..5c332d4 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri/gbm_dri.c

[Mesa-dev] [PATCH 2/6] st/dri: Add shared usage on buffers created

2012-08-15 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- src/gallium/state_trackers/dri/drm/dri2.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/dri/drm/dri2.c b/src/gallium/state_trackers/dri/drm/dri2.c index d5a98a2..1ea62be 100644 --- a/src/gallium/state_trackers/dri/drm

[Mesa-dev] [PATCH 1/6] st/dri: Support width and height getters

2012-08-15 Thread Jakob Bornecrantz
Signed-off-by: Jakob Bornecrantz --- src/gallium/state_trackers/dri/drm/dri2.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/state_trackers/dri/drm/dri2.c b/src/gallium/state_trackers/dri/drm/dri2.c index d0be710..d5a98a2 100644 --- a/src/gallium/state_trackers/dri

[Mesa-dev] [PATCH 2/2] gbm: Use libkms to work around missing cursor support in dri drivers

2012-08-13 Thread Jakob Bornecrantz
kms_bo_write function, but that is probably wise in anyways. The only downside is that it adds a dependancy on libkms, this could how ever be replaced with the dumb_bo drm ioctl interface. Signed-off-by: Jakob Bornecrantz --- configure.ac |2 ++ src/egl/drivers/dri2/Makefile.am

[Mesa-dev] [PATCH 1/2] egl_dri2: Avoid using createSubImage when not neccassery

2012-08-13 Thread Jakob Bornecrantz
Makes it possible to run Wayland on Gallium drivers. At least a bit until it tries to use gbm cursor bo's. Signed-off-by: Jakob Bornecrantz --- src/egl/drivers/dri2/egl_dri2.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/egl/drivers

Re: [Mesa-dev] Mesa 8.0 branch maintenance

2012-07-26 Thread Jakob Bornecrantz
- Original Message - > We've been really crappy about keeping up on stable releases. The > biggest problem has been bug fixes sitting on master never getting > cherry picked over. Release time comes along, and either I cherry > pick 57 patches over the day before the release or Jakob send

Re: [Mesa-dev] Upcoming Mesa releases

2012-06-29 Thread Jakob Bornecrantz
- Original Message - > On Thu, May 03, 2012 at 02:38:11PM -0700, Ian Romanick wrote: > > To keep in the habit of doing regular releases, I'd like to propose > > the following set of release dates. We had previously discussed > > doing stable releases monthly and feature releases every six

[Mesa-dev] Missing commits on stable

2012-06-27 Thread Jakob Bornecrantz
Finally got around to writing that script to analyse what should be on 8.0 but is not. I have attached the result. First list is only there to shame people who have forgotten -x when cherry picking. The second list is all the commits that we have forgotten about that is on master. The third is a l

Re: [Mesa-dev] Upcoming Mesa releases

2012-06-15 Thread Jakob Bornecrantz
On Thu, May 3, 2012 at 11:38 PM, Ian Romanick wrote: > To keep in the habit of doing regular releases, I'd like to propose the > following set of release dates.  We had previously discussed doing stable > releases monthly and feature releases every six months.  This set of dates > basically reflec

Re: [Mesa-dev] [PATCH 04/19] make: Drop HOST_CC and HOST_CFLAGS.

2012-06-13 Thread Jakob Bornecrantz
- Original Message - > Except for the deleted linux-cell target, these were just the target > cc/cflags. The only usage was for gen_matypes, which wants the > target's structure packing, not the host, anyway. > --- > configs/default |2 -- > src/mesa/x86/Makefile |2 +- > 2

Re: [Mesa-dev] [PATCH] mesa: Build git_sha1.h before computing dependencies.

2012-06-11 Thread Jakob Bornecrantz
- Original Message - > Otherwise, version.c doesn't get a dependency on it in a clean build, > and then it doesn't necessarily get generated before version.c is > compiled. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50976 Thanks for fixing

Re: [Mesa-dev] [PATCH] scons: Fix Haiku binary compatibility

2012-06-11 Thread Jakob Bornecrantz
ge if statement >  '! windows or debug or True' Looks good, or at least it doesn't seem to break anything else can't really comment on the Haiku specific parts of this. Reviewed-by: Jakob Bornecrantz Lets get you commit access, so these patches doesn't

Re: [Mesa-dev] Upcoming Mesa releases

2012-05-04 Thread Jakob Bornecrantz
- Original Message - > To keep in the habit of doing regular releases, I'd like to propose > the following set of release dates. We had previously discussed > doing stable releases monthly and feature releases every six months. > This set of dates basically reflects that. > > I should be

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-04 Thread Jakob Bornecrantz
- Original Message - > On Thu, May 3, 2012 at 5:08 PM, Mandeep Baines > wrote: > > 2012/5/2 Kristian Høgsberg : > >> This new gbm entry point allows writing data into a gbm bo.  The > >> bo has to be created with the GBM_BO_USE_WRITE flag, and it's > >> only required to work for GBM_BO_USE

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Jakob Bornecrantz
- Ursprungligt meddelande - > This new gbm entry point allows writing data into a gbm bo. The bo > has to be created with the GBM_BO_USE_WRITE flag, and it's only > required to work for GBM_BO_USE_CURSOR_64X64 bos. > > The gbm API is designed to be the glue layer between EGL and KMS, but

Re: [Mesa-dev] [PATCH] gbm: Add gbm_bo_write entry point

2012-05-03 Thread Jakob Bornecrantz
- Ursprungligt meddelande - > On Thu, May 3, 2012 at 7:47 AM, Jakob Bornecrantz > wrote: > > Hi Kristian, > > > > s/gbm_bo_write/gbm_bo_write_to_cursor/g and make fail on anything > > other then cursors and I'm happy. Not making it just happen > >

  1   2   3   4   >