Re: [Mesa-dev] Extension help

2019-08-02 Thread Fritz Koenig
On Fri, Aug 2, 2019 at 3:03 PM Ian Romanick wrote: > > On 8/2/19 1:13 PM, Fritz Koenig wrote: > > Hi, > > > > I would like to be able to use the MESA_framebuffer_flip_y extension > > in GLES 3.0. The blocker is that FramebufferParameteri is not part of > > GL

Re: [Mesa-dev] Extension help

2019-08-02 Thread Fritz Koenig
I made another pass and I think I solved it in the correct way. I think the problem was that the test needed to be updated to take into consideration that the extension can apply to GLES 3.0 and not just GLES 3.1. On Fri, Aug 2, 2019 at 1:13 PM Fritz Koenig wrote: > > Hi, > > I w

[Mesa-dev] Extension help

2019-08-02 Thread Fritz Koenig
Hi, I would like to be able to use the MESA_framebuffer_flip_y extension in GLES 3.0. The blocker is that FramebufferParameteri is not part of GLES 3.0. I have explored a couple of ways of achieving this. 1. FramebufferParameteri was first provided by the GL extension ARB_framebuffer_no_attac

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-10-01 Thread Fritz Koenig
On Mon, Sep 17, 2018 at 1:51 PM Fritz Koenig wrote: > > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo checks were replaced with > FlipY checks. rb->Name is also used to determine > if a buffer is winsys. > > v2: Fixes annotation [for emil] >

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-09-20 Thread Fritz Koenig
On Wed, Aug 22, 2018 at 3:41 PM Jason Ekstrand wrote: > > On Wed, Aug 22, 2018 at 5:35 PM Fritz Koenig wrote: >> >> On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand wrote: >> > >> > Two questions: >> > >> > 1) Have you grep'd through t

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-09-17 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. v2: Fixes annotation [for emil] Fixes: ab05dd183cc ("i965: implement GL_MESA_framebuffer_flip_y [v3]") --- src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-09-17 Thread Fritz Koenig
On Thu, Aug 23, 2018 at 11:01 AM Emil Velikov wrote: > > On Thu, 23 Aug 2018 at 18:41, Emil Velikov wrote: > > > > Hi Fritz, > > > > On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > > > > > In the GL_MESA_framebuffer_flip_y implementation >

[Mesa-dev] [PATCH 1/2] mesa: Additional FlipY applications

2018-09-14 Thread Fritz Koenig
Instances where direction was determined based on winsys or user fbo and should be determined based on FlipY. Key STATE_FB_WPOS_Y_TRANSFORM for of FlipY instead of _mesa_is_user_fbo. This corrects gl_FragCoord usage when applying GL_MESA_framebuffer_flip_y. Fixes: ab05dd183cc ("i965: implement G

[Mesa-dev] [PATCH 2/2] mesa: FramebufferParameteri parameter checking

2018-09-14 Thread Fritz Koenig
Missing break; causes parameter checking to never pass GL_FRAMEBUFFER_FLIP_Y_MESA paramers. Fixes: 318c265160 ("mesa: GL_MESA_framebuffer_flip_y extension [v4]") --- src/mesa/main/fbobject.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c in

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-08-23 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. v2: Fixes annotation [for emil] Fixes: ab05dd183cc ("i965: implement GL_MESA_framebuffer_flip_y [v3]") --- src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-23 Thread Fritz Koenig
On Thu, Aug 23, 2018 at 11:01 AM Emil Velikov wrote: > > On Thu, 23 Aug 2018 at 18:41, Emil Velikov wrote: > > > > Hi Fritz, > > > > On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > > > > > In the GL_MESA_framebuffer_flip_y implementation >

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Fritz Koenig
gh our CI system? No I haven't. How do I kick that off? > > On Wed, Aug 22, 2018 at 5:00 PM Fritz Koenig wrote: >> >> In the GL_MESA_framebuffer_flip_y implementation >> _mesa_is_winsys_fbo checks were replaced with >> FlipY checks. rb->Name is also used to determ

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. --- src/mesa/drivers/dri/i965/brw_blorp.c| 20 +--- src/mesa/drivers/dri/i965/intel_pixel_read.c | 4 ++--

[Mesa-dev] [PATCH 2/2] i965: implement MESA_framebuffer_flip_y [v3]

2018-07-23 Thread Fritz Koenig
Instead of using _mesa_is_winsys_fbo or _mesa_is_user_fbo to infer if an fbo is flipped use the InvertedY flag. v2: * additional window-system framebuffer checks [for jason] v3: * s/inverted_y/flip_y/g [for chadv] * s/InvertedY/FlipY/g [for chadv] --- src/mesa/drivers/dri/i965/brw_blorp.c

[Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v4]

2018-07-23 Thread Fritz Koenig
ngs + +GL_MESA_framebuffer_flip_y + +Contact + + Fritz Koenig + +Contributors + + Fritz Koenig, Google +Kristian Høgsberg, Google +Chad Versace, Google + +Status + +Proposal + +Version + +Version 1, June 7, 2018 + +Number + +302 + +Dependencies + +OpenGL ES 3.1 is required,

Re: [Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v3]

2018-07-19 Thread Fritz Koenig
On Wed, Jul 11, 2018 at 3:54 PM Chad Versace wrote: > > +Ken, I had a question about GLboolean. I call you by name in the > comments below. > > On Fri 29 Jun 2018, Fritz Koenig wrote: > > Adds an extension to glFramebufferParameteri > > that will specify if th

Re: [Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v3]

2018-07-18 Thread Fritz Koenig
On Wed, Jul 11, 2018 at 3:54 PM Chad Versace wrote: > > +Ken, I had a question about GLboolean. I call you by name in the > comments below. > > On Fri 29 Jun 2018, Fritz Koenig wrote: > > Adds an extension to glFramebufferParameteri > > that will specify if th

[Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v3]

2018-06-29 Thread Fritz Koenig
,84 @@ +Name + +MESA_framebuffer_flip_y + +Name Strings + +GL_MESA_framebuffer_flip_y + +Contact + + Fritz Koenig + +Contributors + + Fritz Koenig, Google +Kristian Høgsberg, Google +Chad Versace, Google + +Status + +Proposal + +Version + +Version 1, June 7, 2018 + +Num

Re: [Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v2]

2018-06-29 Thread Fritz Koenig
On Fri, Jun 29, 2018 at 1:50 AM Erik Faye-Lund wrote: > > On Thu, Jun 28, 2018 at 11:12 PM Fritz Koenig wrote: > > > > Adds an extension to glFramebufferParameteri > > that will specify if the framebuffer is vertically > > flipped. Historically system framebuffers

[Mesa-dev] [PATCH 1/2] mesa: MESA_framebuffer_flip_y extension [v2]

2018-06-28 Thread Fritz Koenig
ngs + +GL_MESA_framebuffer_flip_y + +Contact + + Fritz Koenig + +Contributors + + Fritz Koenig, Google +Kristian Høgsberg, Google +Chad Versace, Google + +Status + +Proposal + +Version + +Version 1, June 7, 2018 + +Number + +TBD + +Dependencies + +OpenGL ES 3.1

[Mesa-dev] [PATCH 2/2] i965: implement MESA_framebuffer_flip_yv [v2]

2018-06-28 Thread Fritz Koenig
Instead of using _mesa_is_winsys_fbo or _mesa_is_user_fbo to infer if an fbo is flipped use the InvertedY flag. --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- src/mesa/drivers/dri/i965/brw_meta_util.c | 4 +- src/mesa/drivers/dri/i965/brw_sf.c| 6 +-- src/mesa/drivers

Re: [Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

2018-06-15 Thread Fritz Koenig
On Tue, Jun 12, 2018 at 12:28 PM Chad Versace wrote: > > On Thu 07 Jun 2018, Fritz Koenig wrote: > > Adds an extension to glFramebufferParameteri > > that will specify if the framebuffer is vertically > > flipped. Historically system framebuffers are > > vertically

Re: [Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

2018-06-07 Thread Fritz Koenig
xels to work correctly. It would be preferable to have the driver handle all of that work. > On Thu, Jun 7, 2018 at 7:01 PM, Fritz Koenig wrote: > > Adds an extension to glFramebufferParameteri > > that will specify if the framebuffer is vertically > > flipped. Historically sy

[Mesa-dev] [PATCH 1/2] mesa : MESA_framebuffer_flip_y extension

2018-06-07 Thread Fritz Koenig
/MESA_framebuffer_flip_y.spec new file mode 100644 index 00..b9867e0683 --- /dev/null +++ b/docs/specs/MESA_framebuffer_flip_y.spec @@ -0,0 +1,59 @@ +Name + +MESA_framebuffer_flip_y + +Name Strings + +GL_MESA_framebuffer_flip_y + +Contact + +Fritz Koenig + +Status + +Proposal + +Version + +Version

[Mesa-dev] [PATCH 2/2] i965: implement MESA_framebuffer_flip_y

2018-06-07 Thread Fritz Koenig
Instead of using _mesa_is_winsys_fbo or _mesa_is_user_fbo to infer if an fbo is flipped use the InvertedY flag. --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- src/mesa/drivers/dri/i965/brw_meta_util.c | 4 +- src/mesa/drivers/dri/i965/brw_sf.c| 6 +-- src/mesa/drivers