Re: [Mesa-dev] [PATCH 1/2] glsl: Match order of gl_LightSourceParameters elements.

feature. On 2017-11-29 23:56, Brian Paul wrote: > Reviewed-by: Brian Paul > > I think you could tag both of your patches for the stable branch. > > On 11/23/2017 01:48 PM, Fabian Bieler wrote: >> spotExponent and spotCosCutoff were swapped in the >> gl_builtin_unif

[Mesa-dev] [PATCH 1/2] glsl: Match order of gl_LightSourceParameters elements.

spotExponent and spotCosCutoff were swapped in the gl_builtin_uniform_element struct. Now the order matches across gl_builtin_uniform_element, glsl_struct_field and the spec. --- src/compiler/glsl/builtin_variables.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com

[Mesa-dev] [PATCH 2/2] glsl: Fix gl_NormalScale.

GLSL shaders can access the normal scale factor with the built-in gl_NormalScale. Mesa's modelspace lighting optimization uses a different normal scale factor than defined in the spec. We have to take care not to use this factor for gl_NormalScale. Mesa already defines two seperate states: state

Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

On Sat, Mar 8, 2014, at 11:13 AM, Kenneth Graunke wrote: > On 02/05/2014 04:30 PM, Ian Romanick wrote: > > On 02/05/2014 01:07 PM, Fabian Bieler wrote: > >> The hardcoded numbers are a few lines off at the moment. > >> Keeping track of the numbers through further mo

Re: [Mesa-dev] Introductory projects in r600/radeonsi

On 2014-02-28 11:27, Timothy Arceri wrote: Hi Sean, There are a couple of projects left to do on the Newbie page that will help you get started contributing to mesa and piglit [1] NV_non_square_matrices is done but the other two haven't been worked on yet as far as I can tell. The tests for ARB

Re: [Mesa-dev] [PATCH 1/5] mesa: Add GL_NV_non_square_matrices for OpenGL ES 2.x.

quot;, 30, -1 }, + // { "glUniformMatrix2x4fv", 30, -1 }, + // { "glUniformMatrix3x2fv", 30, -1 }, + // { "glUniformMatrix3x4fv", 30, -1 }, + // { "glUniformMatrix4x2fv", 30, -1 }, + // { "glUniformMatrix4x3fv

Re: [Mesa-dev] [RFC PATCH] i965/gs: add snb support

e mistaken about some of this :) Once again, thanks for working on this! I'll try to look over your code sometime today or tomorrow and make more comments. Paul _______ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/m

[Mesa-dev] [PATCH 11/12] geom-outlining-150: Use core geometry shaders.

Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/geom-outlining-150.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 0bc20f0..3dffa16

[Mesa-dev] [PATCH 08/12] glsl/gsraytrace: Use core geometry shaders.

v2: Don't remove ShaderSupported() test. It sets up some function pointers for the CompileShader framework. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 24 +--- 1 file changed, 9 insertions(+), 15 dele

[Mesa-dev] [PATCH 06/12] glsl/gsraytrace: Use core GL3.0 transform feedback

NV_transform_feedback is not supported by mesa. Use transform feedback from core OpenGL 3.0. This necessitates binding the transform feedback varyings before linking the shader. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 72

[Mesa-dev] [PATCH 07/12] glsl/gsraytrace: Use GLSL 1.5 instead of 1.2.

This commit prepares the transition from extension to core geometry shaders. (Core geometry shaders require GLSL version 1.5 or later.) This includes using generic vertex attributes instead of built-ins. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src

[Mesa-dev] [PATCH 09/12] glsl/gsraytrace: Switch to core profile.

v2: Remove redundant 'core' in GLSL version statement. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/src/glsl/gsrayt

[Mesa-dev] [PATCH 01/12] configure.ac: Check for freeglut.

To get an OpenGL core profile context freeglut 2.6 or later is required. Note that in spite of it's name HAVE_FREEGLUT is only defined if freeglut 2.6 (released in 2009) or later ist found. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- configure.a

[Mesa-dev] [PATCH 12/12] geom-outlining-150: Switch to core profile.

Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/geom-outlining-150.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 3dffa16..2e2a54a 100644 --- a/src/glsl/geom

[Mesa-dev] [PATCH 05/12] glsl/gsraytrace: Bind transform feedback buffer.

Bind the transform feedback buffer before drawing into it und unbind it afterwards. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/gsraytrace.cpp b/src

[Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ "constant" takes care of this automatically. v2: Don't set source-string-number to line number. Signed-off-by: Fabian Bieler Reviewed

[Mesa-dev] [PATCH 00/12] DEMOS Use core profile in two GS demos (v3).

have git access, I'd appreciate it if someone could commit these patches. Thanks, Fabian Fabian Bieler (12): configure.ac: Check for freeglut. glut_wrapper: Include freeglut.h if available. glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings. glsl/gsraytr

[Mesa-dev] [PATCH 02/12] glut_wrapper: Include freeglut.h if available.

The freeglut header only defines the extensions to request an OpenGL core profile context if freeglut.h (rather than glut.h) is included. Note that the header is installed to include/GL/freeglut.h on OS X, too. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick

[Mesa-dev] [PATCH 10/12] geom-outlining-150: Use a vbo.

Use a vbo for vertex data instead of client-side arrays. Also bind a vertex array object. This is necessary for the switch to a core profile context. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/geom-outlining-150.c | 25

[Mesa-dev] [PATCH 04/12] glsl/gsraytrace: Don't create new Buffer objects everytime the window is resized.

Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul Reviewed-by: Ian Romanick --- src/glsl/gsraytrace.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index c21c667..f156fdc 100644 --- a/src/glsl/gsraytrace.cpp +++ b

[Mesa-dev] [PATCH 09/12] glsl/gsraytrace: Switch to core profile.

Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index 6df6543..3eec835 100644 --- a/src/glsl/gsraytrace.cpp +++ b/src/glsl

[Mesa-dev] [PATCH 10/12] geom-outlining-150: Use a vbo.

Use a vbo for vertex data instead of client-side arrays. Also bind a vertex array object. This is necessary for the switch to a core profile context. Signed-off-by: Fabian Bieler --- src/glsl/geom-outlining-150.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions

[Mesa-dev] [PATCH 11/12] geom-outlining-150: Use core geometry shaders.

Signed-off-by: Fabian Bieler --- src/glsl/geom-outlining-150.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 0bc20f0..3dffa16 100644 --- a/src/glsl/geom-outlining-150.c +++ b/src

[Mesa-dev] [PATCH 01/12] configure.ac: Check for freeglut.

To get an OpenGL core profile context freeglut 2.6 or later is required. Note that in spite of it's name HAVE_FREEGLUT is only defined if freeglut 2.6 (released in 2009) or later ist found. Signed-off-by: Fabian Bieler --- configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --

[Mesa-dev] [PATCH 04/12] glsl/gsraytrace: Don't create new Buffer objects everytime the window is resized.

Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index c21c667..f156fdc 100644 --- a/src/glsl/gsraytrace.cpp +++ b/src/glsl/gsraytrace.cpp @@ -776,7 +776,6 @@ Reshape

[Mesa-dev] [PATCH 00/12] DEMOS Use core profile in two GS demos (v2).

don't have git access, I'd appreciate it if someone could commit these patches (assuming there are no further issues, of course). Thanks, Fabian Fabian Bieler (12): configure.ac: Check for freeglut. glut_wrapper: Include freeglut.h if available. glsl/gsraytrace: Use __LINE__ macro t

[Mesa-dev] [PATCH 02/12] glut_wrapper: Include freeglut.h if available.

The freeglut header only defines the extensions to request an OpenGL core profile context if freeglut.h (rather than glut.h) is included. Note that the header is installed to include/GL/freeglut.h on OS X, too. Signed-off-by: Fabian Bieler --- src/util/glut_wrap.h | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH 12/12] geom-outlining-150: Switch to core profile.

Signed-off-by: Fabian Bieler --- src/glsl/geom-outlining-150.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 3dffa16..2e2a54a 100644 --- a/src/glsl/geom-outlining-150.c +++ b/src/glsl/geom-outlining-150.c

[Mesa-dev] [PATCH 05/12] glsl/gsraytrace: Bind transform feedback buffer.

Bind the transform feedback buffer before drawing into it und unbind it afterwards. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index f156fdc..015bfcd 100644

[Mesa-dev] [PATCH 06/12] glsl/gsraytrace: Use core GL3.0 transform feedback

NV_transform_feedback is not supported by mesa. Use transform feedback from core OpenGL 3.0. This necessitates binding the transform feedback varyings before linking the shader. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 72 + 1

[Mesa-dev] [PATCH 08/12] glsl/gsraytrace: Use core geometry shaders.

v2: Don't remove ShaderSupported() test. It sets up some function pointers for the CompileShader framework. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src

[Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ "constant" takes care of this automatically. v2: Don't set source-string-number to line number. Signed-off-by: Fabian Bieler

[Mesa-dev] [PATCH 07/12] glsl/gsraytrace: Use GLSL 1.5 instead of 1.2.

This commit prepares the transition from extension to core geometry shaders. (Core geometry shaders require GLSL version 1.5 or later.) This includes using generic vertex attributes instead of built-ins. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 58

[Mesa-dev] [PATCH 08/12] glsl/gsraytrace: Use core geometry shaders.

V2: Don't remove ShaderSupported() test. It sets up some function pointers for the CompileShader framework. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src

[Mesa-dev] [PATCH 08/12] glsl/gsraytrace: Use core geometry shaders.

Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index 23c0f93..adb6c7a 100644 --- a/src/glsl/gsraytrace.cpp +++ b/src/glsl/gsraytrace.cpp

[Mesa-dev] [PATCH 06/12] glsl/gsraytrace: Use core GL3.0 transform feedback

NV_transform_feedback is not supported by mesa. Use transform feedback from core OpenGL 3.0. This necessitates binding the transform feedback varyings before linking the shader. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 72 + 1

[Mesa-dev] [PATCH 11/12] geom-outlining-150: Use core geometry shaders.

Signed-off-by: Fabian Bieler --- src/glsl/geom-outlining-150.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 0bc20f0..3dffa16 100644 --- a/src/glsl/geom-outlining-150.c +++ b/src

[Mesa-dev] [PATCH 10/12] geom-outlining-150: Use a vbo.

Use a vbo for vertex data instead of client-side arrays. Also bind a vertex array object. This is necessary for the switch to a core profile context. Signed-off-by: Fabian Bieler --- src/glsl/geom-outlining-150.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions

[Mesa-dev] [PATCH 00/12] DEMOS Use core profile in two GS demos.

Hello! As mesa only supports geometry shaders in core profile contexts this patchset adjusts the gsraytrace and the geom-outlining-150 demos to use the core profile. Fabian Fabian Bieler (12): configure.ac: Check for freeglut. glut_wrapper: Include freeglut.h if available. glsl

[Mesa-dev] [PATCH 01/12] configure.ac: Check for freeglut.

To get an OpenGL core profile context freeglut 2.6 or later is required. Note that in spite of it's name HAVE_FREEGLUT is only defined if freeglut 2.6 (released in 2009) or later ist found. Signed-off-by: Fabian Bieler --- configure.ac | 6 ++ 1 file changed, 6 insertions(+) diff --

[Mesa-dev] [PATCH 12/12] geom-outlining-150: Switch to core profile.

Signed-off-by: Fabian Bieler --- src/glsl/geom-outlining-150.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/glsl/geom-outlining-150.c b/src/glsl/geom-outlining-150.c index 3dffa16..2e2a54a 100644 --- a/src/glsl/geom-outlining-150.c +++ b/src/glsl/geom-outlining-150.c

[Mesa-dev] [PATCH 07/12] glsl/gsraytrace: Use GLSL 1.5 instead of 1.2.

This commit prepares the transition from extension to core geometry shaders. (Core geometry shaders require GLSL version 1.5 or later.) This includes using generic vertex attributes instead of built-ins. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 58

[Mesa-dev] [PATCH 04/12] glsl/gsraytrace: Don't create new Buffer objects everytime the window is resized.

Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index 31e9fda..eace71b 100644 --- a/src/glsl/gsraytrace.cpp +++ b/src/glsl/gsraytrace.cpp @@ -776,7 +776,6 @@ Reshape

[Mesa-dev] [PATCH 02/12] glut_wrapper: Include freeglut.h if available.

The freeglut header only defines the extensions to request an OpenGL core profile context if freeglut.h (rather than glut.h) is included. Note that the header is installed to include/GL/freeglut.h on OS X, too. Signed-off-by: Fabian Bieler --- src/util/glut_wrap.h | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ "constant" takes care of this automatically. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 10 +++--- 1 file changed, 7

[Mesa-dev] [PATCH 09/12] glsl/gsraytrace: Switch to core profile.

Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index adb6c7a..03d5f30 100644 --- a/src/glsl/gsraytrace.cpp +++ b/src/glsl

[Mesa-dev] [PATCH 05/12] glsl/gsraytrace: Bind transform feedback buffer.

Bind the transform feedback buffer before drawing into it und unbind it afterwards. Signed-off-by: Fabian Bieler --- src/glsl/gsraytrace.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index eace71b..e76a3a2 100644

Re: [Mesa-dev] [PATCH] glsl/geom-stipple-lines: Pass pattern as int to GS.

Please disregard this mail. Sorry about the noise. On 2014-02-05 20:50, Fabian Bieler wrote: > Pass pattern as bitmask in a unsigned int instead of as array of floats to the > geometry shader. > > Signed-off-by: Fabian Bieler > --- > src/glsl/geom-st

[Mesa-dev] [PATCH] glsl/geom-stipple-lines: Pass pattern as int to GS.

Pass pattern as bitmask in a unsigned int instead of as array of floats to the geometry shader. Signed-off-by: Fabian Bieler --- src/glsl/geom-stipple-lines.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/src/glsl/geom-stipple-lines.c b/src/glsl/geom

Re: [Mesa-dev] [PATCH 3/5] glsl: Return error_type instead of NULL if element_type() is called on non array type.

On 2013-06-18 11:24, Ian Romanick wrote: > On 06/03/2013 01:23 PM, Fabian Bieler wrote: >> This matches the behavior of field_type() and other get_*_type() methods. >> >> I looked through the calls to element_type() and didn't find a caller that >> depends on the ol

Re: [Mesa-dev] [PATCH 5/5] glsl: Update array access tracker of function parameters.

On 2013-06-18 11:14, Ian Romanick wrote: > On 06/03/2013 01:23 PM, Fabian Bieler wrote: >> Uniform arrays are subject to beeing shrunk if higher members were not >> accessed. > ^^ > being > >> Update the max_array_access flag s

Re: [Mesa-dev] [PATCH 4/5] glsl: Don't copy array of sampler parameters when inlining functions.

On 2013-06-18 11:05, Ian Romanick wrote: > On 06/03/2013 01:23 PM, Fabian Bieler wrote: >> Remove The parameter from the list of parameters and replace the derefs in >> the >> function body with the deref of the argument. > > It seems like the existing code would break

Re: [Mesa-dev] Pull request for 1.50 GS layout qualifiers

Hello! I gave your series a try and found two small nitpicks: In "glsl: Parse the GLSL 1.50 GS layout qualifiers.": There are two debug printfs left in "ast_type_qualifier::merge_qualifier" max_vertices or VerticesOut is not checked against MaxGeometryOutputVertices. Fabian On 2013-06-14 03:15,

[Mesa-dev] [PATCH 3/3] mesa/main: Check for 0 size draws after validation.

egarding DrawArraysOneInstance, in terms of which other draw operations are defined:] If count is negative, an INVALID_VALUE error is generated." This patch also changes the bahavior of MultiDrawElements to perform the draw operation if some primitive's index counts are zero. Signed-off

[Mesa-dev] [PATCH 2/3] glsl: Only call mark_whole_array_access for arrays.

Otherwise the max_array_access field of scalar variables is set to 0x. This doesn't lead to any errors since that field isn't used for scalar variables but leaving it at zero is probably better. Signed-off-by: Fabian Bieler --- src/glsl/ast_to_hir.cpp | 8 ++-- 1 file

[Mesa-dev] [PATCH 1/3] glsl/linker: Use correct array length when linking inter-stage uniforms and varyings.

Signed-off-by: Fabian Bieler --- src/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index cd8d680..e3a8ccd 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1147,7 +1147,7 @@ update_array_sizes(struct

[Mesa-dev] [PATCH 1/2] glsl/gsraytrace: Bind transform feedback buffer.

Bind the transform feedback buffer before drawing into it und unbind it afterwards. --- src/glsl/gsraytrace.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/gsraytrace.cpp b/src/glsl/gsraytrace.cpp index 62a584d..f34a3da 100644 --- a/src/glsl/gsraytrace.cpp +++ b/

[Mesa-dev] [PATCH 2/2] glsl/gsraytrace: Use EXT_transform_feedback instead of, NV.

NV_transform_feedback is currently not supported by mesa (and I'm somewhat doubtful it will be implemented in the foreseeable future). Note that with this patch the demo doesn't work anymore with the nvidia binary driver. --- src/glsl/gsraytrace.cpp | 71 +-

Re: [Mesa-dev] Seeking information about commit 586b4b50 (glsl: Also update implicit sizes of varyings at link time)

Hello! I'm obviously no expert for this code but as far as I understand it this was supposed to resize the zero length built-in arrays when they are not redeclared by the user (and only indexed with constant expressions). However, the later commit 6f53921 linker: Ensure that unsized arrays have

[Mesa-dev] [PATCH 5/5] glsl: Update array access tracker of function parameters.

-by: Fabian Bieler --- src/glsl/ast_function.cpp | 12 1 file changed, 12 insertions(+) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index 00e0c05..9378894 100644 --- a/src/glsl/ast_function.cpp +++ b/src/glsl/ast_function.cpp @@ -322,6 +322,18 @@ generate_call

[Mesa-dev] [PATCH 4/5] glsl: Don't copy array of sampler parameters when inlining functions.

Remove The parameter from the list of parameters and replace the derefs in the function body with the deref of the argument. This is the way scalar sampler variables are handled already. Signed-off-by: Fabian Bieler --- src/glsl/opt_function_inlining.cpp | 4 ++-- 1 file changed, 2 insertions

[Mesa-dev] [PATCH 3/5] glsl: Return error_type instead of NULL if element_type() is called on non array type.

This matches the behavior of field_type() and other get_*_type() methods. I looked through the calls to element_type() and didn't find a caller that depends on the old behavior. Signed-off-by: Fabian Bieler --- src/glsl/glsl_types.h | 6 +++--- 1 file changed, 3 insertions(+), 3 dele

[Mesa-dev] [PATCH 2/5] glsl: Only call mark_whole_array_access for arrays.

Otherwise the max_array_access field of scalar variables is set to 0x. This doesn't lead to any errors since that field isn't used for scalar variables but leaving it at zero is probably better. Signed-off-by: Fabian Bieler --- src/glsl/ast_to_hir.cpp | 8 ++-- 1 file

[Mesa-dev] [PATCH 1/5] glsl/linker: Use correct array length when linking inter-stage uniforms and varyings.

Signed-off-by: Fabian Bieler --- src/glsl/linker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 982fe46..7395ed5 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1147,7 +1147,7 @@ update_array_sizes(struct

[Mesa-dev] [PATCH 5/5] glsl/linker: Fail if gl_FragDepth layouts don't match.

This fixes Piglit test shaders/link-mismatch-layout-02. --- src/glsl/linker.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 4415b8d..4bc0eee 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -561,6 +561,7 @@ cross_validate_globa

[Mesa-dev] [PATCH 4/5] glsl/linker: Fail if gl_FragCoord layouts don't match.

Fail linking if gl_FragCoord is used with different layout qualifiers in seperate shader objects. This fixes Piglit test shaders/link-mismatch-layout-01. --- src/glsl/linker.cpp | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/

[Mesa-dev] [PATCH 3/5] glsl: Fail if gl_FragCoord layouts don't match.

Fail compile if gl_FragCoord is redeclared with different layout qualifiers in one shader. --- src/glsl/ast_to_hir.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 63fbd5a..d6362b0 100644 --- a/src/glsl/ast_to_hir.cpp +++ b

[Mesa-dev] [PATCH 2/5] glsl: Add redeclation flag to ir_variable.

It is illegal to redeclare builtin variables with incompatible layout qualifiers in seprerate shader objects that are linked together. Since a redeclaration without any layout qualifiers can be incompatible with another redeclartion where no redeclaration wouldn't be, it can be necessary to know we

[Mesa-dev] [PATCH 1/5] glsl: Overwrite storage qualifier of builtin redeclarations.

Prior to GLSL version 1.3 builtin variables such as gl_Position have no storage qualifiers (in or out). However, the internal declarations in Mesa have storage qualifiers regardless of version. As the code to identify a redeclaration checks for identical storage qualifiers you cannot redeclare bui

[Mesa-dev] [PATCH 2/2] mesa/program: Don't copy propagate from swizzles.

drivers that use Mesa IR. NOTE: This is a candidate for the stable branches. Signed-off-by: Fabian Bieler Reviewed-by: Ian Romanick --- src/mesa/program/ir_to_mesa.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 14cf5ba

[Mesa-dev] [PATCH 1/2] mesa/st: Don't copy propagate from swizzles.

gallium drivers. NOTE: This is a candidate for the stable branches. Signed-off-by: Fabian Bieler Reviewed-by: Brian Paul --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker

[Mesa-dev] [PATCH 2/2] mesa/program: Don't copy propagate from swizzles.

Do not propagate a copy if source and destination are identical. Otherwise code like MOV TEMP[0].xyzw, TEMP[0].wzyx MOV TEMP[1].xyzw, TEMP[0].xyzw is changed to MOV TEMP[0].xyzw, TEMP[0].wzyx MOV TEMP[1].xyzw, TEMP[0].wzyx This fixes Piglit test shaders/glsl-copy-propagation-self-2 for drivers

[Mesa-dev] [PATCH 1/2] mesa/st: Don't copy propagate from swizzles.

Do not propagate a copy if source and destination are identical. Otherwise code like MOV TEMP[0].xyzw, TEMP[0].wzyx MOV TEMP[1].xyzw, TEMP[0].xyzw is changed to MOV TEMP[0].xyzw, TEMP[0].wzyx MOV TEMP[1].xyzw, TEMP[0].wzyx This fixes Piglit test shaders/glsl-copy-propagation-self-2 for gallium

Re: [Mesa-dev] [PATCH] mesa/st: Don't copy propagate from swizzles.

On 2013-04-24 17:54, Brian Paul wrote: > On 04/20/2013 11:40 AM, Fabian Bieler wrote: >> Do not propagate a copy if source and destination are identical. >> >> Otherwise code like >> >> MOV TEMP[0].xyzw, TEMP[0].wzyx >> mov TEMP[1].xyzw, TEMP[0].xyzw >

[Mesa-dev] [PATCH] mesa/st: Don't copy propagate from swizzles.

Do not propagate a copy if source and destination are identical. Otherwise code like MOV TEMP[0].xyzw, TEMP[0].wzyx mov TEMP[1].xyzw, TEMP[0].xyzw is changed to MOV TEMP[0].xyzw, TEMP[0].wzyx mov TEMP[1].xyzw, TEMP[0].wzyx --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |2 ++ 1 file change

Re: [Mesa-dev] [PATCH 2/3] st/mesa: Finalize fbo texture attachments

images from one texture object gallium will still fail silently. I'll submit a patch to mark these cases as fbo incomplete. Fabian On Tuesday 05 April 2011 02:56:51 Brian Paul wrote: > On 04/02/2011 11:41 AM, Fabian Bieler wrote: > > > Does this fix a specific bug or

[Mesa-dev] [PATCH 3/3] st/mesa: Move fbo texture attachment finalization to validation.

I think it's a bit nicer to do this during validation, but if anyone disagrees I won't object to dropping this patch. Fabian From cac5460d04e7028ed621e0fe822a7820915dfd3d Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Sat, 2 Apr 2011 13:12:32 +0200 Subject: [PATCH 3/3] st/mesa

[Mesa-dev] [PATCH 2/3] st/mesa: Finalize fbo texture attachments

From 24f7050dd447df52d3cbf53b4594a95f2ea637b6 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Sat, 2 Apr 2011 12:19:49 +0200 Subject: [PATCH 2/3] st/mesa: Finalize fbo texture attachments This patch tries to make sure that the texture image that should be attached to the fbo actually lives

[Mesa-dev] [PATCH 1/3] mesa: Guard against null pointer deref in fbo validation

From 3561688742016c82c6c146e448949112255b234c Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Sat, 2 Apr 2011 13:52:34 +0200 Subject: [PATCH 1/3] mesa: Guard against null pointer deref in fbo validation This matches the behaviour below when numSamples is compared. At least with the gallium

[Mesa-dev] [PATCH 4/4] st/mesa: Set min/max_lod to BaseLevel w/o mipmapping

From 555867d4bdbd9463df8b9e85828e6425bf0c14f8 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Tue, 29 Mar 2011 11:59:08 +0200 Subject: [PATCH 4/4] st/mesa: Set min/max_lod to BaseLevel w/o mipmapping According to chapter 3.8.8 of the OpenGL 2.1 specification, the GL should always select

[Mesa-dev] [PATCH 3/4] st/mesa: Clamp min_lod and max_lod to BaseLevel and MaxLevel

lod > texobj->MaxLevel) sampler->min_lod = texobj->MaxLevel; But clamping is a little bit cleaner imho. Fabian From 3e21ca559b9c49f86a768db849f6fa0497055706 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Tue, 29 Mar 2011 11:56:31 +0200 Subject: [PATCH 3/4] st/mesa: Clamp min_lod

[Mesa-dev] [PATCH 2/4] st/mesa: Apply LOD from texture object

From fa33b8f497083b57c3b744a23c92c1260f449b6a Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Fri, 25 Mar 2011 11:06:01 +0100 Subject: [PATCH 2/4] st/mesa: Apply LOD from texture object --- src/mesa/state_tracker/st_atom_sampler.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[Mesa-dev] [PATCH 1/4] st/mesa: Apply LOD bias from correct texture unit

From 301b77d35543f7a1540e778b7041d128a858a43e Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Fri, 25 Mar 2011 11:04:41 +0100 Subject: [PATCH 1/4] st/mesa: Apply LOD bias from correct texture unit --- src/mesa/state_tracker/st_atom_sampler.c |2 +- 1 files changed, 1 insertions(+), 1

[Mesa-dev] [PATCH 3/3] r600g: Handle texture fetch instructions with relative addressing (resend)

From 72ec3077dfa9a4af4e28b35d66e71d02f7131ee9 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Wed, 23 Mar 2011 23:27:01 +0100 Subject: [PATCH 3/3] r600g: Handle texture fetch instructions with relative addressing --- src/gallium/drivers/r600/r600_shader.c |1 + 1 files changed, 1

[Mesa-dev] [PATCH 2/3] r600g: Handle texture fetch instructions with neg or abs on source register (resend)

From 8bbfaa7c22fb5a8ddee9d4982f46a18fd5dd7e0b Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Wed, 23 Mar 2011 23:26:41 +0100 Subject: [PATCH 2/3] r600g: Handle texture fetch instructions with neg or abs on source register --- src/gallium/drivers/r600/r600_shader.c |8 +--- 1 files

[Mesa-dev] [PATCH 1/3] r600g: Handle texture fetch instructions with swizzle on source register (resend)

Resend without bogus swizzles spotted by Henri Verbeet From 2ee1d4ba2fab08dba7d5eceb807c6eae3a253eb2 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Wed, 23 Mar 2011 18:12:44 +0100 Subject: [PATCH 1/3] r600g: Handle texture fetch instructions with swizzle on source register --- src/gallium

[Mesa-dev] [PATCH 3/3] r600g: Handle texture fetch instructions with relative addressing

't support relative addressing. ARB_vertex_program doesn't support texture fetches. From ababc239f468c3e202bb7ee93c4b8015798c5ca8 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Wed, 23 Mar 2011 23:27:01 +0100 Subject: [PATCH 3/3] r600g: Handle texture fetch instructions with relative

[Mesa-dev] [PATCH 2/3] r600g: Handle texture fetch instructions with neg or abs on source register

This fixes the piglit tests shaders/glsl-deriv-varyings and shaders/glsl-derivs From 55e4fec8ff0cef3ec6cc8eee741a308b96c98df9 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Wed, 23 Mar 2011 23:26:41 +0100 Subject: [PATCH 2/3] r600g: Handle texture fetch instructions with neg or abs on source

[Mesa-dev] [PATCH 1/3] r600g: Handle texture fetch instructions with swizzle on source register

This fixes the following piglit tests: shaders/glsl-derivs-swizzle shaders/glsl-fs-shadow2d shaders/glsl-fs-shadow2d-01 shaders/glsl-fs-shadow2d-07 spec/ARB_texture_rg/fs-shadow2d-red-01 From 37ede956be2312cc6fea3c01a69ff267de5ae7e7 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Wed, 23 Mar

[Mesa-dev] [PATCH] r600g: Check for relative addressing in destination register when trying to merge instruction groups

eca929488701d4a8434cf4e4724c3c0066252f42 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Thu, 3 Mar 2011 10:08:08 +0100 Subject: [PATCH] r600g: Check for relative addressing in destination register when trying to merge instruction groups --- src/gallium/drivers/r600/r600_asm.c |9 - 1 files changed, 8 insertions

[Mesa-dev] [PATCH] r600g: Process TRUNC with tgis_op2

This fixes piglit test glsl-fs-texture2d-dependent-3. From 4eccbd6e36744b65f81f3c21021e9cf723f3a904 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Sun, 27 Feb 2011 16:10:55 +0100 Subject: [PATCH] r600g: Process TRUNC with tgis_op2 TRUNC is neither a scalar instruction nor exclusive to the

[Mesa-dev] [PATCH] r600g: Don't negate result of ABS instruction

This fixes piglit tests glsl-fs-abs-neg and glsl-vs-abs-neg. From b489ad266913eb7a492c7c72bed1f024ac185ef8 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Fri, 25 Feb 2011 10:11:37 +0100 Subject: [PATCH] r600g: Don't negate result of ABS instruction --- src/gallium/drivers/r600/r600_sha

[Mesa-dev] [PATCH] gallium/utils: Fix vertex element setup (resend)

Resend with fix suggested by Marek Olšák From 65250fbec01f0a596bce1b2177349adf1da7e92a Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Thu, 24 Feb 2011 10:56:16 +0100 Subject: [PATCH] gallium/utils: Fix vertex element setup Check if element was translated per element instead of per buffer

[Mesa-dev] [PATCH] gallium/utils: Fix vertex element setup

From 24c98993e595242e68ce2162627277dda8e234a2 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Thu, 24 Feb 2011 10:56:16 +0100 Subject: [PATCH] gallium/utils: Fix vertex element setup Check if element was translated per element instead of per buffer. --- src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH 1/2] gallium/utils: Translate all buffers in vbuf manager

Please disregard this patch. Marek Olšák pointed out to me that it is unecessary. Sorry for the noise. Fabian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] r600g: Request DWORD aligned vertex buffers.

x27;s probes with non-dword aligned strides pass without the patch. However, if you examine the rendered image you find that the respective triangles are not rendered correctly. Fabian From 4ee935e3f698a237eeb3c43be39d3dfe7b97f936 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Mon, 14 Feb 20

[Mesa-dev] [PATCH 1/2] gallium/utils: Translate all buffers in vbuf manager

From 73532f298726eb0a64f8b6c149b6c1a5f4b1228a Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Mon, 14 Feb 2011 22:37:12 +0100 Subject: [PATCH 1/2] gallium/utils: Translate all buffers in vbuf manager If one vertex element needs to be translated, translate all. Otherwise, the elements with

[Mesa-dev] [PATCH] r600g: Start a new TEX clause if the texture lookup address was fetched in the current clause

This fixes piglit test shaders/fp-indirections2 From ff041cc493a954cb0de64b045e6ea055d43e61fd Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Wed, 16 Feb 2011 10:02:47 +0100 Subject: [PATCH] r600g: Start a new TEX clause if the texture lookup address was fetched in the current clause --- src

[Mesa-dev] [PATCH] r600g: Add support to dump vertex- and texture-fetch clauses

From 998f82f834417f706506ba58b691dbb573d554b1 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Tue, 15 Feb 2011 13:00:49 +0100 Subject: [PATCH] r600g: Add support to dump vertex- and texture-fetch clauses --- src/gallium/drivers/r600/r600_asm.c | 57 ++- 1

[Mesa-dev] [PATCH] r600g: Fix RGB10_A2 format handling

This patch fixes the fbo/fbo-clear-formats piglit test. As PIPE_FORMAT_B10G10R10A2_UNORM is the only format the mesa state tracker uses, this is the only format I actualy tested. From 27238ed21d3f2d7a6912531ca9f01d508cf76931 Mon Sep 17 00:00:00 2001 From: Fabian Bieler Date: Thu, 10 Feb 2011 16

  1   2   >