On 1/15/19 8:02 AM, Daniel Stone wrote:
> Hi,
>
> On Tue, 18 Dec 2018 at 17:59, Lucas Stach wrote:
>> Am Dienstag, den 18.12.2018, 17:43 + schrieb Emil Velikov:
On Tue, 18 Dec 2018 at 11:16, Lucas Stach wrote:
if (dri2_surf->back == NULL)
dri2_surf->back
aiting for).
The easiest known reproduction case is running weston-subsurfaces under
weston --use-pixman
Signed-off-by: Derek Foreman
---
src/egl/drivers/dri2/platform_wayland.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/src/e
+++ b/src/egl/drivers/dri2/platform_wayland.c
@@ -676,7 +676,7 @@ get_fourcc(struct dri2_egl_display *dri2_dpy,
__DRIimage *image, int *fourcc)
{
EGLBoolean query;
- uint32_t dri_format;
+ int dri_format;
Yup, sorry.
Reviewed-by: Derek Foreman
query = dri2_dpy->
Please disregard, I misunderstood a comment in the bug tracker and this
has been posted here before.
Sorry for the line noise.
On 2017-11-14 09:39 AM, Derek Foreman wrote:
When queryImage doesn't support __DRI_IMAGE_ATTRIB_FOURCC wayland clients
will die with a NULL derefen
When queryImage doesn't support __DRI_IMAGE_ATTRIB_FOURCC wayland clients
will die with a NULL derefence in wl_proxy_add_listener.
Attempt to provide a simple fallback to keep ancient systems working.
Signed-off-by: Derek Foreman
---
src/egl/drivers/dri2/platform_wayland.c
nd client
under weston will result in a client side abort.
Signed-off-by: Derek Foreman
---
src/gallium/drivers/vc4/vc4_screen.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/src/gallium/drivers/vc4/vc4_screen.c
b/src/gallium/drivers/vc4/vc4
On 2017-09-27 01:49 PM, Emil Velikov wrote:
From: Emil Velikov
Now that wayland-drm (correctly) keeps a local copy of the callbacks,
this should not longer cause explosions.
After all the symbol is a local, constant data.
Cc: Daniel Stone
Cc: Derek Foreman
Signed-off-by: Emil Velikov
This fixes a crash from glTexImage2D() at startup for all EFL
applications on rpi3.
Thanks,
Tested-by: Derek Foreman
On 2017-09-07 12:17 PM, Eric Anholt wrote:
Only one of the three checks for dim was updated, so we would try to set a
UBO buffer index source value on a nir_load_uniform, and
ution.
Cc: Derek Foreman
Signed-off-by: Emil Velikov
I'd forgotten this was still in place - thanks for coming back to it.
Reviewed-by: Derek Foreman
---
One way to avoid the issue w/o bumping the requirement (for -stable) is
to add fall-back define alongside weak implementation of the
before commit f871946594129500a67c05a6d9fe99db54b4bb64
image_loader_extension was always present in dri2_dpy->extensions,
after that commit it is only present for render nodes.
Its removal broke partial render based on buffer age on (at least)
raspberry pi.
Signed-off-by: Derek Foreman
---
On 24/11/16 08:53 AM, Emil Velikov wrote:
On 24 November 2016 at 06:22, Boyan Ding wrote:
2016-11-24 13:29 GMT+08:00 Derek Foreman :
On 23/11/16 07:18 PM, Boyan Ding wrote:
2016-11-24 7:01 GMT+08:00 Derek Foreman :
This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e
except
On 23/11/16 07:18 PM, Boyan Ding wrote:
2016-11-24 7:01 GMT+08:00 Derek Foreman :
This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e
except for i915.
Original log for the i965 commit follows:
Some application, such as drm backend of weston, uses XRGB config as
default
f EGL takes ARGB as XRGB. Now that commit
65c8965d makes EGL recognize format correctly so weston won't start
because it can't find XRGB. Add XRGB format to i965 just as
other drivers do.
Signed-off-by: Derek Foreman
---
src/mesa/drivers/dri/i915/intel_screen.c
currently trim our queue in
any way, an application that briefly needs a large number of buffers
will continue to receive older buffers than it would if it only ever
needed two buffers.
Reviewed-by: Daniel Stone
Signed-off-by: Derek Foreman
---
The only changes are in the commit log, which hopefu
: Derek Foreman
---
src/egl/drivers/dri2/platform_drm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_drm.c
b/src/egl/drivers/dri2/platform_drm.c
index 2099314..f812ab5 100644
--- a/src/egl/drivers/dri2/platform_drm.c
+++ b/src/egl/drivers
wapBuffers, unless and until we can find a more gentle
behaviour.
Ping - adding a couple more CCs.
This looks correct to me. I've done some testing with weston and
enlightenment and various EFL clients, and note no regressions.
Reviewed-by: Derek Foreman
Tested-by: Derek Foreman
On 16/02/16 10:37 AM, Daniel Stone wrote:
> Hi,
>
> On 16 February 2016 at 16:34, Derek Foreman wrote:
>> +try_damage_buffer(struct dri2_egl_surface *dri2_surf,
>> + const EGLint *rects,
>> + EGLin
t the incoming
damage as being in buffer co-ordinates.
Reviewed-by: Jason Ekstrand
Reviewed-by: Pekka Paalanen
Signed-off-by: Derek Foreman
---
Changes from v1:
Add comment explaining why the call to wl_proxy_get_version() is hidden
by the seemingly unrelated macro.
src/egl/drivers
On 12/02/16 04:46 PM, Emil Velikov wrote:
> On 11 February 2016 at 16:34, Derek Foreman wrote:
>> Since commit d1314de293e9e4a63c35f094c3893aaaed8580b4 we ignore
>> damage passed to SwapBuffersWithDamage.
>>
>> Wayland 1.10 now has functionality that allows us to prope
t the incoming
damage as being in buffer co-ordinates.
Signed-off-by: Derek Foreman
---
src/egl/drivers/dri2/platform_wayland.c | 32 +---
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/src/egl/drivers
This is already our common idiom for opening files with CLOEXEC and
it's a little ugly, so let's share this one implementation.
Signed-off-by: Derek Foreman
---
src/loader/loader.c | 6 +++---
src/loader/loader.h | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/
We've moved the open with CLOEXEC idiom into a helper function, so
call it instead of duplicating the code here.
Signed-off-by: Derek Foreman
---
src/glx/dri2_glx.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
Replacing dup() with fcntl F_DUPFD_CLOEXEC creates the duplicate
file descriptor with CLOEXEC so it won't be leaked to child
processes if the process fork()s later.
Signed-off-by: Derek Foreman
---
src/egl/drivers/dri2/platform_drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
We've moved the open with CLOEXEC idiom into a helper function, so
call it instead of duplicating the code.
This also replaces a couple of opens that didn't properly do CLOEXEC.
Signed-off-by: Derek Foreman
---
src/egl/drivers/dri2/platform_drm.c | 4 ++--
src/egl/dr
This series catches a couple of places where we forget to set CLOEXEC on
file descriptors, and makes a helper function for the necessarily ugly
way we have to open fds to make sure CLOEXEC is set.
Derek Foreman (4):
egl/drm: Duplicate fd with F_DUPFD_CLOEXEC to prevent leak
loader: Rename
On 12/06/15 06:04 PM, Emil Velikov wrote:
> On 12/06/15 19:07, Derek Foreman wrote:
>> We do this right almost everywhere already, but the idiom is a little
>> gruesome. This moves it into loader.c and fixes dri2_initialize_drm()
>> which could open without CLOEXEC in some ca
On 12/06/15 05:52 PM, Emil Velikov wrote:
> On 12/06/15 19:05, Derek Foreman wrote:
>> On 12/06/15 11:29 AM, Emil Velikov wrote:
>>> Hi Derek,
>>
>> Hi, thanks for looking at this. :)
>>
> Props goes to Matt, for the reminder. It kind of fell of my rada
Prevents fd leak if the caller forks later.
Signed-off-by: Derek Foreman
---
src/egl/drivers/dri2/platform_drm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/drivers/dri2/platform_drm.c
b/src/egl/drivers/dri2/platform_drm.c
index 3391afc..5c356c4 100644
--- a/src/egl/drivers
We do this right almost everywhere already, but the idiom is a little
gruesome. This moves it into loader.c and fixes dri2_initialize_drm()
which could open without CLOEXEC in some cases.
Signed-off-by: Derek Foreman
---
src/egl/drivers/dri2/platform_drm.c | 4 ++--
src/egl/drivers/dri2
On 12/06/15 11:29 AM, Emil Velikov wrote:
> Hi Derek,
Hi, thanks for looking at this. :)
> On 1 May 2015 at 18:34, Derek Foreman wrote:
>> These fds can propagate to child processes if we don't set CLOEXEC,
>> so make a best effort to do that.
>>
&g
These fds can propagate to child processes if we don't set CLOEXEC,
so make a best effort to do that.
Signed-off-by: Derek Foreman
---
Noticed this when fixing up similar problems in weston - weston's
drm fd gets dup()ed here and loses CLOEXEC and ends up in every child
process
31 matches
Mail list logo
