Re: [Mesa-dev] [PATCH] dir-locals.el: use appropriate c-file-style

On Mon, Mar 6, 2017 at 7:44 PM, Ilia Mirkin wrote: > What's the difference between c-file-style linux and stroustrup? The main differences are that stroustrup sets c-basic-offset to 4 while linux uses 8 and linux defines braces around "else" on single line, i.e.: "} else {". Even if these get tw

[Mesa-dev] [PATCH] dir-locals.el: use appropriate c-file-style

Add .dir-locals.el and .editorconfig files in src/amd/vulkan and src/amd/common since they don't use the coding style defined in the root .dir-locals.el. Also update the styles for other directories that appear to use the Linux kernel style. Signed-off-by: Damien Grassart --- src/amd/c

Re: [Mesa-dev] [PATCH] dir-locals.el: use appropriate style and stop unsafe warning

Actually please ignore this, cc-mode does not actually work the way I thought it should. Sorry for the noise. On Mon, Mar 6, 2017 at 1:00 PM, Damien Grassart wrote: > This updates the c-file-style for directories that appear to use Linux > kernel style rather than the Stroustrup style, an

[Mesa-dev] [PATCH] dir-locals.el: use appropriate style and stop unsafe warning

ables. Signed-off-by: Damien Grassart --- .dir-locals.el| 2 +- src/amd/vulkan/.dir-locals.el | 11 +++ src/amd/vulkan/.editorconfig | 2 ++ src/gallium/drivers/freedreno/.dir-locals.el | 2 +- src/ga

Re: [Mesa-dev] [PATCH] radv: add .dir-locals.el to make radv code more readable in Emacs

On Mon, Mar 6, 2017 at 7:44 AM, Michel Dänzer wrote: > This doesn't seem consistent with existing .dir-locals.el files in the > tree. If any of those files match the Linux kernel coding style as well, > it would be good to make them all consistent one way or another. Hi Michel, you're right, I wi

[Mesa-dev] [PATCH] radv: remove duplicate initialization of alphaToOne feature

Fixes a GCC warning when compiling with -Wextra: radv_device.c:463:47: warning: initialized field overwritten [-Woverride-init] Signed-off-by: Damien Grassart --- src/amd/vulkan/radv_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan

[Mesa-dev] [PATCH] radv: add .dir-locals.el to make radv code more readable in Emacs

The current root .dir-locals.el doesn't match the radv coding style, causing Emacs to highlight nearly every line and edits to use 3-space indentation. This sets the c-file-style to "linux" since that appears to be the radv coding style. Signed-off-by: Damien Grassart --- src/

Re: [Mesa-dev] [PATCH v2] gallium/targets: don't leave an empty target directory(ies)

This breaks make install for me as well. Does this patch make sense for XvMC since by default it gets installed to '${libdir}' (while VDPAU goes to '${libdir}/vdpau' by default)? Should there be a check to make sure ${dest_dir} isn't ${libdir}? Thanks, -Damien On Sun, Mar 5, 2017 at 3:11 PM Andy

[Mesa-dev] [PATCH] anv: return count of queue families written

The Vulkan spec indicates that vkGetPhysicalDeviceQueueFamilyProperties() should overwrite pQueueFamilyPropertyCount with the number of structures actually written to pQueueFamilyProperties. Signed-off-by: Damien Grassart --- src/intel/vulkan/anv_device.c | 1 + 1 file changed, 1 insertion

[Mesa-dev] [PATCH] radv: return count of queue families written

The Vulkan spec indicates that vkGetPhysicalDeviceQueueFamilyProperties() should overwrite pQueueFamilyPropertyCount with the number of structures actually written to pQueueFamilyProperties. Signed-off-by: Damien Grassart --- src/amd/vulkan/radv_device.c | 5 - 1 file changed, 4 insertions