Re: [Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

2014-06-25 Thread Christoph Brill
Reviewed-by: Christoph Brill Am 25.06.2014 04:15 schrieb "Ian Romanick" : > From: Ian Romanick > > Mesa has an optimization that converts expressions like "v.x + v.y + v.z > + v.w" into dot(v, 1.0). And therein lies the rub: the other operand to > the dot-p

Re: [Mesa-dev] [PATCH 2/3] ra: Create a reg_belongs_to_class() helper function.

2014-03-18 Thread Christoph Brill
It's a bit picky as compilers are likely to detect this themselves, but an 'inline' might be nice. Nonetheless I'm in favor for everything that improves code readability, so: Reviewed-By: Christoph Brill Am 17.03.2014 21:32 schrieb "Kenneth Graunke" : >

Re: [Mesa-dev] [PATCH 1/9] gallivm: add a lp_build_intrinsic_map_trinary() function

2014-01-05 Thread Christoph Brill
Am 05.01.2014 00:42 schrieb "Maxence Le Doré" : > > From: Maxence Le Doré It appears that something in your bit setup might be wrong. Normally you should have your mail address in between <> and not your name. You might want run something like 'git config user.email "maxence.led...@gmail.com"'.

Re: [Mesa-dev] [PATCH 01/10] radeon: move some functions to r600_buffer.c

2013-11-29 Thread Christoph Brill
Reviewed-by: Christoph Brill 2013/11/29 Marek Olšák > From: Marek Olšák > > --- > src/gallium/drivers/radeon/Makefile.sources | 1 + > src/gallium/drivers/radeon/r600_buffer.c | 133 > ++ > src/gallium/drivers/radeon/r60

Re: [Mesa-dev] [PATCH 04/17] Modified llvmpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-25 Thread Christoph Brill
Am 25.11.2013 06:36 schrieb "Siavash Eliasi" : > > --- > src/gallium/drivers/llvmpipe/lp_screen.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c > index f61df98..8be1779 100644 > --- a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 02/17] Modified softpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-25 Thread Christoph Brill
Am 25.11.2013 06:36 schrieb "Siavash Eliasi" : > > --- > src/gallium/drivers/softpipe/sp_screen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c > index 47ef20e..022b5bf 100644 > --- a/src

Re: [Mesa-dev] [PATCH 5/6] i965/vs: implement ir_query_levels

2013-10-05 Thread Christoph Brill
2013/10/5 Chris Forbes > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp > b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp

Re: [Mesa-dev] [PATCH 0/4] RFC: gl_shader cache

2013-09-20 Thread Christoph Brill
2013/9/20 Tapani Pälli > Hello; > > This is RFC for shader cache implementation, goal is to optimize > application > startup time. The implementation is based on idea that Kenneth had on a > Mesa > branch for memory based cache. These patches implement a 'behind the > scenes' > cache for shader c

[Mesa-dev] Improved Patch review using Gerrit

2013-05-08 Thread Christoph Brill
Hi list, I'm trying to follow the patches and patchsets sent to mesa-dev and really like the process of how they get reviewed. It's a good way of catching bugs before they get committed. But currently this approach has a downside (at least for me): It's easy to miss a patch and happens from time t