Reviewed-by: Bruce Cherniak
> On Dec 17, 2018, at 8:36 AM, Alok Hota wrote:
>
> To make debugging simpler
> ---
> .../swr/rasterizer/jitter/JitManager.cpp | 27 +--
> .../swr/rasterizer/jitter/JitManager.h| 12 -
> 2 files changed, 36 insertions(+), 3 deletio
Reviewed-by: Bruce Cherniak
> On Dec 17, 2018, at 8:36 AM, Alok Hota wrote:
>
> - added graphics address translation in odd gathers
> - added support for unaligned gathers in fetch shader
> - changed how 2+ GB offsets are handled to make them compatible with
> unaligned offsets
> ---
> .../swr
Reviewed-by: Bruce Cherniak
> On Dec 17, 2018, at 8:36 AM, Alok Hota wrote:
>
> Avoids confusion with other defaulted integer parameters
>
> - fixed some unspecified usages
> - removed unnecessary includes
> - removed unecessary protected access specifier in buckets framework
> ---
> .../driv
Reviewed-by: Bruce Cherniak
> On Dec 17, 2018, at 8:36 AM, Alok Hota wrote:
>
> Use gfxptr_t type value for stream pointer uses in gather and similar
> calls
> ---
> .../swr/rasterizer/jitter/fetch_jit.cpp | 34 +--
> 1 file changed, 16 insertions(+), 18 deletions(-)
>
>
Reviewed-by: Bruce Cherniak
> On Dec 17, 2018, at 8:36 AM, Alok Hota wrote:
>
> Fixes relocation errors with LLVM 7.0.0
> ---
> .../swr/rasterizer/jitter/JitManager.cpp | 79 +++
> .../swr/rasterizer/jitter/JitManager.h| 28 +--
> 2 files changed, 65 insertions(+
Reviewed-by: Bruce Cherniak
> On Dec 17, 2018, at 8:36 AM, Alok Hota wrote:
>
> - updated sample from TRTT surfaces correctly
> - implemented mapped status return for TRTT surfaces
> - implemented per-sample instruction minLod clamp
> - updated bilinear filter weight calculation to be closer t
Reviewed-by: Bruce Cherniak
> On Dec 17, 2018, at 8:36 AM, Alok Hota wrote:
>
> This improves cache filesystem performance, especially during CI tests
> Also updated jitcache magic number due to codegen parameter changes
> Removed 2 `if constexpr` to prevent C++17 requirement
> ---
> .../swr/r
Hello and apologies for such a delayed response — we were quite busy with the
SC’18
supercomputing conference.
On Oct 17, 2018, at 3:37 PM, Roland Scheidegger
mailto:srol...@vmware.com>> wrote:
Am 17.10.18 um 19:15 schrieb Gert Wollny:
Dear all,
we are looking into doing a CI for virglrenderer
Reviewed-by: Bruce Cherniak
> On Oct 17, 2018, at 1:51 PM, Alok Hota wrote:
>
> This function's API changed between LLVM 5 and 6. Compile errors occur
> when building with LLVM 6+ if LLVM 5 was used for a dist tarball
> ---
> .../drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 3 +
Reviewed-by: Bruce Cherniak
> On Oct 15, 2018, at 9:53 AM, Alok Hota wrote:
>
> Converted from x86 VFMADDPS intrinsic to generic LLVM intrinsic, and
> removed createInstructionSimplifierPass, which were both removed in LLVM
> 7.0.0
>
> These changes combine patches we received from the communi
res LLVM 5.0.
>>
>> Let's bump required LLVM to 6.0 in swr too.
>>
>> Fixes: fd1121e839 ("amd: remove support for LLVM 5.0")
>> Cc: Tim Rowley
>> Cc: Emil Velikov
>> Cc: Dylan Baker
>> Cc: Eric Engestrom
>
> CC: "Chern
.com>> wrote:
Hi Bruce,
Thank you, could you please merge commits? (I don't have commit rights.)
On Fri, Jul 27, 2018 at 11:02 PM Cherniak, Bruce
mailto:bruce.chern...@intel.com>> wrote:
Reviewed-by: Bruce Cherniak
mailto:bruce.chern...@intel.com>>
> On Jul 27, 2018
Reviewed-by: Bruce Cherniak
> On Jul 27, 2018, at 1:45 PM, Denis Pauk wrote:
>
> Reuse Code from:
> f69bc797e1 gallium/auxiliary: Add helper support for bptc format
> compress/decompress
>
> Signed-off-by: Denis Pauk
> CC: Marek Olšák
> CC: Bruce Cherniak
> CC: Tim Rowley
> ---
> src/gal
Reviewed-by: Bruce Cherniak
> On Jun 28, 2018, at 2:17 PM, Alok Hota wrote:
>
> Sorry for the churn on these patches. They had to be split in three due
> to some code change in between a mass formatting change. Anyway this
> patch contains only formatting changes for the files that were update
v2 Reviewed-by: Bruce Cherniak
> On Jun 25, 2018, at 9:52 AM, Alok Hota wrote:
>
> These code changes were made in between some of the formatting changes.
> Unforunately we do have another formatting patch coming in after this,
> but I will keep that separate.
>
> These patches are primarily
Reviewed-by: Bruce Cherniak
> On Jun 25, 2018, at 9:52 AM, Alok Hota wrote:
>
> ---
> .../swr/rasterizer/jitter/builder_gfx_mem.cpp | 13 +
> .../drivers/swr/rasterizer/jitter/builder_gfx_mem.h | 6 ++
> 2 files changed, 19 insertions(+)
>
> diff --git a/src/gallium/driver
Reviewed-by: Bruce Cherniak
> On Jun 22, 2018, at 9:11 AM, Alok Hota wrote:
>
> ---
> .../swr/rasterizer/jitter/JitManager.cpp | 133 ++--
> .../swr/rasterizer/jitter/builder_gfx_mem.cpp | 90 +
> .../swr/rasterizer/jitter/builder_gfx_mem.h | 101 +-
> .../jitter/f
Reviewed-by: Bruce Cherniak
> On Jun 19, 2018, at 10:03 AM, Alok Hota wrote:
>
> These code changes were made in between some of the formatting changes.
> Unforunately we do have another formatting patch coming in after this,
> but I will keep that separate.
>
> These patches are primarily foc
> On Jun 18, 2018, at 9:23 AM, Juan A. Suarez Romero
> wrote:
>
> RADV now requires LLVM 5.0 or greater, and thus we can't build dist
> tarball because swr requires LLVM 4.0.
>
> Let's bump required LLVM to 5.0 in swr too.
Sorry, I didn't see this sooner. We are fine with bumping the swr min
Reviewed-by: Bruce Cherniak
(and thanks for not emailing such a huge patch)
> On Jun 8, 2018, at 3:01 PM, Alok Hota wrote:
>
> Sorry for the large patch - the changes are all whitespace and code
> formatting for the swr driver and its rasterizer.
> The patch file itself is available on Github
V2: Good catch!
Reviewed-by: Bruce Cherniak
> On May 25, 2018, at 10:19 AM, Alok Hota wrote:
>
> Version 2 makes a small change to swr_loader.cpp to include the new InitMemory
> header, which fixes a compile error on single-architecture builds.
>
> Alok Hota (7):
> swr/rast: Added in-place b
Entire patchset: 1-7 (What I meant to say in the first place)
Reviewed-by: Bruce Cherniak
> On May 24, 2018, at 11:13 AM, Cherniak, Bruce
> wrote:
>
> Patchset (1/7)
> Reviewed-by: Bruce Cherniak
>
>> On May 23, 2018, at 2:58 PM, Alok Hota wrote:
>>
>
Patchset (1/7)
Reviewed-by: Bruce Cherniak
> On May 23, 2018, at 2:58 PM, Alok Hota wrote:
>
> SCATTERPS previously assumed it was being used with an existing basic
> block
> ---
> .../drivers/swr/rasterizer/jitter/builder_mem.cpp | 29 +++---
> 1 file changed, 20 insertions(+)
On May 14, 2018, at 8:59 AM, Alexandre
mailto:alexandre.gauthier-foic...@inria.fr>>
wrote:
Hello,
Sorry for the inconvenience if this message is not appropriate for this mailing
list.
The following is a question for developers of the swr driver of gallium.
I am the main developer of a motio
Reviewed-by: Bruce Cherniak
> On May 4, 2018, at 1:40 PM, George Kyriazis wrote:
>
> Misc OpenSWR changes
>
> George Kyriazis (7):
> swr/rast: Change formatting
> swr/rast: Use binner topology to assemble backend attributes
> swr/rast: Add constant initializer for uint64_t
> swr/rast: Add
Reviewed-by: Bruce Cherniak
> On Apr 25, 2018, at 2:21 PM, George Kyriazis
> wrote:
>
> Misc changes. Include:
> - fix KNL behavior with LLVm 6.0.0
> - fix byte offset for non-indexed draws
> - fix 64-bit float handling with code generator
> - misc cleanup
>
> George Kyriazis (21):
> swr/r
Entire patch set Reviewed-by: Bruce Cherniak
> On Apr 17, 2018, at 8:31 PM, George Kyriazis
> wrote:
>
>
> Lots of SWR-specifc changes, including:
> - work for 16-wide simd operation across all avx flavors
> - separate avx instrinsics into a separate x86 lowering pass
> - stats work
> - mis
Code looks good. I'm not able to test it, but it's isolated within #defined(
__APPLE__).
Thanks for the contribution.
Reviewed-by: Bruce Cherniak
> On Mar 14, 2018, at 6:19 PM, Jeremy Huddleston Sequoia
> wrote:
>
> From: Apple SWE
>
> The implementation for bootstrapping SWR on Darwin t
We don't currently build SWR on OS X, I've had difficulty building Mesa on OS X
in general.
But, I'd be very interesting in learning. Thanks for the patch.
Reviewed-by: Bruce Cherniak
> On Mar 14, 2018, at 6:19 PM, Jeremy Huddleston Sequoia
> wrote:
>
> From: Apple SWE
>
> sched_yield is
patch set (1 through 9) Reviewed-by: Bruce Cherniak
> On Mar 7, 2018, at 7:32 PM, George Kyriazis wrote:
>
> ---
> src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_mem.cpp
> b/s
Reviewed-by: Bruce Cherniak
> On Feb 28, 2018, at 1:16 PM, George Kyriazis
> wrote:
>
> Populate pLastIndex, even for the non-indexed case. An zero pLastIndex
> can cause the index offsets inside the fetcher to have non-sensical values
> that can be either very large positive or very large n
Reviewed-by: Bruce Cherniak
> On Feb 27, 2018, at 2:12 PM, George Kyriazis
> wrote:
>
> v2 is a merged patchset of the following email threads:
> <1519312447-27403-1-git-send-email-george.kyria...@intel.com>
> <1519317122-3529-1-git-send-email-george.kyria...@intel.com>
>
> The cc to mesa-st
Entire set Reviewed-by: Bruce Cherniak
> On Feb 13, 2018, at 4:42 PM, George Kyriazis
> wrote:
>
> Batch patchset of SWR rasterizer-related changes
>
> George Kyriazis (31):
> swr/rast: Add missing parameter to a few gather functions
> swr/rast: Cleanup knob definitions
> swr/rast: Don't
Reviewed-by: Bruce Cherniak
> On Jan 24, 2018, at 2:50 PM, George Kyriazis
> wrote:
>
> Modify DumpToFile to only dump the function, not the entire module.
> Reduces file sizes and speeds up the dumping.
> ---
> src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 3 +--
> 1 file changed,
Series Reviewed-by: Bruce Cherniak
> On Jan 24, 2018, at 9:31 AM, George Kyriazis
> wrote:
>
> Early Rasterization did not initially work with USE_SIMD16_FRONTEND=0.
> Fix it so it works there, too. Please note that the default setting
> is USE_SIMD16_FRONTEND=1.
> ---
> .../drivers/swr/rast
v2 is Reviewed-by: Bruce Cherniak
> On Jan 24, 2018, at 2:43 PM, George Kyriazis
> wrote:
>
> LLVM 3.9 was not taken into account in initial check-in.
>
> Fixes: 01ab218bbc ("swr/rast: Initial work for debugging support.")
> cc: mesa-sta...@lists.freedesktop.org
> Bugzilla: https://bugs.free
On Jan 24, 2018, at 11:43 AM, Emil Velikov
mailto:emil.l.veli...@gmail.com>> wrote:
On 24 January 2018 at 15:30, George Kyriazis
mailto:george.kyria...@intel.com>> wrote:
LLVM 3.9 was not taken into in initial check-in.
In addition to Emil's comments, please correct commit message to make sens
Reviewed-by: Bruce Cherniak
> On Jan 19, 2018, at 5:03 PM, George Kyriazis
> wrote:
>
> For some reason llvm5 is picky about accepting a void * type in the
> case of building an argument list.
>
> Since we don't care about the type (we ignore the argument for now),
> pick another pointer typ
Entire set.
Reviewed-by: Bruce Cherniak
> On Jan 19, 2018, at 3:46 PM, George Kyriazis
> wrote:
>
> Also including:
> - enabling of SIMD16 VS
> - Early Rasterization implementation
>
> George Kyriazis (20):
> swr/rast: Fix one more invalid object format for windows.
> swr/rast: Added mis
Thanks Chuck!
Reviewed-by: Bruce Cherniak
> On Jan 18, 2018, at 1:57 PM, Chuck Atkins wrote:
>
> Part 1 of 2 (part 1 is autoconf changes, part 2 is C++ changes)
>
> When only a single SWR architecture is being used, this allows that
> architecture to be builtin rather than as a separate libsw
Thanks Chuck!
Reviewed-by: Bruce Cherniak
> On Jan 18, 2018, at 1:57 PM, Chuck Atkins wrote:
>
> Part 2 of 2 (part 1 is autoconf changes, part 2 is C++ changes)
>
> When only a single SWR architecture is being used, this allows that
> architecture to be builtin rather than as a separate libsw
Apologies for not seeing this over the holidays.
Reviewed-by: Bruce Cherniak
mailto:bruce.chern...@intel.com>>
On Jan 18, 2018, at 12:03 PM, Emil Velikov
mailto:emil.l.veli...@gmail.com>> wrote:
On 31 December 2017 at 16:55, Greg V
mailto:greg@unrelenting.technology>> wrote:
---
src/gallium/d
> On Jan 16, 2018, at 1:59 PM, Chuck Atkins wrote:
>
> Part 2 of 2 (part 1 is autoconf changes, part 2 is C++ changes)
>
> When only a single SWR architecture is being used, this allows that
> architecture to be builtin rather than as a separate libswrARCH.so that
> gets loaded via dlopen. Sin
With a minor comment change (below)
Reviewed-by: Bruce Cherniak
> On Jan 16, 2018, at 1:59 PM, Chuck Atkins wrote:
>
> Part 1 of 2 (part 1 is autoconf changes, part 2 is C++ changes)
>
> When only a single SWR architecture is being used, this allows that
> architecture to be builtin rather th
On Jan 16, 2018, at 1:40 PM, Chuck Atkins
mailto:chuck.atk...@kitware.com>> wrote:
Perhaps one can split out the .cpp and build changes somehow.
Good idea. It's easy enough to split and without the autoconf changes the
existing behavior will still be preserved so the other two builds can stil
Reviewed-by: Bruce Cherniak
> On Jan 9, 2018, at 11:50 AM, George Kyriazis
> wrote:
>
> BuilderSWR::swr_gs_llvm_fetch_input() (and consequently
> swr_gs_llvm_fetch_input()), did not handle the case where
> is_vindex_indirect or is_aindex_direct is set.
>
> Implement it, using the code in dra
Set Reviewed-by: Bruce Cherniak
> On Jan 4, 2018, at 12:58 PM, Tim Rowley wrote:
>
> Highlights include simd16 cleanup (renaming and removing old
> codepaths), fixing a potential crash with the fetch shader, and code
> cleanups.
>
> Tim Rowley (6):
> swr/rast: SIMD16 builder - cleanup naming
Reviewed-by: Bruce Cherniak
> On Jan 4, 2018, at 10:33 AM, Tim Rowley wrote:
>
> Should be 0x8000 instead of 0x800.
>
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl | 2 +-
> src/gallium/drivers/swr/rasterizer/common/simd
On Dec 21, 2017, at 6:41 PM, Andres Rodriguez
mailto:andre...@gmail.com>> wrote:
Rename fences -> semaphores in preparation for upgrading fence
functionality.
This series renames the following symbols:
- pipe_fence_handle -> pipe_semaphore_handle
- fence_server_sync -> semaphore_server_sync
Reviewed-by: Bruce Cherniak
> On Jan 2, 2018, at 10:57 AM, Tim Rowley wrote:
>
> LLVM api change.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104381
> ---
> src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/
This change only affects the client buffer case (swr_user_vbuf_range), not VBOs.
Reviewed with the caveat that the patch description be changed to remove "VBO"
Reviewed-by: Bruce Cherniak
> On Dec 15, 2017, at 10:22 AM, George Kyriazis
> wrote:
>
> Account for info.index_bias when calculating
> On Dec 17, 2017, at 10:23 AM, Andres Gomez wrote:
>
> Bruce, this depends on ead0dfe31ec7 which didn't make it for the 17.2
> queue so I will be leaving out from there.
Hi Andres, it is fine to leave out for 17.2, that branch is fine.
We would like this in 17.3 stable, however. 17.3.0 contai
Reviewed-by: Bruce Cherniak
> On Dec 14, 2017, at 3:34 PM, Tim Rowley wrote:
>
> Highlights include simd16 work, thread pool initialization rework,
> and code cleanup.
>
> Tim Rowley (20):
> swr/rast: Remove unneeded copy of gather mask
> swr/rast: Binner fixes for viewport index offset han
Reviewed-by: Bruce Cherniak
> On Dec 5, 2017, at 10:50 AM, George Kyriazis
> wrote:
>
> gen_BackendPixelRate*.cpp depends on gen_ar_eventhandler.hpp.
> Fix missing dependency.
> ---
> src/gallium/drivers/swr/SConscript | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drive
Reviewed-by: Bruce Cherniak
> On Nov 20, 2017, at 11:18 AM, Tim Rowley wrote:
>
> Highlights are code cleanups and more progress on simd16.
>
> Tim Rowley (10):
> swr/rast: support flexible vertex layout for DS output
> swr/rast: Widen fetch shader to SIMD16
> swr/rast: Code style change (N
Reviewed-by: Bruce Cherniak
> On Nov 13, 2017, at 8:03 PM, Tim Rowley wrote:
>
> Speed up simd16 frontend (default) on avx/avx2 platforms;
> fixes performance regression caused by switch to simdlib.
>
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> .../swr/rasterizer/common/simdlib_512_emu.in
Reviewed-by: Bruce Cherniak
> On Nov 13, 2017, at 8:03 PM, Tim Rowley wrote:
>
> Speed up avx512 platforms; fixes performance regression caused
> by swithc to simdlib.
>
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> .../drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 12 +
Reviewed-by: Bruce Cherniak
> On Oct 19, 2017, at 4:40 PM, George Kyriazis
> wrote:
>
> Remove allocation of > 2kbyte buffers into context memory in
> swr_copy_to_scatch_space() (which is used to copy small vertex/index buffers
> and shader constants to a scratch space to be used by the upcom
Reviewed-by: Bruce Cherniak
> On Oct 19, 2017, at 8:12 AM, Tim Rowley wrote:
>
> Highlights are code cleanups, some more simd16 work (disabled by default),
> and tuning for the Intel Xeon Phi architecture.
>
> Tim Rowley (7):
> swr/rast: Minor changes for os-x
> swr/rast: Miscellaneous vie
Reviewed-by: Bruce Cherniak
> On Oct 11, 2017, at 10:50 AM, Rowley, Timothy O
> wrote:
>
> Start building vertex shaders as simd16.
>
> Disabled by default, set USE_SIMD16_SHADERS in knobs.h to experiment.
>
> Cc: Bruce Cherniak
> ---
> src/gallium/drivers/swr/swr_screen.cpp | 6 ++
>
Reviewed-by: Bruce Cherniak
> On Oct 3, 2017, at 3:23 PM, Tim Rowley wrote:
>
> Causing a crash in ParaView waveletcontour.py test when
> _DEBUG defined due to vector aligned copy with unaligned
> address.
> ---
> src/gallium/drivers/swr/rasterizer/core/clip.h | 4 ++--
> 1 file changed, 2 inse
Reviewed-by: Bruce Cherniak
> On Sep 25, 2017, at 5:28 PM, George Kyriazis
> wrote:
>
> No need to check if screen->pipe != pipe, so we can just assign it. Just do
> it.
> ---
> src/gallium/drivers/swr/swr_state.cpp | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/
Reviewed-by: Bruce Cherniak
> On Sep 25, 2017, at 5:28 PM, George Kyriazis
> wrote:
>
> Swr caches fb contents in tiles. Those tiles are stored on a per-context
> basis.
>
> When switching contexts that share resources we need to make sure that
> the tiles of the old context are being store
Reviewed-by: Bruce Cherniak
> On Sep 21, 2017, at 7:46 PM, Tim Rowley wrote:
>
> Highlights: large change in the geometry shader api, cleanups.
>
> Tim Rowley (9):
> swr/rast: Add support for R10G10B10_FLOAT_A2_UNORM pixel format
> swr/rast: New GS state/context API
> swr/rast: Fetch compi
+ // control header
(SWR_VTX_NUM_SLOTS * 16) * // sizeof vertex
pGS->maxNumVerts; // num verts
On Sep 23, 2017, at 9:51 PM, Cherniak, Bruce
mailto:bruce.chern...@intel.com>> wrote:
On Sep 21, 2017, at 7:46 PM, Tim Rowley
mailto:timothy.o.row...@intel.com>> wrote:
O
> On Sep 21, 2017, at 7:46 PM, Tim Rowley wrote:
>
> One piglit regression, which was a false pass:
> spec@glsl-1.50@execution@geometry@dynamic_input_array_index
> ---
> .../drivers/swr/rasterizer/core/frontend.cpp | 227 -
> src/gallium/drivers/swr/rasterizer/core/stat
> On Sep 20, 2017, at 8:13 AM, Laurent Carlier wrote:
>
> Le mardi 19 septembre 2017, 21:25:42 CEST Tim Rowley a écrit :
>> We currently don't use these instructions, and since their API
>> changed in llvm-5.0 having them in the autogen files broke the mesa
>> release tarballs which ship with gen
Regardless of making it a v2, etc. :-) Sorry for the complication of not being
able to just accept the original.
Reviewed-by: Bruce Cherniak
> On Sep 12, 2017, at 8:03 AM, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
> ---
> src/gallium/drivers/swr/rasterizer/memory/StoreTile.h
Reviewed-by: Bruce Cherniak
> On Sep 11, 2017, at 2:28 PM, Tim Rowley wrote:
>
> Mostly some api changes, plus making the cpu topology code a bit more
> robust in the face of some odd configurations seen in virtualized
> environments.
>
> No piglit or vtk ctest regressions.
>
> Tim Rowley (1
>
> On Sep 7, 2017, at 5:21 AM, Eric Engestrom wrote:
>
> Signed-off-by: Eric Engestrom
> ---
> src/gallium/drivers/swr/rasterizer/memory/StoreTile.h | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/gallium/drivers/swr/rasterizer/memory/StoreTile.h
> b/sr
Reviewed-by: Bruce Cherniak
> On Sep 7, 2017, at 3:53 AM, Thomas Hellstrom wrote:
>
> This fixes a regression introduced with commit
> eceb6710024716433069d705fbd873d6d136c2cc:
> "mesa/st: Reduce the number of frontbuffer flush calls"
> where we, after flushing the front buffer marked it as no
Reviewed-by: Bruce Cherniak
> On Sep 5, 2017, at 1:57 PM, Tim Rowley wrote:
>
> Highlight is starting to unify the simd/simd16 code, removing lots of
> temporary code duplication.
>
> No piglit or vtk test regressions.
>
> Tim Rowley (8):
> swr/rast: Allow gather of floats from fetch shader
Gentle bump. This fixes mesa master for Kitware's VTK testing.
> On Aug 25, 2017, at 2:59 PM, Cherniak, Bruce wrote:
>
> Accompanying patch "st/mesa: only try to create 1x msaa surfaces for
> 'fake' msaa" requires driver to report max_samples=1 to enable &q
Gentle bump. This fixes mesa master for Kitware's VTK testing.
> On Aug 25, 2017, at 2:59 PM, Bruce Cherniak wrote:
>
> From: Brian Paul
>
> For software drivers where we want "fake" msaa support for GL 3.x, we
> treat 1 sample as being msaa.
>
> For drivers with real msaa support, start for
Reviewed-by: Bruce Cherniak
> On Aug 23, 2017, at 11:19 AM, Tim Rowley wrote:
>
> Only copy this value when in restart drawing mode.
>
> Eliminates valgrind errors when running trivial programs.
> ---
> src/gallium/drivers/swr/swr_draw.cpp | 5 -
> 1 file changed, 4 insertions(+), 1 deleti
Reviewed-by: Bruce Cherniak
> On Aug 9, 2017, at 5:22 PM, Tim Rowley wrote:
>
> CID: 1416243, 1416244, 1416255
> CC: mesa-sta...@lists.freedesktop.org
> ---
> src/gallium/drivers/swr/rasterizer/core/api.cpp | 2 +-
> src/gallium/drivers/swr/rasterizer/core/context.h | 8
> src/gall
>
> On Aug 2, 2017, at 10:30 PM, Brian Paul wrote:
>
> I'll let Charmaine review, but the subject line prefix should probably be
> "st/osmesa".
Thanks, I'll clarify the subject line on commit.
> -Brian
>
> On 08/02/2017 05:28 PM, Bruce Cherniak wrote:
>> Commit bbc29393d3 didn't include osme
Entire set
Reviewed-by: Bruce Cherniak
> On Aug 1, 2017, at 2:44 PM, Tim Rowley wrote:
>
> Highlights include enabling the simd16 frontend and code cleanups.
>
> v2: split previous gen_knobs patch into five chunks: scons fix,
> relicense to match rest of tree, code style, template split,
>
Reviewed-by: Bruce Cherniak
> On Jul 26, 2017, at 5:27 PM, George Kyriazis
> wrote:
>
> The shader that is used to copy vertex data out of the vs/gs shaders to
> the user-specified buffer (streamout or SO shader) was not using the
> correct offsets.
>
> Adjust the offsets that are used just
Reviewed-by: Bruce Cherniak
> On Jul 26, 2017, at 4:38 PM, Tim Rowley wrote:
>
> gcc prior to 4.9 didn't implement , causing a startup crash
> in the swr knob parameter reading code.
>
> CC:
> ---
> .../swr/rasterizer/codegen/templates/gen_knobs.cpp | 21 +
> 1 file chang
> On Jul 24, 2017, at 10:22 AM, Roland Scheidegger wrote:
>
> Am 24.07.2017 um 15:26 schrieb Jose Fonseca:
>> In particular:
>>
>> 1) For buffers the box expresses bytes, not pixels.
> This shouldn't be an issue, since buffers are required to have a 1-byte
> format (usually R8_UINT, but R8_UNOR
Reviewed-by: Bruce Cherniak
> On Jul 21, 2017, at 2:17 PM, Tim Rowley wrote:
>
> Linux-specific gettid() syscall shouldn't be used in portable code.
> Fix does assume a 1:1 thread:LWP architecture, but works for our
> current target platforms and can be revisited later if needed.
>
> Fixes unr
Reviewed-by: Bruce Cherniak
> On Jul 21, 2017, at 11:46 AM, Tim Rowley wrote:
>
> Linux-specific gettid() syscall shouldn't be used in portable code.
> Fix does assume a 1:1 thread:LWP architecture, but works for our
> current target platforms and can be revisited later if needed.
>
> Fixes u
Reviewed-by: Bruce Cherniak
> On Jul 20, 2017, at 5:09 PM, Tim Rowley wrote:
>
> Tested with clang-4.0 and gcc-6.3.
> ---
> .../swr/rasterizer/common/simdlib_512_avx512.inl | 43 +-
> .../swr/rasterizer/common/simdlib_types.hpp| 2 +-
> 2 files changed, 35 insertio
Reviewed-by: Bruce Cherniak
> On Jul 20, 2017, at 5:09 PM, Tim Rowley wrote:
>
> Source/destination will not be AVX512 aligned, use the
> unaligned load/store intrinsics.
> ---
> .../drivers/swr/rasterizer/common/simdlib_128_avx512.inl | 10 +-
> .../drivers/swr/rasterizer/common/
Reviewed-by: Bruce Cherniak
> On Jul 20, 2017, at 5:09 PM, Tim Rowley wrote:
>
> Prevents unalignment crashes with avx512 code on gcc/clang.
> ---
> src/gallium/drivers/swr/rasterizer/core/tilemgr.cpp | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/dr
Reviewed-by: Bruce Cherniak
> On Jul 14, 2017, at 3:01 PM, Tim Rowley wrote:
>
> Fixes performance regression from f50aa21456d - was forcing internal
> code generation to target AVX (no gather, etc).
> ---
> src/gallium/drivers/swr/swr_screen.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 de
Reviewed-by: Bruce Cherniak
> On Jul 12, 2017, at 10:38 AM, Tim Rowley wrote:
>
> Highlights are read-only render targets and simd16 fixes.
>
> Tim Rowley (6):
> swr/rast: Support render target mask instead of render target count
> swr/rast: Add support for read-only render targets
> swr/r
Reviewed-by: Bruce Cherniak
> On Jul 11, 2017, at 9:52 AM, Tim Rowley wrote:
>
> From: George Kyriazis
>
> Needed to expose SwrGetInterface
> ---
> src/gallium/drivers/swr/rasterizer/common/os.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/swr/
Reviewed-by: Bruce Cherniak
> On Jul 7, 2017, at 4:25 PM, Tim Rowley wrote:
>
> Use the SWR rasterizer API through the table returned from
> SwrGetInterface rather than referencing the functions directly.
> This will allow us to move to a model of having the driver dynamically
> load the appro
Reviewed-by: Bruce Cherniak
> On Jul 6, 2017, at 1:55 PM, Tim Rowley wrote:
>
> Cacheline alignment of SWR_STATS to prevent sharing of cachelines
> between threads (performance).
>
> Gets rid of gcc-7.1 warning about using c++17's over-aligned new
> feature.
>
> Cc: mesa-sta...@lists.freedesk
Reviewed-by: Bruce Cherniak
> On Jul 6, 2017, at 11:26 AM, Tim Rowley wrote:
>
> ---
> src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx.inl | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx.inl
> b/s
Reviewed-by: Bruce Cherniak
> On Jul 6, 2017, at 11:26 AM, Tim Rowley wrote:
>
> ---
> src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 2 --
> src/gallium/drivers/swr/rasterizer/jitter/streamout_jit.cpp | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/src/gallium/drivers/
Reviewed-by: Bruce Cherniak
> On Jul 6, 2017, at 11:26 AM, Tim Rowley wrote:
>
> Define these in terms of setzero for ancient gcc versions which don't
> have the undefined intrinsics.
>
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> src/gallium/drivers/swr/rasterizer/common/os.h | 6 ++
>
On Jul 4, 2017, at 9:40 AM, Jose Fonseca
mailto:jfons...@vmware.com>> wrote:
On 29/06/17 11:02, Michel Dänzer wrote:
On 29/06/17 01:54 AM, Cherniak, Bruce wrote:
On Jun 26, 2017, at 2:10 PM, Marek Olšák
mailto:mar...@gmail.com>> wrote:
In my opinion, dumping resources isn'
Reviewed-by: Bruce Cherniak
> On Jun 30, 2017, at 11:52 AM, Tim Rowley wrote:
>
> Tag pStat field in swr_draw_context structure so gen_llvm_types.py
> can deal with the actual structure type instead of using void.
>
> Code cleanup, no functional change.
> ---
> src/gallium/drivers/swr/swr_con
Reviewed-by: Bruce Cherniak
> On Jun 29, 2017, at 10:07 AM, Tim Rowley wrote:
>
> Reduces the memory footprint of the frontend processing by packing
> vertices.
> ---
> src/gallium/drivers/swr/swr_draw.cpp | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/galliu
Reviewed-by: Bruce Cherniak
> On Jun 27, 2017, at 1:09 PM, Tim Rowley wrote:
>
> Highlights include splitting the heavily templated files into multiple
> chunks to speed compile (2x for a large machine), and switching the
> simd intrinsic usage from a macro-based header to a more c++ feeling
>
this a valid fix? It prevents a crash that happens on occasion
while running
GALLIUM_TRACE.
I too would be interested in learning how to replay traces. Would be very
handy.
Thanks,
Bruce
> Marek
>
> On Mon, Jun 26, 2017 at 6:28 PM, Cherniak, Bruce
> wrote:
>> Back in Feb
Back in February, I submitted a patch for review to address an a crash in
GALLIUM_TRACE.
It never got a review, and I forgot to follow up on it. Is this a correct fix
and useful to anyone
else?
Thanks,
Bruce
From patchwork Wed Feb 1 20:20:38 2017
Content-Type: text/plain; charset="utf-
1 - 100 of 215 matches
Mail list logo
