Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-20 Thread Simona Vetter
On Fri, Dec 20, 2024 at 09:24:59AM -0500, Marek Olšák wrote: > > > > * Modifiers must uniquely encode buffer layout. In other words, a buffer > > must > > * match only a single modifier. > > > > That sentence is misleading and impossible to meet. Specifications are > sometimes changed to reflect

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-20 Thread Simona Vetter
On Thu, Dec 19, 2024 at 05:09:33PM +0100, Michel Dänzer wrote: > On 2024-12-19 10:02, Daniel Stone wrote: > > > > How this would be used in practice is also way too underdocumented. We > > need to document that exact-round-up 64b is more restrictive than > > any-multiple-of 64b is more restrictive

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-20 Thread Marek Olšák
> > * Modifiers must uniquely encode buffer layout. In other words, a buffer > must > * match only a single modifier. > That sentence is misleading and impossible to meet. Specifications are sometimes changed to reflect the overwhelming reality. Multiple modifiers can represent identical layouts

AV1 hardware decoding problems with latest Mesa 25.0.0-devel

2024-12-20 Thread Chris Rankin
Hi, I've just raised this issue in GitLab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12337 I thought this video was 4:2:0 AV1, and it used to play OK with both VA-API and VDPAU hardware decoding. First bad commit is: in/HEAD) Author: David Rosca Date: Mon Dec 16 17:26:09 2024 +0100

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-20 Thread Brian Starkey
This is getting long, so tl;dr: - Pitch alignment *by itself* is manageable. - Adding constraints in modifiers quickly leads to combinatorial explosion. - drm_fourcc.h explicitly says "it's incorrect to encode pitch alignment in a modifier", for all the reasons Daniel raised. That need