Re: Replacing NIR with SPIR-V?

2022-01-20 Thread Jason Ekstrand
On Thu, Jan 20, 2022 at 5:49 PM Abel Bernabeu < abel.berna...@esperantotech.com> wrote: > In principle, all the properties you highlight in your blog > as key points > of NIR also apply to SPIR-V. > First off, that blog post is truly anc

Re: Replacing NIR with SPIR-V?

2022-01-20 Thread Abel Bernabeu
In principle, all the properties you highlight in your blog as key points of NIR also apply to SPIR-V. I was curious to know where in the details that I miss, NIR starts shining as a more suitable IR than SPIR-V for the task of communicati

[PATCH v3 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-20 Thread Robert Beckett
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. v3: fix typos and less emphasis v2: Fixed suggestions on formatting

Re: [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-20 Thread Ramalingam C
On 2022-01-18 at 17:50:37 +, Robert Beckett wrote: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. >

Re: NIR: is_used_once breaks multi-pass rendering

2022-01-20 Thread Connor Abbott
There are precise rules for when calculations in GL must return the same result, which are laid out in Appendix A ("Invariance"). The relevant rule here: "Rule 4 The same vertex or fragment shader will produce the same result when run multiple times with the same input. The wording ‘the same shade

NIR: is_used_once breaks multi-pass rendering

2022-01-20 Thread Marek Olšák
Hi, "is_used_once" within an inexact transformation in nir_opt_algebraic can lead to geometry differences with multi-pass rendering, causing incorrect output. Here's an example to proof this: Let's assume there is a pass that writes out some intermediate value from the position calculation as a v