Re: [Mesa-dev] Workflow Proposal

2021-10-07 Thread Marek Olšák
Despite all the time it takes to add the tags and force-push, I have no objection to doing that. It captures per-commit reviews well. Marek On Thu, Oct 7, 2021 at 1:17 PM Eero Tamminen wrote: > Hi, > > On 7.10.2021 19.51, Daniel Stone wrote: > > On Thu, 7 Oct 2021 at 09:38, Eero Tamminen > wro

Re: [Mesa-dev] Workflow Proposal

2021-10-07 Thread Eero Tamminen
Hi, On 7.10.2021 19.51, Daniel Stone wrote: On Thu, 7 Oct 2021 at 09:38, Eero Tamminen wrote: This sounds horrible from the point of view of trying to track down somebody who knows about what's & why's of some old commit that is later on found to cause issues... But why would your first poin

Re: [Mesa-dev] Workflow Proposal

2021-10-07 Thread Daniel Stone
On Thu, 7 Oct 2021 at 09:38, Eero Tamminen wrote: > This sounds horrible from the point of view of trying to track down > somebody who knows about what's & why's of some old commit that is later > on found to cause issues... But why would your first point of call not be to go back to the review d

Re: [Mesa-dev] Workflow Proposal

2021-10-07 Thread Emma Anholt
" On Thu, Oct 7, 2021 at 1:38 AM Eero Tamminen wrote: > > Hi, > > On 6.10.2021 23.00, Jordan Justen wrote: > > Bas Nieuwenhuizen writes: > >> On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen > >> wrote: > >>> I guess I missed where it was suggested that Marge should remove > >>> Reviewed-by tags.

Re: [Mesa-dev] Workflow Proposal

2021-10-07 Thread Eero Tamminen
Hi, On 6.10.2021 23.00, Jordan Justen wrote: Bas Nieuwenhuizen writes: On Wed, Oct 6, 2021 at 8:49 PM Jordan Justen wrote: I guess I missed where it was suggested that Marge should remove Reviewed-by tags. I don't think Marge should ever remove something from the commit message. AFAIU this