Re: [Mesa-dev] [ANNOUNCE] mesa 20.0.3

2020-04-02 Thread Eric Engestrom
Sorry about that; looks like it was missed by my testing. I need to go to sleep now, but I'll do an emergency release tomorrow morning with just this revert. On Thursday, 2020-04-02 11:25:17 +0200, Samuel Pitoiset wrote: > Good catch! > > Yes, please revert it asap, it breaks a bunch of things

Re: [Mesa-dev] nir: find_msb vs clz

2020-04-02 Thread Ian Romanick
On 4/1/20 11:39 AM, Erik Faye-Lund wrote: > While working on the NIR to DXIL conversion code for D3D12, I've > noticed that we're not exactly doing the best we could here. > > First some background: > > NIR currently has a few instructions that does kinda the same: > > 1. nir_op_ufind_msb: Finds

Re: [Mesa-dev] nir: find_msb vs clz

2020-04-02 Thread Jason Ekstrand
On Thu, Apr 2, 2020 at 7:23 AM Daniel Schürmann wrote: > > W.r.t AMD hardware, it seems to map quite exactly the DX behavior, > so given that I would, of course favor a NIR instruction which maps that :) I'm a bit surprised. I thought AMD HW usually had 25 opcodes whenever 3 were needed just so

Re: [Mesa-dev] nir: find_msb vs clz

2020-04-02 Thread Daniel Schürmann
W.r.t AMD hardware, it seems to map quite exactly the DX behavior, so given that I would, of course favor a NIR instruction which maps that :) Small overview (scalar and vector): S_FLBIT_I32_{B32,B64} - D = the number of zeros before the first one starting from the MSB.Returns -1 if none. S_FLBI

Re: [Mesa-dev] [ANNOUNCE] mesa 20.0.3

2020-04-02 Thread Samuel Pitoiset
Good catch! Yes, please revert it asap, it breaks a bunch of things ... :( On 4/2/20 11:11 AM, Danylo Piliaiev wrote: "spirv: Implement OpCopyObject and OpCopyLogical as blind copies" was reverted yesterday due to the failures in several dEQP-VK tests, see: https://gitlab.freedesktop.org/me

Re: [Mesa-dev] [ANNOUNCE] mesa 20.0.3

2020-04-02 Thread Danylo Piliaiev
"spirv: Implement OpCopyObject and OpCopyLogical as blind copies" was reverted yesterday due to the failures in several dEQP-VK tests, see: https://gitlab.freedesktop.org/mesa/mesa/-/commit/68f325b256d96dca923f6c7d84bc6faf43911245  https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4375