[Mesa-dev] [Bug 111019] radv doesn't handle variable descriptor count properly

2019-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111019 Bas Nieuwenhuizen changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] softpipe: Don't draw when rasterizer_discard is set

2019-07-29 Thread Gert Wollny
Am Montag, den 29.07.2019, 11:39 -0400 schrieb Ilia Mirkin: > Hi Gert, > > I just saw you pushed commit > > https://cgit.freedesktop.org/mesa/mesa/commit/?id=4ee638cd7826e8a4bed76f51c7b73395a2fcdb > > which just returns if rasterizer_discard is set, similar to if the > render condition doesn't m

[Mesa-dev] [Bug 111019] radv doesn't handle variable descriptor count properly

2019-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111019 --- Comment #4 from Józef Kucia --- It seems that layout->buffer_count is incorrectly used for VK_DESCRIPTOR_BINDING_VARIABLE_DESCRIPTOR_COUNT_BIT_EXT. layout->buffer_count is based on the upper limit taken from descriptor set layout. -- You a

Re: [Mesa-dev] softpipe: Don't draw when rasterizer_discard is set

2019-07-29 Thread Ilia Mirkin
Hi Gert, I just saw you pushed commit https://cgit.freedesktop.org/mesa/mesa/commit/?id=4ee638cd7826e8a4bed76f51c7b73395a2fcdb which just returns if rasterizer_discard is set, similar to if the render condition doesn't match. However this breaks TF and any image/etc writes in vertex stages when

[Mesa-dev] [Bug 111019] radv doesn't handle variable descriptor count properly

2019-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111019 Józef Kucia changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Mesa-dev] [Bug 111019] radv doesn't handle variable descriptor count properly

2019-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111019 --- Comment #3 from Józef Kucia --- Created attachment 144908 --> https://bugs.freedesktop.org/attachment.cgi?id=144908&action=edit Minimal reproducer 2 With the fix it works for samplers now. Unfortunately, it still doesn't work for other de

[Mesa-dev] [Bug 107767] Segfault with standalone compiler and --dump-builder

2019-07-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107767 Sergii Romantsov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] radv/gfx10: do not use the fast depth or stencil clear bytes path

2019-07-29 Thread Bas Nieuwenhuizen
r-b On Mon, Jul 29, 2019 at 2:35 PM Samuel Pitoiset wrote: > > > On 7/29/19 2:30 PM, Bas Nieuwenhuizen wrote: > > On Mon, Jul 29, 2019 at 2:20 PM Samuel Pitoiset > > wrote: > >> > >> On 7/29/19 2:15 PM, Bas Nieuwenhuizen wrote: > >>> On Mon, Jul 29, 2019 at 2:11 PM Samuel Pitoiset > >>> wrote:

Re: [Mesa-dev] [PATCH] radv/gfx10: do not use the fast depth or stencil clear bytes path

2019-07-29 Thread Samuel Pitoiset
On 7/29/19 2:30 PM, Bas Nieuwenhuizen wrote: On Mon, Jul 29, 2019 at 2:20 PM Samuel Pitoiset wrote: On 7/29/19 2:15 PM, Bas Nieuwenhuizen wrote: On Mon, Jul 29, 2019 at 2:11 PM Samuel Pitoiset wrote: The HTILE masks seem to be different and so we need to rework that path. Just disabled for

Re: [Mesa-dev] [PATCH] radv/gfx10: do not use the fast depth or stencil clear bytes path

2019-07-29 Thread Bas Nieuwenhuizen
On Mon, Jul 29, 2019 at 2:20 PM Samuel Pitoiset wrote: > > > On 7/29/19 2:15 PM, Bas Nieuwenhuizen wrote: > > On Mon, Jul 29, 2019 at 2:11 PM Samuel Pitoiset > > wrote: > >> The HTILE masks seem to be different and so we need to rework that > >> path. Just disabled for now and implement later. >

Re: [Mesa-dev] [PATCH] radv/gfx10: do not use the fast depth or stencil clear bytes path

2019-07-29 Thread Samuel Pitoiset
On 7/29/19 2:15 PM, Bas Nieuwenhuizen wrote: On Mon, Jul 29, 2019 at 2:11 PM Samuel Pitoiset wrote: The HTILE masks seem to be different and so we need to rework that path. Just disabled for now and implement later. The HTILE masks are not different per amdvlk? Can you at least rework the co

Re: [Mesa-dev] [PATCH] radv/gfx10: do not use the fast depth or stencil clear bytes path

2019-07-29 Thread Bas Nieuwenhuizen
On Mon, Jul 29, 2019 at 2:11 PM Samuel Pitoiset wrote: > > The HTILE masks seem to be different and so we need to rework that > path. Just disabled for now and implement later. The HTILE masks are not different per amdvlk? Can you at least rework the commit message to reflect that? > > This fixe

[Mesa-dev] [PATCH] radv/gfx10: do not use the fast depth or stencil clear bytes path

2019-07-29 Thread Samuel Pitoiset
The HTILE masks seem to be different and so we need to rework that path. Just disabled for now and implement later. This fixes rendering issues with vkmark and Wreckfest at least. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 5 +++-- 1 file changed, 3 insertions(+), 2 d

Re: [Mesa-dev] [PATCH] radv: implement VK_EXT_index_type_uint8

2019-07-29 Thread Bas Nieuwenhuizen
r-b On Mon, Jul 29, 2019 at 10:47 AM Samuel Pitoiset wrote: > > Natively supported on VI+. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 60 +++ > src/amd/vulkan/radv_device.c | 6 > src/amd/vulkan/radv_extensions.py | 1 +

Re: [Mesa-dev] [PATCH] ac: do not crash when the buffer data format is invalid

2019-07-29 Thread Bas Nieuwenhuizen
r-b On Mon, Jul 29, 2019 at 12:00 PM Samuel Pitoiset wrote: > > This might happen when a pipeline doesn't define the vertex input > state, so the buffer data format is 0 (aka INVALID). > > This fixes crashes when compiling some shaders on GFX10. > > Signed-off-by: Samuel Pitoiset > --- > src/am

[Mesa-dev] [PATCH] ac: do not crash when the buffer data format is invalid

2019-07-29 Thread Samuel Pitoiset
This might happen when a pipeline doesn't define the vertex input state, so the buffer data format is 0 (aka INVALID). This fixes crashes when compiling some shaders on GFX10. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/s

[Mesa-dev] [PATCH] radv: implement VK_EXT_index_type_uint8

2019-07-29 Thread Samuel Pitoiset
Natively supported on VI+. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 60 +++ src/amd/vulkan/radv_device.c | 6 src/amd/vulkan/radv_extensions.py | 1 + 3 files changed, 61 insertions(+), 6 deletions(-) diff --git a/src/amd/vul