[Mesa-dev] [Bug 110847] occlusion-query.c:190:45: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror, -Wformat]

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110847 --- Comment #2 from Mark Janes --- Oops, I guess it needs an include also: https://gitlab.freedesktop.org/majanes/mesa/commit/97e056faf38ff65274dd91e2a1d29ae7859c1c51 -- You are receiving this mail because: You are the QA Contact for the bu

[Mesa-dev] [Bug 110847] occlusion-query.c:190:45: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror, -Wformat]

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110847 Mark Janes changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@lists

[Mesa-dev] [Bug 110847] occlusion-query.c:190:45: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror, -Wformat]

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110847 Bug ID: 110847 Summary: occlusion-query.c:190:45: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]

Re: [Mesa-dev] [PATCH 6/8] radv: handle sample locations during automatic layout transitions

2019-06-05 Thread Bas Nieuwenhuizen
On Wed, Jun 5, 2019 at 12:04 PM Samuel Pitoiset wrote: > > > On 6/5/19 2:51 AM, Bas Nieuwenhuizen wrote: > > On Thu, May 30, 2019 at 4:02 PM Samuel Pitoiset > > wrote: > >> From the Vulkan spec 1.1.109: > >> > >> "Some implementations may need to evaluate depth image values > >> while p

Re: [Mesa-dev] [PATCH] radv: set the subpass before any initial subpass transitions

2019-06-05 Thread Bas Nieuwenhuizen
r-b On Mon, Jun 3, 2019 at 3:45 PM Bas Nieuwenhuizen wrote: > > While it is not wrong, I don't think this is the right fix, as the > current_layout is not necessarily accurate. > > Will try to get something better. > > On Thu, May 30, 2019 at 3:10 PM Samuel Pitoiset > wrote: > > > > This might f

[Mesa-dev] [Bug 110811] radv: Assassin's Creed Unity glitches when compiled with recent LLVM 9 (DXVK)

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110811 --- Comment #7 from Yury Zhuravlev --- I have the same issue. Also, before was GPU just hung, now it's working stable but with artifacts. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [ANNOUNCE] mesa 19.0.6

2019-06-05 Thread Dylan Baker
Hi list, Sorry for the brief message, but I'm on a time crunch. Things are chugging along with the 19.0.6 release. This was planned to be the last release of the 19.0 series, but I'm planning to have another one in two weeks due to a longer RC cycle for 19.1. Dylan Shortlog Alok Hota (

[Mesa-dev] [PATCH 6/6] panfrost/midgard: Disambiguate register mode

2019-06-05 Thread Alyssa Rosenzweig
We postfix instructions by their size if a destination override is in place (a la AT&T assembly), disambiguating instruction sizes. Previously, "16-bit instruction, 16-bit dest, 16-bit sources" disassembled identically to "32-bit instruction, 16-bit dest, 16-bit sources", which is semantically dist

[Mesa-dev] [PATCH 5/6] panfrost/midgard: Expose vec8/vec16 modes

2019-06-05 Thread Alyssa Rosenzweig
Midgard ALUs can operate in one of four modes: vec2 64-bit, vec4 32-bit, vec8 16-bit, or vec16 8-bit. Our compiler (and indeed, any OpenGL ES shader) only uses 32-bit (and eventually vec4 16-bit) modes in normal circumstances. Nevertheless, the other modes do exist and are easily accessible through

[Mesa-dev] [PATCH 1/6] panfrost/midgard: Add rounding mode specific opcodes

2019-06-05 Thread Alyssa Rosenzweig
This adds a set of opcodes for performing moves and type conversions with respect to particular rounding modes, required for OpenCL. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard.h| 27 ++- .../panfrost/midgard/midgard_compile.c| 18 +++

[Mesa-dev] [PATCH 4/6] panfrost/midgard: Add shifting int modifiers

2019-06-05 Thread Alyssa Rosenzweig
As a source modifier, shift allows shifting a value left by the bit size, useful in conjunction with a greater register mode, for instance to implement `upsample`. As a concrete example, the following OpenCL: ushort hr0 = /* ... */, uint r1 = /* ... */; uint r2 = (convert_uint(hr0) << 16) ^

[Mesa-dev] [PATCH 0/6] panfrost/midgard: Improve disassembler per OpenCL

2019-06-05 Thread Alyssa Rosenzweig
This series is the culmination of quite a bit of poking at OpenCL kernels, exposing a bunch of details about integer and reduced-precision modes that don't normally come up in OpenGL (but come up in enough truly bizarre corners, i.e. blend shaders, that without this knowledge, debugging can be herc

[Mesa-dev] [PATCH 3/6] panfrost/midgard: Add integer outmods

2019-06-05 Thread Alyssa Rosenzweig
For floats, output modifiers determine clamping behaviour. For integers, they determine wrapping/saturation behaviour (or shifting -- see next commit). These are very different; they are conceptually two unrelated enums union'ed together; the distinction is responsible for many-a-bug. While clampin

[Mesa-dev] [PATCH 2/6] panfrost/midgard: Note floating compares type convert

2019-06-05 Thread Alyssa Rosenzweig
OP_TYPE_CONVERTS denotes an opcode that returns a different type than is source (going from int-domain to float-domain or vice versa), named after the f2i/i2f family of opcodes it covers. We care because source mods are determined by the source type (i/f) but output modifiers are determined by the

[Mesa-dev] [PATCH] panfrost/midgard: Verify SSA claims when pipelining

2019-06-05 Thread Alyssa Rosenzweig
The pipeline register creation algorithm is only valid for SSA indices; NIR registers and such cannot be pipelined without more complex analysis. However, there are the ocassional class of "liars" -- indices that claim to be SSA but are not. This occurs in the blend shader prologue, for example. De

[Mesa-dev] [PATCH] panfrost/midgard: Don't assign var locations ourselves

2019-06-05 Thread Alyssa Rosenzweig
This piece of code was cargo-culted from the ir3 standalone compiler and made sense when we were a standalone compiler ourselves. Unfortunately, for the online compiler, mesa/st *already handles this for us* and if we duplicate it here, we're duplicating it *incorrectly*. So just delete these lines

Re: [Mesa-dev] [PATCH 0/2] panfrost/midgard: Fix regressions

2019-06-05 Thread Alyssa Rosenzweig
Pushed. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radeonsi: Don't force dcc disable for loads

2019-06-05 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jun 5, 2019 at 6:49 AM Connor Abbott wrote: > When e9d935ed0e2 added force_dcc_off(), we forced it off for any > preloaded image descriptor which had stores associated with them, since > the same preloaded descriptors were used for loads and stores. Howev

[Mesa-dev] [Bug 110846] VA-API st doesn't expose NOISE_REDUCTION/SHARPNESS, while they exposed via VDPAU st

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110846 Bug ID: 110846 Summary: VA-API st doesn't expose NOISE_REDUCTION/SHARPNESS, while they exposed via VDPAU st Product: Mesa Version: git Hardware: x86 (IA32)

[Mesa-dev] [ANNOUNCE] mesa 19.1.0-rc5

2019-06-05 Thread Juan A. Suarez Romero
Hello, list. The fifth release candidate for Mesa 19.1.0 is now available. We have extended the release candidates because there are two bugs blocking the final release: #110302 - [bisected][regression] piglit egl-create-pbuffer-surface and egl-gl-colorspace regressions #110357 - [REGRESSION]

Re: [Mesa-dev] [Mesa-stable] [PATCH 6/8] egl/dri: flesh out and use dri2_create_drawable()

2019-06-05 Thread Emil Velikov
On Mon, 3 Jun 2019 at 23:52, Marek Olšák wrote: > > Would you please review this fixed version: > https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master&id=40e4702ef815410f74130f349e2b40cc0524e422 > > It trivially solves the GBM crash by checking that gbm_surf != NULL before > using it. > Mak

[Mesa-dev] [PATCH 1/2] mapi: add static_date offset to MaxShaderCompilerThreadsKHR

2019-06-05 Thread Emil Velikov
From: Emil Velikov As elaborated in the next patch, there is some hidden ABI that effectively require most entrypoints to be listed in the file. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110302 Cc: Marek Olšák Fixes: c5c38e831ee ("mesa: implement ARB/KHR_parallel_shader_compile") S

[Mesa-dev] [PATCH 2/2] mapi: correctly handle the full offset table

2019-06-05 Thread Emil Velikov
From: Emil Velikov Earlier commit converted ES1 and ES2 to a new, much simpler, dispatch generator. At the same time, GL/glapi and the driver side are still using the old code. There is a hidden ABI between GL*.so and glapi.so, former referencing entry-points by offset in the _glapi_table. Hence

[Mesa-dev] [PATCH 2/2] panfrost/midgard: Always break up fragment writeout

2019-06-05 Thread Alyssa Rosenzweig
In a fragment shader, r0 is written out with a special branch sequence. r0 is not a real register here, but essentially a pipeline register -- as such, it needs to be written out in full and on time, with hanging dependencies in the bundle. Otherwise, we break up the bundle, which costs an extra AL

[Mesa-dev] [PATCH 0/2] panfrost/midgard: Fix regressions

2019-06-05 Thread Alyssa Rosenzweig
The RA rewrite / schedler refactor series changed huge portions of the Midgard codebase. Inevitably, that introduced a few hundred regressions or so on dEQP. Fix them before anyone noticed. Nothing to see here, folks. Alyssa Rosenzweig (2): panfrost/midgard: Fix cubemap regression panfrost/mi

[Mesa-dev] [PATCH 1/2] panfrost/midgard: Fix cubemap regression

2019-06-05 Thread Alyssa Rosenzweig
Fixes: 2d9802233 ("panfrost/midgard: Extend RA to non-vec4 sources") Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_ra.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_ra.c b/src/gal

Re: [Mesa-dev] [PATCH 0/3] panfrost/midgard: Integer division

2019-06-05 Thread Ryan Houdek
Patch series Reviewed-By: Ryan Houdek On Wed, Jun 5, 2019 at 8:41 AM Alyssa Rosenzweig < alyssa.rosenzw...@collabora.com> wrote: > This series adds some new ALU ops from OpenCL (cherry-picked from my > downstream tree -- the full set of OpenCL-related ISA additions should > be coming soon). In p

[Mesa-dev] [Bug 110763] Rendering problem and fps decrease

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110763 Michel Dänzer changed: What|Removed |Added Version|unspecified |19.0 QA Contact|xorg-t...@lists

[Mesa-dev] [PATCH 2/3] panfrost/midgard: Fix 1-arg ALU memory corruption

2019-06-05 Thread Alyssa Rosenzweig
Certain ops that only take one argument have an imaginary "zero" constant for their second argument. For instance, conversions: i2f [dest], [source], #0 Memory corruption meant that #0 was instead random noise. For some ops, that doesn't matter (manifested as abnormally large code size and poo

[Mesa-dev] [PATCH 1/3] panfrost/midgard: Add a bunch of new ALU ops

2019-06-05 Thread Alyssa Rosenzweig
These ops are used to accelerate various functions exposed in OpenCL. This commit only includes the routine additions to the table. They are not wired through the compiler; rather, they are just here to keep a reference for the disassembler. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drive

[Mesa-dev] [PATCH 3/3] panfrost/midgard: Lower integer division

2019-06-05 Thread Alyssa Rosenzweig
We use the shared nir_lower_idiv pass to lower integer division, fixing 144 dEQP tests. This pass was not applied in the past due to breakage from iabs fixed earlier in the series. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/ci/expected-failures.txt | 144 -- .../pa

[Mesa-dev] [PATCH 0/3] panfrost/midgard: Integer division

2019-06-05 Thread Alyssa Rosenzweig
This series adds some new ALU ops from OpenCL (cherry-picked from my downstream tree -- the full set of OpenCL-related ISA additions should be coming soon). In particular, it identifies iabs as iabsdiff/#0, allowing an iabs bug to be fixed. From there, all prereqs are in place to enable integer div

Re: [Mesa-dev] [PATCH] ac/nir: Remove stale TODO

2019-06-05 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 6/5/19 5:09 PM, Connor Abbott wrote: While we're here, copy the comment explaining this from radeonsi. --- src/amd/common/ac_nir_to_llvm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/comm

[Mesa-dev] [PATCH] ac/nir: Remove stale TODO

2019-06-05 Thread Connor Abbott
While we're here, copy the comment explaining this from radeonsi. --- src/amd/common/ac_nir_to_llvm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 833b1e54abc..11de22a8cbd 100644 --- a/src/amd/com

Re: [Mesa-dev] [PATCH] Revert "radv: fix color conversions for normalized uint/sint formats"

2019-06-05 Thread Bas Nieuwenhuizen
r-b On Wed, Jun 5, 2019 at 12:02 PM Samuel Pitoiset wrote: > > For some reasons, this actually introduced rendering issues with > Far Cry 3 (and probably Far Cry 4). I'm reverting it for now > until I figure out the right fix. > > See the following link for reference: > https://github.com/ValveSo

[Mesa-dev] [PATCH] radeonsi: Don't force dcc disable for loads

2019-06-05 Thread Connor Abbott
When e9d935ed0e2 added force_dcc_off(), we forced it off for any preloaded image descriptor which had stores associated with them, since the same preloaded descriptors were used for loads and stores. However, when the preloading was removed in 16be87c9042, the existing logic was kept despite it not

Re: [Mesa-dev] [PATCH 6/8] radv: handle sample locations during automatic layout transitions

2019-06-05 Thread Samuel Pitoiset
On 6/5/19 2:51 AM, Bas Nieuwenhuizen wrote: On Thu, May 30, 2019 at 4:02 PM Samuel Pitoiset wrote: From the Vulkan spec 1.1.109: "Some implementations may need to evaluate depth image values while performing image layout transitions. To accommodate this, instances of the VkSamp

Re: [Mesa-dev] [PATCH 1/8] radv: allow to save/restore sample locations during meta operations

2019-06-05 Thread Samuel Pitoiset
On 6/5/19 2:37 AM, Bas Nieuwenhuizen wrote: On Thu, May 30, 2019 at 4:02 PM Samuel Pitoiset wrote: This will be used for the depth decompress pass that might need to emit variable sample locations during layout transitions. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c | 20

[Mesa-dev] [PATCH] Revert "radv: fix color conversions for normalized uint/sint formats"

2019-06-05 Thread Samuel Pitoiset
For some reasons, this actually introduced rendering issues with Far Cry 3 (and probably Far Cry 4). I'm reverting it for now until I figure out the right fix. See the following link for reference: https://github.com/ValveSoftware/Proton/issues/727#issuecomment-498638025 Cc: 19.0 19.1 This rever

[Mesa-dev] [Bug 110811] radv: Assassin's Creed Unity glitches when compiled with recent LLVM 9 (DXVK)

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110811 --- Comment #6 from Andrew Sheldon --- (In reply to Samuel Pitoiset from comment #5) > Does https://reviews.llvm.org/D62614 help? No change, unfortunately. -- You are receiving this mail because: You are the QA Contact for the bug. You are th

[Mesa-dev] [Bug 110815] Segfault vkCreateDescriptorPool in The-Forge on RADV

2019-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110815 --- Comment #7 from Alex Fuller --- Hello again, I didn't realise it was so simple to build debug versions of Mesa/RADV so I went ahead and did this. I've found the bug: https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/amd/vulkan/radv_

Re: [Mesa-dev] [PATCH] panfrost: bifrost: Fix format string in disassembler

2019-06-05 Thread Ryan Houdek
Awesome, thanks for the fix. Reviewed-By: Ryan Houdek On Tue, Jun 4, 2019 at 11:55 PM Tomeu Vizoso wrote: > The compiler configuration was hardened to fail on format warnings and > things stopped building. > > Fixes: c9c1e2610647 ("mesa: prevent common string formatting security > issues") > Si

[Mesa-dev] [PATCH] panfrost: Don't flip scanout

2019-06-05 Thread Alyssa Rosenzweig
The mesa/st flips the viewport, so we respect that rather than trying to flip the framebuffer itself and ignoring the viewport and using a messy heuristic. However, this brings an underlying disagreement about the interpretation of winding order to light. The blob uses a different strategy than Me