Re: [Mesa-dev] [PATCH] radeon: Fix width align for hevc encode

2019-04-18 Thread Lei Zhou
Hi Boyuan, Thanks for your suggestions. I have split this patch to 2 patches, and resent to mesa-dev mailing list. > Hi Lei, > > You are right. The width alignment for HEVC encoding should be 64. This is > actually a hardware requirement that we missed here. Thanks for catching it. > > Just

[Mesa-dev] [Bug 110468] using swrAVX renders incorrectly at particular resolutions

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110468 ayan...@outlook.com changed: What|Removed |Added Summary|using swrAVX renders|using swrAVX renders

Re: [Mesa-dev] [PATCH 1/4] radeonsi/gfx9: set that window_rectangles always roll the context

2019-04-18 Thread Marek Olšák
Please disregard this series. Marek On Wed, Apr 17, 2019 at 7:39 PM Marek Olšák wrote: > From: Marek Olšák > > Cc: 19.0 > --- > src/gallium/drivers/radeonsi/si_state.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state.h > b/src/g

[Mesa-dev] [PATCH 3/3] radeonsi: remove dirty slot masks from scissor and viewport states

2019-04-18 Thread Marek Olšák
From: Marek Olšák All registers in the array need to be updated if any of them is changed. Only apps writing gl_ViewportIndex were affected by this bug. --- src/gallium/drivers/radeonsi/si_blit.c| 2 +- src/gallium/drivers/radeonsi/si_gfx_cs.c | 3 - src/gallium/drivers/radeons

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_PREFER_COMPUTE_BLIT_FOR_MULTIMEDIA

2019-04-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_screen.c | 1 + src/gallium/docs/source/screen.rst| 2 ++ src/gallium/drivers/radeonsi/si_get.c | 1 + src/gallium/include/pipe/p_defines.h | 1 + 4 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/util/u_screen.c b/src/g

[Mesa-dev] [PATCH 2/3] radeonsi/gfx9: rework the gfx9 scissor bug workaround (v2)

2019-04-18 Thread Marek Olšák
From: Marek Olšák Needed to track context rolls caused by streamout and ACQUIRE_MEM. ACQUIRE_MEM can occur outside of draw calls. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110355 v2: squashed patches and done more rework Cc: 19.0 --- src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 1/3] radeonsi/gfx9: set that window_rectangles always roll the context

2019-04-18 Thread Marek Olšák
From: Marek Olšák Cc: 19.0 --- src/gallium/drivers/radeonsi/si_state.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.h index 311e1a428ae..119558b8674 100644 --- a/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 2/2] va: use a compute shader for the blit

2019-04-18 Thread Marek Olšák
From: "Jiang, Sonny" Signed-off-by: Sonny Jiang Signed-off-by: Marek Olšák --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/util/u_compute.c | 165 + src/gallium/auxiliary/util/u_compute.h | 45 ++ src/gallium/state_trackers/va/cont

Re: [Mesa-dev] [PATCH] nir/spirv: short-circuit when conditional branch contains end block

2019-04-18 Thread Jason Ekstrand
On Thu, Apr 18, 2019 at 9:13 AM Juan A. Suarez Romero wrote: > On Thu, 2019-03-14 at 11:25 -0500, Jason Ekstrand wrote: > > Looking at this a bit more, I'm not sure that just short-circuiting > actually covers all the cases. Unfortunately, we don't know what all the > cases are because the SPIR-

[Mesa-dev] [PATCH] glsl: Silence may unused parameter warnings in glsl/ir.h

2019-04-18 Thread Ian Romanick
From: Ian Romanick Every file that included glsl/ir.h had a warning like: src/compiler/glsl/ir.h: In member function ‘virtual bool ir_rvalue::is_lvalue(const _mesa_glsl_parse_state*) const’: src/compiler/glsl/ir.h:236:64: warning: unused parameter ‘state’ [-Wunused-parameter] virtual bool

[Mesa-dev] [PATCH v2 1/2] radeon/uvd: fix width alignment for hevc encoding

2019-04-18 Thread Lei Zhou
The width alignment for HEVC encoding should be 64 due to hardware requirement. This will fix conformance_window_flag in SPS. Signed-off-by: Lei Zhou --- src/gallium/drivers/radeon/radeon_uvd_enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r

[Mesa-dev] [PATCH v2 2/2] radeon/vcn: fix width alignment for hevc encoding

2019-04-18 Thread Lei Zhou
The width alignment for HEVC encoding should be 64 due to hardware requirement. This will fix conformance_window_flag in SPS. v2 (Zhang, Boyuan): - add marcos to define width alignment for hevc and h264 Signed-off-by: Lei Zhou --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 4 ++-- src/g

Re: [Mesa-dev] [PATCH] intel/isl: Align clear color buffer to full cacheline

2019-04-18 Thread Nanley Chery
On Thu, Apr 18, 2019 at 08:19:38AM -0700, Kenneth Graunke wrote: > On Wednesday, April 17, 2019 1:31:28 PM PDT Nanley Chery wrote: > > On Wed, Apr 17, 2019 at 11:34:15AM -0700, Rafael Antognolli wrote: > > > On Wed, Apr 17, 2019 at 09:04:09AM -0700, Kenneth Graunke wrote: > > > > On Wednesday, Apri

Re: [Mesa-dev] [PATCH] intel/isl: Align clear color buffer to full cacheline

2019-04-18 Thread Jason Ekstrand
On Wed, Apr 17, 2019 at 3:31 PM Nanley Chery wrote: > On Wed, Apr 17, 2019 at 11:34:15AM -0700, Rafael Antognolli wrote: > > On Wed, Apr 17, 2019 at 09:04:09AM -0700, Kenneth Graunke wrote: > > > On Wednesday, April 17, 2019 7:16:28 AM PDT Topi Pohjolainen wrote: > > > > From: Rafael Antognolli

Re: [Mesa-dev] [PATCH] intel/isl: Align clear color buffer to full cacheline

2019-04-18 Thread Kenneth Graunke
On Wednesday, April 17, 2019 1:31:28 PM PDT Nanley Chery wrote: > On Wed, Apr 17, 2019 at 11:34:15AM -0700, Rafael Antognolli wrote: > > On Wed, Apr 17, 2019 at 09:04:09AM -0700, Kenneth Graunke wrote: > > > On Wednesday, April 17, 2019 7:16:28 AM PDT Topi Pohjolainen wrote: > > > > From: Rafael An

Re: [Mesa-dev] [PATCH] nir/spirv: short-circuit when conditional branch contains end block

2019-04-18 Thread Juan A. Suarez Romero
On Thu, 2019-03-14 at 11:25 -0500, Jason Ekstrand wrote: > Looking at this a bit more, I'm not sure that just short-circuiting actually > covers all the cases. Unfortunately, we don't know what all the cases are > because the SPIR-V spec doesn't say. I'm trying to work towards fixing that > ri

[Mesa-dev] [PATCH] docs: document MESA_GLSL=errors keyword

2019-04-18 Thread Alejandro Piñeiro
Added with commit 0161691f3518, still checked on shaderapi.c _mesa_get_shader_flag method. --- docs/shading.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/shading.html b/docs/shading.html index 9e3c7218e31..76f25316f86 100644 --- a/docs/shading.html +++ b/docs/shading.html @@ -59,6

Re: [Mesa-dev] [PATCH] egl: Fix EGL_PLATFORM_X11_SCREEN_KHR handling

2019-04-18 Thread Emil Velikov
Hi Adam, On Wed, 17 Apr 2019 at 19:57, Adam Jackson wrote: > > If this was specified and a non-NULL display was passed to > eglGetPlatformDisplay, we would ignore the attribute and instead use > whatever xcb thought the default screen would be. > > To fix this, store a copy of the attribute list

Re: [Mesa-dev] Mesa/DRI applications freezing randomly

2019-04-18 Thread Eero Tamminen
Hi, (Please add answers to the bug you create about this) On 17.4.2019 16.22, Augusto Mecking Caringi wrote: Recently applications using Mesa/DRI libraries started fo freeze randomly in my system... I'm running Fedora 29 x86_64: - Kernel: x86_64 Linux 5.0.7-200.fc29.x86_64 - X.Org X Server 1.2

[Mesa-dev] [Bug 110462] Epic Games Launcher renders nothing with "-opengl" option

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110462 --- Comment #3 from Danylo --- It creates several contexts (from apitrace): glXCreateContextAttribsARB(dpy = 0x7e1e57b0, config = 0x7e875070, share_context = 0x7e9c0450, direct = True, attrib_list = [GLX_CONTEXT_MAJOR_VERSION_ARB, 3, GLX_CONTEX

Re: [Mesa-dev] [PATCH v7] intel/compiler: validate region restrictions for mixed float mode

2019-04-18 Thread Juan A. Suarez Romero
On Wed, 2019-04-17 at 13:17 -0700, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > From: Iago Toral Quiroga > > > > v2: > > - Adapted unit tests to make them consistent with the changes done > >to the validation of half-float conversions. > > > > v3 (Curro): > > - Check all

[Mesa-dev] [Bug 110468] using swrAVX renders incorrectly at certain resolutions

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110468 --- Comment #1 from ayan...@outlook.com --- Created attachment 144033 --> https://bugs.freedesktop.org/attachment.cgi?id=144033&action=edit Image of failed rendering -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 110468] using swrAVX renders incorrectly at certain resolutions

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110468 Bug ID: 110468 Summary: using swrAVX renders incorrectly at certain resolutions Product: Mesa Version: 19.0 Hardware: x86-64 (AMD64) OS: Windows (All)

Re: [Mesa-dev] [PATCH 3/3] ac/nir: use the new raw/struct SSBO atomic intrisics for comp_swap

2019-04-18 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri On 18/4/19 5:23 pm, Samuel Pitoiset wrote: This is actually fixed now. This change requires LLVM r358579. Make sure to have it in your tree, otherwise the following piglit will hang: tests/spec/arb_shader_storage_buffer_object/execution/ssbo-atomicCompSwap

[Mesa-dev] [Bug 109183] GPU Hangs randomly with GTA V

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109183 --- Comment #9 from Samuel Pitoiset --- I will investigate at some point. Could be related to https://bugs.freedesktop.org/show_bug.cgi?id=110345 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 109183] GPU Hangs randomly with GTA V

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109183 --- Comment #8 from Alexander --- Not really, mostly happens at "The Fleeca job", during the preparations. Video Settings: Screen type: Full screen view Resolution: 1920x1080 Refreshrate: 60hz but i guess 144hz gets forced by the DE. Direct

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: use the correct condition for the DPBB + QUANT_MODE workaround

2019-04-18 Thread Samuel Pitoiset
On 4/18/19 4:17 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_viewport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_viewport.c b/src/gallium/drivers/radeonsi/si_state_viewport.c index 1ec6

[Mesa-dev] [Bug 109183] GPU Hangs randomly with GTA V

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109183 --- Comment #7 from Samuel Pitoiset --- Yeah, it's quite interesting. I guess it's hard to find a good way for reproducing that hang? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH 1/3] Revert "radv: add VK_KHR_shader_atomic_int64 but disable it for now"

2019-04-18 Thread Timothy Arceri
On 18/4/19 4:39 pm, Samuel Pitoiset wrote: On 4/18/19 8:38 AM, Samuel Pitoiset wrote: On 4/18/19 8:34 AM, Timothy Arceri wrote: On 18/4/19 4:34 pm, Samuel Pitoiset wrote: On 4/18/19 8:16 AM, Timothy Arceri wrote: Meant to add this was tested on LLVM 9. What do you mean? I meant to say

[Mesa-dev] [Bug 110440] [REGRESSION] [BISECTED] [OpenGL CTS] dEQP-GLES2.functional.uniform_api.random.3

2019-04-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110440 --- Comment #4 from Kenneth Graunke --- https://gitlab.freedesktop.org/mesa/mesa/merge_requests/683 -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list

[Mesa-dev] [PATCH 3/3] ac/nir: use the new raw/struct SSBO atomic intrisics for comp_swap

2019-04-18 Thread Samuel Pitoiset
This is actually fixed now. This change requires LLVM r358579. Make sure to have it in your tree, otherwise the following piglit will hang: tests/spec/arb_shader_storage_buffer_object/execution/ssbo-atomicCompSwap-int.shader_test Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm

[Mesa-dev] [PATCH 1/3] ac/nir: only use the new raw/struct image atomic intrinsics with LLVM 9+

2019-04-18 Thread Samuel Pitoiset
They are buggy with LLVM 8 because they weren't marked as source of divergence, see r358579. Fixes: dd0172e865f ("radv: Use structured intrinsics instead of indexing workaround for GFX9.")" Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertion

[Mesa-dev] [PATCH 2/3] ac/nir: only use the new raw/struct SSBO atomic intrinsics with LLVM 9+

2019-04-18 Thread Samuel Pitoiset
They are buggy with older LLVM version, see r358579. Fixes: 78c551aca1c ("ac/nir: use new LLVM 8 intrinsics for SSBO atomics except cmpswap") Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/common

Re: [Mesa-dev] [PATCH] Revert "compiler/glsl: handle case where we have multiple users for types"

2019-04-18 Thread Timothy Arceri
On 18/4/19 4:38 pm, Tapani Pälli wrote: On 4/18/19 8:50 AM, Timothy Arceri wrote: On 18/4/19 3:08 pm, Tapani Pälli wrote: On 4/18/19 8:05 AM, Timothy Arceri wrote: This reverts commit 624789e3708c87ea2a4c8d2266266b489b421cba. It caused 400+ piglit tests to crash on radeonsi, I haven't been