Re: [Mesa-dev] [PATCH 1/2] drisw: fix incomplete type compilation failure

Hi Brian, Both of these fixes: Reviewed-by: Mathias Fröhlich best Mathias On Friday, 8 March 2019 23:53:32 CET Brian Paul wrote: > Fixes: > ../src/gallium/winsys/sw/dri/dri_sw_winsys.c: In function > ‘dri_sw_displaytarget_display’: > ../src/gallium/winsys/sw/dri/dri_sw_winsys.c:255:39: error

[Mesa-dev] [PATCH 07/12] panfrost: Allocate dedicated slab for linear BOs

Previously, linear BOs shared memory with each other to minimize kernel round-trips / latency, as well as to work around a bug in the free_slab function. These concerns are invalid now, but continuing to use the slab allocator for BOs resulted in memory allocation errors. This issue was aggravated,

[Mesa-dev] [PATCH 02/12] panfrost: Combine has_afbc/tiled in layout enum

AFBC, tiled, and linear BO layouts are mutually exclusive; they should be coupled via a single enum rather than ad hoc checks of booleans. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 33 ++-- src/gallium/drivers/panfrost/pan_resource.c | 34

[Mesa-dev] [PATCH 12/12] panfrost: Make hacks a little more obvious

To be clear, the layout switching voodoo is still a hack that needs to be cleaned up. But that's a job as big as this patch series always-is, so at least explain _why_ we're working counterintuitively. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 16

[Mesa-dev] [PATCH 09/12] panfrost: Support linear depth buffers

Previously, only AFBC depth buffers were supported for writing; a linear pseudo-depth-buffer was attached when clearing DEPTH but in practice this was not actually used. Nevertheless, the hardware does support honest-to-goodness linear depth buffers, which might be useful at some point. If nothing

[Mesa-dev] [PATCH 11/12] panfrost: Identify fragment_extra flags

The fragment_extra structure contains additional fields extending the MRT framebuffer descriptor, snuck in between the main framebuffer descriptor and the render targets. Its fields include those related to transaction elimination and depth/stencil buffers. This patch identifies the flags field (pr

[Mesa-dev] [PATCH 08/12] panfrost: Support linear depth textures

This combination has not yet been seen "in the wild" in traces, but to support linear depth FBOs, ~bruteforce reveals this bit pattern is necessary. It's not yet clear why the meanings of 0x1 and 0x2 are essentially flipped (tiled vs linear for colour, linear vs some sort of tiled for depth). Sign

[Mesa-dev] [PATCH 10/12] panfrost: Document "depth buffer writeback" bit

We were setting this bit as a magic value for a while when using depth FBOs, but it is only now clear what the meaning is. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/include/panfrost-job.h | 8 src/gallium/drivers/panfrost/pan_context.c | 5 ++--- 2 files

[Mesa-dev] [PATCH 05/12] panfrost: Determine framebuffer format bits late

Again, these formats are only properly known at the time of fragment job emit. Rather than hardcoding the format, at least for MFBD we begin to construct the format bits on-demand. This cleans up the code, futureproofs for ES3 framebuffer formats, and should fix bugs regarding FBO colour swizzles.

[Mesa-dev] [PATCH 06/12] panfrost: Refactor layout selection (BO creation)

With a unified layout field, we can specify the logic for BO layout explicitly, deciding between linear/tiled/AFBC based on the specified usage/binding flags. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 64 ++--- 1 file changed, 44 insertion

[Mesa-dev] [PATCH 03/12] panfrost: Delay color buffer setup

In an effort to cleanup framebuffer management code, we delay colour buffer setup until the FRAGMENT job is actually emitted, allowing the AFBC and linear codepaths to be unified. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 93 -- 1 file

[Mesa-dev] [PATCH 01/12] panfrost: Cleanup needless if in create_bo

I'm not sure why we were checking for these additional criteria (likely inherited from some other driver); remove the needless checks to cleanup the code and perhaps fix some bugs down the line. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 56 ++-

[Mesa-dev] [PATCH 04/12] panfrost: Cleanup zsbuf emit in fragment job

This emit is only implemented for AFBC depth/stencil buffers, so conceptually there is no change here, but we follow the style of the previous patch to improve robustness and clarity. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 71 +- 1 f

[Mesa-dev] [PATCH 00/12] Refactors related to BO layouts

Midgard supports (at least) 3 broad classes of resource layouts: * Linear: slow, but universally supported, uncompressed * Tiled: good for cache efficiency, uncompressed * Arm Framebuffer Compression (AFBC): tiled and compressed We can't render into tiled buffers (for technical reasons), and we c

[Mesa-dev] [Bug 109535] [Tracker] Mesa 19.0 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=109535 Cristian Aravena changed: What|Removed |Added CC||carav...@gmail.com -- You are recei

Re: [Mesa-dev] [PATCH 2/5] d3dadapter9: Support software renderer on any DRI device

After pushing this (with my r-b), gitlab's travis complained. It seems there needs to be some ifdefs to check if kms was built. I reverted the patch until it is fixed. Axel On 07/03/2019 23:23, Axel Davy wrote: From: Patrick Rudolph If D3D_ALWAYS_SOFTWARE is set for debugging purposes, run

Re: [Mesa-dev] [PATCH 1/5] st/nine: Disable depth write when nothing gets updated

On 08/03/2019 07:26, Kenneth Graunke wrote: On Thursday, March 7, 2019 2:23:53 PM PST Axel Davy wrote: I don't think we actually need the NEVER check, but it seems fine. Patches 1 and 3 are: Reviewed-by: Kenneth Graunke I'm not really up to speed to review the others. Thanks, I got a review

Re: [Mesa-dev] dumb meson questions

Did you build LLVM yourself. In my experience, passing -DCMAKE_C_FLAGS="-g1 -fno-omit-frame-pointer" \ -DCMAKE_CXX_FLAGS="-g1 -fno-omit-frame-pointer" \ to cmake when building LLVM makes debugging info much smaller, without compromising the ability to get stack traces, etc. Jos