Re: [Mesa-dev] [PATCH 1/4] radeonsi/nir: add get_component_usagemask() helper

2019-02-10 Thread Timothy Arceri
Please ingnore this series for now. I'm working on a series that does this better. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109603] nir_instr_as_deref: Assertion `parent && parent->type == nir_instr_type_deref' failed.

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109603 --- Comment #2 from Jason Ekstrand --- I've got a patch on the mailing list which fixes this: https://patchwork.freedesktop.org/patch/285338/ -- You are receiving this mail because: You are the assignee for the bug.___

[Mesa-dev] [PATCH] nir/deref: Rematerialize parents in rematerialize_derefs_in_use_blocks

2019-02-10 Thread Jason Ekstrand
When nir_rematerialize_derefs_in_use_blocks_impl was first written, I attempted to optimize things a bit by not bothering to re-materialize the sources of deref instructions figuring that the final caller would take care of that. However, in the case of more complex deref chains where the first li

[Mesa-dev] [PATCH 3/4] radeonsi/nir: set input_usage_mask properly

2019-02-10 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 28 +++- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 04e9e217306..ba7c0b31bd2 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 2/4] radeonsi/nir: add get_num_of_component_info() helper

2019-02-10 Thread Timothy Arceri
This will be reused in the following patch. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 38 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 5abda445e09..04

[Mesa-dev] [PATCH 4/4] radeonsi/nir: set colors_read properly

2019-02-10 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 21 +++- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index ba7c0b31bd2..d5a5464e235 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 1/4] radeonsi/nir: add get_component_usagemask() helper

2019-02-10 Thread Timothy Arceri
This will be reused in a following patch. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 46 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 7554f5b9f8b..5abd

Re: [Mesa-dev] [PATCH 2/5] panfrost: Specify supported draw modes per-context

2019-02-10 Thread Alyssa Rosenzweig
> Might I recommend saying (PIPE_PRIM_POLYGON + 1) instead of > PIPE_PRIM_LINES_ADJACENCY? Otherwise it's a bit unclear why you're > talking about LINES_ADJ. Thanks, just pushed with this change. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

[Mesa-dev] [PATCH] panfrost: Resolve alignment issue on 32-bit

2019-02-10 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_blending.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_blending.c b/src/gallium/drivers/panfrost/pan_blending.c index 058fb6bda84..a19d048123b 100644 --- a/src/gall

[Mesa-dev] [PATCH v4 0/4] improved the support for ETC2 formats on Gen 7

2019-02-10 Thread Eleni Maria Stea
Intel Gen7 GPUs don't support the ETC2 formats natively and in order to show the pixels properly we convert them to RGBA and create RGBA miptrees. The problem with that is that the GetCompressed* functions that should return the compressed pixel values return the RGBA instead. These patches are an

[Mesa-dev] [PATCH v4 1/4] i965: Rename intel_mipmap_tree::r8stencil_* -> ::shadow_*

2019-02-10 Thread Eleni Maria Stea
From: Nanley Chery Use more generic field names. We'll reuse these fields for a workaround with ASTC miptrees. Reviewed-by: Eleni Maria Stea --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 8 src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 16 src/mesa/driv

[Mesa-dev] [PATCH v4 4/4] i965: Enabled the OES_copy_image extension on Gen 7 GPUs

2019-02-10 Thread Eleni Maria Stea
OES_copy_image extension was disabled on Gen7 due to the lack of support for ETC2 images. Enabled it back. (Kenneth Graunke) v2: - Removed the blank lines in the comments above OES_copy_image and OES_texture_view extensions in intel_extensions.c (Nanley Chery) --- src/mesa/drivers/dri/i965/in

[Mesa-dev] [PATCH v4 0/4] improved the support for ETC2 formats on Gen 7

2019-02-10 Thread Eleni Maria Stea
Intel Gen7 GPUs don't support the ETC2 formats natively and in order to show the pixels properly we convert them to RGBA and create RGBA miptrees. The problem with that is that the GetCompressed* functions that should return the compressed pixel values return the RGBA instead. These patches are an

[Mesa-dev] [PATCH v4 3/4] i965: Fixed the CopyImageSubData for ETC2 on Gen < 8

2019-02-10 Thread Eleni Maria Stea
For CopyImageSubData to copy the data during the 1st draw call, we need to update the shadow tree right before the rendering. v2: - Added assertion that the miptree doesn't need update at the time we update the texture surface. (Nanley Chery) v3: - As we now update the tree before the rende

[Mesa-dev] [PATCH v4 2/4] i965: Faking the ETC2 compression on Gen < 8 GPUs using two miptrees.

2019-02-10 Thread Eleni Maria Stea
GPUs Gen < 8 cannot sample ETC2 formats. So far, they converted the compressed EAC/ETC2 images to non-compressed RGBA images. When GetCompressed* functions were called, the pixels were returned in this RGBA format and not the compressed format that was expected. Trying to fix this problem, we use

[Mesa-dev] [Bug 109565] CmdBindDescriptorSets gets confused about dynamic offsets

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109565 --- Comment #6 from Jakub OkoĊ„ski --- I've made some unrelated changes (the mvp_set and its layout is still the same), and even started using advanced descriptor indexing features with partially bound descriptor sets and suddenly it's working. N

[Mesa-dev] [Bug 109603] nir_instr_as_deref: Assertion `parent && parent->type == nir_instr_type_deref' failed.

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109603 --- Comment #1 from xbx --- the hlsl code it was compiled from: RWBuffer Weights : register(u0); struct SCtx { uintiList ; uintLightId ; float LightW ; }; void LoadLight(in out SCtx C) { const ui

[Mesa-dev] [Bug 109603] nir_instr_as_deref: Assertion `parent && parent->type == nir_instr_type_deref' failed.

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109603 Bug ID: 109603 Summary: nir_instr_as_deref: Assertion `parent && parent->type == nir_instr_type_deref' failed. Product: Mesa Version: git Hardware: Other O

Re: [Mesa-dev] [PATCH 0/5] Cleanup dead code

2019-02-10 Thread Robert Foss
This patch is Reviewed-by: Robert Foss On 2/9/19 2:21 AM, Alyssa Rosenzweig wrote: Via the prototyping cycle, a substantial amount of dead code and other cruft has accumulated in the Panfrost tree, which is a burden for both maintenance and aesthetic. This patch series removes dead code when i

Re: [Mesa-dev] [PATCH 0/5] Cleanup dead code

2019-02-10 Thread Robert Foss
On 2/10/19 6:58 PM, Robert Foss wrote: This patch is s/patch/series Reviewed-by: Robert Foss On 2/9/19 2:21 AM, Alyssa Rosenzweig wrote: Via the prototyping cycle, a substantial amount of dead code and other cruft has accumulated in the Panfrost tree, which is a burden for both maintenance

[Mesa-dev] [Bug 109574] Blender 2.8

2019-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109574 --- Comment #14 from Gert Wollny --- I've seen a few differences in the shaders created on HD2600 vs. HD4850 (one has a R6xx class chip, the other a R7xx chip), i.e. at some points in the shader creatied for HD2600 contain workarounds for hardw