[Mesa-dev] [PATCH] nv50: always keep TSC slot 0 bound

2018-12-01 Thread Ilia Mirkin
All TXF operations implicitly use sampler 0, and fail if it's not bound to anything. This does not happen in LINKED_TSC mode, but we don't currently use this. We ensure that TSC entry at id 0 has the SRGB conversion bit enabled (and all samplers we normally generate will too). Then when the TSC at

Re: [Mesa-dev] [PATCH v3] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-12-01 Thread Ilia Mirkin
Looks right. Reviewed-by: Ilia Mirkin On Sat, Dec 1, 2018 at 1:18 PM Karol Herbst wrote: > > The new approach is that samplers don't get unbound even if they won't be used > in a draw and we should just leave them be as well. > > Fixes a regression in multiple windows games using gallium nine an

[Mesa-dev] [PATCH v3] nv50, nvc0: Fix gallium nine regression regarding sampler bindings

2018-12-01 Thread Karol Herbst
The new approach is that samplers don't get unbound even if they won't be used in a draw and we should just leave them be as well. Fixes a regression in multiple windows games using gallium nine and nouveau. v2: adjust num_samplers to keep track of the highest sampler bound v3: rework how to set

[Mesa-dev] [PATCH] amd/vulkan: meson build - use radv_deps for libvulkan_radeon

2018-12-01 Thread Tobias Klausmann
Without this the build breaks with: FAILED: src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o cc -Isrc/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha -Isrc/amd/vulkan -I../src/amd/vulkan -Isrc/../include -I../src/../include -Isrc -I../src -Isrc/mapi -I../src/mapi -Isrc/mesa -I../src

[Mesa-dev] [Bug 108647] Kernel parameter GRUB_CMDLINE_LINUX_DEFAULT="quiet splash amdgpu.ppfeaturemask=0xffffffff" artifacts

2018-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108647 --- Comment #3 from echar...@vtluug.org --- Created attachment 142682 --> https://bugs.freedesktop.org/attachment.cgi?id=142682&action=edit dmesg with 4.20.0-rc4 kernel when having the issue As I understand, ppfeaturemask is set in order to en

[Mesa-dev] [Bug 108647] Kernel parameter GRUB_CMDLINE_LINUX_DEFAULT="quiet splash amdgpu.ppfeaturemask=0xffffffff" artifacts

2018-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108647 --- Comment #2 from echar...@vtluug.org --- Created attachment 142681 --> https://bugs.freedesktop.org/attachment.cgi?id=142681&action=edit xorg log with ppfeaturemask=0x -- You are receiving this mail because: You are the QA Contact

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-12-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #15 from egon2003 --- I have been trying to record a trace with renderdoc but I have been unsuccessful. Im not sure if I am doing something wrong or if it just does not work. I have also been trying to get a new apitrace but I cant

Re: [Mesa-dev] Representing explicit memory layouts in NIR

2018-12-01 Thread Jason Ekstrand
For what it's worth, I've prototyped both 1 and 3 and I don't like either: https://gitlab.freedesktop.org/jekstrand/mesa/commits/wip/nir-ubo-deref-v0.2 https://gitlab.freedesktop.org/jekstrand/mesa/commits/wip/nir-ubo-deref-v0.3 I'm going to try 2B next week. --Jason On Fri, Nov 30, 2018 at 4:

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Samuel Pitoiset
On 12/1/18 3:36 PM, Connor Abbott wrote: On Sat, Dec 1, 2018 at 3:22 PM Samuel Pitoiset wrote: I'm not saying this series is the right thing to do. It just fixes two test failures in the vkd3d testsuite for RADV. I added a new compiler option to not break anything and to only affects RADV. A

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Connor Abbott
On Sat, Dec 1, 2018 at 3:22 PM Samuel Pitoiset wrote: > > I'm not saying this series is the right thing to do. It just fixes two > test failures in the vkd3d testsuite for RADV. I added a new compiler > option to not break anything and to only affects RADV. Anyways, it seems > unclear what the bes

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Samuel Pitoiset
I'm not saying this series is the right thing to do. It just fixes two test failures in the vkd3d testsuite for RADV. I added a new compiler option to not break anything and to only affects RADV. Anyways, it seems unclear what the best option is. To sum up, looks like there is 3 ways: 1) set t

Re: [Mesa-dev] [PATCH 1/2] nir: add a compiler option for disabling float comparison simplifications

2018-12-01 Thread Connor Abbott
On Fri, Nov 30, 2018 at 10:18 PM Ian Romanick wrote: > > On 11/29/2018 07:47 AM, Connor Abbott wrote: > > On Thu, Nov 29, 2018 at 4:22 PM Jason Ekstrand wrote: > >> > >> Can you provide some context for this? Those rules are already flagged > >> "inexact" (that's what the ~ means) so they won't

Re: [Mesa-dev] Representing explicit memory layouts in NIR

2018-12-01 Thread Jason Ekstrand
On Sat, Dec 1, 2018 at 4:06 AM apinheiro wrote: > On 30/11/18 23:52, Jason Ekstrand wrote: > > On Fri, Nov 30, 2018 at 4:39 PM Timothy Arceri > wrote: > >> On 1/12/18 9:11 am, Jason Ekstrand wrote: >> > All, >> > >> > This week, I've been working on trying to move UBO and SSBO access in >> > NIR

Re: [Mesa-dev] [PATCH] d3dadapter9: use snprintf(..., "%s", ...) instead of strncpy

2018-12-01 Thread Axel Davy
Well, OK, I guess these snprintf call are an acceptable solution then. Reviewed-by: Axel Davy On 26/11/2018 13:23, Andre Heider wrote: On 25/11/2018 17:23, Axel Davy wrote: Reading https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/ I think the snprintf var

Re: [Mesa-dev] Representing explicit memory layouts in NIR

2018-12-01 Thread apinheiro
On 30/11/18 23:52, Jason Ekstrand wrote: > On Fri, Nov 30, 2018 at 4:39 PM Timothy Arceri > wrote: > > On 1/12/18 9:11 am, Jason Ekstrand wrote: > > All, > > > > This week, I've been working on trying to move UBO and SSBO > access in > > NIR ov