On Saturday, 24 November 2018 04:03:06 CET Marek Olšák wrote:
> For the series:
>
> Reviewed-by: Marek Olšák
Thank You!
Mathias
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Scons and autotools don't define it, and as of last commit nothing
uses it.
`VERSION` is also a generic enough name that something somewhere will
eventually clash, and we don't want to repeat the LLVM `DEBUG` fiasco.
Signed-off-by: Eric Engestrom
---
Android.common.mk | 1 -
meson.build |
On 23/11/2018 19:47, Eric Engestrom wrote:
Per chapter 3.2 "Instances":
Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing
an apiVersion of 0 is equivalent to providing an apiVersion of
VK_MAKE_VERSION(1,0,0).
Reported-by: Niklas Haas
Fixes: 8c048af5890d43578ca4 "anv: Copy th
Everything else uses PACKAGE_VERSION, so let's be consistent, and
VERSION and PACKAGE_VERSION are currently defined to be the same in
meson and android, while VERSION is undefined in autotools and scons.
Signed-off-by: Eric Engestrom
---
src/vulkan/util/vk_util.c | 6 +++---
1 file changed, 3 in
Would it make sense to instead keep track of a samplers_bound[] like
we do for textures? It's only ever used in a context of
for (i = 0; i < num_samplers; i++)
if (samplers[i])
do stuff
So having a mask would actually optimize that, and make this logic much simpler.
On Sun, Nov 25, 2018 at
Yeah, the common case of a handful of textures bound, it saves a lot
of iterations (not to mention the current max of 16 on nv50). This
stuff comes up on drawoverhead, I'd imagine. Since it's trivial to
implement, I don't really understand why we're talking about this...
On Sun, Nov 25, 2018 at 6:1
ohh, I was being silly. Nvm.. yeah, bitmask it is.
On Mon, Nov 26, 2018 at 12:19 AM Ilia Mirkin wrote:
>
> Yeah, the common case of a handful of textures bound, it saves a lot
> of iterations (not to mention the current max of 16 on nv50). This
> stuff comes up on drawoverhead, I'd imagine. Since
On Sun, Nov 25, 2018 at 5:48 PM Ilia Mirkin wrote:
>
> Would it make sense to instead keep track of a samplers_bound[] like
> we do for textures? It's only ever used in a context of
>
> for (i = 0; i < num_samplers; i++)
> if (samplers[i])
> do stuff
>
I already had the idea to just remove
On Sun, Nov 25, 2018 at 5:43 PM Karol Herbst wrote:
>
> On Sun, Nov 25, 2018 at 5:48 PM Ilia Mirkin wrote:
> >
> > Would it make sense to instead keep track of a samplers_bound[] like
> > we do for textures? It's only ever used in a context of
> >
> > for (i = 0; i < num_samplers; i++)
> > if (
Improves performance in Talos by about 15% (and significant improvements
in RotR and possibly other but did not bench with final patch) on
kernel 4.19 and earlier.
On 4.20+ a similar effect comes from
433ca054949a "drm/amdgpu: try allocating VRAM as power of two"
v2: Do not impact the alignment
On Sun, Nov 25, 2018 at 5:48 PM Ilia Mirkin wrote:
>
> Would it make sense to instead keep track of a samplers_bound[] like
> we do for textures? It's only ever used in a context of
>
> for (i = 0; i < num_samplers; i++)
> if (samplers[i])
> do stuff
>
> So having a mask would actually opti
On Mon, Nov 26, 2018 at 12:08 AM Ilia Mirkin wrote:
>
> On Sun, Nov 25, 2018 at 5:43 PM Karol Herbst wrote:
> >
> > On Sun, Nov 25, 2018 at 5:48 PM Ilia Mirkin wrote:
> > >
> > > Would it make sense to instead keep track of a samplers_bound[] like
> > > we do for textures? It's only ever used in
Improves performance in Talos by about 15% (and significant improvements
in RotR and possibly other but did not bench with final patch) on
kernel 4.19 and earlier.
On 4.20+ a similar effect comes from
433ca054949a "drm/amdgpu: try allocating VRAM as power of two"
Given the simplicity of the patc
Reading
https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/
I think the snprintf variant suffers from the same issue, and the
compiler is just not yet able to detect it,
and send the same warning (but it might do in later gcc versions).
Probably a better fix wo
anv and radv both happened to already return 2^14 for these, but
querying the ICD is better and will help if vdreno (or whatever it's
called) doesn't have the same max.
Signed-off-by: Eric Engestrom
---
src/vulkan/wsi/wsi_common.c | 7 ---
src/vulkan/wsi/wsi_common.h | 1 +
The new approach is that samplers don't get unbound even if they won't be used
in a draw and we should just leave them be as well.
Fixes a regression in multiple windows games using gallium nine and nouveau.
v2: adjust num_samplers to keep track of the highest sampler bound
Bugzilla: https://bug
Fixes -Wstringop-truncation compiler warnings.
See f836d799f9066adf58f36 "intel/decoder: use snprintf(..., "%s", ...) instead
of strncpy"
Signed-off-by: Andre Heider
---
src/gallium/targets/d3dadapter9/description.c | 27 ---
src/gallium/targets/d3dadapter9/drm.c | 8 ++
https://bugs.freedesktop.org/show_bug.cgi?id=108856
Bug ID: 108856
Summary: floating-point-exceptions in gallium/auxiliary/tgsi/
functions
Product: Mesa
Version: 18.2
Hardware: Other
OS: All
Stat
18 matches
Mail list logo
