Re: [Mesa-dev] [radeonsi] Blender/vsraytrace/fsraytrace/gsraytrace - GPUShader: compile error

2018-11-11 Thread Timothy Arceri
I'm guessing your using GCC 8.2.1 to compile Mesa? There was a compiler bug: https://bugzilla.redhat.com/show_bug.cgi?id=1645400 On 12/11/18 2:11 pm, Dieter Nützel wrote: Hello, I get brocken shaders with Blender and the above demos didn't start any longer. NOT NIR related. Have to start bise

[Mesa-dev] [Bug 108636] test_optpass has use after free bug, failing with memory testing tools like address sanitizer

2018-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108636 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] nir: don't pack varyings ints with floats unless flat

2018-11-11 Thread Jason Ekstrand
On Sun, Nov 11, 2018 at 9:37 PM Timothy Arceri wrote: > On 12/11/18 2:11 pm, Jason Ekstrand wrote: > > On November 11, 2018 20:30:29 Timothy Arceri > wrote: > > > >> Fixes: 1c9c42d16b4c ("nir: add varying component packing helpers") > >> --- > >> src/compiler/nir/nir_linking_helpers.c | 9 ++

Re: [Mesa-dev] [PATCH 2/2] nir: don't pack varyings ints with floats unless flat

2018-11-11 Thread Timothy Arceri
On 12/11/18 2:11 pm, Jason Ekstrand wrote: On November 11, 2018 20:30:29 Timothy Arceri wrote: Fixes: 1c9c42d16b4c ("nir: add varying component packing helpers") --- src/compiler/nir/nir_linking_helpers.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler

[Mesa-dev] [radeonsi] Blender/vsraytrace/fsraytrace/gsraytrace - GPUShader: compile error

2018-11-11 Thread Dieter Nützel
Hello, I get brocken shaders with Blender and the above demos didn't start any longer. NOT NIR related. Have to start bisect. OpenGL renderer string: Radeon RX 580 Series (POLARIS10, DRM 3.27.0, 4.19.0-rc1-1.g7262353-default+, LLVM 8.0.0) OpenGL core profile version string: 4.5 (Core Profile)

Re: [Mesa-dev] [PATCH 2/2] nir: don't pack varyings ints with floats unless flat

2018-11-11 Thread Jason Ekstrand
On November 11, 2018 20:30:29 Timothy Arceri wrote: Fixes: 1c9c42d16b4c ("nir: add varying component packing helpers") --- src/compiler/nir/nir_linking_helpers.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_linking_helpers.c b/src/compiler/n

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Jason Ekstrand
On Sun, Nov 11, 2018 at 8:46 PM Karol Herbst wrote: > an) > On Mon, Nov 12, 2018 at 12:37 AM Jason Ekstrand > wrote: > > > > On November 11, 2018 16:36:16 Karol Herbst wrote: > > > > > On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand > wrote: > > >> > > >> On Sun, Nov 11, 2018 at 3:35 PM Plame

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Karol Herbst
an) On Mon, Nov 12, 2018 at 12:37 AM Jason Ekstrand wrote: > > On November 11, 2018 16:36:16 Karol Herbst wrote: > > > On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand > > wrote: > >> > >> On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova > >> wrote: > >>> > >>> > >>> Lowering shader variables

[Mesa-dev] [PATCH 2/2] nir: don't pack varyings ints with floats unless flat

2018-11-11 Thread Timothy Arceri
Fixes: 1c9c42d16b4c ("nir: add varying component packing helpers") --- src/compiler/nir/nir_linking_helpers.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_linking_helpers.c b/src/compiler/nir/nir_linking_helpers.c index b07bb40894e..125a8d55b3e

[Mesa-dev] [PATCH 1/2] nir: add glsl_type_is_integer() helper

2018-11-11 Thread Timothy Arceri
--- src/compiler/nir_types.cpp | 5 + src/compiler/nir_types.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index d24f0941519..3cd61f66056 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_types.cpp @@ -301,6 +301,

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Jason Ekstrand
On November 11, 2018 16:36:16 Karol Herbst wrote: On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand wrote: On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova wrote: Lowering shader variables which depend on the local work group size being available in nir_lower_system_values is only possibl

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Karol Herbst
On Sun, Nov 11, 2018 at 10:48 PM Jason Ekstrand wrote: > > On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova > wrote: >> >> Lowering shader variables which depend on the local work group >> size being available in nir_lower_system_values is only possible >> if the local work group size isn't vari

Re: [Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Jason Ekstrand
On Sun, Nov 11, 2018 at 3:35 PM Plamena Manolova < plamena.n.manol...@gmail.com> wrote: > Lowering shader variables which depend on the local work group > size being available in nir_lower_system_values is only possible > if the local work group size isn't variable, otherwise this should > be hand

Re: [Mesa-dev] [PATCH 0/2] Update on thread_submit

2018-11-11 Thread Andre Heider
On 10/11/2018 17:09, Axel Davy wrote: Axel Davy (2): st/nine: Allow 'triple buffering' with thread_submit st/nine: Remove thread_submit warning Nice! Series is: Tested-by: Andre Heider ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

[Mesa-dev] [PATCH v2] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Plamena Manolova
Lowering shader variables which depend on the local work group size being available in nir_lower_system_values is only possible if the local work group size isn't variable, otherwise this should be handled by the native driver (if it supports ARB_compute_variable_group_size). Signed-off-by: Plamen

[Mesa-dev] [PATCH] nir: Handle variables dependent on the local work group size.

2018-11-11 Thread Plamena Manolova
Lowering the global invocation id and the local work group size in nir_lower_system_values is only possible if the local work group size isn't variable, otherwise this should be handled by the native driver (if it supports ARB_compute_variable_group_size). Signed-off-by: Plamena Manolova --- src

[Mesa-dev] [PATCH] nv50/ir/ra: enforce max register requirement, and change spill order

2018-11-11 Thread Ilia Mirkin
On nv50, certain operations must happen on regs below 64, due to encoding requirements. First of all, we add infrastructure to enforce this. Secondly we change the spill order to first spill RIG nodes that are unconstrained, followed by ones that are. This makes the gamecube logo shadertoy compile

Re: [Mesa-dev] [PATCH] util: Fix warning in u_cpu_detect on non-x86

2018-11-11 Thread Alyssa Rosenzweig
Alright, thank you :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [RFC PATCH] gallium/nir: Add shader-based blending helpers

2018-11-11 Thread Alyssa Rosenzweig
Some mobile GPUs lack fixed-function hardware for blending, instead emulating blending via internal shaders. In particular for us, vc4 lacks most of the fragment pipeline, implementing blending in the epilogue of the fragment shader. Newer Malis supported by Panfrost have limitations in their fixed

Re: [Mesa-dev] [PATCH] meson: Don't set -Wall

2018-11-11 Thread Eric Engestrom
On Friday, 2018-11-09 13:28:49 -0800, Dylan Baker wrote: > meson does this for you with it's warn levels, so we don't need to set > it ourselves. s/it's/its/ And yeah you're right, I just checked and -Wall (or equivalent) is always passed to compilers that support it. Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] util: Fix warning in u_cpu_detect on non-x86

2018-11-11 Thread Matt Turner
Thank you. I noticed this as well. Reviewed-by: Matt Turner I'll commit it tomorrow if there are no additional comments. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] util: Fix warning in u_cpu_detect on non-x86

2018-11-11 Thread Alyssa Rosenzweig
regs is only set and used on x86; on other platforms (like ARM), this code causes a trivial warning, solved by moving the regs declaration to the architecture-dependent usage. Signed-off-by: Alyssa Rosenzweig --- src/util/u_cpu_detect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH mesa 3/3] meson: fix wayland-less builds

2018-11-11 Thread Eric Engestrom
On Thursday, 2018-10-11 16:36:15 +0100, Eric Engestrom wrote: > Those empty variables in the !wayland case are useless and running that > meson.build with them breaks the build: > > [287/850] Generating wayland-drm-client-protocol.h with a custom command. > FAILED: src/egl/wayland/wayland-drm/

[Mesa-dev] [PATCH] nv50/ir/ra: improve condition for short regs, unify with cond for 16-bit

2018-11-11 Thread Ilia Mirkin
Instead of the size restriction existing in two places, and potentially being applied twice, we move this together. Ops with 16-bit register addresses can only take a short reg, and ops with immediates can only take a short reg. Of course we leave the immediate 0 in place since we know that it wil

Re: [Mesa-dev] [PATCH 6/7] intel/fs: Support min_lod parameters on texture instructions

2018-11-11 Thread Jason Ekstrand
Sagar reminded me via his MSR that this patch series never landed. Everything got reviewed by Ian except this patch which he only acked. Would someone mind doing a more proper review? This seemed like the wrong patch to push with just an ack. --Jason On Thu, Oct 11, 2018 at 4:33 PM Jason Ekstran

Re: [Mesa-dev] [PATCH] nir: Allow to skip integer ops in nir_lower_to_source_mods

2018-11-11 Thread Jason Ekstrand
On November 11, 2018 09:11:26 Gert Wollny wrote: Am Sonntag, den 11.11.2018, 09:07 -0600 schrieb Jason Ekstrand: On November 11, 2018 07:44:54 Gert Wollny wrote: From: Gert Wollny Since some hardware supports source mods only for float operations make it possible to skip this lowering

Re: [Mesa-dev] [PATCH] nir: Allow to skip integer ops in nir_lower_to_source_mods

2018-11-11 Thread Gert Wollny
Am Sonntag, den 11.11.2018, 09:07 -0600 schrieb Jason Ekstrand: > On November 11, 2018 07:44:54 Gert Wollny > wrote: > > > From: Gert Wollny > > > > > > Since some hardware supports source mods only for float operations > > make > > it possible to skip this lowering for integer operations. >

Re: [Mesa-dev] [PATCH] nir: Allow to skip integer ops in nir_lower_to_source_mods

2018-11-11 Thread Jason Ekstrand
On November 11, 2018 07:44:54 Gert Wollny wrote: From: Gert Wollny Since some hardware supports source mods only for float operations make it possible to skip this lowering for integer operations. Out of curiosity, what hardware would that be? Signed-off-by: Gert Wollny --- I'm a bit un

[Mesa-dev] [PATCH] nir: Allow to skip integer ops in nir_lower_to_source_mods

2018-11-11 Thread Gert Wollny
From: Gert Wollny Since some hardware supports source mods only for float operations make it possible to skip this lowering for integer operations. Signed-off-by: Gert Wollny --- I'm a bit unsure about what the best name for the parameter is, i.e. passing in true when one doesn't want all t