Re: [Mesa-dev] [PATCH 0/9] nir: Add better helpers for handling constant sources

2018-10-26 Thread Jason Ekstrand
I landed the first four but it'd be nice if I could get some review on the intel bits. --Jason On Sat, Oct 20, 2018 at 12:55 PM Jason Ekstrand wrote: > Previously, the only thing we had was nir_src_as_const_value which returns > a pointer to a nir_const_value which was NULL if the source wasn't

[Mesa-dev] [PATCH 3/3] radeonsi: add support for Raven2

2018-10-26 Thread Marek Olšák
From: Marek Olšák --- src/amd/addrlib/amdgpu_asic_addr.h | 2 ++ src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +- src/amd/common/ac_gpu_info.c| 6 ++ src/amd/common/ac_llvm_util.c | 1 + src/amd/common/ac_surface.c

[Mesa-dev] [PATCH 1/3] radeonsi/gfx9: set optimal OVERWRITE_COMBINER_WATERMARK

2018-10-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_state.c | 14 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.h index dc95afb7421..08

[Mesa-dev] [PATCH 2/3] radeonsi: clean up decompress flags in fast color clear

2018-10-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c index 520e5b94f4a..8aa3355afc8 100644 --- a/src/gallium/drivers

Re: [Mesa-dev] [PATCH] nir: Allow using nir_lower_io_to_scalar_early on VS input vars.

2018-10-26 Thread Timothy Arceri
On Mon, Oct 15, 2018, at 5:18 PM, Eric Anholt wrote: > This will be used on V3D to cut down the size of the VS inputs in the VPM > (memory area for sharing data between shader stages). > --- > src/compiler/nir/nir_lower_io_to_scalar.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH 1/3] anv: Flag semaphore BOs as external

2018-10-26 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 26/10/2018 19:40, Jason Ekstrand wrote: It probably doesn't actually break anything but it does cause some assertions in debug builds. Fixes: 7a89a0d9edae6 "anv: Use separate MOCS settings for external BOs" --- src/intel/vulkan/anv_queue.c | 5 +++-- 1 file

Re: [Mesa-dev] [PATCH] glsl/linker: validate attribute aliasing before optimizations

2018-10-26 Thread Timothy Arceri
On Fri, Oct 12, 2018, at 5:04 AM, Tapani Pälli wrote: > Patch does a 'dry run' of assign_attribute_or_color_locations before > optimizations to catch cases where we have aliasing of unused attributes > which is forbidden by the GLSL ES 3.x specifications. > > We need to run this pass before unused

Re: [Mesa-dev] [PATCH] anv: Improve the asserts in anv_buffer_get_range

2018-10-26 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 26/10/2018 19:28, Jason Ekstrand wrote: --- src/intel/vulkan/anv_private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 25e290ed112..d8a08d9d67f 100644 --- a/src/i

Re: [Mesa-dev] [PATCH] glsl/linker: Fix out variables linking during single stage

2018-10-26 Thread Timothy Arceri
On Wed, Oct 24, 2018, at 3:28 AM, Vadym Shovkoplias wrote: > Since out variables are copied from shader objects instruction > streams to linked shader instruction steam it should be cloned > at first to keep source instruction steam unaltered. > > Fixes: 966a797e433 glsl/linker: Link all out vars

[Mesa-dev] [Bug 108572] Could not start gimp (probably due to opencl)

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108572 Bug ID: 108572 Summary: Could not start gimp (probably due to opencl) Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 1/2] blorp: Emit a dummy 3DSTATE_WM prior to 3DSTATE_WM_HZ_OP

2018-10-26 Thread Kenneth Graunke
On Tuesday, October 16, 2018 1:12:18 PM PDT Jason Ekstrand wrote: > Suggested-by: Francisco Jerez > --- > src/intel/blorp/blorp_genX_exec.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/intel/blorp/blorp_genX_exec.h > b/src/intel/blorp/blorp_genX_exec.h > index 50341ab0e

Re: [Mesa-dev] [Mesa-stable] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

2018-10-26 Thread Dylan Baker
Quoting Eric Engestrom (2018-10-26 14:05:31) > On Friday, 2018-10-26 08:55:46 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-10-25 09:44:14) > > > On Tuesday, 2018-10-02 13:44:07 -0700, Dylan Baker wrote: > > > > Quoting Eric Engestrom (2018-10-02 07:09:03) > > > > > Cc: mesa-sta...@lis

Re: [Mesa-dev] [Mesa-stable] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

2018-10-26 Thread Eric Engestrom
On Friday, 2018-10-26 08:55:46 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-10-25 09:44:14) > > On Tuesday, 2018-10-02 13:44:07 -0700, Dylan Baker wrote: > > > Quoting Eric Engestrom (2018-10-02 07:09:03) > > > > Cc: mesa-sta...@lists.freedesktop.org > > > > Signed-off-by: Eric Engestro

[Mesa-dev] [PATCH] anv/SKL+: Use ForceThreadDispatchEnable instead of PixelShaderHasUAV

2018-10-26 Thread Jason Ekstrand
This reverts commit 0fa9e6d7b304f6a8064ed78a4b9c557e1026e7e5 but adds a line to BLORP to emit 3DSTATE_WM right before 3DSTATE_WM_HZ_OP. Cc: Kenneth Graunke --- src/intel/blorp/blorp_genX_exec.h | 9 +++ src/intel/vulkan/genX_pipeline.c | 42 ++- 2 files changed

[Mesa-dev] [PATCH] nir/deref: Support casts in comparisons

2018-10-26 Thread Jason Ekstrand
The code which constructs deref paths already gives you the path starting at the nearest deref_cast or deref_var. All we need to do is handle the case where the start of the path isn't a deref_var. Cc: Caio Marcelo de Oliveira Filho --- src/compiler/nir/nir_deref.c | 40 +++

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-26 Thread Dylan Baker
Quoting Matt Turner (2018-10-26 10:44:47) > On Fri, Oct 26, 2018 at 3:06 AM Sergii Romantsov > wrote: > > > > While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. > > So it has to be done manually by flag '-msee'. > > Added support of such specification to build-system. > > > > C

[Mesa-dev] [AppVeyor] mesa master #9162 completed

2018-10-26 Thread AppVeyor
Build mesa 9162 completed Commit 7e64e39f8b by Brian Paul on 10/26/2018 6:34 PM: nir: Fix array initializer\n\nEmpty initializer is not standard C. This fixes MSVC build.\n\nTrivial. Configure your notification preferences __

[Mesa-dev] [PATCH 3/3] anv: Add a userspace timeline implementation based on BOs

2018-10-26 Thread Jason Ekstrand
This allows us to implement non-exportable timeline semaphores with BOs that will work on as old a kernel as we like. --- src/intel/vulkan/anv_private.h | 23 src/intel/vulkan/anv_queue.c | 187 + 2 files changed, 210 insertions(+) diff --git a/src/intel/vu

[Mesa-dev] [PATCH 0/3] anv: Add a BO-based timeline implementation

2018-10-26 Thread Jason Ekstrand
The upcoming timeline semaphore extension will require kernel support in order to be able to share timeline semaphores between processes. However, we can fake it reasonably well with a userspace list of BOs and time points. The third patch is such an implementation in the Intel driver. The first

[Mesa-dev] [PATCH 2/3] anv: Use absolute timeouts in wait_for_bo_fences

2018-10-26 Thread Jason Ekstrand
We were previously using relative timeouts and decrementing the user-provided timeout as we waited. Instead, this commit refactors things to use absolute timeouts throughout. This should fix a subtle bug in the waitAll case where we aren't decrementing the timeout after a successful GPU wait. Si

[Mesa-dev] [PATCH 1/3] anv: Flag semaphore BOs as external

2018-10-26 Thread Jason Ekstrand
It probably doesn't actually break anything but it does cause some assertions in debug builds. Fixes: 7a89a0d9edae6 "anv: Use separate MOCS settings for external BOs" --- src/intel/vulkan/anv_queue.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_que

[Mesa-dev] [PATCH] anv: Improve the asserts in anv_buffer_get_range

2018-10-26 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 25e290ed112..d8a08d9d67f 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -1705,7 +1705,

Re: [Mesa-dev] [PATCH 07/31] nir/opt_if: Rework condition propagation

2018-10-26 Thread Jose Fonseca
On 22/10/18 23:13, Jason Ekstrand wrote: > Instead of doing our own constant folding, we just emit instructions and > let constant folding happen. This is substantially simpler and lets us > use the nir_imm_bool helper instead of dealing with the const_value's > ourselves. > --- > src/compiler/n

Re: [Mesa-dev] [PATCH 2/2] anv: Return VK_ERROR_DEVICE_LOST from anv_device_set_lost

2018-10-26 Thread Eric Engestrom
On Friday, 2018-10-26 11:42:12 -0500, Jason Ekstrand wrote: > This lets us get rid of a bunch of duplicated error messages. Better than mine :P Reviewed-by: Eric Engestrom > --- > src/intel/vulkan/anv_device.c | 50 +++--- > src/intel/vulkan/anv_private.h | 7 +++--

Re: [Mesa-dev] [PATCH mesa] anv: set error in anv_device_set_lost()

2018-10-26 Thread Eric Engestrom
On Friday, 2018-10-26 12:39:25 -0500, Jason Ekstrand wrote: > I sent two patches for this an hour ago Oops, should've checked before sending mine :) Your solution is cleaner; r-b > > On Fri, Oct 26, 2018 at 12:31 PM Eric Engestrom > wrote: > > > This de-duplicates the error messages. > > >

Re: [Mesa-dev] [PATCH 1/2] anv/util: Split a vk_errorv helper out of vk_errorf

2018-10-26 Thread Lionel Landwerlin
Awesome, thanks for doing this. This series is : Reviewed-by: Lionel Landwerlin On 26/10/2018 17:42, Jason Ekstrand wrote: --- src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/anv_util.c| 23 +-- 2 files changed, 25 insertions(+), 6 deletions(-) diff

Re: [Mesa-dev] [PATCH 00/31] nir: Use a 1-bit data type for booleans

2018-10-26 Thread Jason Ekstrand
Thanks! I've pushed the first 13. On Mon, Oct 22, 2018 at 6:06 PM Ian Romanick wrote: > Patches 1 through 13 are > > Reviewed-by: Ian Romanick > > The rest are going to take a bit more time and deep thought. > > On 10/22/2018 03:13 PM, Jason Ekstrand wrote: > > This is something that Connor an

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-26 Thread Matt Turner
On Fri, Oct 26, 2018 at 3:06 AM Sergii Romantsov wrote: > > While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. > So it has to be done manually by flag '-msee'. > Added support of such specification to build-system. > > CC: Dylan Baker > Bugzilla: https://bugs.freedesktop.org/s

[Mesa-dev] [AppVeyor] mesa master #9159 failed

2018-10-26 Thread AppVeyor
Build mesa 9159 failed Commit 5bcf479524 by Nanley Chery on 10/25/2018 9:08 PM: intel/blorp: Define the clear value bounds for HiZ clears\n\nFollow the restriction of making sure the clear value is between the min\nand max values defined in CC_VIEWPORT. Avoids

Re: [Mesa-dev] [PATCH mesa] anv: set error in anv_device_set_lost()

2018-10-26 Thread Jason Ekstrand
I sent two patches for this an hour ago On Fri, Oct 26, 2018 at 12:31 PM Eric Engestrom wrote: > This de-duplicates the error messages. > > Signed-off-by: Eric Engestrom > --- > Kinda hacky, so I won't take it personally if I get a "heck no!" :P > --- > src/intel/vulkan/anv_device.c | 27

Re: [Mesa-dev] [PATCH] scons/svga: remove opt from the list of valid build types

2018-10-26 Thread Jose Fonseca
Looks great. Reviewed-by: Jose Fonseca On 26/10/18 17:52, Brian Paul wrote: > This reverts commit a5fd54f8bf6713312fa5efd7ef5cd125557a0ffe. > > The whole point was to add a way to pass -DVMX86_STATS to the build, > but we can do that with a command line argument when we invoke scons. > --- >

[Mesa-dev] [PATCH mesa] anv: set error in anv_device_set_lost()

2018-10-26 Thread Eric Engestrom
This de-duplicates the error messages. Signed-off-by: Eric Engestrom --- Kinda hacky, so I won't take it personally if I get a "heck no!" :P --- src/intel/vulkan/anv_device.c | 27 --- src/intel/vulkan/anv_private.h | 5 + src/intel/vulkan/anv_queue.c | 16 ---

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-26 Thread Nanley Chery
On Fri, Oct 26, 2018 at 12:02:58PM -0500, Jason Ekstrand wrote: > On Thu, Oct 25, 2018 at 6:25 PM wrote: > > > From: Nanley Chery > > > > Follow the restriction of making sure the clear value is between the min > > and max values defined in CC_VIEWPORT. Avoids a simulator warning for > > some pi

[Mesa-dev] [PATCH 09/14] util/gen_xmlpool: Use print function instad of sys.stderr.write

2018-10-26 Thread Dylan Baker
This ensures that stderr is flushed, unlike writing --- src/util/xmlpool/gen_xmlpool.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py index 70e0f96df9e..9d932f3e85c 100644 --- a/src/util/xmlpool/gen_xm

[Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

2018-10-26 Thread Dylan Baker
This is a little cleaner than just looking at sys.argv, but it's also going to allow us to handle the differences in the way meson and autotools handle translations more cleanly. Reviewed-by: Eric Engestrom --- src/util/xmlpool/gen_xmlpool.py | 20 +--- 1 file changed, 9 insertio

[Mesa-dev] [PATCH 02/14] meson: add support for generating translation mo files

2018-10-26 Thread Dylan Baker
Meson has handy a handy built-in module for handling gettext called i18n, this module works a bit differently than our autotools build does, namely it doesn't automatically generate translations instead it creates 3 new top level targets to run. These are: xmlpool-pot xmlpool-update-po xmlpool-gmo

[Mesa-dev] [PATCH 10/14] util/gen_xmlpool: use a main function

2018-10-26 Thread Dylan Baker
Again, just good style --- src/util/xmlpool/gen_xmlpool.py | 127 +--- 1 file changed, 66 insertions(+), 61 deletions(-) diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py index 9d932f3e85c..a39f9e9e2fa 100644 --- a/src/util/xmlpool/gen_xmlp

[Mesa-dev] [PATCH 07/14] docs/meson: Add note about update translations

2018-10-26 Thread Dylan Baker
--- docs/meson.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index ece64673107..51f661b6e0a 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -95,6 +95,13 @@ each configuration you want to build recommended in the documentation + +Autoto

[Mesa-dev] [PATCH 11/14] util/gen_xmlpool: use with statement to open file

2018-10-26 Thread Dylan Baker
Which ensures it is closed at the end of the scope. --- src/util/xmlpool/gen_xmlpool.py | 66 - 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py index a39f9e9e2fa..6a5dcee0a87 100644 --

[Mesa-dev] [PATCH 06/14] util/gen_xmlpool: Remove --meson option for gen_xmlpool

2018-10-26 Thread Dylan Baker
Autotools now uses the same layout as meson, and scons doesn't care, so remove the separate paths. --- src/util/Android.mk | 2 +- src/util/xmlpool/Makefile.am| 2 +- src/util/xmlpool/gen_xmlpool.py | 10 +++--- src/util/xmlpool/meson.build| 2 +- 4 files changed, 6 inse

[Mesa-dev] [PATCH 12/14] util/gen_xmlpool: Don't write via shell redirection

2018-10-26 Thread Dylan Baker
This is bad for a couple of reasons, but the worst is that it gets the shell involved. When the shell gets involved we can start running into problems with LANG, namely LANG=C. This is particularly obnoxious for translation files, since there is a very high likelyhood of running into unicode in the

[Mesa-dev] [PATCH 08/14] util/gen_xmlpool: Use more standard style

2018-10-26 Thread Dylan Baker
gen_xmlpool uses a style unlike the rest of mesa, spaces between function/method calls and the parens, strange whitespace to force lining up method calls, and some other whitespace stuff. Since I'm going to be doing some work in the file, I'm going to start cleaning those up. --- src/util/xmlpool/

[Mesa-dev] [PATCH 00/14] translations updates

2018-10-26 Thread Dylan Baker
This series has two distinct changes in it, but that would require enough rebasing to land on top of the other I didn't want to send the separately. The first change is to add support to meson to generate driric translations. This is the v2 of that, with changes requested by Emil addressed, namely

[Mesa-dev] [PATCH 13/14] util/gen_xmlpool: Don't use len to test for container emptiness

2018-10-26 Thread Dylan Baker
This is a very common python anti-pattern. Not using length allows us to go through faster C paths, but has the same meaning. --- src/util/xmlpool/gen_xmlpool.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpo

[Mesa-dev] [PATCH 05/14] autotools, android: Use meson layout (including .gmo)

2018-10-26 Thread Dylan Baker
This will allow autotools, meson, and android to use the same layout and options in the gen_xmlpool script. Scons doesn't care because windows doesn't support translations. v2: - Add this commit --- src/util/Android.mk | 6 +++--- src/util/xmlpool/Makefile.am | 12 +++- 2 files

[Mesa-dev] [PATCH 03/14] util/gen_xmlpool: Add a --meson switch

2018-10-26 Thread Dylan Baker
Meson won't put the .gmo files in the layout that python's gettext.translation() expects, so we need to handle them differently, this switch allows the script to load the files as meson lays them out v2: - Handle OSError as well as IOError, since that's what will happen in the meson case if

[Mesa-dev] [PATCH 04/14] meson: use meson generated translation files

2018-10-26 Thread Dylan Baker
This is a change from the current status-quo, namely to get dri-conf translations you now *must* run the meson generation scripts, even if you're building from an autotools generated tarball (an official release). v2: - use .gmo files in build dir, not source dir. --- src/util/xmlpool/meson.build

[Mesa-dev] [PATCH 14/14] util/gen_xmlpool: Make use of python's foreach loop

2018-10-26 Thread Dylan Baker
Instead of using a while loop with indexing. This is much cleaner. This requires some other small changes. --- src/util/xmlpool/gen_xmlpool.py | 57 - 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/

Re: [Mesa-dev] [PATCH] intel/blorp: Define the clear value bounds for HiZ clears

2018-10-26 Thread Jason Ekstrand
On Thu, Oct 25, 2018 at 6:25 PM wrote: > From: Nanley Chery > > Follow the restriction of making sure the clear value is between the min > and max values defined in CC_VIEWPORT. Avoids a simulator warning for > some piglit tests, one of them being: > > ./bin/depthstencil-render-miplevels 146 d=z

Re: [Mesa-dev] [PATCH] intel/compiler: Print message descriptor as immediate source

2018-10-26 Thread Sagar Ghuge
Hi, Thank you for sharing the following patch series. On 10/26/18 6:15 AM, Eero Tamminen wrote: > Hi, > > Toni had a working assembler in early 2017, but he had to stop working > on it because nobody reviewed the patches needed for the disassembler. > > Maybe his patch series for the disassemb

[Mesa-dev] [PATCH] scons/svga: remove opt from the list of valid build types

2018-10-26 Thread Brian Paul
This reverts commit a5fd54f8bf6713312fa5efd7ef5cd125557a0ffe. The whole point was to add a way to pass -DVMX86_STATS to the build, but we can do that with a command line argument when we invoke scons. --- common.py | 2 +- scons/gallium.py | 8 ++

[Mesa-dev] [AppVeyor] mesa master #9156 failed

2018-10-26 Thread AppVeyor
Build mesa 9156 failed Commit 5cdeefe057 by Jason Ekstrand on 10/19/2018 5:06 PM: intel/nir: Use the OPT macro for more passes\n\nReviewed-by: Ian Romanick Configure your notification preferences ___ mesa-

[Mesa-dev] [PATCH 1/2] anv/util: Split a vk_errorv helper out of vk_errorf

2018-10-26 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/anv_util.c| 23 +-- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index a3ab971b6fd..c5d636fef8d 100644 --- a/src/intel/vulka

[Mesa-dev] [PATCH 2/2] anv: Return VK_ERROR_DEVICE_LOST from anv_device_set_lost

2018-10-26 Thread Jason Ekstrand
This lets us get rid of a bunch of duplicated error messages. --- src/intel/vulkan/anv_device.c | 50 +++--- src/intel/vulkan/anv_private.h | 7 +++-- src/intel/vulkan/anv_queue.c | 16 +++ src/intel/vulkan/genX_query.c | 4 +-- 4 files changed, 32 inserti

Re: [Mesa-dev] [PATCH 2/2] kmsro: Extend to include hx8357d.

2018-10-26 Thread Eric Anholt
Eric Engestrom writes: > On Thursday, 2018-10-25 09:39:10 -0700, Eric Anholt wrote: >> This allows vc4 to initialize on the Adafruit PiTFT 3.5" touchscreen with >> the new tinydrm driver I just submitted. If this series extending the >> pl111/kmsro driver is accepted, then I'll extend kmsro with

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-26 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > CC'ing Matt and Emil. > > This will make the code non-portable from an SSE capable system to a non-sse > capable system. That's a pretty old system at this point (Pentium III and > Athlon > XP), and I don't personaly care, but it's quite possi

[Mesa-dev] [Bug 108565] Rise of the Tomb Raider SIGSEGV in LLVM 7.0.0

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108565 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Status|NEW |RESOLVED R

Re: [Mesa-dev] [Mesa-stable] [PATCH mesa 1/4] meson: turn git_sha1.h target into a proper dependency

2018-10-26 Thread Dylan Baker
Quoting Eric Engestrom (2018-10-25 09:44:14) > On Tuesday, 2018-10-02 13:44:07 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-10-02 07:09:03) > > > Cc: mesa-sta...@lists.freedesktop.org > > > Signed-off-by: Eric Engestrom > > > --- > > > src/mesa/meson.build | 3 +-- > > > src/meson.

Re: [Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-26 Thread Dylan Baker
CC'ing Matt and Emil. This will make the code non-portable from an SSE capable system to a non-sse capable system. That's a pretty old system at this point (Pentium III and Athlon XP), and I don't personaly care, but it's quite possible that distros do care. What do you guys think? Dylan Quotin

Re: [Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

2018-10-26 Thread Dylan Baker
I don't really understand what happened, but the rest of the series sent as blank emails, mailman got very grumpy with me and gave me a temp ban for it :/ I'll resend the whole series with your rb on this patch. Dylan Quoting Eric Engestrom (2018-10-26 04:30:01) > On Thursday, 2018-10-25 13:12:0

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Lionel Landwerlin
On 26/10/2018 15:34, Toni Lönnberg wrote: On Fri, Oct 26, 2018 at 03:15:50PM +0100, Lionel Landwerlin wrote: On 26/10/2018 15:06, Toni Lönnberg wrote: - Forwarded message from Toni Lönnberg - Date: Fri, 26 Oct 2018 17:03:54 +0300 From: Toni Lönnberg To: Lionel Landwerlin Message-ID:

Re: [Mesa-dev] [PATCH v2] intel/tools: fix resource leak

2018-10-26 Thread Lionel Landwerlin
On 26/10/2018 15:29, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit Some memory and file descriptors are not freed/closed. v2: fixed case where we skipped the 'aub' variable initialization Signed-off-by: Andrii Simiklit Still : Reviewed-by: Lionel Landwerlin Thanks! --- sr

Re: [Mesa-dev] [PATCH] intel/tools: fix resource leak

2018-10-26 Thread andrey simiklit
Hello, Thanks a lot for reviewing and for quick reply. Sorry, I forgot ( I thought that it impossible to have the feedback in a 10 minutes on Friday :-) ) to update my inbox and sent version v2, I guess that I fix small issue in v2: - aub_file_finish(&aub); + if(aub.file) { + aub_file_fin

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Toni Lönnberg
On Fri, Oct 26, 2018 at 03:15:50PM +0100, Lionel Landwerlin wrote: > On 26/10/2018 15:06, Toni Lönnberg wrote: > > - Forwarded message from Toni Lönnberg - > > > > Date: Fri, 26 Oct 2018 17:03:54 +0300 > > From: Toni Lönnberg > > To: Lionel Landwerlin > > Message-ID: <20181026140354.gd3

[Mesa-dev] [PATCH v2] intel/tools: fix resource leak

2018-10-26 Thread asimiklit . work
From: Andrii Simiklit Some memory and file descriptors are not freed/closed. v2: fixed case where we skipped the 'aub' variable initialization Signed-off-by: Andrii Simiklit --- src/intel/tools/error2aub.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/intel/tools/error2a

Re: [Mesa-dev] [PATCH] intel/tools: fix resource leak

2018-10-26 Thread Lionel Landwerlin
On 26/10/2018 15:11, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit Some memory and file descriptors are not freed/closed. Thanks a lot : Reviewed-by: Lionel Landwerlin Signed-off-by: Andrii Simiklit --- src/intel/tools/error2aub.c | 6 ++ 1 file changed, 6 insertions(+

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Lionel Landwerlin
On 26/10/2018 15:06, Toni Lönnberg wrote: - Forwarded message from Toni Lönnberg - Date: Fri, 26 Oct 2018 17:03:54 +0300 From: Toni Lönnberg To: Lionel Landwerlin Message-ID: <20181026140354.gd3...@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Mesa-dev] [PATCH] intel/de

[Mesa-dev] [PATCH] intel/tools: fix resource leak

2018-10-26 Thread asimiklit . work
From: Andrii Simiklit Some memory and file descriptors are not freed/closed. Signed-off-by: Andrii Simiklit --- src/intel/tools/error2aub.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c index 8a23d5ef1e..451fd8c74a 100644 --

[Mesa-dev] [Bug 108565] Rise of the Tomb Raider SIGSEGV in LLVM 7.0.0

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108565 --- Comment #2 from Alex Smith --- Possibly fixed by https://gitlab.freedesktop.org/mesa/mesa/commit/ca83d51cfb154af12ee6e17a533df6cbbc890e22 which didn't make 18.2.3. Could you try that? I saw some similar backtraces while debugging that, due t

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Toni Lönnberg
- Forwarded message from Toni Lönnberg - Date: Fri, 26 Oct 2018 17:03:54 +0300 From: Toni Lönnberg To: Lionel Landwerlin Message-ID: <20181026140354.gd3...@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields

[Mesa-dev] [Bug 108565] Rise of the Tomb Raider SIGSEGV in LLVM 7.0.0

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108565 --- Comment #1 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- Created attachment 142220 --> https://bugs.freedesktop.org/attachment.cgi?id=142220&action=edit gdb backtrace 2.txt -- You are receiving this mail because: You are the assignee for t

[Mesa-dev] [Bug 108565] Rise of the Tomb Raider SIGSEGV in LLVM 7.0.0

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108565 Bug ID: 108565 Summary: Rise of the Tomb Raider SIGSEGV in LLVM 7.0.0 Product: Mesa Version: 18.2 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 107601] Rise of the Tomb Raider Segmentation Fault when the game starts

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107601 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added CC||0xe2.0x9a.0...@gmai

Re: [Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Lionel Landwerlin
Overall I agree this probably what we should do rather than this long special case switch in gen_group_get_length(). I have one suggestion below. On 26/10/2018 14:07, Toni Lönnberg wrote: Use the 'DWord Length' and 'bias' fields from the instruction definition to parse the packet length from th

Re: [Mesa-dev] [PATCH] intel/compiler: Print message descriptor as immediate source

2018-10-26 Thread Eero Tamminen
Hi, Toni had a working assembler in early 2017, but he had to stop working on it because nobody reviewed the patches needed for the disassembler. Maybe his patch series for the disassembly output still has something useful for your assembler: * i965 shader disassembly label support: htt

[Mesa-dev] [PATCH] intel/decoder: Use 'DWord Length' and 'bias' fields for packet length.

2018-10-26 Thread Toni Lönnberg
Use the 'DWord Length' and 'bias' fields from the instruction definition to parse the packet length from the command stream when possible. The hardcoded mechanism is used whenever an instruction doesn't have this field. --- src/intel/common/gen_decoder.c | 16 ++-- src/intel/common/gen

Re: [Mesa-dev] [PATCH 3/3] anv: Handle the device loss abort in anv_device_set_lost

2018-10-26 Thread Eric Engestrom
On Thursday, 2018-10-25 11:46:57 -0500, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 11 +++ > src/intel/vulkan/anv_util.c | 4 > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > ind

Re: [Mesa-dev] [PATCH 2/2] kmsro: Extend to include hx8357d.

2018-10-26 Thread Eric Engestrom
On Thursday, 2018-10-25 09:39:10 -0700, Eric Anholt wrote: > This allows vc4 to initialize on the Adafruit PiTFT 3.5" touchscreen with > the new tinydrm driver I just submitted. If this series extending the > pl111/kmsro driver is accepted, then I'll extend kmsro with the other > tinydrm drivers a

Re: [Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

2018-10-26 Thread Eric Engestrom
On Thursday, 2018-10-25 13:12:04 -0700, Dylan Baker wrote: > This is a little cleaner than just looking at sys.argv, but it's also > going to allow us to handle the differences in the way meson and > autotools handle translations more cleanly. Can't see the rest of this series (it's not in the mai

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

2018-10-26 Thread Daniel Vetter
On Fri, Oct 26, 2018 at 1:08 PM Daniel Stone wrote: > > Hi, > > On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote: > > On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote: > > > On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote: > > > > On Wed, Oct 17, 2018 at 2:05 PM Danie

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-26 Thread Erik Faye-Lund
On Thu, 2018-10-25 at 10:45 -0400, Ilia Mirkin wrote: > Please confirm that this passes the piglit tests you sent to the list > when run with ES2 forced, i.e. not ES3. > (MESA_GLES_VERSION_OVERRIDE=2.0 iirc.) I'm concerned that the extra > logic was only added to _mesa_es3_error_check_bla and not t

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

2018-10-26 Thread Daniel Stone
Hi, On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote: > On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote: > > On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote: > > > On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote: > > > > Yeah, I think it makes sense. Some things

Re: [Mesa-dev] [RFC] Allow fd.o to join forces with X.Org

2018-10-26 Thread Daniel Vetter
On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote: > On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote: > > On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote: > > > > > > On Tue, 16 Oct 2018 at 08:17, Peter Hutterer > > > wrote: > > > > On Mon, Oct 15, 2018 at 10:49:24A

[Mesa-dev] [Bug 103312] meson/macOS: Dependency libdrm_intel found: NO

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103312 --- Comment #5 from Yurii Kolesnykov --- I can successfully build mesa under macOS 10.14 (Mojave). -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [Bug 103312] meson/macOS: Dependency libdrm_intel found: NO

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103312 Yurii Kolesnykov changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] nir: Divergence Analysis

2018-10-26 Thread Daniel Schürmann
Hi Ian, thank you very much for the detailed suggestions. I added the formatting to adhere the coding conventions. Please remind that this is an RFC, not a pull request. The implementation is incomplete and not meant to go upstream in this state. And while I added some, there are still a lot of

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/1] util: Change remaining uint32 cache ids to sha1

2018-10-26 Thread Juan A. Suarez Romero
On Fri, 2018-10-26 at 14:52 +1100, Timothy Arceri wrote: > Pushed. Thanks again! > > Ccing stable in case the Fixes tag isnt enough for this to get picked up > (since the previous cache fix this fixes was also backported) > Enqueued for 18.2. I didn't apply cleanly, so I've fixed the conflicts.

[Mesa-dev] [Bug 108560] Mesa 32 is built without sse

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108560 --- Comment #1 from Sergii Romantsov --- Patch series for meson and autoconf: https://patchwork.freedesktop.org/series/51585/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [PATCH v1 4/5] autotools: library-dependency when no sse and 32-bit

2018-10-26 Thread Sergii Romantsov
Building of 32bit Mesa may fail if __SSE__ is not specified. Added missed dependency from libm. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 Signed-off-by: Sergii Romantsov --- src/util/Makefile.am | 5 + 1 file changed, 5 insertions(+) diff --git a/src/uti

[Mesa-dev] [PATCH v1 3/5] autotools: compilation flags for sse

2018-10-26 Thread Sergii Romantsov
While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. So it has to be done manually by flag '-msee'. Added support of such specification to build-system. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 Signed-off-by: Sergii Romantsov --- configure.

[Mesa-dev] [PATCH v1 2/5] meson: specify -msse manually for 32-bit build

2018-10-26 Thread Sergii Romantsov
While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. So it has to be done manually by flag '-msee'. Added support of such specification to build-system. That enables optimization for file src/util/rounding.h. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id

[Mesa-dev] [PATCH v1 1/5] meson: compilation flags for sse

2018-10-26 Thread Sergii Romantsov
While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. So it has to be done manually by flag '-msee'. Added support of such specification to build-system. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560 Signed-off-by: Sergii Romantsov --- meson.buil

[Mesa-dev] [PATCH v1 5/5] autotools: specify -msse manually for 32-bit build

2018-10-26 Thread Sergii Romantsov
While building of 32bit Mesa gcc doesn't specifies __SSE__ by default. So it has to be done manually by flag '-msee'. Added support of such specification to build-system. That enables optimization for file src/util/rounding.h. CC: Dylan Baker Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id

[Mesa-dev] [Bug 108560] Mesa 32 is built without sse

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108560 Bug ID: 108560 Summary: Mesa 32 is built without sse Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [Mesa-dev] [PATCH] anv: Fix sanitization of stencil state when the depth test is disabled

2018-10-26 Thread Alex Smith
Good point, I didn't notice they were both now doing the same thing. Merged them together and pushed. On Thu, 25 Oct 2018 at 18:00, Jason Ekstrand wrote: > Maybe we should just roll the depthTestEnable check in with the ds_aspects > & VK_IMAGE_ASPECT_DEPTH_BIT check right below it. In either ca

[Mesa-dev] [Bug 107765] [regression] Batman Arkham City crashes with DXVK under wine

2018-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107765 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

Re: [Mesa-dev] [PATCH v3 1/2] i965/batch: avoid reverting batch buffer if saved state is an empty

2018-10-26 Thread andrey simiklit
Hi, Could you please help me with a push. I don't have a right for it :-) Thanks, Andrii. On Thu, Oct 11, 2018 at 9:22 PM Jordan Justen wrote: > On 2018-10-11 03:01:56, andrey simiklit wrote: > > Hello, > > > > Thanks for reviewing. > > Please find my comment below. > > > > On Thu, Oct 11, 201