On 28/9/18 2:53 am, Tom Stellard wrote:
On 09/24/2018 11:51 PM, Samuel Pitoiset wrote:
On 9/25/18 6:46 AM, Timothy Arceri wrote:
On 25/9/18 10:35 am, Marek Olšák wrote:
Do you know what's broken in LLVM? Or is it a problem with the ISA?
I haven't actually dug any further. Adding Samuel to
https://bugs.freedesktop.org/show_bug.cgi?id=108082
--- Comment #2 from Vinson Lee ---
The warnings appear with autotools.
./autogen.sh --disable-egl --with-dri-drivers=swrast
--with-gallium-drivers=swrast --with-platforms=x11
$ clang --version
Apple LLVM version 10.0.0 (clang-1000.10.44.2)
Tar
On 2018-09-26 10:40 AM, boyuan.zh...@amd.com wrote:
From: Boyuan Zhang
The previous array logic for converting pipe video profile to profile idc
relies on the order of pipe_video_profile enum defines. Adding new profile
to enum defines may break the logic. Therefore, it's better to use switch
https://bugs.freedesktop.org/show_bug.cgi?id=108087
Jan Vesely changed:
What|Removed |Added
Blocks||99553
--- Comment #1 from Jan Vesely ---
https://bugs.freedesktop.org/show_bug.cgi?id=99553
Jan Vesely changed:
What|Removed |Added
Depends on||108087
Referenced Bugs:
https://bugs.free
This series fixes the assert I was encountering with SteamVR here:
https://bugs.freedesktop.org/show_bug.cgi?id=108065
Thanks for the fixes.
-Andres
On 2018-09-22 05:39 PM, Jason Ekstrand wrote:
This little series fixes three bugs encountered while running the Vulkan
CTS with SPIR-V optimizat
https://bugs.freedesktop.org/show_bug.cgi?id=108065
--- Comment #1 from Andres Rodriguez ---
Issue resolved by:
https://patchwork.freedesktop.org/series/50059/
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.__
On 09/24/2018 11:51 PM, Samuel Pitoiset wrote:
>
>
> On 9/25/18 6:46 AM, Timothy Arceri wrote:
>> On 25/9/18 10:35 am, Marek Olšák wrote:
>>> Do you know what's broken in LLVM? Or is it a problem with the ISA?
>>
>> I haven't actually dug any further. Adding Samuel to see if he remembers
>> more
Since LLVM 7.0 has already been released:
Reviewed-by: Marek Olšák
Marek
On Tue, Sep 25, 2018 at 12:46 AM Timothy Arceri wrote:
>
> On 25/9/18 10:35 am, Marek Olšák wrote:
> > Do you know what's broken in LLVM? Or is it a problem with the ISA?
>
> I haven't actually dug any further. Adding Samu
Fixes:
* fbo-blit-check-limits
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108088
Signed-off-by: Vadym Shovkoplias
---
src/intel/blorp/blorp.h | 8 ++--
src/intel/blorp/blorp_blit.c | 8 ++--
src/mesa/drivers/dri/i965/brw_blorp.c | 20 ---
https://bugs.freedesktop.org/show_bug.cgi?id=108087
Bug ID: 108087
Summary: Memory leak in clover::kernel::argument::create<>()
(i.e. clEnqueueNDRangeKernel())
Product: Mesa
Version: 18.1
Hardware: Other
OS:
https://bugs.freedesktop.org/show_bug.cgi?id=107457
--- Comment #1 from jeckfer...@gmail.com ---
https://bugs.freedesktop.org/show_bug.cgi?id=108086
Kindly look into it.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug._
On September 26, 2018 11:48:25 PM UTC, Caio Marcelo de Oliveira Filho
wrote:
> Hi,
>
> I was a bit unsure about where to send Crucible(*) patches, neither
> README or HACKING file has the answer. In #dri-devel channel people
> were also not sure. I've ended up sending to piglit mailing list,
https://bugs.freedesktop.org/show_bug.cgi?id=108082
--- Comment #1 from Illia ---
I haven't got this warning at this commit. I used these meson parameters:
1. meson -Dbuildtype=debug -Dvalgrind=false -Ddri-drivers=i965
-Dgallium-drivers= -Dvulkan-drivers= -Dgallium-omx="disabled"
-Dplatforms=
This can happens if we are running an SPIR-V shader (ARB_gl_spirv).
---
src/mesa/main/shader_query.cpp | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp
index 11ecd71c575..b775b4231c2
From: Antia Puentes
---
src/compiler/glsl/gl_nir_linker.c | 79 +++
1 file changed, 79 insertions(+)
diff --git a/src/compiler/glsl/gl_nir_linker.c
b/src/compiler/glsl/gl_nir_linker.c
index 138a12e532d..acec0fe1f03 100644
--- a/src/compiler/glsl/gl_nir_linke
Since ARB_gl_spirv it is possible to miss a lot of name reflection
information, so it is needed to add NULL name checks for several
queries, and return a specific value on those cases. This commit add
them for ACTIVE_UNIFORM_BLOCK_MAX_NAME_LENGTH,
ACTIVE_ATTRIBUTE_MAX_LENGTH and ACTIVE_UNIFORM_MAX_
From: Antia Puentes
Binding comparison is used to determine the block the uniform is part
of. To do the binding comparison we need the information in
UniformBlocks[] and ShaderStorageBlocks[] to be available, so we have
to call gl_nir_link_uniform_blocks() before linking the uniforms.
---
src/co
The function had a mix of true/GL_TRUE and false/GL_FALSE
returns. Using GL_TRUE/GL_FALSE as the function returns a GLboolean.
---
src/mesa/drivers/dri/i965/brw_link.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp
b/src/mesa/dri
When using a SPIR-V shader. Note that needs to be done before linking
uniforms, so when creating the uniform storage entries, block_index
could be filled properly (among other things).
---
src/mesa/drivers/dri/i965/brw_link.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drive
---
src/compiler/glsl/gl_nir_linker.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/compiler/glsl/gl_nir_linker.c
b/src/compiler/glsl/gl_nir_linker.c
index 547549bc4e0..138a12e532d 100644
--- a/src/compiler/glsl/gl_nir_linker.c
+++ b/src/compiler/glsl/gl_nir_linker.c
@@
Until now, we were using the uniform explicit location to check if the
current nir variable already was processed, and entries on the uniform
storage added. But for UBOs/SSBOs, entries are added but we lack a
explicit location.
For those we need to rely on the UBO/SSBO binding (to the nir variable
From ARB_gl_spirv:
"Mapping of layouts
std140/std430 -> explicit *Offset*, *ArrayStride*, and *MatrixStride*
Decoration on struct members"
That means that we would not have available any kind of layout info,
and we should use explicit array strides.
This comm
---
src/compiler/glsl/gl_nir_link_uniforms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/gl_nir_link_uniforms.c
b/src/compiler/glsl/gl_nir_link_uniforms.c
index 1a491dc2e5d..00995fb3f76 100644
--- a/src/compiler/glsl/gl_nir_link_uniforms.c
+++ b/src/com
For this interfaces, the inner members are added only once as uniforms
or resources, in opposite to other cases, like a uniform array of
structs.
For those guessing why a issue (16) from ARB_program_interface_query
was used, instead of a quote of the core spec: The core spec is not
really clear ab
---
src/compiler/spirv/spirv_to_nir.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/compiler/spirv/spirv_to_nir.c
index 101e2b0bf02..02de2f640c1 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -798,6 +79
From: Neil Roberts
When linking a program using ARB_gl_spirv it now lowers the
vulkan_resource_index intrinsic as an extra pass on the nir shader.
Unlike Vulkan this can be done without waiting for the extra state
from the pipeline layout.
It also adds the call to this lowering on the i965 drive
Equivalent to the already existing ir_variable is_in_buffer_block and
is_in_shader_storage_block, adding the uniform buffer object one. I'm
using the short forms (ssbo, ubo) to avoid having method names too
long.
---
src/compiler/nir/nir.h | 22 ++
1 file changed, 22 insertions
Specifically, offset, array_stride, matrix_stride and row_major.
On GLSL, most of that info is computed, but on ARB_gl_spirv they are
explicit, and for Mesa, included on the glsl_type.
From ARB_gl_spirv spec:
"Mapping of layouts
std140/std430 -> explicit *Offset*, *ArrayStride*, and
We need all the info when asking for the type, so we needed to call
type_decoration_cb earlier, in order to get the ArrayStride.
It is somewhat ugly to do this only for Array types, but we can't do
it before the switch as type_decoration_cb have some asserts to ensure
that the type and the decorat
Adding the ability to link uniform blocks and shader storage blocks
using NIR, intended for ARB_gl_spirv support. Among other things, this
linking needs to take into account that everything should work without
names, as they could be not present, while the GLSL IR uniform block
linking was wrote wi
From: Neil Roberts
In order to replicate the behaviour of lower_ubo_reference_visitor,
the lowering code should search the list of blocks in
ShaderStorageBlocks for the matching binding whenever a non-ubo usage
of the resource index is encountered.
The intended usage of the vulkan_resource_index
Hi,
this is the second version of the ubo/ssbo support for ARB_gl_spirv
series. Differences compared with v1:
* Rebased against today master.
* Patch "nir/linker: use only the array element type for array of
ssbo/ubo" got a proper spec quote.
* Two extra patches are included. They are
They are supported by SPIR-V for OpenGL. OpenGL codepath expect nir to
include the ssbo as nir variables.
---
src/compiler/spirv/vtn_variables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/vtn_variables.c
b/src/compiler/spirv/vtn_variables.c
index ba
They are supported by SPIR-V for ARB_gl_spirv.
---
src/compiler/spirv/vtn_variables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/vtn_variables.c
b/src/compiler/spirv/vtn_variables.c
index 358ff4bef7a..ba1b8816038 100644
--- a/src/compiler/spirv/vtn_
To already existing fields on glsl_types. Specifically:
* glsl_get_struct_field_offset
* glsl_get_struct_field_matrix_layout
* glsl_type_arrays_of_arrays_size
---
src/compiler/nir_types.cpp | 21 +
src/compiler/nir_types.h | 8
2 files changed, 29 insertion
From ARB_gl_spirv spec:
"7.6.2.spv SPIR-V Uniform Offsets and Strides
The SPIR-V decorations *GLSLShared* or *GLSLPacked* must not be
used. A variable in the *Uniform* Storage Class decorated as a
*Block* must be explicitly laid out using the *Offset*,
*ArrayStride*, and *Matr
---
src/compiler/spirv/spirv_to_nir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/compiler/spirv/spirv_to_nir.c
index 15a3e8cce9a..101e2b0bf02 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -725,6 +725,7 @@
From: Neil Roberts
Previously the code was taking any location decoration on the block
and using that to calculate the member locations for all of the
members. I think this was assuming that there would only be one
location decoration for the entire block. According to the Vulkan spec
it is possi
vnt_variables uses interface_type on several use cases, but on nir
variable it is more limited. From nir.h:
/**
* For variables that are in an interface block or are an instance of an
* interface block, this is the \c GLSL_TYPE_INTERFACE type for that block.
*
* \sa ir_varia
Some nir variables are only filled up for some specific modes. We
found to need the binding for ubos/ssbos.
The comment before that code (starts with XXX) points that binding
still needs to be filled up for uniform variables at that point, and
that should be fixed, although it doesn't specify why
From ARB_gl_spirv spec:
"Mapping of layouts
std140/std430 -> explicit *Offset*, *ArrayStride*, and
*MatrixStride* Decoration on struct members"
and
"A variable in the *Uniform* Storage Class decorated as a *Block*
must be explicitly laid out using the *Offset*
Right now, a type is considered a ubo/ssbo if the mode is
uniform/shader_storage and the interface_type is different to
NULL. See ir_variable::in_in_buffer_block as an example.
---
src/compiler/spirv/vtn_variables.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/sr
Hi,
Please find my comment below:
Regards,
Andrii.
On Wed, Sep 26, 2018 at 6:39 PM Eric Engestrom
wrote:
> Signed-off-by: Eric Engestrom
> ---
> src/vulkan/wsi/wsi_common_display.c | 95 -
> 1 file changed, 94 insertions(+), 1 deletion(-)
>
> diff --git a/src/vulk
https://bugs.freedesktop.org/show_bug.cgi?id=108024
Stuart Young changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
45 matches
Mail list logo
