Re: [Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

2018-07-21 Thread Gert Wollny
Am Samstag, den 21.07.2018, 14:14 -0400 schrieb Ilia Mirkin: > On Sat, Jul 21, 2018 at 1:48 PM, Gert Wollny om> wrote: > > Am Samstag, den 21.07.2018, 11:33 -0400 schrieb Ilia Mirkin: > > > > > > > > > On Sat, Jul 21, 2018, 05:45 Gert Wollny > > m> > > > wrote: > > > > Am Freitag, den 20.07.201

[Mesa-dev] [PATCH 2/2] i965/disk_cache: Add in the INTEL_DEBUG value to the renderer string

2018-07-21 Thread Jordan Justen
Since various options within INTEL_DEBUG could impact code generation, we should add this into the renderer string so changing the INTEL_DEBUG setting will cause the shader cache to work properly. An example that will affect the program generated by i965 is the INTEL_DEBUG=nocompact option. Addin

[Mesa-dev] [PATCH 1/2] i965/disk_cache: Add extra unused character in renderer temp string

2018-07-21 Thread Jordan Justen
This extra character should not be used by snprintf, but we make it available to verify that we printed the exact number we wanted, and didn't overflow. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --

[Mesa-dev] [PATCH] draw: force draw pipeline if there's more than 65535 vertices

2018-07-21 Thread sroland
From: Roland Scheidegger The pt emit path can only handle 65535 - the number of vertices is truncated to a ushort, resulting in a too small buffer allocation, which will crash. Forcing the pipeline path looks suboptimal, then again this bug is probably there ever since GS is supported, so it see

Re: [Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

2018-07-21 Thread Ilia Mirkin
On Sat, Jul 21, 2018 at 1:48 PM, Gert Wollny wrote: > Am Samstag, den 21.07.2018, 11:33 -0400 schrieb Ilia Mirkin: >> >> >> On Sat, Jul 21, 2018, 05:45 Gert Wollny >> wrote: >> > Am Freitag, den 20.07.2018, 12:31 -0400 schrieb Ilia Mirkin: >> > > >> > > > + /* Allow 3-comp 32 bit texturs only f

Re: [Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

2018-07-21 Thread Gert Wollny
Am Samstag, den 21.07.2018, 11:33 -0400 schrieb Ilia Mirkin: > > > On Sat, Jul 21, 2018, 05:45 Gert Wollny > wrote: > > Am Freitag, den 20.07.2018, 12:31 -0400 schrieb Ilia Mirkin: > > > > > > > + /* Allow 3-comp 32 bit texturs only for TBOs (needed for > > > > ARB_tbo_rgb32) */ > > > > + i

Re: [Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

2018-07-21 Thread Ilia Mirkin
On Sat, Jul 21, 2018, 05:45 Gert Wollny wrote: > Am Freitag, den 20.07.2018, 12:31 -0400 schrieb Ilia Mirkin: > > > > > + /* Allow 3-comp 32 bit texturs only for TBOs (needed for > > > ARB_tbo_rgb32) */ > > > + if ((format == PIPE_FORMAT_R32G32B32_FLOAT || > > > + format == PIPE_FORMAT_

[Mesa-dev] [PATCH 2/2] nir: replace nir_load_system_value calls with appropiate builder functions

2018-07-21 Thread Karol Herbst
this helps reduce the overall code changes when a bit_size parameter is added to nir_load_system_value Reviewed-by: Jason Ekstrand Signed-off-by: Karol Herbst --- src/amd/vulkan/radv_meta_buffer.c| 8 src/amd/vulkan/radv_meta_bufimage.c | 16 --

[Mesa-dev] [PATCH 1/2] nir: add const_index parameters to system value builder function

2018-07-21 Thread Karol Herbst
this allows to replace some nir_load_system_value calls with the specific system value constructor Reviewed-by: Jason Ekstrand Signed-off-by: Karol Herbst --- src/compiler/nir/nir_builder_opcodes_h.py | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

2018-07-21 Thread Gert Wollny
Am Freitag, den 20.07.2018, 12:31 -0400 schrieb Ilia Mirkin: > > > + /* Allow 3-comp 32 bit texturs only for TBOs (needed for > > ARB_tbo_rgb32) */ > > + if ((format == PIPE_FORMAT_R32G32B32_FLOAT || > > + format == PIPE_FORMAT_R32G32B32_SINT || > > + format == PIPE_FORMAT_R32G32B3

Re: [Mesa-dev] [PATCH] android: util/disk_cache: fix building errors in gallium drivers

2018-07-21 Thread Bas Nieuwenhuizen
On Sat, Jul 21, 2018 at 11:32 AM, Mauro Rossi wrote: > This patch applies the necessary changes in Android.common.mk > as per automake rules, to avoid following building error: > > external/mesa/src/gallium/drivers/nouveau/nouveau_screen.c:159:8: > error: implicit declaration of function 'disk_cac

Re: [Mesa-dev] [PATCH] android: util/disk_cache: fix building errors in gallium drivers

2018-07-21 Thread Bas Nieuwenhuizen
ugh, yet another buildsystem. Reviewed-by: Bas Nieuwenhuizen On Sat, Jul 21, 2018 at 11:32 AM, Mauro Rossi wrote: > This patch applies the necessary changes in Android.common.mk > as per automake rules, to avoid following building error: > > external/mesa/src/gallium/drivers/nouveau/nouveau_scr

[Mesa-dev] [PATCH] android: util/disk_cache: fix building errors in gallium drivers

2018-07-21 Thread Mauro Rossi
This patch applies the necessary changes in Android.common.mk as per automake rules, to avoid following building error: external/mesa/src/gallium/drivers/nouveau/nouveau_screen.c:159:8: error: implicit declaration of function 'disk_cache_get_function_timestamp' is invalid in C99 [-Werror,-Wimplici