Commit 5fb69daa6076e56b deleted support from nir_print for printing the
texture and sampler indices on texture instructions. This commit just
brings it back as best as we can.
---
src/compiler/nir/nir_print.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/compiler/nir/nir_pr
anyway, I think it might make sense to take a look at the shaders hurt
most as I suspect there might be a way to improve the situation a
little
On Sat, Jul 7, 2018 at 3:38 AM, Karol Herbst wrote:
> okay right, if loading those special regs is indeed more expensive
> than doing the read + a few ex
okay right, if loading those special regs is indeed more expensive
than doing the read + a few extbf then I see the point of this
optimization
On Sat, Jul 7, 2018 at 2:46 AM, Ilia Mirkin wrote:
> Are they? Fewer special reg loads = better...
>
> On Fri, Jul 6, 2018 at 8:31 PM, Karol Herbst wrote
Are they? Fewer special reg loads = better...
On Fri, Jul 6, 2018 at 8:31 PM, Karol Herbst wrote:
> somehow it doesn't really look like that it is worth the effort as the
> generated shaders are worse in avg?
>
> On Fri, Jul 6, 2018 at 10:32 PM, Rhys Perry wrote:
>> This patch doesn't touch NTID
somehow it doesn't really look like that it is worth the effort as the
generated shaders are worse in avg?
On Fri, Jul 6, 2018 at 10:32 PM, Rhys Perry wrote:
> This patch doesn't touch NTID since it seems very difficult (or
> impossible) to generate. Seemingly because the state tracker or glsl
>
Looks good to me.
Reviewed-by: Neha Bhende
Regards,
Neha
From: Charmaine Lee
Sent: Friday, July 6, 2018 4:09:02 PM
To: mesa-dev@lists.freedesktop.org
Cc: Brian Paul; Neha Bhende; Charmaine Lee
Subject: [PATCH] st/wgl: check for NULL piAttribList in wglCreateP
On 07/05/2018 06:22 PM, Caio Marcelo de Oliveira Filho wrote:
> Reviewed-by: Caio Marcelo de Oliveira Filho
>
> Tested the patch with the shaders mentioned.
>
> Do you think would be worth to have a pass at NIR level to perform
> these transformations?
Possibly. In many cases, it is better to
On 07/06/2018 09:43 AM, Roland Scheidegger wrote:
> Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund:
>> OpenGL 4.4 and OpenGL ES 3.1 both require the maximum
>> vertex attrib stride to be at least 2048. If this isn't
>> the case, we shouldn't expose these API versions.
>>
>> Unfortunately, the r600 d
Assuming the concerns about patch 1 are resolved, patches 2 and 3 are
Reviewed-by: Ian Romanick
On 07/06/2018 03:03 AM, Erik Faye-Lund wrote:
> OpenGL 4.4 and OpenGL ES 3.1 both require the maximum
> vertex attrib stride to be at least 2048. If this isn't
> the case, we shouldn't expose these AP
https://bugs.freedesktop.org/show_bug.cgi?id=107146
Bug ID: 107146
Summary: swr doesn't compile with current LLVM 7.0 snapshots
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: norm
Java2d opengl pipeline passes NULL piAttribList to
wglCreatePbufferARB(). So skip parsing the attribute list
if it is NULL.
---
src/gallium/state_trackers/wgl/stw_ext_pbuffer.c | 80
1 file changed, 41 insertions(+), 39 deletions(-)
diff --git a/src/gallium/state_trackers
These buffer objects are never accessed with the CPU.
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index eee83a7a963..3a1d064e
For the series:
Reviewed-by: Marek Olšák
Marek
On Fri, Jul 6, 2018 at 6:03 AM, Erik Faye-Lund
wrote:
> The OpenGL 3.1 specification, table Table 20.41 ("Implementation
> Dependent Values"), defines the minimum-maximum value for
> MAX_VERTEX_ATTRIB_STRIDE to be 2048.
>
> So we shouldn't enable
Reviewed-by: Marek Olšák
Marek
On Fri, Jul 6, 2018 at 6:03 AM, Erik Faye-Lund
wrote:
> OpenGL 4.4 requires a max vertex attrib of 2048 or higher, but
> r600 only supports 2047. Technically, this makes it an GL4.3 GPU,
> but it's currently exposing GL4.4.
>
> To avoid regressing the GL version s
Reviewed-by: Jason Ekstrand
On Fri, Jul 6, 2018 at 2:06 PM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> Signed-off-by: Lionel Landwerlin
> ---
> src/vulkan/util/gen_enum_to_str.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/vulkan/util/gen_enum_t
Signed-off-by: Lionel Landwerlin
---
src/vulkan/util/gen_enum_to_str.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vulkan/util/gen_enum_to_str.py
b/src/vulkan/util/gen_enum_to_str.py
index bf883d5cb8f..fb9ecd65c6d 100644
--- a/src/vulkan/util/gen_enum_to_str.py
+++ b
These have come up from time to time in some enums. They've never been
a problem in the past because we just haven't cared about enum_to_str on
those.
---
src/vulkan/util/gen_enum_to_str.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/vulkan/util/gen_enum_to_str.p
This patch doesn't touch NTID since it seems very difficult (or
impossible) to generate. Seemingly because the state tracker or glsl
compiler is turning gl_WorkGroupSize into a immediate. Such a
transformation is not possible with GL_ARB_compute_variable_group_size
but gl_WorkGroupSize is not avail
On Fri, Jul 06, 2018 at 01:29:29PM -0700, Nanley Chery wrote:
> On Fri, Jul 06, 2018 at 03:36:01PM +0300, Pohjolainen, Topi wrote:
> > On Tue, Jun 12, 2018 at 12:21:52PM -0700, Nanley Chery wrote:
> > > This series fixes a couple stencil texturing bugs on HSW and
> > > cache-tracking for certain st
On Fri, Jul 06, 2018 at 03:36:01PM +0300, Pohjolainen, Topi wrote:
> On Tue, Jun 12, 2018 at 12:21:52PM -0700, Nanley Chery wrote:
> > This series fixes a couple stencil texturing bugs on HSW and
> > cache-tracking for certain stencil BOs on all platforms.
> >
> > Nanley Chery (13):
> > i965: Se
total instructions in shared programs : 5804448 -> 5804690 (0.00%)
total gprs used in shared programs: 670065 -> 670065 (0.00%)
total shared used in shared programs : 548832 -> 548832 (0.00%)
total local used in shared programs : 21068 -> 21068 (0.00%)
local shared
This brings in the Broadcom VC4 SAND and V3D 3.x+ UIF modifiers, from
drm-next commit 4da1d4c751c9b1b713c13043bad7c4d27cd1418c.
---
In sending this series, I'm just looking for an ack from someone for
updating the drm_fourcc.h from drm-next.
include/drm-uapi/drm_fourcc.h | 80 +++
You can't use T tiled buffers on V3D 3.x and newer, it's been replaced
with a newer layout shared with other hardware blocks.
---
src/gallium/drivers/v3d/v3d_resource.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/v3d/v3d_resource.c
Adam Jackson writes:
> Drawable and readable need to either both be None or both be non-None.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/ma
Hi Danylo,
I just run into the same issue, thanks for fixing this with autotools.
I think the same issue remains with meson though.
Thanks,
-
Lionel
On 20/06/18 14:25, Danylo Piliaiev wrote:
VK_USE_PLATFORM_XLIB_XRANDR_EXT requires xlib leasing which requires
xcb-randr >= 1.13. Also xrandr he
Hi Lionel,
The original problem we saw happened when dri format is
__DRI_IMAGE_FORMAT_XBGR2101010, which doesn't have any corresponding
ISL format available.
And yes, I verified the problem we saw doesn't happen anymore
with the latest code base possibly with your fix. So I could turn down
this p
Drawable and readable need to either both be None or both be non-None.
Cc:
Signed-off-by: Adam Jackson
---
src/glx/glxcurrent.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/glx/glxcurrent.c b/src/glx/glxcurrent.c
index fd04929b89f..2b9c708c3ee 100644
--- a/src/glx/glxcurrent.c
I've gone ahead and tested (through our CI) and pushed patches 1-3 with the
relevant *-bys added from Me, Eric, and Ian. I wanted to get patch 1 merged
quickly due to the high chance of conflicts.
Dylan
Quoting Mathieu Bridon (2018-07-05 06:17:34)
> This is compatible with Python versions >= 2.6.
https://bugs.freedesktop.org/show_bug.cgi?id=106151
--- Comment #25 from pritzl3...@gmail.com ---
(In reply to Samuel Pitoiset from comment #20)
> Created attachment 140246 [details] [review]
> possible fix
>
> Does this patch help?
The game still hangs with this patch using Mesa 18.1.3.
--
Yo
https://bugs.freedesktop.org/show_bug.cgi?id=106151
--- Comment #24 from pritzl3...@gmail.com ---
(In reply to Samuel Pitoiset from comment #19)
> Thanks, what preset do you use?
I'm using the high preset and I have disabled AA. Resolution is 3840x2160.
--
You are receiving this mail because:
Y
This patch is
Reviewed-by: Ian Romanick
On 07/06/2018 03:22 AM, Mathieu Bridon wrote:
> Python 2 has a range() function which returns a list, and an xrange()
> one which returns an iterator.
>
> Python 3 lost the function returning a list, and renamed the function
> returning an iterator as ran
This patch is
Reviewed-by: Ian Romanick
On 07/06/2018 03:17 AM, Mathieu Bridon wrote:
> In Python 2, dict.keys() and dict.values() both return a list, which can
> be sorted in two ways:
>
> * l.sort() modifies the list in-place;
> * sorted(l) returns a new, sorted list;
>
> In Python 3, dict.k
I don't think I knew about the "in" operator when I wrote that code... a
lot of it is pretty old, so it may not have even existed in 2005. :)
This patch is
Reviewed-by: Ian Romanick
On 07/06/2018 03:15 AM, Mathieu Bridon wrote:
> Python 3 lost the dict.has_key() method. Instead it requires usin
This patch is
Reviewed-by: Ian Romanick
On 07/06/2018 03:13 AM, Mathieu Bridon wrote:
> We could have made this compatible with Python 3 by using:
>
> except Exception as e:
>
> But since none of this code actually uses the exception objects, let's
> just drop them entirely.
>
> Signed-of
On Fri, Jul 06, 2018 at 03:21:31PM +0300, Pohjolainen, Topi wrote:
> On Fri, Jul 06, 2018 at 03:17:14PM +0300, Pohjolainen, Topi wrote:
> > On Tue, Jun 12, 2018 at 12:22:02PM -0700, Nanley Chery wrote:
> > > ---
> > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 ---
> > > 1
On 07/06/2018 08:45 AM, Adam Jackson wrote:
> On Fri, 2018-07-06 at 10:29 +0100, Emil Velikov wrote:
>
>> Skimming through the egl_khr_create_context text, this relaxes some
>> parts which are meant to be an error.
>> For example
>>
>> * If either of or is a valid surface and the other
>>
Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund:
> OpenGL 4.4 and OpenGL ES 3.1 both require the maximum
> vertex attrib stride to be at least 2048. If this isn't
> the case, we shouldn't expose these API versions.
>
> Unfortunately, the r600 driver only supports 2047. To
> avoid regressions in the
On Fri, 2018-07-06 at 10:29 +0100, Emil Velikov wrote:
> Skimming through the egl_khr_create_context text, this relaxes some
> parts which are meant to be an error.
> For example
>
> * If either of or is a valid surface and the other
> is EGL_NO_SURFACE, an EGL_BAD_MATCH error is
On 04/07/18 09:44, Iago Toral Quiroga wrote:
---
src/intel/vulkan/anv_pipeline_cache.c | 37 +++
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/src/intel/vulkan/anv_pipeline_cache.c
b/src/intel/vulkan/anv_pipeline_cache.c
index d4c7262dc0..5825
Hi Dongwon,
Jason & I merged some patches to fix similar issues a few weeks ago.
I think we didn't change this function because a crash or hitting an
assert is a good indication that something's gone wrong before we run
into this function.
If you patch fixes an issue, could you give some deta
On Tue, Jun 12, 2018 at 12:21:52PM -0700, Nanley Chery wrote:
> This series fixes a couple stencil texturing bugs on HSW and
> cache-tracking for certain stencil BOs on all platforms.
>
> Nanley Chery (13):
> i965: Set the r8stencil flag in miptree_finish_write
> i965/miptree: Set the r8stenci
On Tue, Jun 12, 2018 at 12:22:05PM -0700, Nanley Chery wrote:
> Note that the separate stencil miptree now has the same alloc_flag as
> the depth component.
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 29 ---
> 1 file changed, 6 insertions(+), 23 deletions(-)
>
> diff
On Fri, Jul 06, 2018 at 03:17:14PM +0300, Pohjolainen, Topi wrote:
> On Tue, Jun 12, 2018 at 12:22:02PM -0700, Nanley Chery wrote:
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 ---
> > 1 file changed, 26 insertions(+), 14 deletions(-)
> >
> > diff --git a/src/mes
On Tue, Jun 12, 2018 at 12:22:02PM -0700, Nanley Chery wrote:
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 ---
> 1 file changed, 26 insertions(+), 14 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/dri/i965/intel_mip
On Tue, Jun 12, 2018 at 12:22:01PM -0700, Nanley Chery wrote:
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
AFAICS, we use python 2 in two places:
(1) SCons*
I suspect using Python 3 will be far from straightforward, as it will
require newer SCons versions, and all that's implied.
So I rather not embark on this yet.
(2) C code generation scripts
Python 3.5 seems to be included on our build
Python 2 has a range() function which returns a list, and an xrange()
one which returns an iterator.
Python 3 lost the function returning a list, and renamed the function
returning an iterator as range().
As a result, using range() makes the scripts compatible with both Python
versions 2 and 3.
In Python 2, dictionaries have 2 sets of methods to iterate over their
keys and values: keys()/values()/items() and
iterkeys()/itervalues()/iteritems().
The former return lists while the latter return iterators.
Python 3 dropped the method which return lists, and renamed the methods
returning it
In Python 2, dict.keys() and dict.values() both return a list, which can
be sorted in two ways:
* l.sort() modifies the list in-place;
* sorted(l) returns a new, sorted list;
In Python 3, dict.keys() and dict.values() do not return lists any more,
but iterators. Iterators do not have a .sort() me
Python 3 lost the dict.has_key() method. Instead it requires using the
"in" operator.
This is also compatible with Python 2.
Signed-off-by: Mathieu Bridon
---
src/mapi/glapi/gen/glX_XML.py| 2 +-
src/mapi/glapi/gen/glX_proto_send.py | 2 +-
src/mapi/glapi/gen/glX_proto_size.py | 18 ++
We could have made this compatible with Python 3 by using:
except Exception as e:
But since none of this code actually uses the exception objects, let's
just drop them entirely.
Signed-off-by: Mathieu Bridon
---
src/mapi/glapi/gen/glX_XML.py | 2 +-
src/mapi/glapi/gen/gl_XML.py
The OpenGL 3.1 specification, table Table 20.41 ("Implementation
Dependent Values"), defines the minimum-maximum value for
MAX_VERTEX_ATTRIB_STRIDE to be 2048.
So we shouldn't enable OpenGL ES 3.1 on implementations where this
isn't the case. Let's add a check for this
Signed-off-by: Erik Faye-Lu
OpenGL 4.4 requires a max vertex attrib of 2048 or higher, but
r600 only supports 2047. Technically, this makes it an GL4.3 GPU,
but it's currently exposing GL4.4.
To avoid regressing the GL version supported in the following
patches, let's just lie and pretend like we support 2048. Any
applicatio
OpenGL 4.4 and OpenGL ES 3.1 both require the maximum
vertex attrib stride to be at least 2048. If this isn't
the case, we shouldn't expose these API versions.
Unfortunately, the r600 driver only supports 2047. To
avoid regressions in the supported GL version, the
first patch modifies the returned
The OpenGL 4.4 specification, table Table 23.55 ("Implementation
Dependent Values"), defines the minimum-maximum value for
MAX_VERTEX_ATTRIB_STRIDE to be 2048.
So we shouldn't enable OpenGL 4.4 on implementations where this isn't
the case. Let's add a check for this.
Signed-off-by: Erik Faye-Lund
We were not properly writing page tables when the virtual address
range spans multiple subtrees of the tables.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/intel_dump_gpu.c | 46
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/src/intel/to
Older system might not have support for memfd_create at the kernel
level. There we won't be able to use aubinator.
We also initially tried to workaround some libc having the
memfd_create syscall number defined, but not the memfd_create()
function.
This change makes dealing with the 2 problems abo
From: Emil Velikov
With commit c6c0f947142, back in 2006 Brian removed the
_glapi_check_multithread() call from core mesa - _mesa_make_current.
He moved it to a DRI loader (type of) decision - with equivalents in
the monolithic OSMesa and libGL-Xlib.
Some time afterwords, swrast (a DRI driver)
On Thu, 2018-07-05 at 09:31 -0700, Dylan Baker wrote:
> Quoting Mathieu Bridon (2018-07-05 06:17:47)
> > On Python 2, the builtin functions filter() and zip() would return
> > lists.
> >
> > On Python 3, they return iterators.
> >
> > Since we want to use those objects in contexts where we need l
Hi Rob,
On 6 July 2018 at 09:58, Robert Foss wrote:
>>
>> You can trivially eliminate the goto statement here.
>>
>
> As Tomasz noted this fallback is already implemented in egldriver.c,
> so it can be removed entirely.
>
Right forgot about that one.
Currently we have the fallback in egldriver.
On Thu, 2018-07-05 at 09:14 -0700, Dylan Baker wrote:
> Does it make more sense to encode, or to use io.open and open the
> file in text mode? I've gone back and forth on this myself several
> times.
Same here, both seem equally valid and I can't really make my mind up
on which one to pick.
The g
On 5 July 2018 at 20:35, Adam Jackson wrote:
> Fixes 14 piglits, mostly in egl_khr_create_context.
>
> Fixes: https://github.com/anholt/libepoxy/issues/177
> Signed-off-by: Adam Jackson
> ---
> src/mesa/drivers/dri/swrast/swrast.c | 34 +++-
> 1 file changed, 18 insertion
On Thu, 2018-07-05 at 09:10 -0700, Dylan Baker wrote:
> Quoting Mathieu Bridon (2018-07-05 06:17:43)
> > +def __ne__(self, other):
> > +return not self.__eq__(other)
>
> This can be written as "not (self == other)", right?
It can, yes.
The `==` operator is going to end up calling th
Hey Emil,
On 05/07/18 15:04, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swrast is also enabled as a
On 05/07/18 17:50, Robert Foss wrote:
Hey Emil,
On 05/07/18 15:13, Emil Velikov wrote:
Hi Rob,
On 5 July 2018 at 11:07, Robert Foss wrote:
@@ -511,7 +515,7 @@ dri2_open_driver(_EGLDisplay *disp)
char path[PATH_MAX], *search_paths, *next, *end;
char *get_extensions_name;
con
Hey Tomasz,
On 05/07/18 16:26, Tomasz Figa wrote:
Hi Rob,
On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote:
Add support for the ForceSoftware option, which is togglable
on the Android platform through setting the "drm.gpu.force_software"
property to a non-zero value.
kms_swrast is also enab
On Thu, 2018-07-05 at 08:48 -0700, Dylan Baker wrote:
> I've asked a couple of people who have (in the past at least) had a
> hard requirement on python 2.x if moving to 3.x will be okay for
> them. If it's not then we may need to do something else here. I've
> used six in the past (although I know
On 2018-07-06 12:15 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> Ported from i965 including the comment.
>
> This fixes:
> dEQP-EGL.functional.reusable_sync.valid.wait_server
>
> Cc: 18.1
> ---
> src/gallium/state_trackers/dri/dri_helpers.c | 6 ++
> 1 file changed, 6 insertions(+)
Jon Turney writes:
> per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate
>
> v2: just change the variable name, since there's no intended correlation
> here between this value and the machine's actual page size.
>
> Cc: Scott D Phillips
> Signed-off-by: Jon Turney
Revi
69 matches
Mail list logo
