Re: [Mesa-dev] [PATCH v2 4/5] mesa/util: add allow_glsl_relaxed_es driconfig override

2018-06-18 Thread Ian Romanick
This commit breaks all of shader-db and regresses about 9,000 piglit tests. Consider this a very strong NAK of this patch. At this point, Google needs to fix its app. Please revert ASAP. On 06/13/2018 06:00 PM, Timothy Arceri wrote: > This relaxes a number of ES shader restrictions allowing sha

[Mesa-dev] [PATCH] gallium: Fix automake for Android

2018-06-18 Thread Chad Versace
Chromium OS uses Autotools and pkg-config when building Mesa for Android. The gallium drivers were failing to find the headers and libraries for zlib and Android's libbacktrace. --- configure.ac | 6 +- src/gallium/Automake.inc | 5 + src/gallium/auxiliary/Mak

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #18 from Trevor Davenport --- This may not be a mesa bug. For me, as soon as I enable MSAA i get asserts in mesa (in a debug build) or get lots of validation layers errors when they are enabled. The error have to do with the aspe

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #3 from Giovanni ongaro --- Created attachment 140216 --> https://bugs.freedesktop.org/attachment.cgi?id=140216&action=edit pic ov vega with bad rendering issue -- You are receiving this mail because: You are the QA Contact for t

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #2 from Giovanni ongaro --- Created attachment 140215 --> https://bugs.freedesktop.org/attachment.cgi?id=140215&action=edit pic of rx480 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Con

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 --- Comment #1 from Giovanni ongaro --- Created attachment 140214 --> https://bugs.freedesktop.org/attachment.cgi?id=140214&action=edit wine log -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

[Mesa-dev] [Bug 106958] Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106958 Bug ID: 106958 Summary: Mass Effect Andromeda renders correctly on RX480 POLARIS but BAD ON RX VEGA 64 on wine 3.10 stagingf with DXVK Product: Mesa Version: gi

[Mesa-dev] [PATCH 2/2] radeonsi: rename r600_texture -> si_texture, rxxx -> xxx or sxxx

2018-06-18 Thread Marek Olšák
Too big for mesa-dev: https://cgit.freedesktop.org/~mareko/mesa/commit/?id=39ba6addbf33208203bec034258aa5da8d2e78e6 Please review, Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa

[Mesa-dev] [PATCH 1/2] amd, radeonsi: rename radeon_winsys_cs -> radeon_cmdbuf

2018-06-18 Thread Marek Olšák
Too big for mesa-dev: https://cgit.freedesktop.org/~mareko/mesa/commit/?id=64fefbc9de4734ae33f34d97d78a1dfd46bee2cd Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106955] Mesa 18.1.2 not tagged in git

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106955 --- Comment #1 from Bas Nieuwenhuizen --- Seems the tag exists at https://gitlab.freedesktop.org/mesa/mesa/tags/mesa-18.1.2 so likely the synchronization does nto copy over new tags? -- You are receiving this mail because: You are the QA Con

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Ilia Mirkin
On Mon, Jun 18, 2018 at 7:19 PM, Jason Ekstrand wrote: > On Mon, Jun 18, 2018 at 3:57 PM, Ilia Mirkin wrote: >> >> Not sure how much voting power I have, but I really like Erik's version at >> >> https://codepen.io/kusma/pen/vrXppL >> >> It uses CSS3 animation on hover, so it's pretty low impact.

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Jason Ekstrand
On Mon, Jun 18, 2018 at 5:36 PM, Jordan Justen wrote: > On 2018-06-18 15:57:50, Ilia Mirkin wrote: > > Not sure how much voting power I have, but I really like Erik's version > at > > > > https://codepen.io/kusma/pen/vrXppL > > I think it's unfortunate that the logo says "3D Graphics Library", >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Jordan Justen
On 2018-06-18 15:57:50, Ilia Mirkin wrote: > Not sure how much voting power I have, but I really like Erik's version at > > https://codepen.io/kusma/pen/vrXppL I think it's unfortunate that the logo says "3D Graphics Library", while simultaneously showing an image that couldn't look more 2D. :)

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-18 Thread Eric Anholt
Jason Ekstrand writes: > On Mon, Jun 18, 2018 at 2:14 AM, Michel Dänzer wrote: > >> On 2018-06-16 08:23 AM, Jason Ekstrand wrote: >> > On Fri, Jun 15, 2018 at 4:44 PM, Eric Anholt wrote: >> > >> >> Michel Dänzer writes: >> >> >> >>> On 2018-06-15 05:25 PM, Jason Ekstrand wrote: >> On June

Re: [Mesa-dev] [PATCH v2 2/5] mesa/util: add allow_glsl_builtin_const_expression driconf override

2018-06-18 Thread Dave Airlie
On 14 June 2018 at 11:00, Timothy Arceri wrote: > Google Earth VR shaders uses builtins in constant expressions with > GLSL 1.10. That feature wasn't allowed until GLSL 1.20. For 2-5. Reviewed-by: Dave Airlie ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH] nir: add pass to move load_const

2018-06-18 Thread Rob Clark
On Mon, Jun 18, 2018 at 6:36 PM, Ian Romanick wrote: > On 06/11/2018 08:23 AM, Rob Clark wrote: >> Run this pass late (after opt loop) to move load_const instructions back >> into the basic blocks which use the result, in cases where a load_const >> is only consumed in a single block. >> >> This h

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Rob Clark
On Mon, Jun 18, 2018 at 7:19 PM, Jason Ekstrand wrote: > On Mon, Jun 18, 2018 at 3:57 PM, Ilia Mirkin wrote: >> >> Not sure how much voting power I have, but I really like Erik's version at >> >> https://codepen.io/kusma/pen/vrXppL >> >> It uses CSS3 animation on hover, so it's pretty low impact.

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-18 Thread Jason Ekstrand
On Mon, Jun 18, 2018 at 2:14 AM, Michel Dänzer wrote: > On 2018-06-16 08:23 AM, Jason Ekstrand wrote: > > On Fri, Jun 15, 2018 at 4:44 PM, Eric Anholt wrote: > > > >> Michel Dänzer writes: > >> > >>> On 2018-06-15 05:25 PM, Jason Ekstrand wrote: > On June 15, 2018 01:14:24 Michel Dänzer w

[Mesa-dev] [PATCH 11/11] radeonsi: disable DCC statistics gathering on everything but Stoney

2018-06-18 Thread Marek Olšák
From: Marek Olšák I think we don't need it on other chips. --- src/gallium/drivers/radeonsi/si_clear.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c index f366de32d0f..36e2033b1f6 100644

[Mesa-dev] [PATCH 05/11] radeonsi: enable shader caching for compute shaders

2018-06-18 Thread Marek Olšák
From: Marek Olšák Compute shaders were not using the shader cache. --- src/gallium/drivers/radeonsi/si_compute.c | 45 --- src/gallium/drivers/radeonsi/si_state.h | 6 +++ .../drivers/radeonsi/si_state_shaders.c | 14 +++--- 3 files changed, 50 insertions(+), 15

[Mesa-dev] [PATCH 09/11] radeonsi: simplify logic around vi_separate_dcc_try_enable

2018-06-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 23 ++- src/gallium/drivers/radeonsi/si_texture.c | 6 +- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c

[Mesa-dev] [PATCH 07/11] radeonsi: reorder and initialize more fields in si_reallocate_texture_inplace

2018-06-18 Thread Marek Olšák
From: Marek Olšák Some fields shouldn't be initialized, like framebuffers_bound and other stats. It's hopefully complete now. Cc: 18.1 --- src/gallium/drivers/radeonsi/si_texture.c | 31 ++- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH 06/11] radeonsi: remove references to Evergreen

2018-06-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 1 - src/gallium/drivers/radeonsi/si_dma_cs.c | 2 +- src/gallium/drivers/radeonsi/si_query.c | 1 - src/gallium/drivers/radeonsi/si_texture.c | 2 +- 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/d

[Mesa-dev] [PATCH 01/11] radeonsi/gfx9: insert the barrier between merged shaders inside the if block

2018-06-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index d2b9b73e039..a0a00d722cb 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 08/11] radeonsi: fix memory exhaustion issue with DCC statistics gathering with DRI2

2018-06-18 Thread Marek Olšák
From: Marek Olšák Cc: 18.1 --- src/gallium/drivers/radeonsi/si_blit.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index fe059b36577..93cf7fe9001 100644 --- a/src/

[Mesa-dev] [PATCH 10/11] radeonsi: don't enable DCC statistics gathering for small surfaces

2018-06-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 30 + 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c index ef843966f2a..f366de32d0f 100644 --- a/src/gallium

[Mesa-dev] [PATCH 00/11] RadeonSI: Compute shader caching & DCC stats fixes

2018-06-18 Thread Marek Olšák
Hi, This series enables the shader cache for compute shaders, sinks the barrier between merged shaders into the next conditional, fixes issues with DCC statistics gathering and disables it on all chips except Stoney, and other changes. There is also this older unreviewed series: https://patchwor

[Mesa-dev] [PATCH 03/11] radeonsi: unify duplicated code for initial shader compilation

2018-06-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 25 ++--- src/gallium/drivers/radeonsi/si_state.h | 4 ++ .../drivers/radeonsi/si_state_shaders.c | 53 +++ 3 files changed, 39 insertions(+), 43 deletions(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH 02/11] ac: set +auto-waitcnt-before-barrier when needed

2018-06-18 Thread Marek Olšák
From: Marek Olšák This removes useless s_waitcnt before barriers. Only radeonsi uses this function. --- src/amd/common/ac_llvm_util.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c index be2d92b4c08..99cc677

[Mesa-dev] [PATCH 04/11] radeonsi: store compute local_size into tgsi_shader_info

2018-06-18 Thread Marek Olšák
From: Marek Olšák This is kinda a hack, but it's enough for the shader cache. --- src/gallium/drivers/radeonsi/si_compute.c| 5 - src/gallium/drivers/radeonsi/si_shader.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.h | 6 +++--- src/gallium/drivers/radeonsi/si_shader_nir.c |

Re: [Mesa-dev] [PATCH] nir: evaluate if condition uses inside the if branches

2018-06-18 Thread Timothy Arceri
On 19/06/18 08:40, Ian Romanick wrote: On 06/17/2018 05:15 PM, Timothy Arceri wrote: Since we know what side of the branch we ended up on we can just replace the use with a constant. All helped shaders are from Unreal Engine 4 besides one shader from Dirt Showdown. shader-db results SKL: tota

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Jason Ekstrand
On Mon, Jun 18, 2018 at 3:57 PM, Ilia Mirkin wrote: > Not sure how much voting power I have, but I really like Erik's version at > > https://codepen.io/kusma/pen/vrXppL > > It uses CSS3 animation on hover, so it's pretty low impact. Some > slight cleverness could even include a fallback for a bro

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Ilia Mirkin
Not sure how much voting power I have, but I really like Erik's version at https://codepen.io/kusma/pen/vrXppL It uses CSS3 animation on hover, so it's pretty low impact. Some slight cleverness could even include a fallback for a browser that doesn't support SVG. IMO solutions like three.js and

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Laura Ekstrand
This looks like a useful check for WebGL compatibility: https://threejs.org/docs/index.html#manual/introduction/WebGL-compatibility-check On Mon, Jun 18, 2018, 3:50 PM Laura Ekstrand wrote: > Jordan's version is awesome. But in general most people are concerned > that WebGL will crash browsers.

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-18 Thread Laura Ekstrand
Jordan's version is awesome. But in general most people are concerned that WebGL will crash browsers. One idea is to look into using three.js, which is a front-end library for web graphics. It's backed by multiple frameworks including WebGL. On Sun, Jun 17, 2018, 9:23 PM Jordan Justen wrote:

Re: [Mesa-dev] [PATCH] [RFC] i965/blit: bump some limits to 64k

2018-06-18 Thread Nanley Chery
On Thu, Jun 14, 2018 at 07:50:54PM +0100, Chris Wilson wrote: > Quoting Nanley Chery (2018-06-14 19:46:09) > > On Thu, Jun 14, 2018 at 10:01:18AM -0700, Nanley Chery wrote: > > > On Thu, Jun 14, 2018 at 04:18:30PM +0300, Martin Peres wrote: > > > > This fixes screenshots using 8k+ wide display setu

Re: [Mesa-dev] [PATCH] nir: evaluate if condition uses inside the if branches

2018-06-18 Thread Ian Romanick
On 06/17/2018 05:15 PM, Timothy Arceri wrote: > Since we know what side of the branch we ended up on we can just > replace the use with a constant. > > All helped shaders are from Unreal Engine 4 besides one shader from > Dirt Showdown. > > shader-db results SKL: > > total instructions in shared

Re: [Mesa-dev] [PATCH] nir: add pass to move load_const

2018-06-18 Thread Ian Romanick
On 06/11/2018 08:23 AM, Rob Clark wrote: > Run this pass late (after opt loop) to move load_const instructions back > into the basic blocks which use the result, in cases where a load_const > is only consumed in a single block. > > This helps reduce register usage in cases where the backend driver

Re: [Mesa-dev] [PATCH 7/9] intel: aubinator: move address masking

2018-06-18 Thread Rafael Antognolli
Patches 4-7 are: Reviewed-by: Rafael Antognolli On Thu, Jun 14, 2018 at 06:11:43PM +0100, Lionel Landwerlin wrote: > The Masking is only needed for entry matching. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

Re: [Mesa-dev] [PATCH 2/9] intel/tools/aubinator: aubinate ppgtt aubs

2018-06-18 Thread Rafael Antognolli
Hi Lionel, I've been going through the patch and I think the content so far is mostly fine. However, it has a lot of things going on for a single patch IMHO. I see changes for the execution list submission port, ppgtt, using the RB tree for ggtt too, etc... It definitely make it more painful to r

Re: [Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

2018-06-18 Thread Marek Olšák
What about non-sRGB formats? Marek On Wed, May 23, 2018 at 4:54 AM, Tomeu Vizoso wrote: > When Mesa itself implements ETC2 decompression, it currently > decompresses to formats in the GL_BGRA component order. > > That can be problematic for drivers which cannot upload the texture data > as GL_B

Re: [Mesa-dev] [PATCH v3 1/2] gallium: add scalar isa shader cap

2018-06-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jun 15, 2018 at 6:29 AM, Christian Gmeiner < christian.gmei...@gmail.com> wrote: > v1 -> v2: > - nv30 is _NOT_ scalar as suggested by Ilia Mirkin. > - Change from a screen cap to a shader cap as suggested >by Eric Anholt. > - radeonsi is scalar as

Re: [Mesa-dev] [PATCH] tgsi: add some atomic opcodes to tgsi_opcode_infer_type

2018-06-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jun 14, 2018 at 7:35 PM, Gurchetan Singh < gurchetansi...@chromium.org> wrote: > We don't have cases for atomic types, some of which are explicitly > signed or unsigned. > > The other opcodes could have uint or int return types, based on the > sources. >

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

2018-06-18 Thread Marek Olšák
On Mon, Jun 18, 2018 at 4:41 PM, Bas Nieuwenhuizen wrote: > On Mon, Jun 18, 2018 at 10:39 PM, Marek Olšák wrote: > > On Mon, Jun 18, 2018 at 12:12 PM, Bas Nieuwenhuizen > > wrote: > >> > >> On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: > >> > Do you need this if you set compressZ = true

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jun 17, 2018 at 10:39 PM, Timothy Arceri wrote: > This is required for compatibility profile support. > --- > src/mesa/main/ff_fragment_shader.cpp | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/ff_fragment_sh

Re: [Mesa-dev] [PATCH] radeonsi: enable OpenGL 3.3 compat profile

2018-06-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 18, 2018 at 1:29 AM, Timothy Arceri wrote: > Cc: Marek Olšák > --- > > This is intended to apply on top of: > https://patchwork.freedesktop.org/patch/229981/ > > All the high importance pieces are now implemented and > we have a reasonable nu

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] ac/surface: Set compressZ for stencil-only surfaces.

2018-06-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jun 18, 2018 at 10:32 AM, Bas Nieuwenhuizen wrote: > We HTILE compress stencil-only surfaces too. > > CC: 18.1 > --- > src/amd/common/ac_surface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_surface.c b/src

Re: [Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

2018-06-18 Thread Marek Olšák
The function can be removed completely, because it doesn't do anything now. Marek On Mon, Jun 18, 2018 at 10:55 AM, Eric Engestrom wrote: > On Monday, 2018-06-18 07:31:49 -0700, Matt Turner wrote: > > On Mon, Jun 18, 2018 at 3:15 AM Eric Engestrom > wrote: > > > > > > As of 66673bef941af344314

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

2018-06-18 Thread Bas Nieuwenhuizen
On Mon, Jun 18, 2018 at 10:39 PM, Marek Olšák wrote: > On Mon, Jun 18, 2018 at 12:12 PM, Bas Nieuwenhuizen > wrote: >> >> On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: >> > Do you need this if you set compressZ = true for stencil? >> >> Technically not, then you don't hit the path anymore.

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

2018-06-18 Thread Marek Olšák
On Mon, Jun 18, 2018 at 12:12 PM, Bas Nieuwenhuizen wrote: > On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: > > Do you need this if you set compressZ = true for stencil? > > Technically not, then you don't hit the path anymore. Anyway even > though neither AMDVLK or RADV anymore if we do th

Re: [Mesa-dev] [PATCH mesa] meson: fix i965/anv/isl genX static lib names

2018-06-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-15 04:15:31) > Shouldn't make any functional difference, just that `liblibanv_gen90.a` > will now be called `libanv_gen90.a`. > > Fixes: 3218056e0eb375eeda470 "meson: Build i965 and dri stack" > Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan drive

Re: [Mesa-dev] [PATCH] virgl: Remove debugging left-overs

2018-06-18 Thread Dave Airlie
On 18 June 2018 at 22:50, Tomeu Vizoso wrote: > Some fprintfs were probably left unintentionally a few years ago and are > a bit of a nuisance. > > Signed-off-by: Tomeu Vizoso > Cc: Signed-off-by: Rob Herring > Fixes: 2d3301e4d513 ("virgl: fix reference counting of prime handles") Reviewed-by:

[Mesa-dev] [Bug 106915] [GLSL] Unused arrays declared without a size should be handled like arrays of size 1.

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106915 --- Comment #9 from Ian Romanick --- Okay... this doesn't work on any desktop implementation of GLSL. In previous cases like this we have decided we have decided that the spec is either unclear or wrong. Either way, please submit a Khronos spe

Re: [Mesa-dev] [PATCH shaderdb] run: shader program file created via GetProgramBinary (v5)

2018-06-18 Thread Matt Turner
On Wed, May 23, 2018 at 3:12 PM Dongwon Kim wrote: > > Thanks, Matt!! > I am glad to see it is finally merged. By the way, not sure if you > saw this patch. > > [PATCH shaderdb] run: handling binding of attribute variable name (v2) > https://lists.freedesktop.org/archives/mesa-dev/2018-March/19017

Re: [Mesa-dev] [PATCH 00/19] intel: extract performance query code

2018-06-18 Thread Lionel Landwerlin
I forgot that the last patch won't make it (too big). The branch is here : https://github.com/djdeath/mesa/tree/wip/djdeath/perf-extract Cheers, - Lionel On 18/06/18 18:39, Lionel Landwerlin wrote: Hi all, This series can be broken in 3 parts : - Making the performace query code API

[Mesa-dev] [PATCH 11/19] intel: perf: update HSW configuration

2018-06-18 Thread Lionel Landwerlin
One register that was in the configuration turned out to be IVB specific. Let's just drop it. Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-hsw.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/perf/oa-hsw.xml b/src/intel/perf/oa-hsw.xml index 861cc1212

[Mesa-dev] [PATCH 17/19] intel: perf: glk: add pma stall metric

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-glk.xml | 113 +- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git a/src/intel/perf/oa-glk.xml b/src/intel/perf/oa-glk.xml index 68fcd2d6dde..e3da757f46f 100644 --- a/src/intel/perf/oa-glk.xml +

[Mesa-dev] [PATCH 10/19] i965: perf: add mdapi pipeline statistics queries on gen10/11

2018-06-18 Thread Lionel Landwerlin
The Gen10+ expected format adds an additional counter which we can't disclose yet. We can still make the size of the expected query result match. Signed-off-by: Lionel Landwerlin --- src/intel/perf/gen_perf_mdapi.h| 1 + .../drivers/dri/i965/brw_performance_query_mdapi.c

[Mesa-dev] [PATCH 08/19] i965: move mdapi guid into intel/perf

2018-06-18 Thread Lionel Landwerlin
One more thing we want to share between the different APIs. Signed-off-by: Lionel Landwerlin --- src/intel/perf/gen_perf_mdapi.h | 3 +++ src/mesa/drivers/dri/i965/brw_performance_query_mdapi.c | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/in

[Mesa-dev] [PATCH 18/19] intel: perf: chv: fixup counter names

2018-06-18 Thread Lionel Landwerlin
No functional changes, just cleaning up the names of the counters. Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-chv.xml | 50 +++ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/intel/perf/oa-chv.xml b/src/intel/perf/oa-chv.xml in

[Mesa-dev] [PATCH 09/19] intel/perf: stub gen10/11 missing definitions

2018-06-18 Thread Lionel Landwerlin
--- src/intel/perf/gen_perf_mdapi.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/perf/gen_perf_mdapi.h b/src/intel/perf/gen_perf_mdapi.h index a2f8066dcf4..45fe171b030 100644 --- a/src/intel/perf/gen_perf_mdapi.h +++ b/src/intel/perf/gen_perf_mdapi.h @@ -108,6 +108,10 @@ struc

[Mesa-dev] [PATCH 15/19] intel: perf: cfl: add pma stall metric

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-cflgt2.xml | 103 ++- src/intel/perf/oa-cflgt3.xml | 103 ++- 2 files changed, 204 insertions(+), 2 deletions(-) diff --git a/src/intel/perf/oa-cflgt2.xml b/src/intel/perf/oa-cf

[Mesa-dev] [PATCH 16/19] intel: perf: bxt: add pma stall metric

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-bxt.xml | 113 +- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git a/src/intel/perf/oa-bxt.xml b/src/intel/perf/oa-bxt.xml index 5b18369b2cb..db018a3d62b 100644 --- a/src/intel/perf/oa-bxt.xml +

[Mesa-dev] [PATCH 12/19] intel: perf: bdw: add pma stall metric

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-bdw.xml | 203 +- 1 file changed, 202 insertions(+), 1 deletion(-) diff --git a/src/intel/perf/oa-bdw.xml b/src/intel/perf/oa-bdw.xml index 258fcacfd59..714a1f08ea7 100644 --- a/src/intel/perf/oa-bdw.xml +

[Mesa-dev] [PATCH 13/19] intel: perf: skl: add pma stall metric

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-sklgt2.xml | 103 ++- src/intel/perf/oa-sklgt3.xml | 103 ++- src/intel/perf/oa-sklgt4.xml | 103 ++- 3 files changed, 306 insertions(+), 3 deleti

[Mesa-dev] [PATCH 05/19] i965: move OA accumulation code to intel/perf

2018-06-18 Thread Lionel Landwerlin
We'll want to reuse this in our Vulkan extension. Signed-off-by: Lionel Landwerlin --- src/intel/perf/gen_perf.c | 135 ++ src/intel/perf/gen_perf.h | 81 ++- .../drivers/dri/i965/brw_performance_query.c | 134 +++-- .

[Mesa-dev] [PATCH 14/19] intel: perf: kbl: add pma stall metric

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-kblgt2.xml | 103 ++- src/intel/perf/oa-kblgt3.xml | 103 ++- 2 files changed, 204 insertions(+), 2 deletions(-) diff --git a/src/intel/perf/oa-kblgt2.xml b/src/intel/perf/oa-kb

[Mesa-dev] [PATCH 02/19] i965: store device revision in gen_device_info

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/dev/gen_device_info.h | 1 + src/mesa/drivers/dri/i965/brw_performance_query.c | 3 +-- src/mesa/drivers/dri/i965/intel_screen.c | 4 +++- src/mesa/drivers/dri/i965/intel_screen.h | 3 --- 4 files changed, 5 insert

[Mesa-dev] [PATCH 04/19] i965: move mdapi data structure to intel/perf

2018-06-18 Thread Lionel Landwerlin
We'll want to reuse those structures later on. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.sources| 3 +- src/intel/perf/gen_perf_mdapi.h | 119 ++ .../dri/i965/brw_performance_query_mdapi.c| 103 ++- 3 files changed

[Mesa-dev] [PATCH 07/19] i965: move mdapi result data format to intel/perf

2018-06-18 Thread Lionel Landwerlin
We want to reuse this in Anv. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.sources| 3 +- src/intel/perf/gen_perf_mdapi.c | 116 ++ src/intel/perf/gen_perf_mdapi.h | 8 ++ src/intel/perf/meson.build

[Mesa-dev] [PATCH 06/19] i965: move brw_timebase_scale to device info

2018-06-18 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/dev/gen_device_info.h | 7 +++ src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/brw_performance_query.c | 8 ++-- .../dri/i965/brw_performance_query_mdapi.c| 6 +++--- src/mesa/d

[Mesa-dev] [PATCH 01/19] intel: genxml: add mask fields for INSTPM/CS_DEBUG_MODE2 registers

2018-06-18 Thread Lionel Landwerlin
Those 2 registers have masks on the upper 16bits of field values that should be applied in HW. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 3 +++ src/intel/genxml/gen11.xml | 3 +++ src/intel/genxml/gen7.xml | 4 src/intel/genxml/gen75.xml | 4 src/intel/genxml/g

[Mesa-dev] [PATCH 03/19] i965: extract performance query metrics

2018-06-18 Thread Lionel Landwerlin
We would like to reuse performance query metrics in other APIs. Let's make the query code dealing with the processing of raw counters into human readable values API agnostic. Signed-off-by: Lionel Landwerlin --- src/intel/Android.mk | 1 + src/intel/Android.perf.mk

[Mesa-dev] [PATCH 00/19] intel: extract performance query code

2018-06-18 Thread Lionel Landwerlin
Hi all, This series can be broken in 3 parts : - Making the performace query code API agnostic so that it can be reused on other APIs (patches 1 -> 10) - Adding a new pma stall metric on gen 8 & 9 (patches 17) - Adding performance query support on gen 11 (patch 19) Cheers

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-18 Thread Juan A. Suarez Romero
On Mon, 2018-06-18 at 09:56 -0700, Dylan Baker wrote: > Quoting Juan A. Suarez Romero (2018-06-18 00:22:02) > > On Fri, 2018-06-15 at 12:47 -0400, Ilia Mirkin wrote: > > > On Fri, Jun 15, 2018 at 12:36 PM, Dylan Baker wrote: > > > > I don't even understand why we make these announcements TBH. I ha

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-18 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-06-18 00:22:02) > On Fri, 2018-06-15 at 12:47 -0400, Ilia Mirkin wrote: > > On Fri, Jun 15, 2018 at 12:36 PM, Dylan Baker wrote: > > > I don't even understand why we make these announcements TBH. I have a > > > public > > > 18.1-proposed branch that I push to *

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-18 Thread Robert Foss
On 2018-06-14 04:54, Tomasz Figa wrote: On Thu, Jun 14, 2018 at 4:14 AM Rob Herring wrote: On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote: On 13 June 2018 at 20:45, Rob Herring wrote: +Amit and John On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss wrote: This patch both adds support

[Mesa-dev] [Bug 106420] segfault in dri2_allocate_textures(), radeonsi_dri.so 18.1-rc3 using mpv

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106420 Axel Rohde changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] anv: Use a single global API patch version

2018-06-18 Thread Jason Ekstrand
On Mon, Jun 18, 2018 at 2:33 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > I was wondering whether we should pick up the patch version from the > registry. > I've thought about that. However, I like the manual step of someone saying "Yes, I've been paying attention and I'm pret

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

2018-06-18 Thread Bas Nieuwenhuizen
On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: > Do you need this if you set compressZ = true for stencil? Technically not, then you don't hit the path anymore. Anyway even though neither AMDVLK or RADV anymore if we do that, it still bugged me that the index is wrong. - Bas > > Marek > >

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

2018-06-18 Thread Marek Olšák
Do you need this if you set compressZ = true for stencil? Marek On Mon, Jun 18, 2018 at 11:00 AM, Bas Nieuwenhuizen wrote: > Tile index 3 is "16 bpp depth PRT (non-MSAA), don't support > uncompressed depth" while tile index 0 is "non-AA compressed depth > or any stencil" per the comments at the

Re: [Mesa-dev] [PATCH mesa] radv: fix reported number of available VGPRs

2018-06-18 Thread Alex Smith
Reviewed-by: Alex Smith On 15 June 2018 at 17:52, Eric Engestrom wrote: > It's a bit late to round up after an integer division. > > Fixes: de889794134e6245e08a2 "radv: Implement VK_AMD_shader_info" > Cc: Alex Smith > Signed-off-by: Eric Engestrom > --- > src/amd/vulkan/radv_shader.c | 2 +-

[Mesa-dev] [Bug 106955] Mesa 18.1.2 not tagged in git

2018-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106955 Bug ID: 106955 Summary: Mesa 18.1.2 not tagged in git Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: minor Priority:

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

2018-06-18 Thread Eric Engestrom
On Monday, 2018-06-18 16:23:41 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 5.0 or greater, and thus we can't build dist > tarball because swr requires LLVM 4.0. > > Let's bump required LLVM to 5.0 in swr too. > > Fixes: f9eb1ef870 ("amd: remove support for LLVM 4.0") > Cc: George

[Mesa-dev] [PATCH] freedreno: a2xx: fix clear color

2018-06-18 Thread Jonathan Marek
the format of the CLEAR_COLOR register doesn't depend on the target format this fixes clear color when rendering to 32-bit RGBA and 16-bit targets Signed-off-by: Jonathan Marek --- src/gallium/drivers/freedreno/a2xx/fd2_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [PATCH] freedreno: add initial a20x support

2018-06-18 Thread Jonathan Marek
the bare minimum to get a20x running with kmscube and some glmark2 scenes: different CP_DRAW_INDX format and the different clear color register Signed-off-by: Jonathan Marek --- src/gallium/drivers/freedreno/a2xx/fd2_draw.c | 15 +++-- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 10 +

[Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

2018-06-18 Thread Bas Nieuwenhuizen
Tile index 3 is "16 bpp depth PRT (non-MSAA), don't support uncompressed depth" while tile index 0 is "non-AA compressed depth or any stencil" per the comments at the top of the file. On my Cape Verde this caused assertions due to the bank height of tile index 3 being too low. (2 while needs to be

Re: [Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

2018-06-18 Thread Eric Engestrom
On Monday, 2018-06-18 07:31:49 -0700, Matt Turner wrote: > On Mon, Jun 18, 2018 at 3:15 AM Eric Engestrom > wrote: > > > > As of 66673bef941af344314f ("mesa: Unconditionally enable floating-point > > textures"), the `bind` argument is no longer used, and the format check > > is now a simple enum

[Mesa-dev] [PATCH 1/2] amd/addrlib: Use correct tile index for S8 on SI.

2018-06-18 Thread Bas Nieuwenhuizen
Tile index 3 is "16 bpp depth PRT (non-MSAA), don't support uncompressed depth" while tile index 0 is "non-AA compressed depth or any stencil" per the comments at the top of the file. On my Cape Verde this caused assertions due to the bank height of tile index 3 being too low. (2 while needs to be

[Mesa-dev] [PATCH 2/2] ac/surface: Set compressZ for stencil-only surfaces.

2018-06-18 Thread Bas Nieuwenhuizen
We HTILE compress stencil-only surfaces too. CC: 18.1 --- src/amd/common/ac_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 6600ff6b7ef..618b755afc7 100644 --- a/src/amd/common/ac_surface.c +++ b/src/am

Re: [Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

2018-06-18 Thread Matt Turner
On Mon, Jun 18, 2018 at 3:15 AM Eric Engestrom wrote: > > As of 66673bef941af344314f ("mesa: Unconditionally enable floating-point > textures"), the `bind` argument is no longer used, and the format check > is now a simple enum range check, so inline it and remove the > unnecessary argument from c

Re: [Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

2018-06-18 Thread Lionel Landwerlin
Hey Danylo, Thanks for this patch. I'm not really an expert here but my understanding is that it should reflect the number of bits in fixed point precision. We use 32bits floats in the packets sent to the hardware. Quoting the spec : "If the implementation truely has floating point viewport bo

[Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

2018-06-18 Thread Juan A. Suarez Romero
RADV now requires LLVM 5.0 or greater, and thus we can't build dist tarball because swr requires LLVM 4.0. Let's bump required LLVM to 5.0 in swr too. Fixes: f9eb1ef870 ("amd: remove support for LLVM 4.0") Cc: George Kyriazis Cc: Tim Rowley Cc: Emil Velikov Cc: Dylan Baker Cc: Eric Engestrom

[Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

2018-06-18 Thread Danylo Piliaiev
We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS should reflect this. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105975 Signed-off-by: Danylo Piliaiev --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Mesa-dev] [PATCH] virgl: Remove debugging left-overs

2018-06-18 Thread Tomeu Vizoso
Some fprintfs were probably left unintentionally a few years ago and are a bit of a nuisance. Signed-off-by: Tomeu Vizoso Cc: Signed-off-by: Rob Herring Fixes: 2d3301e4d513 ("virgl: fix reference counting of prime handles") --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 -- 1 file chan

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-18 Thread Jakob Bornecrantz
On Mon, Jun 18, 2018 at 1:06 PM Elie Tournier wrote: > > On Mon, Jun 18, 2018 at 12:06:42PM +0100, Jakob Bornecrantz wrote: > > TGSI already has a invariant field on declarations, we are running > > into a bug with virgl because st_glsl_to_tgsi completely drops the > > invariant flag on the floor

Re: [Mesa-dev] [PATCH mesa] mesa: add missing return in error path

2018-06-18 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2018-06-18 at 11:40 +0100, Eric Engestrom wrote: > Fixes: 67f40dadaadacd90 "mesa: add support for > ARB_sample_locations" > Cc: Rhys Perry > Cc: Brian Paul > Signed-off-by: Eric Engestrom > --- > src/mesa/main/fbobject.c | 4 +++- > 1 file changed,

[Mesa-dev] [PATCH kmscube 2/2] add MSAA

2018-06-18 Thread Rob Clark
Signed-off-by: Rob Clark --- common.c | 5 +++-- common.h | 12 ++-- cube-smooth.c | 4 ++-- cube-tex.c| 4 ++-- cube-video.c | 4 ++-- kmscube.c | 12 +--- 6 files changed, 24 insertions(+), 17 deletions(-) diff --git a/common.c b/common.c index 931fc06..d

[Mesa-dev] [PATCH kmscube 1/2] gbm: fix fallback for drivers that don't support modifiers

2018-06-18 Thread Rob Clark
Gallium drivers that do not implement resource_create_with_modifiers() will fail gbm_surface_create_with_modifiers() so fall back to the old way. Fixes: 4f7cec0 Use weak functions to handle lack of gbm modifiers Signed-off-by: Rob Clark --- common.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

2018-06-18 Thread Elie Tournier
On Mon, Jun 18, 2018 at 12:06:42PM +0100, Jakob Bornecrantz wrote: > TGSI already has a invariant field on declarations, we are running > into a bug with virgl because st_glsl_to_tgsi completely drops the > invariant flag on the floor when it comes to declarations (tho precise > is added to the ops

  1   2   >