[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #4 from Tapani Pälli --- I've noticed that if I skip uniform removal in opt_dead_code (even builtin uniforms), then this test passes. I have no idea why this is though. I have been running chrome with following arguments: "--use-gl=e

Re: [Mesa-dev] [PATCH v3 2/3] egl/android: #ifdef out flink name support

2018-06-13 Thread Tomasz Figa
Hi Rob, On Sun, Jun 10, 2018 at 2:28 AM Robert Foss wrote: > > From: Rob Herring > > Maintaining both flink names and prime fd support which are provided by > 2 different gralloc implementations is problematic because we have a > dependency on a specific gralloc implementation header. > > This m

Re: [Mesa-dev] [PATCH v3 1/3] gallium/util: Fix build error due to cast to different size

2018-06-13 Thread Tomasz Figa
Hi Rob, On Sun, Jun 10, 2018 at 2:28 AM Robert Foss wrote: > > Signed-off-by: Robert Foss > --- > src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_debug_stack_android.cpp > b/src/galli

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-13 Thread Tomasz Figa
Hi Rob, Thanks for sending v3. Please see few more comments inline. On Sun, Jun 10, 2018 at 2:28 AM Robert Foss wrote: > > This patch both adds support for probing & filtering DRM nodes > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > gralloc call. > > Currently the filteri

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #3 from Jordan Justen --- (In reply to Tapani Pälli from comment #2) > FYI on my Fedora machine, there are failures with this test already with > Mesa 17.3.6 so at least some of these are pretty old issues, before shader > cache was

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #2 from Tapani Pälli --- FYI on my Fedora machine, there are failures with this test already with Mesa 17.3.6 so at least some of these are pretty old issues, before shader cache was turned on. -- You are receiving this mail becaus

Re: [Mesa-dev] [PATCH] mesa: enable EXT_render_snorm extension

2018-06-13 Thread Tapani Pälli
On 06/14/2018 12:58 AM, Eric Anholt wrote: Tapani Pälli writes: Patch sets additional formats renderable and enables the extension when OpenGL ES 3.1 is supported. Signed-off-by: Tapani Pälli --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/fbobject.c | 20

[Mesa-dev] [PATCH] loader_dri3: Handle mismatched depth 30 formats for Prime renderoffload.

2018-06-13 Thread Mario Kleiner
Detect if the display (X-Server) gpu and Prime renderoffload gpu prefer different channel ordering for color depth 30 formats ([X/A]BGR2101010 vs. [X/A]RGB2101010) and perform format conversion during the blitImage() detiling op from tiled backbuffer -> linear buffer. For this we need to find the

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-13 Thread Tomasz Figa
On Thu, Jun 14, 2018 at 4:14 AM Rob Herring wrote: > > On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote: > > On 13 June 2018 at 20:45, Rob Herring wrote: > >> > >> +Amit and John > >> > >> On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss > >> wrote: > >> > This patch both adds support for probi

[Mesa-dev] [Bug 102057] Enabling DSA in COMPATIBILITY PROFILE

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102057 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

Re: [Mesa-dev] [PATCH v2] intel/compiler: Properly consider UBO loads that cross 32B boundaries.

2018-06-13 Thread Jason Ekstrand
On June 13, 2018 19:17:21 Kenneth Graunke wrote: On Wednesday, June 13, 2018 6:52:07 PM PDT Jason Ekstrand wrote: On Wed, Jun 13, 2018 at 6:14 PM, Kenneth Graunke wrote: The UBO push analysis pass incorrectly assumed that all values would fit within a 32B chunk, and only recorded a bit for

Re: [Mesa-dev] [PATCH v2] intel/compiler: Properly consider UBO loads that cross 32B boundaries.

2018-06-13 Thread Kenneth Graunke
On Wednesday, June 13, 2018 6:52:07 PM PDT Jason Ekstrand wrote: > On Wed, Jun 13, 2018 at 6:14 PM, Kenneth Graunke > wrote: > > > The UBO push analysis pass incorrectly assumed that all values would fit > > within a 32B chunk, and only recorded a bit for the 32B chunk containing > > the starting

Re: [Mesa-dev] [PATCH v2] intel/compiler: Properly consider UBO loads that cross 32B boundaries.

2018-06-13 Thread Jason Ekstrand
On Wed, Jun 13, 2018 at 6:14 PM, Kenneth Graunke wrote: > The UBO push analysis pass incorrectly assumed that all values would fit > within a 32B chunk, and only recorded a bit for the 32B chunk containing > the starting offset. > > For example, if a UBO contained the following, tightly packed: >

Re: [Mesa-dev] [PATCH 14/14] intel/compiler: shuffle_64bit_data_for_32bit_write is not used anymore

2018-06-13 Thread Jason Ekstrand
12 and 14 are Reviewed-by: Jason Ekstrand Thanks for working on this! This is very nice clean-up. --Jason On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > --- > src/intel/compiler/brw_fs.h | 4 > src/intel/compiler/brw_fs_nir.cpp | 32

Re: [Mesa-dev] [PATCH 13/14] intel/compiler: use new shuffle_32bit_write for all 64-bit storage writes

2018-06-13 Thread Jason Ekstrand
On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp > b/src/intel/compiler/brw_fs_nir.cpp > ind

Re: [Mesa-dev] [PATCH 11/14] intel/compiler: use shuffle_from_32bit_read for 64-bit FS load_input

2018-06-13 Thread Jason Ekstrand
On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > As the previous use of shuffle_32bit_load_result_to_64bit_data > had a source/destination overlap for 64-bit. Now a temporal destination > s/temporal/temporary/ With that, patches 10 and 11 are Reviewed

Re: [Mesa-dev] [PATCH 09/14] intel/compiler: Use shuffle_from_32bit_read at VS load_input

2018-06-13 Thread Jason Ekstrand
On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > shuffle_from_32bit_read manages 32-bit reads to 32-bit destination > in the same way that the previous loop so now we just call the new > function for all bitsizes, simplifying also the 64-bit load_input.

Re: [Mesa-dev] [PATCH 08/14] intel/compiler: enable shuffle_from_32bit_read at 64-bit gs_input_load

2018-06-13 Thread Jason Ekstrand
How about "Use shuffle_from_32bit_read for 64-bit gs_input_load"? Also, as a general comment, intel/fs would be a bit more specific prefix Reviewed-by: Jason Ekstrand On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > This implementation avoids two unn

Re: [Mesa-dev] [PATCH 07/14] intel/compiler: shuffle_from_32bit_read for 64-bit do_untyped_vector_read

2018-06-13 Thread Jason Ekstrand
On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > do_untyped_vector_read is used at load_ssbo and load_shared. > > The previous MOVs are removed because shuffle_from_32bit_read > can handle storing the shuffle results in the expected destination > just us

Re: [Mesa-dev] [PATCH 06/14] intel/compiler: remove old 16-bit shuffle/unshuffle functions

2018-06-13 Thread Jason Ekstrand
Yes, please. :-) Patches 3-6 are, Reviewed-by: Jason Ekstrand On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > --- > src/intel/compiler/brw_fs.h | 11 -- > src/intel/compiler/brw_fs_nir.cpp | 62 --- > 2 files c

[Mesa-dev] [PATCH v2] intel/compiler: Properly consider UBO loads that cross 32B boundaries.

2018-06-13 Thread Kenneth Graunke
The UBO push analysis pass incorrectly assumed that all values would fit within a 32B chunk, and only recorded a bit for the 32B chunk containing the starting offset. For example, if a UBO contained the following, tightly packed: vec4 a; // [0, 16) float b; // [16, 20) vec4 c; // [20,

Re: [Mesa-dev] [PATCH 05/14] intel/compiler: Use shuffle_from_32bit_write for 16-bits store_ssbo

2018-06-13 Thread Jason Ekstrand
s/from/for/ in the commit message. On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp > b/src/intel/

Re: [Mesa-dev] [PATCH 02/14] intel/compiler: new shuffle_for_32bit_write and shuffle_from_32bit_read

2018-06-13 Thread Jason Ekstrand
On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > These new shuffle functions deal with the shuffle/unshuffle operations > needed for read/write operations using 32-bit components when the > read/written components have a different bit-size (8, 16, 64-bit

[Mesa-dev] [PATCH v2 4/5] mesa/util: add allow_glsl_relaxed_es driconfig override

2018-06-13 Thread Timothy Arceri
This relaxes a number of ES shader restrictions allowing shaders to follow more desktop GLSL like rules. This initial implementation relaxes the following: - allows linking ES shaders with desktop shaders - allows mismatching precision qualifiers - always enables standard derivative builtins

[Mesa-dev] [PATCH v2 3/5] util: add allow_glsl_builtin_const_expression to drirc for Google Earth VR

2018-06-13 Thread Timothy Arceri
--- src/util/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/util/drirc b/src/util/drirc index c76f1ca4380..ff706d16001 100644 --- a/src/util/drirc +++ b/src/util/drirc @@ -176,6 +176,10 @@ TODO: document the other workarounds. + + +

[Mesa-dev] [PATCH v2 2/5] mesa/util: add allow_glsl_builtin_const_expression driconf override

2018-06-13 Thread Timothy Arceri
Google Earth VR shaders uses builtins in constant expressions with GLSL 1.10. That feature wasn't allowed until GLSL 1.20. --- src/compiler/glsl/ast_function.cpp | 3 ++- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 1 + src/gallium/include/state_tracker/st_api.h

[Mesa-dev] [PATCH v2 1/5] util: manually extract the program name from program_invocation_name

2018-06-13 Thread Timothy Arceri
Glibc has the same code to get program_invocation_short_name. However for some reason the short name gets mangled for some wine apps. For example with Google Earth VR I get: program_invocation_name: "/home/tarceri/.local/share/Steam/steamapps/common/EarthVR/Earth.exe" program_invocation_short_na

[Mesa-dev] [PATCH v2 5/5] util: add allow_glsl_relaxed_es to drirc for Google Earth VR

2018-06-13 Thread Timothy Arceri
--- src/util/drirc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/drirc b/src/util/drirc index ff706d16001..7f91035ae8b 100644 --- a/src/util/drirc +++ b/src/util/drirc @@ -178,6 +178,7 @@ TODO: document the other workarounds. +

Re: [Mesa-dev] [PATCH 01/14] intel/compiler: general 8/16/32/64-bit shuffle_src_to_dst function

2018-06-13 Thread Jason Ekstrand
On Wed, Jun 13, 2018 at 5:07 PM, Chema Casanova wrote: > On 13/06/18 22:46, Jason Ekstrand wrote: > > On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com>> wrote: > > > > This new function takes care of shuffle/unshuffle components of a > > particul

Re: [Mesa-dev] [PATCH] glsl: allow standalone semicolons outside main()

2018-06-13 Thread Dave Airlie
On 14 June 2018 at 10:12, Matt Turner wrote: > On Wed, Jun 13, 2018 at 4:53 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> GLSL 4.60 offically added this but games and older CTS suites actually >> had shaders that did this, we may as well enable it everywhere. >> --- >> src/compiler/glsl/gls

Re: [Mesa-dev] [PATCH] glsl: allow standalone semicolons outside main()

2018-06-13 Thread Matt Turner
On Wed, Jun 13, 2018 at 4:53 PM, Dave Airlie wrote: > From: Dave Airlie > > GLSL 4.60 offically added this but games and older CTS suites actually > had shaders that did this, we may as well enable it everywhere. > --- > src/compiler/glsl/glsl_parser.yy | 1 + > 1 file changed, 1 insertion(+) >

Re: [Mesa-dev] [PATCH 01/14] intel/compiler: general 8/16/32/64-bit shuffle_src_to_dst function

2018-06-13 Thread Chema Casanova
On 13/06/18 22:46, Jason Ekstrand wrote: > On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > This new function takes care of shuffle/unshuffle components of a > particular bit-size in components with a different bit-size. > > If sou

Re: [Mesa-dev] [PATCH] radv: Fix output for sparse MRTs.

2018-06-13 Thread Dave Airlie
On 14 June 2018 at 07:35, Bas Nieuwenhuizen wrote: > We need to init the cb_shader_format correctly with the changed > col_format, so this moves the col_format adjustment to before the > adjustment to before the cb_shader_mask gets generated. > > Fixes: 06d3c650980 "radv: fix a GPU hang when MRTs

Re: [Mesa-dev] [PATCH] glsl: allow standalone semicolons outside main()

2018-06-13 Thread Timothy Arceri
On 14/06/18 09:53, Dave Airlie wrote: From: Dave Airlie GLSL 4.60 offically added this but games and older CTS suites actually had shaders that did this, we may as well enable it everywhere. --- src/compiler/glsl/glsl_parser.yy | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compil

[Mesa-dev] [PATCH] glsl: allow standalone semicolons outside main()

2018-06-13 Thread Dave Airlie
From: Dave Airlie GLSL 4.60 offically added this but games and older CTS suites actually had shaders that did this, we may as well enable it everywhere. --- src/compiler/glsl/glsl_parser.yy | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/glsl_parser.yy b/src/compiler/glsl/g

Re: [Mesa-dev] [PATCH 1/4] nv50/ir: add preliminary support for OP_XMAD

2018-06-13 Thread Karol Herbst
On Thu, Jun 14, 2018 at 12:02 AM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 3 ++- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 14 > .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 12 +-- > ..

Re: [Mesa-dev] [PATCH mesa 7/9] vulkan: Add EXT_acquire_xlib_display [v3]

2018-06-13 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > This extension adds the ability to borrow an X RandR output for > temporary use directly by a Vulkan application. For DRM, we use the > Linux resource leasing mechanism. > > v2: > Clean up xlib_lease detection > > * Use sepa

Re: [Mesa-dev] [PATCH] configure.ac/meson.build: Add options for library suffixes

2018-06-13 Thread Benjamin Gordon
On Wed, Jun 13, 2018 at 9:46 AM Dylan Baker wrote: > Quoting Eric Engestrom (2018-06-13 03:03:25) > > On Tuesday, 2018-06-12 11:19:40 -0600, bmgor...@chromium.org wrote: > > > From: Benjamin Gordon > > > > > > When building the Chrome OS Android container, we need to build copies > > > of mesa t

[Mesa-dev] [PATCH v2] configure.ac/meson.build: Add options for library suffixes

2018-06-13 Thread bmgordon
From: Benjamin Gordon When building the Chrome OS Android container, we need to build copies of mesa that don't conflict with the Android system-supplied libraries. This adds options to create suffixed versions of EGL and GLES libraries: libEGL.so -> libEGL${egl-lib-suffix}.so libGLESv1_CM.so ->

[Mesa-dev] [PATCH 0/4] nv50/ir: Improve Performance of Integer Multiplication

2018-06-13 Thread Rhys Perry
Forgot to CC you. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 106903] radv: Fragment shader output goes to wrong attachments when render targets are sparse

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106903 --- Comment #2 from Bas Nieuwenhuizen --- https://patchwork.freedesktop.org/patch/229361/ should fix this. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [PATCH 0/4] nv50/ir: Improve Performance of Integer Multiplication

2018-06-13 Thread Rhys Perry
This series improve the performance of integer multiplication by removing much usage of the very slow IMAD and IMUL. It depends on the SHLADD/IndirectPropagation patches. The first and second patch add support for the XMAD instruction in codegen The third patch replaces most IMADs and IMULs with

[Mesa-dev] [PATCH 2/4] gm107/ir: add support for OP_XMAD on GM107+

2018-06-13 Thread Rhys Perry
Signed-off-by: Rhys Perry --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 61 ++ .../nouveau/codegen/nv50_ir_target_gm107.cpp | 6 ++- .../nouveau/codegen/nv50_ir_target_nvc0.cpp| 1 + 3 files changed, 67 insertions(+), 1 deletion(-) diff --git a/src/

[Mesa-dev] [PATCH 1/4] nv50/ir: add preliminary support for OP_XMAD

2018-06-13 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 3 ++- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 14 .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 12 +-- .../drivers/nouveau/codegen/nv50_ir_print.cpp | 20 +++

[Mesa-dev] [PATCH 4/4] nv50/ir: further optimize multiplication by immediates

2018-06-13 Thread Rhys Perry
Strongly mitigates the harm from the previous commit, which made many integer multiplications much more heavy on the register and instruction count. total instructions in shared programs : 5294693 -> 5268293 (-0.50%) total gprs used in shared programs: 624962 -> 624196 (-0.12%) total shared us

[Mesa-dev] [PATCH 3/4] nv50/ir: optimize imul/imad to xmads

2018-06-13 Thread Rhys Perry
This hits the shader-db numbers a good bit, though a few xmads is way faster than an imul or imad and the cost is mitigated by the next commit, which optimizes many multiplications by immediates into shorter and less register heavy instructions than the xmads. total instructions in shared programs

Re: [Mesa-dev] [PATCH] mesa: enable EXT_render_snorm extension

2018-06-13 Thread Eric Anholt
Tapani Pälli writes: > Patch sets additional formats renderable and enables the extension > when OpenGL ES 3.1 is supported. > > Signed-off-by: Tapani Pälli > --- > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/fbobject.c | 20 +++- > src/mesa/main/glformats.c

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-13 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > This adds support for the KHR_display extension to the anv Vulkan > driver. The driver now attempts to open the master DRM node when the > KHR_display extension is requested so that the common winsys code can > perform the necessary operati

Re: [Mesa-dev] [PATCH mesa 3/9] radv: Add KHR_display extension to radv [v4]

2018-06-13 Thread Jason Ekstrand
On Wed, Jun 13, 2018 at 2:46 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > With the caveat that I have no idea how the amdgpu kernel interface works. :-) > On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > >> This adds support for the KHR_display extension to the radv Vulk

Re: [Mesa-dev] [PATCH mesa 3/9] radv: Add KHR_display extension to radv [v4]

2018-06-13 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > This adds support for the KHR_display extension to the radv Vulkan > driver. The driver now attempts to open the master DRM node when the > KHR_display extension is requested so that the common winsys code can

Re: [Mesa-dev] [PATCH mesa 4/9] vulkan: Add EXT_direct_mode_display [v2]

2018-06-13 Thread Jason Ekstrand
patches 4-6 are Reviewed-by: Jason Ekstrand On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > Add support for the EXT_direct_mode_display extension. This just > provides the vkReleaseDisplayEXT function. > > v2: > Adopt Jason Ekstrand's coding conventions > > Declare var

Re: [Mesa-dev] [PATCH mesa 04/21] vulkan: Add EXT_direct_mode_display

2018-06-13 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 9:32 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > This seems a bit odd. Why is the FD not stored in the display? What if > > you acquire multiple displays for two-player VR? If the master FD passed > > in is not -1, we could just create a VkDisplayKHR object

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-13 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > This adds support for the KHR_display extension to the anv Vulkan > driver. The driver now attempts to open the master DRM node when the > KHR_display extension is requested so that the common winsys code can > perform the necessary operati

Re: [Mesa-dev] [PATCH mesa 1/9] vulkan: Add KHR_display extension using DRM [v8]

2018-06-13 Thread Jason Ekstrand
I'm trusting that not much changed other than what was explicitly called out. I didn't want to re-read in *that* much detail again. :-) Reviewed-by: Jason Ekstrand On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > This adds support for the KHR_display extension support to the vulkan

[Mesa-dev] [PATCH] radv: Fix output for sparse MRTs.

2018-06-13 Thread Bas Nieuwenhuizen
We need to init the cb_shader_format correctly with the changed col_format, so this moves the col_format adjustment to before the adjustment to before the cb_shader_mask gets generated. Fixes: 06d3c650980 "radv: fix a GPU hang when MRTs are sparse" Bugzilla: https://bugs.freedesktop.org/show_bug.c

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #1 from Jordan Justen --- Any chance you might be able to write a small piglit test that shows the bug? For example: https://cgit.freedesktop.org/piglit/commit/?id=f1dc46ddf8c1 -- You are receiving this mail because: You are the Q

Re: [Mesa-dev] [PATCH 01/14] intel/compiler: general 8/16/32/64-bit shuffle_src_to_dst function

2018-06-13 Thread Jason Ekstrand
On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > This new function takes care of shuffle/unshuffle components of a > particular bit-size in components with a different bit-size. > > If source type size is smaller than destination type size the operation

[Mesa-dev] [PATCH 1/8] i965/bufmgr: Bail early in bo_busy if the BO is flagged idle

2018-06-13 Thread Jason Ekstrand
This has the potential to make brw_bo_busy a bit cheaper for internal BOs if someone has checked it for busy or waited on it before. We already do the same thing in brw_bo_wait. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH 5/8] i965/batch: Use brw_bo_unreference_bos_when_idle

2018-06-13 Thread Jason Ekstrand
Instead of unreferencing all the BOs used by the freshly submitted batch directly, ask the bufmgr to unref them for us once the batch goes idle. This should more-or-less have the same effect except that we now wait to unref the BOs until the batch is idle. --- src/mesa/drivers/dri/i965/intel_batch

[Mesa-dev] [PATCH 8/8] i965/bufmgr: Allocate from the tail of the bucket free list

2018-06-13 Thread Jason Ekstrand
The previous approach gave a sort of round-robin behavior which made sense because we didn't want to walk the entire list looking for the first idle BO. Now that everything is idle, we can pick any BO in the list and it should be fine. Using the most recently used BO should give us less over-all

[Mesa-dev] [PATCH 2/8] i965/miptree: Stop setting BO_ALLOC_BUSY

2018-06-13 Thread Jason Ekstrand
It was never all that useful and no one had really demonstrated the value of it in any concrete way. It is, however, a very easy way to run into trouble if you're not careful. Let's just drop it and hope to solve whatever problems it was solving in some other way. --- src/mesa/drivers/dri/i965/i

[Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-13 Thread Jason Ekstrand
The current BO cache puts BOs back into the recycle bucket the moment the refcount hits zero. If the BO is busy, we just don't re-use it until it isn't or we re-use it for a render target which we assume will be used first for drawing. This patch series reworks the way the BO cache works a bit so

[Mesa-dev] [PATCH 3/8] i965/bufmgr: Drop the BO_ALLOC_BUSY flag

2018-06-13 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_bufmgr.c | 46 ++ src/mesa/drivers/dri/i965/brw_bufmgr.h | 1 - 2 files changed, 10 insertions(+), 37 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 58bb559fdee..e9d3daa598

[Mesa-dev] [PATCH 6/8] i965: Call intel_finish before destroying the context

2018-06-13 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_context.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 9ced230ec14..98ec54f2ae3 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++ b/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 7/8] i965/bufmgr: Don't allow busy BOs to be returned to the pool

2018-06-13 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_bufmgr.c | 51 -- 1 file changed, 32 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index cfa32ff3726..ef918315c65 100644 --- a/src/mesa/drivers/dri/i965/brw_buf

[Mesa-dev] [PATCH 4/8] i965/bufmgr: Add a garbage collection mechanism

2018-06-13 Thread Jason Ekstrand
While we can always trust the kernel to reference count things and not actually free any memory until the GPU is done with it, that may not actually do what we want. We have to be careful, for instance, with recycling buffers that we might immediately map. This commit provides a tagging mechanism

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 Samuel Pitoiset changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this m

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-13 Thread Rob Herring
On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote: > On 13 June 2018 at 20:45, Rob Herring wrote: >> >> +Amit and John >> >> On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss >> wrote: >> > This patch both adds support for probing & filtering DRM nodes >> > and switches away from using the GRALLOC

[Mesa-dev] [Bug 106696] repeatable drm:amdgpu_job_timedout with vulkan toy

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106696 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|REOPENED

[Mesa-dev] [Bug 106479] NDEBUG not defined for libamdgpu_addrlib

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106479 Samuel Pitoiset changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 106677] vmwgfx: atom (electron-based app) causes corruption, hangs

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106677 --- Comment #4 from David Cuthbert --- Note that it takes some fiddling to reproduce this currently (the exact trigger isn't known). I can go hours without seeing this issue. I've been banging my head against the wall trying to get my extra log

[Mesa-dev] [PATCH 2/2] radv: don't check for linear images in emit_fast_color_clear()

2018-06-13 Thread Samuel Pitoiset
We don't enable CMASK for linear surfaces and addrlib only enables DCC for tiling surfaces. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index 28050079f

[Mesa-dev] [PATCH 1/2] radv: don't check the number of levels in emit_fast_color_clear()

2018-06-13 Thread Samuel Pitoiset
This is useless because we don't support DCC/CMASK for mipmaps. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index fae441ceb66..28050079f92 100644 ---

[Mesa-dev] [Bug 106912] radv: 16-bit depth buffer causes artifacts in Shadow Warrior 2

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106912 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] radv: don't fast clear HTILE for 16-bit depth surfaces on GFX8

2018-06-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Jun 13, 2018 at 8:19 PM, Samuel Pitoiset wrote: > This causes rendering issues in Shadow Warrior 2 with DXVK. > > Cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106912 > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH] radv: don't fast clear HTILE for 16-bit depth surfaces on GFX8

2018-06-13 Thread Samuel Pitoiset
This causes rendering issues in Shadow Warrior 2 with DXVK. Cc: mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106912 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 8 1 file changed, 8 insertions(+) diff --git a/src/amd/

[Mesa-dev] [Bug 106677] vmwgfx: atom (electron-based app) causes corruption, hangs

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106677 --- Comment #3 from Thomas Hellström --- FWIW, no apparent problems on Fedora Rawhide with 4.18.0-rc0. /Thomas -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

Re: [Mesa-dev] [PATCH 08/13] i965/miptree: Share the miptree format in miptree_create

2018-06-13 Thread Pohjolainen, Topi
On Wed, Jun 13, 2018 at 09:20:55AM -0700, Nanley Chery wrote: > On Wed, Jun 13, 2018 at 09:33:41AM +0300, Pohjolainen, Topi wrote: > > On Tue, Jun 12, 2018 at 12:22:00PM -0700, Nanley Chery wrote: > > > --- > > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 30 +-- > > > 1 file

Re: [Mesa-dev] [PATCH 10/13] i965/miptree: Add and use mt_surf_usage

2018-06-13 Thread Pohjolainen, Topi
On Wed, Jun 13, 2018 at 09:25:37AM -0700, Nanley Chery wrote: > On Wed, Jun 13, 2018 at 09:39:08AM +0300, Pohjolainen, Topi wrote: > > On Tue, Jun 12, 2018 at 12:22:02PM -0700, Nanley Chery wrote: > > > --- > > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 --- > > > 1 file

Re: [Mesa-dev] [PATCH 2/2] glsl: Don't copy propagate elements from SSBO or shared variables either

2018-06-13 Thread Caio Marcelo de Oliveira Filho
Reviewed-by: Caio Marcelo de Oliveira Filho On Tue, Jun 12, 2018 at 03:48:14PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Since SSBOs can be written, copy propagating a read can cause the > value to magically change. SSBO reads are also very expensive, so > doing it twice will be slo

Re: [Mesa-dev] [PATCH 1/2] glsl: Don't copy propagate from SSBO or shared variables either

2018-06-13 Thread Caio Marcelo de Oliveira Filho
Reviewed-by: Caio Marcelo de Oliveira Filho On Tue, Jun 12, 2018 at 03:48:13PM -0700, Ian Romanick wrote: > From: Ian Romanick > > Since SSBOs can be written, copy propagating a read can cause the Optional: maybe write "... can be written by other threads"? > value to magically change. SSBO

[Mesa-dev] [Bug 106677] vmwgfx: atom (electron-based app) causes corruption, hangs

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106677 --- Comment #2 from Deepak --- (In reply to David Cuthbert from comment #0) > I'm filing this currently so I have a place to keep notes on this bug. > > Running the atom text editor under various OSes (tried Linux Mint 18.3, > Ubuntu 18.04, and

Re: [Mesa-dev] [PATCH 11/13] i965/miptree: Refactor miptree_create

2018-06-13 Thread Nanley Chery
On Wed, Jun 13, 2018 at 09:44:14AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 12, 2018 at 12:22:03PM -0700, Nanley Chery wrote: > > Enable a future patch to create the r8stencil_mt in this function. > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 48 +-- > > 1 file c

Re: [Mesa-dev] [PATCH 1/3] meson: Fix -latomic check

2018-06-13 Thread Matt Turner
On Wed, Jun 13, 2018 at 8:37 AM, Dylan Baker wrote: > Quoting Matt Turner (2018-06-12 17:50:20) >> Commit 54ba73ef102f (configure.ac/meson.build: Fix -latomic test) fixed >> some checks for -latomic, and then commit 54bbe600ec26 (configure.ac: >> rework -latomic check) further extended the fixes i

[Mesa-dev] [Bug 106912] radv: 16-bit depth buffer causes artifacts in Shadow Warrior 2

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106912 --- Comment #1 from Samuel Pitoiset --- Can you explain how to reproduce the issue in-game? I would like to know if Vega is affected as well. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

Re: [Mesa-dev] [PATCH 10/13] i965/miptree: Add and use mt_surf_usage

2018-06-13 Thread Nanley Chery
On Wed, Jun 13, 2018 at 09:39:08AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 12, 2018 at 12:22:02PM -0700, Nanley Chery wrote: > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 --- > > 1 file changed, 26 insertions(+), 14 deletions(-) > > > > diff --git a/src/mes

Re: [Mesa-dev] [PATCH] intel/compiler: Properly consider UBO loads that cross 32B boundaries.

2018-06-13 Thread Jason Ekstrand
I just reverted this in master because it regressed about 30K Vulkan CTS tests. More investigation needed? On Wed, Jun 13, 2018 at 2:07 AM, Kenneth Graunke wrote: > On Tuesday, June 12, 2018 1:38:03 PM PDT Rafael Antognolli wrote: > > On Mon, Jun 11, 2018 at 02:01:49PM -0700, Kenneth Graunke wr

Re: [Mesa-dev] [PATCH 08/13] i965/miptree: Share the miptree format in miptree_create

2018-06-13 Thread Nanley Chery
On Wed, Jun 13, 2018 at 09:33:41AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 12, 2018 at 12:22:00PM -0700, Nanley Chery wrote: > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 30 +-- > > 1 file changed, 15 insertions(+), 15 deletions(-) > > > > diff --git a/src/mes

Re: [Mesa-dev] [PATCH 04/13] i965/draw: Fix adding the stencil bo to the depth cache

2018-06-13 Thread Nanley Chery
On Wed, Jun 13, 2018 at 09:25:02AM +0300, Pohjolainen, Topi wrote: > On Tue, Jun 12, 2018 at 12:21:56PM -0700, Nanley Chery wrote: > > Fix the case where only stencil writes are enabled on a depth stencil > > Isn't this an issue even when depth writes are enabled? Both would add the > same bo to c

Re: [Mesa-dev] [PATCH] configure.ac/meson.build: Add options for library suffixes

2018-06-13 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-13 03:03:25) > On Tuesday, 2018-06-12 11:19:40 -0600, bmgor...@chromium.org wrote: > > From: Benjamin Gordon > > > > When building the Chrome OS Android container, we need to build copies > > of mesa that don't conflict with the Android system-supplied libraries. >

Re: [Mesa-dev] [PATCH 1/3] meson: Fix -latomic check

2018-06-13 Thread Dylan Baker
Quoting Matt Turner (2018-06-12 17:50:20) > Commit 54ba73ef102f (configure.ac/meson.build: Fix -latomic test) fixed > some checks for -latomic, and then commit 54bbe600ec26 (configure.ac: > rework -latomic check) further extended the fixes in configure.ac but > not in Meson. This commit extends tho

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-13 Thread Rob Herring
+Amit and John On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss wrote: > This patch both adds support for probing & filtering DRM nodes > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > gralloc call. > > Currently the filtering is based just on the driver name, > and the desired

[Mesa-dev] [Bug 106912] radv: 16-bit depth buffer causes artifacts in Shadow Warrior 2

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106912 Bug ID: 106912 Summary: radv: 16-bit depth buffer causes artifacts in Shadow Warrior 2 Product: Mesa Version: git Hardware: Other OS: All Statu

[Mesa-dev] [Bug 106897] Ubuntu 16.04. Mesa can't be built with specified configurations

2018-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106897 --- Comment #7 from Timo Aaltonen --- such is life, 16.04 won't get a newer wayland, but 18.04 will.. eventually for now, you can use a ppa for a backport with the necessary packaging changes: https://launchpad.net/~ubuntu-x-swat/+archive/ubun

Re: [Mesa-dev] [PATCH 1/2] ac/gpu_info: report real total memory sizes

2018-06-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for both. Thanks! On Wed, Jun 13, 2018 at 3:15 AM, Marek Olšák wrote: > From: Marek Olšák > > The change from MIN2 to MAX2 is intentional. > --- > src/amd/common/ac_gpu_info.c | 82 > 1 file changed, 54 insertions(+), 28 dele

Re: [Mesa-dev] [PATCH v3] radv: update the ZRANGE_PRECISION value for the TC-compat bug

2018-06-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Jun 13, 2018 at 2:27 PM, Samuel Pitoiset wrote: > On GFX8+, there is a bug that affects TC-compatible depth surfaces > when the ZRange is not reset after LateZ kills pixels. > > The workaround is to always set DB_Z_INFO.ZRANGE_PRECISION to match > the last

[Mesa-dev] [PATCH v3] radv: update the ZRANGE_PRECISION value for the TC-compat bug

2018-06-13 Thread Samuel Pitoiset
On GFX8+, there is a bug that affects TC-compatible depth surfaces when the ZRange is not reset after LateZ kills pixels. The workaround is to always set DB_Z_INFO.ZRANGE_PRECISION to match the last fast clear value. Because the value is set to 1 by default, we only need to update it when clearing

Re: [Mesa-dev] [PATCH] virgl: add ARB_tessellation_shader support. (v2)

2018-06-13 Thread Elie Tournier
On Wed, Jun 13, 2018 at 11:03:55AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This should add all the pieces to enable tess shaders on virgl. > > v2: fixup transform to handle tess and strip out precise. > set default for max patch varyings to work around issue when > tess gets enabled fr

Re: [Mesa-dev] Mesa GitLab access approval process

2018-06-13 Thread Rob Clark
On Wed, Jun 13, 2018 at 12:43 AM, Jason Ekstrand wrote: > Since we've been on GitLab (it's been less than a week), we've already > gotten a couple of developer access requests through GitLab. As it stands, > these just show up as an e-mail to the group owners with zero explanation or > opportunit

Re: [Mesa-dev] [PATCH 1/3] meson: Fix -latomic check

2018-06-13 Thread Eric Engestrom
On Tuesday, 2018-06-12 17:50:20 -0700, Matt Turner wrote: > Commit 54ba73ef102f (configure.ac/meson.build: Fix -latomic test) fixed > some checks for -latomic, and then commit 54bbe600ec26 (configure.ac: > rework -latomic check) further extended the fixes in configure.ac but > not in Meson. This co

  1   2   >