[Mesa-dev] [Bug 106351] Freezes with plasmashell and steam client

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106351 Michel Dänzer changed: What|Removed |Added CC||tobias.johannes.klausmann@m

[Mesa-dev] [Bug 106351] Freezes with plasmashell and steam client

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106351 Markus Rathgeb changed: What|Removed |Added CC||maggu2...@gmail.com -- You are receiv

[Mesa-dev] [Bug 106536] glXWaitVideoSyncSGI blocks forever

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106536 Bug ID: 106536 Summary: glXWaitVideoSyncSGI blocks forever Product: Mesa Version: 18.0 Hardware: Other OS: All Status: NEW Severity: normal Pri

Re: [Mesa-dev] [PATCH 9.5/17] squash! i965/miptree: Unify aux buffer allocation

2018-05-15 Thread Pohjolainen, Topi
On Wed, May 09, 2018 at 10:47:24AM -0700, Nanley Chery wrote: > v2: Inline the switch statement (Jason) > > Reviewed-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 90 --- > 1 file changed, 38 insertions(+), 52 deletions(-) > > diff --git a/src/mesa/d

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-15 Thread Pohjolainen, Topi
On Tue, May 08, 2018 at 02:05:37PM -0700, Nanley Chery wrote: > On Tue, May 08, 2018 at 08:31:39AM +0300, Pohjolainen, Topi wrote: > > On Mon, May 07, 2018 at 10:11:39AM -0700, Nanley Chery wrote: > > > On Mon, May 07, 2018 at 11:30:15AM +0300, Pohjolainen, Topi wrote: > > > > On Thu, May 03, 2018

Re: [Mesa-dev] [PATCH 13/17] i965: Update the indirect buffer in set_clear_color

2018-05-15 Thread Pohjolainen, Topi
On Tue, May 08, 2018 at 02:55:24PM -0700, Nanley Chery wrote: > On Tue, May 08, 2018 at 09:24:19AM +0300, Pohjolainen, Topi wrote: > > On Thu, May 03, 2018 at 12:04:00PM -0700, Nanley Chery wrote: > > > Although BLORP currently does the update when performing a fast clear, > > > it's simpler to do

Re: [Mesa-dev] [PATCH] android: enable VK_ANDROID_native_buffer

2018-05-15 Thread Tapani Pälli
On 05/16/2018 08:46 AM, Jason Ekstrand wrote: On Tue, May 15, 2018 at 10:42 PM, Tapani Pälli > wrote: Patch changes entrypoints generator to not skip this extension even though it is set as disabled in the xml. We also need compilation flag VK_USE_PLA

Re: [Mesa-dev] [PATCH] android: enable VK_ANDROID_native_buffer

2018-05-15 Thread Jason Ekstrand
On Tue, May 15, 2018 at 10:42 PM, Tapani Pälli wrote: > Patch changes entrypoints generator to not skip this extension even > though it is set as disabled in the xml. We also need compilation > flag VK_USE_PLATFORM_ANDROID_KHR to be enabled and a small fix to > vk_icd.h because of following compi

[Mesa-dev] [PATCH] android: enable VK_ANDROID_native_buffer

2018-05-15 Thread Tapani Pälli
Patch changes entrypoints generator to not skip this extension even though it is set as disabled in the xml. We also need compilation flag VK_USE_PLATFORM_ANDROID_KHR to be enabled and a small fix to vk_icd.h because of following compilation error: vk_icd.h:116:5: error: must use 'struct' tag to r

[Mesa-dev] [PATCH v2 1/2] ignore some compile warning on android

2018-05-15 Thread jenny.q.cao
resend, pls ingore the previous mail force cast the I to GLint to avoid the compile warning when type is GLenum16, in vendor/intel/external/mesa3d-intel/src/mesa/main/get.c:3005:19: warning: comparison of constant -32768 with expression of type 'GLenum16' (aka 'unsigned short') is always false -

[Mesa-dev] [PATCH v2 1/2] Update for fix or ignore the compile warning on android

2018-05-15 Thread jenny.q.cao
force cast the I to GLint to avoid the compile warning when type is GLenum16, in vendor/intel/external/mesa3d-intel/src/mesa/main/get.c:3005:19: warning: comparison of constant -32768 with expression of type 'GLenum16' (aka 'unsigned short') is always false -Wtautologicalia-constant-out-of-range-

[Mesa-dev] [PATCH] ac/llvm: use amdgcn.tbuffer.store instead of SI.tbuffer.store intrinsic

2018-05-15 Thread Dave Airlie
From: Dave Airlie Drop the use of the old intrinsic. --- src/amd/common/ac_llvm_build.c | 92 +++--- 1 file changed, 60 insertions(+), 32 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index c9b2e36b632..18a624a0dae

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Timothy Arceri
On 16/05/18 09:41, Marek Olšák wrote: On Tue, May 15, 2018 at 4:59 PM, Jason Ekstrand > wrote: On Tue, May 15, 2018 at 1:38 PM, Marek Olšák mailto:mar...@gmail.com>> wrote: On Tue, May 15, 2018 at 4:09 PM, Ilia Mirkin mailto:imir...@alum.mit.ed

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Marek Olšák
On Tue, May 15, 2018 at 4:59 PM, Jason Ekstrand wrote: > On Tue, May 15, 2018 at 1:38 PM, Marek Olšák wrote: > >> On Tue, May 15, 2018 at 4:09 PM, Ilia Mirkin >> wrote: >> >>> On Tue, May 15, 2018 at 3:54 PM, Marek Olšák wrote: >>> > On Tue, May 15, 2018 at 3:36 PM, Ilia Mirkin >>> wrote: >>>

Re: [Mesa-dev] [PATCH] gallium/hud: add frametime graph (v2)

2018-05-15 Thread Marek Olšák
Pushed, thanks! Marek On Tue, May 15, 2018 at 5:09 PM, Matthias Groß wrote: > Thanks for your comment. This version has an additional boolean in the > fps_info struct to distinguish between fps and frame time calculation. > The struct is initialised in the respecting install functions for this

Re: [Mesa-dev] [PATCH v2 1/1] eg/compute: Use reference counting to handle compute memory pool.

2018-05-15 Thread Dave Airlie
On 16 May 2018 at 08:06, Jan Vesely wrote: > On Wed, 2018-05-09 at 15:54 -0400, Jan Vesely wrote: >> Use pipe_refernce to release old RAT surfaces. >> RAT surface adds a reference to pool bo. So use reference counting for >> pool->bo >> as well. >> >> v2: Use the same pattern for both defrag path

[Mesa-dev] [PATCH 9/9] intel/blorp: Refactor MCS clears

2018-05-15 Thread Jason Ekstrand
This commit renames blorp_fast_clear to blorp_mcs_clear, pulls in the fast clear rectangle calculation into the function, and removes the unneeded level parameter. We could have also removed the x0, y0, x1, and y1 parameters because all of the callers only do full-slice clears. However, partial cl

[Mesa-dev] [PATCH 8/9] intel/blorp: Handle fast-clear directly in blorp_ccs_op

2018-05-15 Thread Jason Ekstrand
--- src/intel/blorp/blorp_clear.c | 199 +++--- 1 file changed, 88 insertions(+), 111 deletions(-) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index 39bc0c6..5625221 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp

[Mesa-dev] [PATCH 6/9] intel/blorp: Make blorp_ccs_ambiguate just an internal helper

2018-05-15 Thread Jason Ekstrand
Now that anv uses blorp_ccs_op for everything, we no longer need to expose the ccs_ambiguate function directly. It's much better tucked away as an implementation detail. --- src/intel/blorp/blorp.h | 5 - src/intel/blorp/blorp_clear.c | 21 ++--- 2 files changed, 10 ins

[Mesa-dev] [PATCH 2/9] intel/blorp: Use the hardware op for CCS ambiguate on gen10+

2018-05-15 Thread Jason Ekstrand
Cannonlake hardware adds a new resolve type in 3DSTATE_PS called FAST_CLEAR_0 which does an ambiguate. Now that the hardware can do it directly, we should use that instead of binding the CCS as a render target and doing it manually. This was tested with a full Vulkan CTS run on Cannonlake. --- s

[Mesa-dev] [PATCH 7/9] i965: Use blorp_ccs_op for CCS fast-clears

2018-05-15 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index dab04f2..b6097f5 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++ b/src/mesa/drivers

[Mesa-dev] [PATCH 5/9] anv/blorp: Use blorp_ccs_op for everything

2018-05-15 Thread Jason Ekstrand
--- src/intel/vulkan/anv_blorp.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 7c4a022..d71a648 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/anv_blorp.c @@ -170

[Mesa-dev] [PATCH 4/9] intel/blorp: Simplify asserts in blorp_ccs_op

2018-05-15 Thread Jason Ekstrand
If we use any invalid CCS ops for a particular platform, we will hit an unreachable() in the blorp back-end. The only on CCS op not supported by this function at the moment is fast-clear. --- src/intel/blorp/blorp_clear.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --

[Mesa-dev] [PATCH 0/9] intel/blorp: Refactors, cleanups, and fixes

2018-05-15 Thread Jason Ekstrand
This little series makes a bunch of mostly small changes to blorp. The end objective is to get to the point where you just call blorp_ccs_op and hand it an isl_aux_op instead of having different entrypoints for everything. This is similar to what we do for HiZ. For MCS, we still have two function

[Mesa-dev] [PATCH 3/9] intel/blorp: Rename blorp_ccs_resolve to blorp_ccs_op

2018-05-15 Thread Jason Ekstrand
We also make it capable of handling any aux op including fast-clear and ambiguate. --- src/intel/blorp/blorp.h | 10 src/intel/blorp/blorp_clear.c | 46 --- src/intel/vulkan/anv_blorp.c | 4 +-- src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 1/9] intel/blorp: Only double the fast-clear rect alignment on HSW

2018-05-15 Thread Jason Ekstrand
The data in the commit message is a bit sketchy for Ivybridge. We don't run dEQP or any of the CTSs on Ivybridge in CI so all the data we have is piglit. On Haswell, piglit didn't catch anything so we don't have anything to go off of for Ivybridge besides the fact that the restriction wasn't adde

Re: [Mesa-dev] [PATCH v2 1/1] eg/compute: Use reference counting to handle compute memory pool.

2018-05-15 Thread Jan Vesely
On Wed, 2018-05-09 at 15:54 -0400, Jan Vesely wrote: > Use pipe_refernce to release old RAT surfaces. > RAT surface adds a reference to pool bo. So use reference counting for > pool->bo > as well. > > v2: Use the same pattern for both defrag paths > Drop confusing comment > > CC: > Signed-o

[Mesa-dev] [Bug 106090] Compiling compute shader crashes RADV

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106090 --- Comment #2 from mais...@archlinux.us --- Yup, works fine now. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list

[Mesa-dev] [PATCH] gallium/hud: add frametime graph (v2)

2018-05-15 Thread Matthias Groß
Thanks for your comment. This version has an additional boolean in the fps_info struct to distinguish between fps and frame time calculation. The struct is initialised in the respecting install functions for this purpose. --- src/gallium/auxiliary/hud/hud_context.c | 4 +++ src/gallium/auxiliary/

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Jason Ekstrand
On Tue, May 15, 2018 at 1:38 PM, Marek Olšák wrote: > On Tue, May 15, 2018 at 4:09 PM, Ilia Mirkin wrote: > >> On Tue, May 15, 2018 at 3:54 PM, Marek Olšák wrote: >> > On Tue, May 15, 2018 at 3:36 PM, Ilia Mirkin >> wrote: >> >> >> >> The extension is totally different... it adds things like "

Re: [Mesa-dev] [PATCH] radv: add generated files to .gitignore(s)

2018-05-15 Thread Samuel Pitoiset
Pushed, thanks! On 05/15/2018 03:52 PM, Dieter Nützel wrote: Hello Bas, sorry I have some trouble with 'git send-email' (configuration) Command unknown: 'AUTH' at /usr/lib/git/git-send-email line 1455 currently, so I send it this way. Dieter ___

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Marek Olšák
On Tue, May 15, 2018 at 4:09 PM, Ilia Mirkin wrote: > On Tue, May 15, 2018 at 3:54 PM, Marek Olšák wrote: > > On Tue, May 15, 2018 at 3:36 PM, Ilia Mirkin > wrote: > >> > >> The extension is totally different... it adds things like "unsigned > >> int", and a ton of texture*/shadow* variants. If

[Mesa-dev] [Bug 106504] vulkan SPIR-V parsing failed at ../src/compiler/spirv/vtn_cfg.c:381

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106504 Jason Ekstrand changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] radv: only declare the ESGS rings for pre GFX9 chips

2018-05-15 Thread Samuel Pitoiset
GFX9 uses LDS instead. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index b4af0f29415..95bc860e66c 100644 --- a/src/a

[Mesa-dev] [Bug 105613] Compute shader locks up within nested "for" loop

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105613 Samuel Pitoiset changed: What|Removed |Added Severity|normal |critical Priority|medium

[Mesa-dev] [Bug 100424] X hang (in kernel) after some event in Serious Sam Fusion using radv. 4.9/amd-staging-4.9

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100424 --- Comment #6 from Samuel Pitoiset --- Closing, I have tried to reproduce the issue yesterday (again), maybe I'm unlucky and not good enough at playing games, but it worked perfectly fine (tested on Vega 56). Feel free to re-open. Thanks! --

[Mesa-dev] [Bug 100424] X hang (in kernel) after some event in Serious Sam Fusion using radv. 4.9/amd-staging-4.9

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100424 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Ilia Mirkin
On Tue, May 15, 2018 at 3:54 PM, Marek Olšák wrote: > On Tue, May 15, 2018 at 3:36 PM, Ilia Mirkin wrote: >> >> The extension is totally different... it adds things like "unsigned >> int", and a ton of texture*/shadow* variants. If it helps this one >> shader compile, that's a coincidence. IMO it

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104302 --- Comment #19 from Samuel Pitoiset --- Yeah, it's a LLVM issue. I partially figured out the problem but it's hard to fix it correctly. I will let you know when I have something better. -- You are receiving this mail because: You are the QA C

[Mesa-dev] [Bug 104329] Vulkan app crashes GPU

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104329 Samuel Pitoiset changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100430 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Marek Olšák
On Tue, May 15, 2018 at 3:36 PM, Ilia Mirkin wrote: > The extension is totally different... it adds things like "unsigned > int", and a ton of texture*/shadow* variants. If it helps this one > shader compile, that's a coincidence. IMO it's dangerous to start > throwing things like this in. > Tha

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Marek Olšák
On Tue, May 15, 2018 at 3:36 PM, Bas Nieuwenhuizen wrote: > On Tue, May 15, 2018 at 9:34 PM, Marek Olšák wrote: > > On Tue, May 15, 2018 at 3:32 PM, Bas Nieuwenhuizen < > b...@basnieuwenhuizen.nl> > > wrote: > >> > >> No, this is a vulkan issue, where we want to let apps create linear > >> RGB f

[Mesa-dev] [Bug 103852] Rendering errors when running dolphin-emu with Vulkan backend, radv (Super Smash Bros. Melee)

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103852 Ben Clapp changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 106090] Compiling compute shader crashes RADV

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106090 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 106504] vulkan SPIR-V parsing failed at ../src/compiler/spirv/vtn_cfg.c:381

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106504 --- Comment #1 from Samuel Pitoiset --- Should be fixed with https://cgit.freedesktop.org/mesa/mesa/commit/?id=6bde8c560877512852ff49fafa296eb71a5ec14b -- You are receiving this mail because: You are the assignee for the bug.__

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Bas Nieuwenhuizen
On Tue, May 15, 2018 at 9:34 PM, Marek Olšák wrote: > On Tue, May 15, 2018 at 3:32 PM, Bas Nieuwenhuizen > wrote: >> >> No, this is a vulkan issue, where we want to let apps create linear >> RGB float surfaces. (AMDVLK exposes this too: >> http://vulkan.gpuinfo.org/displayreport.php?id=3222#forma

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Ilia Mirkin
The extension is totally different... it adds things like "unsigned int", and a ton of texture*/shadow* variants. If it helps this one shader compile, that's a coincidence. IMO it's dangerous to start throwing things like this in. -ilia On Mon, May 14, 2018 at 10:32 PM, Timothy Arceri wrote: >

Re: [Mesa-dev] [Mesa-stable] [PATCH] amd/addrlib: Use defines in autotools build.

2018-05-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, May 14, 2018 at 11:48 AM, Bas Nieuwenhuizen wrote: > Otherwise stuff like NDEBUG would not be passed through. > > CC: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106479 > --- > src/amd/Makefile.addrlib.am | 1 + > 1 file changed, 1 insertio

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Marek Olšák
On Tue, May 15, 2018 at 3:32 PM, Bas Nieuwenhuizen wrote: > No, this is a vulkan issue, where we want to let apps create linear > RGB float surfaces. (AMDVLK exposes this too: > http://vulkan.gpuinfo.org/displayreport.php?id=3222#formats, see > R32G32B32_SFLOAT and friends) Vulkan has no conecept

Re: [Mesa-dev] [PATCH v2] spirv: fix visiting inner loops with same break/continue block

2018-05-15 Thread Samuel Pitoiset
On 05/15/2018 05:56 PM, Jason Ekstrand wrote: I don't think this does the right thing in the switch fall-through case but it will at least fail with a reasonable assert instead of just doing the wrong thing. Yeah, I'm not sure but that could be fixed later if we hit the situation. Thanks fo

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Bas Nieuwenhuizen
No, this is a vulkan issue, where we want to let apps create linear RGB float surfaces. (AMDVLK exposes this too: http://vulkan.gpuinfo.org/displayreport.php?id=3222#formats, see R32G32B32_SFLOAT and friends) Vulkan has no conecept of staging textures (or at least the app does not have to tell the

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Marek Olšák
Would this work for you instead? https://cgit.freedesktop.org/~mareko/mesa/commit/?h=user-stride&id=1fadff480e53fb691add602933c5d711d7e4b6e0 Marek On Mon, May 14, 2018 at 5:10 PM, Bas Nieuwenhuizen wrote: > There are non-shared linear images too, and those don't > need the extra alignment at al

Re: [Mesa-dev] [PATCH] gallium/hud: add frametime graph

2018-05-15 Thread Marek Olšák
It would be better to modify the existing query_fps function to compute the frame time as an option. FPS in the HUD is not per second, but per HUD period. GALLIUM_HUD_PERIOD=0 gives you FPS = 1 / frametime. For greater period values, it's: frames / elapsed_time. Marek On Tue, May 15, 2018 at 11:

Re: [Mesa-dev] [RFC] glsl: bump default glsl version to 130 if EXT_gpu_shader4 used

2018-05-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, May 14, 2018 at 10:32 PM, Timothy Arceri wrote: > EXT_gpu_shader4 is GL 3.0 plus some more bits and pieces. Currently > the extension is never enabled for any drivers. Bumping the glsl > version should allow shaders to compile. > > Noticed when looking at

Re: [Mesa-dev] [PATCH] mesa/st: handle vert_attrib_mask in nir case too

2018-05-15 Thread Mathias Fröhlich
Hi Rob, Thanks for taking care! Reviewed-by: Mathias Fröhlich best Mathias On Tuesday, 15 May 2018 20:34:14 CEST Rob Clark wrote: > Note, actually fixes 9987a072cb, but the problems don't show up until > 19a91841c3. > > Fixes: 19a91841c3 st/mesa: Use Array._DrawVAO in st_atom_array.c. > Fixe

Re: [Mesa-dev] [PATCH] mesa/st: handle vert_attrib_mask in nir case too

2018-05-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, May 15, 2018 at 2:34 PM, Rob Clark wrote: > Note, actually fixes 9987a072cb, but the problems don't show up until > 19a91841c3. > > Fixes: 19a91841c3 st/mesa: Use Array._DrawVAO in st_atom_array.c. > Fixes: 9987a072cb st/mesa: Make the input_to_index arra

[Mesa-dev] [ANNOUNCE] Mesa 18.0.4 release candidate

2018-05-15 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 18.0.4 is now available. Currently we have: - 27 queued (+1 squashed) - 0 nominated (outstanding) - and 4 rejected patches The current queue consists of: r600 driver gets a fix for constant buffer boounds, which fixes rendering bugs in Trine and Witcher

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-05-15 Thread Mathias Fröhlich
On Tuesday, 15 May 2018 20:36:19 CEST Rob Clark wrote: > On Tue, May 15, 2018 at 2:33 PM, Mathias Fröhlich > wrote: > > Hi, > > > > On Tuesday, 15 May 2018 20:12:47 CEST Rob Clark wrote: > >> oh, ok, "st/mesa: Make the input_to_index array available." isn't > >> handling the nir case ;-) > > > > U

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-05-15 Thread Rob Clark
On Tue, May 15, 2018 at 2:33 PM, Mathias Fröhlich wrote: > Hi, > > On Tuesday, 15 May 2018 20:12:47 CEST Rob Clark wrote: >> oh, ok, "st/mesa: Make the input_to_index array available." isn't >> handling the nir case ;-) > > Uh, ok. > > So, you may want to look at something similar to > > commit 99

[Mesa-dev] [PATCH] mesa/st: handle vert_attrib_mask in nir case too

2018-05-15 Thread Rob Clark
Note, actually fixes 9987a072cb, but the problems don't show up until 19a91841c3. Fixes: 19a91841c3 st/mesa: Use Array._DrawVAO in st_atom_array.c. Fixes: 9987a072cb st/mesa: Make the input_to_index array available. Signed-off-by: Rob Clark --- src/mesa/state_tracker/st_program.c | 14 +++---

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-05-15 Thread Mathias Fröhlich
Hi, On Tuesday, 15 May 2018 20:12:47 CEST Rob Clark wrote: > oh, ok, "st/mesa: Make the input_to_index array available." isn't > handling the nir case ;-) Uh, ok. So, you may want to look at something similar to commit 9987a072cbc00306eb4d34409f6325ae29728a2f Author: Mathias Fröhlich Date:

Re: [Mesa-dev] [PATCH 2/2] i965: add {X, A}BGR2101010 to 'intel_image_formats'

2018-05-15 Thread Chad Versace
On Mon 07 May 2018, Miguel Casas wrote: > This patch adds {X,A}BGR2101010 entries to the list of supported > 'intel_image_formats'. > > Bug: https://crbug.com/776093 > --- > src/mesa/drivers/dri/i965/intel_screen.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Chad Versace I want

Re: [Mesa-dev] [PATCH 1/2] dri_util: Add R10G10B10{A, X}2 translation between DRI and mesa_format.

2018-05-15 Thread Chad Versace
On Mon 07 May 2018, Miguel Casas wrote: > Add R10G10B10{A,X}2 translation between mesa_format and DRI format > to driGLFormatToImageFormat() and driImageFormatToGLFormat(). > > Bug: https://crbug.com/776093 > --- > src/mesa/drivers/dri/common/dri_util.c | 8 > 1 file changed, 8 insertion

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-05-15 Thread Rob Clark
On Tue, May 15, 2018 at 2:07 PM, Rob Clark wrote: > On Tue, May 15, 2018 at 1:41 PM, Rob Clark wrote: >> On Mon, May 7, 2018 at 2:14 AM, wrote: >>> From: Mathias Fröhlich >>> >>> Finally make use of the binding information in the VAO when >>> setting up arrays for draw. >>> >>> v2: Emit less r

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-05-15 Thread Rob Clark
On Tue, May 15, 2018 at 1:41 PM, Rob Clark wrote: > On Mon, May 7, 2018 at 2:14 AM, wrote: >> From: Mathias Fröhlich >> >> Finally make use of the binding information in the VAO when >> setting up arrays for draw. >> >> v2: Emit less relocations also for interleaved userspace arrays. >> >> Sign

Re: [Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

2018-05-15 Thread Rob Clark
On Mon, May 7, 2018 at 2:14 AM, wrote: > From: Mathias Fröhlich > > Finally make use of the binding information in the VAO when > setting up arrays for draw. > > v2: Emit less relocations also for interleaved userspace arrays. > > Signed-off-by: Mathias Fröhlich This appears to break glmark2 (

Re: [Mesa-dev] [PATCH] radeonsi: create .gitignore

2018-05-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, May 15, 2018 at 9:55 AM, Dieter Nützel wrote: > Hello Marek, > > sorry I have some trouble with 'git send-email' (configuration) > > Command unknown: 'AUTH' at /usr/lib/git/git-send-email line 1455 > > currently, so I send it this way. > > Dieter

[Mesa-dev] [Bug 106351] Freezes with plasmashell and steam client

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106351 --- Comment #15 from Mike Lothian --- I've not seen the freezes with that patch so far Feel free to add my tested by Tested-by: Mike Lothian -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact fo

[Mesa-dev] [PATCH mesa v2 7/7] meson: remove "empty array"/"array of an empty string" confusion

2018-05-15 Thread Eric Engestrom
Setting `-D arrayoption=` is not the same as setting `-D arrayoption=[]`; the latter clears the array, while the former fills it with an empty string option. This makes the code handling array options a bit more complicated, and a lot more error-prone, so let's get rid of the confusion by removing

[Mesa-dev] [PATCH mesa v2 6/7] docs/meson: mention how to use array options

2018-05-15 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/meson.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/meson.html b/docs/meson.html index f394a22fc2a7d058828e..29907a60a9cb02975065 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -67,6 +67,14 @@ 1. Basic Usage meson configur

[Mesa-dev] [PATCH mesa v2 3/7] meson: fix vulkan-drivers=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D vulkan-drivers=[]` and `-D vulkan-drivers=` --- meson.build | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index 556860e1

[Mesa-dev] [PATCH mesa v2 2/7] meson: fix gallium-drivers=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D gallium-drivers=[]` and `-D gallium-drivers=` --- meson.build | 66 - 1 file changed, 25 insertions(+), 41 deletions(-) diff --g

[Mesa-dev] [PATCH mesa v2 1/7] meson: fix dri-drivers=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D dri-drivers=[]` and `-D dri-drivers=` --- meson.build | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [PATCH mesa v2 5/7] meson: drop unused empty string array element

2018-05-15 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 7d3db81c887d82c6fe57..a8fd0980010babae8c9f 100644 --- a/meson.build +++ b/meson.build @@ -100,13 +100,13 @@ if _drivers.contains('auto') if

[Mesa-dev] [PATCH mesa v2 4/7] meson: fix platforms=[]

2018-05-15 Thread Eric Engestrom
Fixes: 5608d0a2cee47c7d037f ("meson: use array type options") Signed-off-by: Eric Engestrom --- v2: handle both `-D platforms=[]` and `-D platforms=` --- meson.build | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/meson.build b/meson.build index

Re: [Mesa-dev] [PATCH v2] spirv: fix visiting inner loops with same break/continue block

2018-05-15 Thread Jason Ekstrand
I don't think this does the right thing in the switch fall-through case but it will at least fail with a reasonable assert instead of just doing the wrong thing. Reviewed-by: Jason Ekstrand On Tue, May 15, 2018 at 3:00 AM, Samuel Pitoiset wrote: > We should stop walking through the CFG when th

[Mesa-dev] [PATCH] gallium/hud: add frametime graph

2018-05-15 Thread Matthias Groß
Frametimes are often a more useful metric than FPS, because fps are an averaged-value for the duration of a rather long period (one second). Example: 59 frames are rendered in 16 ms each, but one frame takes 56 ms to compute. That's exactly 60 FPS, but there is very noticeable stutter. Some modern

[Mesa-dev] [Bug 106528] radv doesn't support VK_FORMAT_D24_UNORM_S8_UINT

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106528 --- Comment #5 from Józef Kucia --- FWIW, VK_FORMAT_D24_UNORM_S8_UINT is already handled in various functions in src/amd/vulkan/radv_formats.c. It confused me, and I assumed that the format is supported. -- You are receiving this mail because:

[Mesa-dev] [Bug 106528] radv doesn't support VK_FORMAT_D24_UNORM_S8_UINT

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106528 --- Comment #4 from Samuel Pitoiset --- Oh my bad, I misread D24_UNORM_S8_UINT vs D32_SFLOAT_S8_UINT. :) Yeah, that could be supported. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bu

[Mesa-dev] [Bug 106528] radv doesn't support VK_FORMAT_D24_UNORM_S8_UINT

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106528 Józef Kucia changed: What|Removed |Added Summary|radv: |radv doesn't support |O

[Mesa-dev] [Bug 106528] radv: OpImageSampleDrefImplicitLod returns invalid results for VK_FORMAT_D24_UNORM_S8_UINT

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106528 --- Comment #2 from Alex Smith --- D24 isn't even supported on RADV: FORMAT_D24_UNORM_S8_UINT: linearTiling FormatFeatureFlags: None optimalTiling FormatFeatureFlags: None bufferFeature

Re: [Mesa-dev] [PATCH v2 04/14] etnaviv: put logic for rs clear format selection into caller

2018-05-15 Thread Philipp Zabel
On Tue, 2018-05-01 at 16:48 +0200, Christian Gmeiner wrote: > We do no need to call translate_rs_format(..) as we can simplify > things by using formats blocksize to choose the correct RS format > for clearing. > > No piglit regressions. > > Signed-off-by: Christian Gmeiner > --- > src/gallium/

[Mesa-dev] [Bug 106528] radv: OpImageSampleDrefImplicitLod returns invalid results for VK_FORMAT_D24_UNORM_S8_UINT

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106528 --- Comment #1 from Samuel Pitoiset --- Does it work with RADV_DEBUG=nohiz ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev

[Mesa-dev] [Bug 106528] radv: OpImageSampleDrefImplicitLod returns invalid results for VK_FORMAT_D24_UNORM_S8_UINT

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106528 Józef Kucia changed: What|Removed |Added Hardware|Other |All OS|All

[Mesa-dev] [Bug 106528] radv: OpImageSampleDrefImplicitLod returns invalid results for VK_FORMAT_D24_UNORM_S8_UINT

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106528 Bug ID: 106528 Summary: radv: OpImageSampleDrefImplicitLod returns invalid results for VK_FORMAT_D24_UNORM_S8_UINT Product: Mesa Version: git Hardware: Other

[Mesa-dev] [PATCH] radeonsi: create .gitignore

2018-05-15 Thread Dieter Nützel
Hello Marek, sorry I have some trouble with 'git send-email' (configuration) Command unknown: 'AUTH' at /usr/lib/git/git-send-email line 1455 currently, so I send it this way. DieterFrom 0d5c86aaaffb7f672184ef556430397f27fe12c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dieter=20N=C3=BCtzel?= D

[Mesa-dev] [PATCH] radv: add generated files to .gitignore(s)

2018-05-15 Thread Dieter Nützel
Hello Bas, sorry I have some trouble with 'git send-email' (configuration) Command unknown: 'AUTH' at /usr/lib/git/git-send-email line 1455 currently, so I send it this way. DieterFrom 8826f56d9e13c1e47753f63162bf9fb70ef869e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dieter=20N=C3=BCtzel?= Dat

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-05-15 Thread Kai Wasserbäch
Hey Jan, Jan Vesely wrote on 15.05.2018 04:50: > I've pushed the patch. thank you very much! I went ahead and closed the associated bug in the meantime. > I've also kept the stable tag although the > policy is (afaik) to only support llvm versions available at the point > of mesa release. Don't b

[Mesa-dev] [PATCH 2/3] intel/compiler: add a region_match() helper

2018-05-15 Thread Iago Toral Quiroga
This checks whether two register regions are an exact match. --- src/intel/compiler/brw_ir_fs.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/intel/compiler/brw_ir_fs.h b/src/intel/compiler/brw_ir_fs.h index f06a33c516d..cad333b6b6d 100644 --- a/src/intel/compiler/brw_ir_f

[Mesa-dev] [PATCH 0/3] intel: implement an optimization pass to clean-up boolean conversions

2018-05-15 Thread Iago Toral Quiroga
NIR assumes that all booleans are 32-bit, so drivers need to produce 32-bit booleans even if they can produce native booleans of a different bit-size, like Intel does. This means that if we have a 16-bit CMP instruction, we generate a 16-bit boolean that we immediately convert to 32-bit, since that

[Mesa-dev] [PATCH 3/3] intel/compiler: add an optimization pass for booleans

2018-05-15 Thread Iago Toral Quiroga
NIR assumes that all booleans are 32-bit but Intel hardware produces booleans of the same size as the operands to the CMP instruction, so we can actually have 8-bit and 16-bit booleans. To work around this mismatch between NIR and the hardware, we emit boolean conversions to 32-bit right after emit

[Mesa-dev] [PATCH 1/3] intel/compiler: make brw_reg_type_from_bit_size usable from other places

2018-05-15 Thread Iago Toral Quiroga
This was private to brw_fs_nir.cpp but we are going to need it soon in brw_fs.cpp, so move it there and make it available to other files as we do for other utility functions. --- src/intel/compiler/brw_fs.cpp | 59 +++ src/intel/compiler/brw_fs.h | 4

[Mesa-dev] [PATCH v2] spirv: fix visiting inner loops with same break/continue block

2018-05-15 Thread Samuel Pitoiset
We should stop walking through the CFG when the inner loop's break block ends up as the same block as the outer loop's continue block because we are already going to visit it. This fixes the following assertion which ends up by crashing in RADV or ANV: SPIR-V parsing FAILED: In file ../src/compil

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] radv: Fix up 2_10_10_10 alpha sign.

2018-05-15 Thread Juan A. Suarez Romero
On Mon, 2018-05-14 at 22:35 +0200, Bas Nieuwenhuizen wrote: > On Mon, May 14, 2018 at 9:28 PM, Mark Janes wrote: > > Bas Nieuwenhuizen writes: > > > > > Pre-Vega HW always interprets the alpha for this format as unsigned, > > > so we have to implement a fixup to do the sign correctly for signed

Re: [Mesa-dev] [PATCH] cso: check count == 0 in cso_set_vertex_buffers

2018-05-15 Thread Michel Dänzer
On 2018-05-15 04:35 AM, Marek Olšák wrote: > From: Marek Olšák > > The code didn't expect that. > > Fixes: 86d63b53a20a747e "gallium: remove aux_vertex_buffer_slot code" Fixes the piglit crashes introduced by that commit. Tested-by: Michel Dänzer -- Earthling Michel Dänzer |

Re: [Mesa-dev] [PATCH] gallivm: Use alloca_undef with array type instead of alloca_array

2018-05-15 Thread Jose Fonseca
On 15/05/18 03:51, srol...@vmware.com wrote: From: Roland Scheidegger Use a single allocation of array type instead of the old-style array allocation for the temp and immediate arrays. Probably only makes a difference if they aren't used indirectly (so, if we used them solely because there's to

[Mesa-dev] [Bug 106522] QA Notice

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106522 Michel Dänzer changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[Mesa-dev] [Bug 106351] Freezes with plasmashell and steam client

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106351 Michel Dänzer changed: What|Removed |Added CC||dark.shad...@web.de --- Comment #14 fro

[Mesa-dev] [Bug 106502] Running game with wine fullscreen freezes the system when missing xf86-video-amdgpu

2018-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106502 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

  1   2   >