Re: [Mesa-dev] How about vulkan status in Mesa

On 04/11/2018 09:01 AM, Yuan, Feng wrote: Hi, We have an image processing project libxcam (https://github.com/intel/libxcam/wiki) which has been based on OpenCL to support amount of features. Recently, we decide to porting kernels to GLES compute-shader language and based on Vulkan APIs. Cer

Re: [Mesa-dev] [PATCH v2 1/3] nir: remove leftover return value when lowering to SSA

On Tue, Apr 10, 2018 at 11:13:38PM -0700, Caio Marcelo de Oliveira Filho wrote: > The return value was needed to make use of the old nir_foreach_block > helper, but not needed anymore with the macro version. Then go one > step further and move the foreach directly into the register variable > uses

[Mesa-dev] [PATCH v2 3/3] nir: simplify node matching code when lowering to SSA

The matching code doesn't make real use of the return value. The main function return value is ignored, and while the worker function propagate its return value, the actual callback never returns false. v2: Style fixes. (Jason) --- src/compiler/nir/nir_lower_vars_to_ssa.c | 67 +++

[Mesa-dev] [PATCH v2 1/3] nir: remove leftover return value when lowering to SSA

The return value was needed to make use of the old nir_foreach_block helper, but not needed anymore with the macro version. Then go one step further and move the foreach directly into the register variable uses function. v2: Move foreach to register_variable_uses(). (Jason) Reviewed-by: Jason Eks

[Mesa-dev] [PATCH v2 2/3] nir: remove unnecessary check when lowering to SSA

Only fully-qualified direct derefs, collected in direct_deref_nodes, are checked for aliasing, so it is already known up front that they have only array derefs of type direct. Reviewed-by: Jason Ekstrand --- This is really the same as v1, but with Reviewed-by and resent together with the series.

Re: [Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

On Tue, Apr 10, 2018 at 10:15:45PM -0700, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > > > The matching code doesn't make real use of the return value. The main > > function return value is ignored, and while the wor

[Mesa-dev] How about vulkan status in Mesa

Hi, We have an image processing project libxcam (https://github.com/intel/libxcam/wiki) which has been based on OpenCL to support amount of features. Recently, we decide to porting kernels to GLES compute-shader language and based on Vulkan APIs. Certainly the driver is Mesa. There are my quest

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

On 11/04/18 15:05, Jason Ekstrand wrote: If I understand correctly, this is because when running with minimal GLSL IR, opt_function_inlining doesn't acutally inline them all.  Is that correct?  If so, would it make sense to just repeatedly call do_function_inlining until it stops making progr

Re: [Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > The matching code doesn't make real use of the return value. The main > function return value is ignored, and while the worker function > propagate its return value, the actual callback never retur

Re: [Mesa-dev] [PATCH 2/3] nir: remove unnecessary check when lowering to SSA

Reviewed-by: Jason Ekstrand On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Only fully-qualified direct derefs, collected in direct_deref_nodes, > are checked for aliasing, so it is already known up front that they > have only array derefs of

Re: [Mesa-dev] [PATCH 1/3] nir: remove leftover return value when lowering to SSA

On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > The return value was needed to make use of the old nir_foreach_block > helper, but not needed anymore with the macro version. > Nice bit of archaeology there. :-) > --- > src/compiler/nir/nir_l

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

If I understand correctly, this is because when running with minimal GLSL IR, opt_function_inlining doesn't acutally inline them all. Is that correct? If so, would it make sense to just repeatedly call do_function_inlining until it stops making progress when we're running with minimal optimizatio

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

For the series (except 9-10): Tested-by: Dieter Nützel with glmark2, UH, UV and KDE Plasma 5 on RX580 Dieter Am 10.04.2018 06:34, schrieb Timothy Arceri: --- src/compiler/glsl/glsl_to_nir.cpp | 20 1 file changed, 20 insertions(+) diff --git a/src/compiler/glsl/glsl_to

Re: [Mesa-dev] [PATCH] fix gcc 8 parenthesis warning

On 11/04/18 12:13, Timothy Arceri wrote: On 24/03/18 02:55, Eric Engestrom wrote: On Friday, 2018-03-23 08:09:46 -0700, Ian Romanick wrote: On 03/23/2018 03:52 AM, Eric Engestrom wrote: On Friday, 2018-03-23 11:01:23 +0100, Marc Dietrich wrote: fixes warnings like this: [184/1137] Compiling

Re: [Mesa-dev] [PATCH] fix gcc 8 parenthesis warning

On 24/03/18 02:55, Eric Engestrom wrote: On Friday, 2018-03-23 08:09:46 -0700, Ian Romanick wrote: On 03/23/2018 03:52 AM, Eric Engestrom wrote: On Friday, 2018-03-23 11:01:23 +0100, Marc Dietrich wrote: fixes warnings like this: [184/1137] Compiling C++ object 'src/compiler/glsl/glsl@sta/lowe

Re: [Mesa-dev] [PATCH] vulkan: Drop vk_android_native_buffer.xml

On Tue, Apr 10, 2018 at 4:29 PM, Dylan Baker wrote: > Quoting Jason Ekstrand (2018-04-09 22:04:02) > > All the information in vk_android_native_buffer.xml is now in vk.xml. > > The only exception is the extension type attribute which we can work > > around in the generators while we wait for the

[Mesa-dev] [PATCH] ac/surface: Allow S swizzle for displayable surfaces.

For dcn1 && < 64 bpp displayable surfaces, addrlib only accepts S swizzles. At the same time addrlib prefers D swizzles is allowed, so we can just allow S swizzles as fallback. Fixes: b64b712558 "ac/surface/gfx9: request desired micro tile mode explicitly" --- src/amd/common/ac_surface.c | 7 +++

Re: [Mesa-dev] [PATCH 1/4] ac/surface: don't set the display flag for obviously unsupported cases (v2)

What is the addrlib assertion we are hitting? On Tue, Apr 10, 2018 at 11:44 AM, Michel Dänzer wrote: > On 2018-04-06 07:12 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> This enables the tile swizzle for some cases of the displayable micro mode, >> and it also fixes an addrlib assertion failu

[Mesa-dev] [PATCH] radv: Enable RB+ on Raven.

--- src/amd/vulkan/radv_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 4fc7392e65e..22e8f1e7a78 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -293,7 +293,8 @@ radv_ph

Re: [Mesa-dev] [PATCH] vulkan: Drop vk_android_native_buffer.xml

Quoting Jason Ekstrand (2018-04-09 22:04:02) > All the information in vk_android_native_buffer.xml is now in vk.xml. > The only exception is the extension type attribute which we can work > around in the generators while we wait for the XML to be fixed. > > Cc: Dylan Baker > Cc: Tapani Pälli > -

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 09:22, Timothy Arceri wrote: On 11/04/18 09:18, Timothy Arceri wrote: On 11/04/18 08:58, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri mailto:tarc...@itsqueeze.com>> wrote:     On 11/04/18 01:11, Jason Ekstrand wrote:     On Tue, Apr 10, 2018 at 8:05

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 09:18, Timothy Arceri wrote: On 11/04/18 08:58, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri > wrote:     On 11/04/18 01:11, Jason Ekstrand wrote:     On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst     mailto:kher...

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 08:58, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri > wrote: On 11/04/18 01:11, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst mailto:kher...@redhat.com>

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On Tue, Apr 10, 2018 at 3:16 PM, Timothy Arceri wrote: > > > On 11/04/18 01:11, Jason Ekstrand wrote: > >> On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst > > wrote: >> >> If the bindless image is passed through a struct we ended up getting >> the >> glsl_type of

Re: [Mesa-dev] [PATCH v3 000/104] nir: Move to using instructions for derefs

> I've skipped 21 and 28 because I wanted to give a deeper look at the > originals. OK. Patches 21 and 28 are Reviewed-by: Caio Marcelo de Oliveira Filho Patch 12 seems a candidate to get in early. (It is R-B'ed in my previous mail). Thanks, Caio _

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On 11/04/18 01:11, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst > wrote: If the bindless image is passed through a struct we ended up getting the glsl_type of the struct, not the image. variable_referenced points to the declaration

[Mesa-dev] [PATCH] radv: advertise 8 bits of subpixel precision for viewports

This is what radeonsi does. --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 4fc7392e65e6..35b686ab7f02 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c

[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- Comment #10 from Timothy Arceri --- (In reply to Timothy Arceri from comment #9) > (In reply to Alan Swanson from comment #7) > > Just to confirm with Ben, this very definitely affects radeonsi not just > > i965. Forcing MESA_GLSL_VERSION_OV

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

I think this used to work previously because something would clamp GLSLVersion to 130 for compat, and it no longer does. So probably just adding 30 is enough... On Tue, Apr 10, 2018 at 5:51 PM, Timothy Arceri wrote: > On 11/04/18 00:34, Ilia Mirkin wrote: >> >> What about GL 2.1 and 2.0 (and earl

[Mesa-dev] [Bug 105320] Storage texel buffer access produces wrong results (RX Vega)

https://bugs.freedesktop.org/show_bug.cgi?id=105320 --- Comment #4 from Józef Kucia --- (In reply to Samuel Pitoiset from comment #3) > This should be fixed with > https://cgit.freedesktop.org/mesa/mesa/commit/ > ?id=4503ff760c794c3bb15b978a47c530037d56498e The attached sample program still does

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

On 11/04/18 00:34, Ilia Mirkin wrote: What about GL 2.1 and 2.0 (and earlier where you could still have GLSL as an ext)? And does the GLSL version have to line up exactly for those? Or does this just need to be default: if (ctx->Version < 31) ctx->Const.GLSLVersion = MIN2(ctx->Const.GLSLVersi

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

https://bugs.freedesktop.org/show_bug.cgi?id=105942 --- Comment #7 from Bas Nieuwenhuizen --- Since you use Arch, it may be worth building/running https://aur.archlinux.org/packages/mesa-git/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for t

[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- Comment #9 from Timothy Arceri --- (In reply to Alan Swanson from comment #7) > Just to confirm with Ben, this very definitely affects radeonsi not just > i965. Forcing MESA_GLSL_VERSION_OVERRIDE=130 resolves issue so perhaps a > game issue

Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

Ah neat trick. Unless you submit each prim individually I have some doubts about correctness though. But should be enough to pass piglits I suppose... svga also can't do this (it will just report this via debug callback). Roland Am 10.04.2018 um 21:50 schrieb Marek Olšák: > On Tue, Apr 10, 2018

[Mesa-dev] [Bug 105942] Graphical artefacts after update to mesa 18.0.0-2

https://bugs.freedesktop.org/show_bug.cgi?id=105942 --- Comment #6 from kaspar.t...@gmail.com --- Thank you! I my self probably don't have the know-how to compile & replace your patched mesa with my system's mesa to verify the fix. -- You are receiving this mail because: You are the QA Contact

Re: [Mesa-dev] [PATCH v2 01/12] glsl/tests: reimplement warnings-test in python

Quoting Eric Anholt (2018-04-10 10:50:32) > Dylan Baker writes: > > > This reimplements the test in python with a shell script wrapper that > > allows autotools to continue to run the test without realizing that > > anything has changed. > > > > Using python has two advantages, first it's portabl

[Mesa-dev] [Bug 102390] centroid interpolation causes broken attribute values

https://bugs.freedesktop.org/show_bug.cgi?id=102390 Samuel Pitoiset changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Samuel P

Re: [Mesa-dev] [PATCH v2 11/12] meson: build tests for gallium mesa state tracker

Quoting Eric Anholt (2018-04-10 11:05:03) > Dylan Baker writes: > > > Signed-off-by: Dylan Baker > > --- > > src/mesa/state_tracker/tests/meson.build | 40 +- > > src/meson.build | 3 ++- > > 2 files changed, 43 insertions(+) > > create mode 10

Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

Reviewed-by: Marek Olšák Marek On Tue, Apr 10, 2018 at 12:11 PM, Emil Velikov wrote: > From: Emil Velikov > > Virtually every driver that supports ATI_separate_stencil > also supports EXT_stencil_two_side. > > Use the latter boolean for both extension. With that in mind we can drop > the expl

[Mesa-dev] [Bug 100424] X hang (in kernel) after some event in Serious Sam Fusion using radv. 4.9/amd-staging-4.9

https://bugs.freedesktop.org/show_bug.cgi?id=100424 --- Comment #5 from Samuel Pitoiset --- Hi Darren, Can you still reproduce the hang? I regularly test Serious Sam Fusion on Polaris/Vega, and it never hung for me. -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 105952] radv causes GPU hang on SI

https://bugs.freedesktop.org/show_bug.cgi?id=105952 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 3/3] nir: simplify node matching code when lowering to SSA

The matching code doesn't make real use of the return value. The main function return value is ignored, and while the worker function propagate its return value, the actual callback never returns false. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 73 +++- 1 file changed, 32

[Mesa-dev] [PATCH 1/3] nir: remove leftover return value when lowering to SSA

The return value was needed to make use of the old nir_foreach_block helper, but not needed anymore with the macro version. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/compiler/n

[Mesa-dev] [PATCH 2/3] nir: remove unnecessary check when lowering to SSA

Only fully-qualified direct derefs, collected in direct_deref_nodes, are checked for aliasing, so it is already known up front that they have only array derefs of type direct. --- src/compiler/nir/nir_lower_vars_to_ssa.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/

Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

On Tue, Apr 10, 2018 at 12:27 PM, Roland Scheidegger wrote: > Yes, there is indeed plenty hw (all with d3d heritage, d3d10 doesn't > support different ref/masks) which don't actually have full support for > two-sided stencil. > I think all drivers just cheat and fail though since they really want

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=/usr/llvm/x86_64-linux-gnu -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=ON \ -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON \ -DLLVM_APPEND_VC_REV=OFF -DCMAKE_SHARED

Re: [Mesa-dev] [PATCH] mesa: fix glsl version mismatch in compat profile

Reviewed-by: Marek Olšák Marek On Tue, Apr 10, 2018 at 7:40 AM, Timothy Arceri wrote: > Drivers that only support compat 3.0 were reporting GLSL 1.40 > support. This fixes issues with the menu of Dawn of War II. > > Fixes: a0c8b49284ef "mesa: enable OpenGL 3.1 with ARB_compatibility" > > Bugzi

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

Quoting Marek Olšák (2018-04-10 11:03:59) > On Mon, Apr 9, 2018 at 5:37 PM, Dylan Baker wrote: > > Are you building LLVM yourself, or is that a build that comes with your > distro? > Also, what is your distro? > > > Ubuntu 16.04. LLVM is in /usr/llvm/ bin is not in PATH by defau

Re: [Mesa-dev] [PATCH] intel/blorp/hiz: Emit CC viewport

On Tue, Apr 10, 2018 at 11:32:19AM -0700, Nanley Chery wrote: > On Tue, Apr 03, 2018 at 09:07:52PM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 09:04:48PM +0300, Pohjolainen, Topi wrote: > > > On Tue, Apr 03, 2018 at 07:40:34PM +0300, Topi Pohjolainen wrote: > > > > Otherwise simulat

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 1:50 PM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 1:17 PM, Jason Ekstrand wrote: >> On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: >>> >>> On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand >>> wrote: >>> > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >>> >> >>>

Re: [Mesa-dev] [PATCH] intel/blorp/hiz: Emit CC viewport

On Tue, Apr 03, 2018 at 09:07:52PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 03, 2018 at 09:04:48PM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 07:40:34PM +0300, Topi Pohjolainen wrote: > > > Otherwise simulator for ICL complains that: > > > > > > B-spec CC_ViewPort Minimum Dep

Re: [Mesa-dev] [PATCH] i965/miptree: Initialize mcs buffer only until clear color

On Fri, Apr 06, 2018 at 07:04:01PM +0300, Pohjolainen, Topi wrote: > On Fri, Apr 06, 2018 at 08:53:39AM -0700, Jason Ekstrand wrote: > > On Fri, Apr 6, 2018 at 8:22 AM, Rafael Antognolli < > > rafael.antogno...@intel.com> wrote: > > > > > On Fri, Apr 06, 2018 at 06:07:52PM +0300, Topi Pohjolainen

Re: [Mesa-dev] [PATCH] RFC gallium: add 64 bit integer formats

On Mon, Apr 9, 2018 at 9:14 PM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 2:43 AM, Ilia Mirkin wrote: > > On Mon, Apr 9, 2018 at 8:39 PM, Karol Herbst wrote: > >> unsigneds are needed by ARB_bindless_texture 64 bit vertex attribs, > both for > >> NV_vertex_attrib_integer64. > >> > >> Fixes

Re: [Mesa-dev] [PATCH 04/11] gallium: Use Array._DrawVAO in st_atom_array.c.

Generally, if you have to loop over all arrays to find common vertex buffers, it's better not to do it. The default separate path is going to perform best, because it's straightforward and interleaved arrays are super rare. Marek On Mon, Apr 9, 2018 at 7:15 PM, Mathias Fröhlich wrote: > Hi Mare

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

If I understand correctly, you don't disagree with the patch. Marek On Tue, Apr 10, 2018 at 2:03 PM, Marek Olšák wrote: > On Mon, Apr 9, 2018 at 5:37 PM, Dylan Baker wrote: > >> Are you building LLVM yourself, or is that a build that comes with your >> distro? >> Also, what is your distro? >>

Re: [Mesa-dev] [PATCH v2 11/12] meson: build tests for gallium mesa state tracker

Dylan Baker writes: > Signed-off-by: Dylan Baker > --- > src/mesa/state_tracker/tests/meson.build | 40 +- > src/meson.build | 3 ++- > 2 files changed, 43 insertions(+) > create mode 100644 src/mesa/state_tracker/tests/meson.build > > diff --g

Re: [Mesa-dev] [PATCH] gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times

On Mon, Apr 9, 2018 at 5:37 PM, Dylan Baker wrote: > Are you building LLVM yourself, or is that a build that comes with your > distro? > Also, what is your distro? > Ubuntu 16.04. LLVM is in /usr/llvm/ bin is not in PATH by default, include is not in the include path by default, but lib is i

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

This doesn't change TGSI. It only changes utilities around it. Marek On Mon, Apr 9, 2018 at 6:02 PM, Joe M. Kniss wrote: > Add support for glsl 'invariant' modifier for output data declarations. > Gallium drivers that use TGSI serialization currently loose invariant > modifiers in glsl shaders.

Re: [Mesa-dev] [PATCH v2 01/12] glsl/tests: reimplement warnings-test in python

Dylan Baker writes: > This reimplements the test in python with a shell script wrapper that > allows autotools to continue to run the test without realizing that > anything has changed. > > Using python has two advantages, first it's portable so this test can be > run on windows as well as Linux

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 1:17 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: >> >> On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand >> wrote: >> > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >> >> >> >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand >> >>

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 10:20 AM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 6:01 PM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst > wrote: > >> > >> On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand > >> wrote: > >> > I still don't see anything to make nir_valida

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 6:01 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst wrote: >> >> On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand >> wrote: >> > I still don't see anything to make nir_validate not fail out on you if >> > it >> > sees a read or a write to/from an

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 9:59 AM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: > >> > >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand > >> wrote: > >> > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark > wrote:

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

On Tue, Apr 10, 2018 at 10:05 AM, Emil Velikov wrote: > On 10 April 2018 at 17:53, Ivan Kalvachev wrote: > > On 3/28/18, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> Earlier commit enforced that we'll bail out if the number of terminators > >> is different than 2. With that in mind, t

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

On 10 April 2018 at 17:53, Ivan Kalvachev wrote: > On 3/28/18, Emil Velikov wrote: >> From: Emil Velikov >> >> Earlier commit enforced that we'll bail out if the number of terminators >> is different than 2. With that in mind, the assert() will never trigger. >> >> Fixes: 56b867395de ("glsl: fix

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 11:55 AM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: >> >> On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand >> wrote: >> > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: >> >> >> >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand >> >>

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

On 3/28/18, Emil Velikov wrote: > From: Emil Velikov > > Earlier commit enforced that we'll bail out if the number of terminators > is different than 2. With that in mind, the assert() will never trigger. > > Fixes: 56b867395de ("glsl: fix infinite loop caused by bug in loop > unrolling pass") >

Re: [Mesa-dev] [PATCH 3/3] egl/x11: Handle both depth 30 formats for eglCreateImage().

On Tue, Apr 10, 2018 at 4:42 AM, Michel Dänzer wrote: > On 2018-04-10 10:22 AM, Mario Kleiner wrote: >> On 04/09/2018 12:12 PM, Michel Dänzer wrote: >>> On 2018-04-06 08:56 PM, Mario Kleiner wrote: >>> >>> I'm interested in the full xdpyinfo *at screen depth 30*, in particular >>> whether it lists

Re: [Mesa-dev] [PATCH] docs/release-calendar: update to include 18.1 and 18.2

On Tue, 2018-04-10 at 16:23 +0100, Emil Velikov wrote: > On 10 April 2018 at 09:06, Juan A. Suarez Romero wrote: > > On Mon, 2018-04-09 at 19:02 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Dylan has kindly stepped up to help with 18.1.0, while I've taken the > > > liberty to

Re: [Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

Yes, there is indeed plenty hw (all with d3d heritage, d3d10 doesn't support different ref/masks) which don't actually have full support for two-sided stencil. I think all drivers just cheat and fail though since they really want to expose GL 2 anyway. So I suppose that's ok, albeit I don't really

Re: [Mesa-dev] [PATCH v4 6/6] i965: gl_BaseVertex must be zero for non-indexed draw calls

On Tue, Apr 10, 2018 at 1:28 AM, Antia Puentes wrote: > On 07/04/18 08:21, Jason Ekstrand wrote: > > On Fri, Apr 6, 2018 at 2:53 PM, Ian Romanick wrote: > >> From: Antia Puentes >> >> We keep 'firstvertex' as it is and move gl_BaseVertex to the drawID >> vertex element. The previous Vertex Elem

[Mesa-dev] [PATCH] mesa: remove struct gl_extensions::ATI_separate_stencil

From: Emil Velikov Virtually every driver that supports ATI_separate_stencil also supports EXT_stencil_two_side. Use the latter boolean for both extension. With that in mind we can drop the explicit true from the drivers and the nasty comment in compute_version(). Signed-off-by: Emil Velikov -

Re: [Mesa-dev] [PATCH v4 3/5] i965/miptree: Use cpu tiling/detiling when mapping

Quoting Scott D Phillips (2018-04-10 16:49:16) > Chris Wilson writes: > > > Quoting Scott D Phillips (2018-04-03 21:05:43) > >> Rename the (un)map_gtt functions to (un)map_map (map by > >> returning a map) and add new functions (un)map_tiled_memcpy that > >> return a shadow buffer populated with

Re: [Mesa-dev] [PATCH 2/5] i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

Quoting Scott D Phillips (2018-04-10 16:33:18) > Chris Wilson writes: > > > Quoting Chris Wilson (2018-04-05 20:54:54) > > > Quoting Scott D Phillips (2018-04-03 21:05:42) > > [...] > > > > Ok, was hoping to see how you choose to use the streaming load, but I > > > guess that's the next patch.

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 8:35 AM, Karol Herbst wrote: > On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand > wrote: > > I still don't see anything to make nir_validate not fail out on you if it > > sees a read or a write to/from an IMAGE or SAMPLER. > > > > what kind of glsl code are you talking abo

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 8:17 AM, Rob Clark wrote: > On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand > wrote: > > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: > >> > >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand > >> wrote: > >> > + A bunch of potentially interested parties. > >> > >

Re: [Mesa-dev] [PATCH v2 5/5] i965/miptree: Don't gtt map from map_depthstencil

Chris Wilson writes: > Quoting Scott D Phillips (2018-04-03 21:05:45) >> Instead of gtt mapping, call out to other map functions (map_map >> or map_tiled_memcpy) for the depth surface. Removes a place where >> gtt mapping is used. >> >> v2: add level, slice to debug print (Nanley) >> --- >> @@ -

Re: [Mesa-dev] [PATCH v4 3/5] i965/miptree: Use cpu tiling/detiling when mapping

Chris Wilson writes: > Quoting Scott D Phillips (2018-04-03 21:05:43) >> Rename the (un)map_gtt functions to (un)map_map (map by >> returning a map) and add new functions (un)map_tiled_memcpy that >> return a shadow buffer populated with the intel_tiled_memcpy >> functions. >> >> Tiling/detiling

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

On 10 April 2018 at 15:49, Juan A. Suarez Romero wrote: > On Tue, 2018-04-03 at 10:58 +0100, Alex Smith wrote: > > I don't know exactly what's causing it, no. I noticed the issue was > fixed on master so just bisected to this. > > > > CC'ing stable to nominate: > > 42627dabb4db3011825a022325be7ae

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On Tue, Apr 10, 2018 at 5:11 PM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: >> >> If the bindless image is passed through a struct we ended up getting the >> glsl_type of the struct, not the image. >> >> variable_referenced points to the declaration of the struct

Re: [Mesa-dev] [PATCH] radv: fix picking the method for resolve subpass

Reviewed-by: Bas Nieuwenhuizen On Tue, Apr 10, 2018 at 4:00 PM, Samuel Pitoiset wrote: > The source and destination image parameters were swapped. > > No CTS changes on Polaris10, but I suspect this might > fix something. > > Fixes: 2a04f5481df ("radv/meta: select resolve paths") > Signed-off-by

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

On Tue, Apr 10, 2018 at 5:12 PM, Jason Ekstrand wrote: > I still don't see anything to make nir_validate not fail out on you if it > sees a read or a write to/from an IMAGE or SAMPLER. > what kind of glsl code are you talking about here? I wrote some tests and things just seem to work out. I wasn

Re: [Mesa-dev] [PATCH v3 024/104] nir: Support deref instructions in lower_system_values

> I took another swing at it, and this one seems to make Jenkins happy: > > https://gitlab.freedesktop.org/jekstrand/mesa/commit/ad3cc9f301da3519d4f76767a6d9e98e5a5c118e Reviewed-by: Caio Marcelo de Oliveira Filho Thanks, Caio ___ mesa-dev mailing li

Re: [Mesa-dev] [PATCH 2/5] i965/tiled_memcpy: inline movntdqa loads in tiled_to_linear

Chris Wilson writes: > Quoting Chris Wilson (2018-04-05 20:54:54) > > Quoting Scott D Phillips (2018-04-03 21:05:42) [...] > > Ok, was hoping to see how you choose to use the streaming load, but I > > guess that's the next patch. > > > > Reviewed-by: Chris Wilson > > Oh, one point Eric Anholt

Re: [Mesa-dev] [PATCH] docs/release-calendar: update to include 18.1 and 18.2

On 10 April 2018 at 09:06, Juan A. Suarez Romero wrote: > On Mon, 2018-04-09 at 19:02 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Dylan has kindly stepped up to help with 18.1.0, while I've taken the >> liberty to nominate Andres for 18.2.0 ;-) >> > > I would like to replace Andres for

Re: [Mesa-dev] [PATCH v3 2/7] nir/spirv: Fix warning and add missing breaks.

Reviewed-by: Jason Ekstrand On Tue, Apr 10, 2018 at 7:37 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > --- > src/compiler/spirv/spirv_to_nir.c | 2 ++ > src/compiler/spirv/vtn_subgroup.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/src/compiler/spirv/spir

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 11:04 AM, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: >> >> On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand >> wrote: >> > + A bunch of potentially interested parties. >> > >> > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho >

Re: [Mesa-dev] [PATCH v3 1/7] nir: adjust subgroups instructions for 64bit ballot sizes

On Tue, Apr 10, 2018 at 7:37 AM, Daniel Schürmann < daniel.schuerm...@campus.tu-berlin.de> wrote: > --- > src/compiler/nir/nir_lower_subgroups.c | 5 ++--- > src/compiler/nir/nir_opcodes.py| 12 ++-- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/src/compiler

Re: [Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

I still don't see anything to make nir_validate not fail out on you if it sees a read or a write to/from an IMAGE or SAMPLER. On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: > v2: fix assertion for bindless to non bindless assignments > > Signed-off-by: Karol Herbst > --- > src/compiler/n

Re: [Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: > If the bindless image is passed through a struct we ended up getting the > glsl_type of the struct, not the image. > > variable_referenced points to the declaration of the struct, so it won't > work > for bindless images. So just drop it. > >

Re: [Mesa-dev] [PATCH v2 2/3] nir: add support for bindless_texture samplers

On Tue, Apr 10, 2018 at 8:05 AM, Karol Herbst wrote: > v2: add both texture and sampler handles > > Signed-off-by: Karol Herbst > --- > src/compiler/glsl/glsl_to_nir.cpp | 17 +++-- > src/compiler/nir/nir.h| 2 ++ > src/compiler/nir/nir_print.c | 6 ++ > 3 fil

[Mesa-dev] [PATCH v2 3/3] glsl/nir: fix variable type for image intrinsics and ubos

If the bindless image is passed through a struct we ended up getting the glsl_type of the struct, not the image. variable_referenced points to the declaration of the struct, so it won't work for bindless images. So just drop it. Signed-off-by: Karol Herbst --- src/compiler/glsl/glsl_to_nir.cpp

[Mesa-dev] [PATCH v2 2/3] nir: add support for bindless_texture samplers

v2: add both texture and sampler handles Signed-off-by: Karol Herbst --- src/compiler/glsl/glsl_to_nir.cpp | 17 +++-- src/compiler/nir/nir.h| 2 ++ src/compiler/nir/nir_print.c | 6 ++ 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/compile

[Mesa-dev] [PATCH v2 1/3] nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars

v2: fix assertion for bindless to non bindless assignments Signed-off-by: Karol Herbst --- src/compiler/nir/nir_split_var_copies.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_split_var_copies.c b/src/compiler/nir/nir_split_var_copies.c index b

[Mesa-dev] [PATCH v2 0/3] nir: add support for ARB_bindless_texture texture handles

With this it should be possible to add support for texture handles for backends using NIR. changes since v2: * dropped patch for image handles, still need to work on that Karol Herbst (3): nir/split_var_copies: handle IMAGE and SAMPLER for bindless vars nir: add support for bindless_texture s

Re: [Mesa-dev] [PATCH v3 057/104] nir,spirv: Rework function calls

On Tue, Apr 10, 2018 at 6:20 AM, Rob Clark wrote: > On Mon, Apr 9, 2018 at 10:52 PM, Jason Ekstrand > wrote: > > + A bunch of potentially interested parties. > > > > On Mon, Apr 9, 2018 at 4:25 PM, Caio Marcelo de Oliveira Filho > > wrote: > >> > >> Hi, > >> > >> > typedef struct { > >> > -

Re: [Mesa-dev] [PATCH 3/3] ac: make use of if/loop build helpers

On Tue, 2018-04-03 at 10:58 +0100, Alex Smith wrote: > I don't know exactly what's causing it, no. I noticed the issue was fixed on > master so just bisected to this. > > CC'ing stable to nominate: > 42627dabb4db3011825a022325be7ae9b51103d6 - (1/3) ac: add if/loop build > helpers > 6e1a142863b3

[Mesa-dev] [Bug 105807] [Regression, bisected]: 3D Rendering not working correctly in Warhammer 40k: Dawn of War II

https://bugs.freedesktop.org/show_bug.cgi?id=105807 --- Comment #8 from b...@besd.de --- These are from shaderdumps (good thing I have the sha naming in place otherwise these would have been overwritten ;) When GLSL is not forced [require] GLSL >= 0.00 // this is generated by OpenGL so maybe so

[Mesa-dev] [PATCH v3 3/7] nir: lower 64bit subgroup shuffle intrinsics

--- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_subgroups.c | 68 +++--- 2 files changed, 56 insertions(+), 13 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f33049d713..f3326e6df9 100644 --- a/src/compiler

[Mesa-dev] [PATCH v3 5/7] ac: add LLVM build functions for subgroup instrinsics

Co-authored-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 456 + src/amd/common/ac_llvm_build.h | 30 ++- 2 files changed, 485 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 2fb8aea

  1   2   >