Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Timothy Arceri writes: > I'd just like to point out that as an outside user of Intels CI I have > missed regressions on a couple of occasions. However this was not due to > "Lazy behaviour", having a CI system is fantastic and I'm very grateful > to have access to it. However, it's not uncommo

[Mesa-dev] [PATCH 14/14] st/radeonsi: enable uniform packing in NIR backend

--- src/gallium/drivers/radeonsi/si_get.c | 6 +- src/mesa/state_tracker/st_glsl_to_nir.cpp | 10 ++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 323700d425..b4ca5bea94 100644 --

[Mesa-dev] [PATCH 13/14] st: add uniform packing support to lower_uniforms_to_ubo()

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 2 +- src/mesa/state_tracker/st_nir.h | 3 ++- src/mesa/state_tracker/st_nir_lower_uniforms_to_ubo.c | 16 +++- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH 09/14] st/glsl_to_nir: add support for packed builtin uniforms

--- src/mesa/state_tracker/st_glsl_to_nir.cpp | 42 +++ 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp index 0bd9c4e4e3..1fd553fdf8 100644 --- a/src/mesa/state_tracker

[Mesa-dev] [PATCH 08/14] mesa: add _mesa_add_sized_state_reference() helper

This will be used for adding packed builtin uniforms. --- src/mesa/program/prog_parameter.c | 36 ++-- src/mesa/program/prog_parameter.h | 5 + 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/progra

[Mesa-dev] [PATCH 11/14] st/nir/radeonsi: move nir_lower_uniforms_to_ubo() to the state tracker

This will only even be used by gallium drivers so it probably doesn't belong in the nir toolkit. Also we want to pass it some non NIR things in the following patch. To avoid regressions we wrap the lowering calls that have been moved to st_glsl_to_nir with a quick hack so that they are only called

[Mesa-dev] [PATCH 12/14] gallium: add packed uniform CAP

--- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c | 1 + src/gallium/d

[Mesa-dev] [PATCH 06/14] mesa: allow for uniform packing when adding uniforms to param list

Reviewed-by: Nicolai Hähnle --- src/mesa/program/ir_to_mesa.cpp | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index dacb469855..149d914bc4 100644 --- a/src/mesa/program/ir_to_

[Mesa-dev] [PATCH 04/14] mesa: add packing support for setting uniforms

Reviewed-by: Nicolai Hähnle --- src/mesa/main/uniform_query.cpp | 72 ++--- 1 file changed, 53 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index eaed536f68..14ecfdca2f 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 05/14] mesa: add packing support for setting uniform handles

Reviewed-by: Nicolai Hähnle --- src/mesa/main/uniform_query.cpp | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 14ecfdca2f..f901fcb3e5 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/s

[Mesa-dev] [PATCH 03/14] mesa: create copy uniform to storage helpers

These will be used in the following patch to allow copying directly to the param list when packing is enabled. Reviewed-by: Nicolai Hähnle --- src/mesa/main/uniform_query.cpp | 154 1 file changed, 91 insertions(+), 63 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 10/14] st: add st_glsl_type_size_scalar() helper

This will be used to support uniform packing. --- src/mesa/state_tracker/st_glsl_types.cpp | 43 src/mesa/state_tracker/st_glsl_types.h | 1 + 2 files changed, 44 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_types.cpp b/src/mesa/state_tracker/st_g

[Mesa-dev] [PATCH 07/14] mesa: add support propagate uniform support for packed uniforms

--- src/mesa/program/ir_to_mesa.cpp | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 149d914bc4..19a9fd3fc2 100644 --- a/src/mesa/program/ir_to_mesa.cpp +++ b/src/mesa/program/ir_to_mes

[Mesa-dev] Uniform packing for radeonsi NIR

I've dusted off my old uniform packing patches and made it work with the radeonsi NIR backend. This was much simpler than the messing around needed for tgsi (which I never got fully working). One thing to note is we don't do packing from asm programs because there is currently no Mesa IR to NIR pa

[Mesa-dev] [PATCH 02/14] mesa: rework ParameterList to allow packing

Currently everything is padded to 4 components. Making the list more flexible will allow us to do uniform packing. V2 (suggestions from Nicolai): - always pass existing calls to _mesa_add_parameter() true for padd_and_align - fix bindless param value offsets - remove left over wip logic from pad a

[Mesa-dev] [PATCH 01/14] mesa: add PackedDriverUniformStorage const

Will be used to determine whether to take packing code paths or not. Reviewed-by: Nicolai Hähnle --- src/mesa/main/mtypes.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 2df2288899..1ee37b009f 100644 --- a/src/mesa/main/mtypes.h +++

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

https://bugs.freedesktop.org/show_bug.cgi?id=105464 libgra...@gmail.com changed: What|Removed |Added CC||libgra...@gmail.com -- You are re

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On 14/03/18 07:36, Mark Janes wrote: Daniel Vetter writes: On Tue, Mar 13, 2018 at 4:46 PM, Mark Janes wrote: Daniel Vetter writes: On Mon, Mar 12, 2018 at 11:54:45PM -0700, Kenneth Graunke wrote: On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote: [snip] I've been doing this for

Re: [Mesa-dev] [PATCH 2/2] configure.ac: require libdrm_amdgpu 2.4.91

Yes, it does. Marek On Mar 13, 2018 10:44 PM, "Dylan Baker" wrote: > Does meson need the same change? > > On March 13, 2018 6:03:18 PM PDT, "Marek Olšák" wrote: >> >> From: Marek Olšák >> >> Since 2.4.90 might not work, just ask for the next version. >> --- >> configure.ac | 9 + >>

[Mesa-dev] [PATCH 14/14] radv: drop geometry stride user sgpr.

From: Dave Airlie This removes the other geometry specific user sgpr. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 37 +++-- src/amd/vulkan/radv_pipeline.c| 9 - src/amd/vulkan/radv_shader.h | 1 - 3 files changed, 19 ins

[Mesa-dev] [PATCH 10/14] radv: use num_patches output from tcs shader.

From: Dave Airlie Instead of recalculating the value, use the shader calculated value. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulk

[Mesa-dev] [PATCH 09/14] radv/tess: remove last chunk of tess sgprs

From: Dave Airlie This removes the last TES-specifc user sgpr. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 50 --- src/amd/vulkan/radv_pipeline.c| 18 ++ src/amd/vulkan/radv_shader.h | 4 ++-- 3 files changed, 19

[Mesa-dev] [PATCH 13/14] radv: get rid of geometry user sgpr for num entries.

From: Dave Airlie This drops one of the geometry specific user sgprs, we can work this out at compile time. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 15 +++ src/amd/vulkan/radv_pipeline.c| 9 + 2 files changed, 8 insertions(+), 16 deletions(-)

[Mesa-dev] [PATCH 12/14] radv: migrate lds size calculations to shader gen.

From: Dave Airlie This moves the lds_size calcs into the shader so we have all the size stuff in one file. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 33 + src/amd/vulkan/radv_pipeline.c| 29 - src/amd/vulk

[Mesa-dev] [PATCH 11/14] radv: drop scanning the tess shader in the nir code.

From: Dave Airlie This drops the now unneeded scanning and results in favour of the ones in the info. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 33 - src/amd/vulkan/radv_pipeline.c| 7 +++ src/amd/vulkan/radv_shader.h | 5

[Mesa-dev] [PATCH 08/14] radv: pass num_patches to tes from tcs

From: Dave Airlie TES needs num_patches to do some of the calculations. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 4 +++- src/amd/vulkan/radv_pipeline.c| 4 src/amd/vulkan/radv_shader.h | 3 ++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 04/14] radv/tess: drop tcs_in_layout setting completely.

From: Dave Airlie Inline all calcs at shader creation. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 26 +- src/amd/vulkan/radv_pipeline.c| 12 ++-- src/amd/vulkan/radv_shader.h | 1 + 3 files changed, 24 insertions(+), 15 deletion

[Mesa-dev] [PATCH 06/14] radv: drop tcs_out_offsets

From: Dave Airlie Move all calculations to shader generation. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 39 +++ src/amd/vulkan/radv_pipeline.c| 10 ++ 2 files changed, 29 insertions(+), 20 deletions(-) diff --git a/src/a

[Mesa-dev] [PATCH 02/14] radv/shader_info: start gathering tess output info (v2)

From: Dave Airlie This gathers the ls outputs written by the vertex shader, and the tcs outputs, these are needed to calculate certain tcs parameters. These have to be separate for combined gfx9 shaders. This is a bit pessimistic compared to the nir pass, as we don't work out the individual slo

[Mesa-dev] [PATCH 03/14] radv: drop ls_out_layout const.

From: Dave Airlie We can precalculate input_vertex_size at compile time. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 30 -- src/amd/vulkan/radv_pipeline.c| 10 -- src/amd/vulkan/radv_shader.h | 1 - 3 files changed, 4 inserti

[Mesa-dev] [PATCH 07/14] radv: drop tess offchip layout for tcs.

From: Dave Airlie This removes the last TCS specific user sgpr. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 116 +- src/amd/vulkan/radv_pipeline.c| 9 --- src/amd/vulkan/radv_shader.c | 2 +- src/amd/vulkan/radv_shader.h

[Mesa-dev] [PATCH 05/14] radv: drop tcs_out_layout

From: Dave Airlie Move all calculations to shader generation. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 22 +- src/amd/vulkan/radv_pipeline.c| 8 ++-- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/radv_nir_

[Mesa-dev] [PATCH 01/14] radv: migrate unique index info shader info (v2)

From: Dave Airlie This just moves this function to an inline so the shader_info pass can use it. v2: use inline (Samuel) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_nir_to_llvm.c | 22 -- src/amd/vulkan/radv_shader.h | 21 + 2 files changed,

[Mesa-dev] radv: drop all tess and geometry user sgprs (v2)

None of the info we were passing from the pipeline into the shaders via user sgprs for tess/gs was required, this series removes all user sgprs in favour of calculating the values at compile time. This is a repost, I've rebased this into radv and hopefully taken all the comments on board. Dave. _

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

Am 13.03.2018 um 05:28 schrieb Dave Airlie: > On 13 March 2018 at 14:24, Dave Airlie wrote: >> This is the main code for the soft fp64 work. It's mostly Elie's >> code with a bunch of changes by me. >> > > All the patches are in my tree here, along with some other bits: > https://cgit.freedesktop

Re: [Mesa-dev] [PATCH 03/50] glsl: Add "built-in" function to do sign(fp64) (v2)

Am 14.03.2018 um 02:05 schrieb Dave Airlie: > On 14 March 2018 at 10:46, Roland Scheidegger wrote: >> Am 13.03.2018 um 05:24 schrieb Dave Airlie: >>> From: Elie Tournier >>> >>> v2: use mix. >>> >>> Signed-off-by: Elie Tournier >>> --- >>> src/compiler/glsl/builtin_float64.h | 28 ++

Re: [Mesa-dev] [PATCH 15/50] glsl: Add "built-in" functions to do sqrt(fp64)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > This currently uses fp64->fp32, sqrt(fp32), fp32->fp64. > > [airlied: The code is include from soft float for doing proper sqrt64 > but it needs to be decided if we need to pursue this and > how to optimise it better.] > > Si

Re: [Mesa-dev] [PATCH 2/2] fixup! dri3: allow building against older xcb (v3)

Wrap it in parens and it can span multiple lines On March 13, 2018 5:40:15 PM PDT, Rob Clark wrote: >On Tue, Mar 13, 2018 at 7:47 PM, Rob Clark wrote: >> On Tue, Mar 13, 2018 at 7:27 PM, Rob Clark >wrote: >>> On Tue, Mar 13, 2018 at 7:10 PM, Dylan Baker >wrote: Quoting Rob Clark (2018-03-

Re: [Mesa-dev] [PATCH 2/2] configure.ac: require libdrm_amdgpu 2.4.91

Does meson need the same change? On March 13, 2018 6:03:18 PM PDT, "Marek Olšák" wrote: >From: Marek Olšák > >Since 2.4.90 might not work, just ask for the next version. >--- > configure.ac | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > >diff --git a/configure.ac b/configure.a

Re: [Mesa-dev] [PATCH 06/50] glsl: Add "built-in" functions to do lt(fp64, fp64)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 135 > > src/compiler/glsl/builtin_functions.cpp | 4 + > src/compiler/glsl/builtin_functions.h | 3 + > s

Re: [Mesa-dev] [PATCH 2/2] configure.ac: require libdrm_amdgpu 2.4.91

On Tue, Mar 13, 2018 at 9:15 PM, Mike Lothian wrote: > Did you mean to remove the blacklist you added in the previous patch? Yes. The previous patch is for stable releases only, but it has to go through master. Marek ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

I am fine to add ref count for map pointer but then the code looks a little complex: We already have ref count for display target, and it seems most other drivers don't have a ref count for map pointer. (I checked dri_sw_displaytarget_map / gdi_sw_displaytarget_map/hgl_winsys_displaytarget_map /xli

Re: [Mesa-dev] [PATCH 2/2] configure.ac: require libdrm_amdgpu 2.4.91

Did you mean to remove the blacklist you added in the previous patch? On Wed, 14 Mar 2018 at 01:03 Marek Olšák wrote: > From: Marek Olšák > > Since 2.4.90 might not work, just ask for the next version. > --- > configure.ac | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > dif

Re: [Mesa-dev] [PATCH 04/50] glsl: Add "built-in" functions to do eq(fp64, fp64)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 104 > > src/compiler/glsl/builtin_functions.cpp | 4 ++ > src/compiler/glsl/builtin_functions.h | 3 + >

Re: [Mesa-dev] [PATCH 03/50] glsl: Add "built-in" function to do sign(fp64) (v2)

On 14 March 2018 at 10:46, Roland Scheidegger wrote: > Am 13.03.2018 um 05:24 schrieb Dave Airlie: >> From: Elie Tournier >> >> v2: use mix. >> >> Signed-off-by: Elie Tournier >> --- >> src/compiler/glsl/builtin_float64.h | 28 >> src/compiler/glsl/builtin_funct

[Mesa-dev] [PATCH 2/2] configure.ac: require libdrm_amdgpu 2.4.91

From: Marek Olšák Since 2.4.90 might not work, just ask for the next version. --- configure.ac | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index e29ce68..8ec5b26 100644 --- a/configure.ac +++ b/configure.ac @@ -67,21 +67,21 @@ OPENCL_VE

[Mesa-dev] [PATCH 1/2] configure.ac: blacklist libdrm 2.4.90

From: Marek Olšák Cc: 18.0 17.3 17.2 --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index 621dc32..e29ce68 100644 --- a/configure.ac +++ b/configure.ac @@ -2601,20 +2601,27 @@ if test -n "$with_gallium_drivers"; then rade

Re: [Mesa-dev] [PATCH 03/50] glsl: Add "built-in" function to do sign(fp64) (v2)

Am 13.03.2018 um 05:24 schrieb Dave Airlie: > From: Elie Tournier > > v2: use mix. > > Signed-off-by: Elie Tournier > --- > src/compiler/glsl/builtin_float64.h | 28 > src/compiler/glsl/builtin_functions.cpp | 4 > src/compiler/glsl/builtin_functions.h

Re: [Mesa-dev] [PATCH 2/2] fixup! dri3: allow building against older xcb (v3)

On Tue, Mar 13, 2018 at 7:47 PM, Rob Clark wrote: > On Tue, Mar 13, 2018 at 7:27 PM, Rob Clark wrote: >> On Tue, Mar 13, 2018 at 7:10 PM, Dylan Baker wrote: >>> Quoting Rob Clark (2018-03-13 16:04:00) --- I'm a bit unsure about the xcb-present version dependency, as that was added

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

On 14 March 2018 at 09:47, Gert Wollny wrote: > > Am Dienstag, den 13.03.2018, 14:24 +1000 schrieb Dave Airlie: >> This is the main code for the soft fp64 work. It's mostly Elie's >> code with a bunch of changes by me. > > Many thanks for this work, Elie and Dave. I've tested the patches on > BART

[Mesa-dev] [Bug 105464] Reading per-patch outputs in Tessellation Control Shader returns undefined values

https://bugs.freedesktop.org/show_bug.cgi?id=105464 --- Comment #3 from Dave Airlie --- https://patchwork.freedesktop.org/series/39918/ Should fix this, thanks for the report and reproducer. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for th

[Mesa-dev] [PATCH 1/3] radv: get correct offset into LDS for indexed vars.

From: Dave Airlie This seems more correct to me, since if we have an array of floats they'll be vec4 aligned, and if we do af[2], we want the const index to increase by 2 slots in the non compact case. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464 Fixes: 94f9591995 (radv/ac: add

[Mesa-dev] [PATCH 2/3] ac/nir: pass the nir variable through tcs loading.

From: Dave Airlie I was going to have to add another parameter to this monster, so we should just pass the nir_variable in, I can't find any reason this would be a bad idea. This needed for the next fix. Fixes: 94f9591995 (radv/ac: add support for TCS/TES inputs/outputs.) Signed-off-by: Dave Ai

[Mesa-dev] [PATCH 3/3] ac/radv: mark all tess output for an indirect access.

From: Dave Airlie If a shader does a tcs store with an indirect access, we were only marking the first spot as used. For indirect access we always now mark all slots used by the variable. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464 Fixes: 94f9591995 (radv/ac: add support for TC

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

On 14 March 2018 at 09:54, Matt Turner wrote: > On Mon, Mar 12, 2018 at 9:24 PM, Dave Airlie wrote: >> This is the main code for the soft fp64 work. It's mostly Elie's >> code with a bunch of changes by me. >> >> This patchset has all the glsl lowering code. (using float64.glsl, >> yes I know che

[Mesa-dev] [PATCH] intel/compiler: Check for unsupported register sizes.

Make sure we don't emit 64 bit types if the hardware doesn't support them. Signed-off-by: Rafael Antognolli Suggested-by: Kenneth Graunke --- src/intel/compiler/brw_reg_type.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/compiler/brw_reg_type.c b/src/intel/compiler/brw_reg_

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

On Mon, Mar 12, 2018 at 9:24 PM, Dave Airlie wrote: > This is the main code for the soft fp64 work. It's mostly Elie's > code with a bunch of changes by me. > > This patchset has all the glsl lowering code. (using float64.glsl, > yes I know checked in files are bad, but not bad enough for anyone >

Re: [Mesa-dev] soft fp64 support - main body (glsl/gallium)

Am Dienstag, den 13.03.2018, 14:24 +1000 schrieb Dave Airlie: > This is the main code for the soft fp64 work. It's mostly Elie's > code with a bunch of changes by me. Many thanks for this work, Elie and Dave. I've tested the patches on BARTS with nosb, piglit set all, -t fp64, and I get 2976 of 2

Re: [Mesa-dev] [PATCH 2/2] fixup! dri3: allow building against older xcb (v3)

On Tue, Mar 13, 2018 at 7:27 PM, Rob Clark wrote: > On Tue, Mar 13, 2018 at 7:10 PM, Dylan Baker wrote: >> Quoting Rob Clark (2018-03-13 16:04:00) >>> --- >>> I'm a bit unsure about the xcb-present version dependency, as that was >>> added in a different commit. OTOH I guess Dave is building vul

Re: [Mesa-dev] [PATCH] meson: fix pipe-loaders after omx changes

On Tue, Mar 13, 2018 at 7:05 PM, Dylan Baker wrote: > with_gallium_omx used to be a boolean, but now it's a string. That means > it needs to be compared to 'disabled' instead of false. > > CC: Rob Clark > Fixes: 34e852d5b50772199797ea839fc8d6b3805633ff >("meson: Re-add auto option for omx

Re: [Mesa-dev] [PATCH 2/2] fixup! dri3: allow building against older xcb (v3)

On Tue, Mar 13, 2018 at 7:10 PM, Dylan Baker wrote: > Quoting Rob Clark (2018-03-13 16:04:00) >> --- >> I'm a bit unsure about the xcb-present version dependency, as that was >> added in a different commit. OTOH I guess Dave is building vulkan with >> his patch so it is perhaps not a built-time d

[Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) Reviewed-by: Eric Anholt --- src/util/hash_table.c | 22 ++ src/util/hash_table.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index b7421a0144..f8

[Mesa-dev] [PATCH 0/2] V2: Use hash table cloning in copy propagation

Sending out a v2 just in case someone has any more comments. If not I'll probably push these tomorrow, or thursday. This is a revival of some old patches I had around to improve the compile times in the glsl compiler by reducing the time spend inserting items in the hash table in opt_copy_propagat

[Mesa-dev] [PATCH 2/2] glsl: Use hash table cloning in copy propagation

Walking the whole hash table, inserting entries by hashing them first is just a really bad idea. We can simply memcpy the whole thing. While this does not have a major performance impact on average, as it only helps shaders with a lot of branches, it might help individual shaders quite a lot. For

Re: [Mesa-dev] [PATCH 2/2] fixup! dri3: allow building against older xcb (v3)

Quoting Rob Clark (2018-03-13 16:04:00) > --- > I'm a bit unsure about the xcb-present version dependency, as that was > added in a different commit. OTOH I guess Dave is building vulkan with > his patch so it is perhaps not a built-time dependency. > > meson.build | 11 --- > 1 file cha

[Mesa-dev] [PATCH] meson: fix pipe-loaders after omx changes

with_gallium_omx used to be a boolean, but now it's a string. That means it needs to be compared to 'disabled' instead of false. CC: Rob Clark Fixes: 34e852d5b50772199797ea839fc8d6b3805633ff ("meson: Re-add auto option for omx") Signed-off-by: Dylan Baker --- src/gallium/targets/pipe-loa

[Mesa-dev] [PATCH 2/2] fixup! dri3: allow building against older xcb (v3)

--- I'm a bit unsure about the xcb-present version dependency, as that was added in a different commit. OTOH I guess Dave is building vulkan with his patch so it is perhaps not a built-time dependency. meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/me

[Mesa-dev] [PATCH 1/2] fixup! dri3: allow building against older xcb (v3)

--- You can squash this, and at your descrition the 2nd one into Dave's patch[1] [1] https://patchwork.freedesktop.org/patch/210351/ meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 3a00456e7c9..c201644c372 100644 --- a/meson.build +

[Mesa-dev] [Bug 105494] UT2004 cube map reflection problem

https://bugs.freedesktop.org/show_bug.cgi?id=105494 --- Comment #2 from almos --- Created attachment 138082 --> https://bugs.freedesktop.org/attachment.cgi?id=138082&action=edit shot43.png -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 105494] UT2004 cube map reflection problem

https://bugs.freedesktop.org/show_bug.cgi?id=105494 Bug ID: 105494 Summary: UT2004 cube map reflection problem Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Prio

[Mesa-dev] [Bug 105494] UT2004 cube map reflection problem

https://bugs.freedesktop.org/show_bug.cgi?id=105494 --- Comment #1 from almos --- Created attachment 138081 --> https://bugs.freedesktop.org/attachment.cgi?id=138081&action=edit shot42.png -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 2/4] st/nine: Fix bad tracking of vs textures for NINESBT_ALL

Stateblocks with NINESBT_ALL should track all textures. For better performance they have a faster path which copies all the required. This path was only tracking ps textures. Fixes: https://github.com/iXit/Mesa-3D/issues/303 Signed-off-by: Axel Davy CC: "17.3 18.0" --- src/gallium/state_trac

[Mesa-dev] [PATCH 4/4] st/nine: Fix non inversible matrix check

There was a missing absolute value when checking if the determinant was big enough. Fixes: https://github.com/iXit/Mesa-3D/issues/292 Signed-off-by: Axel Davy CC: "17.3 18.0" --- src/gallium/state_trackers/nine/nine_ff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/

[Mesa-dev] [PATCH 1/4] st/nine: Fix bad tracking of bound vs textures

An incorrect formula was used to compute bound_samplers_mask_vs. Since s is above always 8 for vs and the variable is encoded on 8 bits, it was always 0. This resulted in commiting the samplers every call when there was at least one texture read in the vs shader. Signed-off-by: Axel Davy --- src

[Mesa-dev] [PATCH 3/4] st/nine: Fixes warning about implicit conversion

Makes the conversion explicit. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=102542 Signed-off-by: Axel Davy CC: "17.3 18.0" --- src/gallium/state_trackers/nine/nine_ff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src

Re: [Mesa-dev] [PATCH v2] nir: lower_load_const_to_scalar fix for 8/16b types

Reviewed-by: Jason Ekstrand On Tue, Mar 13, 2018 at 2:39 PM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > Now with switch (and also u64<-u64 copy instead of f64<-f64 for 64b).. > > src/compiler/nir/nir_lower_load_const_to_scalar.c | 19 > +++ > 1 file changed, 15 insert

[Mesa-dev] [PATCH v2] nir: lower_load_const_to_scalar fix for 8/16b types

Signed-off-by: Rob Clark --- Now with switch (and also u64<-u64 copy instead of f64<-f64 for 64b).. src/compiler/nir/nir_lower_load_const_to_scalar.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_lower_load_const_to_scalar.c b/src/

Re: [Mesa-dev] [PATCH] dri3: allow building against older xcb (v3)

Quoting Rob Clark (2018-03-13 14:08:46) > On Tue, Mar 13, 2018 at 4:48 PM, Dylan Baker wrote: > > Quoting Dave Airlie (2018-03-13 13:06:00) > >> From: Dave Airlie > >> > >> I'm not sure everyone wants to be updating their dri3 in a forced > >> march setting, this allows a nicer approach, esp when

Re: [Mesa-dev] [PATCH] dri3: allow building against older xcb (v3)

Quoting Rob Clark (2018-03-13 14:08:46) > On Tue, Mar 13, 2018 at 4:48 PM, Dylan Baker wrote: > > Quoting Dave Airlie (2018-03-13 13:06:00) > >> From: Dave Airlie > >> > >> I'm not sure everyone wants to be updating their dri3 in a forced > >> march setting, this allows a nicer approach, esp when

Re: [Mesa-dev] [PATCH] dri3: allow building against older xcb (v3)

On Tue, Mar 13, 2018 at 4:48 PM, Dylan Baker wrote: > Quoting Dave Airlie (2018-03-13 13:06:00) >> From: Dave Airlie >> >> I'm not sure everyone wants to be updating their dri3 in a forced >> march setting, this allows a nicer approach, esp when you want >> to build on distro that aren't brand ne

[Mesa-dev] [PATCH] radv: fix vkGetDeviceQueue2() when create flags don't match

This fixes CTS: dEQP-VK.api.device_init.create_device_queue2_unmatched_flags Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 23 +-- src/amd/vulkan/radv_private.h | 1 + 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_de

Re: [Mesa-dev] [PATCH] dri3: allow building against older xcb (v3)

Quoting Dave Airlie (2018-03-13 13:06:00) > From: Dave Airlie > > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer approach, esp when you want > to build on distro that aren't brand new. > > I'm sure there are plenty of ways this patch could

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Daniel Vetter writes: > On Tue, Mar 13, 2018 at 4:46 PM, Mark Janes wrote: >> Daniel Vetter writes: >> >>> On Mon, Mar 12, 2018 at 11:54:45PM -0700, Kenneth Graunke wrote: On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote: [snip] > I've been doing this for Intel. Develop

Re: [Mesa-dev] [PATCH 0/2] nir: Move the si vote lowering to common code

On Tue, Mar 13, 2018 at 11:39 AM, Bas Nieuwenhuizen wrote: > Thanks a lot! > You're welcome. Classic case of writing code is easier than reviewing it. :-) > Reviewed-by: Bas Nieuwenhuizen > Thanks! Pushed. > for the series. > > On Sat, Mar 10, 2018 at 7:42 PM, Jason Ekstrand > wrote: >

Re: [Mesa-dev] [PATCH] nir: lower_load_const_to_scalar fix for 8/16b types

On Tue, Mar 13, 2018 at 12:45 PM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > src/compiler/nir/nir_lower_load_const_to_scalar.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_lower_load_const_to_scalar.c > b/src/compiler/nir/nir_lo

[Mesa-dev] [PATCH] dri3: allow building against older xcb (v3)

From: Dave Airlie I'm not sure everyone wants to be updating their dri3 in a forced march setting, this allows a nicer approach, esp when you want to build on distro that aren't brand new. I'm sure there are plenty of ways this patch could be cleaner, and I've also not built it against an update

Re: [Mesa-dev] [PATCH 1/2] util: Implement a hash table cloning function

2018-03-12 19:48 GMT+01:00 Emil Velikov : > Hi Thomas, > > On 12 March 2018 at 17:55, Thomas Helland wrote: >> V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) >> --- >> src/util/hash_table.c | 22 ++ >> src/util/hash_table.h | 2 ++ >> 2 files changed,

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Kenneth Graunke writes: > [ Unknown signature status ] > On Friday, March 9, 2018 12:12:28 PM PDT Mark Janes wrote: > [snip] >> I've been doing this for Intel. Developers are on the hook to fix their >> bugs, but you can't make them do it. They have many pressures on them, >> and a maintainer c

Re: [Mesa-dev] [PATCH 4/5 v6] clover/llvm: Add get_[cl|language]_version, validation and some helpers

Sorry, partially forgot about it. I’ll look at it over the weekend, as I don’t have time before. :-/ Pierre signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo

[Mesa-dev] [PATCH] nir: lower_load_const_to_scalar fix for 8/16b types

Signed-off-by: Rob Clark --- src/compiler/nir/nir_lower_load_const_to_scalar.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_lower_load_const_to_scalar.c b/src/compiler/nir/nir_lower_load_const_to_scalar.c index e494facfd21..9d37e3fecef 100644

[Mesa-dev] [PATCH 2/2] radv: align tessellation patch limits with amdvlk driver.

From: Dave Airlie AMDVLK says 16 for pre-GFX9 and 64 for GFX9. This seems to help fix: https://bugs.freedesktop.org/show_bug.cgi?id=105464 on Polaris. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464 Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 10 +++--- 1

[Mesa-dev] [PATCH 1/2] radv: get correct offset into LDS for indexed vars.

From: Dave Airlie This seems more correct to me, since if we have an array of floats they'll be vec4 aligned, and if we do af[2], we want the const index to increase by 2 slots in the non compact case. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105464 Fixes: 94f9591995 (radv/ac: add

Re: [Mesa-dev] tizonia egl build fail

Quoting Andy Furniss (2018-03-06 15:12:37) > make[5]: Entering directory > '/mnt/sdc1/Gits/mesa/src/gallium/state_trackers/omx/tizonia' >CC h264dprc.lo > In file included from h264dprc.c:45:0: > ../../../../../src/egl/drivers/dri2/egl_dri2.h:47:10: fatal error: > wayland/wayland-egl/way

Re: [Mesa-dev] [PATCH 2/3] meson: Use the same version for all libdrm checks

Quoting Ilia Mirkin (2018-03-13 12:15:08) > On Tue, Mar 13, 2018 at 3:05 PM, Emil Velikov > wrote: > > On 13 March 2018 at 18:52, Dylan Baker wrote: > >> Currently each driver specifies it's own version, and core libdrm > >> specifies a version. In the most common case this is fine, since there

Re: [Mesa-dev] [PATCH 2/3] meson: Use the same version for all libdrm checks

On Tue, Mar 13, 2018 at 3:05 PM, Emil Velikov wrote: > On 13 March 2018 at 18:52, Dylan Baker wrote: >> Currently each driver specifies it's own version, and core libdrm >> specifies a version. In the most common case this is fine, since there >> will be exactly one libdrm installed on a system,

Re: [Mesa-dev] [PATCH] radv: Fix CmdCopyImage between uncompressed and compressed images

On 13 March 2018 at 01:38, Alex Smith wrote: > From the spec: > > "When copying between compressed and uncompressed formats the > extent members represent the texel dimensions of the source > image and not the destination." > > However, as per 7b890a36, we must still use the destinat

Re: [Mesa-dev] [PATCH 2/3] meson: Use the same version for all libdrm checks

On 13 March 2018 at 18:52, Dylan Baker wrote: > Currently each driver specifies it's own version, and core libdrm > specifies a version. In the most common case this is fine, since there > will be exactly one libdrm installed on a system, but if there are more > than one it's possible that mesa wi

Re: [Mesa-dev] [PATCH 2/2] autotools: add -I/src/egl to tizonia

On 13 March 2018 at 18:23, Dylan Baker wrote: > Quoting Emil Velikov (2018-03-13 09:41:47) >> On 7 March 2018 at 23:13, Dylan Baker wrote: >> > meson got the same fix. >> > >> > cc: Emil Veliov >> > Signed-off-by: Dylan Baker >> > --- >> > >> > I don't know hat the "right" fix is here Emil, I j

[Mesa-dev] [PATCH 3/3] meson: use dep_libdrm version for pkg-config

This corrects pkg-config to use the libdrm version (as computed by the previous patch) instead of using a hardcoded value that may or may not (probably not) be right. Signed-off-by: Dylan Baker --- src/gallium/targets/d3dadapter9/meson.build | 2 +- src/mesa/drivers/dri/meson.build|

[Mesa-dev] [PATCH 2/3] meson: Use the same version for all libdrm checks

Currently each driver specifies it's own version, and core libdrm specifies a version. In the most common case this is fine, since there will be exactly one libdrm installed on a system, but if there are more than one it's possible that mesa will be linked against different versions of libdrm. Ther

  1   2   >