Re: [Mesa-dev] [PATCH] tgsi/scan: use wrap-around shift behavior explicitly for file_mask

2018-03-01 Thread Jose Fonseca
On 02/03/18 02:23, Brian Paul wrote: On 03/01/2018 07:01 PM, srol...@vmware.com wrote: From: Roland Scheidegger The comment said it will only represent the lowest 32 regs. This was not entirely true in practice, since at least on x86 you'll get masked shifts (unless the compiler could recogniz

Re: [Mesa-dev] [PATCH 11/12] vbo: Remove vbo_save_vertex_list::buffer_offset.

2018-03-01 Thread Mathias Fröhlich
Hi Brian, On Thursday, 1 March 2018 18:15:55 CET Brian Paul wrote: > That sounds great. At VMware we come across quite a few legacy GL apps > that make heavy use of display lists, and often times, the applications > are pretty inefficient with display list use. I know. Working myself for a CAE

Re: [Mesa-dev] [PATCH] util: use clock_gettime() on PIPE_OS_BSD

2018-03-01 Thread Jonathan Gray
On Wed, Feb 28, 2018 at 08:22:57AM -0700, Brian Paul wrote: > On 02/28/2018 03:19 AM, Jonathan Gray wrote: > > OpenBSD, FreeBSD, NetBSD and DragonFlyBSD all have clock_gettime() > > so use it when PIPE_OS_BSD is defined. > > > > Signed-off-by: Jonathan Gray > > --- > > src/util/os_time.c | 2 +-

Re: [Mesa-dev] [PATCH 02/13] nir: add load_param

2018-03-01 Thread Jason Ekstrand
On Wed, Feb 28, 2018 at 1:25 PM, Rob Clark wrote: > On Wed, Feb 28, 2018 at 4:16 PM, Eric Anholt wrote: > > Rob Clark writes: > > > >> From: Karol Herbst > >> > >> OpenCL kernels have parameters (see pipe_grid_info::input), and so we > >> need a way to access them. > >> > >> Signed-off-by: Rob

Re: [Mesa-dev] [PATCH] Update the documentation for meson

2018-03-01 Thread Matt Turner
On Thu, Mar 1, 2018 at 11:34 AM, Dylan Baker wrote: > Meson is pretty well tested and works in most configurations now, so we > can remove the warning about it being unsuited for actual use. > > It's also worth documenting that meson 0.42.0 or greater is required. > > Signed-off-by: Dylan Baker >

Re: [Mesa-dev] [PATCH] Update the documentation for meson

2018-03-01 Thread Brian Paul
On 03/01/2018 12:34 PM, Dylan Baker wrote: Meson is pretty well tested and works in most configurations now, so we can remove the warning about it being unsuited for actual use. It's also worth documenting that meson 0.42.0 or greater is required. Signed-off-by: Dylan Baker --- docs/meson.ht

Re: [Mesa-dev] [PATCH] tgsi/scan: use wrap-around shift behavior explicitly for file_mask

2018-03-01 Thread Brian Paul
On 03/01/2018 07:01 PM, srol...@vmware.com wrote: From: Roland Scheidegger The comment said it will only represent the lowest 32 regs. This was not entirely true in practice, since at least on x86 you'll get masked shifts (unless the compiler could recognize it already and toss it out). It turn

[Mesa-dev] [PATCH 4/5 v6] clover/llvm: Add get_[cl|language]_version, validation and some helpers

2018-03-01 Thread Aaron Watry
Used to calculate the default CLC language version based on the --cl-std in build args and the device capabilities. According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by: 1) If you have -cl-std=CL1.1+ use the version specified 2) If not, use the highest 1.x version that th

[Mesa-dev] [PATCH] tgsi/scan: use wrap-around shift behavior explicitly for file_mask

2018-03-01 Thread sroland
From: Roland Scheidegger The comment said it will only represent the lowest 32 regs. This was not entirely true in practice, since at least on x86 you'll get masked shifts (unless the compiler could recognize it already and toss it out). It turns out this actually works out alright (presumably no

Re: [Mesa-dev] [PATCH 4/5] clover/llvm: Add get_[cl|language]_version, validation and some helpers

2018-03-01 Thread Aaron Watry
On Thu, Mar 1, 2018 at 3:43 PM, Pierre Moreau wrote: > On 2018-03-01 — 13:39, Aaron Watry wrote: >> Used to calculate the default CLC language version based on the --cl-std in >> build args >> and the device capabilities. >> >> According to section 5.8.4.5 of the 2.0 spec, the CL C version is cho

Re: [Mesa-dev] [PATCH 2/2] clover: Include generic type in several kernel/device obj() calls

2018-03-01 Thread Aaron Watry
On Thu, Mar 1, 2018, 5:19 PM Francisco Jerez wrote: > Aaron Watry writes: > > > Fixes auto-completion for some device and kernel methods in my IDE. > > > > No functional change intended. > > > > NAK to this one. object.hpp goes through quite some effort to infer the > type automatically in a wa

[Mesa-dev] [Bug 105291] r600 [CEDAR]: GPU stalls when running shadertoy "ladybug"

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105291 --- Comment #2 from Roland Scheidegger --- You could figure out if it simply takes too long by increasing the timeout (albeit that needs a recompile of the kernel module). If so, I'm not sure what to do really. (Though I think the shader actuall

Re: [Mesa-dev] [PATCH 1/2] i965: Generalize intel_upload.c to support multiple uploaders.

2018-03-01 Thread Chris Wilson
Quoting Kenneth Graunke (2018-03-01 23:39:54) > I'd like to reuse the upload logic for a new program cache, but the > buffers will need to have a different lifetime than the default > uploader, and also some address space restrictions. > > This makes it a bit more like u_upload_mgr. To be clear,

[Mesa-dev] [Bug 105291] r600 [CEDAR]: GPU stalls when running shadertoy "ladybug"

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105291 --- Comment #1 from russianneuroman...@ya.ru --- Created attachment 137739 --> https://bugs.freedesktop.org/attachment.cgi?id=137739&action=edit dmesg of Radeon HD 6620G hang Same issue here when running on SUMO iGPU with Linux 4.15.5 and Mesa

[Mesa-dev] [PATCH 1/2] i965: Generalize intel_upload.c to support multiple uploaders.

2018-03-01 Thread Kenneth Graunke
I'd like to reuse the upload logic for a new program cache, but the buffers will need to have a different lifetime than the default uploader, and also some address space restrictions. This makes it a bit more like u_upload_mgr. --- src/mesa/drivers/dri/i965/brw_context.c | 2 + src/mesa

[Mesa-dev] [PATCH 2/2] i965: Mark upload buffers with MAP_ASYNC and MAP_PERSISTENT.

2018-03-01 Thread Kenneth Graunke
This should have no practical impact. For the default uploader, we don't really care, but for others, we may want to append more data as the GPU is reading existing data, which means we need async and persistent flags. --- src/mesa/drivers/dri/i965/intel_upload.c | 4 +++- 1 file changed, 3 inser

Re: [Mesa-dev] [PATCH 2/2] clover: Include generic type in several kernel/device obj() calls

2018-03-01 Thread Francisco Jerez
Aaron Watry writes: > Fixes auto-completion for some device and kernel methods in my IDE. > > No functional change intended. > NAK to this one. object.hpp goes through quite some effort to infer the type automatically in a way that's guaranteed correct. I don't think we want to increase the sy

[Mesa-dev] [Bug 105320] Wrong results produced by vkCmdCopyBuffer() from storage texel buffer

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105320 Bug ID: 105320 Summary: Wrong results produced by vkCmdCopyBuffer() from storage texel buffer Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/fs: Set up sampler message headers in the visitor on gen7+

2018-03-01 Thread Jason Ekstrand
On Thu, Mar 1, 2018 at 12:38 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > This gives the scheduler visibility into the headers which should > > improve scheduling. More importantly, however, it lets the scheduler > > know that the header gets written. As-is, the scheduler thinks t

Re: [Mesa-dev] [PATCH 05/29] intel/isl: Add a helper for inverting swizzles

2018-03-01 Thread Jason Ekstrand
On Thu, Mar 1, 2018 at 6:49 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Mon, Feb 26, 2018 at 08:42:42AM -0800, Jason Ekstrand wrote: > > On Mon, Feb 26, 2018 at 6:19 AM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Fri, Jan 26, 2018 at 05:59:34PM -080

Re: [Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

2018-03-01 Thread Francisco Jerez
Aaron Watry writes: > Useful for testing API, builtin library, and device completeness of > not-yet-supported versions. > > Signed-off-by: Aaron Watry > Cc: Pierre Moreau > Cc: Jan Vesely > Cc: Francisco Jerez > --- > src/gallium/state_trackers/clover/api/platform.cpp | 7 ++- > src/gall

[Mesa-dev] [Bug 105161] KHR_blend_equation_advanced doesn't work in GLSL 1.10-1.40 shaders

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105161 Kenneth Graunke changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG

Re: [Mesa-dev] [PATCH 3/5] clover/llvm: Pass device down to compile

2018-03-01 Thread Francisco Jerez
Aaron Watry writes: > We'll need to be able to detect device version to define the appropriate > __OPENCL_VERSION__ header. > > v2: Rebase after removing the previous patch (Pierre) > - Removed "clover: Add device_clc_version to llvm::create_compiler_instance" > > Signed-off-by: Aaron Watry >

Re: [Mesa-dev] 2018 X.Org Board of Directors Elections Nomination period is NOW

2018-03-01 Thread Rob Clark
All, We have extended the deadline for nominations until 9 Mar 2018. We currently have four nominees for four seats, but we would like to have at least another candidate or two, so please consider stepping up and nominating yourself or a friend! BR, -R On Fri, Feb 9, 2018 at 9:01 AM, Rob Clark

[Mesa-dev] [Bug 105255] Waiting for fences without waitAll is not implemented

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105255 Józef Kucia changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: simplify st_nir_assign_var_locations() and fix for fs outputs

2018-03-01 Thread Timothy Arceri
Just FYI this has been reviewed over IRC and pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] ac: fix nir_intrinsic_shared_atomic_comp_swap handling

2018-03-01 Thread Timothy Arceri
Just FYI this has been reviewed over IRC and pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

2018-03-01 Thread Pierre Moreau
Reviewed-by: Pierre Moreau On 2018-03-01 — 13:44, Aaron Watry wrote: > Useful for testing API, builtin library, and device completeness of > not-yet-supported versions. > > Signed-off-by: Aaron Watry > Cc: Pierre Moreau > Cc: Jan Vesely > Cc: Francisco Jerez > --- > src/gallium/state_tracke

Re: [Mesa-dev] [PATCH 4/5] clover/llvm: Add get_[cl|language]_version, validation and some helpers

2018-03-01 Thread Pierre Moreau
On 2018-03-01 — 22:43, Pierre Moreau wrote: > On 2018-03-01 — 13:39, Aaron Watry wrote: > > Used to calculate the default CLC language version based on the --cl-std in > > build args > > and the device capabilities. > > > > According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen

Re: [Mesa-dev] [PATCH 4/5] clover/llvm: Add get_[cl|language]_version, validation and some helpers

2018-03-01 Thread Pierre Moreau
On 2018-03-01 — 13:39, Aaron Watry wrote: > Used to calculate the default CLC language version based on the --cl-std in > build args > and the device capabilities. > > According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by: > 1) If you have -cl-std=CL1.1+ use the version spe

[Mesa-dev] [PATCH 3/3] radv: report the scratch private memory size with shader stats

2018-03-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 171802eede..d216408074 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shade

[Mesa-dev] [PATCH 1/3] ac: add ac_count_scratch_private_memory()

2018-03-01 Thread Samuel Pitoiset
Imported from RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_util.c| 31 +++ src/amd/common/ac_llvm_util.h| 3 +++ src/gallium/drivers/radeonsi/si_shader.c | 32 3 files changed, 38 inserti

[Mesa-dev] [PATCH 2/3] ac/nir: count the scratch private memory size

2018-03-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 10 -- src/amd/common/ac_nir_to_llvm.h | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 23344909af..6446dd682f 100644 --- a/sr

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel/fs: Set up sampler message headers in the visitor on gen7+

2018-03-01 Thread Francisco Jerez
Jason Ekstrand writes: > This gives the scheduler visibility into the headers which should > improve scheduling. More importantly, however, it lets the scheduler > know that the header gets written. As-is, the scheduler thinks that a > texture instruction only reads it's payload and is unaware

Re: [Mesa-dev] [PATCH 1/5] clover/llvm: Use device in llvm compilation instead of copying fields

2018-03-01 Thread Pierre Moreau
I am wondering whether you should squash the first three patches together, as they are all about passing the device around rather than the attributes, and patch 2 (and 3) just start from where the previous patch left, and pass the device one level deeper in the call chain. Regardless of whether the

Re: [Mesa-dev] [PATCH 2/5] clover: Pass device to llvm::create_compiler_instance

2018-03-01 Thread Jan Vesely
On Thu, 2018-03-01 at 13:39 -0600, Aaron Watry wrote: > We'll be using dev.device_clc_version to select the default language version > soon along with the existing ir_target field. > > Signed-off-by: Aaron Watry > Cc: Pierre Moreau > Cc: Jan Vesely > > v4: Pass the device down instead of devic

Re: [Mesa-dev] [PATCH 1/5] clover/llvm: Use device in llvm compilation instead of copying fields

2018-03-01 Thread Jan Vesely
On Thu, 2018-03-01 at 13:39 -0600, Aaron Watry wrote: > Copying the individual fields from the device when compiling/linking > will lead to an unnecessarily large number of fields getting passed > around. > > v3: Rebase on current master > v2: Use device in function args before making additional c

Re: [Mesa-dev] [PATCH 3/6] intel/ir: Allow arbitrary scratch flag registers for SHADER_OPCODE_FIND_LIVE_CHANNEL.

2018-03-01 Thread Francisco Jerez
Kenneth Graunke writes: > On Tuesday, February 27, 2018 1:38:25 PM PST Francisco Jerez wrote: >> This shouldn't cause any functional change at this point, it changes >> SHADER_OPCODE_FIND_LIVE_CHANNEL to use the flag register specified at >> the IR level instead of the hard-coded f1.0, now that i

[Mesa-dev] [PATCH 1/2] clover: Allow overriding platform/device version numbers

2018-03-01 Thread Aaron Watry
Useful for testing API, builtin library, and device completeness of not-yet-supported versions. Signed-off-by: Aaron Watry Cc: Pierre Moreau Cc: Jan Vesely Cc: Francisco Jerez --- src/gallium/state_trackers/clover/api/platform.cpp | 7 ++- src/gallium/state_trackers/clover/core/device.cpp

[Mesa-dev] [PATCH 2/2] clover: Include generic type in several kernel/device obj() calls

2018-03-01 Thread Aaron Watry
Fixes auto-completion for some device and kernel methods in my IDE. No functional change intended. Signed-off-by: Aaron Watry --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- src/gallium/state_trackers/clover/api/kernel.cpp | 22 +++--- 2 files changed, 12 insertion

Re: [Mesa-dev] [PATCH 4/6] intel/eu: Plumb header present bit to codegen helpers for HDC messages.

2018-03-01 Thread Jordan Justen
1-4 Reviewed-by: Jordan Justen On 2018-02-27 13:38:26, Francisco Jerez wrote: > This makes sure that the header-present bit of the message descriptor > is in sync with the IR instruction fields, which gives the optimizer > more control to avoid the overhead of setting up a message header when > i

[Mesa-dev] [PATCH 0/5 v3] A few clover fixes for both CTS and eventual 1.2 support

2018-03-01 Thread Aaron Watry
The first two patches of the previous series [1] landed upstream a while back. When I bump my platform/device versions to 1.2, the clang instance has been confirmed to enable 1.2 language features (like the static keyword required in test/cl/program/execute/static.cl, which goes skip->pass), while

[Mesa-dev] [PATCH 4/5] clover/llvm: Add get_[cl|language]_version, validation and some helpers

2018-03-01 Thread Aaron Watry
Used to calculate the default CLC language version based on the --cl-std in build args and the device capabilities. According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by: 1) If you have -cl-std=CL1.1+ use the version specified 2) If not, use the highest 1.x version that th

[Mesa-dev] [PATCH 2/5] clover: Pass device to llvm::create_compiler_instance

2018-03-01 Thread Aaron Watry
We'll be using dev.device_clc_version to select the default language version soon along with the existing ir_target field. Signed-off-by: Aaron Watry Cc: Pierre Moreau Cc: Jan Vesely v4: Pass the device down instead of device_clc_version as a separate field v3: Revise to acknowledge that we no

[Mesa-dev] [PATCH 1/5] clover/llvm: Use device in llvm compilation instead of copying fields

2018-03-01 Thread Aaron Watry
Copying the individual fields from the device when compiling/linking will lead to an unnecessarily large number of fields getting passed around. v3: Rebase on current master v2: Use device in function args before making additional changes in following patches Signed-off-by: Aaron Watry Cc: Jan

[Mesa-dev] [PATCH 3/5] clover/llvm: Pass device down to compile

2018-03-01 Thread Aaron Watry
We'll need to be able to detect device version to define the appropriate __OPENCL_VERSION__ header. v2: Rebase after removing the previous patch (Pierre) - Removed "clover: Add device_clc_version to llvm::create_compiler_instance" Signed-off-by: Aaron Watry Cc: Pierre Moreau --- src/gallium/

[Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-01 Thread Aaron Watry
Use get_language_version to calculate default cl standard based on device capabilities and -cl-std specified in build options. v4: Squash the __OPENCL_VERSION__ and CLC language version patches v3: (Jan) Allow device_version up to 2.2 while device_clc_version only goes to 2.0 Use get_cl_ve

[Mesa-dev] [PATCH] Update the documentation for meson

2018-03-01 Thread Dylan Baker
Meson is pretty well tested and works in most configurations now, so we can remove the warning about it being unsuited for actual use. It's also worth documenting that meson 0.42.0 or greater is required. Signed-off-by: Dylan Baker --- docs/meson.html | 34 +- 1

Re: [Mesa-dev] [PATCH 5/6] intel/fs: Handle surface opcode sample masks via predication.

2018-03-01 Thread Kenneth Graunke
On Tuesday, February 27, 2018 1:38:27 PM PST Francisco Jerez wrote: > The main motivation is to enable HDC surface opcodes on ICL which no > longer allows the sample mask to be provided in a message header, but > this is enabled all the way back to IVB when possible because it > decreases the instr

Re: [Mesa-dev] [PATCH] radeon/vcn: use enc profile instead of pic profile

2018-03-01 Thread Boyuan Zhang
Agree, I added the missing profile and entry_point to st/omx. Please see the attached patch below. On radeon driver side, do you think we should still check the profile in encoder instead since profile shouldn't been changed during encoding. Or we can just leave it with picture profile with this

Re: [Mesa-dev] [PATCH 3/6] intel/ir: Allow arbitrary scratch flag registers for SHADER_OPCODE_FIND_LIVE_CHANNEL.

2018-03-01 Thread Kenneth Graunke
On Tuesday, February 27, 2018 1:38:25 PM PST Francisco Jerez wrote: > This shouldn't cause any functional change at this point, it changes > SHADER_OPCODE_FIND_LIVE_CHANNEL to use the flag register specified at > the IR level instead of the hard-coded f1.0, now that it can be > represented in backe

Re: [Mesa-dev] [PATCH] gallium/util: use sockets on PIPE_OS_UNIX in u_network

2018-03-01 Thread Emil Velikov
On 28 February 2018 at 10:21, Jonathan Gray wrote: > Instead of listing all the UNIX PIPE_OS platforms just use > PIPE_OS_UNIX. Makes BSD sockets available on PIPE_OS_BSD. > > Signed-off-by: Jonathan Gray > --- > src/gallium/auxiliary/util/u_network.c | 9 +++-- > src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH v2] travis: make Meson find the proper llvm-config

2018-03-01 Thread Emil Velikov
On 1 March 2018 at 18:15, Dylan Baker wrote: > Quoting Emil Velikov (2018-03-01 09:27:44) >> On 1 March 2018 at 17:16, Dylan Baker wrote: >> > Quoting Emil Velikov (2018-02-28 16:01:56) >> >> On 28 February 2018 at 21:18, Andres Gomez wrote: >> >> > Travis CI has moved to LLVM 5.0, and meson is

Re: [Mesa-dev] [PATCH v2] travis: make Meson find the proper llvm-config

2018-03-01 Thread Dylan Baker
Quoting Emil Velikov (2018-03-01 09:27:44) > On 1 March 2018 at 17:16, Dylan Baker wrote: > > Quoting Emil Velikov (2018-02-28 16:01:56) > >> On 28 February 2018 at 21:18, Andres Gomez wrote: > >> > Travis CI has moved to LLVM 5.0, and meson is detecting automatically > >> > the available version

Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-03-01 Thread Brian Paul
Piglit fbo-drawbuffers2-blend -Brian On 03/01/2018 10:25 AM, Ilia Mirkin wrote: Ok. Is there a test that failed? I'll probably have to fix up nv50 for it. On Mar 1, 2018 11:43 AM, "Brian Paul" > wrote: On 02/28/2018 08:36 AM, Ilia Mirkin wrote: Can st/m

Re: [Mesa-dev] [PATCH v2] travis: make Meson find the proper llvm-config

2018-03-01 Thread Emil Velikov
On 1 March 2018 at 17:16, Dylan Baker wrote: > Quoting Emil Velikov (2018-02-28 16:01:56) >> On 28 February 2018 at 21:18, Andres Gomez wrote: >> > Travis CI has moved to LLVM 5.0, and meson is detecting automatically >> > the available version in /usr/local/bin based on the PATH env variable >>

Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-03-01 Thread Ilia Mirkin
Ok. Is there a test that failed? I'll probably have to fix up nv50 for it. On Mar 1, 2018 11:43 AM, "Brian Paul" wrote: > On 02/28/2018 08:36 AM, Ilia Mirkin wrote: > >> Can st/mesa instead be fixed to maintain the original API? Other >> drivers look in rt[0] in the non-independent_blend_enable

Re: [Mesa-dev] [PATCH v2] travis: make Meson find the proper llvm-config

2018-03-01 Thread Dylan Baker
Quoting Emil Velikov (2018-02-28 16:01:56) > On 28 February 2018 at 21:18, Andres Gomez wrote: > > Travis CI has moved to LLVM 5.0, and meson is detecting automatically > > the available version in /usr/local/bin based on the PATH env variable > > order preference. > > > > As for 0.44.x, Meson can

Re: [Mesa-dev] [PATCH 11/12] vbo: Remove vbo_save_vertex_list::buffer_offset.

2018-03-01 Thread Brian Paul
On 02/28/2018 12:10 AM, Mathias Fröhlich wrote: Hi Brian, On Wednesday, 28 February 2018 00:56:36 CET Brian Paul wrote: On 02/26/2018 11:12 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich The buffer_offset is used in aligned_vertex_buffer_offset. But now that most of these decisi

Re: [Mesa-dev] [PATCH] nir/search: Include 8 and 16-bit support in construct_value

2018-03-01 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand I think they make sense as two separate patches. I've updated my patch title to say that it's only for match_value and I'll push both once Jenkins is done with them. On Thu, Mar 1, 2018 at 9:06 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > --- >

Re: [Mesa-dev] [PATCH v3 5/6] tegra: Initial support

2018-03-01 Thread Dylan Baker
Quoting Thierry Reding (2018-03-01 05:54:53) > Tegra K1 and later use a GPU that can be driven by the Nouveau driver. > But the GPU is a pure render node and has no display engine, hence the > scanout needs to happen on the Tegra display hardware. The GPU and the > display engine each have a separa

Re: [Mesa-dev] [PATCH v3 5/6] tegra: Initial support

2018-03-01 Thread Dylan Baker
Quoting Thierry Reding (2018-03-01 05:54:53) > --- /dev/null > +++ b/src/gallium/winsys/tegra/drm/meson.build > @@ -0,0 +1,33 @@ > +# Copyright © 2018 NVIDIA CORPORATION > + > +# Permission is hereby granted, free of charge, to any person obtaining a > copy > +# of this software and associated doc

[Mesa-dev] [PATCH] nir/search: Include 8 and 16-bit support in construct_value

2018-03-01 Thread Jose Maria Casanova Crespo
--- src/compiler/nir/nir_search.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c index c7c52ae320d..28b36b2b863 100644 --- a/src/compiler/nir/nir_search.c +++ b/src/compiler/nir/nir_search.c @@ -525,6 +525,9 @@ con

Re: [Mesa-dev] [PATCH] nir/search: Support 8 and 16-bit constants

2018-03-01 Thread Chema Casanova
I've been checking the whole nir_search.c and there is another pending 16-bit support in construct_value function. I'm sending a patch so feel free to squash it to your if it makes sense. In any case this is. Reviewed-by: Jose Maria Casanova Crespo El 28/02/18 a las 22:18, Jason Ekstrand escrib

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-01 Thread Dylan Baker
Quoting Thierry Reding (2018-03-01 05:54:52) > From: Thierry Reding > > This adds support for framebuffer modifiers to Nouveau. This will be > used by the Tegra driver to share metadata about the format of buffers > (such as the tiling mode or compression). > > Changes in v2: > - remove unused p

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

2018-03-01 Thread Dylan Baker
Quoting sndir...@suse.de (2018-03-01 08:11:54) > From: Stefan Dirsch > > Patch by "Tomas Chvatal" with modifications > by "Michal Srb" to not break python 2. > > https://bugzilla.suse.com/show_bug.cgi?id=1082303 > > v2: > - no longer try to encode a unicode > - make use of 'from __future__ im

Re: [Mesa-dev] [PATCH v2] disk cache: Link with -latomic if necessary

2018-03-01 Thread Dylan Baker
Quoting Thierry Reding (2018-03-01 05:28:07) > From: Thierry Reding > > The disk cache implementation uses 64-bit atomic operations. For some > architectures, such as 32-bit ARM, GCC will not be able to translate > these operations into atomic, lock-free instructions and will instead > rely on th

Re: [Mesa-dev] [PATCH] svga: fix blending regression

2018-03-01 Thread Brian Paul
On 02/28/2018 08:36 AM, Ilia Mirkin wrote: Can st/mesa instead be fixed to maintain the original API? Other drivers look in rt[0] in the non-independent_blend_enable case. For example, freedreno and nouveau. If independent blend is not in use, then rt[0] will have all the blending info, as bef

[Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

2018-03-01 Thread sndirsch
From: Stefan Dirsch Patch by "Tomas Chvatal" with modifications by "Michal Srb" to not break python 2. https://bugzilla.suse.com/show_bug.cgi?id=1082303 v2: - no longer try to encode a unicode - make use of 'from __future__ import print_function', so semantics of print statements in python2

[Mesa-dev] [Bug 105296] Account request for Chema Casanova

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105296 Brian Paul changed: What|Removed |Added Component|Other |New Accounts Assignee|mesa-dev@l

Re: [Mesa-dev] [PATCH v2] clover/llvm: Drop support for LLVM < 3.9.

2018-03-01 Thread Jan Vesely
On Tue, 2018-02-20 at 18:17 +, Emil Velikov wrote: > On 28 October 2017 at 00:32, Francisco Jerez wrote: > > Vedran Miletić writes: > > > > > v2: remove/inline compat stuff > > > > > > Reviewed-by: Francisco Jerez > > > --- > > > .../state_trackers/clover/llvm/codegen/native.cpp | 8 +-

Re: [Mesa-dev] [PATCH 05/29] intel/isl: Add a helper for inverting swizzles

2018-03-01 Thread Pohjolainen, Topi
On Mon, Feb 26, 2018 at 08:42:42AM -0800, Jason Ekstrand wrote: > On Mon, Feb 26, 2018 at 6:19 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, Jan 26, 2018 at 05:59:34PM -0800, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl.c | 30 ++

Re: [Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-01 Thread Ilia Mirkin
On Thu, Mar 1, 2018 at 8:54 AM, Thierry Reding wrote: > From: Thierry Reding > > This adds support for framebuffer modifiers to Nouveau. This will be > used by the Tegra driver to share metadata about the format of buffers > (such as the tiling mode or compression). > > Changes in v2: > - remove

Re: [Mesa-dev] [PATCH] loader: Add support for platform and host1x busses

2018-03-01 Thread Eric Engestrom
On March 1, 2018 1:31:53 PM UTC, Thierry Reding wrote: > From: Thierry Reding > > ARM SoCs usually have their DRM/KMS devices on the platform bus, so > add > support for this bus in order to allow use of the DRI_PRIME > environment > variable with those devices. > > While at it, also support

[Mesa-dev] [PATCH v3 6/6] autotools: Add tegra to AM_DISTCHECK_CONFIGURE_FLAGS

2018-03-01 Thread Thierry Reding
From: Thierry Reding This allows the driver to be built on a make distcheck and makes sure that it properly builds when a distribution tarball is made. Suggested-by: Emil Velikov Signed-off-by: Thierry Reding --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Mesa-dev] [PATCH v3 4/6] nouveau: Add framebuffer modifier support

2018-03-01 Thread Thierry Reding
From: Thierry Reding This adds support for framebuffer modifiers to Nouveau. This will be used by the Tegra driver to share metadata about the format of buffers (such as the tiling mode or compression). Changes in v2: - remove unused parameters to nouveau_buffer_create() - move format modifier q

[Mesa-dev] [PATCH v3 3/6] nouveau/nvc0: Extract common tile mode macro

2018-03-01 Thread Thierry Reding
From: Thierry Reding Add a new macro that can be used to extract the tiling mode from a tile_mode value. This is will be used to determine the number of GOBs used in block linear mode. Acked-by: Emil Velikov Tested-by: Andre Heider Signed-off-by: Thierry Reding --- src/gallium/drivers/nouvea

[Mesa-dev] [PATCH v3 5/6] tegra: Initial support

2018-03-01 Thread Thierry Reding
Tegra K1 and later use a GPU that can be driven by the Nouveau driver. But the GPU is a pure render node and has no display engine, hence the scanout needs to happen on the Tegra display hardware. The GPU and the display engine each have a separate DRM device node exposed by the kernel. To make th

[Mesa-dev] [PATCH v3 0/6] NVIDIA Tegra support

2018-03-01 Thread Thierry Reding
From: Thierry Reding This series of patches implements initial support for Tegra. The first two patches import DRM UAPI from v4.16-rc1 that provides framebuffer modifiers that can be used to specify buffers shared between Nouveau and the Tegra DRM driver. Patches 3 and 4 add support for framebuf

[Mesa-dev] [PATCH v3 2/6] drm/tegra: Sanitize format modifiers

2018-03-01 Thread Thierry Reding
From: Thierry Reding The existing format modifier definitions were merged prematurely, and recent work has unveiled that the definitions are suboptimal in several ways: - The format specifiers, except for one, are not Tegra specific, but the names don't reflect that. - The number space i

[Mesa-dev] [PATCH v3 1/6] drm/fourcc: Fix fourcc_mod_code() definition

2018-03-01 Thread Thierry Reding
From: Thierry Reding Avoid a compiler warnings when the val parameter is an expression. This is based on commit 5843f4e02fbe86a59981e35adc6cabebee46fdc0 from Linux v4.16-rc1. Acked-by: Emil Velikov Tested-by: Andre Heider Signed-off-by: Thierry Reding --- include/drm-uapi/drm_fourcc.h | 2 +

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

2018-03-01 Thread Stefan Dirsch
On Wed, Feb 28, 2018 at 02:16:08PM +0100, Stefan Dirsch wrote: > On Wed, Feb 28, 2018 at 12:12:25PM +0100, Stefan Dirsch wrote: > > Patch by "Tomas Chvatal" with modifications > > by "Michal Srb" to not break python 2. > > > > https://bugzilla.suse.com/show_bug.cgi?id=1082303 > > > > v2: > > -

[Mesa-dev] [PATCH] loader: Add support for platform and host1x busses

2018-03-01 Thread Thierry Reding
From: Thierry Reding ARM SoCs usually have their DRM/KMS devices on the platform bus, so add support for this bus in order to allow use of the DRI_PRIME environment variable with those devices. While at it, also support the host1x bus, which is effectively the same but uses an additional layer i

[Mesa-dev] [PATCH v2] disk cache: Link with -latomic if necessary

2018-03-01 Thread Thierry Reding
From: Thierry Reding The disk cache implementation uses 64-bit atomic operations. For some architectures, such as 32-bit ARM, GCC will not be able to translate these operations into atomic, lock-free instructions and will instead rely on the external atomics library to provide these operations.

Re: [Mesa-dev] [PATCH] st/mesa: ensure that images don't try to reference non-existent levels

2018-03-01 Thread Ilia Mirkin
Yes, as I mentioned this makes some tests assert. They were passing before, but it was through luck since the actual images were never accessed. On Mar 1, 2018 04:04, "Timothy Arceri" wrote: > This causes the CTS tests to assert on radeonsi where they previously > passed. If that expected? > >

[Mesa-dev] [Bug 105105] Suffixless KHR_robustness functions aren't exposed in ES 3.2

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105105 --- Comment #4 from Tapani Pälli --- (In reply to Kenneth Graunke from comment #0) > The readnpixels test does: > >PFNGLREADNPIXELS pReadnPixels = > (PFNGLREADNPIXELS)context->getRenderContext(). > getProcAddress("glReadnPixels"); > > and

[Mesa-dev] [PATCH 4/4] ac/nir: only enable used channels when exporting parameters

2018-03-01 Thread Samuel Pitoiset
This allows us to generate, for example, "exp param0 v0, off, off, off" if only the first channel is needed. Not sure if this improves performance but it's worth trying. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 24 1 file changed, 20 insertio

[Mesa-dev] [PATCH 3/4] ac: update enabled channels mask when optimizing PARAM exports

2018-03-01 Thread Samuel Pitoiset
When the mask is not 0xf we need to update the number of enabled channels, otherwise the hardware won't emit the components that are combined. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a

[Mesa-dev] [PATCH 2/4] ac/nir: pass the number of enabled channels to si_llvm_init_export_args()

2018-03-01 Thread Samuel Pitoiset
Currently, it's always 0xf but an upcoming patch will reduce the number of channels for parameters export. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH 1/4] ac/shader: scan output usage mask for VS and TES

2018-03-01 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_shader_info.c | 18 ++ src/amd/common/ac_shader_info.h | 4 2 files changed, 22 insertions(+) diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c index 57d7edec76..98de963147 100644 --- a/src/am

[Mesa-dev] [Bug 72600] ES3 context returned when ES2 is requested

2018-03-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72600 Tapani Pälli changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-03-01 Thread Andres Gomez
On Thu, 2018-03-01 at 09:25 +, Eric Engestrom wrote: [...] > > Oh, my apologies, I didn't think about that! > Can you add that paragraph in the commit message so it's clearer? > (I know there was already a mention of that, but I had not understood it the > first time around) > > > > > You

Re: [Mesa-dev] [PATCH] radv: do not set pending_reset_query in BeginCommandBuffer()

2018-03-01 Thread Alex Smith
Reviewed-by: Alex Smith On 1 March 2018 at 09:53, Samuel Pitoiset wrote: > This is just useless for two reasons: > 1) flush_bits is not set accordingly, so nothing will be flushed >in BeginQuery(). > 2) we always flush caches in EndCommandBuffer(), so if a reset >is done in a previous c

[Mesa-dev] [PATCH] radv: do not set pending_reset_query in BeginCommandBuffer()

2018-03-01 Thread Samuel Pitoiset
This is just useless for two reasons: 1) flush_bits is not set accordingly, so nothing will be flushed in BeginQuery(). 2) we always flush caches in EndCommandBuffer(), so if a reset is done in a previous command buffer we are safe. Cc: Alex Smith Signed-off-by: Samuel Pitoiset --- src/am

Re: [Mesa-dev] [PATCH v3] radv: make sure to emit cache flushes before starting a query

2018-03-01 Thread Samuel Pitoiset
On 03/01/2018 10:21 AM, Alex Smith wrote: Hi Samuel, On 28 February 2018 at 20:47, Samuel Pitoiset > wrote: If the query pool has been previously resetted using the compute shader path. v3: set pending_reset_query only for the compute shader pat

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-03-01 Thread Eric Engestrom
On February 28, 2018 8:30:14 PM UTC, Andres Gomez wrote: > On Wed, 2018-02-28 at 17:12 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > > > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > > > On Wednesday, 2018-02-28 17:52:05 +0

Re: [Mesa-dev] [PATCH v3] radv: make sure to emit cache flushes before starting a query

2018-03-01 Thread Alex Smith
Hi Samuel, On 28 February 2018 at 20:47, Samuel Pitoiset wrote: > If the query pool has been previously resetted using the compute > shader path. > > v3: set pending_reset_query only for the compute shader path > v2: handle multiple commands buffers with same pool > > Fixes: a41e2e9cf5 ("radv: a

[Mesa-dev] [PATCH] ac: fix nir_intrinsic_shared_atomic_comp_swap handling

2018-03-01 Thread Timothy Arceri
Following on from 49879f377870 this makes sure we use the correct src index. Fixes cts test: KHR-GL46.compute_shader.atomic-case3 --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm

Re: [Mesa-dev] [PATCH v2 2/9] intel/blorp: Add indirect clear color support to mcs_partial_resolve

2018-03-01 Thread Pohjolainen, Topi
On Mon, Feb 26, 2018 at 07:15:13AM -0800, Jason Ekstrand wrote: > On February 26, 2018 05:33:15 "Pohjolainen, Topi" > wrote: > > >On Fri, Feb 23, 2018 at 10:22:57PM -0800, Jason Ekstrand wrote: > >>This is a bit complicated because we have to get the indirect clear > >>color in there somehow. In

Re: [Mesa-dev] [PATCH 05/13] nir: expose 'C' wrappers for std430 size/alignment

2018-03-01 Thread Karol Herbst
On Wed, Feb 28, 2018 at 10:59 PM, Rob Clark wrote: > hmm, I haven't tried passing a struct (rather than a pointer to a > struct) as a parameter, but if there were 8/16 bit fields in the > struct it would calculate the size incorrectly. > > (otoh the more important question is whether this agrees w

  1   2   >