Re: [Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

2017-12-30 Thread Jason Ekstrand
On Sat, Dec 30, 2017 at 3:57 PM, Grazvydas Ignotas wrote: > Hi, > > I don't know if it's the game's fault, but it appears this change broke > DOOM. > here is the offending spirv binary: > https://people.freedesktop.org/~notaz/doom_compute_spirv > Have you filed a bug? Please do and assign it to

Re: [Mesa-dev] [PATCH 3/8] spirv: Add basic type validation for OpLoad, OpStore, and OpCopyMemory

2017-12-30 Thread Grazvydas Ignotas
Hi, I don't know if it's the game's fault, but it appears this change broke DOOM. here is the offending spirv binary: https://people.freedesktop.org/~notaz/doom_compute_spirv GraÅžvydas On Thu, Dec 7, 2017 at 6:12 PM, Jason Ekstrand wrote: > --- > src/compiler/spirv/vtn_variables.c | 18 ++

[Mesa-dev] [PATCH] radv: Use the alternative workaround for GFX9 scissor issues.

2017-12-30 Thread Bas Nieuwenhuizen
I don't like having to fush, so this introduces the other workaround. Since my experience is that context register writes are pretty cheap, this should not have too much overhead. I haven't seen any significant perf changes in benchmarks or games though. --- src/amd/vulkan/radv_cmd_buffer.c | 22

[Mesa-dev] [PATCH 2/2] radv: Implement binning on GFX9.

2017-12-30 Thread Bas Nieuwenhuizen
Overall it does not really help or hurt. The deferred demo gets 1% improvement and some games a 3% decrease, so I don't think this should be enabled by default. But with the code upstream it is easier to experiment with it. --- src/amd/vulkan/radv_cmd_buffer.c | 16 ++ src/amd/vulkan/radv_pipeli

[Mesa-dev] [PATCH 1/2] radv: Add flag for enabling binning.

2017-12-30 Thread Bas Nieuwenhuizen
Letting it be disabled by default. --- src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c | 8 2 files changed, 9 insertions(+) diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h index af07564833e..5b37bfe0847 100644 --- a/src/amd/vulkan/radv_debug.h +++

Re: [Mesa-dev] [PATCH] i965: Combine {VS, FS}_OPCODE_GET_BUFFER_SIZE opcodes.

2017-12-30 Thread Jason Ekstrand
Rb On December 29, 2017 23:39:21 Kenneth Graunke wrote: These are the same, we don't need a separate opcode enum per backend. --- src/intel/compiler/brw_eu_defines.h | 5 ++--- src/intel/compiler/brw_fs.cpp | 2 +- src/intel/compiler/brw_fs_generator.cpp | 2 +- src/intel

Re: [Mesa-dev] [PATCH] i965: Combine {VS, FS}_OPCODE_GET_BUFFER_SIZE opcodes.

2017-12-30 Thread Jason Ekstrand
Rb On December 29, 2017 23:39:21 Kenneth Graunke wrote: These are the same, we don't need a separate opcode enum per backend. --- src/intel/compiler/brw_eu_defines.h | 5 ++--- src/intel/compiler/brw_fs.cpp | 2 +- src/intel/compiler/brw_fs_generator.cpp | 2 +- src/intel