Re: [Mesa-dev] [PATCH 1/4] intel/aubinator: Allow for the case where the ascii85 decode fails

2017-12-27 Thread Kenneth Graunke
On Wednesday, December 27, 2017 3:13:42 PM PST Jason Ekstrand wrote: > On December 27, 2017 17:06:43 Kenneth Graunke wrote: > > > On Wednesday, December 27, 2017 12:58:12 PM PST Jason Ekstrand wrote: > >> --- > >> src/intel/tools/aubinator_error_decode.c | 6 -- > >> 1 file changed, 4 insert

[Mesa-dev] [PATCH] radv: fix pipeline statistics end query on compute queue

2017-12-27 Thread Dave Airlie
From: Dave Airlie It's legal to a pipeline stat query on a compute queue, but we'd emit the wrong packet here. This should fix it to emit the correct packet. Noticed while inspecting the mpv hang. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_query.c | 2 +- 1 file changed, 1 insertion(+

[Mesa-dev] [PATCH] radv: fix events on compute queues.

2017-12-27 Thread Dave Airlie
From: Dave Airlie The event emission wasn't sending the correct packet for gfx8 compute queues, which explains why it works on vega fine. This fixes the mpv vulkan hang. Fixes: ad61eac250 (radv: factor out eop event writing code. (v2)) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_b

[Mesa-dev] [PATCH] radv: move local bos usage to a perftest flag.

2017-12-27 Thread Dave Airlie
From: Dave Airlie These seem mildly unstable on vega, crashing CTS in various fun ways, and looks like leaking memory. Disable for now, but leave the option to enable them. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH] [rfc] radv: choose 32-bit abgr export for f16 formats.

2017-12-27 Thread Dave Airlie
From: Dave Airlie This fixes: dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat I've no idea if it's correct though. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file

Re: [Mesa-dev] [PATCH 2/2] r600: fix textureSize queries with tbos

2017-12-27 Thread Alex Deucher
On Wed, Dec 27, 2017 at 7:51 PM, Dave Airlie wrote: > On 23 December 2017 at 17:19, wrote: >> From: Roland Scheidegger >> >> piglit doesn't care, but I'm quite confident that the size actually bound >> as range should be reported and not the base size of the resource. >> Also, the array in the

Re: [Mesa-dev] [PATCH 2/2] r600: fix textureSize queries with tbos

2017-12-27 Thread Dave Airlie
On 23 December 2017 at 17:19, wrote: > From: Roland Scheidegger > > piglit doesn't care, but I'm quite confident that the size actually bound > as range should be reported and not the base size of the resource. > Also, the array in the constant buffer looks overallocated by a factor of 4. > For

Re: [Mesa-dev] [PATCH] vulkan/wsi: free cmd pools

2017-12-27 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Dec 28, 2017 at 12:47 AM, Dave Airlie wrote: > From: Dave Airlie > > We destroy the pools but don't free the container. > > This fixes: > dEQP-VK.wsi.xlib.swapchain.simulate_oom* > > Fixes: d50937f137 (vulkan/wsi: Implement prime in a completely generic wa

[Mesa-dev] [PATCH] vulkan/wsi: free cmd pools

2017-12-27 Thread Dave Airlie
From: Dave Airlie We destroy the pools but don't free the container. This fixes: dEQP-VK.wsi.xlib.swapchain.simulate_oom* Fixes: d50937f137 (vulkan/wsi: Implement prime in a completely generic way) Signed-off-by: Dave Airlie --- src/vulkan/wsi/wsi_common.c | 1 + 1 file changed, 1 insertion(+

Re: [Mesa-dev] [PATCH] radv: Use correct frambuffer size for partial FS resolves.

2017-12-27 Thread Dave Airlie
> Framebuffer is from 0,0, not (dst.x, dst.y). > > Fixes: 69136f4e633 "radv/meta: add resolve pass using fragment/vertex shaders" Reviewed-by: Dave Airlie Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mail

[Mesa-dev] [PATCH] radv: Use correct frambuffer size for partial FS resolves.

2017-12-27 Thread Bas Nieuwenhuizen
Framebuffer is from 0,0, not (dst.x, dst.y). Fixes: 69136f4e633 "radv/meta: add resolve pass using fragment/vertex shaders" --- src/amd/vulkan/radv_meta_resolve_fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c b/src/amd/vulkan/rad

Re: [Mesa-dev] [PATCH 1/4] intel/aubinator: Allow for the case where the ascii85 decode fails

2017-12-27 Thread Jason Ekstrand
On December 27, 2017 17:06:43 Kenneth Graunke wrote: On Wednesday, December 27, 2017 12:58:12 PM PST Jason Ekstrand wrote: --- src/intel/tools/aubinator_error_decode.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/int

Re: [Mesa-dev] [PATCH 1/4] intel/aubinator: Allow for the case where the ascii85 decode fails

2017-12-27 Thread Kenneth Graunke
On Wednesday, December 27, 2017 12:58:12 PM PST Jason Ekstrand wrote: > --- > src/intel/tools/aubinator_error_decode.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/intel/tools/aubinator_error_decode.c > b/src/intel/tools/aubinator_error_decode.c > index d6fb

Re: [Mesa-dev] [PATCH] st/mesa: increase size of glsl_base_type bitfields

2017-12-27 Thread Neha Bhende
Looks good. Reviewed-by : Neha Bhende Regards, Neha From: Brian Paul Sent: Wednesday, December 27, 2017 12:38:53 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] st/mesa: increase size of glsl_base_type bitfields Change 5

Re: [Mesa-dev] [PATCH 2/2] radeonsi: don't do cmask fast clears on gfx9 single sample

2017-12-27 Thread Marek Olšák
CMASK fast clears work on gfx9 just fine. I can't accept this patch. Marek On Wed, Dec 27, 2017 at 1:44 AM, Dave Airlie wrote: > From: Dave Airlie > > AMDVLK says that these don't work, so disable them. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/radeonsi/si_clear.c | 6 +-

[Mesa-dev] [PATCH 4/4] anv/device: Mark all state buffers as needing capture

2017-12-27 Thread Jason Ekstrand
Previously, we were flagging the instruction state buffer for capture but not surface state or dynamic state. We want those captured too. --- src/intel/vulkan/anv_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/an

[Mesa-dev] [PATCH 3/4] intel/aubinator: Gracefully handle dynamic state not being available

2017-12-27 Thread Jason Ekstrand
Some older versions of the Vulkan driver didn't properly tag dynamic state as needing to be captured. Also, this prevents crashes when looking at dumps on older kernels. --- src/intel/tools/gen_batch_decoder.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/tools/gen_batch_deco

[Mesa-dev] [PATCH 2/4] intel/aubinator: Free section data last

2017-12-27 Thread Jason Ekstrand
We were walking the sections, printing the batches, and then freeing them in one pass. If the batch happens to reference any earlier sections (which it almost certainly will since it's at the end), we will access freed memory. --- src/intel/tools/aubinator_error_decode.c | 6 -- 1 file change

[Mesa-dev] [PATCH 1/4] intel/aubinator: Allow for the case where the ascii85 decode fails

2017-12-27 Thread Jason Ekstrand
--- src/intel/tools/aubinator_error_decode.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index d6fbfe0..f0c5b5b 100644 --- a/src/intel/tools/aubinator_error_decode.c +++ b/src/intel/t

[Mesa-dev] [PATCH] st/mesa: increase size of glsl_base_type bitfields

2017-12-27 Thread Brian Paul
Change 59f458cd8703b97b31b8 added more enums to glsl_base_type. We have to bump up the size of the bitfields for fields of this type for MSVC. Also, add another assertion to catch another place where this enum bitfield is used. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + src/mesa

[Mesa-dev] [Bug 104196] XOrg fails to start due to Mesa DRI crash with NULL pointer, also glmark2 fails with NULL pointer

2017-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104196 Luis Mendes changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] svga: move variant->fs_shadow_compare_units assignment

2017-12-27 Thread Brian Paul
Fixes a crash since the variant object isn't allocated until later in the function. Not sure how this got through. --- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/dri

Re: [Mesa-dev] [PATCH] radv/gfx9: use correct stencil format for tc compat htile.

2017-12-27 Thread Samuel Pitoiset
On 12/27/2017 02:24 AM, Dave Airlie wrote: From: Dave Airlie This needs to correspond to the bit depth of the Z plane. noticed in passing reading amdvlk. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [Bug 102891] [radv] glitches on rpcs3 emulator (green zones)

2017-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102891 alex.vl...@gmail.com changed: What|Removed |Added CC||alex.vl...@gmail.com -- You are

Re: [Mesa-dev] [PATCH mesa 3/3] egl: don't try the software path twice

2017-12-27 Thread Eric Engestrom
On Wednesday, 2017-12-27 11:14:24 +, Emil Velikov wrote: > For the series: > > Reviewed-by: Emil Velikov > > Modulo any objections, I'll push it later on today. Thanks; can you also add to 1/3 and 3/3: Reported-by: Brendan King Cheers ___ mesa-d

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-27 Thread Eric Engestrom
On Wednesday, 2017-12-27 10:54:56 +, Emil Velikov wrote: > On 18 December 2017 at 16:33, Eric Engestrom > wrote: > > From: Brendan King > > > > DRI modules store the address of the dispatch table in a TLS variable, > > _glapi_tls_Dispatch. > > > > Changes to the way libEGL is built in d884d8

Re: [Mesa-dev] [PATCH 4/5] radv: Fix fragment resolve destination offset.

2017-12-27 Thread Bas Nieuwenhuizen
On Wed, Dec 27, 2017 at 5:25 AM, Dieter Nützel wrote: > Am 27.12.2017 01:20, schrieb Bas Nieuwenhuizen: >> >> The position start at (dst.x, dst.y), so if we want the source to >> start at (src.x, src.y), we have to offset by (src.x-dst.x,src.y-dst.y). >> >> Haven't tested that this fixed anything

Re: [Mesa-dev] [PATCH] radv: don't do format replacement on tc compat htile surfaces.

2017-12-27 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Dec 27, 2017 at 8:04 AM, Dave Airlie wrote: > From: Dave Airlie > > For copies the texture unit needs to know the depth format so > it can read the htile data properly. > > This fixes: > dEQP-VK.renderpass.suballocation.formats.d32_sfloat_s8_uint.load.clea

Re: [Mesa-dev] [PATCH] radv/gfx9: use correct stencil format for tc compat htile.

2017-12-27 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Dec 27, 2017 at 2:24 AM, Dave Airlie wrote: > From: Dave Airlie > > This needs to correspond to the bit depth of the Z plane. > > noticed in passing reading amdvlk. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_image.c | 9 ++--- > 1 fil

Re: [Mesa-dev] [PATCH mesa 3/3] egl: don't try the software path twice

2017-12-27 Thread Emil Velikov
For the series: Reviewed-by: Emil Velikov Modulo any objections, I'll push it later on today. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-27 Thread Emil Velikov
On 18 December 2017 at 16:33, Eric Engestrom wrote: > From: Brendan King > > DRI modules store the address of the dispatch table in a TLS variable, > _glapi_tls_Dispatch. > > Changes to the way libEGL is built in d884d8d0077c16d459b1 resulted in > it being statically linked against libglapi, and

[Mesa-dev] [Bug 103945] FireFox Error Abort with flash objects

2017-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103945 Tapani Pälli changed: What|Removed |Added Status|NEW |NEEDINFO -- You are receiving this mail