[Mesa-dev] [PATCH 11/11] spirv: Rework asserts in var_decoration_cb

Now that higher levels are enforcing decoration sanity, we don't need the vtn_asserts here. This function *should* be safe but we still want a few well-placed regular asserts in case something goes awry. --- src/compiler/spirv/vtn_variables.c | 15 --- 1 file changed, 8 insertions(+),

[Mesa-dev] [PATCH 10/11] spirv: Rework error checking for decorations

This reworks the error checking on our generic handling of decorations. The objective is to validate all of the SPIR-V assumptions we make up-front and convert redundant checks to compiled-out asserts. The most important part of this is to ensure that member decorations only occur on OpTypeStruct

[Mesa-dev] [PATCH 08/11] spirv: Switch on vtn_base_type in OpComposite(Extract|Insert)

This is a bit simpler since we have fewer enum values in the case. It's also a bit more efficient because we're making fewer glsl_get_* calls. While we're at it, add better type validation. --- src/compiler/spirv/spirv_to_nir.c | 69 ++- 1 file changed, 32 inse

[Mesa-dev] [PATCH 07/11] spirv: Refactor Op[Spec]ConstantComposite and add better validation

Now that vtn_base_type is a real and full base type, we can switch on that instead of the GLSL base type which is a lot fewer cases in our switch. --- src/compiler/spirv/spirv_to_nir.c | 68 ++- 1 file changed, 32 insertions(+), 36 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 09/11] spirv: Add better type validation to OpTypeImage

--- src/compiler/spirv/spirv_to_nir.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 83c75c7..ffea442 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_t

[Mesa-dev] [PATCH 01/11] spirv: Add better error messages in vtn_value helpers

--- src/compiler/spirv/vtn_private.h | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/compiler/spirv/vtn_private.h b/src/compiler/spirv/vtn_private.h index 7cb69d7..f7d8f49 100644 --- a/src/compiler/spirv/vtn_private.h +++ b/src/compiler/spirv/vt

[Mesa-dev] [PATCH 04/11] spirv: Unify boolean constants and add better validation

--- src/compiler/spirv/spirv_to_nir.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 0493dd3..9a67690 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/sp

[Mesa-dev] [PATCH 06/11] spirv: Add better validation to Op[Spec]Constant

--- src/compiler/spirv/spirv_to_nir.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 208ec95..d65c0d0 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -

[Mesa-dev] [PATCH 05/11] spirv: Remove a pointless assignment in SpvOpSpecConstant

We re-assign later inside the bit_size switch --- src/compiler/spirv/spirv_to_nir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 9a67690..208ec95 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spi

[Mesa-dev] [PATCH 02/11] spirv: Make 'info' a local array spirv_info_c.py

--- src/compiler/spirv/spirv_info_c.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/spirv_info_c.py b/src/compiler/spirv/spirv_info_c.py index d898bf0..4a6a815 100644 --- a/src/compiler/spirv/spirv_info_c.py +++ b/src/compiler/spirv/spirv_info_c.p

[Mesa-dev] [PATCH 00/11] SPIR-V More error checking/validation improvements

This series is another 11 patches in the direction of improving SPIR-V error messages and validation. The purpose here isn't really to validate the SPIR-V (I'm sure there will be many things we won't error on) but to make it such that the assumptions we do make about the incoming SPIR-V and requir

[Mesa-dev] [PATCH 03/11] spirv/info: Add spirv_op_to_string

--- src/compiler/spirv/spirv_info.h| 1 + src/compiler/spirv/spirv_info_c.py | 10 ++ 2 files changed, 11 insertions(+) diff --git a/src/compiler/spirv/spirv_info.h b/src/compiler/spirv/spirv_info.h index 81d43ec..121ffd2 100644 --- a/src/compiler/spirv/spirv_info.h +++ b/src/compile

Re: [Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

On 17/12/17 09:07, Erik Faye-Lund wrote: On Thu, Dec 14, 2017 at 6:02 AM, Timothy Arceri wrote: Fixes 56 crashes in radeonsi. 56 crashes with what? Piglit? Yes fixes 56 piglit crashes ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https

[Mesa-dev] [PATCH 3/6] amd/common: Add detection of the syncobj wait/signal/reset ioctls.

First amdgpu bump after inclusion was 20 (which was done for local BOs). --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 0576dd369cf..c042bb229ce 100644 ---

[Mesa-dev] [PATCH 6/6] radv: Add external fence support.

--- src/amd/vulkan/radv_device.c | 20 src/amd/vulkan/radv_extensions.py | 2 ++ 2 files changed, 22 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 94562fda875..a4ec912ff2c 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src

[Mesa-dev] [PATCH 1/6] configure/meson: Bump libdrm_amdgpu version requirement.

For the radv dependencies on syncobj signal/reset. --- configure.ac | 2 +- meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index a4564d23f4c..138459c6f79 100644 --- a/configure.ac +++ b/configure.ac @@ -74,7 +74,7 @@ AC_SUBST([OPENCL

[Mesa-dev] [PATCH 4/6] radv: Implement fences based on syncobjs.

--- src/amd/vulkan/radv_device.c | 113 -- src/amd/vulkan/radv_private.h | 6 ++- src/amd/vulkan/radv_wsi.c | 5 ++ 3 files changed, 109 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 7

[Mesa-dev] [PATCH 2/6] radv: Add syncobj signal/reset/wait to winsys.

--- src/amd/vulkan/radv_radeon_winsys.h | 4 +++ src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 40 +++ 2 files changed, 44 insertions(+) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h index 2b815d9c5a9..e851c3edf86 1006

[Mesa-dev] [PATCH 5/6] radv: Implement VK_KHR_external_fence_fd.

--- src/amd/vulkan/radv_device.c | 47 +++ src/amd/vulkan/radv_extensions.py | 1 + 2 files changed, 48 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index fc9fb59f991..94562fda875 100644 --- a/src/amd/vulkan/radv_

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: Disable regular fast-clears (CCS_D) on gen9+"

On December 16, 2017 14:35:29 Nanley Chery wrote: On Wed, Dec 13, 2017 at 05:52:03PM -0800, Jason Ekstrand wrote: This reverts commit ee57b15ec764736e2d5360beaef9fb2045ed0f68. Cc: "17.3" --- src/mesa/drivers/dri/i965/brw_meta_util.c | 10 - src/mesa/drivers/dri/i965/intel_mipmap_tre

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: Disable regular fast-clears (CCS_D) on gen9+"

On Wed, Dec 13, 2017 at 05:52:03PM -0800, Jason Ekstrand wrote: > This reverts commit ee57b15ec764736e2d5360beaef9fb2045ed0f68. > > Cc: "17.3" > --- > src/mesa/drivers/dri/i965/brw_meta_util.c | 10 - > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 57 > --- >

Re: [Mesa-dev] [PATCH] st/st_glsl_to_nir: call nir_lower_64bit_pack

On Thu, Dec 14, 2017 at 6:02 AM, Timothy Arceri wrote: > Fixes 56 crashes in radeonsi. 56 crashes with what? Piglit? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Remove unused variable.

Rb On December 16, 2017 13:03:41 Bas Nieuwenhuizen wrote: --- src/intel/vulkan/anv_device.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 59767c2..4638f311dd1 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src

[Mesa-dev] [PATCH] anv: Remove unused variable.

--- src/intel/vulkan/anv_device.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 59767c2..4638f311dd1 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -741,8 +741,6 @@ void anv_GetPhysica

[Mesa-dev] [Bug 104290] Multisampling gives corrupt rendering

https://bugs.freedesktop.org/show_bug.cgi?id=104290 --- Comment #1 from mais...@archlinux.us --- ./samples/rotating_texture/rotating_texture is basically the exact same thing, but does not have this issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are the as

[Mesa-dev] [Bug 104290] Multisampling gives corrupt rendering

https://bugs.freedesktop.org/show_bug.cgi?id=104290 Bug ID: 104290 Summary: Multisampling gives corrupt rendering Product: Mesa Version: 17.3 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v2 0/3] nouveau compiler warning cleanups

Couple of little compiler warning cleanups so that nouveau builds without any warnings for meson's debug and release builds with gcc 7.2.0 v2: Add preventative comment (Ilia Mirkin) Rhys Kidd (3): nv50: Fix unused var warning in release build nvc0: Fix unused var warnings in release build n

[Mesa-dev] [PATCH v2 2/3] nvc0: Fix unused var warnings in release build

Signed-off-by: Rhys Kidd --- src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_video.c b/src/gallium/drivers/nouveau/nvc0/nvc0_video.c index b5e7bba5f9..5c1cf899ca 100644 --- a/src/galliu

[Mesa-dev] [PATCH v2 3/3] nv50/ir: Fix unused var warnings in release build

v2: Add preventative comment (Ilia Mirkin) Reviewed-by: Eric Engestrom Signed-off-by: Rhys Kidd --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 +- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 1/3] nv50: Fix unused var warning in release build

Signed-off-by: Rhys Kidd --- src/gallium/drivers/nouveau/nv50/nv98_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv98_video.c b/src/gallium/drivers/nouveau/nv50/nv98_video.c index 92526d9f64..da0267e646 100644 --- a/src/gallium/dri