Re: [Mesa-dev] [PATCH 0/4] enable GL_EXT_disjoint_timer_query

2017-12-03 Thread Tapani Pälli
ping! On 11/20/2017 09:18 AM, Tapani Pälli wrote: This series enables mostly existing functionality but adds the disjoint state required by this extension. WebGL tests seem to utilize desktop extension GL_EXT_timer_query but I wrote a separate simple Piglit test for this. Tapani Pälli (4): m

[Mesa-dev] [PATCH] radeonsi: pass llvm type directly to buffer_load()

2017-12-03 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index a94c2af8709..6a1293b99d1 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH 1/6] anv/pipeline: Translate vulkan_resource_index to a constant when possible

2017-12-03 Thread Jason Ekstrand
On Sat, Dec 2, 2017 at 11:09 PM, Jordan Justen wrote: > On 2017-12-01 17:20:04, Jason Ekstrand wrote: > > We want to call brw_nir_analyze_ubo_ranges immedately after > > anv_nir_apply_pipeline_layout and it badly wants constants. We could > > run an optimization step and let constant folding do

[Mesa-dev] [PATCH 1/2] i965/fs: Rewrite assign_constant_locations

2017-12-03 Thread Jason Ekstrand
This rewires the logic for assigning uniform locations to work in terms of "complex alignments". The basic idea is that, as we walk the list of instructions, we keep track of the alignment and continuity requirements of each slot and assert that the alignments all match up. We then use those alig

[Mesa-dev] [PATCH 2/2] i965/fs: Handle !supports_pull_constants and push UBOs properly

2017-12-03 Thread Jason Ekstrand
In Vulkan, we don't support classic pull constants and everything the client asks us to push, we push. However, for pushed UBOs, we still want to fall back to conventional pulls if we run out of space. --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Mesa-dev] [PATCH v3 22/25] mesa/glspirv: Create gl_linked_shader objects for a SPIR-V program

2017-12-03 Thread Timothy Arceri
On 01/12/17 18:15, Eduardo Lima Mitev wrote: v2: Bail out if we see more that one shader for the same stage, and add a corresponding comment. (Timothy Arceri) --- src/mesa/main/glspirv.c | 61 ++--- 1 file changed, 58 insertions(+), 3 deletions

Re: [Mesa-dev] [PATCH v2 24/25] i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders

2017-12-03 Thread Timothy Arceri
On 01/12/17 18:23, Eduardo Lima Mitev wrote: On 12/01/2017 04:44 AM, Timothy Arceri wrote: On 01/12/17 04:28, Eduardo Lima Mitev wrote: This is the main fork of the shader compilation code-path, where a NIR shader is obtained by calling spirv_to_nir() or glsl_to_nir(), depending on its nature

Re: [Mesa-dev] [PATCH 2/2] r600/atomic: add cayman version of atomic save/restore from GDS

2017-12-03 Thread Dave Airlie
On 1 December 2017 at 20:49, Nicolai Hähnle wrote: > On 01.12.2017 06:06, Dave Airlie wrote: >> >> From: Dave Airlie >> >> On Cayman we don't use the append/consume counters (fglrx doesn't) >> and they don't seem to work well with compute shaders. >> >> This just uses GDS instead to do the atomic

Re: [Mesa-dev] [PATCH 2/2] nvir/nvc0: Properly lower 64-bit SHL/SHR when the shift is an imm

2017-12-03 Thread Pierre Moreau
On 2017-12-03 — 15:36, Ilia Mirkin wrote: > On Sun, Dec 3, 2017 at 3:28 PM, Pierre Moreau wrote: > > The existing lowering code assumed the shift would not be an immediate > > but did not guard against it. However, in the constant folding pass, a > > multiplication by a power-of-2 immediate would

Re: [Mesa-dev] [PATCH 1/2] nvir/nvc0: Properly lower 64-bit shifts when the shift value is >32

2017-12-03 Thread Ilia Mirkin
Yeah, this also matches the comments above which explain what it's doing... src[0] == LO, src[1] == HI. Reviewed-by: Ilia Mirkin On Sun, Dec 3, 2017 at 3:28 PM, Pierre Moreau wrote: > Fixes: 61d7676df77 "nvc0/ir: add support for 64-bit shift lowering on > SM20/SM30" > > Fixes fs-shift-scalar-b

Re: [Mesa-dev] [PATCH 2/2] nvir/nvc0: Properly lower 64-bit SHL/SHR when the shift is an imm

2017-12-03 Thread Ilia Mirkin
On Sun, Dec 3, 2017 at 3:28 PM, Pierre Moreau wrote: > The existing lowering code assumed the shift would not be an immediate > but did not guard against it. However, in the constant folding pass, a > multiplication by a power-of-2 immediate would get optimised into a > shift-left instruction, wit

[Mesa-dev] [PATCH 2/2] nvir/nvc0: Properly lower 64-bit SHL/SHR when the shift is an imm

2017-12-03 Thread Pierre Moreau
The existing lowering code assumed the shift would not be an immediate but did not guard against it. However, in the constant folding pass, a multiplication by a power-of-2 immediate would get optimised into a shift-left instruction, with the shift value being an immediate. Signed-off-by: Pierre M

[Mesa-dev] [PATCH 1/2] nvir/nvc0: Properly lower 64-bit shifts when the shift value is >32

2017-12-03 Thread Pierre Moreau
Fixes: 61d7676df77 "nvc0/ir: add support for 64-bit shift lowering on SM20/SM30" Fixes fs-shift-scalar-by-scalar.shader_test from piglit for the current set-up: uniform int64_t ival -0x7dfcfefbdf6536ff # bit pattern: 0x82030104209ac901 uniform uint64_t uval 0x140085010203 uniform int shl 36 u

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

2017-12-03 Thread Gurkirpal Singh
I sent the modified patches in another thread a while ago. Please review in case got missed. On Thu, Nov 30, 2017 at 7:35 PM, Leo Liu wrote: > > > On 11/30/2017 06:22 AM, Julien Isorce wrote: > > Hi Gurkirpal, > > > Before refactoring process both the state trackers were in independent > directo

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock on Wayland compositor with X11

2017-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103538 Bas Nieuwenhuizen changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. | |org

[Mesa-dev] [Bug 103579] Vertex shader causes compiler to crash in SPIRV-to-NIR

2017-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103579 Bas Nieuwenhuizen changed: What|Removed |Added CC||airl...@freedesktop.org,

[Mesa-dev] [PATCH] spirv: Fix loading an entire block at once.

2017-12-03 Thread Bas Nieuwenhuizen
There is no chain, so checking the length ends with a SEGFAULT. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103579 Cc: --- src/compiler/spirv/vtn_variables.c | 58 -- 1 file changed, 30 insertions(+), 28 deletions(-) diff --git a/src/compiler/spir

[Mesa-dev] [Bug 101560] SPIR-V OpSwitch with int64 not supported even though shaderInt64 is true

2017-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101560 Bas Nieuwenhuizen changed: What|Removed |Added Component|Drivers/Vulkan/radeon |Drivers/Vulkan/Common

[Mesa-dev] [Bug 100316] Linking GLSL 1.30 shaders with invariant and deprecated variables triggers an 'mismatching invariant qualifiers' error

2017-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100316 Rémi Verschelde changed: What|Removed |Added Version|17.0|17.2 --- Comment #2 from Rémi Versche

[Mesa-dev] [Bug 104038] mesa: Need a new Bugzilla component Drivers/Vulkan/Common

2017-12-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104038 Daniel Stone changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. | |org