Reviewed-by: Jordan Justen
On 2017-12-01 17:20:05, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 45
> --
> 1 file changed, 34 insertions(+), 11 deletions(-)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_
On 2017-12-01 17:20:04, Jason Ekstrand wrote:
> We want to call brw_nir_analyze_ubo_ranges immedately after
> anv_nir_apply_pipeline_layout and it badly wants constants. We could
> run an optimization step and let constant folding do it but that's way
> more expensive than needed. It's really eas
Both in setup and arithmetic instructions. Also, remove the useless
new_*_inst() functions, and refactor check_arith_arg(), because it did
two completely different things.
Piglit: spec/ati_fragment_shader/error04-endshader
Signed-off-by: Miklós Máté
---
src/mesa/main/atifragshader.c | 107 +
Signed-off-by: Miklós Máté
---
src/mesa/main/atifragshader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c
index 8538e3a53e..6b636f1dc7 100644
--- a/src/mesa/main/atifragshader.c
+++ b/src/mesa/main/atifrags
Signed-off-by: Miklós Máté
---
src/mesa/main/mtypes.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 0e8a05359a..8c8151c496 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -2390,10 +2390,14 @@ struct ati_fragment_s
These are fixes for the problems my Piglit tests uncovered so far.
After this series all gallium drivers (I could only test softpipe,
llvmpipe and radeonsi) and swrast should pass all tests.
Unfortunately I can't test on r200.
Miklós Máté (9):
mesa: add fallback texture for SampleMapATI if there
This fixes crash when:
- first pass begins with alpha inst
- first pass ends with color inst, second pass begins with alpha inst
Also, use the symbolic name instead of a number.
Piglit: spec/ati_fragment_shader/api-alphafirst
v2: fixed formatting
Signed-off-by: Miklós Máté
---
src/mesa/main/at
ATI_fs in swrast only had secondary color if GL_COLOR_SUM was enabled.
This patch probably fixes the same issue in r200.
Piglit: spec/ati_fragment_shader/render-sources and render-precedence
Signed-off-by: Miklós Máté
---
src/mesa/main/state.h | 17 ++---
1 file changed, 10 insertio
This patch fixes multiple problems:
- the interpolator check was duplicated
- both had arg instead of argRep
- I split it into color and alpha for better readability and error msg
- the DOT4 check only applies to color instruction according to the spec
- made the DOT4 check fatal, and improved the
This fixes crash in the state tracker.
Piglit: spec/ati_fragment_shader/render-notexture
v2: fixed formatting, moved stuff inside the loop,
moved the fallback later to fix more cases
Signed-off-by: Miklós Máté
---
src/mesa/main/texstate.c | 30 ++
1 file changed
ATI_fs in swrast only had access to texture coordinates if there was a
valid texture bound and texturing was enabled.
Piglit: spec/ati_fragment_shader/render-sources and render-notexture
Signed-off-by: Miklós Máté
---
src/mesa/tnl/t_context.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
Piglit: spec/ati_fragment_shader/error14-invalidmod
Signed-off-by: Miklós Máté
Reviewed-by: Ian Romanick
---
src/mesa/main/atifragshader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/atifragshader.c b/src/mesa/main/atifragshader.c
index d61455e12f..5ddd83be
Thanks again for the review. Since I don't have Mesa git access (only
Piglit) a little push would be appreciated. ;)
I'll send the commit IDs to mesa-stable as suggested though I'm not sure
if the gl_NormalScale fix is worth the trouble. I don't think _anyone_
is using that feature.
On 2017-11-29
Ugh... This patch, though obviously correct if taken on its own, doesn't
wok. The double_inputs_read field is more subtle and bonkers than I
thought.
On Sat, Dec 2, 2017 at 9:32 AM, Jason Ekstrand wrote:
> It's a little sketchy to put the logic in set_io_mask but due to a
> detail of the GLSL s
On Sat, Dec 2, 2017 at 1:22 PM, Rhys Kidd wrote:
> Signed-off-by: Rhys Kidd
> ---
> src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 +-
> src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/galliu
Couple of little compiler warning cleanups so that nouveau builds without any
warnings for meson's debug and release builds with gcc 7.2.0
Rhys Kidd (3):
nv50: Fix unused var warning in release build
nvc0: Fix unused var warnings in release build
nv50/ir: Fix unused var warnings in release b
Signed-off-by: Rhys Kidd
---
src/gallium/drivers/nouveau/nv50/nv98_video.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/nv50/nv98_video.c
b/src/gallium/drivers/nouveau/nv50/nv98_video.c
index 92526d9f64..da0267e646 100644
--- a/src/gallium/dri
Signed-off-by: Rhys Kidd
---
src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp | 2 +-
src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nv50.cpp
b/src/gallium/
Signed-off-by: Rhys Kidd
---
src/gallium/drivers/nouveau/nvc0/nvc0_video.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_video.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_video.c
index b5e7bba5f9..5c1cf899ca 100644
--- a/src/galliu
It's a little sketchy to put the logic in set_io_mask but due to a
detail of the GLSL spec, it's safe to check for 64-bit without knowing
the full access chain. This fixes a bug where try_mask_partial_io
succeeded at marking a portion of the input as used but then we came
along and marked the whol
On Wed 29 Nov 2017, Jason Ekstrand wrote:
> On Wed, Nov 29, 2017 at 2:24 PM, Chad Versace <[1]chadvers...@chromium.org>
> wrote:
>
> On Tue 28 Nov 2017, Jason Ekstrand wrote:
> > This lets us set the BO tiling when we allocate the memory. This is
> > required for GL to work properly.
https://bugs.freedesktop.org/show_bug.cgi?id=103955
--- Comment #8 from Ilia Mirkin ---
This patch fixes the sample case for me:
https://patchwork.freedesktop.org/patch/191532/
--
You are receiving this mail because:
You are the assignee for the bug.
GLSL IR operation arguments can sometimes have an implicit swizzle as a
result of a vector arg and a scalar arg, where the scalar argument is
implicitly expanded to the size of the vector argument.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103955
Signed-off-by: Ilia Mirkin
---
I'm *
On Wed 29 Nov 2017, Dave Airlie wrote:
> On 29 November 2017 at 10:28, Jason Ekstrand wrote:
> > This patch series is a v2 of the one I sent out a couple weeks ago to
> > rewrite Vulkan window system integration. The original patch series can be
> > found on patchwork here:
> >
> > https://patchw
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> The WSI core code does all the hard work. Just add the wrappers and
> turn it on.
> ---
> src/amd/vulkan/radv_extensions.py | 1 +
> src/amd/vulkan/radv_wsi.c | 26 ++
> 2 files changed, 27 insertions(+)
Reviewed-by: Ch
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> Now that we have anv_device_init/finish functions, there's no reason to
> have the individual driver do any more work than that.
You mean "wsi_device_init/finish" functions.
> ---
> src/amd/vulkan/radv_wsi.c | 36 ++---
https://bugs.freedesktop.org/show_bug.cgi?id=104038
Chad Versace changed:
What|Removed |Added
See Also||https://bugs.freedesktop.or
https://bugs.freedesktop.org/show_bug.cgi?id=104038
Chad Versace changed:
What|Removed |Added
CC||airl...@freedesktop.org,
https://bugs.freedesktop.org/show_bug.cgi?id=104038
Bug ID: 104038
Summary: mesa: Need a new Bugzilla component
Drivers/Vulkan/Common
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NE
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> This lets us move wsi_interface to wsi_common_private.h
> ---
> src/amd/vulkan/radv_wsi.c | 41 ++--
> src/intel/vulkan/anv_wsi.c | 51 +++-
> src/vulkan/wsi/wsi_common.c | 77
>
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> The drivers no longer poke at this directly.
> ---
> src/vulkan/wsi/wsi_common.h | 46
> +
> src/vulkan/wsi/wsi_common_private.h | 46
> +
> 2 files changed, 47 insertions(
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> Unfortunately, due to the fact that AcquireNextImage does not take a
> queue, the ANV trick for triggering the fence won't work in general. We
> leave dealing with the fence up to the caller for now.
> ---
> src/amd/vulkan/radv_wsi.c | 15 ++--
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> From: Dave Airlie
>
> v2 (Jason Ekstrand):
> - Rebase
> - Alter the names of the helpers to better match the vulkan entrypoints
> - Use the helpers in anv
> ---
> src/amd/vulkan/radv_wsi.c | 42 --
> src/int
On Tue 28 Nov 2017, Jason Ekstrand wrote:
> This moves bits out of all four corners (anv, radv, x11, wayland) and
> into the wsi common code. We also switch to using an outarray to ensure
> we get our return code right.
> ---
> src/amd/vulkan/radv_wsi.c | 7 +++
> src/intel/vulkan/
On Fri 01 Dec 2017, Chad Versace wrote:
> On Tue 28 Nov 2017, Jason Ekstrand wrote:
> > Neither mesa driver really cares, but we should set it none the less for
> > the sake of correctness.
> > ---
> > src/vulkan/wsi/wsi_common.c | 17 +
> > 1 file changed, 17 insertions(+)
> >
>
2017-12-02 15:49 GMT+01:00 Thomas Helland :
> This patch tries to reduce the number of calls to ralloc in nir_opt_dce.
> Especially with scalarized shaders we have a bunch of calls to ralloc
> in this pass, hurting us quite bad. See the commit message for details.
>
> The other large caller to rall
This patch tries to reduce the number of calls to ralloc in nir_opt_dce.
Especially with scalarized shaders we have a bunch of calls to ralloc
in this pass, hurting us quite bad. See the commit message for details.
The other large caller to ralloc is nir_alu_instr_create, and it would
be nice if w
Also, allocate worklist_elem in groups of 20, to reduce the burden of
allocation. Do not use rzalloc, as there is no need. This lets us drop
the number of calls to ralloc from aproximately 10% of all calls to
ralloc(130 000 calls), down to a mere 2000 calls to ralloc_array_size.
This cuts the r
On 01/12/2017 23:06, Dylan Baker wrote:
As we discussed elsewhere, this should fix the linkage of the dri3 loader and
glx and egl.
Dylan Baker (3):
meson: Reformat meson code to match more common style
meson: fix underlinkage without dri3
meson: Fix overlinkage of dri3 loader
src/egl
Hi,
comments down below...
Greetings,
Tobias
On 12/2/17 12:34 PM, Karol Herbst wrote:
From: Karol Herbst
Creating correct SubOps for OP_MADSP wasn't easy, because devs needed to know
the proper values for each data type. Also the third source doesn't know any
explicit signess and the curr
https://bugs.freedesktop.org/show_bug.cgi?id=104035
Bug ID: 104035
Summary: When will the egl introp for vaapi be implemented
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
libmesa_amd_common static dependency is added in Android build
to avoid the following building errors:
In file included from
external/mesa/src/gallium/drivers/radeon/r600_buffer_common.c:24:
In file included from external/mesa/src/gallium/drivers/radeonsi/si_pipe.h:26:
external/mesa/src/gallium/d
From: Karol Herbst
Creating correct SubOps for OP_MADSP wasn't easy, because devs needed to know
the proper values for each data type. Also the third source doesn't know any
explicit signess and the current code tried to work around this fact.
To make the creating of the subops much easier, this
On Fri, Dec 01, 2017 at 07:19:17PM +0200, kevin.rogo...@intel.com wrote:
> From: Kevin Rogovin
>
> This patch series implements a needed workaround for Gen9 for ASTC5x5
> sampler reads. The crux of the work around is to make sure that the
> sampler does not read an ASTC5x5 texture and a surface w
44 matches
Mail list logo
