[Mesa-dev] [Bug 97852] Unreal Engine corrupted preview viewport

2017-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97852 Tapani Pälli changed: What|Removed |Added Attachment #135622|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-21 Thread Jason Ekstrand
On Tue, Nov 21, 2017 at 1:21 PM, Grazvydas Ignotas wrote: > On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand > wrote: > > On Sun, Nov 19, 2017 at 5:07 AM, Grazvydas Ignotas > > wrote: > >> > >> On Sun, Nov 19, 2017 at 1:51 AM, Jason Ekstrand > >> wrote: > >> > > >> > I force-pushed the branch a

Re: [Mesa-dev] [PATCH 09/21] anv/pipeline: Hash the entire pipeline in one go

2017-11-21 Thread Jason Ekstrand
On Tue, Nov 21, 2017 at 9:37 PM, Timothy Arceri wrote: > On 21/11/17 03:18, Jason Ekstrand wrote: > > On Mon, Nov 20, 2017 at 3:03 AM, Timothy Arceri > > wrote: >> On 29/10/17 05:36, Jason Ekstrand wrote: >> >> Instead of hashing each stage separately (an

Re: [Mesa-dev] [PATCH 09/21] anv/pipeline: Hash the entire pipeline in one go

2017-11-21 Thread Timothy Arceri
On 21/11/17 03:18, Jason Ekstrand wrote: On Mon, Nov 20, 2017 at 3:03 AM, Timothy Arceri > wrote: On 29/10/17 05:36, Jason Ekstrand wrote: Instead of hashing each stage separately (and TES and TCS together), we hash the entire pipeline. 

Re: [Mesa-dev] NIR linking optimisations for Gallium drivers

2017-11-21 Thread Timothy Arceri
On 22/11/17 07:28, Eric Anholt wrote: Timothy Arceri writes: This series depends on: https://patchwork.freedesktop.org/series/34131/ Tested without regression on radeonsi. Shader-db results (still limited to GLSL 1.40 so not to interesting): Totals from affected shaders: SGPRS: 29440 -> 304

Re: [Mesa-dev] [PATCH 17/24] mesa/main: Add a 'spirv' flag to gl_shader_program_data

2017-11-21 Thread Timothy Arceri
On 21/11/17 21:30, Eduardo Lima Mitev wrote: On 11/20/2017 01:54 PM, Timothy Arceri wrote: On 20/11/17 21:56, Eduardo Lima Mitev wrote: On 11/20/2017 11:31 AM, Timothy Arceri wrote: On 20/11/17 19:00, Eduardo Lima Mitev wrote: On 11/16/2017 12:23 AM, Timothy Arceri wrote: On 16/11/17 00:22

[Mesa-dev] [PATCH] r600: set DX10_CLAMP for compute shader too

2017-11-21 Thread sroland
From: Roland Scheidegger I really intended to set this for all shader stages by 3835009796166968750ff46cf209f6d4208cda86 but missed it for compute shaders (because it's in a different source file...). --- src/gallium/drivers/r600/evergreen_compute.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Mesa-dev] [PATCH 4/4] i965: Use prepare_external instead of make_shareable in setTexBuffer2

2017-11-21 Thread Chad Versace
On Wed 08 Nov 2017, Jason Ekstrand wrote: > The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT > which has tighter restrictions than just "it's shared". In particular, > it says that any rendering to the image while it is bound causes the > contents to become undefined. > > T

[Mesa-dev] [PATCH v2 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-21 Thread Scott D Phillips
This extension provides a new texture and sampler parameter (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce a filtered texel value by computing a component-wise minimum (MIN) or maximum (MAX) of the texels that would normally be averaged. v2: - Remove extension from compat contex

[Mesa-dev] [PATCH 2/3] nir: Add a new lowering option to lower all txd to txl.

2017-11-21 Thread Eric Anholt
VC5 requires that all txd are lowered in the shader. --- src/compiler/nir/nir.h | 6 ++ src/compiler/nir/nir_lower_tex.c | 14 -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f46f6147110a..dd969aeb8

[Mesa-dev] [PATCH 1/3] nir: Fix interaction of GL_CLAMP lowering with texture offsets.

2017-11-21 Thread Eric Anholt
We want the clamping of the coordinate to apply after the offset, so we need to do math to lower the offset out of the instruction. Fixes texwrap offset cases for GL_CLAMP with GL_NEAREST on vc5. Note: I moved the get_texture_size() verbatim, so that it was defined before use. --- src/compiler/n

[Mesa-dev] [PATCH 3/3] broadcom/vc5: Enable NIR txd lowering on all txd instructions.

2017-11-21 Thread Eric Anholt
Fixes almost all of piglit's arb_shader_texture_lod grad tests, except for the base -texgrad/texgradcube ones which fail on what appear to be precision problems. --- src/broadcom/compiler/vir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/broadcom/compiler/vir.c b/src/broadcom/compiler/

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-21 Thread Kenneth Graunke
On Thursday, October 19, 2017 11:04:02 AM PST Jason Ekstrand wrote: > Not to be confused with variablePointersStorageBuffer which is the > subset of VK_KHR_variable_pointers required to enable the extension. > This gives us "full" support for variable pointers. > > The approach chosen here was to

Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

2017-11-21 Thread Miklós Máté
On 21/11/17 02:09, Ian Romanick wrote: On 11/20/2017 04:07 PM, Miklós Máté wrote: This patch fixes multiple problems: - the interpolator check was duplicated - both had arg instead of argRep - I split it into color and alpha for better readability and error msg - the DOT4 check only applies to c

Re: [Mesa-dev] [PATCH 3/4] mesa: fix typo in ATI_fs dstMod error checking

2017-11-21 Thread Miklós Máté
On 21/11/17 01:51, Ian Romanick wrote: On 11/20/2017 04:07 PM, Miklós Máté wrote: Piglit: spec/ati_fragment_shader/error14-invalidmod Signed-off-by: Miklós Máté --- src/mesa/main/atifragshader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/atifragshader.

Re: [Mesa-dev] [PATCH 1/4] mesa: mesa: add fallback texture for SampleMapATI if there is nothing

2017-11-21 Thread Miklós Máté
On 21/11/17 01:27, Ian Romanick wrote: Only need one mesa: in the subject. :) On 11/20/2017 04:07 PM, Miklós Máté wrote: This fixes crash in the state tracker. Piglit: spec/ati_fragment_shader/render-notexture Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 35

Re: [Mesa-dev] [PATCH 2/4] mesa: fix crash when an ATI_fs pass begins with an alpha inst

2017-11-21 Thread Miklós Máté
On 21/11/17 03:04, Roland Scheidegger wrote: Am 21.11.2017 um 01:40 schrieb Ian Romanick: On 11/20/2017 04:07 PM, Miklós Máté wrote: This fixes crash when: - first pass begins with alpha inst - first pass ends with color inst, second pass begins with alpha inst Also, use the symbolic name inst

[Mesa-dev] [PATCH crucible] clear: check for invalid offsets in memory

2017-11-21 Thread Lionel Landwerlin
Trying to detect cases where we read/write at the wrong offsets in images. Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103197 --- src/tests/func/renderpass/clear.c | 235 ++ 1 file changed, 235 insertions(+) diff --

[Mesa-dev] [Bug 102122] [softpipe] piglit fdo10370 regression

2017-11-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102122 Mark Janes changed: What|Removed |Added Blocks|103491 | --- Comment #2 from Mark Janes --- Remov

Re: [Mesa-dev] [PATCH 1/4] i965/miptree: Loosen the format check in miptree_match_image

2017-11-21 Thread Chad Versace
On Tue 21 Nov 2017, Jason Ekstrand wrote: > On Tue, Nov 21, 2017 at 10:56 AM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > This function is used to determine when we need to re-allocate a > > miptree.  Since we do nothing differe

Re: [Mesa-dev] GPU (and system) monitoring

2017-11-21 Thread Gordon Haverland
On Tue, 21 Nov 2017 15:26:17 +0200 Eero Tamminen wrote: > 1. Temperature is affected by the temperature of the surrounding > media, power usage less so > 2. Temperature sensor might not be exactly where current load is > using most power (e.g. ALUs vs. memory) I would imagine the reason to monit

Re: [Mesa-dev] [PATCH 3/4] i965/tex_image: Pull the tex format from the renderbuffer in intelSetTexBuffer2

2017-11-21 Thread Chad Versace
On Wed 08 Nov 2017, Jason Ekstrand wrote: > Cc: "17.3" > --- > src/mesa/drivers/dri/i965/intel_tex_image.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c > b/src/mesa/drivers/dri/i965/intel_tex_image.c > in

Re: [Mesa-dev] [PATCH 2/4] i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2

2017-11-21 Thread Chad Versace
On Wed 08 Nov 2017, Jason Ekstrand wrote: > The old code made a new miptree that referenced the same BO as the > renderbuffer and just trusted in the memory aliasing to work. There are > only two ways in which the new miptree is liable to differ from the one > in the renderbuffer and neither of th

Re: [Mesa-dev] [PATCH] radv: use a 16 bytes array for the sampled/storage image descriptors

2017-11-21 Thread Bas Nieuwenhuizen
You'll want to change the title to 16 words instead of 16 bytes. Otherwise Reviewed-by: Bas Nieuwenhuizen On Wed, Nov 15, 2017 at 12:08 PM, Samuel Pitoiset wrote: > This allows to update them with only one memcpy(). > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_descriptor_set

Re: [Mesa-dev] [PATCH] radv: do not add the query pool BO to the list in vkCmdEndQuery()

2017-11-21 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Wed, Nov 15, 2017 at 10:55 AM, Samuel Pitoiset wrote: > As per the spec, the query identified by queryPool and query > must currently be active. Applications have to call vkCmdBeginQuery() > before, and thus the query pool BO will already be in the list. > > Sig

Re: [Mesa-dev] [PATCH 8/8] radeonsi/gfx9: simplify condition for on-chip ESGS

2017-11-21 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Nov 21, 2017 at 4:03 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeonsi/si_shader.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH 3/4] st/dri2: Propagate stapi make_current failure

2017-11-21 Thread Marek Olšák
For patches 1-3: Reviewed-by: Marek Olšák Marek On Tue, Nov 21, 2017 at 12:15 PM, George Barrett wrote: > dri_make_current discards the return value of st_api_make_current, > preventing callers up the stack being made aware of any failures. > --- > src/gallium/state_trackers/dri/dri_context.c

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-21 Thread Grazvydas Ignotas
On Mon, Nov 20, 2017 at 6:08 PM, Jason Ekstrand wrote: > On Sun, Nov 19, 2017 at 5:07 AM, Grazvydas Ignotas > wrote: >> >> On Sun, Nov 19, 2017 at 1:51 AM, Jason Ekstrand >> wrote: >> > >> > I force-pushed the branch again with an added commit: "radv: Move wsi >> > initialization later in physic

[Mesa-dev] [PATCH v2 1/5] gallium: Add helpers for MSAA resolves in pipe_transfer_map()/unmap().

2017-11-21 Thread Eric Anholt
I had replicated this code from vc4 to vc5, but it's something that most drivers will need to do in a similar way. --- src/gallium/auxiliary/util/u_transfer.c | 119 src/gallium/auxiliary/util/u_transfer.h | 10 +++ 2 files changed, 129 insertions(+) diff --git a

[Mesa-dev] [PATCH v2 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

2017-11-21 Thread Eric Anholt
v2: Remove the callback, leave avoiding the recursion up to the caller (probably by rewriting the vtbl either in pctx or u_resource_vtbl) --- src/gallium/auxiliary/util/u_transfer.c | 114 src/gallium/auxiliary/util/u_transfer.h | 11 +++ 2 files changed, 125

[Mesa-dev] [PATCH v2 2/5] broadcom/vc4: Switch to using the u_transfer_map_msaa_helper().

2017-11-21 Thread Eric Anholt
--- src/gallium/drivers/vc4/vc4_resource.c | 104 - src/gallium/drivers/vc4/vc4_resource.h | 3 - 2 files changed, 10 insertions(+), 97 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4_resource.c index cdcbcc917e0d..

[Mesa-dev] [PATCH v2 5/5] broadcom/vc5: Start adding support for rendering to Z32F_S8X24_UINT.

2017-11-21 Thread Eric Anholt
There may be some more RCL work to be done (I think I need to split my Z/S stores when doing separate stencil), but this gets piglit's "texwrap GL_ARB_depth_buffer_float" working. v2: Unwrap the z32f_wrapper before calling the helper, rather than having the helper have a callback. --- src/gal

[Mesa-dev] [PATCH v2 3/5] broadcom/vc5: Switch to using u_transfer_map_msaa_helper().

2017-11-21 Thread Eric Anholt
--- src/gallium/drivers/vc5/vc5_resource.c | 103 - src/gallium/drivers/vc5/vc5_resource.h | 3 - 2 files changed, 10 insertions(+), 96 deletions(-) diff --git a/src/gallium/drivers/vc5/vc5_resource.c b/src/gallium/drivers/vc5/vc5_resource.c index 768f8d41f08a..

Re: [Mesa-dev] NIR linking optimisations for Gallium drivers

2017-11-21 Thread Eric Anholt
Timothy Arceri writes: > This series depends on: > https://patchwork.freedesktop.org/series/34131/ > > Tested without regression on radeonsi. > > Shader-db results (still limited to GLSL 1.40 so not to interesting): > > Totals from affected shaders: > SGPRS: 29440 -> 30464 (3.48 %) > VGPRS: 1962

Re: [Mesa-dev] [PATCH 1/4] i965/miptree: Loosen the format check in miptree_match_image

2017-11-21 Thread Jason Ekstrand
On Tue, Nov 21, 2017 at 10:56 AM, Chad Versace wrote: > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > This function is used to determine when we need to re-allocate a > > miptree. Since we do nothing different in miptree allocation for > > sRGB vs. linear, loosening this should be safe and may l

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: check for the tail sentinel in merge_two_dsts

2017-11-21 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Mon, Nov 20, 2017 at 4:36 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes yet another case where DFRACEXP has only one destination. Found > by address sanitizer. > > Fixes > tests/spec/arb_gpu_shader_fp64/execution/built-in-functions/fs-frexp-dve

Re: [Mesa-dev] [PATCH v2 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-21 Thread Jordan Justen
On 2017-11-21 05:45:36, Eric Engestrom wrote: > On Monday, 2017-11-20 14:27:27 -0800, Jordan Justen wrote: > > Similar idea to Tim's "spec: MESA_program_binary", but simplified and > > written to support both ARB_get_program_binary and > > OES_get_program_binary. > > > > This spec was merged into

Re: [Mesa-dev] [PATCH] loader/dri3: Improve dri3 thread-safety

2017-11-21 Thread Thomas Hellstrom
Hi, Nicolai, On 11/21/2017 11:50 AM, Nicolai Hähnle wrote: Hi Thomas, On 20.11.2017 18:19, Thomas Hellstrom wrote: Is this a multithreaded test? Do you see the error with Ubuntu 17.10 + Xorg? The dEQP-GLES31 tests are all single-threaded. I could finally test with the Ubuntu 17.10 on Xorg d

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Notify on texture allocation failure

2017-11-21 Thread George Barrett
On Tue, Nov 21, 2017 at 08:01:16PM +0100, Marek Olšák wrote: > Where is patch 1? The patches didn't end up in the same thread. Really sorry about that, still getting used to sending patches via mailing list. The subject is > [Mesa-dev] [PATCH 1/4] st/mesa: Propagate framebuffer validation failure

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Notify on texture allocation failure

2017-11-21 Thread Marek Olšák
Where is patch 1? Marek On Tue, Nov 21, 2017 at 12:16 PM, George Barrett wrote: > Callers of dri_drawable->allocate_textures are unaware of failures > occurring in the provided allocation function, happily chugging along > with potentially invalid state. Update the interface and > {dri2,drisw}_a

Re: [Mesa-dev] [PATCH 1/2] nir/gather_info: recognize load_patch_vertices_in as a system value

2017-11-21 Thread Marek Olšák
This patch: Reviewed-by: Marek Olšák Marek On Thu, Nov 16, 2017 at 8:53 AM, Iago Toral Quiroga wrote: > This intrinsic is produced to load SYSTEM_VALUE_VERTICES_IN, which is > generated to load gl_PatchVerticesIn in the SPIR-V path for both > Vulkan and OpenGL. > --- > src/compiler/nir/nir_ga

Re: [Mesa-dev] [PATCH 1/4] i965/miptree: Loosen the format check in miptree_match_image

2017-11-21 Thread Chad Versace
On Wed 08 Nov 2017, Jason Ekstrand wrote: > This function is used to determine when we need to re-allocate a > miptree. Since we do nothing different in miptree allocation for > sRGB vs. linear, loosening this should be safe and may lead to less > copying and reallocating in some odd cases. > > Cc

Re: [Mesa-dev] [PATCH mesa] meson: fix strtof locale support check

2017-11-21 Thread Dylan Baker
Oops, that's what I get for not copy-n-pasting. Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-21 06:26:03) > Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver" > Signed-off-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

2017-11-21 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-21 10:38:25) > On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > > This is still not fully correct (haiku and BSD is notably probably not > > correct), but Linux is not regressed and this should be correct for > > macOS and Windows. > > > > v2: - set the d

Re: [Mesa-dev] [PATCH 2/2] ac/nir: don't write tcs outputs to LDS that aren't read back.

2017-11-21 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 20, 2017 at 2:57 AM, Dave Airlie wrote: > From: Dave Airlie > > If the TCS doesn't read back the outputs, no need to store them > to LDS in the first place. (except for tess factors). > > This seems to give about 50fps (3290->3330) with tessellation d

Re: [Mesa-dev] [PATCH v3] mesa/teximage: add TEXTURE_CUBE_MAP_ARRAY target for CompressedTexImage3D

2017-11-21 Thread Nanley Chery
On Fri, Nov 17, 2017 at 10:22:37AM -0800, Nanley Chery wrote: > On Fri, Nov 17, 2017 at 05:07:09PM +0100, Juan A. Suarez Romero wrote: > > From section 8.7, page 179 of OpenGL ES 3.2 spec: > > > > An INVALID_OPERATION error is generated by CompressedTexImage3D > > if internalformat is one of t

Re: [Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

2017-11-21 Thread Eric Engestrom
On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote: > This is still not fully correct (haiku and BSD is notably probably not > correct), but Linux is not regressed and this should be correct for > macOS and Windows. > > v2: - set the dri_platform to windows on Cygwin as well (Jon) R-b stand

[Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

2017-11-21 Thread Dylan Baker
This is still not fully correct (haiku and BSD is notably probably not correct), but Linux is not regressed and this should be correct for macOS and Windows. v2: - set the dri_platform to windows on Cygwin as well (Jon) Signed-off-by: Dylan Baker --- meson.build | 15 +-- 1 file cha

Re: [Mesa-dev] [Mesa-stable] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-21 Thread Anuj Phogat
On Mon, Nov 20, 2017 at 4:30 PM, Andres Gomez wrote: > Anuj, these 4 patches series landed in master without the "mesa-stable" > tag, hence, just confirming that you dropped the nomination. > Yes, I dropped the mesa-stable tag. Thanks for confirming. > Let me know if that was not the case. > > On

Re: [Mesa-dev] [PATCH 7/8] glapi: Don't search through subdirs from glapitable.h

2017-11-21 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-21 06:06:33) > On Monday, 2017-11-20 15:12:51 -0800, Dylan Baker wrote: > > Because meson won't put it in that folder. > > > > Signed-off-by: Dylan Baker > > --- > > src/mapi/glapi/tests/check_table.cpp | 2 +- > > src/mesa/main/tests/Makefile.am | 2 ++ > >

Re: [Mesa-dev] [PATCH v2] meson: add si_driinfo.h in libgallium_dri

2017-11-21 Thread Dylan Baker
Thanks for making that change. Reviewed-by: Dylan Baker Quoting Juan A. Suarez Romero (2017-11-21 03:40:51) > v2: generate target conditionally (Dylan) > --- > src/gallium/targets/dri/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/targets/dri/meson.build > b/s

[Mesa-dev] [PATCH 19/20] st/mesa: don't store non-fragment sampler states and views in st_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák those are unused. st_context: 10120 -> 3704 bytes --- src/mesa/state_tracker/st_atom_sampler.c | 35 +-- src/mesa/state_tracker/st_atom_texture.c | 56 +-- src/mesa/state_tracker/st_cb_bitmap.c | 8 ++--- src/mesa/state_tracke

[Mesa-dev] [PATCH 09/20] mesa: shrink VERT_ATTRIB bitfields to 32 bits

2017-11-21 Thread Marek Olšák
From: Marek Olšák There are only 32 vertex attribs now. --- src/compiler/shader_enums.h | 46 ++--- src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 ++--- src/mesa/main/arrayobj.c| 14 - src/mesa/main/enable.c

[Mesa-dev] [PATCH 20/20] st/mesa: remove out_num_textures from update_textures

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_atom_texture.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/st_atom_texture.c index 105fa79..ce7755f 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 15/20] mesa, glsl, nir: reduce gl_state_index size to 2 bytes

2017-11-21 Thread Marek Olšák
From: Marek Olšák Let's use the new gl_state_index16 type everywhere and remove the typecasts. This helps reduce the size of gl_program_parameter. --- src/compiler/glsl/ir.h | 2 +- src/compiler/glsl/shader_cache.cpp | 2 +- src/compiler/glsl/standalone_sca

[Mesa-dev] [PATCH 18/20] mesa: move STATE_LENGTH to shader_enums.h and use it everywhere

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/ir.h | 2 +- src/compiler/nir/nir.h | 10 +- src/compiler/nir/nir_lower_drawpixels.c | 2 +- src/compiler/shader_enums.h | 6 ++ src/mesa/program/prog_statevars.h | 6 -- 5 files chang

[Mesa-dev] [PATCH 16/20] mesa: reduce the size of gl_program_parameter

2017-11-21 Thread Marek Olšák
From: Marek Olšák 40 -> 24 bytes, which includes the gl_state_index16 change. --- src/mesa/program/prog_parameter.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/prog_parameter.h b/src/mesa/program/prog_parameter.h index ce5d2cb..41b3fe8 100644 --- a

[Mesa-dev] [PATCH 13/20] mesa: reduce the size of gl_texture_object

2017-11-21 Thread Marek Olšák
From: Marek Olšák We are technically incorrect by not allowing the full range of non-sensical values. Like BaseLevel = 1. Do we really care about that though? gl_texture_object: 1032 -> 984 bytes. --- src/mesa/main/mtypes.h | 48 src/mesa/m

[Mesa-dev] [PATCH 17/20] mesa: reduce the size of gl_texture_image

2017-11-21 Thread Marek Olšák
From: Marek Olšák 80 -> 40 bytes. --- src/mesa/main/mtypes.h | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 9f3df70..950d156 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/

[Mesa-dev] [PATCH 14/20] mesa: reduce the size of gl_viewport_attrib

2017-11-21 Thread Marek Olšák
From: Marek Olšák All drivers convert these to float, so there is no reason to use double. This makes piglit/arb_viewport_array/viewport-indices fail, because glDepthRange accepts double and piglit expects glGetDoublei_v(GL_DEPTH_RANGE) to return the same value, but this patch rounds it to float

[Mesa-dev] [PATCH 12/20] mesa: reduce the size of gl_program

2017-11-21 Thread Marek Olšák
From: Marek Olšák gl_program: 1456 -> 976 bytes --- src/compiler/glsl/link_uniforms.cpp | 9 - src/mesa/main/mtypes.h | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index 46c

[Mesa-dev] [PATCH 11/20] mesa: reduce the size of gl_vertex_array_object

2017-11-21 Thread Marek Olšák
From: Marek Olšák RelativeOffset should actually be uint, not intptr, according to ARB_vertex_attrib_binding. gl_vertex_array_object: 3632 -> 3112 bytes --- src/mesa/main/mtypes.h | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/

[Mesa-dev] [PATCH 10/20] mesa: reduce the size of gl_image_unit

2017-11-21 Thread Marek Olšák
From: Marek Olšák gl_context::ImageUnits: 6144 -> 4608 bytes gl_context: 74608 -> 73072 bytes --- src/mesa/main/mtypes.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f16ff4e..6ddef05 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 08/20] mesa: remove unused vertex attrib WEIGHT

2017-11-21 Thread Marek Olšák
From: Marek Olšák We don't support ARB_vertex_blend. Note that the attribute aliasing check for ARB_vertex_program had to be rewritten. vbo_context: 20344 -> 20008 bytes gl_context: 74672 -> 74616 bytes --- src/compiler/shader_enums.c | 1 - src/compiler/shader_enums.h

[Mesa-dev] [PATCH 05/20] mesa: further reduce the size of ctx->Texture

2017-11-21 Thread Marek Olšák
From: Marek Olšák gl_context: 75072 -> 74672 bytes --- src/mesa/main/glheader.h | 5 - src/mesa/main/mtypes.h | 44 ++-- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/src/mesa/main/glheader.h b/src/mesa/main/glheader.h index 37296

[Mesa-dev] [PATCH 02/20] mesa: inline init_texture_unit

2017-11-21 Thread Marek Olšák
From: Marek Olšák because this is going to be changed --- src/mesa/main/texstate.c | 90 +--- 1 file changed, 39 insertions(+), 51 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index 2146723..62c3572 100644 --- a/src/me

[Mesa-dev] [PATCH 06/20] vbo: decrease the size of vbo_context slightly

2017-11-21 Thread Marek Olšák
From: Marek Olšák vbo_context: 21520 -> 20344 bytes --- src/mesa/main/mtypes.h | 8 src/mesa/vbo/vbo_context.h | 4 ++-- src/mesa/vbo/vbo_exec_draw.c | 2 +- src/mesa/vbo/vbo_save_draw.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/mtypes.

[Mesa-dev] [PATCH 07/20] mesa: don't assign numbers to vertex attrib enums manually

2017-11-21 Thread Marek Olšák
From: Marek Olšák I plan to remove one of them. --- src/compiler/shader_enums.h | 68 ++-- src/mesa/tnl/t_context.h| 106 ++-- src/mesa/vbo/vbo_attrib.h | 92 +++--- 3 files changed, 133 inser

[Mesa-dev] [PATCH 00/20] Mesa: Reducing sizes of gl_context etc.

2017-11-21 Thread Marek Olšák
Hi, This series reduces sizes of many driver structures. For example: gl_context: 152488 -> 72944 bytes vbo_context: 22696 -> 20008 bytes st_context: 10120 -> 3704 bytes The idea is to decrease CPU cache usage on smaller CPUs. I have not noticed a performance difference with microbenchmarks. It

[Mesa-dev] [PATCH 04/20] mesa: decrease the array size of ctx->Texture.FixedFuncUnit to 8

2017-11-21 Thread Marek Olšák
From: Marek Olšák This makes piglit/texunits fail, because we can't do glTexEnv and glGetTexEnv with 192 texture units anymore. Not that it ever made sense. If people are OK with this, we can adjust the test to check only 8 texture units, so that it doesn't fail. See also code comments. gl_cont

[Mesa-dev] [PATCH 03/20] mesa: separate legacy stuff from gl_texture_unit into gl_fixedfunc_texture_unit

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/mesa/drivers/common/meta.c | 18 +++--- src/mesa/drivers/dri/i915/i830_texblend.c | 3 +- src/mesa/drivers/dri/nouveau/nouveau_util.h | 2 +- src/mesa/drivers/dri/nouveau/nv04_context.c | 14 +++-- src/mesa/drivers/dri/nouveau/nv04_state

Re: [Mesa-dev] [PATCH v5 07/13] meson: extend install_megadrivers script to handle symmlinking

2017-11-21 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-21 02:39:44) > On Monday, 2017-11-20 11:09:39 -0800, Dylan Baker wrote: > > Which is required for the gallium media state trackers. > > > > v4: - Make the full version the hard link and the partial so versiions > > the symlinks > > v5: - drop --so-version all-

Re: [Mesa-dev] [PATCH mesa 1/2] meson: reorder subdirs to avoid directly including more than one level

2017-11-21 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-21 07:09:40) > Signed-off-by: Eric Engestrom > --- > src/mapi/glapi/meson.build | 2 ++ > src/mapi/meson.build | 2 +- > src/meson.build| 1 - > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff

[Mesa-dev] [PATCH 09/12] gallium/hud: separate code for record context init/release

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 49 ++--- src/gallium/auxiliary/hud/hud_private.h | 4 +++ 2 files changed, 37 insertions(+), 16 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_contex

[Mesa-dev] [PATCH 04/12] gallium/hud: pass pipe_context explicitly to most functions

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 38 ++--- src/gallium/auxiliary/hud/hud_cpu.c | 8 ++--- src/gallium/auxiliary/hud/hud_driver_query.c | 51 +++- src/gallium/auxiliary/hud/hud_fps.c | 4 +-- src/galli

[Mesa-dev] [PATCH 10/12] gallium/hud: prevent a crash if the recording context is inactive

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index e3fcad2..7502416 100644 --- a/src/gallium/auxiliary/hud/hud_context.c +++

[Mesa-dev] [PATCH 12/12] gallium/hud: add HUD sharing within a context share group

2017-11-21 Thread Marek Olšák
From: Marek Olšák This is needed for profiling multi-context applications like Chrome. One context can record queries and another context can draw the HUD. --- src/gallium/auxiliary/hud/hud_context.c | 103 +++ src/gallium/auxiliary/hud/hud_context.h | 3 + sr

[Mesa-dev] [PATCH 11/12] gallium/hud: update the HUD interface for multiple contexts

2017-11-21 Thread Marek Olšák
From: Marek Olšák This is the boring subset of the following commit. All new parameters are optional. --- src/gallium/auxiliary/hud/hud_context.c | 7 --- src/gallium/auxiliary/hud/hud_context.h | 7 --- src/gallium/state_trackers/dri/dri_context.c | 4 ++-- src/gal

[Mesa-dev] [PATCH 08/12] gallium/hud: separate code for draw context init/release

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 181 1 file changed, 111 insertions(+), 70 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 810c2ea..6689006 100644 --- a/src/galliu

[Mesa-dev] [PATCH 07/12] gallium/hud: don't use hud->pipe in hud_parse_env_var

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index 92d607f..810c2ea 100644 --- a/src/gallium/auxiliary/hud/hud_con

[Mesa-dev] [PATCH 00/12] Gallium HUD for multi-context applications

2017-11-21 Thread Marek Olšák
Hi, This series enables more flexibility for the HUD with multi-context applications like Google Chrome. (with --single-process parameter) It allows capturing queries from one context and draw the HUD in a different context. For example, you want to profile a WebGL context on a web page, but you

[Mesa-dev] [PATCH 06/12] gallium/hud: use cso_get_pipe_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 5 +++-- src/gallium/auxiliary/hud/hud_context.h | 2 +- src/gallium/state_trackers/dri/dri_context.c | 2 +- src/gallium/state_trackers/glx/xlib/xm_api.c | 2 +- src/gallium/state_trackers/nine/device9.c| 2 +- src/ga

[Mesa-dev] [PATCH 03/12] gallium/hud: split hud_draw into 3 separate functions

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 168 +-- src/gallium/auxiliary/hud/hud_context.h | 2 +- src/gallium/state_trackers/dri/dri_drawable.c| 2 +- src/gallium/state_trackers/glx/xlib/xm_api.c | 2 +- src/gallium/state

[Mesa-dev] [PATCH 05/12] cso: add cso_get_pipe_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/cso_cache/cso_context.c | 4 src/gallium/auxiliary/cso_cache/cso_context.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c b/src/gallium/auxiliary/cso_cache/cso_context.c index 757bcf3..df5543c

[Mesa-dev] [PATCH 02/12] st/dri: remove dead code and incorrect comment around make_current

2017-11-21 Thread Marek Olšák
From: Marek Olšák Core Mesa already handles flushing based on ContextReleaseBehavior, so the comment is wrong. Also, old_st is always NULL, because unbind_context always precedes make_current. --- src/gallium/state_trackers/dri/dri_context.c | 13 - 1 file changed, 13 deletions(-)

[Mesa-dev] [PATCH 01/12] st/dri: clean up dri_unbind_context

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/dri/dri_context.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_context.c b/src/gallium/state_trackers/dri/dri_context.c index 18bbfa0..f5400ab 100644 --- a/src/gallium/state_tracker

[Mesa-dev] [PATCH 8/9] radeonsi: handle imported textures with DCC robustly

2017-11-21 Thread Marek Olšák
From: Marek Olšák now you can hack the driver to enable DCC for displayable textures and Glamor that doesn't enable that by default won't crash anymore. --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 9/9] radeonsi: expose all CB performance counters on Stoney

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gallium/drivers/radeonsi/si_perfcounter.c index 56af0a0..5029af0 100644 --- a/src/gallium/drivers/radeonsi/

[Mesa-dev] [PATCH 3/9] ac: pack legacy_surf_level better

2017-11-21 Thread Marek Olšák
From: Marek Olšák r600_texture: 1488 -> 1248 bytes --- src/amd/common/ac_surface.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_surface.h b/src/amd/common/ac_surface.h index ec89f6b..f18548f 100644 --- a/src/amd/common/ac_surface.h +++ b/src/amd/com

[Mesa-dev] [PATCH 7/9] radeonsi: fix a typo in creating monolithic ES-GS

2017-11-21 Thread Marek Olšák
From: Marek Olšák This has no effect because both occupy the same memory in a union. --- src/gallium/drivers/radeonsi/si_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 16036e3

[Mesa-dev] [PATCH 0/9] RadeonSI tiny changes

2017-11-21 Thread Marek Olšák
Hi, This series contains tiny changes and small cleanups. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 5/9] radeonsi: use ac.lds for shared memory

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 2 -- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_sha

[Mesa-dev] [PATCH 6/9] radeonsi: don't write undefined output channels to LDS in LS

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index bca0ca9..16036e3 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/galliu

[Mesa-dev] [PATCH 4/9] radeonsi: do 64-bit LDS loads recursively

2017-11-21 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e6b14f9..d7c130a 100644 --- a/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 1/9] ac: pack ac_surface better

2017-11-21 Thread Marek Olšák
From: Marek Olšák r600_texture: 1736 -> 1488 bytes --- src/amd/common/ac_surface.h | 9 + src/gallium/drivers/r600/r600_texture.c | 2 +- src/gallium/drivers/radeon/r600_texture.c | 12 ++-- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/am

[Mesa-dev] [PATCH 2/9] ac: change legacy_surf_level::slice_size to dword units

2017-11-21 Thread Marek Olšák
From: Marek Olšák The next commit will reduce the size even more. --- src/amd/common/ac_surface.c| 2 +- src/amd/common/ac_surface.h| 2 +- src/amd/vulkan/radv_image.c| 8 src/gallium/drivers/r600/evergreen_state

Re: [Mesa-dev] [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c

2017-11-21 Thread Charmaine Lee
Series looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, November 21, 2017 6:33:22 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c whe

Re: [Mesa-dev] [PATCH 4/5] gallium: Make a helper for doing Z32_FLOAT_S8X24_UINT mappings.

2017-11-21 Thread Rob Clark
On Thu, Nov 16, 2017 at 9:19 PM, Eric Anholt wrote: > --- > src/gallium/auxiliary/util/u_transfer.c | 118 > > src/gallium/auxiliary/util/u_transfer.h | 18 + > 2 files changed, 136 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_transfer.c > b/

Re: [Mesa-dev] [PATCH v2 16/17] i965: Add ARB_get_program_binary support using nir_serialization

2017-11-21 Thread Emil Velikov
Hi Jordan, There's a small question below and a few nitpicks. Latter can be quite subjective, so please don't bother with them if you don't like the approach. On 20 November 2017 at 22:27, Jordan Justen wrote: > +void > +brw_program_binary_init(unsigned device_id) > +{ > + const struct build_

[Mesa-dev] [PATCH mesa 2/2] meson: add variable for mapi_abi.py instead of going back up the tree

2017-11-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/mapi/es1api/meson.build | 2 +- src/mapi/es2api/meson.build | 2 +- src/mapi/glapi/gen/meson.build| 2 +- src/mapi/meson.build | 2 ++ src/mapi/shared-glapi/meson.build | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) dif

  1   2   >