Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Tapani Pälli
On 11/08/2017 08:59 AM, Timothy Arceri wrote: On 08/11/17 16:58, Tapani Pälli wrote: One question below ... On 11/08/2017 03:41 AM, Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a

Re: [Mesa-dev] [RFC v5 08/19] egl/x11: Re-allocate buffers if format is suboptimal

2017-11-07 Thread Constantine Kharlamov
[snip] > @@ -372,10 +372,22 @@ dri3_handle_present_event(struct loader_dri3_drawable > *draw, > switch (ce->mode) { > case XCB_PRESENT_COMPLETE_MODE_FLIP: > draw->flipping = true; > +for (int b = 0; b < sizeof(draw->buffers) / > sizeof(draw->buffers[0]

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Timothy Arceri
On 08/11/17 16:58, Tapani Pälli wrote: One question below ... On 11/08/2017 03:41 AM, Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Timothy Arceri
On 08/11/17 16:53, Kenneth Graunke wrote: On Tuesday, November 7, 2017 5:41:59 PM PST Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have fai

Re: [Mesa-dev] [PATCH v2] glsl: Make #pragma STDGL invariant(all) only modify outputs.

2017-11-07 Thread Iago Toral
Yeah, this is nicer :) Reviewed-by: Iago Toral Quiroga On Tue, 2017-11-07 at 10:20 -0800, Kenneth Graunke wrote: > According to the GLSL ES 3.20, GLSL 4.50, and GLSL 1.20 specs: > >    "To force all output variables to be invariant, use the pragma > >    #pragma STDGL invariant(all) > >  

Re: [Mesa-dev] [PATCH v3] i965: expose SRGB visuals and turn on EGL_KHR_gl_colorspace

2017-11-07 Thread Tapani Pälli
On 11/08/2017 07:25 AM, Kenneth Graunke wrote: On Thursday, November 2, 2017 1:48:34 AM PST Tapani Pälli wrote: Patch exposes sRGB visuals and adds DRI integer query support for __DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that we mark if the app explicitly wanted sRGB and f

Re: [Mesa-dev] [PATCH 2/2] r600: use the clamped versions of rcp/rsq for eg/cayman.

2017-11-07 Thread Ilia Mirkin
Actually cayman gets half of it - it gets the abs, but not clamped. I wonder what happens if you go the other way -- use the IEEE version of the op for RSQ() (presumably you're not testing this on cayman). On Wed, Nov 8, 2017 at 1:18 AM, Ilia Mirkin wrote: > tgsi_rsq appears to ignore the passed-

Re: [Mesa-dev] [PATCH 2/2] r600: use the clamped versions of rcp/rsq for eg/cayman.

2017-11-07 Thread Ilia Mirkin
tgsi_rsq appears to ignore the passed-in op and always puts in ALU_OP1_RECIPSQRT_CLAMPED anyways. It also sticks an absolute value on the RSQ() argument. This only happens for eg, not cayman. (Probably why only the rcp_clamped change appeared to be necessary.) This is odd though, because there's n

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Tapani Pälli
One question below ... On 11/08/2017 03:41 AM, Timothy Arceri wrote: When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have failed to finish hooking up the final step

Re: [Mesa-dev] [PATCH 2/3] glsl: use the correct parent when allocating program data members

2017-11-07 Thread Kenneth Graunke
On Tuesday, November 7, 2017 5:41:58 PM PST Timothy Arceri wrote: > Cc: "17.2 17.3" > --- > src/compiler/glsl/link_atomics.cpp | 4 ++-- > src/compiler/glsl/link_uniforms.cpp | 2 +- > src/compiler/glsl/linker.cpp| 6 +++--- > src/compiler/glsl/shader_cache.cpp | 4 ++-- > 4 files chang

Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Kenneth Graunke
On Tuesday, November 7, 2017 5:41:59 PM PST Timothy Arceri wrote: > When I introduced gl_shader_program_data one of the intentions was to > fix a bug where a failed linking attempt freed data required by a > currently active program. However I seem to have failed to finish > hooking up the final st

Re: [Mesa-dev] [PATCH v3] i965: expose SRGB visuals and turn on EGL_KHR_gl_colorspace

2017-11-07 Thread Kenneth Graunke
On Thursday, November 2, 2017 1:48:34 AM PST Tapani Pälli wrote: > Patch exposes sRGB visuals and adds DRI integer query support for > __DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that > we mark if the app explicitly wanted sRGB and for these framebuffers > we don't turn sRGB off

[Mesa-dev] [PATCH 2/2] r600: use the clamped versions of rcp/rsq for eg/cayman.

2017-11-07 Thread sroland
From: Roland Scheidegger r600 already used the clamped versions, but for some reason this was different to eg/cayman. (Note that it has been different since essentially forever, 7 years, since df62338c491f2cace1a48f99de78e83b5edd82fd in particular, which changed this for r600 but not eg (cayman w

[Mesa-dev] [PATCH 1/2] r600: use min_dx10/max_dx10 instead of min/max_dx10

2017-11-07 Thread sroland
From: Roland Scheidegger I believe this is the safe thing to do, especially ever since the driver actually generates NaNs for muls too. Albeit since the radeon ISA docs are inaccurate/wrong there, I'm not entirely sure what the non-dx10 versions do, but (as required by dx10) the dx10 versions sho

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

2017-11-07 Thread Wladimir
> +/* Return true if a resource has a TS, and it is valid for at least one > level */ > +static bool > +etna_resource_has_valid_ts(struct pipe_resource *prsc) > +{ > + struct etna_resource *rsc = etna_resource(prsc); > + > + if (!rsc->ts_bo) > + return false; > + > + for (int level = 0;

[Mesa-dev] [PATCH 2/3] glsl: use the correct parent when allocating program data members

2017-11-07 Thread Timothy Arceri
Cc: "17.2 17.3" --- src/compiler/glsl/link_atomics.cpp | 4 ++-- src/compiler/glsl/link_uniforms.cpp | 2 +- src/compiler/glsl/linker.cpp| 6 +++--- src/compiler/glsl/shader_cache.cpp | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/link_atomics

[Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-07 Thread Timothy Arceri
When I introduced gl_shader_program_data one of the intentions was to fix a bug where a failed linking attempt freed data required by a currently active program. However I seem to have failed to finish hooking up the final steps required to have the data hang around. Here we create a fresh instanc

[Mesa-dev] [PATCH 1/3] glsl: drop cache_fallback

2017-11-07 Thread Timothy Arceri
This turned out to be a dead end, it is much easier and less error prone to just cache the IR used by the drivers backend e.g. TGSI or NIR. Cc: "17.2 17.3" --- src/compiler/glsl/link_uniforms.cpp | 15 ++- src/compiler/glsl/linker.cpp| 85 + src/co

Re: [Mesa-dev] [RFC PATCH v1 24/30] RFC: anv: Support VkPhysicalDeviceImageDrmFormatModifierInfoEXT

2017-11-07 Thread Jason Ekstrand
One other comment (that I don't know what patch to make it on): I think we want to disallow the MUTABLE_FORMAT create bit with at least the CCS modifier. Also, the CCS modifier needs to only be usable with CCS-supported formats. You may have already thought of those two things but I wanted to ge

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-07 Thread Timothy Arceri
On 08/11/17 02:35, Neil Roberts wrote: Timothy Arceri writes: You’re right, I think that would be a better way to handle it. I guess if this was done then you don’t really need the second link. There are several pointers for the uniform state that you would need to keep and I think there is

[Mesa-dev] non-shared glapi

2017-11-07 Thread Dylan Baker
Jason let me know today that non-shared glapi is broken in meson. The tests for non-shared glapi are broken in autotools and meson. Is anyone still using non-shared glapi, or can we delete it? signature.asc Description: signature ___ mesa-dev mailing li

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-07 Thread Dylan Baker
Quoting Dylan Baker (2017-11-01 11:58:16) > Meson has up until this point set it's version in the root meson.build > script. While there are other build systems them creates "one more > thing" to duplicate between meson and every other build system, this > script is a simple "read, strip, print" so

Re: [Mesa-dev] [PATCH] meson: Add threads dependencies to glsl_compiler executable

2017-11-07 Thread Dylan Baker
Quoting Dylan Baker (2017-10-27 11:22:09) > Fixes compiling the optional standalone glsl compiler. > > Reported-by: DrNick (on irc) > Signed-off-by: Dylan Baker > --- > > This is not compiled by default, but can be built by: > meson build > ninja -C build src/compiler/glsl/glsl_compiler > > sr

[Mesa-dev] [PATCH 2/4] st/mesa: use enum types instead of int/unsigned (v3)

2017-11-07 Thread Brian Paul
Use the proper enum types for various variables. Makes life in gdb a little nicer. Note that the size of enum bitfields must be one larger so the high bit is always zero (for MSVC). v2: also increase size of image_format bitfield, per Eric Engestrom. v3: use the new ASSERT_BITFIELD_SIZE() macro

[Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-07 Thread Brian Paul
Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Update glsl_type constructor to take glsl_base_type instead of unsigned and pass GLSL_TYPE_VOID instead of zero. No Piglit regressions with llvmpipe. v2: - Decl

[Mesa-dev] [PATCH 1/4] util: add new bitfield_assert.h header

2017-11-07 Thread Brian Paul
Contains a macro for checking that bitfields are large enough to hold the largest expected value. --- src/util/bitfield_assert.h | 49 ++ 1 file changed, 49 insertions(+) create mode 100644 src/util/bitfield_assert.h diff --git a/src/util/bitfield_asse

[Mesa-dev] [PATCH 4/4] util/tgsi: use ASSERT_BITFIELD_SIZE() to check opcode field size

2017-11-07 Thread Brian Paul
I've noticed at least two places where we store the TGSI opcode in an unsigned:8 bitfield. We're at 249 opcodes now. If we hit 256 we'll need to grow those bitfields. Use the new ASSERT_BITFIELD_SIZE() macro to detect that. --- src/gallium/auxiliary/tgsi/tgsi_info.c | 3 +++ 1 file changed, 3 i

Re: [Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part

2017-11-07 Thread Dylan Baker
Quoting boyuan.zh...@amd.com (2017-11-07 13:59:02) > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/Makefile.sources | 3 + > src/gallium/drivers/radeon/radeon_vcn_enc.c | 166 + > src/gallium/drivers/radeon/radeon_vcn_enc.h |

Re: [Mesa-dev] [PATCH 11/18] radeon/vcn: add encode begin frame

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang Same here :) Add implementation for begin_frame interface for VCN encode. Alex > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.c | 23 ++- > 1 file changed, 22 insertions(+), 1

Re: [Mesa-dev] [PATCH 09/18] radeon/vcn: add encode header algorithms

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang Better patch description please. What are these for? Please provide a brief overview. > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.h | 6 ++ > src/gallium/drivers/radeon/radeon_vcn_enc_1_

Re: [Mesa-dev] [PATCH 08/18] radeon/vcn: add ib implementations

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang > Better patch description please. Something like: Implement the command buffer submission interfaces for VCN encode. > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 292 > +

Re: [Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang Better patch description please. Something like: Fill out a skeleton interface for video encode on vcn hardware. > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/Makefile.sources | 3 + > src/gallium/drivers

Re: [Mesa-dev] [PATCH 06/18] st/va: implement poc type

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang > Same comment as patch 5. Please provide some details as to what this is. Alex > Signed-off-by: Boyuan Zhang > --- > src/gallium/state_trackers/va/picture.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/sta

Re: [Mesa-dev] [PATCH 05/18] vl: add poc type

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:59 PM, wrote: > From: Boyuan Zhang > Please add a better patch description. Why do you need this new element and what does it mean? Alex > Signed-off-by: Boyuan Zhang > --- > src/gallium/include/pipe/p_video_state.h | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [Mesa-dev] [PATCH 04/18] winsys/amdgpu: add vcn enc cs support

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:58 PM, wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c > b/src/gallium/winsys/a

Re: [Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-07 Thread Alex Deucher
On Tue, Nov 7, 2017 at 4:58 PM, wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/radeon_vcn_enc.h | 325 > > 1 file changed, 325 insertions(+) > create mode 100644 src/gallium/drivers/radeon/radeon_vcn_enc.h > > diff

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-07 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-07 07:25:53) > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote: > > I tested this in a setup where the builddir was outside of the srcdir. > > --- > > src/intel/vulkan/meson.build | 12 > > 1 file changed, 12 insertions(+) > > > > diff --gi

[Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefile.sources | 3 + src/gallium/drivers/radeon/radeon_vcn_enc.c | 166 + src/gallium/drivers/radeon/radeon_vcn_enc.h | 82 src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c |

[Mesa-dev] [PATCH 14/18] radeon/vcn: add encode destroy

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index a21deb1..0cb8e87 1

[Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 234 1 file changed, 234 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c b/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c index 5170c67..c6

[Mesa-dev] [PATCH 02/18] radeon/winsys: add vcn enc ring type

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_winsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 2d3f646..a14e6e3 100644 --- a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 03/18] radeon/common: add vcn enc ip info query

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/amd/common/ac_gpu_info.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 2e56012..b0c0a08 100644 --- a/src/amd/common/ac_gpu_info.c +++ b/src/am

[Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.h | 325 1 file changed, 325 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_vcn_enc.h diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.h b/src/g

[Mesa-dev] [PATCH 16/18] radeon/vcn: add create encoder

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index ab680

[Mesa-dev] [PATCH 09/18] radeon/vcn: add encode header algorithms

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.h | 6 ++ src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 121 2 files changed, 127 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.h b/src/galliu

[Mesa-dev] [PATCH 17/18] radeonsi: enable vcn encode

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_uvd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_uvd.c b/src/gallium/drivers/radeonsi/si_uvd.c index 2fc5e30..09fdb23 100644 --- a/src/gallium/drivers/

[Mesa-dev] [PATCH 06/18] st/va: implement poc type

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 7427b98..55ca16e 100644 --- a/src/gallium/state_trackers/va/pic

[Mesa-dev] [PATCH 05/18] vl: add poc type

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/include/pipe/p_video_state.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_video_state.h b/src/gallium/include/pipe/p_video_state.h index abd5d36..1d57165 100644 --- a/src/gallium/include/pipe/p_vid

[Mesa-dev] [PATCH 13/18] radeon/vcn: add encode end frame

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index 053cf0e..a21deb1 100644 --- a/src

[Mesa-dev] [PATCH 11/18] radeon/vcn: add encode begin frame

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index 437c2fc..51

[Mesa-dev] [PATCH 08/18] radeon/vcn: add ib implementations

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 292 ++-- 1 file changed, 268 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c b/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c

[Mesa-dev] [PATCH 18/18] radeon/video: enable encode support for raven

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_video.c b/src/gallium/drivers/radeon/radeon_video.c index ea76ca1..4edd0a4 100644 --- a/src/galli

[Mesa-dev] [PATCH 12/18] radeon/vcn: add encode bitstream

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index 51cef7f..053cf0e 100

[Mesa-dev] [PATCH 15/18] radeon/vcn: add encode get feedback

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/radeon/radeon_vcn_enc.c index 0cb8e87..ab68039 10

[Mesa-dev] [PATCH 04/18] winsys/amdgpu: add vcn enc cs support

2017-11-07 Thread boyuan.zhang
From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 0b47af9..75e1891 100644 --- a

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-07 Thread Marek Olšák
On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle wrote: > On 07.11.2017 18:35, Michel Dänzer wrote: >> >> On 07/11/17 06:28 PM, Marek Olšák wrote: >>> >>> Hi, >>> >>> This patch is too large for the mailing list: >>> >>> >>> https://cgit.freedesktop.org/~mareko/mesa/commit/?h=addrlib&id=0e0f044268d3

Re: [Mesa-dev] [PATCH 8/8] r600: add support for hw atomic counters. (v3)

2017-11-07 Thread Nicolai Hähnle
On 07.11.2017 19:38, Dave Airlie wrote: On 8 November 2017 at 03:26, Nicolai Hähnle wrote: On 07.11.2017 07:31, Dave Airlie wrote: From: Dave Airlie This adds support for the evergreen/cayman atomic counters. These are implemented using GDS append/consume counters. The values for each coun

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Jason Ekstrand
All of the pre-work patches have been reviewed by myself and Lionel. I've also read through the rest of the series and things look pretty good to me. I did make some scattered comments but they shouldn't be a big deal. My primary concern with the series is the lack of CCS support. Getting that

Re: [Mesa-dev] [RFC PATCH v1 27/30] RFC: anv: Support VkImageExplicitDrmFormatModifierCreateInfoEXT

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 6:48 AM, Chad Versace wrote: > Incremental implementation of VK_EXT_image_drm_format_modifier. > --- > src/intel/vulkan/anv_image.c | 84 ++ > +- > 1 file changed, 75 insertions(+), 9 deletions(-) > > diff --git a/src/intel/vulkan/an

Re: [Mesa-dev] [PATCH] radv: Don't expose heaps with 0 memory.

2017-11-07 Thread Bas Nieuwenhuizen
Hi Andres, It is a fix, but yeah the changes are pretty extensive. I don't have a strong opinion on this one. - Bas On Fri, Nov 3, 2017 at 4:10 PM, Andres Gomez wrote: > Bas, this commit landed without mentioning any specific stable queue. > > For 17.2, this is quite an extensive change and has

Re: [Mesa-dev] [RFC PATCH v1 25/30] RFC: anv: Support VkImageDrmFormatModifierListCreateInfoEXT

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 6:48 AM, Chad Versace wrote: > Incremental implementation of VK_EXT_image_drm_format_modifier. > --- > src/intel/vulkan/anv_image.c | 72 ++ > > src/intel/vulkan/anv_private.h | 6 > 2 files changed, 72 insertions(+), 6 dele

Re: [Mesa-dev] [RFC PATCH v1 24/30] RFC: anv: Support VkPhysicalDeviceImageDrmFormatModifierInfoEXT

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 6:48 AM, Chad Versace wrote: > Incremental implementation of VK_EXT_image_drm_format_modifier. > --- > src/intel/vulkan/anv_formats.c | 45 ++ > +++- > 1 file changed, 40 insertions(+), 5 deletions(-) > > diff --git a/src/intel/vulkan/an

Re: [Mesa-dev] [RFC PATCH v1 23/30] RFC: anv: Support VkDrmFormatModifierPropertiesListEXT

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 6:48 AM, Chad Versace wrote: > Incremental implementation of VK_EXT_image_drm_format_modifier. > --- > src/intel/vulkan/anv_formats.c | 144 ++ > +++ > 1 file changed, 132 insertions(+), 12 deletions(-) > > diff --git a/src/intel/vulkan/

Re: [Mesa-dev] [RFC PATCH v1 21/30] RFC: anv: Implement VK_EXT_external_memory_dma_buf

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 6:48 AM, Chad Versace wrote: > The draft spec lives at > http://kiwitree.net/~chadv/vulkan/#1.0-VK_EXT_external_memory_dma_buf. > > I plan to ask Khronos to merge the spec this week. > --- > src/intel/vulkan/anv_device.c | 13 ++--- > src/intel/vulkan/anv_exte

Re: [Mesa-dev] [PATCH] gallivm: fix compilation against LLVM r317488

2017-11-07 Thread Tobias Droste
Am Dienstag, 7. November 2017, 11:16:14 CET schrieb Samuel Pitoiset: > > On 11/07/2017 11:15 AM, Michel Dänzer wrote: > > On 07/11/17 11:03 AM, Michel Dänzer wrote: > >> On 07/11/17 09:25 AM, Samuel Pitoiset wrote: > >>> The unsafe algebra codepath has been redefined a lot, and > >>> setUnsafeAlge

Re: [Mesa-dev] [PATCH] st/mesa: use enum types instead of int/unsigned (v2)

2017-11-07 Thread Roland Scheidegger
Am 07.11.2017 um 20:52 schrieb Brian Paul: > On 11/07/2017 11:09 AM, Roland Scheidegger wrote: >> Am 07.11.2017 um 18:57 schrieb Brian Paul: >>> On 11/07/2017 09:07 AM, Roland Scheidegger wrote: Am 07.11.2017 um 16:12 schrieb Brian Paul: > Use the proper enum types for various variables. 

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-07 Thread Nicolai Hähnle
On 07.11.2017 18:35, Michel Dänzer wrote: On 07/11/17 06:28 PM, Marek Olšák wrote: Hi, This patch is too large for the mailing list: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=addrlib&id=0e0f044268d3c1af2e78f161aaa2d92c30167cc1 From the commit log: I just overwrote all Mesa files

Re: [Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-07 Thread Ian Romanick
On 11/06/2017 02:54 PM, Brian Paul wrote: > On 11/06/2017 02:27 PM, Ian Romanick wrote: >> On 11/06/2017 01:00 PM, Brian Paul wrote: >>> Declare glsl_type::sampled_type as glsl_base_type as we do for the >>> base_type field.  And make base_type a bitfield to save a few bytes. >> >> Hmm... I have mi

Re: [Mesa-dev] [PATCH] st/mesa: use enum types instead of int/unsigned (v2)

2017-11-07 Thread Brian Paul
On 11/07/2017 11:09 AM, Roland Scheidegger wrote: Am 07.11.2017 um 18:57 schrieb Brian Paul: On 11/07/2017 09:07 AM, Roland Scheidegger wrote: Am 07.11.2017 um 16:12 schrieb Brian Paul: Use the proper enum types for various variables. Makes life in gdb a little nicer. Note that the size of e

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

2017-11-07 Thread Christian Gmeiner
2017-11-07 17:43 GMT+01:00 Wladimir J. van der Laan : > Sampler TS is an hardware optimization that can be used when rendering > to textures. After rendering to a resource with TS enabled, the > texture unit can use this to bypass lookups to empty tiles. This also > means a resolve-in-place can be

Re: [Mesa-dev] [PATCH 8/8] r600: add support for hw atomic counters. (v3)

2017-11-07 Thread Dave Airlie
On 8 November 2017 at 03:26, Nicolai Hähnle wrote: > On 07.11.2017 07:31, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This adds support for the evergreen/cayman atomic counters. >> >> These are implemented using GDS append/consume counters. The values >> for each counter are loaded before dr

Re: [Mesa-dev] [PATCH 2/3] etnaviv: Add TS_SAMPLER formats to etnaviv_format

2017-11-07 Thread Christian Gmeiner
2017-11-07 17:43 GMT+01:00 Wladimir J. van der Laan : > Sampler TS introduces yet another format enumeration for renderable > formats. Introduce it into etnaviv_format as unobtrusively as possible. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner > --- > src/gallium/d

Re: [Mesa-dev] [PATCH 1/3] etnaviv: rnndb update

2017-11-07 Thread Christian Gmeiner
2017-11-07 17:43 GMT+01:00 Wladimir J. van der Laan : > Update rnndb to etna_viv 07c756a. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +- > src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +- > src

[Mesa-dev] [PATCH v2] glsl: Make #pragma STDGL invariant(all) only modify outputs.

2017-11-07 Thread Kenneth Graunke
According to the GLSL ES 3.20, GLSL 4.50, and GLSL 1.20 specs: "To force all output variables to be invariant, use the pragma #pragma STDGL invariant(all) before all declarations in a shader." Notably, this is only supposed to affect output variables. Furthermore, "Only varia

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-07 Thread Marek Olšák
On Tue, Nov 7, 2017 at 6:35 PM, Michel Dänzer wrote: > On 07/11/17 06:28 PM, Marek Olšák wrote: >> Hi, >> >> This patch is too large for the mailing list: >> >> https://cgit.freedesktop.org/~mareko/mesa/commit/?h=addrlib&id=0e0f044268d3c1af2e78f161aaa2d92c30167cc1 > > From the commit log: > >> I j

Re: [Mesa-dev] [PATCH] st/mesa: use enum types instead of int/unsigned (v2)

2017-11-07 Thread Roland Scheidegger
Am 07.11.2017 um 18:57 schrieb Brian Paul: > On 11/07/2017 09:07 AM, Roland Scheidegger wrote: >> Am 07.11.2017 um 16:12 schrieb Brian Paul: >>> Use the proper enum types for various variables.  Makes life in gdb >>> a little nicer.  Note that the size of enum bitfields must be one >>> larger so th

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 9:04 AM, Chad Versace wrote: > On Tue 07 Nov 2017, Jason Ekstrand wrote: > > On Tue, Nov 7, 2017 at 8:11 AM, Jason Ekstrand <[1]ja...@jlekstrand.net> > wrote: > > > > On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace <[2] > chadvers...@chromium.org> > > wrote: > > > >

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-07 Thread Dylan Baker
It looks like the file deletions aren't applied to meson. Quoting Marek Olšák (2017-11-07 09:28:39) > Hi, > > This patch is too large for the mailing list: > > https://cgit.freedesktop.org/~mareko/mesa/commit/?h=addrlib&id=0e0f044268d3c1af2e78f161aaa2d92c30167cc1 > > The plan is to push this on

Re: [Mesa-dev] [PATCH] st/mesa: use enum types instead of int/unsigned (v2)

2017-11-07 Thread Brian Paul
On 11/07/2017 09:07 AM, Roland Scheidegger wrote: Am 07.11.2017 um 16:12 schrieb Brian Paul: Use the proper enum types for various variables. Makes life in gdb a little nicer. Note that the size of enum bitfields must be one larger so the high bit is always zero (for MSVC). v2: also increase

Re: [Mesa-dev] [PATCH v3] i965 : optimized bucket index calculation

2017-11-07 Thread Ian Romanick
On 11/06/2017 08:30 PM, aravindan.muthuku...@intel.com wrote: > From: Aravindan Muthukumar > > Now the complexity has been reduced to O(1) > > Algorithm calculates the index using matrix method. > Matrix arrangement is as below: > Assuming PAGE_SIZE is 4096. > > 1*4096 2*40963*4

Re: [Mesa-dev] [PATCH 2/8] gallium/tgsi: start adding hw atomics (v3)

2017-11-07 Thread Nicolai Hähnle
On 07.11.2017 18:26, Nicolai Hähnle wrote: On 07.11.2017 17:57, Marek Olšák wrote: With HW atomic counters, MaxAtomicBufferSize is a pretty small number (counters * 4). TGSI has maximum index = 32K. Ah, you're right. I forgot: the other comments (about the assertion in patch 2, and about no

Re: [Mesa-dev] [PATCH 5/8] st/mesa: start adding support for hw atomics atom.

2017-11-07 Thread Nicolai Hähnle
On 07.11.2017 07:31, Dave Airlie wrote: From: Dave Airlie This adds a new atom that calls the new driver API to bind buffers containing hw atomics. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_atomicbuf.c | 37 src/mesa/state_tracker/st_atom_

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-07 Thread Michel Dänzer
On 07/11/17 06:28 PM, Marek Olšák wrote: > Hi, > > This patch is too large for the mailing list: > > https://cgit.freedesktop.org/~mareko/mesa/commit/?h=addrlib&id=0e0f044268d3c1af2e78f161aaa2d92c30167cc1 From the commit log: > I just overwrote all Mesa files with internal addrlib and discarded

[Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-07 Thread Marek Olšák
Hi, This patch is too large for the mailing list: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=addrlib&id=0e0f044268d3c1af2e78f161aaa2d92c30167cc1 The plan is to push this on Thursday if there is no feedback. Marek ___ mesa-dev mailing list mes

[Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-07 Thread Dylan Baker
v2: - Add information about CC, CXX, CFLAGS, and CXXFLAGS (Nicolai) - Add message at top that meson for mesa is still a work in progress - Add trailing "/" to directories (Eric E.) - Fix a number of spelling/grammar/style suggestions from Eric E. - Make a number of changes as sugges

Re: [Mesa-dev] [PATCH 8/8] r600: add support for hw atomic counters. (v3)

2017-11-07 Thread Nicolai Hähnle
On 07.11.2017 07:31, Dave Airlie wrote: From: Dave Airlie This adds support for the evergreen/cayman atomic counters. These are implemented using GDS append/consume counters. The values for each counter are loaded before drawing and saved after each draw using special CP packets. I admit I'm

Re: [Mesa-dev] [PATCH 2/8] gallium/tgsi: start adding hw atomics (v3)

2017-11-07 Thread Nicolai Hähnle
On 07.11.2017 17:57, Marek Olšák wrote: With HW atomic counters, MaxAtomicBufferSize is a pretty small number (counters * 4). TGSI has maximum index = 32K. Ah, you're right. Patches 1-7: Reviewed-by: Nicolai Hähnle Marek On Tue, Nov 7, 2017 at 5:43 PM, Nicolai Hähnle wrote: On 07.11.2

Re: [Mesa-dev] Announcement: Meson build type change

2017-11-07 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-07 05:57:55) > On Tuesday, 2017-11-07 06:54:59 -0700, Brian Paul wrote: > > On 11/07/2017 05:25 AM, Eric Engestrom wrote: > > > Hi all, > > > > > > As a result of the discussion that started with this message: > > > https://lists.freedesktop.org/archives/mesa-dev/20

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Chad Versace
On Tue 07 Nov 2017, Jason Ekstrand wrote: > On Tue, Nov 7, 2017 at 8:11 AM, Jason Ekstrand <[1]ja...@jlekstrand.net> > wrote: > > On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace <[2]chadvers...@chromium.org> > wrote: > >     - crucible > >       We really need to write cruc

Re: [Mesa-dev] [PATCH] glsl: Transform fb buffers are only active if a variable uses them

2017-11-07 Thread Nicolai Hähnle
On 06.11.2017 12:23, Neil Roberts wrote: The GL spec will soon be revised to clarify that a buffer binding for a transform feedback buffer is only required if a variable is actually defined to use the buffer binding point. Previously a declaration for the default transform buffer would make it re

Re: [Mesa-dev] [PATCH] radeonsi: remove unused field in the PCI ID table

2017-11-07 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 07.11.2017 15:28, Marek Olšák wrote: From: Marek Olšák --- include/pci_ids/radeonsi_pci_ids.h| 458 +++--- src/amd/common/ac_gpu_info.c | 2 +- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 2 +-

Re: [Mesa-dev] [PATCH 2/8] gallium/tgsi: start adding hw atomics (v3)

2017-11-07 Thread Marek Olšák
With HW atomic counters, MaxAtomicBufferSize is a pretty small number (counters * 4). TGSI has maximum index = 32K. Marek On Tue, Nov 7, 2017 at 5:43 PM, Nicolai Hähnle wrote: > On 07.11.2017 17:25, Nicolai Hähnle wrote: >> >> On 07.11.2017 07:31, Dave Airlie wrote: >>> >>> diff --git a/src/gall

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add si_screen::has_ls_vgpr_init_bug

2017-11-07 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 07.11.2017 04:12, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 ++ src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 3 +-- src/gallium/drivers/ra

Re: [Mesa-dev] [RFC PATCH v1 09/30] anv: Refactor get_image_format_properties() - Reduce params

2017-11-07 Thread Jason Ekstrand
Actually, ignore all my comments. Patches 1-18 are Reviewed-by: Jason Ekstrand On Tue, Nov 7, 2017 at 8:47 AM, Jason Ekstrand wrote: > On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace > wrote: > >> Replace parameters 'enum isl_format' and 'struct anv_format_plane' with >> new parameter 'const st

Re: [Mesa-dev] [PATCH 2/2] r600g: use SIMPLE_FLOAT for blending to avoid NaNs in RTs

2017-11-07 Thread Nicolai Hähnle
On 06.11.2017 15:40, Ilia Mirkin wrote: On Mon, Nov 6, 2017 at 8:48 AM, Ilia Mirkin wrote: On Mon, Nov 6, 2017 at 6:21 AM, Nicolai Hähnle wrote: On 06.11.2017 05:22, Ilia Mirkin wrote: Radeonsi also sets this flag. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103544 Signed-off-by

Re: [Mesa-dev] [PATCH] loader/dri3: Improve dri3 thread-safety

2017-11-07 Thread Nicolai Hähnle
On 06.11.2017 12:53, Thomas Hellstrom wrote: On 11/06/2017 12:14 PM, Nicolai Hähnle wrote: On 03.11.2017 12:02, Thomas Hellstrom wrote: It turned out that with recent changes that call into dri3 from glFinish(), it appears like different thread end up waiting for X events simultaneously, causi

Re: [Mesa-dev] [PATCH v2] glsl: add varying resources for arrays of complex types

2017-11-07 Thread Nicolai Hähnle
Looks plausible. Reviewed-by: Nicolai Hähnle On 02.11.2017 18:49, Juan A. Suarez Romero wrote: This patch is mostly a patch done by Ilia Mirkin. It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. v2: fix locations for TCS/TES/GS inputs and outputs (Ilia) CC: Ilia Mirkin Bugzil

Re: [Mesa-dev] [RFC PATCH v1 09/30] anv: Refactor get_image_format_properties() - Reduce params

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace wrote: > Replace parameters 'enum isl_format' and 'struct anv_format_plane' with > new parameter 'const struct anv_format *'. > This patch makes me nervous for a few reasons. I made a bunch of comments below. However, I'd like you to ignore all of t

[Mesa-dev] [PATCH 1/3] etnaviv: rnndb update

2017-11-07 Thread Wladimir J. van der Laan
Update rnndb to etna_viv 07c756a. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/hw/common.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/common_3d.xml.h | 2 +- src/gallium/drivers/etnaviv/hw/state.xml.h | 4 ++-- src/gallium/drivers/etnaviv/hw/state_3d.xml.h

[Mesa-dev] [PATCH 2/3] etnaviv: Add TS_SAMPLER formats to etnaviv_format

2017-11-07 Thread Wladimir J. van der Laan
Sampler TS introduces yet another format enumeration for renderable formats. Introduce it into etnaviv_format as unobtrusively as possible. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_format.c | 19 +++ src/gallium/drivers/etnaviv/etnaviv_forma

  1   2   3   >