Re: [Mesa-dev] [PATCH v2 2/2] glsl/linker: location aliasing requires types to have the same width

2017-11-06 Thread Iago Toral
That was my intent, although it seems my patch doesn't actually effectively prevent this for types that are not structs since the way the code is structured we need to mark non-numerical types as consuming all location slots to ensure that we catch aliasing attempts (which is what is being done for

[Mesa-dev] [PATCH 7/8] st/mesa: add support for hw atomics to glsl->tgsi. (v3)

2017-11-06 Thread Dave Airlie
From: Dave Airlie This adds support for creating the hw atomic tgsi from the glsl codepaths. v2: drop the atomic index and move to backend. v3: drop buffer decls. (Marek) Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 101 - 1 file chan

[Mesa-dev] [PATCH 3/8] gallium: add hw atomic buffer binding API.

2017-11-06 Thread Dave Airlie
From: Dave Airlie This API binds atomic buffers for all bound shaders (as per the GL semantics). This is needed to support cross shader hw atomic counters. Signed-off-by: Dave Airlie --- src/gallium/docs/source/context.rst | 8 src/gallium/include/pipe/p_context.h | 16

[Mesa-dev] [PATCH 6/8] st/mesa: setup hw atomic limits. (v1.1)

2017-11-06 Thread Dave Airlie
From: Dave Airlie HW atomics need to use caps to set some limits, and some other limits may also need limiting. This fixes things up to work for evergreen hw, it may need more changes in the future if other hw wants to use this path. v1.1: fix indent. Reviewed-by: Nicolai Hähnle Signed-off-by

[Mesa-dev] [PATCH 1/8] gallium: add CAPs to support HW atomic counters. (v3)

2017-11-06 Thread Dave Airlie
From: Dave Airlie This looks like an evergreen specific feature, but with atomic counters AMD have hw specific counters they use instead of operating on buffers directly. These are separate to the buffer atomics, so require different limits and code paths. I've left the CAP for atomic type exten

[Mesa-dev] [PATCH 5/8] st/mesa: start adding support for hw atomics atom.

2017-11-06 Thread Dave Airlie
From: Dave Airlie This adds a new atom that calls the new driver API to bind buffers containing hw atomics. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_atomicbuf.c | 37 src/mesa/state_tracker/st_atom_list.h| 2 ++ src/mesa/state_tracke

[Mesa-dev] [PATCH 2/8] gallium/tgsi: start adding hw atomics (v3)

2017-11-06 Thread Dave Airlie
From: Dave Airlie This adds support for a hw atomic counters to TGSI. A new register file for storing atomic counters is added, along with a new atomic counter semantic, along with docs for both. v2: drop semantic, move hw counter to backend, Ilia pointed out SSO would have busted my plan, and

[Mesa-dev] [PATCH 8/8] r600: add support for hw atomic counters. (v3)

2017-11-06 Thread Dave Airlie
From: Dave Airlie This adds support for the evergreen/cayman atomic counters. These are implemented using GDS append/consume counters. The values for each counter are loaded before drawing and saved after each draw using special CP packets. v2: move hw atomic assignment into driver. v3: fix mes

[Mesa-dev] gallium/r600 hw atomic support (v3)

2017-11-06 Thread Dave Airlie
This is the 3rd submission of the gallium/r600 hw atomic counter support. This is fixes some rebase artifacts, removes the BUFFER decls from the TGSI, and fixes some indirect crashes in the r600 backend, Dave. ___ mesa-dev mailing list mesa-dev@lists.f

[Mesa-dev] [PATCH 4/8] mesa/program: add hw atomic counter file

2017-11-06 Thread Dave Airlie
From: Dave Airlie This is needed for the GLSL->TGSI translation for hw atomic counters. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 2acf64e..60f06aa 100644 --- a/src/mesa/main/mt

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 7:26 PM, Jason Ekstrand wrote: > On Mon, Nov 6, 2017 at 6:33 PM, Chad Versace > wrote: > >> On Mon 06 Nov 2017, Jason Ekstrand wrote: >> > On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace <[1] >> chadvers...@chromium.org> >> > wrote: >> > >> > Jason, I tested this series

[Mesa-dev] [PATCH v3] i965 : optimized bucket index calculation

2017-11-06 Thread aravindan . muthukumar
From: Aravindan Muthukumar Now the complexity has been reduced to O(1) Algorithm calculates the index using matrix method. Matrix arrangement is as below: Assuming PAGE_SIZE is 4096. 1*4096 2*40963*40964*4096 5*4096 6*40967*40968*4096 10*4096 1

Re: [Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead uniform with GLSL ES 1.00 (v3)

2017-11-06 Thread Tomasz Figa
Hi Kenneth, On Tue, Nov 7, 2017 at 8:18 AM, Kenneth Graunke wrote: > On Thursday, October 19, 2017 9:02:20 PM PST Tomasz Figa wrote: >> Hi Ian, Kenneth, >> >> On Wed, Sep 27, 2017 at 2:57 AM, Tomasz Figa wrote: >> > Commit 259fc505454ea6a67aeacf6cdebf1398d9947759 added linker error for >> > mism

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 6:33 PM, Chad Versace wrote: > On Mon 06 Nov 2017, Jason Ekstrand wrote: > > On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace <[1] > chadvers...@chromium.org> > > wrote: > > > > Jason, I tested this series against the khronos-internal vk-gl-cts > and > > found an asser

[Mesa-dev] [PATCH 4/4] radeonsi: add si_screen::has_ls_vgpr_init_bug

2017-11-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 ++ src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 3 +-- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a

[Mesa-dev] [PATCH 1/4] radeonsi/gfx9: don't set gs_table_depth

2017-11-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index d39e412..649a72e 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c +++ b

[Mesa-dev] [PATCH 3/4] radeonsi: use ac_create_target_machine

2017-11-06 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_util.c | 7 +-- src/amd/common/ac_llvm_util.h | 3 +++ src/gallium/drivers/radeonsi/si_pipe.c | 22 +++--- 3 files changed, 15 insertions(+), 17 deletions(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd

[Mesa-dev] [PATCH 2/4] radeonsi: use ac_get_llvm_processor_name

2017-11-06 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_util.c | 2 +- src/amd/common/ac_llvm_util.h | 2 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 37 ++- src/gallium/drivers/radeon/r600_pipe_common.h | 1 - src/gallium/drivers/radeonsi/s

Re: [Mesa-dev] [PATCH 4/4] i965: Track the depth and render caches separately

2017-11-06 Thread Jason Ekstrand
FYI: This appears to help Car Chase by around 1%. Not much, but I'll take it. On Mon, Nov 6, 2017 at 1:38 PM, Jason Ekstrand wrote: > Previously, we just had one hash set for tracking depth and render > caches called brw_context::render_cache. This is less than ideal > because the depth and re

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Chad Versace
On Mon 06 Nov 2017, Jason Ekstrand wrote: > On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > Jason, I tested this series against the khronos-internal vk-gl-cts and > found an assertion failure in src/compiler/spirv. Any thoughts? > > I haven't d

Re: [Mesa-dev] [PATCH] nir: fix a typo

2017-11-06 Thread Dylan Baker
Thanks, I went ahead and pushed this with my r-b. Quoting Gwan-gyeong Mun (2017-11-06 15:28:25) > Signed-off-by: Mun Gwan-gyeong > --- > src/compiler/nir/nir.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index 87c725

[Mesa-dev] [PATCH 2/2] intel/compiler: Move the destructor from vec4_visitor to backend_shader

2017-11-06 Thread Jason Ekstrand
--- src/intel/compiler/brw_shader.cpp | 4 src/intel/compiler/brw_shader.h | 1 + src/intel/compiler/brw_vec4.h | 1 - src/intel/compiler/brw_vec4_visitor.cpp | 4 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/compiler/brw_shader.cpp b/

[Mesa-dev] [PATCH 1/2] i965/fs: Get rid of the early return in brw_compile_cs

2017-11-06 Thread Jason Ekstrand
--- src/intel/compiler/brw_fs.cpp | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index c0b6047..996e4c6 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@

[Mesa-dev] [PATCH] docs: Fix GL_MESA_program_debug enums

2017-11-06 Thread sroland
From: Roland Scheidegger 13b303ff9265b89bdd9100e32f905e9cdadfad81 added the actual enums but didn't remove the already existing ones. (And also duplicated the "fragment" names instead of using the "vertex" names.) --- docs/specs/enums.txt | 26 -- 1 file changed, 8 i

Re: [Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

2017-11-06 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 07:00:16) > On 1 November 2017 at 22:49, Dylan Baker wrote: > > Currently the versions are set in the header, and then sed is used to > > extract them, so that autotools can use them elsewhere. > > > > This is odd. Autotools is perfectly capable of configuring the

[Mesa-dev] [PATCH] nir: fix a typo

2017-11-06 Thread Gwan-gyeong Mun
Signed-off-by: Mun Gwan-gyeong --- src/compiler/nir/nir.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 87c725625d..0174c30504 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -1155,7 +1155,7 @@ typedef

Re: [Mesa-dev] [PATCH] i965: disable NIR linking on HSW and below

2017-11-06 Thread Mark Janes
This needs to be backported/cc'd to stable for the 17.3 release. Timothy Arceri writes: > Fixes: 379b24a40d3d "i965: make use of nir linking" > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103537 > --- > > Jason's fixes referenced in the bug report help a little, > however there are

Re: [Mesa-dev] [PATCH] i965: Don't emit 3DSTATE_SAMPLER_STATE_POINTERS_VS for compute shaders.

2017-11-06 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2017-10-31 01:58:41, Kenneth Graunke wrote: > For the render pipeline, the upload_sampler_state_table atom emits > 3DSTATE_BINDING_TABLE_POINTERS_XS. It tries to avoid this for compute: > >if (GEN_GEN >= 7 && stage_state->stage != MESA_SHADER_COMPUTE) { >

Re: [Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead uniform with GLSL ES 1.00 (v3)

2017-11-06 Thread Kenneth Graunke
On Thursday, October 19, 2017 9:02:20 PM PST Tomasz Figa wrote: > Hi Ian, Kenneth, > > On Wed, Sep 27, 2017 at 2:57 AM, Tomasz Figa wrote: > > Commit 259fc505454ea6a67aeacf6cdebf1398d9947759 added linker error for > > mismatching uniform precision, as required by GLES 3.0 specification and > > co

Re: [Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-06 Thread Brian Paul
On 11/06/2017 02:27 PM, Ian Romanick wrote: On 11/06/2017 01:00 PM, Brian Paul wrote: Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Hmm... I have mixed feelings about this. I made a conscious decision to

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use enum types instead of int/unsigned

2017-11-06 Thread Charmaine Lee
For this series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, November 6, 2017 1:00:30 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 1/2] st/mesa: use enum types instead of int/unsigned Use the proper enum types fo

[Mesa-dev] [RFC v5 16/19] vulkan/wsi: Add wsi_image_create_with_modifiers

2017-11-06 Thread Louis-Francis Ratté-Boulianne
Allow the winsys to provide a set of acceptable modifiers to the driver when creating WSI images. Signed-off-by: Daniel Stone --- src/amd/vulkan/radv_wsi.c | 3 ++ src/intel/vulkan/anv_image.c | 9 +++- src/intel/vulkan/anv_private.h | 3 ++ src/intel/vulkan/anv_wsi.c | 101

[Mesa-dev] [RFC v5 19/19] vulkan/wsi: Return VK_SUBOPTIMAL_KHR for X11

2017-11-06 Thread Louis-Francis Ratté-Boulianne
When it is detected that a window could have been flipped but has been copied because of suboptimal format/modifier. The Vulkan client should then re-create the swapchain. Signed-off-by: Louis-Francis Ratté-Boulianne --- src/vulkan/wsi/wsi_common_x11.c | 53 --

[Mesa-dev] [RFC v5 18/19] RFC: vulkan/wsi: Add support for DRI3 v1.1

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone Adds support for multiple planes and buffer modifiers. v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers" --- src/vulkan/wsi/wsi_common_x11.c | 238 +--- 1 file changed, 199 insertions(+), 39 deletions(-) diff --git a/src/vulkan/wsi/wsi_co

[Mesa-dev] [RFC v5 15/19] vulkan/wsi: Rename needs_linear_copy to different_gpu

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone That's what it actually means; the fact it generally means a linear copy is requires is incidental. Signed-off-by: Daniel Stone --- src/amd/vulkan/radv_wsi.c | 6 +++--- src/intel/vulkan/anv_wsi.c | 2 +- src/vulkan/wsi/wsi_common.h | 2 +- 3 files changed, 5 insertions(+

[Mesa-dev] [RFC v5 17/19] vulkan/wsi/wayland: Add support for zwp_dmabuf

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer modifiers. Signed-off-by: Daniel Stone --- src/vulkan/Makefile.am | 10 +++ src/vulkan/Makefile.sources | 4 +- src/vulkan/wsi/wsi_common_wayland.c | 157 +++---

[Mesa-dev] [RFC v5 12/19] intel/isl: Add ISL tiling -> modifier conversion

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone Given a tiling mode and an aux usage, return the DRM modifier. Signed-off-by: Daniel Stone --- src/intel/isl/isl.h | 6 +- src/intel/isl/isl_drm.c | 17 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.h b/src/intel/

[Mesa-dev] [RFC v5 10/19] vulkan/wsi: Rename needs_linear_copy to should_export

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone The only use for this boolean was to decide whether or not it should export a dmabuf FD. Simplify things a bit by giving that directly. Signed-off-by: Daniel Stone --- src/amd/vulkan/radv_wsi.c | 6 -- src/intel/vulkan/anv_wsi.c | 21 +

[Mesa-dev] [RFC v5 13/19] intel/isl: Add field for suboptimal tiling flags

2017-11-06 Thread Louis-Francis Ratté-Boulianne
The caller might want to discriminate between two possible sets of tiling flags. For example, some tiling modes might allow direct scanout, and so should be preferred even if GPU operations are a little less performant. Signed-off-by: Louis-Francis Ratté-Boulianne --- src/intel/isl/isl.c | 33 ++

[Mesa-dev] [RFC v5 07/19] RFC: egl/x11: Support DRI3 v1.1

2017-11-06 Thread Louis-Francis Ratté-Boulianne
Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR). Signed-off-by: Louis-Francis Ratté-Boulianne Reviewed-by: Eri

[Mesa-dev] [RFC v5 14/19] vulkan/wsi: Add drm_modifier member to wsi_image

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone Not yet used anywhere. Signed-off-by: Daniel Stone --- src/amd/vulkan/Makefile.am | 1 + src/amd/vulkan/radv_wsi.c | 2 ++ src/intel/vulkan/anv_wsi.c | 9 + src/vulkan/wsi/wsi_common.h | 2 ++ 4 files changed, 14 insertions(+) diff --git a/src/amd/vulkan/Makefil

[Mesa-dev] [RFC v5 11/19] vulkan/wsi: Add multiple planes to wsi_image_base

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone Not currently used. Signed-off-by: Daniel Stone --- src/amd/vulkan/radv_wsi.c | 13 +++-- src/intel/vulkan/anv_wsi.c | 9 + src/vulkan/wsi/wsi_common.h | 9 + src/vulkan/wsi/wsi_common_wayland.c | 11 +++ src/vulka

[Mesa-dev] [RFC v5 08/19] egl/x11: Re-allocate buffers if format is suboptimal

2017-11-06 Thread Louis-Francis Ratté-Boulianne
If PresentCompleteNotify event says the pixmap was presented with mode PresentCompleteModeSuboptimalCopy, it means the pixmap could possibly have been flipped instead if allocated with a different format/modifier. Signed-off-by: Louis-Francis Ratté-Boulianne --- src/egl/drivers/dri2/egl_dri2.c

[Mesa-dev] [RFC v5 06/19] dri: Add createImageWithModifiers2 to DRIimageExtension

2017-11-06 Thread Louis-Francis Ratté-Boulianne
It does the same as createImagewithModifiers but allow multiple modifiers set to be given. The modifier used to create the image should be selected from the first tranche if possible. If not, then the subsequent tranches should be used. Signed-off-by: Louis-Francis Ratté-Boulianne --- include/GL

[Mesa-dev] [RFC v5 04/19] dri: Add suppressImplicitSync to DRIimageExtension

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone Provide a hook to inform the driver that implicit synchronization should be suppressed. --- include/GL/internal/dri_interface.h | 10 +- src/egl/drivers/dri2/egl_dri2.c | 27 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a

[Mesa-dev] [RFC v5 09/19] vulkan/wsi: Add wsi_image_base structure

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone This is used to hold information about the allocated image, rather than an ever-growing function argument list. Signed-off-by: Daniel Stone --- src/amd/vulkan/radv_wsi.c | 31 ++ src/intel/vulkan/anv_wsi.c | 25 +++--- src/v

[Mesa-dev] [RFC v5 05/19] i965: Implement EGL_EXT_image_implicit_sync_control

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 +++ src/mesa/drivers/dri/i965/intel_screen.c | 17 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.h b/src/mesa/drivers/dri/i965/brw_bufmgr.h index ee9132

[Mesa-dev] [RFC v5 01/19] dri: fromPlanar() can return NULL as a valid result

2017-11-06 Thread Louis-Francis Ratté-Boulianne
It was assumed that fromPlanar() could return NULL to mean that the planar image is the same as the parent DRI image. That assumption wasn't made everywhere though. Let's fix things and make sure that all callers understand a NULL result Signed-off-by: Louis-Francis Ratté-Boulianne --- src/egl/

[Mesa-dev] [RFC v5 03/19] egl: Add EGL_EXT_image_implicit_sync_control

2017-11-06 Thread Louis-Francis Ratté-Boulianne
From: Daniel Stone Signed-off-by: Daniel Stone --- src/egl/main/eglapi.c | 1 + src/egl/main/egldisplay.h | 1 + src/egl/main/eglimage.c | 26 ++ src/egl/main/eglimage.h | 3 +++ 4 files changed, 31 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/m

[Mesa-dev] [RFC v5 02/19] i965: Only set planar_format if it's actually one

2017-11-06 Thread Louis-Francis Ratté-Boulianne
The planar_format image property was always set even for non-planar formats. This was breaking CCS support as intel_from_planar is now making sure we can't have both a modifier and an planar format. Signed-off-by: Louis-Francis Ratté-Boulianne Reviewed-by: Daniel Stone --- src/mesa/drivers/dri/

[Mesa-dev] [RFC v5 00/19] DRI3 v1.1, ANV dmabuf

2017-11-06 Thread Louis-Francis Ratté-Boulianne
Hi, With full support for modifiers in DRIimage, this patch series adds support for fully plumbing them through X11. This is the fifth revision, more context can be found here: https://lists.freedesktop.org/archives/mesa-dev/2017-June/158457.html https://lists.freedesktop.org/archives/mesa-dev/20

Re: [Mesa-dev] [PATCH 4/4] i965: Use PTE MOCS for all external buffers

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 8:45 AM, Lyude Paul wrote: > Didn't danvet give you a RB'd here? As well: > I fully expect his R-B still applies but, given that I entirely rewrote the patch, I figured I'd give him a chance to review again. > Tested-by: Lyude Paul > Thanks! --Jason > On Fri, 2017-1

[Mesa-dev] [PATCH 1/4] i965: Add stencil buffers to cache set regardless of stencil texturing

2017-11-06 Thread Jason Ekstrand
We may access them as a texture using blorp regardless of whether or not stencil texturing is enabled. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_draw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/

[Mesa-dev] [PATCH 4/4] i965: Track the depth and render caches separately

2017-11-06 Thread Jason Ekstrand
Previously, we just had one hash set for tracking depth and render caches called brw_context::render_cache. This is less than ideal because the depth and render caches are separate and we can't track moves between the depth and the render caches. This limitation led to some unnecessary flushing a

[Mesa-dev] [PATCH 3/4] i965/blorp: Add more destination flushing

2017-11-06 Thread Jason Ekstrand
Right now we just always flush the destination for render and aren't particularly careful about depth or stencil. Soon, flush_for_render isn't going to do the same thing as flush_for_depth and we may be doing a good deal less depth flushing so we should be a bit more precise. --- src/mesa/drivers

[Mesa-dev] [PATCH 2/4] i965: Add more precise cache tracking helpers

2017-11-06 Thread Jason Ekstrand
In theory, this will let us track the depth and render caches separately. Right now, they're just wrappers around brw_render_cache_set_* --- src/mesa/drivers/dri/i965/brw_draw.c | 12 +-- src/mesa/drivers/dri/i965/brw_misc_state.c| 4 ++-- src/mesa/drivers/dri/i965/genX_blor

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace wrote: > Jason, I tested this series against the khronos-internal vk-gl-cts and > found an assertion failure in src/compiler/spirv. Any thoughts? > > I haven't debugged yet because I don't grok these parts of Mesa. > > vk-gl-cts > > commit a24448c

[Mesa-dev] [PATCH] gallium/dri2: Enable {GLX_ARB, EGL_KHR}_context_flush_control

2017-11-06 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/gallium/state_trackers/dri/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index e0cd0e0bc7..d6f8f7e8d1 100644 --- a/src/gallium/state_trackers/dri/dri2.c +++ b/src/gall

[Mesa-dev] [PATCH] Enable flush control for hardware gallium drivers

2017-11-06 Thread Adam Jackson
i965 and the software drivers have this, but not any other gallium driver. Sending this out-of-line since it probably wants testing on a broad spectrum of hardware (not all of which I have). - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-06 Thread Ian Romanick
On 11/06/2017 01:00 PM, Brian Paul wrote: > Declare glsl_type::sampled_type as glsl_base_type as we do for the > base_type field. And make base_type a bitfield to save a few bytes. Hmm... I have mixed feelings about this. I made a conscious decision to have base_type be "full size" because it's

Re: [Mesa-dev] [PATCH] [RFC] gallivm: Use new LLVM fast-math-flags API

2017-11-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 6, 2017 at 10:09 PM, Tobias Droste wrote: > LLVM 6 changed the API on the fast-math-flags: > https://reviews.llvm.org/rL317488 > > NOTE: This also enables the new flag 'ApproxFunc' to allow for > approximations for library functions (sin, cos, ...). I'

Re: [Mesa-dev] [PATCH] gallium: Guard assertions by NDEBUG instead of DEBUG

2017-11-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 6, 2017 at 6:39 PM, Michel Dänzer wrote: > From: Michel Dänzer > > This matches the standard assert.h header. > > Signed-off-by: Michel Dänzer > --- > src/gallium/auxiliary/util/u_debug.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [Mesa-dev] [PATCH v2 15/26] radeonsi: implement PIPE_FLUSH_{TOP, BOTTOM}_OF_PIPE

2017-11-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > v2: use uncached system memory for the fence, and use the CPU to > clear it so we never read garbage when checking the fence > --- > src/gallium/drivers/radeonsi/si_fence.c | 8

[Mesa-dev] [PATCH] [RFC] gallivm: Use new LLVM fast-math-flags API

2017-11-06 Thread Tobias Droste
LLVM 6 changed the API on the fast-math-flags: https://reviews.llvm.org/rL317488 NOTE: This also enables the new flag 'ApproxFunc' to allow for approximations for library functions (sin, cos, ...). I'm not completly convinced, that this is something mesa should do. Signed-off-by: Tobias Droste -

[Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-06 Thread Brian Paul
Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Update glsl_type constructor to take glsl_base_type intead of unsigned and pass GLSL_TYPE_VOID instead of zero. No Piglit regressions with llvmpipe. --- src/com

[Mesa-dev] [PATCH 1/2] st/mesa: use enum types instead of int/unsigned

2017-11-06 Thread Brian Paul
Use the proper enum types for various variables. Makes life in gdb a little nicer. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 7 --- src/mesa/state_tracker/st_glsl_to_tgsi_private.h | 6 +++--- src/mesa/state_tracker/st_mesa_to_tgsi.c | 6 +++--- src/mesa/state_tracker/st_

[Mesa-dev] [PATCH 2/2] st/mesa: whitespace clean-up in st_mesa_to_tgsi.c

2017-11-06 Thread Brian Paul
Remove trailing whitespace, fix indentation, wrap lines to 78 columns, etc. --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 336 --- 1 file changed, 169 insertions(+), 167 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c b/src/mesa/state_tracker/st_me

Re: [Mesa-dev] [PATCH v2 14/26] radeonsi: document some subtle details of fence_finish & fence_server_sync

2017-11-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > v2: remove the change to si_fence_server_sync, we'll handle that more > robustly > > Reviewed-by: Marek Olšák (v1) > --- > src/gallium/drivers/radeonsi/si_fence.c | 22 +++

Re: [Mesa-dev] [PATCH v2 10/26] gallium/u_threaded: implement asynchronous flushes

2017-11-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This requires out-of-band creation of fences, and will be signaled to > the pipe_context::flush implementation by a special TC_FLUSH_ASYNC flag. > > v2: > - remove an incorrect asse

Re: [Mesa-dev] [PATCH 2/2] r600g: use SIMPLE_FLOAT for blending to avoid NaNs in RTs

2017-11-06 Thread Roland Scheidegger
The patch doesn't help at all, but looks like a sensible thing to do anyway. Reviewed-by: Roland Scheidegger Am 06.11.2017 um 05:22 schrieb Ilia Mirkin: > Radeonsi also sets this flag. > > Bugzilla: > https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fi

Re: [Mesa-dev] [PATCH 3/2] etnaviv: Don't over-pad compressed textures

2017-11-06 Thread Christian Gmeiner
2017-11-02 16:08 GMT+01:00 Wladimir J. van der Laan : > HALIGN_FOUR/SIXTEEN has no meaning for compressed textures, and we can't > render to them anyway. So use the tightest possible packing. This > avoids bugs with non-power-of-two block sizes. > > Signed-off-by: Wladimir J. van der Laan Reviewe

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Chad Versace
Jason, I tested this series against the khronos-internal vk-gl-cts and found an assertion failure in src/compiler/spirv. Any thoughts? I haven't debugged yet because I don't grok these parts of Mesa. vk-gl-cts commit a24448cdd72ffdbd8f7f571886625b8a53100979 mesa refs/tags/chadv/test/an

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-06 Thread Dylan Baker
Quoting Aaron Watry (2017-11-03 19:51:49) > On an unrelated note, I also had to remove the LLVM minimum version > check temporarily, otherwise I get llvm version parsing errors from > 6.0.0svn at the following line: > > dep_llvm = dependency( > 'llvm', version : '>= 3.9.0', required : with_amd_

Re: [Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

2017-11-06 Thread Emil Velikov
On 6 November 2017 at 17:19, Eric Engestrom wrote: > Cc: Dylan Baker > Cc: Chad Versace > Cc: Emil Velikov > Cc: Ilia Mirkin > Cc: Andres Rodriguez > Cc: Michel Dänzer > Cc: Matt Turner > Cc: Christian Schmidbauer > Cc: Eero Tamminen > Cc: Ernst Sjöstrand > Signed-off-by: Eric Engestrom

Re: [Mesa-dev] Couple patches for debian-experimental mesa branch

2017-11-06 Thread Matt Turner
Wrong list, I think. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] automake: include git_sha1.h.in in release tarball

2017-11-06 Thread Emil Velikov
On 6 November 2017 at 15:44, Juan A. Suarez Romero wrote: > Fixes: > > make[2]: Leaving directory '/home/local/mesa/mesa-17.4.0-devel/_build/sub/src' > make[2]: *** No rule to make target '../../../src/git_sha1.h.in', needed by > 'git_sha1.h'. Stop. > Makefile:660: recipe for target 'all-recursi

Re: [Mesa-dev] [PATCH] radv: add initial copy descriptor support. (v2)

2017-11-06 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Sat, Nov 4, 2017 at 9:15 PM, Dave Airlie wrote: > From: Dave Airlie > > It appears the latest dota2 vulkan uses this, > and we get a hang in VR mode without it. > > v2: remove finishme I left in after finishing. > > Cc: "17.2 17.3" > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

2017-11-06 Thread Andres Rodriguez
For both patches: Acked-by: Andres Rodriguez On Mon, Nov 6, 2017 at 1:06 PM, Chad Versace wrote: > For both patches, > Reviewed-by: Chad Versace > Tested-by: Chad Versace > > > On Mon 06 Nov 2017, Eric Engestrom wrote: >> Cc: Dylan Baker >> Cc: Chad Versace >> Cc: Emil Velikov >> Cc: Ilia

Re: [Mesa-dev] [PATCH] intel/fs: Use a pure vertical stride for large register strides

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 4:10 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > > On Thu, 2017-11-02 at 15:54 -0700, Jason Ekstrand wrote: > > Register strides higher than 4 are uncommon but they can happen. For > > instance, if you have a 64-bit extract_u8 operation, we turn that > >

Re: [Mesa-dev] [PATCH v3] meson: implement default driver arguments

2017-11-06 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-03 16:44:11) > On Friday, 2017-11-03 18:09:01 +, Dylan Baker wrote: > > This allows drivers to be set by OS/arch in a sane manner. > > > > v2: - set _drivers to a list of drivers instead of manually assigning > > each with_* > > v3: - Use "auto" instead of

Re: [Mesa-dev] [PATCH mesa 2/2] meson: only turn on Mesa's DEBUG for buildtype==debug

2017-11-06 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 07/26] winsys/amdgpu: handle cs_add_fence_dependency for deferred/unsubmitted fences

2017-11-06 Thread Marek Olšák
On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The idea is to fix the following interleaving of operations > that can arise from deferred fences: > > Thread 1 / Context 1 Thread 2 / Context 2 > > f

Re: [Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-06 Thread Dylan Baker
To clarify, with the one hunk in patch 2 moved to patch 1, both patches are: Reviewed-by: Dylan Baker Quoting Dylan Baker (2017-11-02 16:51:18) > I'm also not sure that it matters, but I think consistency with autotools is > important, > Reviewed-by: Dylan Baker > > Quoting Eric Engestrom (2017

Re: [Mesa-dev] [PATCH mesa 2/2] meson: only turn on Mesa's DEBUG for buildtype==debug

2017-11-06 Thread Eric Engestrom
On Monday, 2017-11-06 17:19:35 +, Eric Engestrom wrote: > Cc: Dylan Baker > Cc: Chad Versace > Signed-off-by: Eric Engestrom > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 6e9a799704ecf606b689..78d51b9b9b580fdc

Re: [Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

2017-11-06 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-06 09:19:34) > Cc: Dylan Baker > Cc: Chad Versace > Cc: Emil Velikov > Cc: Ilia Mirkin > Cc: Andres Rodriguez > Cc: Michel Dänzer > Cc: Matt Turner > Cc: Christian Schmidbauer > Cc: Eero Tamminen > Cc: Ernst Sjöstrand > Signed-off

Re: [Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

2017-11-06 Thread Chad Versace
For both patches, Reviewed-by: Chad Versace Tested-by: Chad Versace On Mon 06 Nov 2017, Eric Engestrom wrote: > Cc: Dylan Baker > Cc: Chad Versace > Cc: Emil Velikov > Cc: Ilia Mirkin > Cc: Andres Rodriguez > Cc: Michel Dänzer > Cc: Matt Turner > Cc: Christian Schmidbauer > Cc: Eero Tam

Re: [Mesa-dev] [PATCH] gallium: Guard assertions by NDEBUG instead of DEBUG

2017-11-06 Thread Eric Engestrom
On Monday, 2017-11-06 18:39:54 +0100, Michel Dänzer wrote: > From: Michel Dänzer > > This matches the standard assert.h header. > > Signed-off-by: Michel Dänzer Reviewed-by: Eric Engestrom Guess we should audit every DEBUG in the codebase to make sure the right one is used. > --- > src/gal

Re: [Mesa-dev] Meson's default build type

2017-11-06 Thread Chad Versace
On Mon 06 Nov 2017, Eric Engestrom wrote: > On Monday, 2017-11-06 08:07:21 -0800, Chad Versace wrote: > > On Thu 02 Nov 2017, Dylan Baker wrote: > > > Quoting Matt Turner (2017-11-02 10:06:43) > > > > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer > > > > wrote: > > > > > FWIW, my vote is for debu

Re: [Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

2017-11-06 Thread Matt Turner
Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium: Guard assertions by NDEBUG instead of DEBUG

2017-11-06 Thread Michel Dänzer
From: Michel Dänzer This matches the standard assert.h header. Signed-off-by: Michel Dänzer --- src/gallium/auxiliary/util/u_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index 63940b7225

[Mesa-dev] [PATCH mesa 2/2] meson: only turn on Mesa's DEBUG for buildtype==debug

2017-11-06 Thread Eric Engestrom
Cc: Dylan Baker Cc: Chad Versace Signed-off-by: Eric Engestrom --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 6e9a799704ecf606b689..78d51b9b9b580fdc4058 100644 --- a/meson.build +++ b/meson.build @@ -350,7 +350,7 @@ if cc.get_

[Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

2017-11-06 Thread Eric Engestrom
Cc: Dylan Baker Cc: Chad Versace Cc: Emil Velikov Cc: Ilia Mirkin Cc: Andres Rodriguez Cc: Michel Dänzer Cc: Matt Turner Cc: Christian Schmidbauer Cc: Eero Tamminen Cc: Ernst Sjöstrand Signed-off-by: Eric Engestrom --- Sorry for the massive Cc-list, I wanted to include everyone who took

[Mesa-dev] Couple patches for debian-experimental mesa branch

2017-11-06 Thread Fabio Pedretti
[PATCH 1/2] Remove libtxc-dxtn* recommends for S3TC [PATCH 2/2] Rename --enable-gallium-llvm to --enable-llvm Fabio ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Meson's default build type

2017-11-06 Thread Eric Engestrom
On Monday, 2017-11-06 08:07:21 -0800, Chad Versace wrote: > On Thu 02 Nov 2017, Dylan Baker wrote: > > Quoting Matt Turner (2017-11-02 10:06:43) > > > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote: > > > > FWIW, my vote is for debugoptimized: Assertions are enabled and there's > > > > debugg

Re: [Mesa-dev] [PATCH v3 01/10] egl: add dri2_surface_fixup() helper (v3)

2017-11-06 Thread Gurchetan Singh
This patch series was intended to: a) de-duplicate code across various platforms. b) do preparatory work for platform_tizen. There was some confusion[1] on how we want to move forward with platform_tizen. Until we can figure that out, I suggest we drop patches that move stuff out of platform_and

Re: [Mesa-dev] [PATCH 4/4] i965: Use PTE MOCS for all external buffers

2017-11-06 Thread Lyude Paul
Didn't danvet give you a RB'd here? As well: Tested-by: Lyude Paul On Fri, 2017-11-03 at 16:17 -0700, Jason Ekstrand wrote: > We were already using PTE for all render targets in case one happened to > get scanned out. However, this still wasn't 100% correct because there > are still possibly ca

Re: [Mesa-dev] [PATCH v2 04/26] util/u_queue: add util_queue_fence_wait_timeout

2017-11-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Nov 6, 2017 at 11:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > v2: > - style fixes > - fix missing timeout handling in futex path > > Reviewed-by: Marek Olšák (v1) > --- > src/util/futex.h | 9 -- > src/util/simple_mtx.h | 2 +- >

Re: [Mesa-dev] [PATCH] automake: include git_sha1.h.in in release tarball

2017-11-06 Thread Eric Engestrom
On Monday, 2017-11-06 16:44:40 +0100, Juan A. Suarez Romero wrote: > Fixes: > > make[2]: Leaving directory '/home/local/mesa/mesa-17.4.0-devel/_build/sub/src' > make[2]: *** No rule to make target '../../../src/git_sha1.h.in', needed by > 'git_sha1.h'. Stop. > Makefile:660: recipe for target 'al

Re: [Mesa-dev] [PATCH 1/4] intel/blorp: Use mocs.tex for depth stencil

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 12:56 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Nov 03, 2017 at 04:17:31PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp_genX_exec.h | 6 +- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/src/intel/blo

Re: [Mesa-dev] [PATCH] spirv: Use correct type for sampled images

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 2:37 AM, Alex Smith wrote: > We should use the result type of the OpSampledImage opcode, rather than > the type of the underlying image/samplers. > > This resolves an issue when using separate images and shadow samplers > with glslang. Example: > > layout (...) uniform

  1   2   >