[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103225 --- Comment #1 from Pekka Paalanen --- struct wl_buffer has two different meanings: - On client side, wl_buffer is a protocol object type, which has not been deprecated. It is still valid, used and necessary. There is no definition for 'struct

Re: [Mesa-dev] [PATCH] mesa: Disallow GL_RED/GL_RG with half-floats on GLES2.

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 23:17, Eric Anholt wrote: Sure, you'd think that the combination of GL_OES_texture_half_float and GL_EXT_texture_rg would mean that GL_RG16F exists, but it doesn't. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103227 Fixes: c16a7443e999 ("mesa: Expose GL_OES_required_inte

Re: [Mesa-dev] [PATCH 08/11] compiler/blob: Make some parameters void instead of uint8_t

2017-10-11 Thread Nicolai Hähnle
I've sent some minor comments on patches #3, #5, and #6. Also, spot the typo in the title of patch #4 :) With those addressed, patches 1-8 are: Reviewed-by: Nicolai Hähnle On 11.10.2017 22:38, Jason Ekstrand wrote: There are certain advantages to using uint8_t internally such as well-define

Re: [Mesa-dev] [PATCH 06/11] compiler/blob: make blob_reserve_bytes() more useful

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 22:38, Jason Ekstrand wrote: From: Connor Abbott Despite the name, it could only be used if you immediately wrote to the pointer. Noboby was using it outside of one test, so clearly this behavior wasn't that useful. Instead, make it return an offset into the data buffer so that th

Re: [Mesa-dev] [PATCH 05/11] compiler/blob: Add a concept of a fixed-allocation blob

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 22:38, Jason Ekstrand wrote: --- src/compiler/blob.c | 24 +--- src/compiler/blob.h | 23 ++- 2 files changed, 43 insertions(+), 4 deletions(-) diff --git a/src/compiler/blob.c b/src/compiler/blob.c index 0b42871..59ad8a3 100644 --- a/src

Re: [Mesa-dev] [PATCH 03/11] compiler: Move blob up a level

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 22:38, Jason Ekstrand wrote: We're going to want to use the blob for Vulkan pipeline caching so it makes sense to have it in libcompiler not libglsl. --- src/compiler/Makefile.sources| 4 ++-- src/compiler/{glsl => }/blob.c | 0 src/compiler/{glsl => }/blob

Re: [Mesa-dev] [PATCH 1/3] compiler: Track which textures are accessed via texelFetch().

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 21:15, Kenneth Graunke wrote: GL_EXT_texture_sRGB_decode requires us to handle sRGB decoding in an inconsistent manner when textures are accessed via texelFetch(). So, we need to track which textures are accessed via texelFetch(). Reviewed-by: Nicolai Hähnle --- src/compile

Re: [Mesa-dev] [PATCH v2 1/6] nir: add glsl_type_is_64bit() to nir_types

2017-10-11 Thread Jason Ekstrand
Rb On October 11, 2017 5:51:54 PM Timothy Arceri wrote: From: Timothy Arceri Reviewed-by: Eric Anholt --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 5

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-11 Thread Tapani Pälli
On 10/12/2017 02:34 AM, Dave Airlie wrote: From: Dave Airlie When I realigned the bufferobj code, I didn't see the getters were different, realign the getters to work the same as ssbo. Alternatively you could set these values as 0 in bind_buffer_base_atomic_buffer()? Not sure if it's any b

Re: [Mesa-dev] [PATCH] radv: take unsafe_math and sisched into account when hashing shaders.

2017-10-11 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 12/10/17 15:11, Dave Airlie wrote: From: Dave Airlie We want to generate different variants for sisched and unsafe_math shader variants, so add them to the hash key. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 24 ++-

Re: [Mesa-dev] [PATCH] radv: don't crash if cache is disabled.

2017-10-11 Thread Timothy Arceri
Thanks. Reviewed-by: Timothy Arceri On 12/10/17 15:24, Dave Airlie wrote: From: Dave Airlie If you set MESA_GLSL_CACHE_DISABLE, radv crashed. Fixes: fd24be134f (radv: make use of on-disk cache) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline_cache.c | 14 +- 1 fi

[Mesa-dev] [PATCH] radv: don't crash if cache is disabled.

2017-10-11 Thread Dave Airlie
From: Dave Airlie If you set MESA_GLSL_CACHE_DISABLE, radv crashed. Fixes: fd24be134f (radv: make use of on-disk cache) Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline_cache.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_pip

[Mesa-dev] [PATCH] radv: take unsafe_math and sisched into account when hashing shaders.

2017-10-11 Thread Dave Airlie
From: Dave Airlie We want to generate different variants for sisched and unsafe_math shader variants, so add them to the hash key. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_pipeline.c | 24 ++-- src/amd/vulkan/radv_pipeline_cache.c | 4 ++-- src/amd/vulkan/r

[Mesa-dev] [PATCH v2] Makefile.tools.am/Makefile.common.am: move handling of Expat to Makefile.common.am

2017-10-11 Thread Hongxu Jia
While built with "-fvisibility=default" ... |i586-oe-linux-gcc ... -fvisibility=default ... -o common/.libs/common_libintel_common_la-gen_decoder.o ... It triggered the failure ... |i586-oe-linux-g++ ... common/.libs/libintel_common.a ... -o vulkan/.libs/libvulkan_intel.so |common/.libs/libinte

Re: [Mesa-dev] [PATCH] Android: disable i9x5 drivers on non-x86 builds

2017-10-11 Thread Kenneth Graunke
On Wednesday, October 11, 2017 4:18:23 PM PDT Rob Herring wrote: > The i965 driver has become dependent on x86 specific compiler builtin > functions, so ensure it's disabled for non-x86 builds. > > Signed-off-by: Rob Herring > --- > Android.mk | 4 > 1 file changed, 4 insertions(+) > > dif

[Mesa-dev] [PATCH v2 2/6] nir: add glsl_channel_type() helper

2017-10-11 Thread Timothy Arceri
Reviewed-by: Eric Anholt --- src/compiler/nir_types.cpp | 27 +++ src/compiler/nir_types.h | 2 ++ 2 files changed, 29 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index b0d84aae384..b1b17ebd831 100644 --- a/src/compiler/nir_types.

[Mesa-dev] [PATCH v2 6/6] i965: call nir_lower_io_to_scalar() at link time for BDW and above

2017-10-11 Thread Timothy Arceri
This will allow dead components of varyings to be removed. BDW shader-db results: total instructions in shared programs: 13190730 -> 13108459 (-0.62%) instructions in affected programs: 2110903 -> 2028632 (-3.90%) helped: 14043 HURT: 486 total cycles in shared programs: 541148990 -> 540544072 (-

[Mesa-dev] [PATCH v2 1/6] nir: add glsl_type_is_64bit() to nir_types

2017-10-11 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Eric Anholt --- src/compiler/nir_types.cpp | 6 ++ src/compiler/nir_types.h | 1 + 2 files changed, 7 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 5583bc01620..b0d84aae384 100644 --- a/src/compiler/nir_types.cp

[Mesa-dev] [PATCH v2 5/6] nir: add component level support to remove_unused_io_vars()

2017-10-11 Thread Timothy Arceri
Reviewed-by: Eric Anholt --- src/compiler/nir/nir_linking_helpers.c | 37 +++--- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/compiler/nir/nir_linking_helpers.c b/src/compiler/nir/nir_linking_helpers.c index 838054e42a4..5591f9be820 100644 --- a

[Mesa-dev] [PATCH v2 4/6] glsl: mark xfb inputs as always_active_io

2017-10-11 Thread Timothy Arceri
We won't split varyings marked as always active because there is no point in doing so. This means we need to mark both sides of the interface as always active otherwise we will have a mismatch and start removing things we shouldn't. --- src/compiler/glsl/link_varyings.cpp | 22 +++-

[Mesa-dev] [PATCH v2 3/6] nir: add variant of lower_io_to_scalar to be called earlier

2017-10-11 Thread Timothy Arceri
This is intended to be called before nir_lower_io() so that we can do some linking optimisations with the results. It can also be used with drivers that don't use nir_lower_io() at all such as RADV. v2: pass mode mask rather than first and last stage integer. --- src/compiler/nir/nir.h

[Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-11 Thread Dave Airlie
From: Dave Airlie When I realigned the bufferobj code, I didn't see the getters were different, realign the getters to work the same as ssbo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103214 Fixes: 65d3ef7cd (mesa: align atomic buffer handling code with ubo/ssbo (v1.1)) Signed-off-b

[Mesa-dev] [PATCH] Android: disable i9x5 drivers on non-x86 builds

2017-10-11 Thread Rob Herring
The i965 driver has become dependent on x86 specific compiler builtin functions, so ensure it's disabled for non-x86 builds. Signed-off-by: Rob Herring --- Android.mk | 4 1 file changed, 4 insertions(+) diff --git a/Android.mk b/Android.mk index 9dc0bbd1d7d7..72a9b04be1e3 100644 --- a/And

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #9 from Roland Scheidegger --- (In reply to Scott D Phillips from comment #8) > It seems jogl wants to detect mesa and alter its behavior based on that: > > https://github.com/sgothel/jogl/blob/ > 45cc13c4d68fb3137b741cbc39ea653c15d

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #8 from Scott D Phillips --- scilab breaks starting with: commit 92b4ca45504e7ffc5f4fa385ada1be48e6123181 Author: Marek Olšák Date: Wed Jun 7 22:00:48 2017 +0200 st/mesa: remove the "Gallium 0.4 on" prefix from GL_RENDERER

Re: [Mesa-dev] [PATCH] egl/dri: don't crash when createImageFromRenderbuffer2 is NULL

2017-10-11 Thread Nicolai Hähnle
On 10.10.2017 19:52, Emil Velikov wrote: From: Emil Velikov The __DRI_IMAGE version can be 17 or over, while the function pointer is NULL. Guard for that instead of crashing. Fixes: bad24395d91 ("egl/dri: use createImageFromRenderbuffer2 when available") Cc: Nicolai Hähnle Signed-off-by: Emil

Re: [Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: ignore GL_TEXTURE_SRGB_DECODE_EXT for samplers used with texelFetch*()

2017-10-11 Thread Nicolai Hähnle
On 10.10.2017 19:31, Marek Olšák wrote: Reviewed-by: Marek Olšák BTW, desktop OpenGL does have GL_TEXTURE_SRGB_DECODE_EXT, so the comments are incorrect. Huh, you're right. No idea where I got that idea from. I've changed the comment to note a TODO about having to clarify the interaction bet

[Mesa-dev] [PATCH] mesa: Disallow GL_RED/GL_RG with half-floats on GLES2.

2017-10-11 Thread Eric Anholt
Sure, you'd think that the combination of GL_OES_texture_half_float and GL_EXT_texture_rg would mean that GL_RG16F exists, but it doesn't. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103227 Fixes: c16a7443e999 ("mesa: Expose GL_OES_required_internalformat on GLES contexts.") --- Appar

Re: [Mesa-dev] Testing out Kristian's fast mtx patch

2017-10-11 Thread Eric Anholt
Timothy Arceri writes: > After a recent discussion about this code from 2015 I was curious > to give it a try. The outstanding review item was that we shouldn't > be replacing the C11 mtx type/functions with our own, so I've renamed > the fast path to simple_mtx* and added a couple of patches to

[Mesa-dev] [PATCH v2 4/11] compiler/blob: Switch to init/finsih instead of create/destroy

2017-10-11 Thread Jason Ekstrand
There's no reason why that tiny bit of memory needs to be on the heap. We always put blob_reader on the stack, so why not do the same with the writable blob. v2 (Jason Ekstrand): - Fix the unit tests --- src/compiler/blob.c | 10 +--- src/compiler/blob.h

[Mesa-dev] [Bug 103212] [PATCH] Add OpenGL 4.6 as a known version

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103212 --- Comment #4 from Ian Romanick --- (In reply to Dario Ostuni from comment #3) > @Emil Velikov with the NVIDIA proprietary driver glxinfo was showing OpenGL > version 4.5, even if the driver supports 4.6 That is probably because OpenGL 4.6 is

[Mesa-dev] [PATCH 10/11] anv/pipeline: Declare bind maps closer to their use

2017-10-11 Thread Jason Ekstrand
This is just a trivial cleanup. --- src/intel/vulkan/anv_pipeline.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index b35bad1..3db9b9a 100644 --- a/src/intel/vulkan/anv_pipeline.c +++ b/sr

[Mesa-dev] [PATCH 09/11] anv/multialloc: Add new add_size helper

2017-10-11 Thread Jason Ekstrand
--- src/intel/vulkan/anv_private.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 00264af..e8a845f 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -438,9 +438,11 @@

[Mesa-dev] [PATCH 11/11] anv/pipeline_cache: Rework to use multialloc and blob

2017-10-11 Thread Jason Ekstrand
This gets rid of all of our hand-rolled size calculation and serialization code and replaces it with safe "standards" that are used elsewhere in anv and mesa. This should be significantly safer than rolling our own. --- src/intel/vulkan/anv_pipeline_cache.c | 298 -

[Mesa-dev] [PATCH 07/11] compiler/blob: Constify the reader

2017-10-11 Thread Jason Ekstrand
--- src/compiler/blob.c | 10 +- src/compiler/blob.h | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/compiler/blob.c b/src/compiler/blob.c index c5ed9f5..4ebe94b 100644 --- a/src/compiler/blob.c +++ b/src/compiler/blob.c @@ -236,10 +236,10 @@ blob_writ

[Mesa-dev] [PATCH 05/11] compiler/blob: Add a concept of a fixed-allocation blob

2017-10-11 Thread Jason Ekstrand
--- src/compiler/blob.c | 24 +--- src/compiler/blob.h | 23 ++- 2 files changed, 43 insertions(+), 4 deletions(-) diff --git a/src/compiler/blob.c b/src/compiler/blob.c index 0b42871..59ad8a3 100644 --- a/src/compiler/blob.c +++ b/src/compiler/blob.c @@ -5

[Mesa-dev] [PATCH 08/11] compiler/blob: Make some parameters void instead of uint8_t

2017-10-11 Thread Jason Ekstrand
There are certain advantages to using uint8_t internally such as well-defined arithmetic on all platforms. However, interfaces that work in terms of raw data should use a void* type. --- src/compiler/blob.c | 6 +++--- src/compiler/blob.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 03/11] compiler: Move blob up a level

2017-10-11 Thread Jason Ekstrand
We're going to want to use the blob for Vulkan pipeline caching so it makes sense to have it in libcompiler not libglsl. --- src/compiler/Makefile.sources| 4 ++-- src/compiler/{glsl => }/blob.c | 0 src/compiler/{glsl => }/blob.h | 0 src/mesa/state_tracker/st_shad

[Mesa-dev] [PATCH 04/11] compiler/blob: Switch to init/finsih instead of create/destroy

2017-10-11 Thread Jason Ekstrand
There's no reason why that tiny bit of memory needs to be on the heap. We always put blob_reader on the stack, so why not do the same with the writable blob. --- src/compiler/blob.c | 10 ++-- src/compiler/blob.h | 11 - src/compiler/glsl/shade

[Mesa-dev] [PATCH 01/11] glsl/blob: Return false from ensure_can_read on overrun

2017-10-11 Thread Jason Ekstrand
Otherwise, if you have a large read fail and then try to do a small read, the small read may succeed even though it's at the wrong offset. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/blob.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl/blob.c b/src/compi

[Mesa-dev] [PATCH 06/11] compiler/blob: make blob_reserve_bytes() more useful

2017-10-11 Thread Jason Ekstrand
From: Connor Abbott Despite the name, it could only be used if you immediately wrote to the pointer. Noboby was using it outside of one test, so clearly this behavior wasn't that useful. Instead, make it return an offset into the data buffer so that the result isn't invalidated if you later write

[Mesa-dev] [PATCH 02/11] glsl/blob: Return false from grow_to_fit if we've ever failed

2017-10-11 Thread Jason Ekstrand
Otherwise we could have a failure followed by a smaller write that succeeds and get a corrupted blob. If we ever OOM, we should stop. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/blob.c | 7 ++- src/compiler/glsl/blob.h | 6 ++ 2 files changed, 12 insertions(+), 1 deletion

[Mesa-dev] [PATCH 00/11] anv: Convert the pipeline cache to use blob

2017-10-11 Thread Jason Ekstrand
I started trying to debug a random segfault in the pipeline cache that I was seeing in some of the synchronization tests. After taking a longer look, It became obvious that doing so with the current implementation is nuts. Instead, we're much better off if we take advantage of the blob structure

Re: [Mesa-dev] [PATCH 2/2] include: Update GL headers from khronos opengl registry.

2017-10-11 Thread Daniel Stone
On 11 October 2017 at 18:04, Eric Anholt wrote: > Taken from their c6a99aff31874697741a08cbc8a3488606ce59c7, keeping the > BUILDING_MESA hunk in place. Both are: Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https:/

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Kenneth Graunke
On Wednesday, October 11, 2017 8:40:52 AM PDT Jason Ekstrand wrote: > On Tue, Oct 10, 2017 at 3:14 PM, Kenneth Graunke > wrote: > > > From: Topi Pohjolainen > > > > v2: > >- Fix return value (s/MESA_FORMAT_NONE/false/) (Anuj) > >- Move _mesa_tex_format_from_format_and_type() just > >

[Mesa-dev] [Bug 103126] glthread doesn't offload anything in Witcher 2

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103126 mirh changed: What|Removed |Added CC||m...@protonmail.ch -- You are receiving this ma

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Kenneth Graunke
On Wednesday, October 11, 2017 9:30:27 AM PDT Pohjolainen, Topi wrote: > On Tue, Oct 10, 2017 at 03:14:17PM -0700, Kenneth Graunke wrote: > > From: Topi Pohjolainen > > I really don't qualify as an author anymore, you two have done a lot more work > here since the slim early version of mine. I'v

[Mesa-dev] [PATCH 3/3] i965: Ignore GL_SKIP_DECODE_EXT for textures accessed via texelFetch().

2017-10-11 Thread Kenneth Graunke
The GL_EXT_texture_sRGB_decode spec says: "The conversion of sRGB color space components to linear color space is always performed if the texel lookup function is one of the texelFetch builtin functions. Otherwise, if the texel lookup function is one of the texture builtin functions or one of

[Mesa-dev] [PATCH 2/3] meta: Unset the textures_used_by_txf bitfield.

2017-10-11 Thread Kenneth Graunke
Drivers that use Meta are happily using blitting data using texelFetch and GL_SKIP_DECODE_EXT, but the GL_EXT_texture_sRGB spec unfortunately makes GL_SKIP_DECODE_EXT not necessarily work with texelFetch. As a hack, just unset the texture_used_by_txf bitfield so we can continue with the old desire

[Mesa-dev] [PATCH 1/3] compiler: Track which textures are accessed via texelFetch().

2017-10-11 Thread Kenneth Graunke
GL_EXT_texture_sRGB_decode requires us to handle sRGB decoding in an inconsistent manner when textures are accessed via texelFetch(). So, we need to track which textures are accessed via texelFetch(). --- src/compiler/nir/nir_gather_info.c | 14 +- src/compiler/shader_info.h |

Re: [Mesa-dev] [PATCH 2/2] swr: simd16 shaders work in progress

2017-10-11 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Oct 11, 2017, at 10:50 AM, Rowley, Timothy O > wrote: > > Start building vertex shaders as simd16. > > Disabled by default, set USE_SIMD16_SHADERS in knobs.h to experiment. > > Cc: Bruce Cherniak > --- > src/gallium/drivers/swr/swr_screen.cpp | 6 ++ >

Re: [Mesa-dev] [PATCH 09/20] meson: split and simplify depdendncies

2017-10-11 Thread Dylan Baker
This patch also is broken (breaks building just vulkan drivers) patch incoming. Quoting Dylan Baker (2017-10-11 10:41:17) > Rather than group dependencies in complex groups, use a flatter > structure with split dependencies to avoid checking for the same > dependencies twice. > > Signed-off-by: D

Re: [Mesa-dev] [PATCH 18/20] meson: build softpipe

2017-10-11 Thread Dylan Baker
This patch is broken, I'll send an update. Note to self, meson remembers configuration options, clean build when doing git rebase -x Quoting Dylan Baker (2017-10-11 10:41:26) > This doesn't include llvmpipe. > > Signed-off-by: Dylan Baker > --- > meson.build | 5 ++

Re: [Mesa-dev] [PATCH 08/20] meson: Build gallium auxiliary

2017-10-11 Thread Eric Anholt
Dylan Baker writes: > Signed-off-by: Dylan Baker Patch 2, 5-8 are: Reviewed-by: Eric Anholt For patch 3, I'm not a huge fan of checking in things in .build/, and I'm going to think about that for a bit. signature.asc Description: PGP signature __

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Chris Wilson
Quoting Kenneth Graunke (2017-10-10 23:14:17) > +/* Consider all the restrictions and determine the format of the source. */ > +static mesa_format > +blorp_get_client_format(struct brw_context *brw, > +GLenum format, GLenum type, > +const struct gl_pi

Re: [Mesa-dev] [PATCH 01/20] meson: fix glx test

2017-10-11 Thread Dylan Baker
Eric reviewed this patch and it's landed already. Quoting Dylan Baker (2017-10-11 10:41:09) > That requires a generated header that was rolled into a loop. > > Signed-off-by: Dylan Baker > --- > src/mapi/glapi/gen/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mapi/gl

[Mesa-dev] [PATCH 05/20] meson: Set _GNU_SOURCE

2017-10-11 Thread Dylan Baker
When we start adding non-free software platforms support we'll need to guard this, but for now it should be fine as is. Signed-off-by: Dylan Baker --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 8d890e53e12..b6f6c32d92d 100644 --- a/meson.build

[Mesa-dev] [PATCH 15/20] meson: build radeonsi gallium driver

2017-10-11 Thread Dylan Baker
This hooks up the bits necessary to build gallium dri drivers, with radeonSI as the first example driver. This isn't tested yet. --- src/gallium/meson.build | 3 +- src/gallium/targets/dri/meson.build | 90 + 2 files changed, 91 insertions(+), 2 del

[Mesa-dev] [PATCH 19/20] meson: build llvmpipe

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/gallium/drivers/llvmpipe/meson.build | 116 +++ src/gallium/meson.build | 2 +- src/gallium/targets/dri/meson.build | 4 ++ 3 files changed, 121 insertions(+), 1 deletion(-) create mode 100644 src/gallium/dr

[Mesa-dev] [PATCH 20/20] meson: refactor meson_options

2017-10-11 Thread Dylan Baker
To put one argument on each line. This results in the file being much longer, but I think much more readable. Suggested-by: Eero Tamminen Signed-off-by: Dylan Baker --- meson_options.txt | 170 +- 1 file changed, 129 insertions(+), 41 deletion

[Mesa-dev] [PATCH 06/20] meson: Don't try to install dri drivers unless one is built

2017-10-11 Thread Dylan Baker
This confused the with_dri flag which is meant to control Direct Rendering Infrastructure, not classic drivers Signed-off-by: Dylan Baker --- src/mesa/drivers/dri/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/meson.build b/src/mesa/drivers/d

[Mesa-dev] [PATCH 12/20] meson: Build gallium dri state tracker

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 1 + src/gallium/meson.build | 1 + src/gallium/{ => state_trackers/dri}/meson.build | 46 +++- 3 files changed, 39 insertions(+), 9 deletions(-) copy src/gallium/{ =>

[Mesa-dev] [PATCH 14/20] meson: build gallium winsys for dri, null, and wrapper

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 4 ++ src/gallium/meson.build | 8 ++-- src/gallium/{ => winsys/sw/dri}/meson.build | 55 +++- src/gallium/{ => winsys/sw/kms-dri}/meson.build | 57 --

[Mesa-dev] [PATCH 17/20] meson: add option to disable LLVM

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 5 - meson_options.txt | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 5684a5666d9..9138dc2f5b5 100644 --- a/meson.build +++ b/meson.build @@ -38,6 +38,7 @@ with_vulkan_icd_dir = get_option

[Mesa-dev] [PATCH 11/20] meson: build gallium helper drivers

2017-10-11 Thread Dylan Baker
This builds ddebug, noop, rbug, and trace drivers. Signed-off-by: Dylan Baker --- src/gallium/{ => drivers/ddebug}/meson.build | 13 - src/gallium/{ => drivers/noop}/meson.build | 12 +++- src/gallium/{ => drivers/rbug}/meson.build | 13 - src/gallium/{ => dri

[Mesa-dev] [PATCH 09/20] meson: split and simplify depdendncies

2017-10-11 Thread Dylan Baker
Rather than group dependencies in complex groups, use a flatter structure with split dependencies to avoid checking for the same dependencies twice. Signed-off-by: Dylan Baker --- meson.build| 199 ++--- src/loader/meson.build | 5 +-

[Mesa-dev] [PATCH 13/20] meson: build radeonsi

2017-10-11 Thread Dylan Baker
This builds the radeonsi (and radeon) window system bits and gallium driver bits. Signed-off-by: Dylan Baker --- meson.build | 10 +++- src/gallium/{ => drivers/radeon}/meson.build| 43 +++--- src/gallium/drivers/radeonsi/meson.build| 78 ++

[Mesa-dev] [PATCH 18/20] meson: build softpipe

2017-10-11 Thread Dylan Baker
This doesn't include llvmpipe. Signed-off-by: Dylan Baker --- meson.build | 5 ++ meson_options.txt| 4 +- src/gallium/drivers/softpipe/meson.build | 85 src/gallium/meson.build | 2 +- src/

[Mesa-dev] [PATCH 16/20] meson: build nouveau (gallium) driver

2017-10-11 Thread Dylan Baker
Tested with a GK107. Signed-off-by: Dylan Baker --- meson.build | 6 + src/gallium/drivers/nouveau/meson.build | 217 +++ src/gallium/meson.build | 3 +- src/gallium/targets/dri/meson.build

[Mesa-dev] [PATCH 07/20] meson: build libmesa_gallium

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 19 --- meson_options.txt| 2 + src/mesa/meson.build | 143 ++- 3 files changed, 155 insertions(+), 9 deletions(-) diff --git a/meson.build b/meson.build index b6f6c32d92d..0b3d499a12

[Mesa-dev] [PATCH 10/20] meson: Build gallium pipe-loader

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build | 2 + src/gallium/auxiliary/pipe-loader/meson.build | 63 +++ src/gallium/meson.build | 2 + 3 files changed, 67 insertions(+) create mode 100644 src/gallium/auxiliary/pi

[Mesa-dev] [PATCH 02/20] meson: Add switch for texture float

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 4 meson_options.txt | 2 ++ 2 files changed, 6 insertions(+) diff --git a/meson.build b/meson.build index bff40f697d3..48e9e1db08e 100644 --- a/meson.build +++ b/meson.build @@ -37,6 +37,10 @@ with_vulkan_icd_dir = get_option('vulkan-icd-d

[Mesa-dev] [PATCH 08/20] meson: Build gallium auxiliary

2017-10-11 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 36 ++- meson_options.txt | 4 +- src/gallium/auxiliary/meson.build | 528 ++ src/{ => gallium}/meson.build | 44 +--- src/meson.build | 2 +- 5 files

[Mesa-dev] [PATCH 04/20] meson: add checks for version script and dynamic list

2017-10-11 Thread Dylan Baker
These are used by gallium drivers. Signed-off-by: Dylan Baker --- meson.build | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 48e9e1db08e..8d890e53e12 100644 --- a/meson.build +++ b/meson.build @@ -426,14 +426,28 @@ endif

[Mesa-dev] [PATCH 03/20] configure: commit test files

2017-10-11 Thread Dylan Baker
These are currently auto-generated, but meson needs the same files, so lets commit them to reduce duplication. Signed-off-by: Dylan Baker --- .build/conftest.dyn | 3 +++ .build/conftest.map | 6 ++ Makefile.am | 4 +++- configure.ac| 18 ++ 4 files changed

[Mesa-dev] [PATCH 00/20] meson, gallium edition

2017-10-11 Thread Dylan Baker
This series is somewhat larger than the one to enable classic drivers. I've made an effort to split the patches up better this go around, so hopefully that will make review easier. I have enabled 3 drivers here, which are probably the most popular, nouveau, radeonsi, and softpipe/llvmpipe. I have

[Mesa-dev] [PATCH 01/20] meson: fix glx test

2017-10-11 Thread Dylan Baker
That requires a generated header that was rolled into a loop. Signed-off-by: Dylan Baker --- src/mapi/glapi/gen/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mapi/glapi/gen/meson.build b/src/mapi/glapi/gen/meson.build index 79aa2accc2a..4360346edad 100644 --- a/src/mapi/gla

[Mesa-dev] [PATCH 2/4] radv: do not set registers for merged ES-GS on GFX9

2017-10-11 Thread Samuel Pitoiset
Based on RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index f5dc26d392..626b68ad8e 100644 --- a/src/amd/vulkan/si_cmd_buffer.c

[Mesa-dev] [PATCH 3/4] radv: add has_clear_state and enable it on CIK+ only

2017-10-11 Thread Samuel Pitoiset
This will allow us to emit the CLEAR_STATE packet instead of a bunch of useless packets when doing CS initialization. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 5 + src/amd/vulkan/radv_private.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src/amd/vulkan/rad

[Mesa-dev] [PATCH 4/4] radv: use CLEAR_STATE for initializing some registers

2017-10-11 Thread Samuel Pitoiset
Based on RadeonSI. This improves some Vulkan demos by +1% to +3%. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c | 99 +- 1 file changed, 58 insertions(+), 41 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si

[Mesa-dev] [PATCH 1/4] radv: move the raster config emission in si_set_raster_config()

2017-10-11 Thread Samuel Pitoiset
Similar to RadeonSI, also only call this function for <= VI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c | 113 ++--- 1 file changed, 60 insertions(+), 53 deletions(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_b

Re: [Mesa-dev] [PATCH] meson: fix glx test

2017-10-11 Thread Eric Anholt
Dylan Baker writes: > That requires a generated header that was rolled into a loop. > > fixes: a47c525f3281a27 ("meson: build glx") > Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] i965: Allow mapped VBOs during drawing in non-debug contexts.

2017-10-11 Thread Eric Anholt
Kenneth Graunke writes: > Section 6.3.2 of the GL 4.5 spec says: > >"Any GL command which attempts to read from, write to, or change > the state of a buffer object may generate an INVALID_OPERATION error > if all or part of the buffer object is mapped ... However, only > commands

[Mesa-dev] [PATCH 2/2] include: Update GL headers from khronos opengl registry.

2017-10-11 Thread Eric Anholt
Taken from their c6a99aff31874697741a08cbc8a3488606ce59c7, keeping the BUILDING_MESA hunk in place. --- include/GL/glcorearb.h | 24 +- include/GL/glext.h | 69 -- include/GL/glxext.h| 12 - include/GL/wglext.h| 2

[Mesa-dev] [PATCH 1/2] mapi: Update extension number of MESA_tile_raster_order.

2017-10-11 Thread Eric Anholt
--- src/mapi/glapi/gen/MESA_tile_raster_order.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/MESA_tile_raster_order.xml b/src/mapi/glapi/gen/MESA_tile_raster_order.xml index a1f0cb89bee4..7cc73ca4b025 100644 --- a/src/mapi/glapi/gen/MESA_tile_raster_o

Re: [Mesa-dev] [PATCH v2 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-11 Thread Jason Ekstrand
On Wed, Oct 11, 2017 at 9:42 AM, Eric Anholt wrote: > Samuel Iglesias Gonsálvez writes: > > > [ Unknown signature status ] > > On Tuesday, October 10, 2017 11:53:27 AM CEST Eric Anholt wrote: > >> Samuel Iglesias Gonsálvez writes: > >> > Signed-off-by: Samuel Iglesias Gonsálvez > >> > --- > >>

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Chris Wilson
Quoting Kenneth Graunke (2017-10-10 23:14:17) > +bool > +brw_blorp_download_miptree(struct brw_context *brw, > + struct intel_mipmap_tree *src_mt, > + mesa_format src_format, uint32_t src_swizzle, > + uint32_t level, uint

Re: [Mesa-dev] [PATCH v2 1/4] nir: set default lod to texture opcodes that needed it but don't provide it

2017-10-11 Thread Eric Anholt
Samuel Iglesias Gonsálvez writes: > [ Unknown signature status ] > On Tuesday, October 10, 2017 11:53:27 AM CEST Eric Anholt wrote: >> Samuel Iglesias Gonsálvez writes: >> > Signed-off-by: Samuel Iglesias Gonsálvez >> > --- >> > >> > src/compiler/nir/nir_lower_tex.c | 68 >> > +++

[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103225 Bug ID: 103225 Summary: Deprecated wl_buffer still mentioned in EGL/eglmesaext.h Product: Mesa Version: 17.2 Hardware: All OS: FreeBSD Status:

Re: [Mesa-dev] [PATCH 1/2] anv: bo_cache: allow importing a BO larger than needed

2017-10-11 Thread Daniel Stone
On 11 October 2017 at 17:36, Lionel Landwerlin wrote: > It's not a problem if a BO has been allocated larger than we need it > to be. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102940 > Fixes: 818b857914 ("anv: Use the BO cache for DeviceMemory allocations") > Signed-off-by: Lionel

Re: [Mesa-dev] [PATCH 1/2] gallium: allow 512-bit vectors

2017-10-11 Thread Roland Scheidegger
This looks alright to me. There's quite a few places where this will increase the memory requirements a bit but there's no way around it (well unless deciding at runtime alignments/allocations, but it's probably not worth the trouble). Reviewed-by: Roland Scheidegger Am 11.10.2017 um 17:50 schri

[Mesa-dev] [PATCH 1/2] anv: bo_cache: allow importing a BO larger than needed

2017-10-11 Thread Lionel Landwerlin
It's not a problem if a BO has been allocated larger than we need it to be. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102940 Fixes: 818b857914 ("anv: Use the BO cache for DeviceMemory allocations") Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_allocator.c | 2 +- 1 file

[Mesa-dev] [PATCH 2/2] anv: intel: use anv_image's computed size for importing a BO

2017-10-11 Thread Lionel Landwerlin
Rather than relying on size = stride * height, we can rely on anv_image's total size. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_intel.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/anv_intel.c b/src/intel/vulkan

Re: [Mesa-dev] [PATCH 1/2] gallium: allow 512-bit vectors

2017-10-11 Thread Jose Fonseca
On 11/10/17 16:50, Tim Rowley wrote: Increase the max allowed vector size from 256 to 512. No piglit llvmpipe regressions running on avx2. Cc: Dave Airlie Cc: Jose Fonseca --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 14 +++--- src/gallium/auxiliary/gallivm/lp_bld_type.h

Re: [Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

2017-10-11 Thread Pohjolainen, Topi
On Tue, Oct 10, 2017 at 03:14:17PM -0700, Kenneth Graunke wrote: > From: Topi Pohjolainen I really don't qualify as an author anymore, you two have done a lot more work here since the slim early version of mine. > > v2: >- Fix return value (s/MESA_FORMAT_NONE/false/) (Anuj) >- Move _mes

[Mesa-dev] [Bug 103212] [PATCH] Add OpenGL 4.6 as a known version

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103212 --- Comment #3 from Dario Ostuni --- @Eric Engestrom thanks! And also thanks for pointing me to that page in the website. @Emil Velikov with the NVIDIA proprietary driver glxinfo was showing OpenGL version 4.5, even if the driver supports 4.6

[Mesa-dev] [PATCH 0/2] gallium/swr: simd16 work in progress

2017-10-11 Thread Tim Rowley
Changes to allow the swr work in progress native simd16 pipeline. Currently enabling this via USE_SIMD16_SHADERS in knobs.h will run the fetch shader with double pumped simd8, the vertex shaders in native simd16, and the rest of the pipeline in simd8. Tim Rowley (2): gallium: allow 512-bit vecto

[Mesa-dev] [PATCH 1/2] gallium: allow 512-bit vectors

2017-10-11 Thread Tim Rowley
Increase the max allowed vector size from 256 to 512. No piglit llvmpipe regressions running on avx2. Cc: Dave Airlie Cc: Jose Fonseca --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 14 +++--- src/gallium/auxiliary/gallivm/lp_bld_type.h | 4 ++-- 2 files changed, 9 insertio

[Mesa-dev] [PATCH 2/2] swr: simd16 shaders work in progress

2017-10-11 Thread Tim Rowley
Start building vertex shaders as simd16. Disabled by default, set USE_SIMD16_SHADERS in knobs.h to experiment. Cc: Bruce Cherniak --- src/gallium/drivers/swr/swr_screen.cpp | 6 ++ src/gallium/drivers/swr/swr_screen.h | 3 +++ src/gallium/drivers/swr/swr_shader.cpp | 14 --

[Mesa-dev] [Bug 103212] [PATCH] Add OpenGL 4.6 as a known version

2017-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103212 --- Comment #2 from Emil Velikov --- (In reply to Eric Engestrom from comment #1) > Good catch, thanks! This allows glxinfo and wglinfo to show 4.6 info :) > It should work even without the patch. When requesting GL 4.5 (or 3.1 even) the driver

  1   2   >