Re: [Mesa-dev] [PATCH v2 2/2] main/format: skip format conversion if src and dst format are equal

2017-10-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On October 7, 2017 1:42:22 PM Kenneth Graunke wrote: From: Karol Herbst Fixes 'KHR-GL45.copy_image.functional' on Nouveau and i965. v2: (by Kenneth Graunke) Rewrite patch according to Jason Ekstrand's review feedback. This makes it handle differing stri

Re: [Mesa-dev] How to build 32-bit Mesa

2017-10-07 Thread Nicholas Miell
On 10/07/2017 10:53 AM, Marek Olšák wrote: > Would you please share how you build 32-bit Mesa on Linux. I think it > would be useful to everybody. 1) Name your build directories e.g. BUILD.x86_64 or BUILD.i686. Put them both in the same directory. 2) Put -m32 or -m64 in the CFLAGS and CXXFLAGS e

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Make _mesa_get_format_bytes handle array formats.

2017-10-07 Thread Kenneth Graunke
On Saturday, October 7, 2017 1:58:30 PM PDT Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > That said, given that I typed it into IRC last night, maybe we should get > another review? Wouldn't hurt. It might also make sense to change authorship to you and put my Reviewed-by on it, sinc

Re: [Mesa-dev] [PATCH v2] i965: Disable auxiliary buffers when there are self-dependencies.

2017-10-07 Thread Kenneth Graunke
On Friday, October 6, 2017 10:25:50 PM PDT Kenneth Graunke wrote: > On Friday, October 6, 2017 8:09:33 PM PDT Jason Ekstrand wrote: > > On October 6, 2017 8:00:04 PM Kenneth Graunke wrote: [snip] > > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > > > b/src/mesa/drivers/dri/i965/in

Re: [Mesa-dev] [PATCH] anv/wsi: Allocate enough memory for the entire image

2017-10-07 Thread Lionel Landwerlin
On 07/10/17 23:23, Jason Ekstrand wrote: On Sat, Oct 7, 2017 at 3:10 PM, Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: On 07/10/17 22:44, Jason Ekstrand wrote: Previously, we allocated memory for image->plane[0].surface.isl.si ze

Re: [Mesa-dev] [PATCH] anv/wsi: Allocate enough memory for the entire image

2017-10-07 Thread Jason Ekstrand
On Sat, Oct 7, 2017 at 3:23 PM, Jason Ekstrand wrote: > On Sat, Oct 7, 2017 at 3:10 PM, Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> On 07/10/17 22:44, Jason Ekstrand wrote: >> >>> Previously, we allocated memory for image->plane[0].surface.isl.size >>> which is great if there

[Mesa-dev] [PATCH 7/7] amd: move r600d_common.h into r600g

2017-10-07 Thread Marek Olšák
From: Marek Olšák --- src/amd/Makefile.sources | 1 - src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/radv_cs.h | 14 +-- src/amd/vulkan/radv_formats.c | 29 +++--- src/am

[Mesa-dev] [PATCH 2/7] radeonsi: add si_so_target_reference

2017-10-07 Thread Marek Olšák
From: Marek Olšák The src type is different on purpose. --- src/gallium/drivers/radeonsi/si_state_streamout.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_streamout.c b/src/gallium/drivers/radeonsi/si_state_streamout.c inde

[Mesa-dev] [PATCH 4/7] radeonsi: remove r600_emit_reloc

2017-10-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_cs.h | 15 --- src/gallium/drivers/radeon/r600_pipe_common.c | 7 --- src/gallium/drivers/radeon/r600_query.c | 12 ++-- src/gallium/drivers/radeonsi/si_state_streamout.c | 12

[Mesa-dev] [PATCH 6/7] radeonsi: shrink r600d_common.h and stop using it

2017-10-07 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/r600d_common.h | 165 -- src/amd/common/sid.h | 17 +++ src/amd/vulkan/radv_cmd_buffer.c | 6 +- src/amd/vulkan/radv_pipeline.c| 6 +- src/amd/vulka

[Mesa-dev] [PATCH 3/7] radeonsi: merge si_set_streamout_targets with si_common_set_streamout_targets

2017-10-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 114 - src/gallium/drivers/radeonsi/si_state.h | 4 - src/gallium/drivers/radeonsi/si_state_streamout.c | 117 -- 3 files changed, 109 insertions(+), 126 deletions(-) di

[Mesa-dev] [PATCH 5/7] radeonsi: import cayman_msaa.c from drivers/radeon

2017-10-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/Makefile.sources | 1 - src/gallium/drivers/radeon/cayman_msaa.c | 269 -- src/gallium/drivers/radeon/r600_pipe_common.c | 1 - src/gallium/drivers/radeon/r600_pipe_common.h | 25 --- src/gallium/drivers/radeons

[Mesa-dev] [PATCH 1/7] radeonsi: import r600_streamout from drivers/radeon

2017-10-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/Makefile.sources| 1 - src/gallium/drivers/radeon/r600_pipe_common.c | 12 -- src/gallium/drivers/radeon/r600_pipe_common.h | 57 --- src/gallium/drivers/radeon/r600_query.c| 4 + src/gallium/drivers/radeons

Re: [Mesa-dev] [PATCH] anv/wsi: Allocate enough memory for the entire image

2017-10-07 Thread Jason Ekstrand
On Sat, Oct 7, 2017 at 3:10 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 07/10/17 22:44, Jason Ekstrand wrote: > >> Previously, we allocated memory for image->plane[0].surface.isl.size >> which is great if there is no compression. However, on BDW, we can do >> CCS_D on X-til

Re: [Mesa-dev] [PATCH] anv/wsi: Allocate enough memory for the entire image

2017-10-07 Thread Lionel Landwerlin
On 07/10/17 22:44, Jason Ekstrand wrote: Previously, we allocated memory for image->plane[0].surface.isl.size which is great if there is no compression. However, on BDW, we can do CCS_D on X-tiled images so we also have to allocate space for the auxiliary buffer. This fixes hangs in some of the

Re: [Mesa-dev] [PATCH] anv: fix nir.h include

2017-10-07 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Lionel Landwerlin (2017-10-07 11:33:23) > All over mesa we include "nir/nir.h", we should probably do the same > here. This fixes the meson build that was broken by the ycbcr series. > > Thanks to Dylan for finding the issue. > > Signed-off-by: Lionel Landwerlin

[Mesa-dev] [PATCH] anv/wsi: Allocate enough memory for the entire image

2017-10-07 Thread Jason Ekstrand
Previously, we allocated memory for image->plane[0].surface.isl.size which is great if there is no compression. However, on BDW, we can do CCS_D on X-tiled images so we also have to allocate space for the auxiliary buffer. This fixes hangs in some of the WSI CTS tests and should also reduce hangs

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Make _mesa_get_format_bytes handle array formats.

2017-10-07 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand That said, given that I typed it into IRC last night, maybe we should get another review? On October 7, 2017 1:42:50 PM Kenneth Graunke wrote: This is easier than making callers handle a bunch of special cases. Suggested-by: Jason Ekstrand --- src/mesa/main/

[Mesa-dev] [Bug 103140] [OpenGL CTS] KHR-GL45.enhanced_layouts.varying_location_aliasing_* fails

2017-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103140 Bug ID: 103140 Summary: [OpenGL CTS] KHR-GL45.enhanced_layouts.varying_location_aliasing_* fails Product: Mesa Version: git Hardware: Other

[Mesa-dev] [PATCH v2 2/2] main/format: skip format conversion if src and dst format are equal

2017-10-07 Thread Kenneth Graunke
From: Karol Herbst Fixes 'KHR-GL45.copy_image.functional' on Nouveau and i965. v2: (by Kenneth Graunke) Rewrite patch according to Jason Ekstrand's review feedback. This makes it handle differing strides, which i965 needed. Signed-off-by: Karol Herbst --- src/mesa/main/format_utils.c

[Mesa-dev] [PATCH v2 1/2] mesa: Make _mesa_get_format_bytes handle array formats.

2017-10-07 Thread Kenneth Graunke
This is easier than making callers handle a bunch of special cases. Suggested-by: Jason Ekstrand --- src/mesa/main/formats.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c index ecdfd561035..ac4ac23c03f 100644 --- a/src/mesa/main/format

Re: [Mesa-dev] [PATCH] mesa: Use immutable level count in FramebufferTexture error check.

2017-10-07 Thread Kenneth Graunke
On Saturday, October 7, 2017 6:30:38 AM PDT Ilia Mirkin wrote: > Hi Ken, > > Have a look at > > https://patchwork.freedesktop.org/patch/134865/ > https://patchwork.freedesktop.org/patch/135410/ > > No idea what the outcome of that was. I guess some code reorg has > happened since too. If, after

Re: [Mesa-dev] [PATCH] anv: fix nir.h include

2017-10-07 Thread Jason Ekstrand
Rb On October 7, 2017 11:34:10 AM Lionel Landwerlin wrote: All over mesa we include "nir/nir.h", we should probably do the same here. This fixes the meson build that was broken by the ycbcr series. Thanks to Dylan for finding the issue. Signed-off-by: Lionel Landwerlin Fixes: f3e91e78a33

Re: [Mesa-dev] How to build 32-bit Mesa

2017-10-07 Thread Marek Olšák
Thank you very much. These two fixed my build: export CC="gcc -m32" export CXX="g++ -m32" I used USER_CFLAGS to set -m32, which didn't work. Marek On Sat, Oct 7, 2017 at 8:09 PM, Laurent Carlier wrote: > Le samedi 7 octobre 2017, 19:53:48 CEST Marek Olšák a écrit : >> Hi, >> >> Recently I disc

Re: [Mesa-dev] [PATCH v2] i965: Disable auxiliary buffers when there are self-dependencies.

2017-10-07 Thread Jason Ekstrand
On Sat, Oct 7, 2017 at 11:42 AM, Kenneth Graunke wrote: > On Saturday, October 7, 2017 8:03:54 AM PDT Jason Ekstrand wrote: > > On October 6, 2017 10:25:55 PM Kenneth Graunke > wrote: > > > > > On Friday, October 6, 2017 8:09:33 PM PDT Jason Ekstrand wrote: > > >> On October 6, 2017 8:00:04 PM K

[Mesa-dev] [PATCH] radeonsi: add performance thresholds for CP DMA, decrease it for clears

2017-10-07 Thread Marek Olšák
From: Marek Olšák The first one isn't used yet. --- src/gallium/drivers/radeonsi/si_cp_dma.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_cp_dma.c b/src/gallium/drivers/radeonsi/si_cp_dma.c index 064f6c0..97adc27 100644 --- a/src/gal

Re: [Mesa-dev] [PATCH v2] i965: Disable auxiliary buffers when there are self-dependencies.

2017-10-07 Thread Kenneth Graunke
On Saturday, October 7, 2017 8:03:54 AM PDT Jason Ekstrand wrote: > On October 6, 2017 10:25:55 PM Kenneth Graunke wrote: > > > On Friday, October 6, 2017 8:09:33 PM PDT Jason Ekstrand wrote: > >> On October 6, 2017 8:00:04 PM Kenneth Graunke > >> wrote: > >> > diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH] anv: fix nir.h include

2017-10-07 Thread Lionel Landwerlin
All over mesa we include "nir/nir.h", we should probably do the same here. This fixes the meson build that was broken by the ycbcr series. Thanks to Dylan for finding the issue. Signed-off-by: Lionel Landwerlin Fixes: f3e91e78a337 ("anv: add nir lowering pass for ycbcr textures") Cc: Dylan Baker

Re: [Mesa-dev] [PATCH] meson: Include nir directories in anv_common

2017-10-07 Thread Lionel Landwerlin
Looks like pretty much everywhere we're include nir/nir.h So I guess I should fix the ycbcr pass. Thanks for digging this though! On 07/10/17 18:15, Dylan Baker wrote: Signed-off-by: Dylan Baker Fixes: f3e91e78a337 ("anv: add nir lowering pass for ycbcr textures") cc: Lionel Landwerlin ---

Re: [Mesa-dev] How to build 32-bit Mesa

2017-10-07 Thread Laurent Carlier
Le samedi 7 octobre 2017, 19:53:48 CEST Marek Olšák a écrit : > Hi, > > Recently I discovered that my configure hacks are not enough to build > 32-bit Mesa successfully anymore. > > Would you please share how you build 32-bit Mesa on Linux. I think it > would be useful to everybody. > > Thanks,

[Mesa-dev] How to build 32-bit Mesa

2017-10-07 Thread Marek Olšák
Hi, Recently I discovered that my configure hacks are not enough to build 32-bit Mesa successfully anymore. Would you please share how you build 32-bit Mesa on Linux. I think it would be useful to everybody. Thanks, Marek ___ mesa-dev mailing list mesa

[Mesa-dev] [PATCH] editorconfig: Add meson configuration

2017-10-07 Thread Dylan Baker
Signed-off-by: Dylan Baker --- .editorconfig | 4 1 file changed, 4 insertions(+) diff --git a/.editorconfig b/.editorconfig index 6eb0702a25a..06848f68c08 100644 --- a/.editorconfig +++ b/.editorconfig @@ -33,3 +33,7 @@ indent_size = 2 [*.patch] trim_trailing_whitespace = false + +[mes

Re: [Mesa-dev] [PATCH v3 07/12] meson: build glx

2017-10-07 Thread Dylan Baker
I looked at what autotools generates in it's make files and output and matches that with what meson is generating now. Does this look good to you? It's the last patch waiting for review in the series. Dylan Quoting Dylan Baker (2017-10-05 14:27:33) > This gets GLX and the loader building. The res

Re: [Mesa-dev] [PATCH 2/2] st/va: Implement vaExportSurfaceHandle()

2017-10-07 Thread Mark Thompson
On 07/10/17 15:23, Leo Liu wrote: > On 2017-10-01 01:40 PM, Mark Thompson wrote: >> This is a new interface in libva2 to support wider use-cases of passing >> surfaces to external APIs.  In particular, this allows export of NV12 and >> P010 surfaces. >> >> v2: Convert surfaces to progressive before

[Mesa-dev] [PATCH] meson: Include nir directories in anv_common

2017-10-07 Thread Dylan Baker
Signed-off-by: Dylan Baker Fixes: f3e91e78a337 ("anv: add nir lowering pass for ycbcr textures") cc: Lionel Landwerlin --- src/intel/vulkan/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build index ff24e304ef

Re: [Mesa-dev] [PATCH] i965: Don't try to decode types for non-existent src1.

2017-10-07 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 07/10/17 15:37, Kenneth Graunke wrote: > KHR-GL45.shader_ballot_tests.ShaderBallotBitmasks has a MOV that hits > this validation path. MOVs don't have a src1 file, but calling > brw_inst_src1_type() was tripping on src1.file being BRW_IMMEDIATE_VALUE > and the h

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive binning on Vega10 (v2)

2017-10-07 Thread Marek Olšák
On Sat, Oct 7, 2017 at 6:19 PM, Marek Olšák wrote: > From: Marek Olšák > > Our driver implementation is known to decrease performance for some tests, > but we don't know if any apps and benchmarks (e.g. those tested by Phoronix) > are affected. This disables the feature just to be safe. > > Set t

[Mesa-dev] [PATCH 1/2] radeonsi: enumerize DBG flags

2017-10-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c| 6 +- src/gallium/drivers/radeon/r600_pipe_common.c | 99 +-- src/gallium/drivers/radeon/r600_pipe_common.h | 110 - src/gallium/drivers/radeon/r600_texture.c | 1

[Mesa-dev] [PATCH 2/2] radeonsi: disable primitive binning on Vega10 (v2)

2017-10-07 Thread Marek Olšák
From: Marek Olšák Our driver implementation is known to decrease performance for some tests, but we don't know if any apps and benchmarks (e.g. those tested by Phoronix) are affected. This disables the feature just to be safe. Set this to enable partial primitive binning: R600_DEBUG=dpbb Set

Re: [Mesa-dev] [PATCH 3/3] radv: configure VGT_VERTEX_REUSE at pipeline creation

2017-10-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Fri, Oct 6, 2017 at 9:53 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 18 -- > src/amd/vulkan/radv_pipeline.c | 7 +++ > src/amd/vulkan/radv_private.h| 1 + >

Re: [Mesa-dev] [PATCH] radeonsi: disable primitive binning on Vega10

2017-10-07 Thread Marek Olšák
On Sat, Oct 7, 2017 at 10:58 AM, Nicolai Hähnle wrote: > On 06.10.2017 15:49, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Our driver implementation is known to decrease performance for some tests, >> but we don't know if any apps and benchmarks (especially those tested by >> Phoronix) are af

Re: [Mesa-dev] [PATCH v2] i965: Disable auxiliary buffers when there are self-dependencies.

2017-10-07 Thread Jason Ekstrand
On October 6, 2017 10:25:55 PM Kenneth Graunke wrote: On Friday, October 6, 2017 8:09:33 PM PDT Jason Ekstrand wrote: On October 6, 2017 8:00:04 PM Kenneth Graunke wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c > b/src/mesa/drivers/dri/i965/brw_draw.c > index c7ed7284501..fcb194db

Re: [Mesa-dev] [PATCH 2/2] st/va: Implement vaExportSurfaceHandle()

2017-10-07 Thread Leo Liu
On 2017-10-01 01:40 PM, Mark Thompson wrote: This is a new interface in libva2 to support wider use-cases of passing surfaces to external APIs. In particular, this allows export of NV12 and P010 surfaces. v2: Convert surfaces to progressive before exporting them (Christian). v3: Set destinat

[Mesa-dev] [PATCH] i965: Don't try to decode types for non-existent src1.

2017-10-07 Thread Kenneth Graunke
KHR-GL45.shader_ballot_tests.ShaderBallotBitmasks has a MOV that hits this validation path. MOVs don't have a src1 file, but calling brw_inst_src1_type() was tripping on src1.file being BRW_IMMEDIATE_VALUE and the hw_type being something invalid for immediates. To work around this, just pretend s

[Mesa-dev] [Bug 102677] [OpenGL CTS] KHR-GL45.CommonBugs.CommonBug_PerVertexValidation fails

2017-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102677 --- Comment #2 from Kenneth Graunke --- Oh, Eduardo sent patches to fix this back in January: https://lists.freedesktop.org/archives/mesa-dev/2017-January/142386.html Khronos made it pretty clear this test is valid: https://gitlab.khronos.org/

Re: [Mesa-dev] [PATCH] mesa: Use immutable level count in FramebufferTexture error check.

2017-10-07 Thread Ilia Mirkin
Hi Ken, Have a look at https://patchwork.freedesktop.org/patch/134865/ https://patchwork.freedesktop.org/patch/135410/ No idea what the outcome of that was. I guess some code reorg has happened since too. If, after reading through those, you think this is right - go ahead :) I've lost all contex

Re: [Mesa-dev] [PATCH] radv: export KHR_relaxed_block_layout

2017-10-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Oct 6, 2017 at 3:29 AM, Dave Airlie wrote: > From: Dave Airlie > > This seems to pass all the cts tests it enables. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_device.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/amd/v

Re: [Mesa-dev] [PATCH 2/2] radv: set ALPHA_TO_MASK_ENABLE at blend state init

2017-10-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Fri, Oct 6, 2017 at 3:39 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/amd/vulkan/radv_pipeline.c

Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-07 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen if you remove the (same as Vulkan) bit. On Fri, Oct 6, 2017 at 4:03 PM, Samuel Pitoiset wrote: > Ported from RadeonSI, and -pro seems to enable it as well. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 11 ++- > 1 file cha

Re: [Mesa-dev] [PATCH 00/12] RadeonSI: 3D clears and blits w/out VBOs and viewport state

2017-10-07 Thread Nicolai Hähnle
On 06.10.2017 16:10, Marek Olšák wrote: Hi, There are 3 states that blits don't have to use or touch: - vertex buffers (also no buffer upload is needed) - vertex element state - viewport state The blit implementation is reworked as follows. VS blit shaders read inputs from user SGPRs and retur

Re: [Mesa-dev] [PATCH 5/5] mesa: Implement a new GL_MESA_tile_raster_order extension.

2017-10-07 Thread Nicolai Hähnle
Patches 1 & 2: Acked-by: Nicolai Hähnle Patches 4 & 5: Reviewed-by: Nicolai Hähnle (for the gallium parts; it would have been nice to split patch 4 up into gallium and driver parts, but I won't insist) On 05.10.2017 20:08, Eric Anholt wrote: The intent is to use this extension on vc4 to a

Re: [Mesa-dev] [PATCH] radv: allow launching waves out-of-order for compute

2017-10-07 Thread Nicolai Hähnle
On 06.10.2017 16:03, Samuel Pitoiset wrote: Ported from RadeonSI, and -pro seems to enable it as well. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/am

Re: [Mesa-dev] [PATCH] radeonsi: disable primitive binning on Vega10

2017-10-07 Thread Nicolai Hähnle
On 06.10.2017 15:49, Marek Olšák wrote: From: Marek Olšák Our driver implementation is known to decrease performance for some tests, but we don't know if any apps and benchmarks (especially those tested by Phoronix) are affected. This disables the feature just to be safe. The debug flags are i

Re: [Mesa-dev] [PATCH 2/3] gallium/radeon: remove r600_atom::num_dw

2017-10-07 Thread Nicolai Hähnle
Okay, so my comment on patch #1 is irrelevant, makes sense. For the series: Reviewed-by: Nicolai Hähnle On 06.10.2017 15:49, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h| 2 -- src/gallium/drivers/radeon/r600_query.c | 15 --

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove old r600g code checking chip_class and family

2017-10-07 Thread Nicolai Hähnle
On 06.10.2017 15:49, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 99 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 20 -- src/gallium/drivers/radeon/r600_query.c | 31 +++-- src/gallium/drivers/radeon/

Re: [Mesa-dev] [PATCH] mesa: Use immutable level count in FramebufferTexture error check.

2017-10-07 Thread Nicolai Hähnle
On 07.10.2017 09:05, Kenneth Graunke wrote: This offers a more accurate bound. .. and it's what the spec mandates :) Reviewed-by: Nicolai Hähnle Fixes KHR-GL45.geometry_shader.layered_fbo.fb_texture_invalid_level_number. --- src/mesa/main/fbobject.c | 14 -- 1 file changed,

Re: [Mesa-dev] [PATCH 6/6] mesa: Set new renderbuffers to RGBA4 on all GLES contexts.

2017-10-07 Thread Nicolai Hähnle
I sent one comment on patch #1. Apart from that, patches 1, 2, and 4-6 are: Reviewed-by: Nicolai Hähnle On 17.08.2017 18:10, Eric Anholt wrote: Before we were doing RGBA4 on GLES3 only, but as of GLES2 2.0.22 it should be RGBA4 as well. Fixes DEQP functional.state_query.rbo.renderbuffer_inte

Re: [Mesa-dev] [PATCH 1/6] mesa: Add X1B5G5R5 along with A1B5G5R5.

2017-10-07 Thread Nicolai Hähnle
On 17.08.2017 18:10, Eric Anholt wrote: For supporting RGB5 in hardware with A in the low bit (vc4), we need this format as well. --- src/mesa/main/formats.c | 2 ++ src/mesa/main/formats.csv| 1 + src/mesa/main/formats.h | 1 + src/mesa/main/texformat.c| 1 + src/mesa/swr

[Mesa-dev] [PATCH] mesa: Use immutable level count in FramebufferTexture error check.

2017-10-07 Thread Kenneth Graunke
This offers a more accurate bound. Fixes KHR-GL45.geometry_shader.layered_fbo.fb_texture_invalid_level_number. --- src/mesa/main/fbobject.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 0867ff70fa7..e11

[Mesa-dev] [Bug 102677] [OpenGL CTS] KHR-GL45.CommonBugs.CommonBug_PerVertexValidation fails

2017-10-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102677 --- Comment #1 from Kenneth Graunke --- In the failing case, a VS and GS are being linked together into a single program. The vertex shader contains: out gl_PerVertex { vec4 gl_Position; }; while the geometry shader contai