Re: [Mesa-dev] [PATCH v2 3/4] i965: Pass the EGL/DRI context priority through to the kernel

2017-09-28 Thread Kenneth Graunke
On Tuesday, April 11, 2017 9:11:56 AM PDT Chris Wilson wrote: > Decode the EGL/DRI priority enum into the [-1023, 1023] range as > interpreted by the kernel and call DRM_I915_GEM_CONTEXT_SETPARAM to > adjust the priority. We use 0 as the default medium priority (also the > kernel default) and so on

Re: [Mesa-dev] [PATCH v3] egl: Support IMG_context_priority

2017-09-28 Thread Kenneth Graunke
On Wednesday, April 12, 2017 3:11:53 AM PDT Chris Wilson wrote: > IMG_context_priority > https://www.khronos.org/registry/egl/extensions/IMG/EGL_IMG_context_priority.txt > > "This extension allows an EGLContext to be created with a priority > hint. It is possible that an implementation wil

Re: [Mesa-dev] [PATCH v3] i965/fs: force pull model for 64-bit GS inputs

2017-09-28 Thread Iago Toral
On Thu, 2017-09-28 at 21:19 -0700, Kenneth Graunke wrote: > On Thursday, September 28, 2017 1:24:21 AM PDT Iago Toral Quiroga > wrote: > > Triggering the push model when 64-bit inputs are involved is not > > easy due to > > the constrains on the maximum number of registers that we allow for > > thi

[Mesa-dev] [PATCH 08/12] i965: Remove validate_reg()

2017-09-28 Thread Matt Turner
Replaced by the assembly validator, and in fact gets in the way of writing tests for the assembly validator. --- src/intel/compiler/brw_eu_emit.c | 80 1 file changed, 80 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_e

[Mesa-dev] [PATCH 09/12] i965: Avoid validation error when src1 is not present

2017-09-28 Thread Matt Turner
There can be no violation of the restriction that source offsets are aligned if there is only one source offset. --- src/intel/compiler/brw_eu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c

[Mesa-dev] [PATCH 11/12] i965: Fix and enable forgotten validation test

2017-09-28 Thread Matt Turner
I seem to have forgotten I still had work to do. --- src/intel/compiler/test_eu_validate.cpp | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/src/intel/compiler/test_eu_validate.cpp b/src/intel/compiler/test_eu_validate.cpp index 3dd560074f..4e

[Mesa-dev] [PATCH 12/12] i965: Validate "Special Requirements for Handling Double Precision Data Types"

2017-09-28 Thread Matt Turner
I did not implement: CNL's restriction on 64-bit int + align16, because I don't think we'll ever use this combination regardless of hardware generation. The restriction on immediate DF -> F conversions, because there's no reason to ever generate that, and I don't even know how DF -> F

[Mesa-dev] [PATCH 05/12] i965: Add GLK, CFL, CNL to test_eu_validate.c

2017-09-28 Thread Matt Turner
--- src/intel/compiler/test_eu_validate.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/compiler/test_eu_validate.cpp b/src/intel/compiler/test_eu_validate.cpp index 46d2b83e34..3dd560074f 100644 --- a/src/intel/compiler/test_eu_validate.cpp +++ b/src/intel/compiler/test_

[Mesa-dev] [PATCH 04/12] i965: Add Atom graphics names to parse_devid_override()

2017-09-28 Thread Matt Turner
--- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index bd1365f232..10253eb5a4 100644 --- a/src/mesa/drivers/dri/i965/intel_screen.c +++ b/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 02/12] i965/fs: Rewrite fsign64 to skip the float -> double conversion

2017-09-28 Thread Matt Turner
... without the float -> double conversion. Low power parts have additional restrictions when it comes to operating on 64-bit types, and the instruction used to do the conversion violates one of them: specifically, the restriction that "Source and Destination horizontal stride must be aligned to th

[Mesa-dev] [PATCH 03/12] i965: Fix support for disassembling 64-bit integer immediates

2017-09-28 Thread Matt Turner
The type suffixes were wrong, and the 16 was missing the 0 prefix. Fixes: 92f787ff86ab ("i965: Add support for disassembling 64-bit integer immediates") --- src/intel/compiler/brw_disasm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/compiler/brw_disasm.c b/s

[Mesa-dev] [PATCH 06/12] i965: Add parentheses around usage of macro arguments

2017-09-28 Thread Matt Turner
Otherwise I cannot use this macro in test_eu_validate.cpp --- src/intel/common/gen_device_info.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/gen_device_info.h b/src/intel/common/gen_device_info.h index ede4915e28..59b345e949 100644 --- a/src/intel/common/g

[Mesa-dev] [PATCH 10/12] i965: Only insert error message if not already present

2017-09-28 Thread Matt Turner
Some restrictions require something like strides to match between src and dest. For multi-source instructions, I'd rather encapsulate the logic for not inserting already present errors in ERROR_IF than open-coding it multiple places. --- src/intel/compiler/brw_eu_validate.c | 18 +-

[Mesa-dev] [PATCH 01/12] i965/fs: Unpack count argument to 64-bit shift ops on Atom

2017-09-28 Thread Matt Turner
64-bit operations on Atom parts have additional restrictions over their big-core counterparts (validated by later patches). Specifically, the restriction that "Source and Destination horizontal stride must be aligned to the same qword" is violated by most shift operations since NIR uses a 32-bit v

[Mesa-dev] [PATCH 07/12] i965: Add and use STRIDE and WIDTH macros

2017-09-28 Thread Matt Turner
You'll notice there were bugs in some of the code being replaced. --- src/intel/compiler/brw_eu_validate.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c index 7453

Re: [Mesa-dev] [PATCH v2] i965: skip reading clip distances from the URB for the FS if possible

2017-09-28 Thread Iago Toral
On Thu, 2017-09-28 at 21:55 -0700, Kenneth Graunke wrote: > On Thursday, September 28, 2017 3:33:12 AM PDT Iago Toral Quiroga > wrote: > > we can skip these slots when they are not read in the fragment > > shader > > and they are positioned right after a VUE header that we are > > already > > skipp

Re: [Mesa-dev] [PATCH v2] i965: skip reading clip distances from the URB for the FS if possible

2017-09-28 Thread Kenneth Graunke
On Thursday, September 28, 2017 3:33:12 AM PDT Iago Toral Quiroga wrote: > we can skip these slots when they are not read in the fragment shader > and they are positioned right after a VUE header that we are already > skipping. We also need to ensure that we are passing at least one other > varying

Re: [Mesa-dev] [PATCH v3] i965/fs: force pull model for 64-bit GS inputs

2017-09-28 Thread Kenneth Graunke
On Thursday, September 28, 2017 1:24:21 AM PDT Iago Toral Quiroga wrote: > Triggering the push model when 64-bit inputs are involved is not easy due to > the constrains on the maximum number of registers that we allow for this mode, > however, for GS with 'points' primitive type and just a couple o

Re: [Mesa-dev] [PATCH 10/12] intel/blorp: Handle clearing compressed surfaces

2017-09-28 Thread Matt Turner
On Fri, Sep 15, 2017 at 9:01 AM, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_clear.c | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c > index 0feebef..e8b1e32 100644 > --- a/src

Re: [Mesa-dev] [PATCH 2/3] st/va: Implement vaExportSurfaceHandle()

2017-09-28 Thread Leo Liu
On 2017-09-28 06:12 PM, Mark Thompson wrote: This is a new interface in libva2 to support wider use-cases of passing surfaces to external APIs. In particular, this allows export of NV12 and P010 surfaces. Signed-off-by: Mark Thompson --- On 22/09/17 10:17, Christian König wrote: Am 21.09.20

[Mesa-dev] [PATCH] st/va: add dst rect to avoid scale on deint

2017-09-28 Thread Leo Liu
For 1080p video transcode, the height will be scaled to 1088 when deint to progressive buffer. Set dst rect to make sure no scale. Fixes: 3ad8687 "st/va: use new vl_compositor_yuv_deint_full() to deint" Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 12 ++-- 1 file

Re: [Mesa-dev] [PATCH] amdgpu/soc15: make the pcie index/data registers constant.

2017-09-28 Thread Dave Airlie
Please ignore, ran wrong script :-) Dave. On 29 September 2017 at 10:08, Dave Airlie wrote: > From: Dave Airlie > > These don't seem to change at runtime, and the initialisers > are constant data. This could be improved by not selecting > the apu/non-apu path on each pcie read/write access. > >

Re: [Mesa-dev] [PATCH 2/2] anv: fix potential push constant buffer leaks

2017-09-28 Thread Lionel Landwerlin
On 29/09/17 01:05, Lionel Landwerlin wrote: Valgrind stats on dEQP-VK.pipeline.push_constant.graphics_pipeline.range_size_128 : I obviously inverted before & after... Before: HEAP SUMMARY: in use at exit: 2,467,381 bytes in 1,304 blocks total heap usage: 697,853 allocs, 696,531 frees,

[Mesa-dev] [PATCH] amdgpu/soc15: make the pcie index/data registers constant.

2017-09-28 Thread Dave Airlie
From: Dave Airlie These don't seem to change at runtime, and the initialisers are constant data. This could be improved by not selecting the apu/non-apu path on each pcie read/write access. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 8 drivers/gpu/drm/amd/

[Mesa-dev] [PATCH 1/2] anv: fix push descriptors with set > 0

2017-09-28 Thread Lionel Landwerlin
When writing to set > 0, we were just wrongly writing to set 0. This commit fixes this by lazily allocating each set as we write to them. We didn't go for having them directly into the command buffer as this would require an additional ~45Kb per command buffer. v2: Allocate push descriptors from

[Mesa-dev] [PATCH 2/2] anv: fix potential push constant buffer leaks

2017-09-28 Thread Lionel Landwerlin
Valgrind stats on dEQP-VK.pipeline.push_constant.graphics_pipeline.range_size_128 : Before: HEAP SUMMARY: in use at exit: 2,467,381 bytes in 1,304 blocks total heap usage: 697,853 allocs, 696,531 frees, 138,466,600 bytes allocated LEAK SUMMARY: definitely lost: 936 bytes in 10 blocks

Re: [Mesa-dev] [PATCH 3/3] Revert "gallium/radeon: consolidate PIPE_BIND_SHARED/SCANOUT handling"

2017-09-28 Thread Andy Furniss
Mark Thompson wrote: This reverts commit f70f6baaa3bb0f8b280ac2eaea69bbffaf7de840. I just bisected to this as it also breaks mpv --hwdec=vdpau --vo=opengl amdgpu: The CS has been rejected, see dmesg for more information (-22). amdgpu: The CS has been cancelled because the context is lost. [d

Re: [Mesa-dev] [PATCH 01/11] glsl/lower_instruction: handle denorms and overflow in ldexp correctly

2017-09-28 Thread Matt Turner
On Sat, Sep 16, 2017 at 4:23 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > GLSL ES requires both, and while GLSL explicitly doesn't require correct > overflow handling, it does appear to require handling input inf/denorms > correctly. > > Fixes dEQP-GLES31.functional.shaders.builtin_functi

Re: [Mesa-dev] [PATCH 00/11] glsl, tgsi, radeonsi: ldexp and frexp bug fixes and features

2017-09-28 Thread Matt Turner
On Thu, Sep 28, 2017 at 3:42 PM, Matt Turner wrote: > On Sat, Sep 16, 2017 at 4:23 AM, Nicolai Hähnle wrote: >> Hi all, >> >> This series was motivated by radeonsi failing some ldexp tests due to >> not handling denorms correctly and not handling overflows (which GLSL >> doesn't require, but GLSL

Re: [Mesa-dev] [PATCH 00/11] glsl, tgsi, radeonsi: ldexp and frexp bug fixes and features

2017-09-28 Thread Matt Turner
On Sat, Sep 16, 2017 at 4:23 AM, Nicolai Hähnle wrote: > Hi all, > > This series was motivated by radeonsi failing some ldexp tests due to > not handling denorms correctly and not handling overflows (which GLSL > doesn't require, but GLSL ES does). > > The first patch fixes the GLSL IR lowering of

[Mesa-dev] [PATCH 3/3] Revert "gallium/radeon: consolidate PIPE_BIND_SHARED/SCANOUT handling"

2017-09-28 Thread Mark Thompson
This reverts commit f70f6baaa3bb0f8b280ac2eaea69bbffaf7de840. --- This commit broke VAAPI surface export (found by bisection). I think the observed behaviour with playback is consistent with surfaces not being updated some of the time, so something to do with sharing? I tried setting PIPE_BIND

[Mesa-dev] [PATCH 2/3] st/va: Implement vaExportSurfaceHandle()

2017-09-28 Thread Mark Thompson
This is a new interface in libva2 to support wider use-cases of passing surfaces to external APIs. In particular, this allows export of NV12 and P010 surfaces. Signed-off-by: Mark Thompson --- On 22/09/17 10:17, Christian König wrote: > Am 21.09.2017 um 21:00 schrieb Mark Thompson: >> On 20/09/1

[Mesa-dev] [PATCH 1/3] st/dri: Add definitions to allow importing 16-bit surfaces

2017-09-28 Thread Mark Thompson
Necessary to support P010/P016 surfaces for video. Signed-off-by: Mark Thompson --- src/gallium/state_trackers/dri/dri2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index 8672174787..2aa3ba52f

Re: [Mesa-dev] [PATCH mesa] REVIEWERS: add Meson

2017-09-28 Thread Dylan Baker
I don't have access to my Intel email except when physically at work, I'd prefer to use dy...@pnwbakers.com Otherwise I probably am the guy to look at meson, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-09-28 05:37:02) > Cc: Dylan Baker > Signed-off-by: Eric Engestrom > --- > REVIEWE

Re: [Mesa-dev] MESA and KOTOR

2017-09-28 Thread Federico Dossena
Sorry if I insist on this again, but can someone who knows the internals of Mesa better than me please tell me which files implement pbuffers in gallium llvmpipe? Specifically, the parts that are involved in creating a pbuffer, its texture, framebuffer, and (I think) copying the screen to it. I

Re: [Mesa-dev] [PATCH 2/2] r600: cleanup set_occlusion_query_state

2017-09-28 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Sep 28, 2017 at 9:55 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes a warning caused by the fork (note the change in the function > signature): > > ../../../../../mesa-src/src/gallium/drivers/r600/r600_state_common.c: In

[Mesa-dev] [PATCH 1/2] r300: add missing case PIPE_SHADER_CAP_INT64_ATOMICS

2017-09-28 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/r300/r300_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c index f41d09d263f..0c3e097535d 100644 --- a/src/gallium/drivers/r300/r300_screen.c +++ b/src/galliu

[Mesa-dev] [PATCH 2/2] r600: cleanup set_occlusion_query_state

2017-09-28 Thread Nicolai Hähnle
From: Nicolai Hähnle This fixes a warning caused by the fork (note the change in the function signature): ../../../../../mesa-src/src/gallium/drivers/r600/r600_state_common.c: In function ‘r600_init_common_state_functions’: ../../../../../mesa-src/src/gallium/drivers/r600/r600_state_common.c:29

Re: [Mesa-dev] [PATCH 1/4] gallivm: fix typo in debug_printf message

2017-09-28 Thread Roland Scheidegger
Am 28.09.2017 um 20:09 schrieb Ben Crocker: > In gallivm_compile_module, fix a typo in the > debug_printf("Invoke as \"llc ..." message. > > Cc: "17.2" > > Signed-off-by: Ben Crocker > --- > src/gallium/auxiliary/gallivm/lp_bld_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Mesa-dev] [Bug 103031] [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0

2017-09-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103031 --- Comment #1 from Roland Scheidegger --- Created attachment 134554 --> https://bugs.freedesktop.org/attachment.cgi?id=134554&action=edit patch accounting for llvm nuked pabs intrinsics Does this patch work? I'm also changing the non-intrins

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] radeonsi: workaround for gather4 on integer cube maps

2017-09-28 Thread Nicolai Hähnle
On 28.09.2017 20:28, Marek Olšák wrote: This breaks GL45-CTS.texture_gather.plain-gather-int-cube-array, but my CTS is very old. Did you test your CTS? You're right, this regressed. I was looking only at the Raven results, where there's no regression. I'll look into it. Cheers, Nicolai

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Gustaw Smolarczyk
2017-09-28 20:21 GMT+02:00 Nicolai Hähnle : > On 28.09.2017 19:18, Gustaw Smolarczyk wrote: >> >> 2017-09-28 18:52 GMT+02:00 Marek Olšák : >>> >>> A clearer comment would be: "Don't destroy the fence when it's in the >>> middle of util_queue_fence_signal (signalled but not unlocked yet >>> because

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] radeonsi: workaround for gather4 on integer cube maps

2017-09-28 Thread Marek Olšák
This breaks GL45-CTS.texture_gather.plain-gather-int-cube-array, but my CTS is very old. Did you test your CTS? Marek On Wed, Sep 13, 2017 at 7:04 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is the same workaround that radv already applied in commit > 3ece76f03dc0 ("radv/ac: gath

Re: [Mesa-dev] [PATCH] gallium: add new LOD opcode

2017-09-28 Thread Roland Scheidegger
Am 28.09.2017 um 15:43 schrieb Jose Fonseca: > On 28/09/17 02:46, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The operation performed is all the same as LODQ, but with the usual >> differences between dx10 and GL texture opcodes, that is separate >> resource >> and sampler indices

[Mesa-dev] [Bug 103031] [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0

2017-09-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103031 Bug ID: 103031 Summary: [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Nicolai Hähnle
On 28.09.2017 18:37, Eric Engestrom wrote: On Thursday, 2017-09-28 16:10:51 +, Nicolai Hähnle wrote: From: Nicolai Hähnle A tempting alternative fix would be adding a lock/unlock pair in util_queue_fence_is_signalled. However, that wouldn't actually improve anything in the semantics of uti

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Nicolai Hähnle
On 28.09.2017 19:18, Gustaw Smolarczyk wrote: 2017-09-28 18:52 GMT+02:00 Marek Olšák : A clearer comment would be: "Don't destroy the fence when it's in the middle of util_queue_fence_signal (signalled but not unlocked yet because util_queue_fence_is_signalled doesn't lock). Instead, wait until

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

2017-09-28 Thread Roland Scheidegger
Am 28.09.2017 um 18:19 schrieb Jose Fonseca: > On 28/09/17 17:16, Roland Scheidegger wrote: >> Am 28.09.2017 um 17:53 schrieb Jose Fonseca: >>> On 28/09/17 16:29, Roland Scheidegger wrote: Am 28.09.2017 um 16:12 schrieb Jose Fonseca: > On 27/09/17 15:07, Roland Scheidegger wrote: >> Am

[Mesa-dev] [PATCH 2/4] gallivm: allow additional llc options

2017-09-28 Thread Ben Crocker
In init_native_targets, allow the passing of additional options to the LLC compiler via new GALLIVM_LLC_OPTIONS environmental control. This option is available only #ifdef DEBUG, initially. At top, add #include for LLVMParseCommandLineOptions() declaration. Cc: "17.2" Signed-off-by: Ben Crocker

[Mesa-dev] [PATCH 1/4] gallivm: fix typo in debug_printf message

2017-09-28 Thread Ben Crocker
In gallivm_compile_module, fix a typo in the debug_printf("Invoke as \"llc ..." message. Cc: "17.2" Signed-off-by: Ben Crocker --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src/

[Mesa-dev] [PATCH 3/4] gallivm/ppc64le: adjust VSX code generation control.

2017-09-28 Thread Ben Crocker
In lp_build_create_jit_compiler_for_module(), advance the minimum version of LLVM for VSX code generation to 4.0; this is the minimum revision at which several known VSX code generation bugs are fixed: https://llvm.org/bugs/show_bug.cgi?id=25503 (fixed in 3.8.1) https://llvm.org/bugs/show_bug.

[Mesa-dev] [PATCH 4/4] gallivm/ppc64le: allow environmental control of Altivec code generation

2017-09-28 Thread Ben Crocker
In check_os_altivec_support(), allow control of Altivec (first PPC vector instruction set) code generation via a new environmental control, GALLIVM_ALTIVEC, which is expected to take on a value of 1 or 0. The default is to enable Altivec code generation. This environmental control of Altivec code

[Mesa-dev] [PATCH 0/4] gallivm/ppc64le: advance LLVM min version for VSX codegen, add environmental controls

2017-09-28 Thread Ben Crocker
Advance the minimum LLVM version for VSX code generation to 4.0. New environmental controls: GALLIVM_LLC_OPTIONS GALLIVM_MATTRS GALLIVM_VSX 0/1, default=1 GALLIVM_ALTIVEC 0/1, default=1 Ben Crocker (4): gallivm: fix typo in debug_printf message gallivm: allow additional llc

Re: [Mesa-dev] initial meson port

2017-09-28 Thread Daniel Stone
Hi, Sorry for the top-post but the Gmail mobile app no longer believes in inline quoting. As for installing newer Meson, that's not strictly needed. As you say, Meson deliberately doesn't have difficult or changing dependencies. It can also be run straight from a checkout without mangling $PATH or

Re: [Mesa-dev] initial meson port

2017-09-28 Thread Dylan Baker
Quoting Tapani Pälli (2017-09-27 23:34:26) > > > On 09/27/2017 08:57 PM, Rob Herring wrote: > > On Wed, Sep 27, 2017 at 12:38 PM, Eric Anholt wrote: > >> Dylan Baker writes: > >> > >>> [ Unknown signature status ] > >>> I've gone ahead and pushed the Vulkan drivers meson builds. > >>> > >>> For

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Gustaw Smolarczyk
2017-09-28 18:52 GMT+02:00 Marek Olšák : > A clearer comment would be: "Don't destroy the fence when it's in the > middle of util_queue_fence_signal (signalled but not unlocked yet > because util_queue_fence_is_signalled doesn't lock). Instead, wait > until util_queue_fence_signal returns and then

Re: [Mesa-dev] [PATCH mesa] REVIEWERS: add Meson

2017-09-28 Thread Dylan Baker
I use my personal email for working with mailing lists (for a host of reasons), so with the email changed to , Reviewed-by: Dylan Baker I set my signoff's using my Intel address because management feels that that is sufficient to convey that I'm working on the behalf of Intel and not as an indep

Re: [Mesa-dev] [PATCH mesa] REVIEWERS: add Meson

2017-09-28 Thread Eric Engestrom
On Thursday, 2017-09-28 10:04:32 -0700, Dylan Baker wrote: > I don't have access to my Intel email except when physically at work, I'd > prefer > to use dy...@pnwbakers.com Done and pushed :) I also added myself as a reviewer, even though I'm not sure I'll be much help at first; I guess I'll be

Re: [Mesa-dev] [PATCH] gallium: add new LOD opcode

2017-09-28 Thread Marek Olšák
On Thu, Sep 28, 2017 at 3:43 PM, Jose Fonseca wrote: > On 28/09/17 02:46, srol...@vmware.com wrote: >> >> From: Roland Scheidegger >> >> The operation performed is all the same as LODQ, but with the usual >> differences between dx10 and GL texture opcodes, that is separate resource >> and sampler

[Mesa-dev] [Bug 102573] fails to build on armel

2017-09-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102573 --- Comment #8 from Juan A. Suarez --- (In reply to Andreas Boll from comment #7) > Yeah, it's fixed [1]. Please cherry-pick commit 2ef7f23820a for 17.2.2. > Sure. It's on the queue. -- You are receiving this mail because: You are the assig

Re: [Mesa-dev] [Mesa-stable] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Marek Olšák
A clearer comment would be: "Don't destroy the fence when it's in the middle of util_queue_fence_signal (signalled but not unlocked yet because util_queue_fence_is_signalled doesn't lock). Instead, wait until util_queue_fence_signal returns and then destroy it." Reviewed-by: Marek Olšák Marek O

[Mesa-dev] [Bug 102573] fails to build on armel

2017-09-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102573 Andreas Boll changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Eric Engestrom
On Thursday, 2017-09-28 16:10:51 +, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > A tempting alternative fix would be adding a lock/unlock pair in > util_queue_fence_is_signalled. However, that wouldn't actually > improve anything in the semantics of util_queue_fence_is_signalled, > while

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

2017-09-28 Thread Jose Fonseca
On 28/09/17 17:16, Roland Scheidegger wrote: Am 28.09.2017 um 17:53 schrieb Jose Fonseca: On 28/09/17 16:29, Roland Scheidegger wrote: Am 28.09.2017 um 16:12 schrieb Jose Fonseca: On 27/09/17 15:07, Roland Scheidegger wrote: Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: Software rast

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

2017-09-28 Thread Roland Scheidegger
Am 28.09.2017 um 17:53 schrieb Jose Fonseca: > On 28/09/17 16:29, Roland Scheidegger wrote: >> Am 28.09.2017 um 16:12 schrieb Jose Fonseca: >>> On 27/09/17 15:07, Roland Scheidegger wrote: Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: > Software rasterizer and LLVM contain code to

[Mesa-dev] [PATCH] util/queue: fix a race condition in the fence code

2017-09-28 Thread Nicolai Hähnle
From: Nicolai Hähnle A tempting alternative fix would be adding a lock/unlock pair in util_queue_fence_is_signalled. However, that wouldn't actually improve anything in the semantics of util_queue_fence_is_signalled, while making that test much more heavy-weight. So this lock/unlock pair in util_

Re: [Mesa-dev] [RFC v2 0/5] DRI3 v1.2, ANV X11 explicit fences

2017-09-28 Thread Emil Velikov
Hi Louis-Francis, On 28 September 2017 at 09:25, Louis-Francis Ratté-Boulianne wrote: > This patchset makes use of Jason Ekstrand's recent work on SYNC_FD > semaphores and DRI3 v1.2 support for DMA fences: > https://lists.x.org/archives/xorg-devel/2017-September/054770.html > > This is the second

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

2017-09-28 Thread Jose Fonseca
On 28/09/17 16:29, Roland Scheidegger wrote: Am 28.09.2017 um 16:12 schrieb Jose Fonseca: On 27/09/17 15:07, Roland Scheidegger wrote: Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: Software rasterizer and LLVM contain code to enable clipping as soon as a vertex shader writes to gl_Clip

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

2017-09-28 Thread Roland Scheidegger
Am 28.09.2017 um 16:12 schrieb Jose Fonseca: > On 27/09/17 15:07, Roland Scheidegger wrote: >> Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: >>> Software rasterizer and LLVM contain code to enable clipping as soon as >>> a vertex shader writes to gl_ClipDistance, even if the corresponding >

Re: [Mesa-dev] Building Mesa GIT with LLVM prior to 3.9

2017-09-28 Thread Emil Velikov
On 19 September 2017 at 15:23, Vedran Miletić wrote: > On 09/18/2017 06:00 PM, Emil Velikov wrote: >> Hi all, >> >> As you may know, different components in Mesa use LLVM for various purposes. >> >> In particular: >> - 3.3.0 for the aux gallium module, gallivm >> - 3.6.0 for the opencl state-tra

[Mesa-dev] [Bug 102573] fails to build on armel

2017-09-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102573 --- Comment #6 from Juan A. Suarez --- Patches landed in master https://patchwork.freedesktop.org/series/30551/ Is this fixed? -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH v2 9/9] egl/tizen: add support of dri_image_loader

2017-09-28 Thread Emil Velikov
On 17 September 2017 at 19:01, Gwan-gyeong Mun wrote: > It adds support of dri_image_loader to egl dri2 tizen backend. >- referenced a basic buffer flow and management implementation from > android's. > > It adds dri_image_back/dri_image_back member variables to dri_egl_surface for > a manag

Re: [Mesa-dev] [PATCH v2 6/9] egl/tizen: add tizen specific implementations for BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL

2017-09-28 Thread Emil Velikov
On 17 September 2017 at 19:01, Gwan-gyeong Mun wrote: > Tizen platform (actually WL_TBM protocol) internally processes similiar > actions > such as mesa's > BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL. > So the platform_tizen.c needs to implemment BindWaylandDisplayWL, > Unb

Re: [Mesa-dev] [PATCH v2 5/9] egl/tizen: add support of dri2_loader

2017-09-28 Thread Emil Velikov
On 17 September 2017 at 19:01, Gwan-gyeong Mun wrote: > It adds support of dri2_loader to egl dri2 tizen backend. > - referenced a basic buffer flow and management implementation from > android. > > And it implements a query buffer age extesion for tizen and turn on > swap_buffers_with_damage

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

2017-09-28 Thread Jose Fonseca
On 27/09/17 15:07, Roland Scheidegger wrote: Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: Software rasterizer and LLVM contain code to enable clipping as soon as a vertex shader writes to gl_ClipDistance, even if the corresponding clip planes are disabled. GLSL specification states that

Re: [Mesa-dev] [PATCH] gallium: add new LOD opcode

2017-09-28 Thread Nicolai Hähnle
On 28.09.2017 03:46, srol...@vmware.com wrote: From: Roland Scheidegger The operation performed is all the same as LODQ, but with the usual differences between dx10 and GL texture opcodes, that is separate resource and sampler indices (plus result swizzling, and setting z/w channels to zero).

Re: [Mesa-dev] [PATCH v2 4/9] configure.ac: Add tizen to supported platforms

2017-09-28 Thread Emil Velikov
On 17 September 2017 at 19:01, Gwan-gyeong Mun wrote: > @@ -1736,6 +1736,11 @@ for plat in $platforms; do > DEFINES="$DEFINES -DHAVE_ANDROID_PLATFORM" > ;; > > +tizen) > +PKG_CHECK_MODULES([TIZEN], [tpl-egl libtbm libtdm]) > +DEFINES="$DEFINES -DHAVE_TIZEN_PL

Re: [Mesa-dev] [PATCH v2 3/9] egl/tizen: add support of the swrast related features for tizen platform

2017-09-28 Thread Emil Velikov
On 17 September 2017 at 19:01, Gwan-gyeong Mun wrote: > It implements the egl swrast related features for tizen platform on > platform_tizen.c > > It works with libtpl-egl (Tizen Porting Layer for egl) and libtbm (Tizen > Buffer Manager) > where back buffers of windows are backed by GEM objects.

Re: [Mesa-dev] [PATCH] gallium: add new LOD opcode

2017-09-28 Thread Jose Fonseca
On 28/09/17 02:46, srol...@vmware.com wrote: From: Roland Scheidegger The operation performed is all the same as LODQ, but with the usual differences between dx10 and GL texture opcodes, that is separate resource and sampler indices (plus result swizzling, and setting z/w channels to zero). ---

Re: [Mesa-dev] [PATCH v2 1/9] egl: add a treatment of tizen platform on egl display

2017-09-28 Thread Emil Velikov
On 17 September 2017 at 19:00, Gwan-gyeong Mun wrote: > It adds a _EGL_PLATFORM_TIZEN enum value to _EGLPlatformType for tizen > platform. > > It adds a detecting routine of tizen platform to > _eglNativePlatformDetectNativeDisplay() > and _eglGetNativePlatform(). > - As tizen platform interna

Re: [Mesa-dev] [PATCH v2 0/9] Introduce supporting of Tizen to mesa's egl platform

2017-09-28 Thread Emil Velikov
Hi Gwan-gyeong Mun On 17 September 2017 at 19:00, Gwan-gyeong Mun wrote: > Hi, > > these commit series modified some items from previous version. > > 1. patches are seperated by feature implementation. > 2. remove unclearly relevant pbuffer surface-creation code. > 3. refactored for removing dupl

[Mesa-dev] [PATCH mesa] REVIEWERS: add Meson

2017-09-28 Thread Eric Engestrom
Cc: Dylan Baker Signed-off-by: Eric Engestrom --- REVIEWERS | 5 + 1 file changed, 5 insertions(+) diff --git a/REVIEWERS b/REVIEWERS index 0b5d9a4fd31bd652cf02..0d97b29309cc98b9a295 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -103,6 +103,11 @@ F: CleanSpec.mk F: */Android.*mk F: */Makefile

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-09-28 Thread Emil Velikov
On 20 September 2017 at 15:06, Daniel Stone wrote: > Hi Emil, > > On 19 September 2017 at 11:25, Emil Velikov wrote: >> On 15 September 2017 at 16:41, Daniel Stone wrote: >>> On 15 September 2017 at 16:13, Emil Velikov >>> wrote: Right, I'm looking through both functions and I'm strugglin

Re: [Mesa-dev] [Libclc-dev] opencl-example: didn't compile (run) with latest LLVM git (for some days)

2017-09-28 Thread Dieter Nützel
Hello Jan, hello Emil, I've found it. It isn't a LLVM but a Mesa clover build problem. After Jan pointed me to build clover with --enable-opencl_icd switch in mesa to create an ICD driver (libMesaOpenCL.so) and the corresponding vendors file (installed as /etc/OpenCL/vendors/mesa.icd) libOp

Re: [Mesa-dev] [PATCH v2 3/3] etnaviv: optimize RS transfers

2017-09-28 Thread Wladimir J. van der Laan
On Fri, Sep 22, 2017 at 11:31:51AM +0200, Lucas Stach wrote: > Currently we are blitting the whole resource when the RS is used to > de-/tile a resource. This can be very inefficient for large resources > where the transfer is only changing a small part of the resource > (happens a lot with glTexSu

Re: [Mesa-dev] [PATCH v2 1/3] etnaviv: support tile aligned RS blits

2017-09-28 Thread Wladimir J. van der Laan
On Fri, Sep 22, 2017 at 11:31:49AM +0200, Lucas Stach wrote: > The RS can blit abitrary tile aligned subregions of a resource by > adjusting the buffer offset. > > Signed-off-by: Lucas Stach > --- > v2: > - add asserts, so we catch any invalid use of the RS > - split out tile mask computation, to

Re: [Mesa-dev] [PATCH v3 1/2] etnaviv: fix varying interpolation

2017-09-28 Thread Lucas Stach
Hi Wladimir, Am Dienstag, den 26.09.2017, 16:20 +0200 schrieb Wladimir J. van der Laan: > Hello Lucas, > > On Fri, Sep 22, 2017 at 11:27:36AM +0200, Lucas Stach wrote: > > It seems that newer cores don't use the PA_ATTRIBUTES to decide if > > the > > varying should bypass the flat shading, but de

Re: [Mesa-dev] [PATCH v2] i965: skip reading clip distances from the URB for the FS if possible

2017-09-28 Thread Iago Toral
On Thu, 2017-09-28 at 07:24 -0400, Ilia Mirkin wrote: > On Thu, Sep 28, 2017 at 6:33 AM, Iago Toral Quiroga m> wrote: > > we can skip these slots when they are not read in the fragment > > shader > > and they are positioned right after a VUE header that we are > > already > > skipping. We also nee

Re: [Mesa-dev] [PATCH v2] i965: skip reading clip distances from the URB for the FS if possible

2017-09-28 Thread Ilia Mirkin
On Thu, Sep 28, 2017 at 6:33 AM, Iago Toral Quiroga wrote: > we can skip these slots when they are not read in the fragment shader > and they are positioned right after a VUE header that we are already > skipping. We also need to ensure that we are passing at least one other > varying, since that

[Mesa-dev] [PATCH v2] i965: skip reading clip distances from the URB for the FS if possible

2017-09-28 Thread Iago Toral Quiroga
we can skip these slots when they are not read in the fragment shader and they are positioned right after a VUE header that we are already skipping. We also need to ensure that we are passing at least one other varying, since that is a hardware requirement. This helps alleviate a problem introduce

Re: [Mesa-dev] [PATCH 00/22] RFC: Batchbuffer Logger for Intel GPU

2017-09-28 Thread Rogovin, Kevin
Hi all, Just a gentle poke. Even though a serious issue was already found by Chris Wilson on batchbuffer migration, I would like for folks to look at the series (in particular the monster patch 16) and give comments. With those comments I will then create a v2 (indeed I've already implemented

[Mesa-dev] [RFC v2 4/5] vulkan: Add support for out-fences in vkAcquireNextImage

2017-09-28 Thread Louis-Francis Ratté-Boulianne
Signed-off-by: Louis-Francis Ratté-Boulianne --- src/vulkan/wsi/wsi_common.h | 3 + src/vulkan/wsi/wsi_common_x11.c | 152 +++- 2 files changed, 121 insertions(+), 34 deletions(-) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h ind

[Mesa-dev] [RFC v2 2/5] vulkan: Check whether X server supports DMA fences

2017-09-28 Thread Louis-Francis Ratté-Boulianne
Signed-off-by: Louis-Francis Ratté-Boulianne --- src/vulkan/wsi/wsi_common_x11.c | 46 + 1 file changed, 46 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index 4569c928c8..d9467092d2 100644 --- a/src/vulkan/ws

[Mesa-dev] [RFC v2 1/5] egl: Support EGL sync objects with OpenGL API

2017-09-28 Thread Louis-Francis Ratté-Boulianne
Signed-off-by: Louis-Francis Ratté-Boulianne --- src/egl/main/eglapi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 41a2a1a9d8..ca2e90cdf0 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1769,9 +1

[Mesa-dev] [RFC v2 3/5] vulkan: Add support for in-fences for vkQueuePresent

2017-09-28 Thread Louis-Francis Ratté-Boulianne
Allow drivers to add a list of semaphores to wait on when queuing a image to present. Signed-off-by: Louis-Francis Ratté-Boulianne --- src/amd/vulkan/radv_wsi.c | 2 +- src/intel/vulkan/anv_wsi.c | 2 ++ src/vulkan/wsi/wsi_common.h | 6 + src/vulkan/wsi/wsi_comm

[Mesa-dev] [RFC v2 5/5] anv: Implement wsi get_semaphores_fd and import_semaphore

2017-09-28 Thread Louis-Francis Ratté-Boulianne
Signed-off-by: Louis-Francis Ratté-Boulianne --- src/intel/vulkan/anv_wsi.c | 121 - 1 file changed, 119 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index 2e05c3b07b..1e8e507d99 100644 --- a/src/in

[Mesa-dev] [RFC v2 0/5] DRI3 v1.2, ANV X11 explicit fences

2017-09-28 Thread Louis-Francis Ratté-Boulianne
This patchset makes use of Jason Ekstrand's recent work on SYNC_FD semaphores and DRI3 v1.2 support for DMA fences: https://lists.x.org/archives/xorg-devel/2017-September/054770.html This is the second version of this patchset. For more context, see: https://lists.freedesktop.org/archives/mesa-dev

[Mesa-dev] [PATCH v3] i965/fs: force pull model for 64-bit GS inputs

2017-09-28 Thread Iago Toral Quiroga
Triggering the push model when 64-bit inputs are involved is not easy due to the constrains on the maximum number of registers that we allow for this mode, however, for GS with 'points' primitive type and just a couple of double varyings we can trigger this and it just doesn't work because the impl

Re: [Mesa-dev] [RFC v3 13/23] vulkan/wsi: Move linear alloc into radv

2017-09-28 Thread Daniel Stone
Hi, On 28 September 2017 at 09:10, Dave Airlie wrote: > If we get a nouveauv ever we would have to have this, so not really wanting > this. Thanks for taking a look. The reason I did this wasn't just to get it out of the WSI, but because we need it in the driver anyway. Without modifiers, it's

Re: [Mesa-dev] [PATCH v2] i965/fs: force pull model for 64-bit GS inputs

2017-09-28 Thread Iago Toral
On Thu, 2017-09-28 at 00:59 -0700, Kenneth Graunke wrote: > On Thursday, September 28, 2017 12:36:27 AM PDT Iago Toral Quiroga > wrote: > > Triggering the push model when 64-bit inputs are involved is not > > easy due to > > the constrains on the maximum number of registers that we allow for > > th

  1   2   >